D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 77976.
cblack added a comment.


  Improve documentation comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=77975=77976

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 77975.
cblack added a comment.


  Better class description

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=77974=77975

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 77974.
cblack added a comment.


  Add comments to code

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=77973=77974

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 77973.
cblack added a comment.


  Use words instead of single letters

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=77972=77973

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=376301

--- Comment #3 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 77972.
cblack added a comment.


  Add EOF newlines

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=77971=77972

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28134: Add ColorUtils

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  ColorUtils is a class that offers utilities for working with colour, offering 
the following items as a start:
  
  - `QColor averageColorForItem(QQuickItem*, int)` - Obtains the average colour 
of an item, ignoring transparent pixels
  - `Brightness brightnessForItem(QQuickItem*)` - Obtains the brightness of an 
item

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=345440

--- Comment #4 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=366488

--- Comment #3 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, jriddell.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch allows you to switch the timezone by clicking on your desired one 
in the
  applet's expanded representation. This is much simpler than the 
mouse-wheel-based UI and
  does not need a config setting to turn it on or off.

TEST PLAN
  F8183863: vokoscreenNG-2020-03-18_22-13-21.webm 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  switch-timezones-by-clicking (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28133

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: ngraham, #vdg, #plasma, jriddell
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28126: Fix crash, the e-mail client service can be null

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8a0bcc24fdb8: Fix crash, the e-mail client service can be 
null (authored by apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28126?vs=77917=77967

REVISION DETAIL
  https://phabricator.kde.org/D28126

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp

To: apol, meven, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28035: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77966.
ngraham added a comment.


  Remove now-unnecessary imports

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28035?vs=77937=77966

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28035

AFFECTED FILES
  CMakeLists.txt
  plasma/package/contents/ui/ActionItem.qml
  plasma/package/contents/ui/VaultItem.qml
  plasma/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ivan
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27935: Make kwallet-pam work with pam_fscrypt

[Albert Astals Cid]

aacid updated this revision to Diff 77963.
aacid added a comment.


  restore the code that calls pam_sm_open_session from pam_sm_authenticate if 
they were called "out of order"

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27935?vs=77232=77963

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27935

AFFECTED FILES
  pam_kwallet.c

To: aacid
Cc: sitter, security-team, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26956: Remove export header from static install

[Mason McParlane]

masonm requested review of this revision.
masonm added a comment.


  Hello,
  
  Just following up on this change review—it all looks good to me. Can we merge 
it in?
  
  Thanks!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26956

To: masonm, #kirigami, mart, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 775 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/775/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 18 Mar 2020 19:34:41 +
 Build duration:
1 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 2538 lines...][2020-03-18T19:36:16.709Z] [ 52%] Generating ui_statusnotifiertest.h[2020-03-18T19:36:16.967Z] Scanning dependencies of target statusnotifiertest[2020-03-18T19:36:16.967Z] [ 52%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest_autogen/mocs_compilation.cpp.o[2020-03-18T19:36:16.967Z] [ 52%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/main.cpp.o[2020-03-18T19:36:16.967Z] [ 52%] Built target plasma_applet_calendar[2020-03-18T19:36:16.967Z] [ 53%] Linking CXX shared module ../../bin/krunner_windows.so[2020-03-18T19:36:16.967Z] Scanning dependencies of target plasma_engine_applicationjobs_autogen[2020-03-18T19:36:16.967Z] [ 53%] Linking CXX shared module ../../../bin/plasma_applet_appmenu.so[2020-03-18T19:36:16.967Z] [ 54%] Generating plasma-dataengine-applicationjobs.json[2020-03-18T19:36:16.967Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"[2020-03-18T19:36:16.967Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-03-18T19:36:16.967Z] Generated  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/dataengines/applicationjobs/plasma-dataengine-applicationjobs.json"[2020-03-18T19:36:16.967Z] [ 54%] Building CXX object applets/panelspacer/plugin/CMakeFiles/org.kde.plasma.panelspacer.dir/panelspacer.cpp.o[2020-03-18T19:36:16.967Z] [ 54%] Automatic MOC for target plasma_engine_applicationjobs[2020-03-18T19:36:17.225Z] [ 54%] Built target kcm_krunner_kill[2020-03-18T19:36:17.225Z] [ 54%] Generating ActivityRankingInterface.cpp, ActivityRankingInterface.h[2020-03-18T19:36:17.225Z] [ 54%] Generating ActivityRankingInterface.moc[2020-03-18T19:36:17.484Z] [ 54%] Built target plasma_engine_applicationjobs_autogen[2020-03-18T19:36:17.484Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest.cpp.o[2020-03-18T19:36:17.484Z] Scanning dependencies of target plasma_engine_activities[2020-03-18T19:36:17.484Z] [ 55%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/plasma_engine_activities_autogen/mocs_compilation.cpp.o[2020-03-18T19:36:17.484Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/pumpjob.cpp.o[2020-03-18T19:36:17.484Z] [ 55%] Built target krunner_windows[2020-03-18T19:36:17.484Z] [ 55%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/timezonesi18n.cpp.o[2020-03-18T19:36:17.744Z] [ 55%] Built target plasma_applet_appmenu[2020-03-18T19:36:17.744Z] [ 55%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/digitalclockplugin.cpp.o[2020-03-18T19:36:17.744Z] [ 55%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/systemtraycontainer.cpp.o[2020-03-18T19:36:17.744Z] [ 55%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtraymodel.cpp.o[2020-03-18T19:36:18.004Z] [ 55%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/debug.cpp.o[2020-03-18T19:36:18.264Z] Scanning dependencies of target plasma_engine_apps[2020-03-18T19:36:18.264Z] [ 55%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/plasma_engine_apps_autogen/mocs_compilation.cpp.o[2020-03-18T19:36:18.264Z] [ 56%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/globalshortcuts.cpp.o[2020-03-18T19:36:18.524Z] [ 56%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/thumbnailer.cpp.o[2020-03-18T19:36:18.783Z] [ 56%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsengine.cpp.o[2020-03-18T19:36:18.783Z] [ 56%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/clipboardmenu.cpp.o[2020-03-18T19:36:19.041Z] [ 56%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsource.cpp.o[2020-03-18T19:36:19.041Z] Scanning dependencies of target plasma_engine_devicenotifications[2020-03-18T19:36:19.299Z] [ 57%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/plasma_engine_devicenotifications_autogen/mocs_compilation.cpp.o[2020-03-18T19:36:19.299Z] [ 57%] Linking CXX executable ../../../../bin/statusnotifiertest[2020-03-18T19:36:19.299Z] [ 57%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/ActivityData.cpp.o[2020-03-18T19:36:19.559Z] [ 57%] Linking CXX 

D28104: [applets/digital-clock] Increase size of calendar in pop-up

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:86f0e49150e7: [applets/digital-clock] Increase size of 
calendar in pop-up (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28104?vs=77849=77960

REVISION DETAIL
  https://phabricator.kde.org/D28104

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: ngraham, #vdg, broulik, mart, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:b060c853b4cd: Fix disabeling of autolock timeout 
(authored by alex, committed by ngraham).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27063?vs=74787=77958

REVISION DETAIL
  https://phabricator.kde.org/D27063

AFFECTED FILES
  kcm/kcm.ui

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 774 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/774/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 18 Mar 2020 18:48:08 +
 Build duration:
5 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 2347 lines...][2020-03-18T18:53:04.932Z] [ 41%] Linking CXX shared module ../../bin/plasma_engine_executable.so[2020-03-18T18:53:04.932Z] [ 41%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/dictengine.cpp.o[2020-03-18T18:53:04.932Z] [ 41%] Building CXX object dataengines/favicons/CMakeFiles/plasma_engine_favicons.dir/faviconprovider.cpp.o[2020-03-18T18:53:04.932Z] [ 41%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/devicenotificationsengine.cpp.o[2020-03-18T18:53:04.932Z] [ 41%] Generating ActivityRankingInterface.cpp, ActivityRankingInterface.h[2020-03-18T18:53:04.932Z] Scanning dependencies of target plasma_engine_apps[2020-03-18T18:53:04.932Z] [ 41%] Generating ActivityRankingInterface.moc[2020-03-18T18:53:04.932Z] [ 41%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/plasma_engine_apps_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:04.932Z] Scanning dependencies of target plasma_engine_activities[2020-03-18T18:53:05.192Z] [ 41%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/plasma_engine_activities_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:05.192Z] [ 41%] Built target plasma_engine_executable[2020-03-18T18:53:05.192Z] [ 41%] Generating ui_statusnotifiertest.h[2020-03-18T18:53:05.192Z] [ 41%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsengine.cpp.o[2020-03-18T18:53:05.192Z] Scanning dependencies of target org.kde.plasma.systemtray[2020-03-18T18:53:05.192Z] Scanning dependencies of target statusnotifiertest[2020-03-18T18:53:05.192Z] [ 41%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/org.kde.plasma.systemtray_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:05.192Z] [ 41%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:05.192Z] [ 41%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/main.cpp.o[2020-03-18T18:53:06.130Z] [ 41%] Linking CXX shared library ../../../bin/libdigitalclockplugin.so[2020-03-18T18:53:06.388Z] Scanning dependencies of target plasma_applet_notifications[2020-03-18T18:53:06.388Z] Scanning dependencies of target org.kde.plasma.private.systemtray[2020-03-18T18:53:06.388Z] [ 41%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/plasma_applet_notifications_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:06.388Z] [ 41%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/org.kde.plasma.private.systemtray_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:06.654Z] [ 41%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/ksolidnotify.cpp.o[2020-03-18T18:53:06.654Z] [ 41%] Linking CXX shared module ../../bin/plasma_engine_favicons.so[2020-03-18T18:53:06.654Z] [ 41%] Linking CXX shared module ../../bin/plasma_engine_dict.so[2020-03-18T18:53:06.654Z] [ 41%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsource.cpp.o[2020-03-18T18:53:06.654Z] [ 41%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appservice.cpp.o[2020-03-18T18:53:07.229Z] [ 41%] Built target digitalclockplugin[2020-03-18T18:53:07.229Z] [ 41%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/systemtraycontainer.cpp.o[2020-03-18T18:53:07.229Z] Scanning dependencies of target org.kde.plasma.panelspacer[2020-03-18T18:53:07.229Z] [ 41%] Built target plasma_engine_favicons[2020-03-18T18:53:07.229Z] [ 42%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest.cpp.o[2020-03-18T18:53:07.229Z] [ 42%] Building CXX object applets/panelspacer/plugin/CMakeFiles/org.kde.plasma.panelspacer.dir/org.kde.plasma.panelspacer_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:07.229Z] Scanning dependencies of target plasma_engine_filebrowser[2020-03-18T18:53:07.229Z] [ 42%] Building CXX object applets/panelspacer/plugin/CMakeFiles/org.kde.plasma.panelspacer.dir/panelspacer.cpp.o[2020-03-18T18:53:07.229Z] [ 42%] Building CXX object dataengines/filebrowser/CMakeFiles/plasma_engine_filebrowser.dir/plasma_engine_filebrowser_autogen/mocs_compilation.cpp.o[2020-03-18T18:53:07.489Z] [ 42%] Built target plasma_engine_dict[2020-03-18T18:53:07.489Z] [ 42%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/pumpjob.cpp.o[2020-03-18T18:53:07.748Z] 

D28132: [Calculator Runner] Minor code optimisation

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation 
(authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28132?vs=77945=77957

REVISION DETAIL
  https://phabricator.kde.org/D28132

AFFECTED FILES
  runners/calculator/calculatorrunner.cpp

To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[David Redondo]

davidre added a comment.


  It seems it is possible to do this (removing stuff from the data engine) 
after all. I will try to work on this in the next time

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[David Redondo]

davidre added a comment.


  It seems it is possible to do this (removing stuff from the data engine) 
after all. I will try to work on this in the next time

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack updated this revision to Diff 77950.
cblack marked 4 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=77930=77950

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28132: [Calculator Runner] Minor code optimisation

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Remove redunant QString::contains() checks.
  
  Create one QRegularExpression object and use setPattern().

TEST PLAN
  make && ctest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-calcrun (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28132

AFFECTED FILES
  runners/calculator/calculatorrunner.cpp

To: ahmadsamir, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Kevin Ottens]

ervin added a comment.


  Ah didn't know! I assumed you could push... But yeah, you authored a few 
patches now, time to apply for a developer account. You can put my name indeed.

REPOSITORY
  R133 KScreenLocker

BRANCH
  fix_disabled_state

REVISION DETAIL
  https://phabricator.kde.org/D27063

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Alexander Lohnau]

alex added a comment.


  I don't have a developer account, but I am going to apply for one.
  May I enter your name as a supporter?

REPOSITORY
  R133 KScreenLocker

BRANCH
  fix_disabled_state

REVISION DETAIL
  https://phabricator.kde.org/D27063

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Kevin Ottens]

ervin added a comment.


  Well, I already accepted it, I thought you pushed long ago (and I suspect it 
got overlooked by the other potential reviewers). :-)

REPOSITORY
  R133 KScreenLocker

BRANCH
  fix_disabled_state

REVISION DETAIL
  https://phabricator.kde.org/D27063

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28103: Support multiple stacked Passive Notifications

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in PassiveNotification.qml:35
> Just `padding`?

actually, it would make the implicitHeight calculation fail (it's dumb like 
that and that's why for the new property inset they only added leftInset 
topInset etcand not a simple inset one)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28103: Support multiple stacked Passive Notifications

[Marco Martin]

mart updated this revision to Diff 77942.
mart marked 2 inline comments as done.
mart added a comment.


  - fix quick spawning of notifications

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77934=77942

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28103: Support multiple stacked Passive Notifications

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PassiveNotification.qml:26
> +
> +x: parent.width/2 - width/2
> +y: parent.height - height - Kirigami.Units.smallSpacing

`Math.round` please

> PassiveNotification.qml:35
> +
> +topPadding: Kirigami.Units.smallSpacing
> +leftPadding: Kirigami.Units.smallSpacing

Just `padding`?

> PassiveNotification.qml:62
>  
> -// Only start the timer when the window has focus, to ensure that
> -// messages don't get missed on the desktop where it's common to
> -//be working with multiple windows at once
> -timer.running = Qt.binding(function() {
> -return root.Window.active;
> +if (outerLayout.children.length > 3) {
> +outerLayout.children[0].close();

When I rapidly create new passive popups, I can exceed the limit. Maybe it 
needs a `while` loop where it closes without animation or something

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D28037: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77938.
ngraham added a comment.


  ExpandableListItem is now in PlasmaExtras

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28037?vs=77700=77938

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28037

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28035: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77937.
ngraham added a comment.


  ExpandableListItem is now in PlasmaExtras

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28035?vs=77699=77937

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28035

AFFECTED FILES
  CMakeLists.txt
  plasma/package/contents/ui/ActionItem.qml
  plasma/package/contents/ui/VaultItem.qml
  plasma/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ivan
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77936.
ngraham added a comment.


  ExpandableListItem is now in PlasmaExtras

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28034?vs=77704=77936

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28034

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: ngraham, #vdg, #plasma, jgrulich
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart updated this revision to Diff 77934.
mart added a comment.


  - export the item
  - support multiple notifications
  - make it a private component again
  - fix passive notifications for ApplciationItem

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77901=77934

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 773 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/773/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 18 Mar 2020 16:08:17 +
 Build duration:
2 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 2558 lines...][2020-03-18T16:11:08.132Z] [ 53%] Built target plasma_applet_calendar[2020-03-18T16:11:08.132Z] [ 53%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/notificationapplet.cpp.o[2020-03-18T16:11:08.132Z] Scanning dependencies of target statusnotifiertest[2020-03-18T16:11:08.132Z] [ 53%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest_autogen/mocs_compilation.cpp.o[2020-03-18T16:11:08.132Z] [ 53%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/main.cpp.o[2020-03-18T16:11:08.132Z] Scanning dependencies of target plasma_engine_applicationjobs_autogen[2020-03-18T16:11:08.132Z] [ 54%] Generating plasma-dataengine-applicationjobs.json[2020-03-18T16:11:08.132Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"[2020-03-18T16:11:08.132Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-03-18T16:11:08.132Z] Generated  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/dataengines/applicationjobs/plasma-dataengine-applicationjobs.json"[2020-03-18T16:11:08.132Z] [ 54%] Automatic MOC for target plasma_engine_applicationjobs[2020-03-18T16:11:08.132Z] [ 54%] Linking CXX shared module ../../../bin/plasma_applet_appmenu.so[2020-03-18T16:11:08.390Z] [ 54%] Built target plasma_engine_applicationjobs_autogen[2020-03-18T16:11:08.390Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest.cpp.o[2020-03-18T16:11:08.390Z] [ 55%] Building CXX object applets/panelspacer/plugin/CMakeFiles/org.kde.plasma.panelspacer.dir/panelspacer.cpp.o[2020-03-18T16:11:08.648Z] [ 55%] Built target plasma_applet_appmenu[2020-03-18T16:11:08.648Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/pumpjob.cpp.o[2020-03-18T16:11:08.906Z] [ 55%] Generating ActivityRankingInterface.cpp, ActivityRankingInterface.h[2020-03-18T16:11:08.906Z] [ 55%] Generating ActivityRankingInterface.moc[2020-03-18T16:11:08.906Z] Scanning dependencies of target plasma_engine_apps[2020-03-18T16:11:08.906Z] [ 55%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/plasma_engine_apps_autogen/mocs_compilation.cpp.o[2020-03-18T16:11:08.906Z] Scanning dependencies of target plasma_engine_activities[2020-03-18T16:11:08.906Z] [ 55%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/plasma_engine_activities_autogen/mocs_compilation.cpp.o[2020-03-18T16:11:08.906Z] [ 55%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/systemtraycontainer.cpp.o[2020-03-18T16:11:09.164Z] Scanning dependencies of target plasma_engine_devicenotifications[2020-03-18T16:11:09.164Z] [ 56%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/plasma_engine_devicenotifications_autogen/mocs_compilation.cpp.o[2020-03-18T16:11:09.422Z] [ 56%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/sortedsystemtraymodel.cpp.o[2020-03-18T16:11:09.422Z] Scanning dependencies of target plasma_engine_dict[2020-03-18T16:11:09.422Z] [ 56%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/plasma_engine_dict_autogen/mocs_compilation.cpp.o[2020-03-18T16:11:09.679Z] [ 56%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsengine.cpp.o[2020-03-18T16:11:09.679Z] [ 56%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/ActivityData.cpp.o[2020-03-18T16:11:09.936Z] [ 56%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/filemenu.cpp.o[2020-03-18T16:11:09.936Z] [ 56%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/devicenotificationsengine.cpp.o[2020-03-18T16:11:09.936Z] [ 56%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/ksolidnotify.cpp.o[2020-03-18T16:11:10.193Z] [ 56%] Linking CXX executable ../../../../bin/statusnotifiertest[2020-03-18T16:11:10.450Z] [ 56%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/dictengine.cpp.o[2020-03-18T16:11:10.450Z] [ 56%] Linking CXX shared module ../../../bin/org.kde.plasma.panelspacer.so[2020-03-18T16:11:10.450Z] [ 56%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtray.cpp.o[2020-03-18T16:11:10.450Z] [ 56%] Building CXX object 

D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f444ebe595a2: Port some usage of QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=77906=77932

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> calculatorrunner.cpp:199
>  
> -if (cmd.contains(QRegExp(QStringLiteral("\\d+and\\d+" {
> - cmd.replace(QRegExp(QStringLiteral("(\\d+)and(\\d+)")), 
> QStringLiteral("\\1&\\2"));
> +if (cmd.contains(QRegularExpression(QStringLiteral("\\d+and\\d+" {
> + cmd.replace(QRegularExpression(QStringLiteral("(\\d+)and(\\d+)")), 
> QStringLiteral("\\1&\\2"));

If you could look into de-duplicating these QRegularExpressions in a separate 
patch, that would be awesome.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol planned changes to this revision.
apol added a comment.


  Just tested it properly, it fails to generate a backtrace altogether :(

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28129

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack updated this revision to Diff 77930.
cblack added a comment.


  Drop unused linkage

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=77924=77930

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  <3

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28129

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, broulik, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This way if we're linking against an old KF5, we still generate a backtrace

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Alexander Lohnau]

alex added a comment.


  Ping.

REPOSITORY
  R133 KScreenLocker

BRANCH
  fix_disabled_state

REVISION DETAIL
  https://phabricator.kde.org/D27063

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> CMakeLists.txt:60
>  Qt5::X11Extras
> +XCB::XCB
>  KF5::IconThemes)

Unused

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik added a comment.


  Nice job

INLINE COMMENTS

> abstracttasksmodel.h:99
>  LastActivated,/**< The timestamp of the last time a task was the 
> active task. */
> +ApplicationMenuServiceName, /**< The DBus service name for the 
> application's menu.
> + May be empty. */

`@since 5.19`

> xwindowtasksmodel.cpp:25
>  #include "xwindowsystemeventbatcher.h"
> +#include 
>  

Unused

> xwindowtasksmodel.cpp:48
>  
> +#include "xcb/xcb.h"
> +

Unused

> xwindowtasksmodel.cpp:473
> +// returns QPair for WId window
> +QPair XWindowTasksModel::Private::appMenu(WId window)
> +{

I think this should be split into two dedicated methods to match the rest

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28109: [applets/systemtray] Simplify icon size logic

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added subscribers: davidedmundson, mart.
ngraham added a comment.
This revision is now accepted and ready to land.


  This looks like a sensible refactor to me, and it solves the issue that I was 
having with icon size changing based on the expanded popup visibility. I can't 
detect any regressions in sizing with horizontal or vertical panels of various 
sizes. However please wait to land this until somebody else possessing greater 
familiarity with this codebase such as @broulik, @mart, or @davidedmundson 
reviews it too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28109

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack updated this revision to Diff 77924.
cblack added a comment.


  Use new KWindowInfo APIs

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=77835=77924

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27935: Make kwallet-pam work with pam_fscrypt

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> aacid wrote in pam_kwallet.c:329
> > How about leaving it in for 5.18 and drop it for master?
> >  Should there be an unexpected problem we'll at least have months of 
> > theoretical testing and a shorter window from 5.19.0 to .1 to hotfix a > 
> > potential regression.
> 
> Doesn't sound very convincing to me, if there's going to be a regression i'd 
> prefer it to be this month when i still remember this code and i still use 
> kwallet-pam and pam_fscrypt, if you delay it to 5.19.0 or something I will 
> not totally remember this code and may not be using this any of those two 
> either os my motivation to fix it may be pretty small.
> 
> I can try adding the code that makes pam_sm_open_session from here if you 
> think it makes sense to have it

That is a fair point but I for one cannot +1 this diff as-is. So, I would 
prefer the pam_sm_open_session call making a return.

Or someone else gives a +1, I don't profoundly object to the diff, but it is in 
my mind not suitable for a stable release right now:
Currently in 5.18 one can call session before auth and it works. With this diff 
that'd be no longer the case and a behavioral change in a stable release 
update. I have no idea if that has real life implications but I can totally 
imagine one of our enterprise users pulling weird stuff like that.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D27935

To: aacid
Cc: sitter, security-team, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jjorge requested review of this revision.

REVISION SUMMARY
  Depending on hardware, Linux kernel exports battery state in
  different files. Previously only charge_now, charge_full and current_now
  were available in ksysguard. With this commit all are selectable.
  
  While we have now screens with more than 1000 pixels height,
  a percentage with 100 steps will show a ladder. This commit also
  make the created graphs nicer by giving 1000 steps.

REPOSITORY
  R106 KSysguard

BRANCH
  AddSysBatteryInfo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28127

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h

To: jjorge
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  In D27199#629881 , @manueljlin 
wrote:
  
  > In D27199#627422 , @gvgeo wrote:
  >
  > > Differently sized icons are about to be restored in D28034 
.
  >
  >
  > Nice! Thanks
  
  
  You should thank @ngraham. He is the one making these small changes, 
including the password field size, in that patch.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/73/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 18 Mar 2020 14:21:33 +
 Build duration:
4 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 294 lines...][2020-03-18T14:26:07.713Z]  * KF5Completion (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-18T14:26:07.713Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-18T14:26:07.713Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * Qt5Core (required version >= 5.12.0)[2020-03-18T14:26:07.713Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-18T14:26:07.713Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * KF5 (required version >= 5.69.0)[2020-03-18T14:26:07.713Z]  * Qt5Test[2020-03-18T14:26:07.713Z] [2020-03-18T14:26:07.713Z] -- The following features have been disabled:[2020-03-18T14:26:07.713Z] [2020-03-18T14:26:07.713Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-18T14:26:07.713Z] [2020-03-18T14:26:07.713Z] -- Configuring done[2020-03-18T14:26:07.972Z] -- Generating done[2020-03-18T14:26:07.972Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-18T14:26:08.723Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project drkonqi --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-18T14:26:08.723Z] Scanning dependencies of target crashtest_autogen[2020-03-18T14:26:08.723Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2020-03-18T14:26:08.723Z] Scanning dependencies of target qbugzilla_autogen[2020-03-18T14:26:08.723Z] Scanning dependencies of target lsb_release_autogen[2020-03-18T14:26:08.723Z] [  0%] Automatic MOC for target crashtest[2020-03-18T14:26:08.723Z] [  0%] Automatic MOC for target lsb_release[2020-03-18T14:26:08.724Z] [  1%] Automatic MOC for target drkonqi_backtrace_parser[2020-03-18T14:26:08.724Z] [  2%] Automatic MOC for target qbugzilla[2020-03-18T14:26:08.987Z] [  2%] Built target crashtest_autogen[2020-03-18T14:26:08.987Z] [  2%] Built target lsb_release_autogen[2020-03-18T14:26:08.987Z] Scanning dependencies of target lsb_release[2020-03-18T14:26:08.987Z] [  3%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.o[2020-03-18T14:26:08.987Z] [  3%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.o[2020-03-18T14:26:08.987Z] Scanning dependencies of target crashtest[2020-03-18T14:26:08.987Z] [  4%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.o[2020-03-18T14:26:08.987Z] [  4%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.o[2020-03-18T14:26:08.987Z] [  5%] Linking CXX executable ../../bin/lsb_release[2020-03-18T14:26:08.987Z] [  5%] Built target lsb_release[2020-03-18T14:26:09.555Z] [  5%] Built target drkonqi_backtrace_parser_autogen[2020-03-18T14:26:09.555Z] Scanning dependencies of target drkonqi_backtrace_parser[2020-03-18T14:26:09.555Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.o[2020-03-18T14:26:09.555Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.o[2020-03-18T14:26:09.555Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.o[2020-03-18T14:26:09.555Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.o[2020-03-18T14:26:09.555Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.o[2020-03-18T14:26:09.555Z] [  9%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.o[2020-03-18T14:26:09.555Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.o[2020-03-18T14:26:09.555Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.o[2020-03-18T14:26:09.555Z] [ 10%] Built target qbugzilla_autogen[2020-03-18T14:26:09.555Z] Scanning dependencies of target qbugzilla[2020-03-18T14:26:09.821Z] [ 11%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/qbugzilla_autogen/mocs_compilation.cpp.o[2020-03-18T14:26:09.821Z] [ 12%] Building CXX object 

D28126: Fix crash, the e-mail client service can be null

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  I don't get a crash anymore

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28126

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp

To: apol, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27985: Include s_kcrashErrorMessage in our traces

[Kai Uwe Broulik]

broulik added a comment.


  When this symbol isn't present, gdb just aborts and you don't get any back 
trace anymore:
  
Error in sourced command file:
No symbol "s_kcrashErrorMessage" in current context.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D27985

To: apol, #frameworks, sitter
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

zzag updated this revision to Diff 77916.
zzag added a comment.


  Rebase on master

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14910?vs=39945=77916

BRANCH
  arcpatch-D14910

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/CMakeLists.txt
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/72/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 18 Mar 2020 13:49:53 +
 Build duration:
1 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 292 lines...][2020-03-18T13:50:57.800Z]  * KF5Completion (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-18T13:50:57.800Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-18T13:50:57.800Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * Qt5Core (required version >= 5.12.0)[2020-03-18T13:50:57.800Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-18T13:50:57.800Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * KF5 (required version >= 5.69.0)[2020-03-18T13:50:57.800Z]  * Qt5Test[2020-03-18T13:50:57.800Z] [2020-03-18T13:50:57.800Z] -- The following features have been disabled:[2020-03-18T13:50:57.800Z] [2020-03-18T13:50:57.800Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-18T13:50:57.800Z] [2020-03-18T13:50:57.800Z] -- Configuring done[2020-03-18T13:50:59.596Z] -- Generating done[2020-03-18T13:50:59.596Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-18T13:51:00.448Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project drkonqi --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-18T13:51:00.728Z] Scanning dependencies of target lsb_release_autogen[2020-03-18T13:51:00.729Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2020-03-18T13:51:00.729Z] Scanning dependencies of target crashtest_autogen[2020-03-18T13:51:00.729Z] Scanning dependencies of target qbugzilla_autogen[2020-03-18T13:51:00.729Z] [  0%] Automatic MOC for target lsb_release[2020-03-18T13:51:00.729Z] [  0%] Automatic MOC for target crashtest[2020-03-18T13:51:00.729Z] [  1%] Automatic MOC for target drkonqi_backtrace_parser[2020-03-18T13:51:00.729Z] [  2%] Automatic MOC for target qbugzilla[2020-03-18T13:51:00.729Z] [  2%] Built target lsb_release_autogen[2020-03-18T13:51:00.729Z] Scanning dependencies of target lsb_release[2020-03-18T13:51:01.007Z] [  2%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.o[2020-03-18T13:51:01.007Z] [  3%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.o[2020-03-18T13:51:01.007Z] [  3%] Built target crashtest_autogen[2020-03-18T13:51:01.627Z] [  4%] Linking CXX executable ../../bin/lsb_release[2020-03-18T13:51:01.627Z] Scanning dependencies of target crashtest[2020-03-18T13:51:01.627Z] [  4%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.o[2020-03-18T13:51:01.627Z] [  5%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.o[2020-03-18T13:51:02.658Z] [  5%] Built target lsb_release[2020-03-18T13:51:03.246Z] [  5%] Built target drkonqi_backtrace_parser_autogen[2020-03-18T13:51:03.246Z] Scanning dependencies of target drkonqi_backtrace_parser[2020-03-18T13:51:03.246Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.o[2020-03-18T13:51:03.246Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.o[2020-03-18T13:51:03.246Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.o[2020-03-18T13:51:03.246Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.o[2020-03-18T13:51:03.883Z] [  8%] Built target qbugzilla_autogen[2020-03-18T13:51:04.511Z] Scanning dependencies of target qbugzilla[2020-03-18T13:51:04.511Z] [  9%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/qbugzilla_autogen/mocs_compilation.cpp.o[2020-03-18T13:51:05.117Z] [  9%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.o[2020-03-18T13:51:05.400Z] [ 10%] Linking CXX executable ../../../bin/crashtest[2020-03-18T13:51:05.400Z] ld: error: undefined symbol: KCrash::setErrorMessage(QString const&)[2020-03-18T13:51:05.400Z] >>> referenced by crashtest.cpp:92 (/usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/src/tests/crashtest/crashtest.cpp:92)[2020-03-18T13:51:05.400Z] >>>   

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/16/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 18 Mar 2020 13:49:16 +
 Build duration:
54 sec and counting
   CONSOLE OUTPUT
  [...truncated 345 lines...][2020-03-18T13:50:03.042Z]  * KF5ConfigWidgets (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5JobWidgets (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5KIO (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5Crash (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5Completion (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-18T13:50:03.042Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-18T13:50:03.043Z]  * KF5 (required version >= 5.69.0)[2020-03-18T13:50:03.043Z]  * KDEWin[2020-03-18T13:50:03.043Z]  * Qt5Test[2020-03-18T13:50:03.043Z] [2020-03-18T13:50:03.043Z] -- The following features have been disabled:[2020-03-18T13:50:03.043Z] [2020-03-18T13:50:03.043Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-18T13:50:03.043Z] [2020-03-18T13:50:03.043Z] -- The following RECOMMENDED packages have not been found:[2020-03-18T13:50:03.043Z] [2020-03-18T13:50:03.043Z]  * Qt5X11Extras (required version >= 5.12.0)[2020-03-18T13:50:03.043Z]Recommended for better integration on X11.[2020-03-18T13:50:03.043Z] [2020-03-18T13:50:03.043Z] -- Configuring done[2020-03-18T13:50:03.990Z] -- Generating done[2020-03-18T13:50:03.990Z] -- Build files have been written to: C:/CI/Job Build/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2020-03-18T13:50:04.804Z] [2020-03-18T13:50:04.804Z] C:\CI\Job Build>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" [2020-03-18T13:50:04.804Z] **[2020-03-18T13:50:04.804Z] ** Visual Studio 2019 Developer Command Prompt v16.4.3[2020-03-18T13:50:04.804Z] ** Copyright (c) 2019 Microsoft Corporation[2020-03-18T13:50:04.804Z] **[2020-03-18T13:50:05.759Z] [vcvarsall.bat] Environment initialized for: 'x64'[2020-03-18T13:50:05.759Z] [1/149] Automatic MOC for target crashtest[2020-03-18T13:50:06.022Z] [2/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest_autogen\mocs_compilation.cpp.obj[2020-03-18T13:50:06.283Z] [3/149] Automatic MOC for target drkonqi_backtrace_parser[2020-03-18T13:50:06.283Z] [4/149] Automatic MOC for target kdbgwin[2020-03-18T13:50:06.283Z] [5/149] Automatic MOC for target qbugzilla[2020-03-18T13:50:07.229Z] [6/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsernull.cpp.obj[2020-03-18T13:50:07.229Z] [7/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj[2020-03-18T13:50:07.229Z] [8/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserlldb.cpp.obj[2020-03-18T13:50:07.229Z] [9/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_backtrace_parser_autogen\mocs_compilation.cpp.obj[2020-03-18T13:50:07.229Z] [10/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj[2020-03-18T13:50:07.229Z] [11/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj[2020-03-18T13:50:07.229Z] [12/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj[2020-03-18T13:50:07.229Z] [13/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj[2020-03-18T13:50:07.229Z] [14/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj[2020-03-18T13:50:07.491Z] [15/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest.cpp.obj[2020-03-18T13:50:07.760Z] [16/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.cpp.obj[2020-03-18T13:50:07.760Z] [17/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj[2020-03-18T13:50:08.022Z] [18/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\attachmentclient.cpp.obj[2020-03-18T13:50:08.283Z] [19/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugsearch.cpp.obj[2020-03-18T13:50:08.283Z] [20/149] Building CXX object 

D27199: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  In D27199#627422 , @gvgeo wrote:
  
  > Differently sized icons are about to be restored in D28034 
.
  
  
  Nice! Thanks
  
  >> ...text indicator replaced with a 1px divider...   Is it a good idea to 
tweak it or is it better to leave it like it is?
  > 
  > The alternative is the first version from T10470 
 mocups, right? If #VDG 
 team doesn't like as it is, don't see a 
reason to keep it as it is.
  
  Yes, it would be like the first mockup
  
  > Would be nice to hear about details labels too, which have 0.6 opacity now:
  >  F8098508: Screenshot_20200211_234124.png 

  
  LGTM
  
  > And of course any other change, to avoid changing the UI with every release.
  
  If you could align the password field to the padding like this it would be 
great F8182886: image.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/71/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 18 Mar 2020 13:41:16 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 266 lines...][2020-03-18T13:41:56.082Z] -- The following OPTIONAL packages have been found:[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z]  * KF5ItemViews (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5Solid (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5Auth (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5Codecs (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5XmlGui (required version >= 5.68.0)[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z] -- The following RECOMMENDED packages have been found:[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z]  * Qt5X11Extras (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]Recommended for better integration on X11.[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z] -- The following REQUIRED packages have been found:[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z]  * ECM (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * Qt5 (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]  * Gettext[2020-03-18T13:41:56.082Z]  * KF5I18n (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * KF5Service (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5JobWidgets (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5CoreAddons (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * KF5ConfigWidgets (required version >= 5.68.0)[2020-03-18T13:41:56.082Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]  * KF5KIO (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * KF5Crash (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * KF5Completion (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * Qt5Core (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-18T13:41:56.082Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * KF5 (required version >= 5.69.0)[2020-03-18T13:41:56.082Z]  * Qt5Test[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z] -- The following features have been disabled:[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-18T13:41:56.082Z] [2020-03-18T13:41:56.082Z] -- Configuring done[2020-03-18T13:41:56.343Z] -- Generating done[2020-03-18T13:41:56.343Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-18T13:41:57.341Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project drkonqi --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-18T13:41:57.341Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2020-03-18T13:41:57.341Z] Scanning dependencies of target crashtest_autogen[2020-03-18T13:41:57.341Z] Scanning dependencies of target lsb_release_autogen[2020-03-18T13:41:57.341Z] Scanning dependencies of target qbugzilla_autogen[2020-03-18T13:41:57.341Z] [  1%] Automatic MOC for target drkonqi_backtrace_parser[2020-03-18T13:41:57.341Z] [  1%] Automatic MOC for target crashtest[2020-03-18T13:41:57.341Z] [  1%] Automatic MOC for target lsb_release[2020-03-18T13:41:57.341Z] [  2%] Automatic MOC for target qbugzilla[2020-03-18T13:41:57.601Z] [  2%] Built target crashtest_autogen[2020-03-18T13:41:57.601Z] [  2%] Built target lsb_release_autogen[2020-03-18T13:41:57.601Z] Scanning dependencies of target lsb_release[2020-03-18T13:41:57.601Z] [  3%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.o[2020-03-18T13:41:57.601Z] [  3%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.o[2020-03-18T13:41:57.869Z] [  4%] Linking CXX executable ../../bin/lsb_release[2020-03-18T13:41:58.194Z] Scanning dependencies of target crashtest[2020-03-18T13:41:58.465Z] [  4%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.o[2020-03-18T13:41:58.465Z] [  5%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.o[2020-03-18T13:41:58.726Z] [  5%] Built target lsb_release[2020-03-18T13:41:59.300Z] [ 

D28120: [Icons KCM] Floor delegate height

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c9f545a3c537: [Icons KCM] Floor delegate height (authored 
by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28120?vs=77895=77912

REVISION DETAIL
  https://phabricator.kde.org/D28120

AFFECTED FILES
  kcms/icons/package/contents/ui/main.qml

To: broulik, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Vlad Zahorodnii]

zzag added a comment.


  In D28075#629829 , @ahmadsamir 
wrote:
  
  > Anyway, the important thing is that the test passes on the CI system.
  
  
  Okay, that's good! We still have that qDeleteAll in ~ShadowHelper(), not sure 
what we have to do about it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77909.
gikari added a comment.


  Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=77185=77909

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77906.
ahmadsamir added reviewers: davidedmundson, apol, broulik.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=77905=77906

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77905.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=77898=77905

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in server.cpp:671
> Why the changes from [0-9] to \d?

Less cluttered; but maybe not as readable. I'll revert it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27857

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Ahmad Samir]

ahmadsamir added a comment.


  Could be something on my system no idea what though. Sorry for the noise.
  
  Anyway, the important thing is that the test passes on the CI system.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Vlad Zahorodnii]

zzag added a comment.


  In D28075#629808 , @ahmadsamir 
wrote:
  
  > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a 
SIGSEGV even after building breeze with this diff:
  >
  >   Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault.
  >   0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
  >   at /usr/include/qt5/QtCore/qalgorithms.h:320
  >   320 delete *begin;
  >   (gdb) bt
  >   #0  0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
  >   at /usr/include/qt5/QtCore/qalgorithms.h:320
  >   #1  0x70c6bdb8 in qDeleteAll > 
(c=...) at /usr/include/qt5/QtCore/qalgorithms.h:328
  >   #2  0x70c69319 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:106
  >   #3  0x70c69380 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:107
  >   #4  0x70c701a2 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:200
  >   #5  0x70c70206 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:202
  >   #6  0x777ff5e8 in QApplication::~QApplication 
(this=0x7fffdd00, __in_chrg=) at kernel/qapplication.cpp:812
  >   #7  0x00408f65 in main (argc=1, argv=0x7fffde58) at 
/home/ahmad/rpmbuild/dev/kwidgetsaddons/autotests/kdatetimeedittest.cpp:31
  >
  
  
  Hmm,
  
❯ dbus-run-session bin/kdatetimeedittest
* Start testing of KDateTimeEditTest *
Config: Using QtTest library 5.15.0, Qt 5.15.0 (x86_64-little_endian-lp64 
shared (dynamic) debug build; by GCC 9.2.1 20200130)
PASS   : KDateTimeEditTest::initTestCase()
PASS   : KDateTimeEditTest::_q_showIfNotHidden()
PASS   : KDateTimeEditTest::testDefaults()
PASS   : KDateTimeEditTest::testValidNull()
PASS   : KDateTimeEditTest::testDateTimeRange()
PASS   : KDateTimeEditTest::testOptions()
PASS   : KDateTimeEditTest::testDateDisplayFormat()
PASS   : KDateTimeEditTest::testDateList()
PASS   : KDateTimeEditTest::testTimeListInterval()
PASS   : KDateTimeEditTest::testTimeList()
PASS   : KDateTimeEditTest::testTimeDisplayFormat()
PASS   : KDateTimeEditTest::testCalendarSystem()
PASS   : KDateTimeEditTest::testTimeSpec()
PASS   : KDateTimeEditTest::testDateMenu()
PASS   : KDateTimeEditTest::cleanupTestCase()
Totals: 15 passed, 0 failed, 0 skipped, 0 blacklisted, 817ms
* Finished testing of KDateTimeEditTest *

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Vlad Zahorodnii]

zzag added a comment.


  In D28075#629808 , @ahmadsamir 
wrote:
  
  > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a 
SIGSEGV even after building breeze with this diff:
  >
  >   Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault.
  >   0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
  >   at /usr/include/qt5/QtCore/qalgorithms.h:320
  >   320 delete *begin;
  >   (gdb) bt
  >   #0  0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
  >   at /usr/include/qt5/QtCore/qalgorithms.h:320
  >   #1  0x70c6bdb8 in qDeleteAll > 
(c=...) at /usr/include/qt5/QtCore/qalgorithms.h:328
  >   #2  0x70c69319 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:106
  >   #3  0x70c69380 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:107
  >   #4  0x70c701a2 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:200
  >   #5  0x70c70206 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
  >   at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:202
  >   #6  0x777ff5e8 in QApplication::~QApplication 
(this=0x7fffdd00, __in_chrg=) at kernel/qapplication.cpp:812
  >   #7  0x00408f65 in main (argc=1, argv=0x7fffde58) at 
/home/ahmad/rpmbuild/dev/kwidgetsaddons/autotests/kdatetimeedittest.cpp:31
  >
  
  
  Urgh, thanks. I'm gonna have a look.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Ahmad Samir]

ahmadsamir added a comment.


  FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a 
SIGSEGV even after building breeze with this diff:
  
Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault.
0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
at /usr/include/qt5/QtCore/qalgorithms.h:320
320 delete *begin;
(gdb) bt
#0  0x70c6c770 in qDeleteAll::const_iterator> (begin=..., end=...)
at /usr/include/qt5/QtCore/qalgorithms.h:320
#1  0x70c6bdb8 in qDeleteAll > 
(c=...) at /usr/include/qt5/QtCore/qalgorithms.h:328
#2  0x70c69319 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:106
#3  0x70c69380 in Breeze::ShadowHelper::~ShadowHelper 
(this=0x547ca0, __in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezeshadowhelper.cpp:107
#4  0x70c701a2 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:200
#5  0x70c70206 in Breeze::Style::~Style (this=0x547a40, 
__in_chrg=)
at /home/ahmad/rpmbuild/dev/breeze/kstyle/breezestyle.cpp:202
#6  0x777ff5e8 in QApplication::~QApplication (this=0x7fffdd00, 
__in_chrg=) at kernel/qapplication.cpp:812
#7  0x00408f65 in main (argc=1, argv=0x7fffde58) at 
/home/ahmad/rpmbuild/dev/kwidgetsaddons/autotests/kdatetimeedittest.cpp:31

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28075

To: zzag, #plasma, cblack
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28103: introduce PassiveNotification type

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4e596d8bed9c: introduce PassiveNotification type 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28103?vs=77843=77901#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77843=77901

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/PassiveNotification.qml
  src/controls/templates/PassiveNotification.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex updated this revision to Diff 77899.
alex added a comment.


  Add tests for converterrunner

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27166?vs=76487=77899

BRANCH
  converter_runner_refactoring (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27166

AFFECTED FILES
  CMakeLists.txt
  runners/converter/CMakeLists.txt
  runners/converter/autotests/CMakeLists.txt
  runners/converter/autotests/converterrunnertest.cpp
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77898.
ahmadsamir marked 2 inline comments as done.
ahmadsamir removed reviewers: davidedmundson, apol, broulik.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27857?vs=76991=77898

BRANCH
  l-qregexp-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27857

AFFECTED FILES
  applets/digital-clock/plugin/clipboardmenu.cpp
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
  ksmserver/server.cpp
  libkworkspace/kdisplaymanager.cpp
  libkworkspace/kworkspace.cpp
  runners/calculator/calculatorrunner.cpp
  shell/panelview.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex added a comment.


  F8182687: folderview_work.patch 
  
  I did the changes above like you said in the patch above.
  I didn't applied it yet, because on testing that same patch, I discovered a 
bug. I reverted the changes ( after saving the work in the above patch ) and 
tested the current implementation and it also has the bug.
  
  The bug is hard to catch, but its like this:
  If one selects listview and changes size, all is well. One can choose 
iconview mode and apply, and then go back to listview mode and apply and all is 
well. Also can change listview mode icon size and all is still well.
  But if one selects iconview mode, changes icon size of iconview mode, and 
apply, then listviewmode will have the icon view mode icon size **until** the 
plasmashell is restarted. after the plasmashell restart all is well again.
  
  I still didn't understood why this is happening, i have been debugging the 
settings file plasma-org.kde.plasma.desktop-appletsrc and the settings seem to 
be properly written.
  
  I really want to understand and fix what is happening before final work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: feat(kded): add a dbus method to lock current rotation

[Bhushan Shah]

bshah added a comment.


  This works as expected API wise and functionality wise, but internally 
control config is not written at all. :/

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28115

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Aleix Pol Gonzalez]

apol added a comment.


  +1 overall

INLINE COMMENTS

> ksolidnotify.cpp:131
>  QString out(p->readAll());
> -const QStringList  = 
> out.split(QRegExp(QStringLiteral("\\s+")), QString::SkipEmptyParts);
> +const QStringList  = 
> out.split(QRegularExpression(QStringLiteral("\\s+")), 
> QString::SkipEmptyParts);
>  KSysGuard::Processes procs;

it could make sense to use splitRef here, unsure where this is used.

> server.cpp:671
>  // strip the screen number from the display
> -display.remove(QRegExp(QStringLiteral("\\.[0-9]+$")));
> +display.remove(QRegularExpression(QStringLiteral("\\.\\d+$")));
>  int i;

Why the changes from [0-9] to \d?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27857

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah updated this revision to Diff 77896.
bshah added a comment.


  - rename method to lock rotation
  - disconnect/connect orientation sensor when we want to lock/unlock rotation

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28115?vs=77879=77896

BRANCH
  arcpatch-D28115

REVISION DETAIL
  https://phabricator.kde.org/D28115

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28120: [Icons KCM] Floor delegate height

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's two rows, so if the delegate happens to be at an odd size, both rows 
would be rounded up, pushing the icons too close to the delegate border.
  Since there's already code for unloading the icons that are out of view, 
nothing should be leaked into the view, even if we now end up having 1 or 2 
pixels of the delegates normally out of view visible.

TEST PLAN
  5.18 please
  
  Before
  F8182640: Screenshot_20200318_113143.png 

  After
  F8182641: Screenshot_20200318_113133.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28120

AFFECTED FILES
  kcms/icons/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28075: [kstyle] Properly unregister widgets in ShadowHelper

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:49fdd73e1629: [kstyle] Properly unregister widgets in 
ShadowHelper (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28075?vs=77727=77893

REVISION DETAIL
  https://phabricator.kde.org/D28075

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: zzag, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28073: [kstyle] Properly unregister widgets in ShadowHelper

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R113:19771d84177d: [kstyle] Properly unregister widgets in 
ShadowHelper (authored by zzag).

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28073?vs=77725=77892

REVISION DETAIL
  https://phabricator.kde.org/D28073

AFFECTED FILES
  kstyle/oxygenshadowhelper.cpp

To: zzag, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28116: Fix sizing of ComboBox and RadioButton

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:b738ebbb6369: Fix sizing of CheckBox and RadioButton 
(authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28116?vs=77882=77884

REVISION DETAIL
  https://phabricator.kde.org/D28116

AFFECTED FILES
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/RadioButton.qml
  plugin/kquickstyleitem.cpp

To: broulik, #plasma, mart, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28116: Fix sizing of ComboBox and RadioButton

[Kai Uwe Broulik]

broulik updated this revision to Diff 77882.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added reviewers: mart, hpereiradacosta.
broulik added a comment.


  - Use pixel metric for checkbox/radio button size and use the spacing. Only 
use the size from contents for the (here unused) implicit size of the 
checkindicator.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28116?vs=77881=77882

REVISION DETAIL
  https://phabricator.kde.org/D28116

AFFECTED FILES
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/RadioButton.qml
  plugin/kquickstyleitem.cpp

To: broulik, #plasma, mart, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27857: Port some usage of QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27857

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Roman Gilg]

romangg added a comment.


  So I think of two things to consider:
  
  - How is the overall interaction? Do we want something in line with other 
systems? Then we should have a lock/unlock rotation workflow where the current 
rotation orientation is made permanent until the icon is tapped again. Android 
 and GNOME 

 do it like this.
  - To make this consistent with the KScreen KCM the values should be written 
to the control file. I.e. your `KScreenDaemon::setAutoRotation` method should 
call into `ControlConfig::setAutoRotate`. Then it would just change for example 
when you lock the rotation from auto to manual and the current rotation value 
is set anyway.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28115

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28116: Fix sizing of ComboBox and RadioButton

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `KQuickStyleItem` manages its implicit size internally. Overriding it on the 
QML side makes this non-deterministic which assignment wins and might cause 
unexpected re-evaluation of the size causing it to change.
  Moreover, the check indicator size already includes spacing between checkbox 
and label on the `QStyle` side, so our additional `spacing` would be added 
ontop. Furthermore, `CheckBox` `padding` appears to add padding around the 
control as a whole /and/ between checkbox and label, further widening the gap 
between the two.
  Finally, because of the right padding of the `CheckIndicator`, assigning its 
`height` to its `width` makes it a lot taller than it should be, resulting in 
large gaps between controls in e.g. a `FormLayout`.
  
  BUG: 418447

TEST PLAN
  The only downside might be that using a `CheckIndicator` standalone now has a 
quite small size (just the checkbox you see basically) rather than a "nice 
delegate like height". But then I don't think this control is being used 
anywhere, and is probably centered vertically anway. When used in conjunction 
with `ItemDelegate` (checkable item delegate) I believe the entire delegate 
becomes clickable to toggle the `CheckBox` so it getting smaller should have no 
effect.
  
  Before:
  F8182462: Screenshot_20200318_090022.png 

  After:
  F8182463: Screenshot_20200318_090005.png 

  The gap is still ever so slightly wider than in a `QCheckBox` but that 
appears to be the style taking into account the "empty label" which still might 
have some font lead in/out.
  
  Edit: Just as I was uploading this, I realized that the spacing is now 
non-existant with styles other than Breeze ... so I'll have to do some more 
research on how it gets the sizing :(

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28116

AFFECTED FILES
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/RadioButton.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah added a comment.


  Maybe it would be sensible idea to instead connect/disconnect orientation 
sensor, and replace method name with "inhibitAutoRotation"?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28115

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah updated this revision to Diff 77879.
bshah added a comment.


  update branch

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28115?vs=77878=77879

BRANCH
  arcpatch-D28115

REVISION DETAIL
  https://phabricator.kde.org/D28115

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  This allows to toggle the auto-rotation or temporary inhibit it on
  mobile.

TEST PLAN
  it works partially currently, after first rotation event
  it re-enables rotation somehow.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28115

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart