D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 78069.
cblack added a comment.


  Add linear interpolation, alpha blending, colour adjustment, and colour 
scaling

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=78030=78069

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp
  src/pendingvalue.cpp
  src/pendingvalue.h

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 636 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/636/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 02:45:42 +
 Build duration:
1 hr 28 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 108 test(s), Skipped: 0 test(s), Total: 108 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)58%
(322/560)58%
(322/560)43%
(31612/74221)32%
(14352/44374)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(130/151)86%
(130/151)65%
(19551/30050)51%
(9991/19735)colorcorrection100%
(7/7)100%
(7/7)78%
(670/855)59%
(236/401)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)79%
(443/562)65%
(140/216)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/379)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/693)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
(79/970)3%
(29/894)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/233)2%
(3/158)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(46/657)1%
(5/552)effects.glide67%
(2/3)67%
(2/3)72%
(150/208)65%
(60/93)effects.highlightwindow100%
(2/2)100%
(2/2)40%
   

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 477 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/477/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 02:45:42 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 13 test(s), Passed: 95 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testDontCrashAuroraeDestroyDecoFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testModiferOnlyShortcutFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXdgShellClientFailed: projectroot.autotests.integration.kwin_testXdgShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 7 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucencyFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScriptFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScript_waylandonly

D27669: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#630974 , @ngraham wrote:
  
  > Nice, the colors are better now. I still see a difference in animation 
speed when the titlebar and toolbar change color though. It's especially 
visible with the current Breeze color scheme.
  >
  > F8185590: vokoscreenNG-2020-03-19_20-53-04.webm 

  
  
  This is only an issue on X11. On Wayland, the titlebar and window contents 
are properly synchronized.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Nice, the colors are better now. I still see a difference in animation speed 
when the titlebar and toolbar change color though. It's especially visible with 
the current Breeze color scheme.
  
  F8185590: vokoscreenNG-2020-03-19_20-53-04.webm 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 635 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/635/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 02:06:02 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 2852 lines...][2020-03-20T02:15:47.897Z] [ 59%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/desktopsmodel.cpp.o[2020-03-20T02:15:48.466Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/appmenu.cpp.o[2020-03-20T02:15:49.035Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/atoms.cpp.o[2020-03-20T02:15:49.293Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/client_machine.cpp.o[2020-03-20T02:15:49.293Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/scripting/scripting_logging.cpp.o[2020-03-20T02:15:50.230Z] [ 59%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/effectsfilterproxymodel.cpp.o[2020-03-20T02:15:50.489Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/scripting/scriptingutils.cpp.o[2020-03-20T02:15:51.426Z] [ 59%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_abstract_client.cpp.o[2020-03-20T02:15:51.426Z] [ 59%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktops.cpp.o[2020-03-20T02:15:51.683Z] [ 59%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktopssettings.cpp.o[2020-03-20T02:15:51.941Z] [ 59%] Linking CXX shared module ../../bin/kcm_kwin_effects.so[2020-03-20T02:15:51.941Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/clockskewnotifier.cpp.o[2020-03-20T02:15:52.508Z] [ 60%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_effectshandler.cpp.o[2020-03-20T02:15:52.508Z] [ 60%] Built target kcm_kwin_effects[2020-03-20T02:15:52.508Z] [ 60%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_screens.cpp.o[2020-03-20T02:15:52.508Z] [ 60%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_workspace.cpp.o[2020-03-20T02:15:53.073Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/clockskewnotifierengine.cpp.o[2020-03-20T02:15:53.331Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/colorcorrectdbusinterface.cpp.o[2020-03-20T02:15:53.591Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/manager.cpp.o[2020-03-20T02:15:53.591Z] [ 60%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/test_scripted_effectloader.cpp.o[2020-03-20T02:15:54.159Z] [ 60%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/settings.cpp.o[2020-03-20T02:15:54.159Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/suncalc.cpp.o[2020-03-20T02:15:55.532Z] [ 60%] Linking CXX shared module ../../bin/kcm_kwin_virtualdesktops.so[2020-03-20T02:15:55.532Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/composite.cpp.o[2020-03-20T02:15:56.100Z] [ 60%] Built target kcm_kwin_virtualdesktops[2020-03-20T02:15:56.100Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/cursor.cpp.o[2020-03-20T02:15:56.100Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/dbusinterface.cpp.o[2020-03-20T02:15:57.036Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/debug_console.cpp.o[2020-03-20T02:15:57.974Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/decorations/decoratedclient.cpp.o[2020-03-20T02:15:58.234Z] [ 61%] Linking CXX executable ../bin/testScriptedEffectLoader[2020-03-20T02:15:59.172Z] [ 61%] Built target testScriptedEffectLoader[2020-03-20T02:15:59.172Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/decorations/decorationbridge.cpp.o[2020-03-20T02:15:59.172Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/decorations/decorationpalette.cpp.o[2020-03-20T02:16:00.554Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/decorations/decorationrenderer.cpp.o[2020-03-20T02:16:01.122Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/decorations/decorations_logging.cpp.o[2020-03-20T02:16:01.381Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/decorations/settings.cpp.o[2020-03-20T02:16:01.640Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/deleted.cpp.o[2020-03-20T02:16:02.574Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/effectloader.cpp.o[2020-03-20T02:16:02.574Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/effects.cpp.o[2020-03-20T02:16:02.574Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/egl_context_attribute_builder.cpp.o[2020-03-20T02:16:03.142Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/events.cpp.o[2020-03-20T02:16:03.401Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/focuschain.cpp.o[2020-03-20T02:16:04.339Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/geometrytip.cpp.o[2020-03-20T02:16:04.339Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/gestures.cpp.o[2020-03-20T02:16:06.244Z] [ 61%] Building CXX object 

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 476 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/476/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 02:06:02 +
 Build duration:
7 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 2875 lines...][2020-03-20T02:12:35.054Z] Unknown property type for key "X-KDE-Keywords[sk]" -> falling back to string[2020-03-20T02:12:35.054Z] Unknown property type for key "X-KDE-Keywords[sv]" -> falling back to string[2020-03-20T02:12:35.054Z] Unknown property type for key "X-KDE-Keywords[uk]" -> falling back to string[2020-03-20T02:12:35.054Z] Unknown property type for key "X-KDE-Keywords[x-test]" -> falling back to string[2020-03-20T02:12:35.054Z] Unknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to string[2020-03-20T02:12:35.054Z] Unknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to string[2020-03-20T02:12:35.054Z] Generated  "/usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/build/kcmkwin/kwineffects/kcm_kwin_effects.json"[2020-03-20T02:12:35.343Z] [ 59%] Automatic MOC for target kcm_kwin_effects[2020-03-20T02:12:36.380Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/composite.cpp.o[2020-03-20T02:12:37.030Z] [ 59%] Built target kcm_kwin_virtualdesktops_autogen[2020-03-20T02:12:37.030Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/cursor.cpp.o[2020-03-20T02:12:37.290Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/dbusinterface.cpp.o[2020-03-20T02:12:37.918Z] [ 59%] Built target kcm_kwin_effects_autogen[2020-03-20T02:12:38.195Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/debug_console.cpp.o[2020-03-20T02:12:38.476Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/decorations/decoratedclient.cpp.o[2020-03-20T02:12:39.924Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/decorations/decorationbridge.cpp.o[2020-03-20T02:12:40.210Z] [ 59%] Building CXX object CMakeFiles/kwin.dir/decorations/decorationpalette.cpp.o[2020-03-20T02:12:42.135Z] [ 59%] Generating virtualdesktopssettings.h, virtualdesktopssettings.cpp[2020-03-20T02:12:42.135Z] [ 59%] Generating virtualdesktopssettings.moc[2020-03-20T02:12:42.135Z] Scanning dependencies of target kcm_kwin_virtualdesktops[2020-03-20T02:12:42.135Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/decorations/decorationrenderer.cpp.o[2020-03-20T02:12:42.135Z] [ 60%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/kcm_kwin_virtualdesktops_autogen/mocs_compilation.cpp.o[2020-03-20T02:12:42.407Z] [ 60%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/__/__/virtualdesktopsdbustypes.cpp.o[2020-03-20T02:12:43.012Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/decorations/decorations_logging.cpp.o[2020-03-20T02:12:43.583Z] [ 60%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/animationsmodel.cpp.o[2020-03-20T02:12:44.206Z] Scanning dependencies of target kcm_kwin_effects[2020-03-20T02:12:44.206Z] [ 60%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/kcm_kwin_effects_autogen/mocs_compilation.cpp.o[2020-03-20T02:12:44.485Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/decorations/settings.cpp.o[2020-03-20T02:12:45.058Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/deleted.cpp.o[2020-03-20T02:12:45.651Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/effectloader.cpp.o[2020-03-20T02:12:45.651Z] [ 60%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/desktopsmodel.cpp.o[2020-03-20T02:12:46.734Z] [ 60%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktops.cpp.o[2020-03-20T02:12:47.328Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/effects.cpp.o[2020-03-20T02:12:47.933Z] [ 60%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/kcm.cpp.o[2020-03-20T02:12:48.539Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/egl_context_attribute_builder.cpp.o[2020-03-20T02:12:49.565Z] [ 60%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktopssettings.cpp.o[2020-03-20T02:12:49.565Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/events.cpp.o[2020-03-20T02:12:50.534Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/focuschain.cpp.o[2020-03-20T02:12:51.147Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/geometrytip.cpp.o[2020-03-20T02:12:51.409Z] [ 60%] Linking CXX shared module ../../bin/kcm_kwin_virtualdesktops.so[2020-03-20T02:12:51.705Z] [ 60%] Built target kcm_kwin_virtualdesktops[2020-03-20T02:12:51.705Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/gestures.cpp.o[2020-03-20T02:12:52.681Z] [ 60%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/effectsfilterproxymodel.cpp.o[2020-03-20T02:12:53.300Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/globalshortcuts.cpp.o[2020-03-20T02:12:53.300Z] [ 60%] Building CXX object 

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78065.
cblack added a comment.


  Use better heuristic for determining if a widget has the correct palette set

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78063=78065

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

bruns added a comment.


  F8185503: Screenshot_20200320_022339.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

bruns updated this revision to Diff 78064.
bruns added a comment.


  Use Kirigami.Action for Trash

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28025?vs=77574=78064

BRANCH
  baloo_config_rework

REVISION DETAIL
  https://phabricator.kde.org/D28025

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

bruns added a comment.


  In D28025#630882 , @ngraham wrote:
  
  > In D28025#630849 , @bruns wrote:
  >
  > > Having only inclusion/exclusion is a temporary state. I plan to add more 
settings for each path, so having an "add" button for each possible state will 
no longer be feasible.
  > >
  > > Also, "removing" a path from the "included"  list is not the same as 
excluding it - the state depends on the state of its next ancestor. This exact 
type of mixup has led to the messy state the current KCM is in.
  >
  >
  > Then maybe we should rethink the UI, because that's what it currently 
suggests. What are the other states you're planning to add?
  
  
  Honestly, no, thats not what it suggests. It clearly tells if a folder should 
be searched (magnifying glass) or not (minus sign). Currently a checkbox would 
do, but thats a) not scalable b) non-obvious (does checked equal included or 
excluded)?
  
  I have already mentioned meta-data vs full-text. Also file-name only is often 
wanted.
  
  >> The Items are inspired by the Desktop Effects KCM. I have searched through 
the HIG for considerable time, unfortunately it lacks any specific information 
what to do, or any usable examples. If you can provide any examples where you 
think it is done the "right way (TM)", please go for it.
  > 
  > Yeah, we need to add more examples and better guidance to the HIG for sure. 
However you must be looking at an old version of the Desktop Effects KCM 
because the git master version shows what I'm talking about:  F8185313: 
Screenshot_20200319_161856.png 
  > 
  > You can also look at the Desktop effects KCM, the Activities KCM, or 
Discover's Settings page.
  
  Lets see:
  
  - Desktop Effects KCM:  It has 3 state checkboxes where this clearly violates 
HIG. The "Video" button is a toggle button, but to get its meaning you have to 
hover it for the tooltip. It has a "Get new Desktop Effects" button on the top 
button, which not only installs new effects, but must also be used to 
**uninstall** effects.
  - Activities: "Create New..." on the bottom **right** (HIG violation).
  
  So much for your poster childs ...
  
  Yes, it does use custom buttons. The second one can be trivially replaced by 
a Kirigami.Action (or I could use "flat" style, and it would look and behave 
exactly like a Kirigami.Action, so no "custom button appearance" nor 
"behavior"). The "Enable/Disable indexing" button is custom. It can be 
trivially changed to a Kirigami.Action by moving the text to the tooltip, but 
IMHO thats much worse from a usability view.
  
  >> The search/excluded icons are just the first implemented state column. 
There will be more columns. Having the full state in textual form for each 
entry will look awkward, and having it in textual form only will make it much 
harder to get the current state for a given path.
  >> 
  >> More fine granular settings have been requested several times. Having a 
content indexer run on ~/Downloads poses a security risk. Running full-text 
indexing on ~/Documents/MyCppProjects/ is definitely subject to a users 
preference, while most users would expect ~/Pictures/, ~/Videos/ and ~/Music/ 
to be scanned for metadata.
  >> 
  >> The current model and visual representation are complete nonsense, from a 
programmers as well as a users view. This definitely gets the model in a usable 
and extensible state, and shows the real state to the user (instead of showing 
some invented entries, and leaving out the other real half), and also makes it 
configurable. The important part here is the model. The view/delegate can be 
extended even by some person who is not familiar with baloo internals.
  > 
  > In general I'm not a fan of patches that change both the backend and UI and 
say, "well, we can make a better UI later." Let's do it now, or we might forget 
to do it later, or do the backend bits in a way that make it impossible to do 
the UI in a user-friendly way. It wounds like what we really need here is a 
true multi-column table, like the one in the git master version of the System 
Tray applet.
  
  Thats not what I said. It has a sound model with this change. The model is 
extensible. The model represents the configuration correctly. Based on this 
model, everybody can polish the UI.
  
  If you can provide a better model, a better UI, please do it. The new model 
and UI addresses all the complaints I am aware of.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78063.
cblack marked 10 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=77529=78063

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breeze.h:104
> Why would this be more "ugly" as when there was no toolarea ? can you post a 
> screeshot of the said ugliness ?

With: F8185479: image.png 
Without: F8185480: image.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This patch introduces a new users KCM based off of the AccountsService.
  
  Co-authored-by: Nicolas Fella 

TEST PLAN
  F8185451: image.png 
  F8185453: image.png 
  F8185454: image.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  cblack/userkcm-ng (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/kcm_user.desktop
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usercontroller.cpp
  kcms/users/src/usercontroller.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Nathaniel Graham]

ngraham added a comment.


  In D28025#630849 , @bruns wrote:
  
  > Having only inclusion/exclusion is a temporary state. I plan to add more 
settings for each path, so having an "add" button for each possible state will 
no longer be feasible.
  >
  > Also, "removing" a path from the "included"  list is not the same as 
excluding it - the state depends on the state of its next ancestor. This exact 
type of mixup has led to the messy state the current KCM is in.
  
  
  Then maybe we should rethink the UI, because that's what it currently 
suggests. What are the other states you're planning to add?
  
  > The Items are inspired by the Desktop Effects KCM. I have searched through 
the HIG for considerable time, unfortunately it lacks any specific information 
what to do, or any usable examples. If you can provide any examples where you 
think it is done the "right way (TM)", please go for it.
  
  Yeah, we need to add more examples and better guidance to the HIG for sure. 
However you must be looking at an old version of the Desktop Effects KCM 
because the git master version shows what I'm talking about:  F8185313: 
Screenshot_20200319_161856.png 
  
  You can also look at the Desktop effects KCM, the Activities KCM, or 
Discover's Settings page.
  
  > The search/excluded icons are just the first implemented state column. 
There will be more columns. Having the full state in textual form for each 
entry will look awkward, and having it in textual form only will make it much 
harder to get the current state for a given path.
  > 
  > More fine granular settings have been requested several times. Having a 
content indexer run on ~/Downloads poses a security risk. Running full-text 
indexing on ~/Documents/MyCppProjects/ is definitely subject to a users 
preference, while most users would expect ~/Pictures/, ~/Videos/ and ~/Music/ 
to be scanned for metadata.
  > 
  > The current model and visual representation are complete nonsense, from a 
programmers as well as a users view. This definitely gets the model in a usable 
and extensible state, and shows the real state to the user (instead of showing 
some invented entries, and leaving out the other real half), and also makes it 
configurable. The important part here is the model. The view/delegate can be 
extended even by some person who is not familiar with baloo internals.
  
  In general I'm not a fan of patches that change both the backend and UI and 
say, "well, we can make a better UI later." Let's do it now, or we might forget 
to do it later, or do the backend bits in a way that make it impossible to do 
the UI in a user-friendly way. It wounds like what we really need here is a 
true multi-column table, like the one in the git master version of the System 
Tray applet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28098: remove pointless and arbitrary 4 line frame limit

[Ahmad Samir]

ahmadsamir added a comment.


  This makes sense; also it fixes a part of the backtraceparsertest unit test, 
test_bug168000, which currently fails on master (output after export'ing 
QT_LOGGING_RULES="*drkonqi*=true"):
  
3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
org.kde.drkonqi.parser: Rating: 24 out of 24 Usefulness: Useless
3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
org.kde.drkonqi.parser: 90%: 21.6 70%: 16.8 40%: 9.6
3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
org.kde.drkonqi.parser: Have seen stack base: false Lines counted: 3
3: FAIL!  : BacktraceParserTest::btParserUsefulnessTest(test_bug168000) 
Compared values are not the same
3:Actual   (btUsefulness): "Useless"
3:Expected (result)  : "MayBeUseful"
3:Loc: 
[/home/ahmad/rpmbuild/dev/drkonqi/src/tests/backtraceparsertest/backtraceparsertest.cpp(71)]
  
  the rating is perfect but gets killed by the frame number limit.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28098

To: sitter, apol, bcooksley
Cc: ahmadsamir, bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27935: Make kwallet-pam work with pam_fscrypt

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R107:2bb4c6dc870f: Make kwallet-pam work with pam_fscrypt 
(authored by aacid).

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27935?vs=77963=78049

REVISION DETAIL
  https://phabricator.kde.org/D27935

AFFECTED FILES
  pam_kwallet.c

To: aacid, sitter
Cc: sitter, security-team, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d8d079e42e62: [applets/appmenu] Use libtaskmanager for 
appmenus (authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28146?vs=78047=78048

REVISION DETAIL
  https://phabricator.kde.org/D28146

AFFECTED FILES
  applets/appmenu/lib/CMakeLists.txt
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

cblack updated this revision to Diff 78047.
cblack marked 2 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28146?vs=78040=78047

BRANCH
  appmenu-use-libtm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28146

AFFECTED FILES
  applets/appmenu/lib/CMakeLists.txt
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

bruns added a comment.


  In D28025#630729 , @ngraham wrote:
  
  > I have some UI suggestions:
  >
  > - Have a button to add an exclusion path as well as a button to add an 
inclusion path, rather than a single Add Setting button, which is a rather 
jargony, programmer-centric way of presenting the feature.
  
  
  Having only inclusion/exclusion is a temporary state. I plan to add more 
settings for each path, so having an "add" button for each possible state will 
no longer be feasible.
  
  Also, "removing" a path from the "included"  list is not the same as 
excluding it - the state depends on the state of its next ancestor. This exact 
type of mixup has led to the messy state the current KCM is in.
  
  > - For consistency, use the typical way of assigning actions to Kirigami 
SwipeListItems, rather than implementing custom button appearance and behavior. 
If you did this because the Kirigami SwipeListItem has no provision to display 
an inline action with text as well as an icon, let's change the component to 
support that.
  
  The Items are inspired by the Desktop Effects KCM. I have searched through 
the HIG for considerable time, unfortunately it lacks any specific information 
what to do, or any usable examples. If you can provide any examples where you 
think it is done the "right way (TM)", please go for it.
  
  > - Instead of having the list item expand when clicked to reveal whether 
it's included or excluded, display that information in textual form in the same 
line, and no need to repeat the same path. This would optionally allow you to 
remove the magnifying glass and minus sign icons.
  
  The search/excluded icons are just the first implemented state column. There 
will be more columns. Having the full state in textual form for each entry will 
look awkward, and having it in textual form only will make it much harder to 
get the current state for a given path.
  
  More fine granular settings have been requested several times. Having a 
content indexer run on ~/Downloads poses a security risk. Running full-text 
indexing on ~/Documents/MyCppProjects/ is definitely subject to a users 
preference, while most users would expect ~/Pictures/, ~/Videos/ and ~/Music/ 
to be scanned for metadata.
  
  The current model and visual representation are complete nonsense, from a 
programmers as well as a users view. This definitely gets the model in a usable 
and extensible state, and shows the real state to the user (instead of showing 
some invented entries, and leaving out the other real half), and also makes it 
configurable. The important part here is the model. The view/delegate can be 
extended even by some person who is not familiar with baloo internals.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appmenumodel.cpp:124
> +m_tasksModel->setScreenGeometry(geometry);
>  emit screenGeometryChanged();
>  }

I think you can just connect this signal to our signal in the constructor and 
then remove the if check here

> appmenumodel.cpp:150
>  
> -if (!id) {
> -setMenuAvailable(false);
> +if ((!objectPath.isEmpty()) && (!serviceName.isEmpty())) {
> +setMenuAvailable(true);

No need for parentheses

REPOSITORY
  R120 Plasma Workspace

BRANCH
  appmenu-use-libtm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28146

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28148: Fix broken paths in kirigami.qrc.in

[Mason McParlane]

masonm created this revision.
masonm added reviewers: Kirigami, VDG.
masonm added a project: Kirigami.
Herald added a subscriber: plasma-devel.
masonm requested review of this revision.

REVISION SUMMARY
  Fix path for private/CardsGridViewPrivate.qml and 
private/CardsListViewPrivate.qml.

TEST PLAN
  Build fails due to missing files mentioned in summary. After applying the 
patch the paths are corrected.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28148

AFFECTED FILES
  kirigami.qrc.in

To: masonm, #kirigami, #vdg
Cc: plasma-devel, #vdg, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

cblack added a comment.


  In D28146#630781 , @broulik wrote:
  
  > When filtering by screen, this now means we get appmenu only when the 
active window is on the same screen? Not sure if this is what we want?
  >  (Perhaps we could do some clever "last window with menu" tracking so we 
can have per-screen global menu? :D)
  
  
  This is already the current behaviour of the application menu plasmoid.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28146

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

cblack updated this revision to Diff 78040.
cblack added a comment.


  Remove extraneous change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28146?vs=78039=78040

BRANCH
  appmenu-use-libtm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28146

AFFECTED FILES
  applets/appmenu/lib/CMakeLists.txt
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

cblack updated this revision to Diff 78039.
cblack marked 6 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28146?vs=78038=78039

BRANCH
  appmenu-use-libtm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28146

AFFECTED FILES
  applets/appmenu/lib/CMakeLists.txt
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h
  libtaskmanager/waylandtasksmodel.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

cblack marked an inline comment as done.
cblack added inline comments.

INLINE COMMENTS

> broulik wrote in CMakeLists.txt:15
> Unused

Linkage fails without it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28146

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Kai Uwe Broulik]

broulik added a comment.


  I love patches with a lot of red!
  
  When filtering by screen, this now means we get appmenu only when the active 
window is on the same screen? Not sure if this is what we want?
  (Perhaps we could do some clever "last window with menu" tracking so we can 
have per-screen global menu? :D)

INLINE COMMENTS

> CMakeLists.txt:15
> +  KF5::WindowSystem
> +  PW::LibTaskManager)
>  

Unused

> appmenumodel.cpp:69
>  
> -connect(this, ::screenGeometryChanged, this, [this] {
> -onWindowChanged(m_currentWindowId);
> -});
> +connect(this, ::screenGeometryChanged, this, 
> ::onActiveWindowChanged);
>  

Is this needed? I would think if screen geometry changes, task manager updates 
and filters and signals the active task having changed?

> appmenumodel.cpp:147
>  
> +#include 
>  

Remove

> appmenumodel.cpp:151
>  {
> -qApp->removeNativeEventFilter(this);
> +auto objectPath = m_tasksModel->data(m_tasksModel->activeTask(), 
> TaskManager::AbstractTasksModel::ApplicationMenuObjectPath).value();
> +auto serviceName = m_tasksModel->data(m_tasksModel->activeTask(), 
> TaskManager::AbstractTasksModel::ApplicationMenuServiceName).value();

Please write as

  const QModelIndex activeTaskIdx = m_tasksMode->activeTask();
  const QString objectPath = m_tasksModel->data(activeTaskIdx, 
TaskManager::AbstractTasmsModel::ApplicationMenuObjectPath).toString();
  const QString serviceName = ;

(perhaps you could drop a `using namespace TaskManager` at the top of the cpp 
file)

> appmenumodel.cpp:154
>  
> -if (!id) {
> -setMenuAvailable(false);
> +if (objectPath != QString() && serviceName != QString()) {
> +setMenuAvailable(true);

`!objectPath.isEmpty()`

> appmenumodel.h:88
>  
>  QRect m_screenGeometry;
>  

I think you can remove this member now and just forward to tasksmodel

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28146

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28146: [applets/appmenu] Use libtaskmanager for appmenus

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This patch ports the appmenu applet to use
  libtaskmanager.

TEST PLAN
  Ensure that there aren't any regressions.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  appmenu-use-libtm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28146

AFFECTED FILES
  applets/appmenu/lib/CMakeLists.txt
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26200: Add shortcut for closing pages

[Nathaniel Graham]

ngraham added a comment.


  In D26200#589355 , @mart wrote:
  
  > hmm, not sure about it.
  >  it would probably be ok for most of the cases, but i'm pretty sure it may 
break some existing app.
  >  an app may want at least two pages always loaded for instance (if uses one 
for sidebar, one for main content)
  
  
  We could handle that by having the keystroke only get passed to the page with 
implicit focus, right?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26200

To: nicolasfella, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D27555: Add a category for kde-only and gnome-only apps

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Requesting changes to remove from the review queue given that I have open 
icon and string change requests

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D27555

To: apol, #plasma, #vdg, ngraham
Cc: ngraham, pino, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27783: Add new Account portal

[Nathaniel Graham]

ngraham added a comment.


  UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window?
  
  https://doc.qt.io/qt-5/qml-qtquick-window-window.html

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27783

To: jgrulich, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a reviewer: mart.
ngraham added a comment.
This revision now requires changes to proceed.


  I have some UI suggestions:
  
  - Have a button to add an exclusion path as well as a button to add an 
inclusion path, rather than a single Add Setting button, which is a rather 
jargony, programmer-centric way of presenting the feature.
  - For consistency, use the typical way of assigning actions to Kirigami 
SwipeListItems, rather than implementing custom button appearance and behavior. 
If you did this because the Kirigami SwipeListItem has no provision to display 
an inline action with text as well as an icon, let's change the component to 
support that.
  - Instead of having the list item expand when clicked to reveal whether it's 
included or excluded, display that information in textual form in the same 
line, and no need to repeat the same path. This would optionally allow you to 
remove the magnifying glass and minus sign icons.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 779 - Still unstable!

[David Edmundson]

This was a real breakage.

It is super important, we could be preventing other people from doing any
development work.

Please can people be more on top of CI failures. Any failure should have
someone either fix it, even if you didn't cause it, or write up an
explanation of why it's not an issue.
I have fixed p-w now.

David

D28143: Add "veryLongDuration" animation duration

[Nathaniel Graham]

ngraham updated this revision to Diff 78037.
ngraham added a comment.


  Forgot one thing

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28143?vs=78029=78037

BRANCH
  veryLongDuration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28143

AFFECTED FILES
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/styles/org.kde.desktop/Units.qml

To: ngraham, #vdg, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 779 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/779/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 18:18:02 +
 Build duration:
9 min 51 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.18.80.xmlacc/LibKWorkspace-5.18.80.xmlacc/LibNotificationManager-5.18.80.xmlacc/LibTaskManager-5.18.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.18.80/log.txtlogs/LibKWorkspace/5.18.80/log.txtlogs/LibNotificationManager/5.18.80/log.txtlogs/LibTaskManager/5.18.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/127)11%
(52/473)11%
(52/473)6%
(2599/42152)4%
(1246/28646)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/280)0%
(0/196)applets.kicker.plugin0%
(0/38)0%
(0/38)0%
(0/3366)0%
(0/2654)applets.notifications0%
(0/8)0%
(0/8)0%
(0/225)0%
(0/98)applets.panelspacer.plugin0%
(0/1)0%
(0/1)0%
(0/53)0%
(0/71)applets.systemtray0%
(0/3)0%
(0/3)0%
(0/551)0%
(0/398)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 778 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/778/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 17:59:20 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 2456 lines...][2020-03-19T18:12:14.198Z] [ 46%] Building CXX object applets/calendar/CMakeFiles/plasma_applet_calendar.dir/calendarapplet.cpp.o[2020-03-19T18:12:15.560Z] [ 46%] Linking CXX shared module ../../bin/plasma_applet_calendar.so[2020-03-19T18:12:15.560Z] [ 46%] Built target plasma_applet_calendar[2020-03-19T18:12:15.815Z] Scanning dependencies of target digitalclockplugin[2020-03-19T18:12:15.815Z] [ 46%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/digitalclockplugin_autogen/mocs_compilation.cpp.o[2020-03-19T18:12:17.179Z] [ 46%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/timezonemodel.cpp.o[2020-03-19T18:12:20.903Z] [ 46%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/timezonesi18n.cpp.o[2020-03-19T18:12:22.842Z] [ 46%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/digitalclockplugin.cpp.o[2020-03-19T18:12:24.237Z] [ 46%] Building CXX object applets/digital-clock/plugin/CMakeFiles/digitalclockplugin.dir/clipboardmenu.cpp.o[2020-03-19T18:12:26.148Z] [ 46%] Linking CXX shared library ../../../bin/libdigitalclockplugin.so[2020-03-19T18:12:26.407Z] [ 46%] Built target digitalclockplugin[2020-03-19T18:12:26.407Z] Scanning dependencies of target kickerplugin_autogen[2020-03-19T18:12:26.407Z] [ 47%] Automatic MOC for target kickerplugin[2020-03-19T18:12:28.332Z] [ 47%] Built target kickerplugin_autogen[2020-03-19T18:12:28.332Z] Scanning dependencies of target org.kde.plasma.panelspacer[2020-03-19T18:12:28.332Z] [ 47%] Building CXX object applets/panelspacer/plugin/CMakeFiles/org.kde.plasma.panelspacer.dir/org.kde.plasma.panelspacer_autogen/mocs_compilation.cpp.o[2020-03-19T18:12:30.249Z] [ 47%] Building CXX object applets/panelspacer/plugin/CMakeFiles/org.kde.plasma.panelspacer.dir/panelspacer.cpp.o[2020-03-19T18:12:32.758Z] [ 47%] Linking CXX shared module ../../../bin/org.kde.plasma.panelspacer.so[2020-03-19T18:12:33.014Z] [ 47%] Built target org.kde.plasma.panelspacer[2020-03-19T18:12:33.014Z] Scanning dependencies of target plasma_applet_notifications[2020-03-19T18:12:33.014Z] [ 47%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/plasma_applet_notifications_autogen/mocs_compilation.cpp.o[2020-03-19T18:12:34.378Z] [ 47%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/notificationapplet.cpp.o[2020-03-19T18:12:36.265Z] [ 47%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/filemenu.cpp.o[2020-03-19T18:12:38.155Z] [ 48%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/globalshortcuts.cpp.o[2020-03-19T18:12:39.523Z] [ 48%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/thumbnailer.cpp.o[2020-03-19T18:12:41.413Z] [ 48%] Linking CXX shared module ../../bin/plasma_applet_notifications.so[2020-03-19T18:12:41.670Z] [ 48%] Built target plasma_applet_notifications[2020-03-19T18:12:41.670Z] Scanning dependencies of target org.kde.plasma.private.systemtray[2020-03-19T18:12:41.670Z] [ 48%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/org.kde.plasma.private.systemtray_autogen/mocs_compilation.cpp.o[2020-03-19T18:12:43.587Z] [ 48%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtraymodel.cpp.o[2020-03-19T18:12:46.927Z] [ 48%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/sortedsystemtraymodel.cpp.o[2020-03-19T18:12:49.499Z] [ 48%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtray.cpp.o[2020-03-19T18:12:52.870Z] [ 48%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/debug.cpp.o[2020-03-19T18:12:54.485Z] [ 48%] Linking CXX shared module ../../bin/org.kde.plasma.private.systemtray.so[2020-03-19T18:12:55.065Z] [ 48%] Built target org.kde.plasma.private.systemtray[2020-03-19T18:12:55.065Z] Scanning dependencies of target org.kde.plasma.systemtray[2020-03-19T18:12:55.065Z] [ 48%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/org.kde.plasma.systemtray_autogen/mocs_compilation.cpp.o[2020-03-19T18:12:56.997Z] [ 48%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/systemtraycontainer.cpp.o[2020-03-19T18:12:59.548Z] [ 48%] Building CXX object applets/systemtray/container/CMakeFiles/org.kde.plasma.systemtray.dir/debug.cpp.o[2020-03-19T18:13:00.946Z] [ 48%] Linking CXX shared module 

Re: KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

[David Edmundson]

I investigated this (slightly) it seems these are false positives.

A new method was introduced in kcrash, that symbol is exported, then this
fails to link.
It implies this is just the CI system linking against an old kcrash until
frameworks sync.

David

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 777 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/777/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 17:32:46 +
 Build duration:
1 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 2574 lines...][2020-03-19T17:34:18.441Z] [ 54%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/notificationapplet.cpp.o[2020-03-19T17:34:18.441Z] [ 54%] Built target plasma_engine_applicationjobs_autogen[2020-03-19T17:34:18.441Z] [ 54%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/filemenu.cpp.o[2020-03-19T17:34:18.700Z] [ 54%] Built target plasma_applet_appmenu[2020-03-19T17:34:18.700Z] [ 54%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/ActivityData.cpp.o[2020-03-19T17:34:18.700Z] Scanning dependencies of target plasma_engine_apps[2020-03-19T17:34:18.700Z] [ 54%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/plasma_engine_apps_autogen/mocs_compilation.cpp.o[2020-03-19T17:34:18.700Z] [ 54%] Built target plasma_applet_calendar[2020-03-19T17:34:18.700Z] [ 54%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsengine.cpp.o[2020-03-19T17:34:18.700Z] [ 54%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsource.cpp.o[2020-03-19T17:34:18.958Z] [ 54%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtraymodel.cpp.o[2020-03-19T17:34:19.217Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest.cpp.o[2020-03-19T17:34:19.475Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/pumpjob.cpp.o[2020-03-19T17:34:19.475Z] [ 55%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/sortedsystemtraymodel.cpp.o[2020-03-19T17:34:19.475Z] [ 55%] Linking CXX shared module ../../../bin/org.kde.plasma.systemtray.so[2020-03-19T17:34:19.732Z] [ 55%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appservice.cpp.o[2020-03-19T17:34:19.732Z] [ 55%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/activityengine.cpp.o[2020-03-19T17:34:19.990Z] [ 55%] Linking CXX shared library ../../../bin/libdigitalclockplugin.so[2020-03-19T17:34:20.248Z] [ 56%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/activityservice.cpp.o[2020-03-19T17:34:20.248Z] [ 56%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/activityjob.cpp.o[2020-03-19T17:34:20.248Z] [ 56%] Built target org.kde.plasma.systemtray[2020-03-19T17:34:20.248Z] [ 56%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/ActivityRankingInterface.cpp.o[2020-03-19T17:34:20.507Z] [ 57%] Building CXX object applets/notifications/CMakeFiles/plasma_applet_notifications.dir/globalshortcuts.cpp.o[2020-03-19T17:34:20.507Z] [ 57%] Built target digitalclockplugin[2020-03-19T17:34:20.507Z] [ 57%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appjob.cpp.o[2020-03-19T17:34:20.507Z] Scanning dependencies of target plasma_engine_devicenotifications[2020-03-19T17:34:20.507Z] Scanning dependencies of target plasma_engine_dict[2020-03-19T17:34:20.507Z] [ 58%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/plasma_engine_devicenotifications_autogen/mocs_compilation.cpp.o[2020-03-19T17:34:20.507Z] [ 58%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/plasma_engine_dict_autogen/mocs_compilation.cpp.o[2020-03-19T17:34:20.765Z] [ 58%] Linking CXX shared module ../../../bin/org.kde.plasma.panelspacer.so[2020-03-19T17:34:20.765Z] [ 58%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/dictengine.cpp.o[2020-03-19T17:34:21.025Z] [ 58%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/systemtray.cpp.o[2020-03-19T17:34:21.025Z] [ 58%] Linking CXX executable ../../../../bin/statusnotifiertest[2020-03-19T17:34:21.283Z] [ 58%] Building CXX object applets/systemtray/CMakeFiles/org.kde.plasma.private.systemtray.dir/debug.cpp.o[2020-03-19T17:34:21.284Z] [ 58%] Built target org.kde.plasma.panelspacer[2020-03-19T17:34:21.284Z] [ 58%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/devicenotificationsengine.cpp.o[2020-03-19T17:34:21.284Z] [ 58%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/ksolidnotify.cpp.o[2020-03-19T17:34:21.284Z] [ 58%] Linking CXX shared module ../../bin/plasma_engine_apps.so[2020-03-19T17:34:21.542Z] [ 58%] Building CXX object 

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5e7d26dc5e38: [libtaskmanager] Add 
ApplicationMenu{ObjectPath,ServiceName} roles to model (authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=78032=78033

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack updated this revision to Diff 78032.
cblack marked 2 inline comments as done.
cblack added a comment.


  Address last feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=77950=78032

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28134: Add ColorUtils

[Carson Black]

cblack updated this revision to Diff 78030.
cblack added a comment.


  Asynchronous return values

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28134?vs=77976=78030

BRANCH
  cblack/colour-utils

REVISION DETAIL
  https://phabricator.kde.org/D28134

AFFECTED FILES
  src/CMakeLists.txt
  src/colorutils.cpp
  src/colorutils.h
  src/kirigamiplugin.cpp
  src/pendingvalue.cpp
  src/pendingvalue.h

To: cblack, #plasma, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28143: Add "veryLongDuration" animation duration

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  As discussed in D28033#630649 .

TEST PLAN
  Compiles. Not used anywhere yet, so no testing possible.

REPOSITORY
  R169 Kirigami

BRANCH
  veryLongDuration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28143

AFFECTED FILES
  src/controls/Units.qml
  src/styles/org.kde.desktop/Units.qml

To: ngraham, #vdg, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28109: [applets/systemtray] Simplify icon size logic

[Nathaniel Graham]

ngraham added a comment.


  Depends on the view; most people don't seem to use Phab's homepage so much 
compared to the email notifications generated when you mention people like 
@broulik, @mart, or @davidedmundson  ;)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28109

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28109: [applets/systemtray] Simplify icon size logic

[Konrad Materka]

kmaterka added a comment.


  In D28109#629974 , @ngraham wrote:
  
  > This looks like a sensible refactor to me, and it solves the issue that I 
was having with icon size changing based on the expanded popup visibility. I 
can't detect any regressions in sizing with horizontal or vertical panels of 
various sizes. However please wait to land this until somebody else possessing 
greater familiarity with this codebase such as @broulik, @mart, or 
@davidedmundson reviews it too.
  
  
  @ngraham the problem is when diff is marked as reviewed, they don't see it :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28109

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25428: Improved support for desktop "Folder View"

[Christoph Feck]

cfeck added a comment.


  Anyone else able to review this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27509: Introduce ProcessDataModel

[David Edmundson]

davidedmundson updated this revision to Diff 78025.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.


  lambdas everywhere

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27509?vs=76653=78025

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27509

AFFECTED FILES
  CMakeLists.txt
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/process_attribute.cpp
  processcore/process_attribute.h
  processcore/process_attribute_model.cpp
  processcore/process_attribute_model.h
  processcore/process_data_model.cpp
  processcore/process_data_model.h
  processui/ProcessModel.cpp

To: davidedmundson, #plasma
Cc: ahiemstra, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D28142: Display PID & signal numbers unlocalized

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Not tested though, somehow my setup prevents my custom drkonqi to show up. So 
far I just know it tells and should work in theory.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28142

To: kossebau, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28142: Display PID & signal numbers unlocalized

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  These are less numbers, but more identifiers in the system.

REPOSITORY
  R871 DrKonqi

BRANCH
  fixpiddisplay

REVISION DETAIL
  https://phabricator.kde.org/D28142

AFFECTED FILES
  src/drkonqidialog.cpp

To: kossebau, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan added a comment.


  > used Layouts instead of Anchors
  
  I know, I'm oldschool - when I was young, we didn't have QML, Kirigami and 
... :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:36e322792002: Add the option to show the current activity 
name and icon (authored by ivan).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28136?vs=78018=78021

REVISION DETAIL
  https://phabricator.kde.org/D28136

AFFECTED FILES
  applets/showActivityManager/package/contents/config/config.qml
  applets/showActivityManager/package/contents/config/main.xml
  applets/showActivityManager/package/contents/ui/ConfigAppearance.qml
  applets/showActivityManager/package/contents/ui/main.qml

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> broulik wrote in converterrunner.cpp:74
> There's also units with µ, Ω, . (fl.oz.), not taking into account how those 
> might be localized, so using a very specific regexp looks somewhat brittle to 
> me. Can't really think of a better way, though...

Well the only idea I have is to allow everything as a unit and let the 
conversion backend decide if it is valid.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 78020.
ahiemstra added a comment.


  - Add some documentation to classes

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78017=78020

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!
  
  I'd still prefer if main.qml used Layouts instead of Anchors, I also still 
think the option to show a generic icon is not really very useful; I have a 
hard time envisioning a user who manually sets icons for their activities but 
prefers to show a generic icon in the pager. However I don't use activities and 
it's your code, so your call. :)

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28098: remove pointless and arbitrary 4 line frame limit

[Ahmad Samir]

ahmadsamir added a comment.


  In D28098#629338 , @bcooksley 
wrote:
  
  > There should be no further changes to Dr Konqi at this time as it fails to 
build from source on both FreeBSD and Windows.
  >  Please see the relevant CI jobs for more information - 
https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/
  
  
  That should really be fixed by D28123 ; I 
see the latest build was ~ 2 hours ago, but it still fails, maybe the CI still 
doesn't have latest KCrash?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28098

To: sitter, apol, bcooksley
Cc: ahmadsamir, bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27166: Refactor converter runner

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> converterrunner.cpp:74
> +const QString valueGroup = 
> QStringLiteral("(?P<%1>[0-9,./]+)").arg(valueKey);
> +const QString unitGroups = 
> QStringLiteral("(?P<%1>[a-zA-Z/\"'^0-9\\p{Sc}²³]+)");
> +const QString sourceUnitGroup = unitGroups.arg(sourceUnitKey);

There's also units with µ, Ω, . (fl.oz.), not taking into account how those 
might be localized, so using a very specific regexp looks somewhat brittle to 
me. Can't really think of a better way, though...

> converterrunner.cpp:129
> +if (outputUnit.categoryId() == KUnitConversion::CurrencyCategory) {
> +outputValue.round(2);
>  }

I thought `KUnitConversion` was doing that when requesting a pretty string

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan added a comment.


  Last change - use "activities" icon if no icon is set (though this should not 
happen if the user creates the activity through legal ways)

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex added a comment.


  > "5 EUR" produces: 4.6095 GBP, 5.467 USD, 7.8745 CAD with too many decimals 
(@sitter says this is some unrelated bug)
  >  "5 m²" doesn't yield any results. In fact none of the ² or ³ do
  
  Fixed in the latest commit.
  
  > Units seem to be matching case sensitive now, i.e. "5 Liter" (German 
locale) doesn't yield any results, wheras "5 liter" does
  
  I will have a look at this too and update the test 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan updated this revision to Diff 78018.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28136?vs=78014=78018

REVISION DETAIL
  https://phabricator.kde.org/D28136

AFFECTED FILES
  applets/showActivityManager/package/contents/config/config.qml
  applets/showActivityManager/package/contents/config/main.xml
  applets/showActivityManager/package/contents/ui/ConfigAppearance.qml
  applets/showActivityManager/package/contents/ui/main.qml

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28027: fix line rating for new format when function name is missing

[Ahmad Samir]

ahmadsamir added a comment.


  In D28027#630512 , @sitter wrote:
  
  > D28026 
  
  
  Ah, yes, that's where those "packagekit" lines are. Thanks :)

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a new library for communicating with a new KSysGuard
  DBus-based daemon that provides sensors. The daemon will be
  posted by d_ed later on.
  
  This new library pretty much maps the different objects from
  the daemon to C++ objects.

TEST PLAN
  None yet, needs the new daemon.

REPOSITORY
  R111 KSysguard Library

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex updated this revision to Diff 78016.
alex added a comment.


  Fix regex, round currencies to two decimal counts

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27166?vs=78007=78016

BRANCH
  converter_runner_refactoring (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27166

AFFECTED FILES
  CMakeLists.txt
  runners/converter/CMakeLists.txt
  runners/converter/autotests/CMakeLists.txt
  runners/converter/autotests/converterrunnertest.cpp
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan marked 3 inline comments as done.
ivan added a comment.


  Done

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan updated this revision to Diff 78014.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28136?vs=78006=78014

REVISION DETAIL
  https://phabricator.kde.org/D28136

AFFECTED FILES
  applets/showActivityManager/package/contents/config/config.qml
  applets/showActivityManager/package/contents/config/main.xml
  applets/showActivityManager/package/contents/ui/ConfigAppearance.qml
  applets/showActivityManager/package/contents/ui/main.qml

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Harald Sitter]

sitter requested changes to this revision.
sitter added a comment.
This revision now requires changes to proceed.


  Please also add test cases for the regressions Kai highlighted. Thanks!

INLINE COMMENTS

> broulik wrote in converterrunnertest.cpp:75
> I think you should change the locale for the unittest to `C` or `en_US` 
> (dunno how, needs someone with more test knowledge :D) since those are 
> translated and fail when I run the test locally

the servicerunnertest in plasma-workspace is actually doing that by simply 
calling setlocale I think. that should be good enough so long as it gets called 
early enough

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Kai Uwe Broulik]

broulik added a comment.


  Nice refactoring work! Quick testing suggests a few issues, however. I 
haven't verified if they have been present before or are in KUnitConversion, 
but:
  
  "5 EUR" produces: 4.6095 GBP, 5.467 USD7.8745 CAD (@sitter says this is some 
unrelated bug)
  "5 l/100km" (fuel consumption) doesn't yield any result (@sitter says this 
didn't work before either)
  "5 m²" doesn't yield any results. In fact none of the ² or ³ do
  Units seem to be matching case sensitive now, i.e. "5 Liter" (German locale) 
doesn't yield any results, wheras "5 liter" does

INLINE COMMENTS

> converterrunnertest.cpp:75
> +QCOMPARE(context.matches().count(), 1);
> +QCOMPARE(context.matches().first().text(), QStringLiteral("100 
> centimeters (cm)"));
> +}

I think you should change the locale for the unittest to `C` or `en_US` (dunno 
how, needs someone with more test knowledge :D) since those are translated and 
fail when I run the test locally

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_runner_refactoring (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28140: Add a declarative plugin to ProcessCore

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a QML plugin to ProcessCore that exposes ProcessController
  and allows it to be used from QML, along with some changes the were
  needed to actually use it from QML and a manual test to verify that
  the QML bits work.
  
  This will later on be expanded to also expose other types, including
  ProcessDataModel from D27509 

TEST PLAN
  The test runs and can send signals to processes.

REPOSITORY
  R111 KSysguard Library

BRANCH
  processcore_declarative

REVISION DETAIL
  https://phabricator.kde.org/D28140

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/declarative/CMakeLists.txt
  processcore/declarative/ProcessEnums.cpp
  processcore/declarative/ProcessEnums.h
  processcore/declarative/ProcessPlugin.cpp
  processcore/declarative/ProcessPlugin.h
  processcore/declarative/qmldir
  processcore/process_controller.cpp
  processcore/process_controller.h
  tests/process/test_process.qml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigAppearance.qml:48
> +}
> +
> +CheckBox {

I would add some whitespace between these, since they're different logical 
groups. You can easily do this with the following:

`item { Kirigami.FormData.isSection: true }`

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27096: Refactoring, improve validation in kcm, optimize

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:8dd8fe555a1e: characters: Refactoring, improve validation 
in kcm, optimize (authored by alex, committed by sitter).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27096?vs=76350=78012

REVISION DETAIL
  https://phabricator.kde.org/D27096

AFFECTED FILES
  runners/characters/charrunner.cpp
  runners/characters/charrunner.h
  runners/characters/charrunner_config.cpp
  runners/characters/charrunner_config.h
  runners/characters/charrunner_config.ui
  runners/characters/config_keys.h

To: alex, davidedmundson, ngraham, sitter, broulik, #plasma
Cc: davidre, dvratil, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25984: Load translations

[Volker Krause]

vkrause added a comment.


  In D25984#589426 , @mart wrote:
  
  > ping, what's the current status of this?
  
  
  There's also https://phabricator.kde.org/D27595, which might address the 
same/a similar issue.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: vkrause, mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra

D28129: Read the new message string after rather than before

[Harald Sitter]

sitter added a comment.


  Quick recap from what we talked about on telegram: putting the print after 
the bt is most definitely going to throw off the backtrace parsing logic, so 
doing it this way would require extensive changes there, which is a dangerous 
place to make extensive changes.
  Or we could define a simple function to ignore errors 
https://stackoverflow.com/questions/17923865/gdb-stops-in-a-command-file-if-there-is-an-error-how-to-continue-despite-the-er
 but that's also a bit faffy.
  Another completely standalone approach would be to change BacktraceGenerator 
(I think?) to invoke the print in a completely independent gdb invocation i.e. 
separate the print call from the regular batchcommands and have drkonqi 
assemble it back into the final report. That way the actual tracing batch 
command couldn't fail on the print.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28129

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex updated this revision to Diff 78007.
alex added a comment.


  Implement requested changes

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27166?vs=77899=78007

BRANCH
  converter_runner_refactoring (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27166

AFFECTED FILES
  CMakeLists.txt
  runners/converter/CMakeLists.txt
  runners/converter/autotests/CMakeLists.txt
  runners/converter/autotests/converterrunnertest.cpp
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan added a comment.


  Kirigami has quite interesting features I must say :)

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan updated this revision to Diff 78006.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28136?vs=77985=78006

REVISION DETAIL
  https://phabricator.kde.org/D28136

AFFECTED FILES
  applets/showActivityManager/package/contents/config/config.qml
  applets/showActivityManager/package/contents/config/main.xml
  applets/showActivityManager/package/contents/ui/ConfigAppearance.qml
  applets/showActivityManager/package/contents/ui/main.qml

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27869: Separate processcore/{formatter,unit} into its own library

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:182fbd95dc94: Separate processcore/{formatter,unit} into 
its own library (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27869?vs=77038=78005

REVISION DETAIL
  https://phabricator.kde.org/D27869

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/formattertest.cpp
  formatter/CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.cpp
  formatter/Unit.h
  formatter/declarative/CMakeLists.txt
  formatter/declarative/FormatterPlugin.cpp
  formatter/declarative/FormatterPlugin.h
  formatter/declarative/FormatterWrapper.cpp
  formatter/declarative/FormatterWrapper.h
  formatter/declarative/qmldir
  processcore/CMakeLists.txt
  processcore/formatter.cpp
  processcore/formatter.h
  processcore/unit.cpp
  processcore/unit.h
  tests/formatter/test_formatter.qml

To: ahiemstra, #plasma, davidedmundson
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 776 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/776/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 19 Mar 2020 14:27:54 +
 Build duration:
1 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 2585 lines...][2020-03-19T14:29:21.610Z] [ 55%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/main.cpp.o[2020-03-19T14:29:21.610Z] [ 56%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/statusnotifiertest.cpp.o[2020-03-19T14:29:21.610Z] [ 56%] Linking CXX shared module ../../../bin/org.kde.plasma.panelspacer.so[2020-03-19T14:29:21.866Z] [ 56%] Building CXX object applets/systemtray/tests/statusnotifier/CMakeFiles/statusnotifiertest.dir/pumpjob.cpp.o[2020-03-19T14:29:21.866Z] Scanning dependencies of target plasma_engine_applicationjobs_autogen[2020-03-19T14:29:21.866Z] [ 57%] Generating plasma-dataengine-applicationjobs.json[2020-03-19T14:29:21.866Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-dataengine.desktop"[2020-03-19T14:29:21.866Z] Found property definition "X-KDE-ParentApp" with type "QString"[2020-03-19T14:29:21.866Z] Generated  "/home/jenkins/workspace/Plasma/plasma-workspace/kf5-qt5 SUSEQt5.12/build/dataengines/applicationjobs/plasma-dataengine-applicationjobs.json"[2020-03-19T14:29:21.866Z] [ 57%] Automatic MOC for target plasma_engine_applicationjobs[2020-03-19T14:29:22.122Z] [ 57%] Built target plasma_engine_applicationjobs_autogen[2020-03-19T14:29:22.122Z] [ 57%] Generating ActivityRankingInterface.cpp, ActivityRankingInterface.h[2020-03-19T14:29:22.122Z] [ 57%] Generating ActivityRankingInterface.moc[2020-03-19T14:29:22.122Z] Scanning dependencies of target plasma_engine_activities[2020-03-19T14:29:22.122Z] [ 57%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/plasma_engine_activities_autogen/mocs_compilation.cpp.o[2020-03-19T14:29:22.377Z] [ 57%] Building CXX object dataengines/activities/CMakeFiles/plasma_engine_activities.dir/ActivityData.cpp.o[2020-03-19T14:29:22.377Z] [ 57%] Built target org.kde.plasma.panelspacer[2020-03-19T14:29:22.377Z] Scanning dependencies of target plasma_engine_apps[2020-03-19T14:29:22.377Z] [ 57%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/plasma_engine_apps_autogen/mocs_compilation.cpp.o[2020-03-19T14:29:22.632Z] [ 57%] Linking CXX shared module ../../../bin/org.kde.plasma.systemtray.so[2020-03-19T14:29:22.632Z] Scanning dependencies of target plasma_engine_devicenotifications[2020-03-19T14:29:22.632Z] [ 58%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/plasma_engine_devicenotifications_autogen/mocs_compilation.cpp.o[2020-03-19T14:29:22.632Z] [ 58%] Linking CXX shared module ../../bin/org.kde.plasma.private.systemtray.so[2020-03-19T14:29:22.889Z] Scanning dependencies of target plasma_engine_dict[2020-03-19T14:29:22.889Z] [ 58%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/plasma_engine_dict_autogen/mocs_compilation.cpp.o[2020-03-19T14:29:22.889Z] [ 58%] Building CXX object dataengines/dict/CMakeFiles/plasma_engine_dict.dir/dictengine.cpp.o[2020-03-19T14:29:23.146Z] [ 58%] Linking CXX shared module ../../bin/plasma_applet_notifications.so[2020-03-19T14:29:23.146Z] Scanning dependencies of target plasma_engine_executable[2020-03-19T14:29:23.146Z] [ 58%] Building CXX object dataengines/executable/CMakeFiles/plasma_engine_executable.dir/plasma_engine_executable_autogen/mocs_compilation.cpp.o[2020-03-19T14:29:23.146Z] [ 58%] Built target org.kde.plasma.private.systemtray[2020-03-19T14:29:23.146Z] [ 58%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsengine.cpp.o[2020-03-19T14:29:23.146Z] [ 58%] Built target org.kde.plasma.systemtray[2020-03-19T14:29:23.146Z] [ 59%] Building CXX object dataengines/executable/CMakeFiles/plasma_engine_executable.dir/executable.cpp.o[2020-03-19T14:29:23.404Z] [ 59%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appsource.cpp.o[2020-03-19T14:29:23.404Z] [ 59%] Building CXX object dataengines/devicenotifications/CMakeFiles/plasma_engine_devicenotifications.dir/devicenotificationsengine.cpp.o[2020-03-19T14:29:23.404Z] [ 59%] Linking CXX shared library ../../../bin/libdigitalclockplugin.so[2020-03-19T14:29:23.404Z] [ 59%] Linking CXX executable ../../../../bin/statusnotifiertest[2020-03-19T14:29:23.404Z] [ 59%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appservice.cpp.o[2020-03-19T14:29:23.662Z] [ 59%] Built target plasma_applet_notifications[2020-03-19T14:29:23.662Z] [ 59%] Building CXX object dataengines/apps/CMakeFiles/plasma_engine_apps.dir/appjob.cpp.o[2020-03-19T14:29:23.662Z] [ 59%] Building CXX object 

D28138: some static analyzer improvements for service runner

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fab5b5e26d7e: some static analyzer improvements for 
service runner (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28138?vs=78001=78004#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28138?vs=78001=78004

REVISION DETAIL
  https://phabricator.kde.org/D28138

AFFECTED FILES
  runners/services/autotests/servicerunnertest.cpp
  runners/services/servicerunner.cpp
  runners/services/servicerunner.h

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28027: fix line rating for new format when function name is missing

[Harald Sitter]

sitter added a comment.


  D28026 

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan added a comment.


  The reason for the icon setting is to have full backwards compatibility. 
Maybe someone likes the static icon better than random icons they set for each 
activity. I don't  like to have everything configurable, but here it is not a 
significant maintainance overhead, and the configuration dialogue would be 
quite dull with a single checkbox :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Harald Sitter]

sitter updated this revision to Diff 78003.
sitter added a comment.


  - isValid is const now
  - use qdiriterator
  - use QFile::encodeName for the stat call

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27980?vs=77716=78003

BRANCH
  multidri

REVISION DETAIL
  https://phabricator.kde.org/D27980

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28138: some static analyzer improvements for service runner

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> servicerunner.cpp:114
> +for(int i = 1; i < strList.size(); ++i) {
> +const auto  = strList[i];
>  if (category == QLatin1String("Name")) {

Perhaps use `.at(i)`

> servicerunner.cpp:464
>  
> -QMimeData *data = new QMimeData();
> +auto data = new QMimeData();
>  data->setUrls(QList{QUrl::fromLocalFile(path)});

Keep the `*` :p

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28138

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28138: some static analyzer improvements for service runner

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - be more consty (and don't risk detatching containers)
  - init members
  - don't ql1s to qstring
  - use auto when newing an object

TEST PLAN
  test passes

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28138

AFFECTED FILES
  runners/services/autotests/servicerunnertest.cpp
  runners/services/servicerunner.cpp
  runners/services/servicerunner.h

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

zzag added a comment.


  Urgh, the authorship information is screwed up. :/

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for 
the xkb  keymap (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14910?vs=77916=78000

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/CMakeLists.txt
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson, zzag
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28137: make servicerunner only build once

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  build the runner itself in a static lib we can use for testing and then
  link that into a module lib together with the factory entry point to
  compose the final lib for installation
  
  means servicesrunner.cpp is now only built once, whereas before it was
  built twice through 100% duplicative targets

TEST PLAN
  test still passes, installing and restarting krunner still yields working 
service searches

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28137

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/autotests/CMakeLists.txt
  runners/services/plugin.cpp
  runners/services/servicerunner.cpp

To: sitter, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> sitter wrote in opengl.cpp:210
> Is that also true for paths that are only ascii? Specifically path is a /dev 
> node.

sure, i get this specific path is ascii

the general recommendation is to use QFile::encodeName for QString -> C paths 
conversions, no matter what (and viceversa QFile::decodeName for C -> QString); 
i personally always use these two avoid any possible future mistake

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28136: Add the option to show the current activity name and icon

[Nathaniel Graham]

ngraham added a comment.


  Pretty nice! I wonder if we even need an option for the activity option 
though. How about this: if the activity has an icon, always show it. If it 
doesn't, show the generic one. That would probably satisfy everyone 
automatically, by re-using the user's preference with respect to icons for 
their activities.
  
  Also in general it's nice to see Layouts used in new code as it tends to 
substantially simplify the width and height code for individual items.

INLINE COMMENTS

> ConfigAppearance.qml:36
> +Label {
> +text: i18n("Icon:")
> +}

this should instead be a `Kirigami.FormData.label: `i18n("Icon:")` property set 
on `radioCurrentActivityIcon`

> ConfigAppearance.qml:53
> +Label {
> +text: i18n("Title:");
> +}

this should instead be a `Kirigami.FormData.label: `i18n("Title:")` property 
set on `checkShowActivityName`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma, ngraham, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 13:18:46 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 294 lines...][2020-03-19T13:33:03.668Z]  * KF5Completion (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-19T13:33:03.668Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-19T13:33:03.668Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * Qt5Core (required version >= 5.12.0)[2020-03-19T13:33:03.668Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-19T13:33:03.668Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * KF5 (required version >= 5.69.0)[2020-03-19T13:33:03.668Z]  * Qt5Test[2020-03-19T13:33:03.668Z] [2020-03-19T13:33:03.668Z] -- The following features have been disabled:[2020-03-19T13:33:03.668Z] [2020-03-19T13:33:03.668Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-19T13:33:03.668Z] [2020-03-19T13:33:03.668Z] -- Configuring done[2020-03-19T13:33:03.926Z] -- Generating done[2020-03-19T13:33:03.926Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-19T13:33:05.084Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project drkonqi --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-19T13:33:05.084Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2020-03-19T13:33:05.084Z] Scanning dependencies of target qbugzilla_autogen[2020-03-19T13:33:05.084Z] Scanning dependencies of target lsb_release_autogen[2020-03-19T13:33:05.084Z] Scanning dependencies of target crashtest_autogen[2020-03-19T13:33:05.084Z] [  1%] Automatic MOC for target drkonqi_backtrace_parser[2020-03-19T13:33:05.084Z] [  1%] Automatic MOC for target crashtest[2020-03-19T13:33:05.084Z] [  1%] Automatic MOC for target lsb_release[2020-03-19T13:33:05.084Z] [  2%] Automatic MOC for target qbugzilla[2020-03-19T13:33:05.084Z] [  2%] Built target lsb_release_autogen[2020-03-19T13:33:05.084Z] [  2%] Built target crashtest_autogen[2020-03-19T13:33:05.084Z] Scanning dependencies of target lsb_release[2020-03-19T13:33:05.084Z] [  2%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.o[2020-03-19T13:33:05.084Z] [  3%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.o[2020-03-19T13:33:05.343Z] [  4%] Linking CXX executable ../../bin/lsb_release[2020-03-19T13:33:05.343Z] Scanning dependencies of target crashtest[2020-03-19T13:33:05.343Z] [  4%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.o[2020-03-19T13:33:05.343Z] [  5%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.o[2020-03-19T13:33:05.343Z] [  5%] Built target lsb_release[2020-03-19T13:33:05.923Z] [  5%] Built target drkonqi_backtrace_parser_autogen[2020-03-19T13:33:05.923Z] [  5%] Built target qbugzilla_autogen[2020-03-19T13:33:05.923Z] Scanning dependencies of target drkonqi_backtrace_parser[2020-03-19T13:33:05.923Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.o[2020-03-19T13:33:05.923Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.o[2020-03-19T13:33:05.923Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.o[2020-03-19T13:33:05.923Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.o[2020-03-19T13:33:05.923Z] [  9%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.o[2020-03-19T13:33:05.923Z] [  9%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.o[2020-03-19T13:33:05.923Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.o[2020-03-19T13:33:05.923Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.o[2020-03-19T13:33:05.923Z] Scanning dependencies of target qbugzilla[2020-03-19T13:33:05.923Z] [ 11%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/qbugzilla_autogen/mocs_compilation.cpp.o[2020-03-19T13:33:05.923Z] [ 11%] Building CXX object 

D28027: fix line rating for new format when function name is missing

[Ahmad Samir]

ahmadsamir added a comment.


  This doesn't apply cleanly.

REPOSITORY
  R871 DrKonqi

BRANCH
  parse-rate

REVISION DETAIL
  https://phabricator.kde.org/D28027

To: sitter, cfeck, ngraham
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/17/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 19 Mar 2020 13:18:44 +
 Build duration:
2 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 341 lines...][2020-03-19T13:20:55.279Z]  * Qt5Concurrent[2020-03-19T13:20:55.279Z]  * Qt5 (required version >= 5.12.0)[2020-03-19T13:20:55.279Z]  * Gettext[2020-03-19T13:20:55.279Z]  * KF5I18n (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5CoreAddons (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5Service (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5ConfigWidgets (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5JobWidgets (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5KIO (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5Crash (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5Completion (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KF5 (required version >= 5.69.0)[2020-03-19T13:20:55.279Z]  * KDEWin[2020-03-19T13:20:55.279Z]  * Qt5Test[2020-03-19T13:20:55.279Z] [2020-03-19T13:20:55.279Z] -- The following features have been disabled:[2020-03-19T13:20:55.279Z] [2020-03-19T13:20:55.279Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-19T13:20:55.279Z] [2020-03-19T13:20:55.279Z] -- The following RECOMMENDED packages have not been found:[2020-03-19T13:20:55.279Z] [2020-03-19T13:20:55.279Z]  * Qt5X11Extras (required version >= 5.12.0)[2020-03-19T13:20:55.279Z]Recommended for better integration on X11.[2020-03-19T13:20:55.279Z] [2020-03-19T13:20:55.539Z] -- Configuring done[2020-03-19T13:20:56.480Z] -- Generating done[2020-03-19T13:20:56.480Z] -- Build files have been written to: C:/CI/Job Build/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2020-03-19T13:21:01.158Z] [2020-03-19T13:21:01.159Z] C:\CI\Job Build>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" [2020-03-19T13:21:01.159Z] **[2020-03-19T13:21:01.159Z] ** Visual Studio 2019 Developer Command Prompt v16.4.3[2020-03-19T13:21:01.159Z] ** Copyright (c) 2019 Microsoft Corporation[2020-03-19T13:21:01.159Z] **[2020-03-19T13:21:02.112Z] [vcvarsall.bat] Environment initialized for: 'x64'[2020-03-19T13:21:02.371Z] [1/149] Automatic MOC for target drkonqi_backtrace_parser[2020-03-19T13:21:02.371Z] [2/149] Automatic MOC for target crashtest[2020-03-19T13:21:02.371Z] [3/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest_autogen\mocs_compilation.cpp.obj[2020-03-19T13:21:02.371Z] [4/149] Automatic MOC for target qbugzilla[2020-03-19T13:21:02.630Z] [5/149] Automatic MOC for target kdbgwin[2020-03-19T13:21:03.202Z] [6/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj[2020-03-19T13:21:03.202Z] [7/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsernull.cpp.obj[2020-03-19T13:21:03.461Z] [8/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_backtrace_parser_autogen\mocs_compilation.cpp.obj[2020-03-19T13:21:03.461Z] [9/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserlldb.cpp.obj[2020-03-19T13:21:03.461Z] [10/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj[2020-03-19T13:21:03.461Z] [11/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj[2020-03-19T13:21:03.461Z] [12/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj[2020-03-19T13:21:03.461Z] [13/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj[2020-03-19T13:21:03.461Z] [14/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj[2020-03-19T13:21:03.461Z] [15/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj[2020-03-19T13:21:03.720Z] [16/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\apijob.cpp.obj[2020-03-19T13:21:03.720Z] [17/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest.cpp.obj[2020-03-19T13:21:04.290Z] 

D27166: Refactor converter runner

[Harald Sitter]

sitter requested changes to this revision.
sitter added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:23
> +endif()
> \ No newline at end of file


No newline at end of file

> CMakeLists.txt:6
> +ecm_add_test(converterrunnertest.cpp TEST_NAME converterrunnertest 
> LINK_LIBRARIES Qt5::Test krunner_converter_test)
> \ No newline at end of file


No newline at end of file

> converterrunnertest.cpp:42
> +private:
> +ConverterRunner *runner;
> +};

`= nullptr`

In fact, you could make this a std::unique_ptr because currently it is also not 
getting deleted, not that it matters for a test ^^

> converterrunnertest.cpp:153
> +#include "converterrunnertest.moc"
> \ No newline at end of file


No newline at end of file

> converterrunner.cpp:83
>  
>  ConverterRunner::~ConverterRunner()
>  {

Seeing as this now doesn't do anything you can `= default` it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28042: [DrKonqi] Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:8d8062fe6bdc: [DrKonqi] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28042?vs=77744=77995

REVISION DETAIL
  https://phabricator.kde.org/D28042

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.cpp
  src/gdbhighlighter.cpp
  src/parser/backtraceparser.cpp
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparserkdbgwin.cpp

To: ahmadsamir, #plasma, davidedmundson, sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> pino wrote in opengl.cpp:210
> qPrintable is wrong when passing paths to native C functions; use 
> QFile::encodeName instead

Is that also true for paths that are only ascii? Specifically path is a /dev 
node.

> pino wrote in opengl.cpp:230-233
> why not just use QDirIterator instead, so it combines dir listing and 
> filtering?

Hadn't even occured to me. It's a good thought though, I'll get on it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28135: Port away from deprecated QSet/QList methods in some places

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in runnermodel.cpp:179
> But toSet() returns new container m_runners and runners are unmodified.

I don't mind reverting that bit, but it seems wasteful to me to throw 
newRunners away, it is sorted and has no duplicates

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27980: make opengl module support multiple dri devices

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> opengl.cpp:169
> +
> +bool isValid()
> +{

const

> opengl.cpp:210
>  struct stat fileInfo;
> -if (::stat("/dev/dri/card0", ) != 0)
> -return false;
> -if ((fileInfo.st_mode & S_IFCHR) != S_IFCHR)
> -return false;
> +if (::stat(qPrintable(path), ) != 0) {
> +return info;

qPrintable is wrong when passing paths to native C functions; use 
QFile::encodeName instead

> opengl.cpp:230-233
> +const auto entries = QDir("/dev/dri/").entryList(QDir::System);
> +for (const auto  : entries) {
> +if (QDir::match(QStringLiteral("card*"), entry)) {
> +auto info = get_drm_device_sysfs(QStringLiteral("/dev/dri/") + 
> entry);

why not just use QDirIterator instead, so it combines dir listing and filtering?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 19 Mar 2020 11:33:08 +
 Build duration:
49 sec and counting
   CONSOLE OUTPUT
  [...truncated 292 lines...][2020-03-19T11:33:48.764Z]  * KF5Completion (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * KF5WidgetsAddons (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-19T11:33:48.764Z]  * KF5Wallet (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-19T11:33:48.764Z]  * KF5Notifications (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * Qt5Core (required version >= 5.12.0)[2020-03-19T11:33:48.764Z]  * KF5IdleTime (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-19T11:33:48.764Z]  * KF5WindowSystem (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * KF5 (required version >= 5.69.0)[2020-03-19T11:33:48.764Z]  * Qt5Test[2020-03-19T11:33:48.764Z] [2020-03-19T11:33:48.764Z] -- The following features have been disabled:[2020-03-19T11:33:48.764Z] [2020-03-19T11:33:48.764Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-19T11:33:48.764Z] [2020-03-19T11:33:48.764Z] -- Configuring done[2020-03-19T11:33:49.021Z] -- Generating done[2020-03-19T11:33:49.021Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-19T11:33:49.716Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project drkonqi --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-19T11:33:49.716Z] Scanning dependencies of target crashtest_autogen[2020-03-19T11:33:49.716Z] Scanning dependencies of target lsb_release_autogen[2020-03-19T11:33:49.716Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2020-03-19T11:33:49.716Z] Scanning dependencies of target qbugzilla_autogen[2020-03-19T11:33:49.716Z] [  0%] Automatic MOC for target crashtest[2020-03-19T11:33:49.716Z] [  0%] Automatic MOC for target lsb_release[2020-03-19T11:33:49.716Z] [  2%] Automatic MOC for target drkonqi_backtrace_parser[2020-03-19T11:33:49.716Z] [  2%] Automatic MOC for target qbugzilla[2020-03-19T11:33:49.976Z] [  2%] Built target lsb_release_autogen[2020-03-19T11:33:49.976Z] [  2%] Built target crashtest_autogen[2020-03-19T11:33:49.976Z] Scanning dependencies of target lsb_release[2020-03-19T11:33:49.976Z] [  2%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.o[2020-03-19T11:33:49.976Z] [  3%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.o[2020-03-19T11:33:50.237Z] [  4%] Linking CXX executable ../../bin/lsb_release[2020-03-19T11:33:50.237Z] Scanning dependencies of target crashtest[2020-03-19T11:33:50.495Z] [  4%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.o[2020-03-19T11:33:50.495Z] [  5%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.o[2020-03-19T11:33:50.755Z] [  5%] Built target lsb_release[2020-03-19T11:33:51.017Z] [  5%] Built target drkonqi_backtrace_parser_autogen[2020-03-19T11:33:51.017Z] Scanning dependencies of target drkonqi_backtrace_parser[2020-03-19T11:33:51.017Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.o[2020-03-19T11:33:51.017Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.o[2020-03-19T11:33:51.279Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.o[2020-03-19T11:33:51.279Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.o[2020-03-19T11:33:51.552Z] [  8%] Built target qbugzilla_autogen[2020-03-19T11:33:51.552Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.o[2020-03-19T11:33:52.498Z] [  9%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.o[2020-03-19T11:33:52.498Z] [ 10%] Linking CXX executable ../../../bin/crashtest[2020-03-19T11:33:52.498Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.o[2020-03-19T11:33:52.498Z] [ 11%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.o[2020-03-19T11:33:52.758Z] ld: error: undefined symbol: KCrash::setErrorMessage(QString const&)[2020-03-19T11:33:52.758Z] >>> referenced by crashtest.cpp:92 (/usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 

D27971: Solid-device-automounter/kcm: correctly update automountOn

[Méven Car]

meven updated this revision to Diff 77992.
meven marked 2 inline comments as done.
meven added a comment.


  Add third parameter to connect()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27971?vs=77368=77992

BRANCH
  arcpatch-D27971

REVISION DETAIL
  https://phabricator.kde.org/D27971

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp

To: meven, bport, #plasma, ervin, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28135: Port away from deprecated QSet/QList methods in some places

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in runnermodel.cpp:179
> IIUC, the original code used toSet() to remove duplicates from both 
> "m_runners" and "runners", because QSet doesn't allow duplicate items.

But toSet() returns new container m_runners and runners are unmodified.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28135: Port away from deprecated QSet/QList methods in some places

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in runnermodel.cpp:179
> Here should be `m_runners = runners` to be exactly same as previous. I don't 
> see much benefit of having duplicate items.

IIUC, the original code used toSet() to remove duplicates from both "m_runners" 
and "runners", because QSet doesn't allow duplicate items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28135: Port away from deprecated QSet/QList methods in some places

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> runnermodel.cpp:179
> +if (currRunners != newRunners) {
> +m_runners = newRunners;
>  

Here should be `m_runners = runners` to be exactly same as previous. I don't 
see much benefit of having duplicate items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28135

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28136: Add the option to show the current activity name and icon

[Ivan Čukić]

ivan added a comment.


  Screenshot:
  
  F8184234: Screenshot_20200319_112003.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28136

To: ivan, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart