Re: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

[Ömer Fadıl USTA]

Ben Cooksley , 25 Mar 2020 Çar, 07:48 tarihinde şunu
yazdı:

> The Dependency Build says plasma-desktop is broken.
>
> Ideas anyone?
>
> Hello ben, It looks like this will solve that problem :
https://phabricator.kde.org/D28232
Could you apply that patch and try if it fixes the problem?

And the problem is here :

*06:24:21*  /home/jenkins/workspace/Administration/Dependency Build
Plasma kf5-qt5 
SUSEQt5.12/plasma-desktop/kcms/spellchecking/spellchecking.cpp:69:119:
error: no matching function for call to
���QSet::QSet(QList::iterator,
QList::iterator)���*06:24:21* 69 | QSet
defaultPreferredLanguages(defaultPreferredLanguagesList.begin(),
defaultPreferredLanguagesList.end());*06:24:21*|

 ^*06:24:21*  In file included from
/usr/include/qt5/QtCore/QSet:1,*06:24:21*   from
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/spellchecking/spellchecking.cpp:27:*06:24:21*
 /usr/include/qt5/QtCore/qset.h:61:12: note: candidate:
���QSet::QSet(std::initializer_list<_Tp>) [with T =
QString]���*06:24:21* 61 | inline
QSet(std::initializer_list list)*06:24:21*|
^~~~*06:24:21*  /usr/include/qt5/QtCore/qset.h:61:12: note:
candidate expects 1 argument, 2 provided*06:24:21*
/usr/include/qt5/QtCore/qset.h:59:12: note: candidate:
���QSet::QSet() [with T = QString]���*06:24:21* 59 | inline
QSet() Q_DECL_NOTHROW {}*06:24:21*|^~~~*06:24:21*
/usr/include/qt5/QtCore/qset.h:59:12: note:   candidate expects 0
arguments, 2 provided*06:24:21*  /usr/include/qt5/QtCore/qset.h:54:7:
note: candidate: ���QSet::QSet(const
QSet&)���*06:24:21* 54 | class QSet*06:24:21*|
   ^~~~*06:24:21*  /usr/include/qt5/QtCore/qset.h:54:7: note:
candidate expects 1 argument, 2 provided*06:24:21*
/usr/include/qt5/QtCore/qset.h:54:7: note: candidate:
���QSet::QSet(QSet&&)���*06:24:21*
/usr/include/qt5/QtCore/qset.h:54:7: note:   candidate expects 1
argument, 2 provided*06:24:21*  Scanning dependencies of target
kded_touchpad*06:24:21*  [ 66%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kded_touchpad_autogen/mocs_compilation.cpp.o*06:24:21*
 make[2]: *** [kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/build.make:89:
kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/spellchecking.cpp.o]
Error 1*06:24:21*  make[1]: *** [CMakeFiles/Makefile2:7597:
kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/all] Error
2*06:24:21*  make[1]: *** Waiting for unfinished jobs

Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

[Ben Cooksley]

The Dependency Build says plasma-desktop is broken.

Ideas anyone?

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Wed, Mar 25, 2020 at 4:24 PM
Subject: KDE CI: Administration » Dependency Build Plasma kf5-qt5
SUSEQt5.12 - Build # 95 - Failure!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20kf5-qt5%20SUSEQt5.12/95/
Project: Dependency Build Plasma kf5-qt5 SUSEQt5.12
Date of build: Wed, 25 Mar 2020 02:06:55 +
Build duration: 1 hr 17 min and counting
* CONSOLE OUTPUT *
[...truncated 102315 lines...]
[2020-03-25T03:24:24.987Z] [ 70%] Building CXX object
kcms/cursortheme/CMakeFiles/kcm_cursortheme.dir/__/krdb/krdb.cpp.o
[2020-03-25T03:24:24.987Z] [ 70%] Building CXX object
kcms/baloo/CMakeFiles/kcm_baloofile.dir/filteredfoldermodel.cpp.o
[2020-03-25T03:24:24.987Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kcm/xlib/testarea.cpp.o
[2020-03-25T03:24:25.245Z] [ 70%] Linking CXX shared module
../../bin/kcm_solid_actions.so
[2020-03-25T03:24:25.245Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kcm/xlib/testbutton.cpp.o
[2020-03-25T03:24:25.503Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kcm/xlib/touchpadconfigxlib.cpp.o
[2020-03-25T03:24:25.503Z] [ 70%] Linking CXX shared module
../../bin/kcm_workspace.so
[2020-03-25T03:24:25.503Z] [ 70%] Building CXX object
kcms/cursortheme/CMakeFiles/kcm_cursortheme.dir/cursorthemesettings.cpp.o
[2020-03-25T03:24:25.760Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kcm/xlib/touchpadparametersbase.cpp.o
[2020-03-25T03:24:25.760Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kcm/xlib/customconfigdialogmanager.cpp.o
[2020-03-25T03:24:25.760Z] [ 70%] Built target kcm_solid_actions
[2020-03-25T03:24:25.760Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/touchpadinterface.cpp.o
[2020-03-25T03:24:25.760Z]
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/cursortheme/xcursor/previewwidget.cpp:79:36:
warning: type qualifiers ignored on function return type
[-Wignored-qualifiers]
[2020-03-25T03:24:25.760Z] 79 | operator const uint32_t () const { return
m_cursor; }
[2020-03-25T03:24:25.760Z] | ^
[2020-03-25T03:24:25.760Z]
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/cursortheme/xcursor/previewwidget.cpp: In
member function ���virtual void
PreviewWidget::hoverLeaveEvent(QHoverEvent*)���:
[2020-03-25T03:24:25.761Z]
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/cursortheme/xcursor/previewwidget.cpp:312:50:
warning: unused parameter ���e��� [-Wunused-parameter]
[2020-03-25T03:24:25.761Z] 312 | void
PreviewWidget::hoverLeaveEvent(QHoverEvent *e)
[2020-03-25T03:24:25.761Z] | ~^
[2020-03-25T03:24:25.761Z]
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/krdb/krdb.cpp: In function ���void
applyGtkStyles(bool, int)���:
[2020-03-25T03:24:25.761Z]
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/krdb/krdb.cpp:97:33: warning: unused
parameter ���active��� [-Wunused-parameter]
[2020-03-25T03:24:25.761Z] 97 | static void applyGtkStyles(bool active, int
version)
[2020-03-25T03:24:25.761Z] | ~^~
[2020-03-25T03:24:26.324Z] [ 70%] Built target kcm_workspace
[2020-03-25T03:24:26.324Z] [ 70%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/qrc_resources.cpp.o
[2020-03-25T03:24:26.324Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/touchpadparameters.cpp.o
[2020-03-25T03:24:26.324Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kded/kded.cpp.o
[2020-03-25T03:24:26.324Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kded/kdedactions.cpp.o
[2020-03-25T03:24:26.324Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/kdedsettings.cpp.o
[2020-03-25T03:24:26.324Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/backends/x11/propertyinfo.cpp.o
[2020-03-25T03:24:26.580Z] [ 71%] Linking CXX shared module
../../bin/kcm_baloofile.so
[2020-03-25T03:24:26.580Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/backends/x11/xlibbackend.cpp.o
[2020-03-25T03:24:26.835Z] [ 71%] Building CXX object
kcms/touchpad/src/CMakeFiles/kded_touchpad.dir/backends/x11/synapticstouchpad.cpp.o
[2020-03-25T03:24:27.090Z]
/home/jenkins/workspace/Administration/Dependency Build Plasma kf5-qt5
SUSEQt5.12/plasma-desktop/kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp:
In constructor
���TouchpadConfigXlib::TouchpadConfigXlib(TouchpadConfigContainer*,
TouchpadBackend*, const QVariantList&)���:

D28154: Add users KCM

[Nathaniel Graham]

ngraham added a comment.


  FWIW deleting a user doesn't work for me. When I click the Delete User 
button, in the console I see:
  

file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml:177:
 TypeError: Cannot read property 'uid' of undefined
  
  Also I notice that the users list no longer indicates what type of account 
the user has; that information must now be found by clicking on each user and 
looking at their details page. A third line could probably be used to re-add 
this information. It would make the list items taller, but that's fine, as long 
as *all* of them are taller. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

[Ben Cooksley]

On Wed, Mar 25, 2020 at 12:05 PM David Edmundson
 wrote:
>
> Briefly investigated, it seems another false positive of frameworks being out 
> of sync which will resolve itself.

This means that Plasma has introduced API into Frameworks and then
rapidly proceeded with making use of it - so it is a valid report in a
way, as this was one of the issues that was brought up in the recent
discussion on Frameworks/Plasma LTS.

I have initiated the Dependency Builds that will repair this
situation, although given we have breakage in Akonadi I fully expect
them to fail (*sigh*)

>
> David

Cheers,
Ben

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

[David Edmundson]

Briefly investigated, it seems another false positive of frameworks being
out of sync which will resolve itself.

David

D28262: [applets/analog-clock] Optional minute hand

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Resigning, due to currently not having time for Plasma development.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: ngraham, aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Nathaniel Graham]

ngraham edited reviewers, added: VDG, Plasma; removed: Plasma: Workspaces.
ngraham added a comment.


  Thanks for the patch, Anthony!
  
  Technical comment: you need to update the kcfg file too, to add a definition 
of the new option.
  
  Conceptual/UI comment: do you think you could explain the use case for 
showing an analog clock without a minute hand? I don't think I've ever seen any 
real-world analog clocks without minute hands.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, kossebau, #vdg, #plasma, #plasma_workspaces
Cc: ngraham, aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau created this revision.
aloiseau added reviewers: Plasma: Workspaces, kossebau.
aloiseau added a project: Plasma: Workspaces.
Herald edited projects, added Plasma; removed Plasma: Workspaces.
Herald added a subscriber: plasma-devel.
aloiseau requested review of this revision.

REVISION SUMMARY
  Add a configuration option to hide minute hand, the same way second hand can 
already be hidden.
  
  Those two options are independent, letting user hide minute hand alone.
  

  
  Clock refresh interval is not modified. It still refreshes every 30 seconds 
when second hand is hidden, even when hour hand is the only visible one. Having 
this interval computed from both hiddable hands would make its computation less 
readable for a minor CPU benefit.

TEST PLAN
  - Add an Analog Clock to your Plasma wallpaper
  - Go to its setting
  - Deselect new "Show minute hand" option
  - Apply
  
  Minute hand is then hidden from Analog Clock widget.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

AFFECTED FILES
  applets/analog-clock/contents/config/main.xml
  applets/analog-clock/contents/ui/analogclock.qml
  applets/analog-clock/contents/ui/configGeneral.qml

To: aloiseau, #plasma_workspaces, kossebau
Cc: aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  > Some of the icons are not rendering now, for example:
  >  Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20
  >  Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb
  >  I'm pretty sure I saw a workaround for that somewhere, but I can't recall 
where...
  
  Found it! You need to handle `IconThemePath`, which can be difficult... :/

INLINE COMMENTS

> StatusNotifierItem.qml:30
>  subText: model.ToolTipSubTitle
>  icon: model.ToolTipIcon !== "" ? model.ToolTipIcon : model.Icon ? 
> model.Icon : model.IconName
>  textFormat: Text.AutoText

You need to change here as well.

> StatusNotifierItem.qml:61
> +PlasmaCore.IconItem {
> +id: overlayIconItem
> +source: {

add `parent: iconItem.parent`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28259: [applets/systemtray] Default value for ItemLoader.source

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5b99315f75f9: [applets/systemtray] Default value for 
ItemLoader.source (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28259?vs=78406=78408

REVISION DETAIL
  https://phabricator.kde.org/D28259

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/ItemLoader.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  Two problems:
  
  After running `plasmashell --replace &` I have these messages in the console 
output:
  
  > 
file:///home/konrad/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/StatusNotifierItem.qml:57:5:
 QML IconItem: Cannot anchor to an item that isn't a parent or sibling.
  >  
file:///home/konrad/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/StatusNotifierItem.qml:57:5:
 QML IconItem: Cannot anchor to an item that isn't a parent or sibling.
  
  You need to rebase, in latest change parent of the icon changed to `parent: 
taskIcon.iconContainer`, overlay icon should have the same parent:
  
id: overlayIconItem
parent: iconItem.parent
  
  Some of the icons are not rendering now, for example:
  Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20
  Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb
  I'm pretty sure I saw a workaround for that somewhere, but I can't recall 
where...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28259: [applets/systemtray] Default value for ItemLoader.source

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma.
Herald added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  When none of the valid conditions are met, function should return default 
value for ItemLoader source. If not, error is printed in logs.

TEST PLAN
  No warning about undefined value for url

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28259

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/ItemLoader.qml

To: kmaterka, #plasma_workspaces, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 805 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/805/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 24 Mar 2020 20:40:08 +
 Build duration:
4 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 3610 lines...][2020-03-24T20:44:19.975Z]   368 | const QString path = KGlobal::dirs()->saveLocation("emoticons", name, false);[2020-03-24T20:44:19.975Z]   |^[2020-03-24T20:44:19.975Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KGlobal:1,[2020-03-24T20:44:19.975Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:30:[2020-03-24T20:44:19.975Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobal.h:375:50: note: declared here[2020-03-24T20:44:19.975Z]   375 | KDELIBS4SUPPORT_DEPRECATED_EXPORT KStandardDirs *dirs();[2020-03-24T20:44:19.975Z]   |  ^~~~[2020-03-24T20:44:19.975Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:389:44: warning: ���QString KInputDialog::getItem(const QString&, const QString&, const QStringList&, int, bool, bool*, QWidget*)��� is deprecated [-Wdeprecated-declarations][2020-03-24T20:44:19.975Z]   389 | const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-03-24T20:44:19.975Z]   |^~~[2020-03-24T20:44:19.975Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KInputDialog:1,[2020-03-24T20:44:19.975Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:37:[2020-03-24T20:44:19.975Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:43: note: declared here[2020-03-24T20:44:19.975Z]   209 | KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString , const QString ,[2020-03-24T20:44:19.975Z]   |   ^~~[2020-03-24T20:44:19.976Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:390:81: warning: ���QString KInputDialog::getItem(const QString&, const QString&, const QStringList&, int, bool, bool*, QWidget*)��� is deprecated [-Wdeprecated-declarations][2020-03-24T20:44:19.976Z]   390 |ls, current, false, , this);[2020-03-24T20:44:19.976Z]   | ^[2020-03-24T20:44:19.976Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KInputDialog:1,[2020-03-24T20:44:19.976Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:37:[2020-03-24T20:44:19.976Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:43: note: declared here[2020-03-24T20:44:19.976Z]   209 | KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString , const QString ,[2020-03-24T20:44:19.976Z]   |   ^~~[2020-03-24T20:44:19.976Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:390:81: warning: ���QString KInputDialog::getItem(const QString&, const QString&, const QStringList&, int, bool, bool*, QWidget*)��� is deprecated [-Wdeprecated-declarations][2020-03-24T20:44:19.976Z]   390 |ls, current, false, , this);[2020-03-24T20:44:19.976Z]   | ^[2020-03-24T20:44:19.976Z] In file included from /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/KInputDialog:1,[2020-03-24T20:44:19.976Z]  from /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/emoticons/emoticonslist.cpp:37:[2020-03-24T20:44:19.976Z] /home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:43: note: declared here[2020-03-24T20:44:19.976Z]   209 | KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString , const QString ,[2020-03-24T20:44:19.976Z]   |   ^~~[2020-03-24T20:44:20.233Z] [ 58%] Built target lookandfeeltool[2020-03-24T20:44:20.491Z] [ 58%] Generating iconssettingsbase.h, iconssettingsbase.cpp[2020-03-24T20:44:20.491Z] [ 58%] Generating iconssettingsbase.moc[2020-03-24T20:44:20.491Z] Scanning dependencies of target plasma-changeicons[2020-03-24T20:44:20.491Z] [ 59%] Building CXX object kcms/icons/CMakeFiles/plasma-changeicons.dir/plasma-changeicons_autogen/mocs_compilation.cpp.o[2020-03-24T20:44:20.491Z] [ 59%] Building CXX object 

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/4/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 24 Mar 2020 20:40:08 +
 Build duration:
1 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 4681 lines...][2020-03-24T20:41:30.798Z] [ 72%] Building CXX object kcms/cursortheme/CMakeFiles/kcm_cursortheme.dir/xcursor/sortproxymodel.cpp.o[2020-03-24T20:41:31.059Z] [ 72%] Building CXX object kcms/cursortheme/CMakeFiles/kcm_cursortheme.dir/__/krdb/krdb.cpp.o[2020-03-24T20:41:31.059Z] [ 72%] Building CXX object kcms/cursortheme/CMakeFiles/kcm_cursortheme.dir/cursorthemesettings.cpp.o[2020-03-24T20:41:31.059Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/cursortheme/kcmcursortheme.cpp:378:20: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2020-03-24T20:41:31.059Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2020-03-24T20:41:31.059Z]^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2020-03-24T20:41:31.059Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2020-03-24T20:41:31.059Z]   ^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-03-24T20:41:31.059Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-03-24T20:41:31.059Z]^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-03-24T20:41:31.059Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-03-24T20:41:31.059Z]  ^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/cursortheme/kcmcursortheme.cpp:378:30: warning: 'emitChange' is deprecated [-Wdeprecated-declarations][2020-03-24T20:41:31.059Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2020-03-24T20:41:31.059Z]  ^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:560:12: note: 'emitChange' has been explicitly marked deprecated here[2020-03-24T20:41:31.059Z] static KDELIBS4SUPPORT_DEPRECATED void emitChange(ChangeType changeType, int arg = 0);[2020-03-24T20:41:31.059Z]^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-03-24T20:41:31.059Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-03-24T20:41:31.059Z]  ^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/cursortheme/kcmcursortheme.cpp:378:56: warning: 'KGlobalSettings' is deprecated [-Wdeprecated-declarations][2020-03-24T20:41:31.059Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2020-03-24T20:41:31.059Z]^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2020-03-24T20:41:31.059Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2020-03-24T20:41:31.059Z]   ^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-03-24T20:41:31.059Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-03-24T20:41:31.059Z]^[2020-03-24T20:41:31.059Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-03-24T20:41:31.059Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-03-24T20:41:31.059Z]  ^[2020-03-24T20:41:31.059Z] 2 warnings generated.[2020-03-24T20:41:31.317Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/baloo/filteredfoldermodel.cpp:39:16: warning: local variable 'input' will be copied despite being returned by name [-Wreturn-std-move][2020-03-24T20:41:31.317Z] return 

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7498b41a1979: [Baloo KCM] Complete overhaul of the 
include/exclude folder list (authored by bruns).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28025?vs=78333=78404

REVISION DETAIL
  https://phabricator.kde.org/D28025

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 78394.
cblack added a comment.


  Add boilerplate code for a KAuth helper to prepare for adding groups support

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=78387=78394

BRANCH
  cblack/userkcm-ng (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/helper.cpp
  kcms/users/src/helper.h
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/user_manager.actions
  kcms/users/src/usercontroller.cpp
  kcms/users/src/usercontroller.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 78387.
cblack marked 6 inline comments as done.
cblack added a comment.


  Address feedback and fix issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=78364=78387

BRANCH
  cblack/userkcm-ng (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usercontroller.cpp
  kcms/users/src/usercontroller.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28109: [applets/systemtray] Simplify icon size logic

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a9d941b38e05: [applets/systemtray] Simplify icon size 
logic (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28109?vs=78185=78386

REVISION DETAIL
  https://phabricator.kde.org/D28109

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, 
apol
Cc: mart, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 78384.
davidre marked 6 inline comments as done.
davidre added a comment.


  Use Math.floor

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78298=78384

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 SUSEQt5.12 - Build # 198 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20SUSEQt5.12/198/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 24 Mar 2020 17:02:36 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/PlasmaPotdProvider-1.0.0.xml
   JUnit Tests
  Name: projectroot.runners.converter Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report7%
(2/28)3%
(3/105)3%
(3/105)4%
(202/5182)3%
(88/2518)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.colorpicker.plugin0%
(0/3)0%
(0/3)0%
(0/88)0%
(0/28)applets.comic0%
(0/14)0%
(0/14)0%
(0/1130)0%
(0/537)applets.dict.plugin0%
(0/3)0%
(0/3)0%
(0/71)0%
(0/21)applets.diskquota.plugin0%
(0/6)0%
(0/6)0%
(0/249)0%
(0/135)applets.fifteenPuzzle.plugin0%
(0/2)0%
(0/2)0%
(0/50)0%
(0/28)applets.grouping0%
(0/1)0%
(0/1)0%
(0/61)0%
(0/66)applets.grouping.container0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/40)applets.mediaframe.plugin0%
(0/3)0%
(0/3)0%
(0/197)0%
(0/94)applets.nightcolor.plugin0%
(0/3)0%
(0/3)0%
(0/169)0%
(0/58)applets.notes.plugin0%
(0/7)0%
(0/7)0%
(0/262)0%
(0/86)applets.quicklaunch.plugin0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/64)applets.quickshare.plugin0%
(0/2)0%
(0/2)0%
(0/54)0%
(0/20)applets.timer.plugin0%
(0/2)0%
(0/2)0%
(0/8)0%
(0/2)applets.weather0%
(0/2)0%
(0/2)0%
(0/132)0%
(0/66)applets.weather.plugin0%
(0/8)0%
(0/8)0%
(0/248)0%
(0/139)dataengines.comic0%
(0/7)0%
(0/7)0%
(0/938)0%
(0/530)dataengines.konsoleprofiles0%
(0/2)0%
(0/2)0%
(0/52)0%
(0/14)dataengines.potd0%
(0/19)0%
(0/19)0%

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20FreeBSDQt5.14/7/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 24 Mar 2020 17:02:36 +
 Build duration:
1 min 19 sec and counting
   JUnit Tests
  Name: projectroot.runners.converter Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[David Edmundson]

davidedmundson added a comment.


  My fault, I'll fix it

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added a comment.


  Sh**t, should I make a new patch to fix this?
  
  And sorry ...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Nathaniel Graham]

ngraham added a comment.


  This broke the CI:
  
[2020-03-24T15:59:18.523Z] [ 66%] Linking CXX shared module 
../../bin/krunner_datetime.so
[2020-03-24T15:59:18.523Z] 
/usr/home/jenkins/workspace/Plasma/kdeplasma-addons/kf5-qt5 
FreeBSDQt5.14/runners/spellchecker/spellcheck.cpp:198:30: error: use of 
undeclared identifier 'findlang'; did you mean 'findLang'?
[2020-03-24T15:59:18.523Z] const QString lang = findlang(terms);
[2020-03-24T15:59:18.523Z] ^~~~

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 78372.
ahiemstra added a comment.


  - Add some documentation to classes
  - Properly install the export header
  - Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake
  - Rebase, update SensorInfo and Daemon XML to new versions

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78275=78372

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 SUSEQt5.12 - Build # 197 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20SUSEQt5.12/197/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 24 Mar 2020 15:57:31 +
 Build duration:
2 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 1228 lines...][2020-03-24T15:59:31.298Z] [ 50%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/util.cpp.o[2020-03-24T15:59:32.229Z] [ 50%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/abstractunitlistmodel.cpp.o[2020-03-24T15:59:32.795Z] Scanning dependencies of target plasma_packagestructure_comic[2020-03-24T15:59:32.795Z] Scanning dependencies of target plasma_applet_weather[2020-03-24T15:59:32.795Z] [ 51%] Building CXX object dataengines/comic/CMakeFiles/plasma_packagestructure_comic.dir/plasma_packagestructure_comic_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:32.795Z] [ 52%] Building CXX object applets/weather/CMakeFiles/plasma_applet_weather.dir/plasma_applet_weather_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:33.053Z] [ 52%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/locationlistmodel.cpp.o[2020-03-24T15:59:33.619Z] [ 52%] Building CXX object dataengines/comic/CMakeFiles/plasma_packagestructure_comic.dir/comic_package.cpp.o[2020-03-24T15:59:33.877Z] Scanning dependencies of target timerplugin[2020-03-24T15:59:33.877Z] [ 52%] Building CXX object applets/timer/CMakeFiles/timerplugin.dir/timerplugin_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:33.877Z] [ 52%] Building CXX object applets/weather/CMakeFiles/plasma_applet_weather.dir/weatherapplet.cpp.o[2020-03-24T15:59:34.809Z] [ 52%] Building CXX object applets/timer/CMakeFiles/timerplugin.dir/plugin/timer.cpp.o[2020-03-24T15:59:34.809Z] [ 52%] Generating activitymanagerslc_interface.cpp, activitymanagerslc_interface.h[2020-03-24T15:59:34.809Z] [ 52%] Generating activitymanagerslc_interface.moc[2020-03-24T15:59:34.809Z] [ 53%] Linking CXX shared module ../../bin/plasma_packagestructure_comic.so[2020-03-24T15:59:34.809Z] [ 54%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/servicelistmodel.cpp.o[2020-03-24T15:59:34.809Z] Scanning dependencies of target purposeplugin[2020-03-24T15:59:34.809Z] [ 55%] Building CXX object applets/quickshare/plugin/CMakeFiles/purposeplugin.dir/purposeplugin_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:35.373Z] [ 55%] Built target plasma_packagestructure_comic[2020-03-24T15:59:35.373Z] [ 55%] Building CXX object applets/quickshare/plugin/CMakeFiles/purposeplugin.dir/purposeplugin.cpp.o[2020-03-24T15:59:35.373Z] Scanning dependencies of target quicklaunchplugin[2020-03-24T15:59:35.373Z] [ 55%] Building CXX object applets/quicklaunch/plugin/CMakeFiles/quicklaunchplugin.dir/quicklaunchplugin_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:35.373Z] [ 56%] Building CXX object applets/timer/CMakeFiles/timerplugin.dir/plugin/timerplugin.cpp.o[2020-03-24T15:59:35.632Z] [ 57%] Linking CXX shared module ../../bin/plasma_applet_weather.so[2020-03-24T15:59:35.892Z] [ 57%] Building CXX object applets/quicklaunch/plugin/CMakeFiles/quicklaunchplugin.dir/quicklaunch_p.cpp.o[2020-03-24T15:59:35.892Z] [ 57%] Built target plasma_applet_weather[2020-03-24T15:59:36.150Z] [ 58%] Building CXX object applets/quicklaunch/plugin/CMakeFiles/quicklaunchplugin.dir/quicklaunchplugin.cpp.o[2020-03-24T15:59:36.150Z] [ 58%] Linking CXX shared library ../../bin/libweatherplugin.so[2020-03-24T15:59:36.717Z] [ 58%] Linking CXX shared library ../../bin/libtimerplugin.so[2020-03-24T15:59:36.717Z] Scanning dependencies of target plasmacomicprovidercore[2020-03-24T15:59:36.717Z] [ 59%] Building CXX object dataengines/comic/CMakeFiles/plasmacomicprovidercore.dir/plasmacomicprovidercore_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:36.717Z] [ 59%] Building CXX object dataengines/comic/CMakeFiles/plasmacomicprovidercore.dir/comicprovider.cpp.o[2020-03-24T15:59:36.717Z] [ 59%] Built target timerplugin[2020-03-24T15:59:36.717Z] [ 60%] Building CXX object applets/quickshare/plugin/CMakeFiles/purposeplugin.dir/contenttracker.cpp.o[2020-03-24T15:59:36.717Z] [ 60%] Built target weatherplugin[2020-03-24T15:59:36.975Z] Scanning dependencies of target plasmapotdprovidercore[2020-03-24T15:59:36.976Z] [ 61%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/plasmapotdprovidercore_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:36.976Z] [ 61%] Building CXX object applets/quickshare/plugin/CMakeFiles/purposeplugin.dir/activitymanagerslc_interface.cpp.o[2020-03-24T15:59:37.235Z] [ 61%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/potdprovider.cpp.o[2020-03-24T15:59:38.168Z] Scanning dependencies of target plasma_engine_konsoleprofiles[2020-03-24T15:59:38.168Z] [ 61%] Building CXX object 

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 24 Mar 2020 15:57:31 +
 Build duration:
1 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 1178 lines...][2020-03-24T15:58:57.590Z] [ 51%] Linking CXX shared module ../../bin/plasma_applet_comic.so[2020-03-24T15:58:57.590Z] Scanning dependencies of target plasma_applet_weather[2020-03-24T15:58:57.590Z] [ 52%] Building CXX object applets/weather/CMakeFiles/plasma_applet_weather.dir/plasma_applet_weather_autogen/mocs_compilation.cpp.o[2020-03-24T15:58:57.590Z] [ 52%] Built target plasma_applet_comic[2020-03-24T15:58:57.590Z] [ 53%] Building CXX object applets/notes/CMakeFiles/notesplugin.dir/plugin/notesplugin.cpp.o[2020-03-24T15:58:57.862Z] [ 53%] Building CXX object applets/timer/CMakeFiles/timerplugin.dir/plugin/timer.cpp.o[2020-03-24T15:58:58.137Z] [ 53%] Building CXX object applets/quickshare/plugin/CMakeFiles/purposeplugin.dir/activitymanagerslc_interface.cpp.o[2020-03-24T15:58:59.127Z] [ 54%] Building CXX object applets/timer/CMakeFiles/timerplugin.dir/plugin/timerplugin.cpp.o[2020-03-24T15:58:59.127Z] [ 54%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/plugin.cpp.o[2020-03-24T15:58:59.392Z] [ 54%] Building CXX object applets/weather/CMakeFiles/plasma_applet_weather.dir/weatherapplet.cpp.o[2020-03-24T15:58:59.653Z] Scanning dependencies of target plasmacomicprovidercore[2020-03-24T15:58:59.653Z] [ 55%] Building CXX object dataengines/comic/CMakeFiles/plasmacomicprovidercore.dir/plasmacomicprovidercore_autogen/mocs_compilation.cpp.o[2020-03-24T15:58:59.653Z] [ 55%] Building CXX object dataengines/comic/CMakeFiles/plasmacomicprovidercore.dir/comicprovider.cpp.o[2020-03-24T15:58:59.930Z] [ 55%] Linking CXX shared library ../../bin/libnotesplugin.so[2020-03-24T15:59:00.215Z] [ 55%] Built target notesplugin[2020-03-24T15:59:00.215Z] Scanning dependencies of target plasma_packagestructure_comic[2020-03-24T15:59:00.215Z] [ 56%] Building CXX object dataengines/comic/CMakeFiles/plasma_packagestructure_comic.dir/plasma_packagestructure_comic_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:01.293Z] [ 56%] Linking CXX shared library ../../bin/libtimerplugin.so[2020-03-24T15:59:01.293Z] [ 56%] Built target timerplugin[2020-03-24T15:59:01.293Z] Scanning dependencies of target plasmapotdprovidercore[2020-03-24T15:59:01.631Z] [ 57%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/plasmapotdprovidercore_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:01.915Z] [ 57%] Linking CXX shared library ../../../bin/libpurposeplugin.so[2020-03-24T15:59:02.207Z] [ 58%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/util.cpp.o[2020-03-24T15:59:02.502Z] [ 58%] Built target purposeplugin[2020-03-24T15:59:02.502Z] [ 58%] Building CXX object dataengines/comic/CMakeFiles/plasma_packagestructure_comic.dir/comic_package.cpp.o[2020-03-24T15:59:03.138Z] [ 58%] Linking CXX shared module ../../bin/plasma_applet_weather.so[2020-03-24T15:59:03.466Z] [ 58%] Built target plasma_applet_weather[2020-03-24T15:59:03.761Z] Scanning dependencies of target plasma_engine_konsoleprofiles[2020-03-24T15:59:03.761Z] [ 58%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/plasma_engine_konsoleprofiles_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:03.761Z] [ 58%] Linking CXX shared library ../../bin/libplasmacomicprovidercore.so[2020-03-24T15:59:03.761Z] Scanning dependencies of target krunner_converter_static[2020-03-24T15:59:04.043Z] [ 59%] Building CXX object runners/converter/CMakeFiles/krunner_converter_static.dir/krunner_converter_static_autogen/mocs_compilation.cpp.o[2020-03-24T15:59:04.314Z] [ 59%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/potdprovider.cpp.o[2020-03-24T15:59:05.046Z] [ 59%] Built target plasmacomicprovidercore[2020-03-24T15:59:05.046Z] [ 60%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/konsoleprofilesengine.cpp.o[2020-03-24T15:59:06.074Z] [ 60%] Linking CXX shared module ../../bin/plasma_packagestructure_comic.so[2020-03-24T15:59:06.358Z] [ 60%] Built target plasma_packagestructure_comic[2020-03-24T15:59:06.358Z] [ 60%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/abstractunitlistmodel.cpp.o[2020-03-24T15:59:06.358Z] [ 60%] Building CXX object runners/converter/CMakeFiles/krunner_converter_static.dir/converterrunner.cpp.o[2020-03-24T15:59:08.503Z] [ 60%] Linking CXX shared library ../../bin/libplasmapotdprovidercore.so[2020-03-24T15:59:08.503Z] [ 60%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/locationlistmodel.cpp.o[2020-03-24T15:59:08.503Z] [ 60%] Built target plasmapotdprovidercore[2020-03-24T15:59:08.810Z] [ 60%] Building CXX object 

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:5e760a0586bb: Refactor foreach, use Qt5 signal syntax, 
remove unnecessary method call (authored by davidedmundson, committed by alex).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=78368=78371

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added a comment.


  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[David Edmundson]

davidedmundson updated this revision to Diff 78368.
davidedmundson added a comment.


  Rebase

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=78336=78368

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28172: [applets/digital-clock] Fix date sizing in vertical panel

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:01691632b523: [applets/digital-clock] Fix date sizing in 
vertical panel (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28172?vs=78366=78367

REVISION DETAIL
  https://phabricator.kde.org/D28172

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: ngraham, #vdg, #plasma, cblack, davidedmundson
Cc: davidedmundson, cblack, muesli, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28172: [applets/digital-clock] Fix date sizing in vertical panel

[Nathaniel Graham]

ngraham updated this revision to Diff 78366.
ngraham added a comment.


  Restore elision property

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28172?vs=78126=78366

BRANCH
  fix-vertical-panel-date-text-sizing (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D28172

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: ngraham, #vdg, #plasma, cblack, davidedmundson
Cc: davidedmundson, cblack, muesli, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28172: [applets/digital-clock] Fix date sizing in vertical panel

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  You probably still want the elide.
  
  We have a word wrap on, so you'll only hit this elide option when the 
alternative is paint outside the area and just leak over other items in the 
system tray. That always looks rubbish.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-vertical-panel-date-text-sizing (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D28172

To: ngraham, #vdg, #plasma, cblack, davidedmundson
Cc: davidedmundson, cblack, muesli, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 78364.
cblack added a comment.


  Use better icon

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=78135=78364

BRANCH
  cblack/userkcm-ng (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usercontroller.cpp
  kcms/users/src/usercontroller.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, 
nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added a comment.


  Small issue: Currently this patch can't be applied (from the master branch)  
because in R114:47381a65debe01a0a015e1aa423cbb78af649648 
 the 
line:
  `QStringList terms = query.split(QLatin1Char(' '), QString::SkipEmptyParts);` 
got changed.
  I don't know how to resolve this conflict and would be thankful for help :-).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28238: Stop multiplying duration values

[Nathaniel Graham]

ngraham added a comment.


  In D28238#633505 , @cblack wrote:
  
  > I'm not sure where you can see the changes to `ActionButton.qml` and 
`UserDelegate.qml`.
  
  
  the lock, logout, and login screens

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-standard-duration-values (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28238

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28140: Add a declarative plugin to ProcessCore

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 78360.
ahiemstra added a comment.


  - Rebase, Expose ProcessDataModel and ProcessAttributeModel as well

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28140?vs=78013=78360

BRANCH
  processcore_declarative

REVISION DETAIL
  https://phabricator.kde.org/D28140

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/declarative/CMakeLists.txt
  processcore/declarative/ProcessEnums.cpp
  processcore/declarative/ProcessEnums.h
  processcore/declarative/ProcessPlugin.cpp
  processcore/declarative/ProcessPlugin.h
  processcore/declarative/qmldir
  processcore/process_controller.cpp
  processcore/process_controller.h
  tests/process/test_process.qml

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28238: Stop multiplying duration values

[Carson Black]

cblack accepted this revision as: Plasma, cblack.
cblack added a comment.
This revision is now accepted and ready to land.


  Code looks good to me, but I haven't looked at how these changes look 
visually.
  These are where these changes will be visible, right?
  
  - Clicking a device in the system tray device list
  - System tray arrow
  
  I'm not sure where you can see the changes to `ActionButton.qml` and 
`UserDelegate.qml`.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-standard-duration-values (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28238

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28238: Stop multiplying duration values

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  After D28144 , some animations are now 
too long because they were inappropriately
  multiplying a duration value. That's no longer necessary, so let's remove the
  multiplication.
  
  Depends on D28144 

TEST PLAN
  Various things that were a bit too slow before feel just right now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-standard-duration-values (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28238

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/components/UserDelegate.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28239: Stop multiplying duration values

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  After D28144 , some animations are now 
too long because they were inappropriately
  multiplying a duration value. That's no longer necessary, so let's remove the
  multiplication.
  
  Depends on D28144 

TEST PLAN
  Various things that were a bit too slow before feel just right now

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-standard-duration-values (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28239

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  desktoppackage/contents/configuration/PanelConfiguration.qml
  desktoppackage/contents/explorer/WidgetExplorer.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28236: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  `units.iconSizes.smallMedium` is the default size, so setting the
  icon size to this has no effect

TEST PLAN
  No change whatsoever in the task manager media playback tooltip
  icon sizes

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-unnecessary-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28236

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28135: Port away from deprecated QSet/QList methods in some places

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78355.
ahmadsamir added a comment.


  QStringList has a sort() method

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28135?vs=77979=78355

BRANCH
  l-qset-fromlist (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28135

AFFECTED FILES
  applets/kicker/plugin/runnermodel.cpp
  dataengines/systemmonitor/systemmonitor.cpp
  kcms/translations/translationsmodel.cpp
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/taskgroupingproxymodel.cpp
  wallpapers/image/backgroundlistmodel.cpp

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28234: Use SyntaxHighlighter for highlighting

[Aleix Pol Gonzalez]

apol added a comment.


  F8196700: Screenshot_20200324_145906.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28234

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28234: Use SyntaxHighlighter for highlighting

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The code is especially fiddly and complex. Using this we can on the
  other hand leverage other parts of our system.

TEST PLAN
  Used, will upload screenshot

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28234

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/backtracewidget.cpp
  src/backtracewidget.h
  src/gdbhighlighter.cpp
  src/gdbhighlighter.h

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  In D27972#633289 , @zzag wrote:
  
  > > in "Always on" manual mode: when active (not inhibited)
  >
  > I still don't understand why we should hide the applet. If VDG is okay with 
such behavior, then feel free to push this change, I won't object or anything.
  
  
  Actually yeah, I agree with this. I didn't notice that change, sorry. If the 
user has deliberately turned it always on, then having the tray icon always 
active by default makes it into a quick on/off toggle, which I think is handy. 
Sorry for missing this with my earlier review.

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham, #vdg
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[systemsettings] [Bug 418949] plymouth-theme-breeze should have a background/wallpaper option

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=418949

Harald Sitter  changed:

   What|Removed |Added

  Component|Plymouth|kcm_plymouth
Product|Breeze  |systemsettings
   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

--- Comment #1 from Harald Sitter  ---
That'd only make sense if people can actually set it via the KCM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D28215: [RFC]: WIP: Make mobile broadband actually functional

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> mobileproviders.h:31
>  
> -class MobileProviders
> +class MobileProviders : public QObject
>  {

Needs `Q_OBJECT` macro

> mobileproviders.h:38
>  
> -MobileProviders();
> +MobileProviders(QObject* parent = 0);
>  ~MobileProviders();

`explicit MobileProviders(QObject *parent = nullptr);`

> mobilebroadbandsettings.cpp:109
> +// no modem detected
> +return "";
> +}

`return QString();`

> mobilebroadbandsettings.h:39
>  void setupMobileNetwork();
> -Q_INVOKABLE QString getAPN();
> +Q_INVOKABLE QString getProvider();
>  

`const`

> main.qml:70
> +}*/
> +Repeater {
> +enabled: mobileDataCheckbox.enabled

You sure you want to use a `Repeater` for this? Or how large can that list 
become?

> main.qml:76
> +text: modelData
> +checked: false
> +onCheckedChanged: {

Doesn't this have to be bound to something?

> main.qml:77
> +checked: false
> +onCheckedChanged: {
> +if (checked) {

Use `onToggled`

> main.qml:79
> +if (checked) {
> +qDebug() << "Activating " << modelData;
> +// activating this provider then: 
> kcm.setupMobileNetwork(model)

This is QML, not C++ :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28215

To: bshah, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

[Ahmad Samir]

ahmadsamir added a comment.


  Should be fixed by D28232 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27503

To: bport, #plasma, meven, crossi, ervin
Cc: usta, ahmadsamir, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28232: [SpellChecking KCM] Fix the build

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, bport, meven, crossi, ervin.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QList/QSet iterator-based ctors are available since Qt 5.14, so we
  could make the code conditional based on that to keep it building
  against older Qt versions. However I think the reason behind converting
  from QStringList to QSet was to remove duplicates, so use
  QStringList::removeDuplicates() and sort() instead.
  
  Bump KF5 min. required version to 5.69.0 because of Sonnet/ConfigView
  which first appeared in that version.

TEST PLAN
  make && ctest

REPOSITORY
  R119 Plasma Desktop

BRANCH
  l-fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28232

AFFECTED FILES
  CMakeLists.txt
  kcms/spellchecking/spellchecking.cpp

To: ahmadsamir, #plasma, bport, meven, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27509: Introduce ProcessDataModel

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:834de9a585c6: Introduce ProcessDataModel (authored by 
davidedmundson).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27509?vs=78091=78346

REVISION DETAIL
  https://phabricator.kde.org/D27509

AFFECTED FILES
  CMakeLists.txt
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/process_attribute.cpp
  processcore/process_attribute.h
  processcore/process_attribute_model.cpp
  processcore/process_attribute_model.h
  processcore/process_data_model.cpp
  processcore/process_data_model.h
  processui/ProcessModel.cpp

To: davidedmundson, #plasma, broulik
Cc: ahiemstra, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dceb791c0779: WebShortcuts Runner: Refactor foreach, 
remove unnecessary method (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27566?vs=78338=78339

REVISION DETAIL
  https://phabricator.kde.org/D27566

AFFECTED FILES
  runners/webshortcuts/webshortcutrunner.cpp
  runners/webshortcuts/webshortcutrunner.h

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Alexander Lohnau]

alex updated this revision to Diff 78338.
alex added a comment.


  Coding style: put space before {

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27566?vs=76144=78338

BRANCH
  arcpatch-D27566

REVISION DETAIL
  https://phabricator.kde.org/D27566

AFFECTED FILES
  runners/webshortcuts/webshortcutrunner.cpp
  runners/webshortcuts/webshortcutrunner.h

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bf28d5d2b4f4: [VirtualDesktopInfo] Connect to rowsChanged 
singal (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28216?vs=78273=78337

REVISION DETAIL
  https://phabricator.kde.org/D28216

AFFECTED FILES
  libtaskmanager/virtualdesktopinfo.cpp

To: broulik, #plasma, hein, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Vlad Zahorodnii]

zzag added a comment.


  > in "Always on" manual mode: when active (not inhibited)
  
  I still don't understand why we should hide the applet. If VDG is okay with 
such behavior, then feel free to push this change, I won't object or anything.

INLINE COMMENTS

> main.qml:26
>  
> +import org.kde.colorcorrect 0.1 as CC
> +

Please do not use `org.kde.colorcorrect` in this applet. If you need operation 
mode constants, please add them to the Monitor class. See D26688 
 for more details.

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham, #vdg
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.

INLINE COMMENTS

> webshortcutrunner.cpp:79
>  const int delimIndex = term.indexOf(m_delimiter);
> -if (delimIndex == term.length() - 1)
> +if (delimIndex == -1 || delimIndex == term.length() - 1){
>  return;

Coding style: put space before `{`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  webshortcuts_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27566

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Alexander Lohnau]

alex added a comment.


  Ping @broulik :-)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  webshortcuts_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27566

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26799: Apply KDE coding style, minor optimizations

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Abandoning this, because there have been a few patches to the same kcm and 
this is mostly formatting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26799

To: alex, ngraham, meven, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex updated this revision to Diff 78336.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=78335=78336

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex updated this revision to Diff 78335.
alex added a comment.


  Minor improvements
  
  I had another look at the project and changed some other things:
  
  - optimize some overloads with QStringLiteral/QLatin1String
  - rename loaddata to loadData
  - remove the unnecessary check for the action in the run method
  - reuse the result of config()
  - make sure that the trigger word can only be required if it is not empty

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74848=78335

BRANCH
  arcpatch-D27070

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  CMakeLists.txt
  runners/converter/CMakeLists.txt
  runners/converter/autotests/CMakeLists.txt
  runners/converter/autotests/converterrunnertest.cpp
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart