D28454: [libnotificationmanager] forward notifications to lockscreen greeter

[Bhushan Shah]

bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  This is alternative to previous revision which talks to ksldapp and then
  ksldapp talks to the greeter over private wayland server interface.

TEST PLAN
  alternative to D28427 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/greeter-notify

REVISION DETAIL
  https://phabricator.kde.org/D28454

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/server_p.cpp

To: bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this isn't working for me. When I pin open the system tray popup and 
click on a Klipper history item, the popup stays open as expected, but the 
Klipper applet itself closes, so the pop-up is replaced with the applets list.
  
  Is this working for you?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 78948.
cblack added a comment.


  Add more documentation comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=78946=78948

BRANCH
  cblack/pagerouter

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#638514 , @ngraham wrote:
  
  > Same error about not being able to find the module. Sorry for not being 
clear.
  
  
  You can provide a full path to the library instead of letting GTK do name to 
library resolution.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Same error about not being able to find the module. Sorry for not being clear.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 78946.
cblack added a comment.


  Get arc to properly diff

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=78927=78946

BRANCH
  cblack/pagerouter

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D28113: Fix initial loading of autostart program names

[Yichao Yu]

yuyichao added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28113

To: yuyichao, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  The best would be to add theme path support to `PlasmaCore.IconItem`. I will 
take a look at this tomorrow.

INLINE COMMENTS

> davidre wrote in systemtraymodel.cpp:331
> This works now, but I don't know how to manage the KIconLoader. The 
> KIconEngines are managed by QIcon (they take ownership of the engine). One 
> idea would be to add it to the item maybe?

I don't like this idea. Now it is just a copy from one model to another without 
much of improvements - in fact now it complicates it even more.  KIconLoader is 
already created in StatusNotifierItemSource, it has little justification to 
create another one in data layer.

> systemtraymodel.cpp:339
> +if(iconThemePath.isEmpty()) {
> +dataItem->setData(iconName, static_cast(role));
> +} else {

Beside formatting (spaces, minor thing), I liked the logic before - the 
presentation layer decided what to render and how, model just provided data.
In addition, *Icon role can have two different types now - it should work with 
`dynamicRoles` enabled, but sometimes it has unexpected consequences. I had a 
bad experience with dynamic data type changes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Stefan Brüns]

bruns added a comment.


  @davidedmundson - is `QIcon(QImage(...)) `save?
  
  the AppstreamRunner suffers from the same problem, it uses 
`match->setIcon(/*wrapped*/QIcon::fromTheme())`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638356 , @ngraham wrote:
  
  > The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but 
nonetheless there is no effect. :(
  
  
  Is the GTK application throwing the same error, that the module is not found, 
or recoloration does not work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#638327 , @ngraham wrote:
  
  > Found an issue in Virtualbox: the menubar isn't considered a part of the 
Tools Area:
  >
  > F8206280: Screenshot_20200330_113752.png 

  
  
  I'm going to WONTFIX on this one-VirtualBox is simply a massive PITA with 
theming, and already breaks badly in many cases with many themes, including 
"official" ones provided by Qt. Frankly, it's a miracle that this doesn't 
result in titlebar color on titlebar color.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  In D28439#638357 , @bruns wrote:
  
  > In D28439#638188 , 
@davidedmundson wrote:
  >
  > > QIcon isn't thread safe.
  >
  >
  > I think this is related to https://phabricator.kde.org/D5889?id=14601 ?
  >
  > I think we are save here, as the QIcon is created from an image stored on 
disk (absolute path to e.g. PNG), not from a theme.
  
  
  Thanks for the response, I was not sure if QIcon being not thread safe was 
meant in general or only for QIcon::fromTheme.
  
  PS: When I said docs I meant the QIcon class docs, but thanks 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#638175 , @ngraham wrote:
  
  > Nice, that seems to have fixed the issue again.
  >
  > However I still see a significant performance regression though. Switching 
tabs in Kate is now quite slow, especially when there are many open and you use 
a keyboard shortcut to do so. I see the spinning busy cursor all the time. The 
Tools area also changes its vertical height a bit when changing tabs, which is 
odd.
  >
  > F8206041: vokoscreenNG-2020-03-30_08-55-52.webm 

  
  
  Any performance regressions when a kate widget is involved (Kate, KDevelop) 
is likely to due to the fact that tab switching results in a spam of repainting 
because of incessant toggling of a toolbar's visible property, which results in 
costly repainting for no reason. I've already optimized what I can from the 
QStyle side, and anything further will have to be fixed in the offending widget.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78928.
cblack added a comment.


  Change how cache invalidation works

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78813=78928

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 78927.
cblack added a comment.


  Add caching

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=78747=78927

BRANCH
  cblack/pagerouter

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Stefan Brüns]

bruns added a comment.


  In D28439#638188 , @davidedmundson 
wrote:
  
  > QIcon isn't thread safe.
  
  
  I think this is related to https://phabricator.kde.org/D5889?id=14601 ?
  
  I think we are save here, as the QIcon is created from an image stored on 
disk (absolute path to e.g. PNG), not from a theme.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but 
nonetheless there is no effect. :(

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638170 , @ngraham wrote:
  
  > Hmm, when following those instructions, I get the following console error:
  >
  >   Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  >
  >
  > And the color scheme doesn't change. The `colorreload-gtk3-module` target 
did get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`
  
  
  Try `export GTK_PATH='$PREFIX/kde/usr/lib/gtk-3.0/' ` before launching app. 
This should make module to load.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Stefan Brüns]

bruns added a comment.


  In D28439#638216 , @alex wrote:
  
  > In D28439#638188 , 
@davidedmundson wrote:
  >
  > > QIcon isn't thread safe.
  >
  >
  > Sorry, I wasn't aware about that and haven't found anything when I had a 
quick look at the docs before submitting this patch.
  
  
  https://api.kde.org/frameworks/krunner/html/classPlasma_1_1AbstractRunner.html

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Eugene Popov]

epopov updated this revision to Diff 78926.
epopov added a comment.


  Rebase on **master**

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78827=78926

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

ngraham added a comment.


  You can add it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  @ndavis like this?
  
  F8206344: Screenshot_20200330_123644.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  This should be 3 submission:
  
  1. early return/indentation changes (preparation)
  2. always read default profile from FF config, do not write "dbfile" to 
runner config
  3. fix lookup of default  profile name

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Eugene Popov]

epopov added a comment.


  In **Plasma/5.18** branch there was a `Containment.onAppletAdded` handler 
that took the `applet` as a parameter, but can't find this handler in 
**master** branch. Unfortunately, I don’t have enough knowledge of Plasma API 
to know if I can add this handler manually.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns added a comment.


  Also keep code lines at < 80 characters

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns added a comment.


  Regarding the summary:
  
  1. Wrap the lines at <80 characters
  2. Describe the screenshot textually

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Stefan Brüns]

bruns added a comment.


  Can you split out the early-return part for the QSQLite driver and submit it 
as a preparation patch?
  
  It adds quite some noise to the diff due to the whitespace changes (though I 
fully agree it is the better coding pattern).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#638328 , 
@abstractdevelop wrote:
  
  > Also should we implement this for GTK apps?
  
  
  Pretty much already there :P
  
  F8206301: image.png 
  
  But yes, I'm already investigating how to apply this to menubar+toolbar'd GTK 
apps.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Abstract Software]

abstractdevelop added a comment.


  Also should we implement this for GTK apps?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Found an issue in Virtualbox: the menubar isn't considered a part of the 
Tools Area:
  
  F8206280: Screenshot_20200330_113752.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson updated this revision to Diff 78922.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28305?vs=78917=78922

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28305

AFFECTED FILES
  CMakeLists.txt
  config-workspace.h.cmake
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/plasma-krunner.service.in
  ksmserver/CMakeLists.txt
  ksmserver/plasma-ksmserver.service.in
  ksmserver/server.cpp
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop.cmake
  shell/plasma-plasmashell.service.in
  startkde/CMakeLists.txt
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/plasma-kcminit-phase1.service.in
  startkde/kcminit/plasma-kcminit.service.in
  startkde/plasma-core.target
  startkde/plasma-ksplash-ready.service.in
  startkde/plasma-workspace.target
  startkde/startplasma.cpp

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

[Nathaniel Graham]

ngraham added a comment.


  Hmm, that's a good point. I hadn't realized that. Would it make sense for 
changing the timezone in the applet to actually change the whole system 
timezone too, rather than just the display in the applet? Is that something we 
can do?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28133

To: ngraham, #vdg, #plasma, jriddell, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

ngraham added a comment.


  It can, you just need to fix the merge conflicts manually. If it doesn't 
apply cleanly to master, that means it can't be landed on master. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Eugene Popov]

epopov added a comment.


  Can't be rebased on master

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28305: WIP: Systemd Startup

[David Edmundson]

davidedmundson updated this revision to Diff 78917.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28305?vs=78541=78917

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28305

AFFECTED FILES
  CMakeLists.txt
  config-workspace.h.cmake
  krunner/CMakeLists.txt
  krunner/dbus/org.kde.krunner.service.in
  krunner/plasma-krunner.service.in
  ksmserver/CMakeLists.txt
  ksmserver/plasma-ksmserver.service.in
  ksmserver/server.cpp
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmawayland.desktop.cmake
  login-sessions/startplasma-dev.sh.cmake
  shell/CMakeLists.txt
  shell/org.kde.plasmashell.desktop.cmake
  shell/plasma-plasmashell.service.in
  startkde/CMakeLists.txt
  startkde/kcminit/CMakeLists.txt
  startkde/kcminit/plasma-kcminit-phase1.service.in
  startkde/kcminit/plasma-kcminit.service.in
  startkde/plasma-core.target
  startkde/plasma-ksplash-ready.service.in
  startkde/plasma-workspace.target
  startkde/startplasma.cpp

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D28354: [applets/digital-clock] Fix calendar events not being shown at first

[Eugene Popov]

epopov added inline comments.

INLINE COMMENTS

> broulik wrote in CalendarView.qml:154
> Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs 
> since epoch)

How can I compare only the date using your expression?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

To: epopov, ngraham, #plasma, vkrause
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Méven Car]

meven updated this revision to Diff 78913.
meven marked 5 inline comments as done.
meven added a comment.


  Adress review (formatting) and fix a couple of indentation issues

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=78522=78913

BRANCH
  shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28422: WIP: Use ecm_install_configured_files macro

[David Edmundson]

davidedmundson updated this revision to Diff 78912.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28422?vs=78854=78912

BRANCH
  configured_install

REVISION DETAIL
  https://phabricator.kde.org/D28422

AFFECTED FILES
  CMakeLists.txt
  krunner/CMakeLists.txt
  login-sessions/CMakeLists.txt
  runners/baloo/CMakeLists.txt
  runners/baloo/org.kde.baloorunner.service.in
  shell/CMakeLists.txt
  wallpapers/image/CMakeLists.txt

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28435: [System Tray] Update effective status on model insertion

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This fixes the same issue affecting Vaults too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28435

To: broulik, #plasma, kmaterka, davidre, ahmadsamir, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, this fixes those issues for me too. Seems to make sense.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28427: [libnotificationmanager] forward notifications to lockscreen

[Nathaniel Graham]

ngraham added a comment.


  In D28427#637913 , @nicolasfella 
wrote:
  
  > So notifications are only forwarded if x-kde-show-on-lockscreen is set? I 
wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard 
to third-party apps. From a privacy POV I think a global 
dont-show-notis-on-lockscreen thing would make more sense than a per-app thing
  
  
  +1 to using global and per-notification blacklists rather than a 
per-notification whitelist

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28427

To: bshah
Cc: ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  In D28439#638188 , @davidedmundson 
wrote:
  
  > QIcon isn't thread safe.
  
  
  Sorry, I wasn't aware about that and haven't found anything when I had a 
quick look at the docs before submitting this patch.
  
  But if I may ask: Why is this now not thread save but was before?
  Before this patch the icon was created in the BookmarkMatch::asQueryMatch 
method which was called from the secondary thread.
  And with this patch the icon gets created in the Browser::match method which 
gets called from the same thread.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  We've added a DBus interface to the screensaver host; ksmserver or kwin 
respectively.
  That receives the notification and then using a different API over wayland, 
sends it to the greeter.
  Is that right?
  
  Is so, why this extra complicated route?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28428

To: bshah, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[David Edmundson]

davidedmundson added a comment.


  QIcon isn't thread safe.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638173 , @cblack wrote:
  
  > GTK™ isn't too fond of trying to load stuff from outside the standard 
directories.
  
  
  How can this be fixed?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Nice, that seems to have fixed the issue again.
  
  However I still see a significant performance regression though. Switching 
tabs in Kate is now quite slow, especially when there are many open and you use 
a keyboard shortcut to do so. I see the spinning busy cursor all the time. The 
Tools area also changes its vertical height a bit when changing tabs, which is 
odd.
  
  F8206041: vokoscreenNG-2020-03-30_08-55-52.webm 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Well this is kind of a problem then since we need to support development 
builds to a nonstandard install prefix.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#638170 , @ngraham wrote:
  
  > Hmm, when following those instructions, I get the following console error:
  >
  >   Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  >
  >
  > And the color scheme doesn't change. The `colorreload-gtk3-module` target 
did get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`
  
  
  GTK™ isn't too fond of trying to load stuff from outside the standard 
directories.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Hmm, when following those instructions, I get the following console error:
  
Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  
  And the color scheme doesn't change. The `colorreload-gtk3-module` target did 
get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex updated this revision to Diff 78906.
alex added a comment.


  Remove unused includes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28439?vs=78905=78906

BRANCH
  bookmarks_change_icon_handling_in_matches

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex created this revision.
alex added reviewers: apol, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Before: A pointer to the favicon gets written in the BookmarkMatch and using 
this pointer the icon gets created when the Plasma::QueryMatch gets created.
  Now: Using the favicon pointer the icon gets created and written to the 
BookmarkMatch, when the QueryMatch is created the icon value is read.
  
  This makes the code easier to unserstand and the BookmarkMatch is independent 
of the Favicon class.
  
  Depends on D28196 , because this bugfix 
is needed for my config.

TEST PLAN
  Should compile and display icons.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarks_change_icon_handling_in_matches

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah updated this revision to Diff 78904.
bshah added a comment.


  - properly wire up the protocol for ksldapp to greeter

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28428?vs=78883=78904

BRANCH
  bshah/ksld-notifications

REVISION DETAIL
  https://phabricator.kde.org/D28428

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  interface.cpp
  interface.h
  protocols/ksld.xml
  waylandserver.cpp
  waylandserver.h

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28438: Add per-partition total and all partitions sensors

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a "total" sensor for each partition that reports the total
  space for that partition. It also adds a new "all" category with sensors
  that report the used/free space for all partitions.

TEST PLAN
  New sesnors are available in KSysGuard

REPOSITORY
  R106 KSysguard

BRANCH
  partition_sensors

REVISION DETAIL
  https://phabricator.kde.org/D28438

AFFECTED FILES
  ksysguardd/Linux/diskstat.c
  ksysguardd/Linux/diskstat.h

To: ahiemstra, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28354: [applets/digital-clock] Fix calendar events not being shown at first

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> CalendarView.qml:154
>  
> +function dateEquals(date1, date2) {
> +var values1 = [

Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs 
since epoch)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

To: epopov, ngraham, #plasma, vkrause
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28354: [applets/digital-clock] Fix calendar events not being shown at first

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a05dc73cf7fb: [applets/digital-clock] Fix calendar events 
not being shown at first (authored by epopov, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28354?vs=78853=78899

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

broulik added a comment.


  Affects any `ComboBox` in a KCM for me, that isn't in a `Popup`: Fonts KCM, 
GTK config on Styles KCM (not the one in the fine tuning popup), the filter in 
colors KCM, ...

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27701

To: broulik, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

ngraham added a comment.


  This needs a rebase on master, as it currently does not apply.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28435: [System Tray] Update effective status on model insertion

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, kmaterka, davidre, ahmadsamir.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Started Konversation, has proper effective status of passive again. Before 
it was empty

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28435

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: broulik, #plasma, kmaterka, davidre, ahmadsamir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28433: Apply the correct palette to icons

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Our icons can be recolored. However there is a difference between custom 
colors
  on widgets and icons. We will respect the palette but KIconLoader that creates
  the icon pixmaps operates on an application wide palette basis. This can 
create
  miscolored icons when a widget has a custom palette. A helper function is
  introduced to load the pixmaps that switches the palette of the global
  KIconLoader if necessary and resets it appropriately.

REPOSITORY
  R31 Breeze

BRANCH
  iconspalette (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28433

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

[Kai Uwe Broulik]

broulik updated this revision to Diff 78891.
broulik retitled this revision from "[Colors KCM] Use Kirigami.SearchField" to 
"[Colors / Desktop Theme KCM] Use Kirigami.SearchField".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  - Add `i18n` to work around translation loading bug
  - Also port `desktoptheme` KCM which has a copy of this

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25462?vs=70159=78891

REVISION DETAIL
  https://phabricator.kde.org/D25462

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, aspotashev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28314: Allow setting separate corner radii for ShadowedRectangle

[Kai Uwe Broulik]

broulik added a comment.


  Cool

INLINE COMMENTS

> shadowedrectangle.h:157
> +private:
> +float m_topLeft = -1.0;
> +float m_topRight = -1.0;

How about using NaN to define "not set"? though you can't have negative radius, 
so probably fine

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28314

To: ahiemstra, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28427: [libnotificationmanager] forward notifications to lockscreen

[Bhushan Shah]

bshah updated this revision to Diff 78884.
bshah added a comment.


  - adapt to changes in the kscreenlocker

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28427?vs=78871=78884

BRANCH
  bshah/ksld-notify

REVISION DETAIL
  https://phabricator.kde.org/D28427

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/server_p.cpp

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah updated this revision to Diff 78883.
bshah added a comment.


  - add argument for the notification id in dbus service
  - add wayland protocol stanza for passing notification data to greeter

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28428?vs=78872=78883

BRANCH
  bshah/ksld-notifications

REVISION DETAIL
  https://phabricator.kde.org/D28428

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h
  protocols/ksld.xml

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28386: fix(kded): watch config also when known config is applied

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:3dced489d7c1: fix(kded): watch config also when known 
config is applied (authored by romangg).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28386?vs=78756=78882

REVISION DETAIL
  https://phabricator.kde.org/D28386

AFFECTED FILES
  kded/daemon.cpp

To: romangg, #plasma, bshah
Cc: bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28389: Add support for logging categories

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:23
> Make sure the include() call is before the add_subdirectory().
> 
> That's why we usually put them together on top right under the find_package() 
> together with `include(ECMGenerateHeaders)`.

Put the include on top and the other trick was to just include the generated 
cpp file. Thanks.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28389

To: romangg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28389: Add support for logging categories

[Roman Gilg]

romangg updated this revision to Diff 78881.
romangg added a comment.


  Include the cpp files

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28389?vs=78765=78881

BRANCH
  logging-categories

REVISION DETAIL
  https://phabricator.kde.org/D28389

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/main.cpp
  ksldapp.cpp
  logind.cpp
  x11locker.cpp

To: romangg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:30a713025624: [kioclient] Fix kioclient5 
--commands usage messages (authored by ahmadsamir).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28423?vs=78856=78876

REVISION DETAIL
  https://phabricator.kde.org/D28423

AFFECTED FILES
  kioclient/kioclient.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28427: [libnotificationmanager] forward notifications to lockscreen

[Nicolas Fella]

nicolasfella added a comment.


  So notifications are only forwarded if x-kde-show-on-lockscreen is set? I 
wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard 
to third-party apps. From a privacy POV I think a global 
dont-show-notis-on-lockscreen thing would make more sense than a per-app thing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28427

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> interface.cpp:213
>  
> +void Interface::Notify(const QString& app_name, uint replaces_id, const 
> QString& app_icon,
> +   const QString& summary, const QString& body, const 
> QStringList& actions,

conding style: & after space

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28428

To: bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Benjamin Port]

bport added a comment.


  Some coding style nitpicking

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>  int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for (const QString  : qAsConst(mComponents))
>  {

{ on same line

> export_scheme_dialog.cpp:74
> +const auto buttons = mButtons.buttons();
> +for (const QAbstractButton *button : buttons)
>  {

{ on same line

> kglobalshortcutseditor.cpp:168
>  
> -for( KServiceGroup::List::ConstIterator it = list.constBegin();
> +for ( KServiceGroup::List::ConstIterator it = list.constBegin();
>   it != list.constEnd(); ++it) {

you have an unneeded space after (

> kglobalshortcutseditor.cpp:543
> +for (const QString  : groupList)
>  {
>  // do not overwrite the Settings group. That makes it possible to

{ on same line

> kglobalshortcutseditor.cpp:832
> +for (const QString  : keys)
>  {
>  if (components.value(text)->uniqueName() == componentUnique)

{ same line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Monday Meeting Notes Week 14 (2020-03-30)

[Kai Uwe Broulik]

Week 14 of 2020 Plasma meeting notes from 2020-03-30:
Hope you're all doing well and staying at home.

DavidRedondo

* I am continuing work for coloring icons in the correct colors
	* Patch for breeze kdecoration now up on phab: 
https://phabricator.kde.org/D28330

* IconItem is fixed already
* Somebody reported to me a bug in the systray because they thought it 
was also coloring bug

* Turns out our sni implementation was bad
	* The data engine does complicated icon logic which breaks and has 
weird interaction with plasma iconitem
* Patch on phab to expose only the raw properties in the engine and do 
the rendering in the actual implementation 
https://phabricator.kde.org/D28208


Q/A:

 dataengines are supposedly stable API
 d_ed: yeah that was my main concern also but I think we all 
involved agreed it was an acceptable break for the common good™
 Yeah that's why I didn't actually remove the properties 
for now

 ok, cool
 So we could keep them around if we want to
 And just ignore them in the applet
 nah, I'm fine with killing all dataengines with fire :)
 as long as we're aware of everything
 We asked latte if they use it and they just use the 
systray applet


d_ed

* I've been working on two big things
* plasma getting a systemd powered startup
	* This is most going all well, all the long groundwork moving 
plasma-session meant it's all gone pretty smoothly

* Also I've been doing some big changes to ksysguard
* last year we introduced plugins for processes, which worked quite well
* so I've done the same for the global stats
* with a new API and all
* these are some big reviews, so we need some volunteers on that
* In terms of my usual frustrated rant:
* This bug list of "very high priority bugs"

https://bugs.kde.org/buglist.cgi?cmdtype=dorem_id=1729437=VHI-priority%20Plasma%20bugs=run_id=208174
* seems to not have moved at all
* like last week
* we had a "security" ish, issue last week with .desktop files having an 
Exec line being used in KRun(someUrl)
	* whilst we're doing the Application/Command job porting and looking 
through usages of KRun it's worth checking any that use the 
KRun(someUrl) constructor and possibly making them not execute things
* my other thing I wanted to discuss - if lots of people are on Corona 
lockdown it might be a good opportunity for some onboarding
	* so I was thinking we could organise some "bug day" or day-long 
virtual sprint or something...


Q/A:

 I think the breeze gtk thing is moving
 I've got stuck on the pinned apps moving
 I'm pretty sure I know what's going on and what's causing it, 
fixing it is annoying

 ok, that's good to hear
 make sure to keep bugs up to date with findings
 I wonder if Bug 418466 is also a side-effect of that ghns 
changedentrieschanged emissions bug
 KDE bug 418466 in systemsettings (kcm_desktoptheme) "Intalled 
Global themes not showing up in Setting's Global theme section." 
[normal,] https://bugs.kde.org/show_bug.cgi?id=418466

 I hereby task you with finding out !
 ok
[...]
 d_ed: but that's the same with clicking on said file right
 DavidRedondo: when clicking on it in dolphin it asks
 recent docs runner would just blatantly execute
 KRun(someUrl) also asks
 if not executable
 also, if possible use service explicitly with URL
 yeah, that too
 e.g. that's what I added KServiceAction for 
applicationlauncherjob, so we don't exec a command but invoke the 
"proper service"
 DavidRedondo: so you're right it wasn't super critical or easy to 
exploit, but it's still worth locking down what we can

[...]
 Speaking of corona, because of sprints being canceled I 
had the idea maybe we could arange topic calls or something if needed?
 DavidRedondo: ack. I think we need a wayland call at some point 
after that long ML thread

 Virtual sprint? :D

bshah
=
* I have been mostly busy with:
	* "[libnotificationmanager] forward notifications to lockscreen" [Needs 
Review] https://phabricator.kde.org/D28427
	* Diff 28428 "[screenlocker] listen to notifications from the 
notification server" [Needs Review] https://phabricator.kde.org/D28428

* There's some more code but it is not polished enough to be public :P
* Apart from it my last week hasn't been that much productive.

Q/A:

 is that stuck on anything needing discussion?
 d_ed: nope, not really
 how generic is that?
 as in, would it also support displaying notifications on 
the normal lockscreen?

 not very iirc
 we've discussed making it generic but we kinda coujldn't 
agree on a scope and security model
 ahiemstra[m]: it could, yes. But I am test-driving it on mobile 
greeter first

 right
 then someone can add it in desktop greeter ;)
 sure
 there's bit we (I and Kai) discussed about notification handler
 which is kinda neat, but then we didn't find a right place to 
put this as API

 and then my nice plan was killed :'(
 yeah I would have loved a generic notification 

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  This will allow notification manager to forward the notifications that
  are meant to be shown on the lockscreen, currently it requires patches
  in ksld wayland protocol and greeter to be useful, which is not part of
  this patch.

TEST PLAN
  tested with D28427 

REPOSITORY
  R133 KScreenLocker

BRANCH
  bshah/ksld-notifications

REVISION DETAIL
  https://phabricator.kde.org/D28428

AFFECTED FILES
  dbus/org.kde.screensaver.xml
  interface.cpp
  interface.h

To: bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28427: [libnotificationmanager] forward notifications to lockscreen

[Bhushan Shah]

bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  This is currently WIP, and doesn't fully work, requires patches on both
  kscreenlocker and lockscreen theme.

TEST PLAN
  tested that dbus call is done using qDebugs for now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bshah/ksld-notify

REVISION DETAIL
  https://phabricator.kde.org/D28427

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/server_p.cpp

To: bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

[David Edmundson]

davidedmundson added a comment.


  looks good to me, but lets delay merging till the relevant other parts are 
ready.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28424

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

[Méven Car]

meven updated this revision to Diff 78866.
meven marked 6 inline comments as done.
meven added a comment.


  Remove unnecessary semilicons, formatting

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28331?vs=78663=78866

BRANCH
  arcpatch-D28331

REVISION DETAIL
  https://phabricator.kde.org/D28331

AFFECTED FILES
  kcms/mouse/backends/kwin_wl/kwin_wl_device.cpp
  kcms/mouse/backends/kwin_wl/kwin_wl_device.h
  kcms/mouse/kcm/libinput/main.qml
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpad.qml

To: meven, #kwin, #plasma, davidedmundson, ervin, bport, crossi, hchain
Cc: ngraham, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> meven wrote in autostart.cpp:210
> ?

rows inserted gives you a range of [first,last] which was added

> meven wrote in autostart.cpp:182
> You mean I should use open/finished right ?

Yes.
It then also needs to set a transient parent and window modality manual I think

> meven wrote in autostart.cpp:241
> Can't use it here: QTreeWidgetItem does not inherit QObject.

Ok

> meven wrote in autostartmodel.h:52
> Not sure what you mean.

Why define `DisplayRole` as dedicated enum entry, rather than just using 
`Qt::DisplayRole` in the code everywhere

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in CMakeLists.txt:43
> Do we rather want it in libexec since it's not meant to be run by the user?

There's a bit of a challenge there.

We need this executable to be found by the xdg generator.
libexec seems to be all over the place across different packaging.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28424

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> CMakeLists.txt:43
> +if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
> +install(TARGETS kde-systemd-start-condition DESTINATION 
> ${KDE_INSTALL_BINDIR})
> +endif ()

Do we rather want it in libexec since it's not meant to be run by the user?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28424

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in autostart.cpp:210
> You probably want to loop
> 
>   for (int i = first; i <= last; ++i) {

?

> broulik wrote in autostart.cpp:182
> In preparation for a move to QML, can we please not `exec()`

You mean I should use open/finished right ?

> broulik wrote in autostart.cpp:231
> Don't always ignore those ranges, we want to handle this model stuff properly

?

> broulik wrote in autostart.cpp:241
> `qobject_cast`

Can't use it here: QTreeWidgetItem does not inherit QObject.

> broulik wrote in autostartmodel.h:52
> Why not just use `Qt::DisplayRole`?

Not sure what you mean.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

[Henri Chain]

hchain created this revision.
hchain added reviewers: davidedmundson, broulik, dfaure, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hchain requested review of this revision.

REVISION SUMMARY
  For systemd autostart generator will add a 
ExecCondition=kde-systemd-start-condition rcfile:section:entry:default
  As described in T12627 . Needs D28421 


TEST PLAN
  Run kde-systemd-start-condition; should return 0 with a missing or incomplete 
argument, 255 with a false or non-existent and non-default con
  fig value.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28424

AFFECTED FILES
  startkde/CMakeLists.txt
  startkde/kde-systemd-start-condition.cpp

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28330: Color icons in titlebar if possible

[David Redondo]

davidre updated this revision to Diff 78860.
davidre added a comment.


  forgot else

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28330?vs=78859=78860

BRANCH
  icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28330

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezebutton.cpp

To: davidre, #plasma, #vdg, ngraham
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28330: Color icons in titlebar if possible

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> breezebutton.cpp:153
> +KIconLoader::global()->resetPalette();
> +}
>  

KWin doesn't change the palette, it uses to global one to draw the icons for 
example when you right click on a window titlebar.

REPOSITORY
  R31 Breeze

BRANCH
  icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28330

To: davidre, #plasma, #vdg, ngraham
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28330: Color icons in titlebar if possible

[David Redondo]

davidre updated this revision to Diff 78859.
davidre added a comment.


  Check if cast is successfull

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28330?vs=78639=78859

BRANCH
  icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28330

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezebutton.cpp

To: davidre, #plasma, #vdg, ngraham
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28423: [kioclient] Fix 'kioclient5 --commands' usage messages

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  It should use 'kioclient5'.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  l-help-messages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28423

AFFECTED FILES
  kioclient/kioclient.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven updated this revision to Diff 78855.
meven marked 10 inline comments as done.
meven added a comment.


  code style mostly, adress Kai review

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26934?vs=78681=78855

BRANCH
  D26934

REVISION DETAIL
  https://phabricator.kde.org/D26934

AFFECTED FILES
  kcms/autostart/CMakeLists.txt
  kcms/autostart/autostart.cpp
  kcms/autostart/autostart.h
  kcms/autostart/autostartitem.cpp
  kcms/autostart/autostartitem.h
  kcms/autostart/autostartmodel.cpp
  kcms/autostart/autostartmodel.h

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre added a comment.




INLINE COMMENTS

> systemtraymodel.cpp:331
> +if (!iconThemePath.isEmpty()) {
> + loader = new KIconLoader(sourceName, {iconThemePath});
> + loader->addAppDir(sourceName, iconThemePath);

This works now, but I don't know how to manage the KIconLoader. The 
KIconEngines are managed by QIcon (they take ownership of the engine). One idea 
would be to add it to the item maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28422: WIP: Use ecm_install_configured_files macro

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  DO NOT MERGE YET.
  
  Uploaded to show intended usage whilst discussing API.

TEST PLAN
  N/A

REPOSITORY
  R120 Plasma Workspace

BRANCH
  configured_install

REVISION DETAIL
  https://phabricator.kde.org/D28422

AFFECTED FILES
  CMakeLists.txt
  krunner/CMakeLists.txt
  login-sessions/CMakeLists.txt
  runners/baloo/CMakeLists.txt
  runners/baloo/org.kde.baloorunner.service.in
  shell/CMakeLists.txt
  wallpapers/image/CMakeLists.txt

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28354: [applets/digital-clock] Fix calendar events not being shown at first

[Eugene Popov]

epopov updated this revision to Diff 78853.
epopov added a comment.


  Rebase to `master`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28354?vs=78715=78853

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 78852.
davidre added a comment.


  - Also handle IconThemePath We need the KIconEngine thing like the dataengine 
did. To make it as not as complicated I moved the "name ? name : pixmap" into 
the model.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78481=78852

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, leinir, davidre.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  GHNS Quick Button signals `changedEntriesChanged` initially even if nothing 
changed.
  While this is a bug that should be fixed in GHNS, the wallpaper model didn't 
handle the case well, when the model was reloaded while a preview was being 
generated.
  
  It looks up whether a preview exists by `QUrl` and stores a 
`QPersistentModelIndex`. However, when the model is reloaded and it accesses 
`data` for the same `QUrl`, the job might still be in-flight, but the 
`QPersistentModelIndex` is invalid as the model has been reset.
  
  This fixes it by performing all lookups exclusively on 
`QPersistentModelIndex`. The hash lookup is optimized for `data()` (loads of 
accesses) with the slower `key()` lookup being done only when the less 
frequently occurring thumbnail generation finishes/fails.
  It will now do two preview jobs initially, but at least it shows something 
again...
  
  BUG: 419234
  FIXED-IN: 5.18.4

TEST PLAN
  - I get thumbnails in wallpaper dialog again
  - It doesn't spwan multiple preview jobs for the same index anymore.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28420

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h

To: broulik, #plasma, leinir, davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik updated this revision to Diff 78842.
broulik added a comment.
This revision is now accepted and ready to land.


  - Adjust to API change in `KServiceAction`
  - Drop linkage of `KIOWidgets` in favor of `KIOGui` (though `KIOFileWidgets` 
probably implies it anyway)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28286?vs=78521=78842

REVISION DETAIL
  https://phabricator.kde.org/D28286

AFFECTED FILES
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

[Kai Uwe Broulik]

broulik updated this revision to Diff 78840.
broulik added a comment.


  - Adjust to API change in `KServiceAction`
  - Also don't use now deprecated `QUrl::queryItemValue`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28347?vs=78651=78840

REVISION DETAIL
  https://phabricator.kde.org/D28347

AFFECTED FILES
  runners/services/CMakeLists.txt
  runners/services/servicerunner.cpp
  runners/shell/CMakeLists.txt
  runners/shell/shellrunner.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart