D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah updated this revision to Diff 79013.
bshah added a comment.


  - change signal name, notify caused confusion with notify of QObj

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28455?vs=78978=79013

BRANCH
  bshah/ksld-dbus-notify

REVISION DETAIL
  https://phabricator.kde.org/D28455

AFFECTED FILES
  CMakeLists.txt
  dbus/org.freedesktop.Notifications.xml
  dbus/org.kde.screensaver.Greeter.xml
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/notifications.cpp
  greeter/notifications.h

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  Thanks, that helps a lot. It still feels a little bit slower than before, but 
it's at least much improved.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 79010.
cblack added a comment.


  More optimization

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=79006=79010

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  In D28461#639056 , @ngraham wrote:
  
  > Is D28460  the only other patch that's 
needed? I applied that and then this patch compiled fine, but I don't see any 
difference in the sidebar, despite having changed some settings from their 
default values.
  
  
  No we also need to add probe to each KCM there is an example with the color 
one there D28462  (locally I have more 
example but need some code cleanup and not needed for code review so I will do 
code cleanup after probe API cleanup is done i.e. patch D28460 
)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Nathaniel Graham]

ngraham added a comment.


  Is D28460  the only other patch that's 
needed? I applied that and then this patch compiled fine, but I don't see any 
difference in the sidebar, despite having changed some settings from their 
default values.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex added a comment.


  In D28057#639054 , @ngraham wrote:
  
  > Sorry for the delay, I will resume reviewing this soon.
  
  
  No worries :) Thank you for your support !

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 79006.
cblack added a comment.


  More optimization

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78928=79006

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Nathaniel Graham]

ngraham added a comment.


  Sorry for the delay, I will resume reviewing this soon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28468: Add property initializer support to PagePool

[Mason McParlane]

masonm created this revision.
masonm added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
masonm requested review of this revision.

REVISION SUMMARY
  Currently PagePool allows pages to be pushed onto the stack but there
  is no way to pass initialization properties to the newly-created
  page. This change adds support for this, and also provides
  asynchronous object creation to speed things up a bit.

TEST PLAN
  After running the following main.qml the page stack will first
  push a page with the default title "NO PROPERTIES" because it
  invokes the no-property behavior. Afterward the same page gets
  pushed on the stack but this time it sets the title to
  "PROPERTIES" using the passed-in properties object.
  
  // main.qml
  Kirigami.ApplicationWindow {
  
id: window

Kirigami.PagePool {
  id: pool
}

Kirigami.PagePoolAction {
  id: noprops

  text: "Action with props"
  pagePool: pool
  pageStack: window.pageStack
  page: "qrc:/TestPage.qml?hasProps=" + false
}
Kirigami.PagePoolAction {
  id: props

  text: "Action with props"
  pagePool: pool
  pageStack: window.pageStack
  page: "qrc:/TestPage.qml?hasProps=" + true
  properties: { title: "PROPERTIES" }
}

Component.onCompleted: {
  noprops.trigger()
  props.trigger()
}
  
  }
  
  // TestPage.qml
  Kirigami.Page {
  
title: "NO PROPERTIES"
  
  }

REPOSITORY
  R169 Kirigami

BRANCH
  add-pagepool-properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28468

AFFECTED FILES
  src/controls/PagePoolAction.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: plasma-devel, mart, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  In D28461#639022 , @ngraham wrote:
  
  > I get a compile error:
  >
  >   /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function 
‘void MenuItem::updateDefault()’:
  >   /home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: 
‘isDefaults’ is not a member of ‘KCModuleLoader’
  > 154 | d->isDefault = KCModuleLoader::isDefaults(d->item);
  > |^~
  >
  >
  > Does this have un-merged dependencies? If so, you can mark them in Phab by 
adding the text `Depends on D12345` (but the actual patch ID, not D12345 
 :) ) in the Summary section.
  
  
  Ok I will add it I thought setting a parent revision on the right sidebar was 
enough

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Make sure you test how this looks in the System Tray too, and not just as a 
standalone applet. ;)

INLINE COMMENTS

> FullRepresentation.qml:31
>  
> -PlasmaBt.DevicesProxyModel {
> -id: devicesModel
> -sourceModel: BluezQt.DevicesModel { }
> +heading: Toolbar {
> +id: toolbar

`PlasmaComponents3.Page` doesn't seem to have a `heading` property. Perhaps you 
meant `header`?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove added a comment.


  In D28467#639027 , @ngraham wrote:
  
  > Screenshots in the Test Plan section are always appreciated :)
  
  
  True, sorry. Added

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham added a comment.


  Screenshots in the Test Plan section are always appreciated :)

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Nathaniel Graham]

ngraham added a comment.


  I get a compile error:
  
/home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function 
‘void MenuItem::updateDefault()’:
/home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: 
‘isDefaults’ is not a member of ‘KCModuleLoader’
  154 | d->isDefault = KCModuleLoader::isDefaults(d->item);
  |^~
  
  Does this have un-merged dependencies? If so, you can mark them in Phab by 
adding the text `Depends on D12345` (but the actual patch ID, not D12345 
 :) ) in the Summary section.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  In D28461#639016 , @abetts wrote:
  
  > If I am understanding correctly, this patch adds icons in the kcm list to 
indicate changes you can revert by going to the kcm. Basically, default 
settings have changed and now you have the possibility to see that changes have 
been made. I am not sure that I like the implementation. I have some questions.
  >
  > What will you do when all of them are changed in some way? Will the entire 
kcm list show an icon indicating change? If you think about it, KDE is the DE 
of changes and options. I feel all of these are going to show some kind of 
change, that could be overwhelming. At the end of the day, is it necessary? 
Wouldn't this be something that probably works best by having it in the 
reset/defaults button?
  
  
  Being the DE of "changes and options" don't mean all people are changing 
everything, but that also mean some people will do some change and then don't 
remember what they changed, and will never find what differ from the default 
values. Reset / Default button have totally different purpose, default button 
will set back default value and will be indeed active if module don't have 
default value. However, user will know that only if he goes to the good module. 
Problem for a "lambda" user is to remember what change.
  
  > Also, these icons indicate change, if you click on the item and then land 
in a kcm that doesn't present more clues as to what changed, then you are left 
with the default action to click defaults or reset on the kcm anyway. There 
doesn't seem to be much more value there.
  
  There is another patch for this purpose
  https://phabricator.kde.org/D27540

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Andres Betts]

abetts added a comment.


  If I am understanding correctly, this patch adds icons in the kcm list to 
indicate changes you can revert by going to the kcm. Basically, default 
settings have changed and now you have the possibility to see that changes have 
been made. I am not sure that I like the implementation. I have some questions.
  
  What will you do when all of them are changed in some way? Will the entire 
kcm list show an icon indicating change? If you think about it, KDE is the DE 
of changes and options. I feel all of these are going to show some kind of 
change, that could be overwhelming. At the end of the day, is it necessary? 
Wouldn't this be something that probably works best by having it in the 
reset/defaults button?
  
  Also, these icons indicate change, if you click on the item and then land in 
a kcm that doesn't present more clues as to what changed, then you are left 
with the default action to click defaults or reset on the kcm anyway. There 
doesn't seem to be much more value there.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham added a comment.


  In D28467#638980 , @niccolove 
wrote:
  
  > I'm a bit confused by
  >
  >   import org.kde.plasma.components 2.0 as PlasmaComponents
  >   import org.kde.plasma.components 3.0 as PlasmaComponents3
  >
  >
  > is it correct?
  
  
  Yes

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  F8208462: image.png 
  
  Test with a blue dot, took less space than an icon
  Wa can imagine a tooltip when you go hover the  dot explaining it

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:175424169d18: [applets/clipboard]: Fix applet closing 
itself when clicking on a history item… (authored by epopov, committed by 
ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78992=79001

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 79000.
niccolove added a comment.


  Import components3 separately

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=78999=79000

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove added a comment.


  I'm a bit confused by
  
import org.kde.plasma.components 2.0 as PlasmaComponents
import org.kde.plasma.components 3.0 as PlasmaComponents3
  
  is it correct?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 78999.
niccolove added a comment.


  I said components 3

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=78998=78999

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 78998.
niccolove added a comment.


  unrelated pt3

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=78997=78998

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 78996.
niccolove added a comment.


  Remove unrelated changes

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=78995=78996

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 78997.
niccolove added a comment.


  remove unrelated changes pt2

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=78996=78997

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Plasma 5.18.4

[Jonathan Riddell]

The tars have now been re-rolled and named 5.18.4.1 available in the same place.

Jonathan


On Tue, Mar 31, 2020 at 01:49:26PM +, Jonathan Riddell wrote:
> 
> Sorry all I didn't bump the version numbers in the source code.  I'll re-roll 
> the tars as 5.18.4.1
> 
> Jonathan
> 
> 
> On Tue, Mar 31, 2020 at 02:41:27PM +0100, Jonathan Riddell wrote:
> > Plasma 5.18.4 is now released https://www.kde.org/announcements/
> > plasma-5.18.4.php

D28467: Converted to Page with a PlasmodHeading in the heading

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Now the main view is a Page, the toolbar is moved to the heading and it's 
contained in a PlasmoidHeading

REPOSITORY
  R97 Bluedevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Lovely. Works perfectly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.14 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.14/3/
 Project:
stable-kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 31 Mar 2020 13:56:54 +
 Build duration:
56 min and counting
   CONSOLE OUTPUT
  [...truncated 218 lines...][2020-03-31T14:53:44.039Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.14'[2020-03-31T14:53:44.039Z] STAGE_NAME= 'Configuring Build'[2020-03-31T14:53:44.039Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-03-31T14:53:44.039Z] BLOCKSIZE = 'K'[2020-03-31T14:53:44.039Z] EXECUTOR_NUMBER   = '0'[2020-03-31T14:53:44.039Z] SHLVL = '0'[2020-03-31T14:53:44.039Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T14:53:44.039Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-31T14:53:44.039Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-31T14:53:44.039Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-31T14:53:44.039Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-31T14:53:44.039Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-03-31T14:53:44.039Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-03-31T14:53:44.039Z] QT_SELECT = 'qt5'[2020-03-31T14:53:44.039Z] LANG  = 'en_US.UTF-8'[2020-03-31T14:53:44.039Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T14:53:44.039Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-03-31T14:53:44.039Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-03-31T14:53:44.039Z] [2020-03-31T14:53:44.039Z] [2020-03-31T14:53:44.039Z] == Commencing Configuration:[2020-03-31T14:53:44.039Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.14"[2020-03-31T14:53:44.039Z] -- The C compiler identification is Clang 8.0.1[2020-03-31T14:53:44.039Z] -- The CXX compiler identification is Clang 8.0.1[2020-03-31T14:53:44.296Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T14:53:44.296Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T14:53:44.296Z] -- Detecting C compiler ABI info[2020-03-31T14:53:44.296Z] -- Detecting C compiler ABI info - done[2020-03-31T14:53:44.296Z] -- Detecting C compile features[2020-03-31T14:53:44.296Z] -- Detecting C compile features - done[2020-03-31T14:53:44.296Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-31T14:53:44.296Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-31T14:53:44.296Z] -- Detecting CXX compiler ABI info[2020-03-31T14:53:44.551Z] -- Detecting CXX compiler ABI info - done[2020-03-31T14:53:44.551Z] -- Detecting CXX compile features[2020-03-31T14:53:44.551Z] -- Detecting CXX compile features - done[2020-03-31T14:53:44.551Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for PowerDevil.[2020-03-31T14:53:44.551Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-03-31T14:53:44.551Z] -- Looking for __GLIBC__[2020-03-31T14:53:44.551Z] -- Looking for __GLIBC__ - not found[2020-03-31T14:53:44.551Z] -- Performing Test _OFFT_IS_64BIT[2020-03-31T14:53:44.551Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-31T14:53:44.551Z] -- Performing Test HAVE_DATE_TIME[2020-03-31T14:53:44.551Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-31T14:53:44.551Z] -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.69.0") [2020-03-31T14:53:44.551Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.69.0") [2020-03-31T14:53:44.551Z] -- Found KF5IdleTime: /usr/home/jenkins/install-prefix/lib/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake (found version "5.69.0") [2020-03-31T14:53:44.551Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.69.0") [2020-03-31T14:53:44.551Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.69.0") [2020-03-31T14:53:44.551Z] -- Found KF5Solid: /usr/home/jenkins/install-prefix/lib/cmake/KF5Solid/KF5SolidConfig.cmake 

D28461: In sidebar mode show if a module is in default state or not

[Noah Davis]

ndavis added a comment.


  maybe it would make more sense to add a different way to view non-default 
settings? like maybe a summary of custom settings.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.14/7/
 Project:
stable-kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 31 Mar 2020 13:54:19 +
 Build duration:
50 min and counting
   CONSOLE OUTPUT
  [...truncated 218 lines...][2020-03-31T14:45:01.732Z] HOME  = '/home/jenkins'[2020-03-31T14:45:01.732Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.14/7/'[2020-03-31T14:45:01.732Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.14/'[2020-03-31T14:45:01.732Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-31T14:45:01.732Z] SHELL = '/bin/sh'[2020-03-31T14:45:01.732Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.14'[2020-03-31T14:45:01.732Z] STAGE_NAME= 'Configuring Build'[2020-03-31T14:45:01.732Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-03-31T14:45:01.732Z] BLOCKSIZE = 'K'[2020-03-31T14:45:01.732Z] EXECUTOR_NUMBER   = '0'[2020-03-31T14:45:01.732Z] SHLVL = '0'[2020-03-31T14:45:01.732Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T14:45:01.732Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-31T14:45:01.732Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-31T14:45:01.732Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-31T14:45:01.732Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-31T14:45:01.732Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-03-31T14:45:01.732Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-03-31T14:45:01.732Z] QT_SELECT = 'qt5'[2020-03-31T14:45:01.732Z] LANG  = 'en_US.UTF-8'[2020-03-31T14:45:01.732Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T14:45:01.732Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-03-31T14:45:01.732Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-03-31T14:45:01.732Z] [2020-03-31T14:45:01.732Z] [2020-03-31T14:45:01.732Z] == Commencing Configuration:[2020-03-31T14:45:01.732Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.14"[2020-03-31T14:45:01.732Z] -- The C compiler identification is Clang 8.0.1[2020-03-31T14:45:01.990Z] -- The CXX compiler identification is Clang 8.0.1[2020-03-31T14:45:01.990Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T14:45:01.990Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T14:45:01.990Z] -- Detecting C compiler ABI info[2020-03-31T14:45:01.990Z] -- Detecting C compiler ABI info - done[2020-03-31T14:45:01.990Z] -- Detecting C compile features[2020-03-31T14:45:01.990Z] -- Detecting C compile features - done[2020-03-31T14:45:01.990Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-31T14:45:01.990Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-31T14:45:01.990Z] -- Detecting CXX compiler ABI info[2020-03-31T14:45:01.990Z] -- Detecting CXX compiler ABI info - done[2020-03-31T14:45:01.990Z] -- Detecting CXX compile features[2020-03-31T14:45:01.990Z] -- Detecting CXX compile features - done[2020-03-31T14:45:01.990Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for plasma-desktop.[2020-03-31T14:45:01.990Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-03-31T14:45:01.990Z] -- Looking for __GLIBC__[2020-03-31T14:45:01.990Z] -- Looking for __GLIBC__ - not found[2020-03-31T14:45:01.990Z] -- Performing Test _OFFT_IS_64BIT[2020-03-31T14:45:01.990Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-31T14:45:01.990Z] -- Performing Test HAVE_DATE_TIME[2020-03-31T14:45:01.990Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-31T14:45:01.990Z] -- Found KF5Auth: /usr/home/jenkins/install-prefix/lib/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.69.0") [2020-03-31T14:45:01.990Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for 

D27677: refactor: incorporate prior libkscreen EDID changes

[Roman Gilg]

romangg added a comment.


  Oh, I just noticed: Please absolutely add a commit message body to this 
commit on push! Just a single line explaining what you do is enough.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27677

To: dvratil, #plasma, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27675: feat: avoid duplicated text when assembling user-facing output names

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Sorry for late review. I didn't get notified by this bullshit platform (which 
might be because I disabled all notifications at one point to not get spammed 
constantly).

INLINE COMMENTS

> utils.cpp:46
> +
> +// Otherwise return just the new text (might be an empty string, but 
> that's OK)
> +return toAppendTrimmed;

full-stop

REPOSITORY
  R104 KScreen

BRANCH
  arcpatch-D27675

REVISION DETAIL
  https://phabricator.kde.org/D27675

To: dvratil, #plasma, romangg
Cc: ahmadsamir, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Eugene Popov]

epopov updated this revision to Diff 78992.
epopov added a comment.


  Rebase on **master**, second edition. Can you try this patch?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78926=78992

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D10042: feat: parse EDID on the backend side

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  In D10042#629261 , @dvratil wrote:
  
  > Agreed. deviceId is not actually used (it's stored in KDED config files, 
but the value doesn't seem to be used anywhere). I'll fix it in a separate 
commit (since it also needs adjusting a bunch of unit-tests in libkscreen and 
kscreen).
  
  
  That's ok. Thanks!

INLINE COMMENTS

> CMakeLists.txt:4
>  project(libkscreen)
> -set(PROJECT_VERSION "5.18.80")
> +set(PROJECT_VERSION "5.18.81")
>  

Why project version change?

REPOSITORY
  R110 KScreen Library

BRANCH
  arcpatch-D10042

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport added a comment.


  Goal of this feature is to improve user discoverability and allow them to 
find more easily which settings diverged from defaults one, so they can more 
easily revert to the default value when needed
  Indeed the current indicator is not the good one, and I will be happy to have 
some help to find a nicest one.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28458: [runners/converter] Skip empty parts when splitting units

[Nathaniel Graham]

ngraham added a comment.


  No problem. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28458

To: alex, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.14 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.14/2/
 Project:
stable-kf5-qt5 FreeBSDQt5.14
 Date of build:
Tue, 31 Mar 2020 13:51:35 +
 Build duration:
20 min and counting
   CONSOLE OUTPUT
  [...truncated 198 lines...][2020-03-31T14:11:32.796Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-03-31T14:11:32.796Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.14'[2020-03-31T14:11:32.796Z] EDITOR= 'vi'[2020-03-31T14:11:32.796Z] ENV   = '/home/jenkins/.shrc'[2020-03-31T14:11:32.796Z] HUDSON_HOME   = '/home/production/data'[2020-03-31T14:11:32.796Z] BUILD_ID  = '2'[2020-03-31T14:11:32.796Z] OLDPWD= '/usr/home/jenkins'[2020-03-31T14:11:32.796Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.14'[2020-03-31T14:11:32.796Z] _ = '/usr/local/bin/java'[2020-03-31T14:11:32.796Z] TERM  = 'su'[2020-03-31T14:11:32.796Z] NODE_LABELS   = 'FreeBSD Builder Iota FreeBSDQt5.14'[2020-03-31T14:11:32.796Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.14-2'[2020-03-31T14:11:32.796Z] BUILD_DISPLAY_NAME= '#2'[2020-03-31T14:11:32.796Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.14/2/display/redirect'[2020-03-31T14:11:32.796Z] USER  = 'jenkins'[2020-03-31T14:11:32.796Z] HOME  = '/home/jenkins'[2020-03-31T14:11:32.796Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.14/2/'[2020-03-31T14:11:32.796Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.14/'[2020-03-31T14:11:32.796Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-31T14:11:32.796Z] SHELL = '/bin/sh'[2020-03-31T14:11:32.796Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.14'[2020-03-31T14:11:32.796Z] STAGE_NAME= 'Configuring Build'[2020-03-31T14:11:32.796Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-03-31T14:11:32.796Z] BLOCKSIZE = 'K'[2020-03-31T14:11:32.796Z] EXECUTOR_NUMBER   = '0'[2020-03-31T14:11:32.796Z] SHLVL = '0'[2020-03-31T14:11:32.796Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T14:11:32.796Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-31T14:11:32.796Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-31T14:11:32.796Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-31T14:11:32.796Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-31T14:11:32.796Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-03-31T14:11:32.796Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-03-31T14:11:32.796Z] QT_SELECT = 'qt5'[2020-03-31T14:11:32.796Z] LANG  = 'en_US.UTF-8'[2020-03-31T14:11:32.796Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T14:11:32.796Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-03-31T14:11:32.796Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-03-31T14:11:32.796Z] [2020-03-31T14:11:32.796Z] [2020-03-31T14:11:32.796Z] == Commencing Configuration:[2020-03-31T14:11:32.796Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.14"[2020-03-31T14:11:32.796Z] -- The C compiler identification is Clang 8.0.1[2020-03-31T14:11:33.052Z] -- The CXX compiler identification is Clang 8.0.1[2020-03-31T14:11:33.052Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T14:11:33.052Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T14:11:33.052Z] -- Detecting C compiler ABI info[2020-03-31T14:11:33.052Z] -- Detecting C compiler ABI info - done[2020-03-31T14:11:33.052Z] -- Detecting C compile features[2020-03-31T14:11:33.052Z] -- Detecting C compile features - done[2020-03-31T14:11:33.052Z] -- Check for working CXX compiler: 

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.14/2/
 Project:
stable-kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 31 Mar 2020 13:57:01 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 267 lines...][2020-03-31T14:09:37.080Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-31T14:09:37.080Z] USER  = 'jenkins'[2020-03-31T14:09:37.080Z] MORE  = '-sl'[2020-03-31T14:09:37.080Z] CSHEDIT   = 'emacs'[2020-03-31T14:09:37.080Z] SHLVL = '2'[2020-03-31T14:09:37.080Z] BUILD_TAG = 'jenkins-Plasma-systemsettings-stable-kf5-qt5 SUSEQt5.14-2'[2020-03-31T14:09:37.080Z] WINDOWMANAGER = 'xterm'[2020-03-31T14:09:37.080Z] PAGER = 'less'[2020-03-31T14:09:37.080Z] EXECUTOR_NUMBER   = '0'[2020-03-31T14:09:37.080Z] CVS_RSH   = 'ssh'[2020-03-31T14:09:37.080Z] LIBGL_DEBUG   = 'quiet'[2020-03-31T14:09:37.080Z] STAGE_NAME= 'Configuring Build'[2020-03-31T14:09:37.080Z] NODE_LABELS   = 'Docker Swarm-25bc5c23287e SUSEQt5.14'[2020-03-31T14:09:37.080Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-31T14:09:37.080Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-31T14:09:37.080Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-31T14:09:37.080Z] PROFILEREAD   = 'true'[2020-03-31T14:09:37.080Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-31T14:09:37.080Z] HOSTTYPE  = 'x86_64'[2020-03-31T14:09:37.080Z] BUILD_ID  = '2'[2020-03-31T14:09:37.080Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-31T14:09:37.080Z] OLDPWD= '/home/jenkins'[2020-03-31T14:09:37.080Z] LC_CTYPE  = 'C.UTF-8'[2020-03-31T14:09:37.080Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T14:09:37.080Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-31T14:09:37.080Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-31T14:09:37.080Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-31T14:09:37.080Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-31T14:09:37.080Z] QT_SELECT = 'qt5'[2020-03-31T14:09:37.080Z] LANG  = 'en_US.UTF-8'[2020-03-31T14:09:37.080Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T14:09:37.080Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-31T14:09:37.080Z] [2020-03-31T14:09:37.080Z] [2020-03-31T14:09:37.080Z] == Commencing Configuration:[2020-03-31T14:09:37.080Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.14"[2020-03-31T14:09:37.080Z] -- The C compiler identification is GNU 9.2.1[2020-03-31T14:09:37.336Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-31T14:09:37.336Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T14:09:37.336Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T14:09:37.336Z] -- Detecting C compiler ABI info[2020-03-31T14:09:37.336Z] -- Detecting C compiler ABI info - done[2020-03-31T14:09:37.336Z] -- Detecting C compile features[2020-03-31T14:09:37.336Z] -- Detecting C compile features - done[2020-03-31T14:09:37.336Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-31T14:09:37.336Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-31T14:09:37.336Z] -- Detecting CXX compiler ABI info[2020-03-31T14:09:37.590Z] -- Detecting CXX compiler ABI info - done[2020-03-31T14:09:37.590Z] -- Detecting CXX compile features[2020-03-31T14:09:37.590Z] -- Detecting CXX compile features - done[2020-03-31T14:09:37.590Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/stable-kf5-qt5 SUSEQt5.14/build/prefix.sh to set the environment for systemsettings.[2020-03-31T14:09:37.590Z] -- Looking for __GLIBC__[2020-03-31T14:09:37.590Z] -- Looking for __GLIBC__ - found[2020-03-31T14:09:37.590Z] -- Performing Test _OFFT_IS_64BIT[2020-03-31T14:09:37.846Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-31T14:09:37.846Z] -- Performing Test HAVE_DATE_TIME[2020-03-31T14:09:37.846Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-31T14:09:37.846Z] -- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake 

D28458: [runners/converter] Skip empty parts when splitting units

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:6e6c5707d406: [runners/converter] Skip empty parts when 
splitting units (authored by alex, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28458?vs=78959=78990

REVISION DETAIL
  https://phabricator.kde.org/D28458

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.14/2/
 Project:
stable-kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 31 Mar 2020 13:56:51 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2020-03-31T14:08:30.605Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.14/2/display/redirect'[2020-03-31T14:08:30.605Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.14/display/redirect'[2020-03-31T14:08:30.605Z] WORKSPACE = '/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.14'[2020-03-31T14:08:30.605Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-31T14:08:30.605Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-03-31T14:08:30.605Z] NODE_NAME = 'Docker Swarm-79bbb0a0339c'[2020-03-31T14:08:30.605Z] HOST  = '79bbb0a0339c'[2020-03-31T14:08:30.605Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-31T14:08:30.605Z] USER  = 'jenkins'[2020-03-31T14:08:30.605Z] MORE  = '-sl'[2020-03-31T14:08:30.605Z] CSHEDIT   = 'emacs'[2020-03-31T14:08:30.605Z] SHLVL = '2'[2020-03-31T14:08:30.605Z] BUILD_TAG = 'jenkins-Plasma-powerdevil-stable-kf5-qt5 SUSEQt5.14-2'[2020-03-31T14:08:30.605Z] WINDOWMANAGER = 'xterm'[2020-03-31T14:08:30.605Z] PAGER = 'less'[2020-03-31T14:08:30.605Z] EXECUTOR_NUMBER   = '0'[2020-03-31T14:08:30.605Z] CVS_RSH   = 'ssh'[2020-03-31T14:08:30.605Z] LIBGL_DEBUG   = 'quiet'[2020-03-31T14:08:30.605Z] STAGE_NAME= 'Configuring Build'[2020-03-31T14:08:30.605Z] NODE_LABELS   = 'Docker Swarm-79bbb0a0339c SUSEQt5.14'[2020-03-31T14:08:30.605Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-31T14:08:30.605Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-31T14:08:30.605Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-31T14:08:30.605Z] PROFILEREAD   = 'true'[2020-03-31T14:08:30.605Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-31T14:08:30.605Z] HOSTTYPE  = 'x86_64'[2020-03-31T14:08:30.605Z] BUILD_ID  = '2'[2020-03-31T14:08:30.605Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-31T14:08:30.605Z] OLDPWD= '/home/jenkins'[2020-03-31T14:08:30.605Z] LC_CTYPE  = 'C.UTF-8'[2020-03-31T14:08:30.605Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T14:08:30.605Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-31T14:08:30.605Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-31T14:08:30.605Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-31T14:08:30.605Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-31T14:08:30.605Z] QT_SELECT = 'qt5'[2020-03-31T14:08:30.605Z] LANG  = 'en_US.UTF-8'[2020-03-31T14:08:30.605Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T14:08:30.605Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-31T14:08:30.605Z] [2020-03-31T14:08:30.605Z] [2020-03-31T14:08:30.605Z] == Commencing Configuration:[2020-03-31T14:08:30.605Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/powerdevil/stable-kf5-qt5 SUSEQt5.14"[2020-03-31T14:08:30.605Z] -- The C compiler identification is GNU 9.2.1[2020-03-31T14:08:30.860Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-31T14:08:30.860Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T14:08:30.860Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T14:08:30.860Z] -- Detecting C compiler ABI info[2020-03-31T14:08:30.860Z] -- Detecting C compiler ABI info - done[2020-03-31T14:08:30.860Z] -- Detecting C compile features[2020-03-31T14:08:30.860Z] -- Detecting C compile features - done[2020-03-31T14:08:30.860Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-31T14:08:31.114Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-31T14:08:31.114Z] -- Detecting CXX compiler ABI info[2020-03-31T14:08:31.114Z] -- Detecting CXX compiler ABI info - done[2020-03-31T14:08:31.114Z] -- Detecting CXX compile features[2020-03-31T14:08:31.114Z] -- 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.14 - Build # 4 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/4/
 Project:
stable-kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 31 Mar 2020 13:54:20 +
 Build duration:
8 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 277 lines...][2020-03-31T14:02:48.283Z] WINDOWMANAGER = 'xterm'[2020-03-31T14:02:48.283Z] PAGER = 'less'[2020-03-31T14:02:48.283Z] EXECUTOR_NUMBER   = '0'[2020-03-31T14:02:48.283Z] CVS_RSH   = 'ssh'[2020-03-31T14:02:48.283Z] LIBGL_DEBUG   = 'quiet'[2020-03-31T14:02:48.283Z] STAGE_NAME= 'Configuring Build'[2020-03-31T14:02:48.283Z] NODE_LABELS   = 'Docker Swarm-7693e5995691 SUSEQt5.14'[2020-03-31T14:02:48.283Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-31T14:02:48.283Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-31T14:02:48.283Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-31T14:02:48.283Z] PROFILEREAD   = 'true'[2020-03-31T14:02:48.283Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-31T14:02:48.283Z] HOSTTYPE  = 'x86_64'[2020-03-31T14:02:48.283Z] BUILD_ID  = '4'[2020-03-31T14:02:48.283Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-31T14:02:48.283Z] OLDPWD= '/home/jenkins'[2020-03-31T14:02:48.283Z] LC_CTYPE  = 'C.UTF-8'[2020-03-31T14:02:48.283Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T14:02:48.283Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-31T14:02:48.283Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-31T14:02:48.283Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-31T14:02:48.283Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-31T14:02:48.283Z] QT_SELECT = 'qt5'[2020-03-31T14:02:48.283Z] LANG  = 'en_US.UTF-8'[2020-03-31T14:02:48.283Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T14:02:48.283Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-31T14:02:48.283Z] [2020-03-31T14:02:48.283Z] [2020-03-31T14:02:48.283Z] == Commencing Configuration:[2020-03-31T14:02:48.283Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14"[2020-03-31T14:02:48.283Z] -- The C compiler identification is GNU 9.2.1[2020-03-31T14:02:48.543Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-31T14:02:48.543Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T14:02:48.543Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T14:02:48.543Z] -- Detecting C compiler ABI info[2020-03-31T14:02:48.808Z] -- Detecting C compiler ABI info - done[2020-03-31T14:02:48.808Z] -- Detecting C compile features[2020-03-31T14:02:48.808Z] -- Detecting C compile features - done[2020-03-31T14:02:48.808Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-31T14:02:49.247Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-31T14:02:49.247Z] -- Detecting CXX compiler ABI info[2020-03-31T14:02:49.247Z] -- Detecting CXX compiler ABI info - done[2020-03-31T14:02:49.247Z] -- Detecting CXX compile features[2020-03-31T14:02:49.247Z] -- Detecting CXX compile features - done[2020-03-31T14:02:49.247Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/build/prefix.sh to set the environment for plasma-desktop.[2020-03-31T14:02:49.247Z] -- Looking for __GLIBC__[2020-03-31T14:02:49.601Z] -- Looking for __GLIBC__ - found[2020-03-31T14:02:49.601Z] -- Performing Test _OFFT_IS_64BIT[2020-03-31T14:02:49.928Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-03-31T14:02:49.928Z] -- Performing Test HAVE_DATE_TIME[2020-03-31T14:02:49.928Z] -- Performing Test HAVE_DATE_TIME - Success[2020-03-31T14:02:50.197Z] -- Found KF5Auth: /home/jenkins/install-prefix/lib64/cmake/KF5Auth/KF5AuthConfig.cmake (found version "5.69.0") [2020-03-31T14:02:50.197Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/build/prefix.sh to set the environment for plasma-desktop.[2020-03-31T14:02:50.197Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/build/prefix.sh to set the environment for 

D28465: [Categories Page] Use BasicListItem

[Kai Uwe Broulik]

broulik added a comment.


  > Tablet mode spacing should just be added into BasicListItem itself
  
  Agreed. I was surprised it didn't actually come from it but was done here 
explicitly

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28465

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28465: [Categories Page] Use BasicListItem

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice! Tablet mode spacing should just be added into BasicListItem itself, if 
it doesn't already have it.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28465

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Filip Fila]

filipf added a comment.


  Can you explain why we want this? It's going to be visually prominent so we 
need a good reason.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  IMHO this is wholly pointless a change, currently. Most people won't care 
about if they've made changes or not in SySe from the defaults, and quite 
frankly seeing that indicator on the sidebar would potentially even deter user 
customisation if not utterly confuse people. If it was an optional setting in 
settings to show these changed settings indicators on the sidebar (such as a 
checkbox item in the SySe menu) that you could turn off by default, I wouldn't 
mind this at all.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Nathaniel Graham]

ngraham added a comment.


  You'll need to compile Plasma from git master, and then run your 
master-branch plasma session. There are instructions here: 
https://community.kde.org/Get_Involved/development#Plasma
  
  Feel free to ping me or anyone else in #plasma 
 or #kde-devel on Freenode IRC or 
Matrix (see 
https://community.kde.org/Get_Involved/development#Communicate_with_the_team) 
if you need a hand.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.14/2/
 Project:
stable-kf5-qt5 SUSEQt5.14
 Date of build:
Tue, 31 Mar 2020 13:51:35 +
 Build duration:
2 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...][2020-03-31T13:54:01.225Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.14'[2020-03-31T13:54:01.225Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-03-31T13:54:01.225Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.14/2/display/redirect'[2020-03-31T13:54:01.225Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.14/display/redirect'[2020-03-31T13:54:01.225Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.14'[2020-03-31T13:54:01.225Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-31T13:54:01.225Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-03-31T13:54:01.225Z] NODE_NAME = 'Docker Swarm-6d4de0674c55'[2020-03-31T13:54:01.225Z] HOST  = '6d4de0674c55'[2020-03-31T13:54:01.225Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-31T13:54:01.225Z] USER  = 'jenkins'[2020-03-31T13:54:01.225Z] MORE  = '-sl'[2020-03-31T13:54:01.225Z] CSHEDIT   = 'emacs'[2020-03-31T13:54:01.225Z] SHLVL = '2'[2020-03-31T13:54:01.225Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.14-2'[2020-03-31T13:54:01.225Z] WINDOWMANAGER = 'xterm'[2020-03-31T13:54:01.225Z] PAGER = 'less'[2020-03-31T13:54:01.225Z] EXECUTOR_NUMBER   = '0'[2020-03-31T13:54:01.225Z] CVS_RSH   = 'ssh'[2020-03-31T13:54:01.225Z] LIBGL_DEBUG   = 'quiet'[2020-03-31T13:54:01.225Z] STAGE_NAME= 'Configuring Build'[2020-03-31T13:54:01.225Z] NODE_LABELS   = 'Docker Swarm-6d4de0674c55 SUSEQt5.14'[2020-03-31T13:54:01.225Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-31T13:54:01.225Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-31T13:54:01.225Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-31T13:54:01.225Z] PROFILEREAD   = 'true'[2020-03-31T13:54:01.225Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-31T13:54:01.225Z] HOSTTYPE  = 'x86_64'[2020-03-31T13:54:01.225Z] BUILD_ID  = '2'[2020-03-31T13:54:01.225Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-31T13:54:01.225Z] OLDPWD= '/home/jenkins'[2020-03-31T13:54:01.225Z] LC_CTYPE  = 'C.UTF-8'[2020-03-31T13:54:01.225Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-31T13:54:01.225Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-31T13:54:01.225Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-31T13:54:01.225Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-31T13:54:01.225Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-31T13:54:01.225Z] QT_SELECT = 'qt5'[2020-03-31T13:54:01.225Z] LANG  = 'en_US.UTF-8'[2020-03-31T13:54:01.225Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-31T13:54:01.225Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-31T13:54:01.225Z] [2020-03-31T13:54:01.225Z] [2020-03-31T13:54:01.225Z] == Commencing Configuration:[2020-03-31T13:54:01.489Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.14"[2020-03-31T13:54:01.753Z] -- The C compiler identification is GNU 9.2.1[2020-03-31T13:54:02.010Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-31T13:54:02.010Z] -- Check for working C compiler: /usr/bin/cc[2020-03-31T13:54:02.267Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-03-31T13:54:02.267Z] -- Detecting C compiler ABI info[2020-03-31T13:54:02.267Z] -- Detecting C compiler ABI info - done[2020-03-31T13:54:02.267Z] -- Detecting C compile features[2020-03-31T13:54:02.267Z] -- Detecting C compile features - done[2020-03-31T13:54:02.267Z] -- Check for working CXX compiler: /usr/bin/c++[2020-03-31T13:54:02.830Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-03-31T13:54:02.830Z] -- 

D28465: [Categories Page] Use BasicListItem

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The delegate doesn't have its own appearance anymore, so just use the default 
one.

TEST PLAN
  Looks almost the same, might have lost the tablet mode spacing increase now?
  Set `label` in any case for accessibility and it now inverts properly when 
selected
  
  Before
  F8208287: Screenshot_20200331_155214.png 

  After
  F8208289: Screenshot_20200331_155154.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28465

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: [kde-announce] Plasma 5.18.4

[Jonathan Riddell]

Sorry all I didn't bump the version numbers in the source code.  I'll re-roll 
the tars as 5.18.4.1

Jonathan


On Tue, Mar 31, 2020 at 02:41:27PM +0100, Jonathan Riddell wrote:
> Plasma 5.18.4 is now released https://www.kde.org/announcements/
> plasma-5.18.4.php

Plasma 5.18.4

[Jonathan Riddell]

Plasma 5.18.4 is now released
https://www.kde.org/announcements/plasma-5.18.4.php

D28461: In sidebar mode show if a module is in default state or not

[Noah Davis]

ndavis added a comment.


  This is merely an indicator and not a button, right? If so, you should not 
use `edit-reset` since you cannot actually reset the settings there. I'll try 
to come up with another indicator.
  
  I'm concerned that this indicator will make system settings visually messy. 
Is it really needed?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28222: Add ShadowedImage and ShadowedTexture items

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0c7ba88d3970: Add ShadowedImage and ShadowedTexture items 
(authored by ahiemstra).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28222?vs=78294=78987#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28222?vs=78294=78987

REVISION DETAIL
  https://phabricator.kde.org/D28222

AFFECTED FILES
  kirigami.qrc
  src/CMakeLists.txt
  src/controls/ShadowedImage.qml
  src/kirigamiplugin.cpp
  src/scenegraph/header_desktop.glsl
  src/scenegraph/header_desktop_core.glsl
  src/scenegraph/header_es.glsl
  src/scenegraph/shaders.qrc
  src/scenegraph/shaders/header_desktop.glsl
  src/scenegraph/shaders/header_desktop_core.glsl
  src/scenegraph/shaders/header_es.glsl
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shaders/shaders.qrc
  src/scenegraph/shaders/shadowedborderrectangle.frag
  src/scenegraph/shaders/shadowedbordertexture.frag
  src/scenegraph/shaders/shadowedrectangle.frag
  src/scenegraph/shaders/shadowedrectangle.vert
  src/scenegraph/shaders/shadowedtexture.frag
  src/scenegraph/shadowedborderrectangle.frag
  src/scenegraph/shadowedborderrectangle_core.frag
  src/scenegraph/shadowedborderrectanglematerial.cpp
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedbordertexturematerial.h
  src/scenegraph/shadowedrectangle.frag
  src/scenegraph/shadowedrectangle.vert
  src/scenegraph/shadowedrectangle_core.frag
  src/scenegraph/shadowedrectangle_core.vert
  src/scenegraph/shadowedrectanglematerial.cpp
  src/scenegraph/shadowedrectanglenode.cpp
  src/scenegraph/shadowedrectanglenode.h
  src/scenegraph/shadowedtexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.h
  src/scenegraph/shadowedtexturenode.cpp
  src/scenegraph/shadowedtexturenode.h
  src/shadowedrectangle.cpp
  src/shadowedrectangle.h
  src/shadowedtexture.cpp
  src/shadowedtexture.h
  tests/ShadowedImageTest.qml

To: ahiemstra, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 78985.
ahiemstra added a comment.


  - Update zzag's last name

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=78372=78985

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Unit.h
  processcore/formatter.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  In D28208#638846 , @davidre wrote:
  
  > Yes it's not pretty but I had no other Idea. One option would be trying to 
manually search for the icon in the path?
  
  
  Not a good idea, theme path only point to root of more complex structure like 
`hicolor/22x22/apps/...`. This is also code/logic duplication.
  
  > Or if all else fails for now use the old icon property in case 
`IconThemePath` is set.
  
  As a temporary workaround - yes. Final goal is to add custom icon loader 
support to PlasmaCore.IconItem. I checked code, I see great potential for 
additional refactoring there :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre updated this revision to Diff 78982.
davidre added a comment.


  - Revert "Also handle IconThemePath"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28208?vs=78852=78982

BRANCH
  sni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28208

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h
  applets/systemtray/tests/statusnotifier/statusnotifiertest.cpp
  applets/systemtray/tests/statusnotifier/statusnotifiertest.ui
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre added a comment.


  Yes it's not pretty but I had no other Idea. One option would be trying to 
manually search for the icon in the path? Or if all else fails for now use the 
old icon property in case `IconThemePath` is set.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[David Redondo]

davidre added a comment.


  Hi, I made a comparison video performing the same task with oxygen, current 
breeze, this patch with the option enabled and disabled (in order of 
appearance). The task is opening kdevelop, opening the same two files, 
switching between them and then closing the files and the application. As you 
can see the startup time is much worse and even the disabled option seems to 
have some impact.
  F8208176: vokoscreen-2020-03-31_14-07-55.mkv 

  Saying this is the fault of applications is imo unacceptable as it worked 
fine before and in other styles and is caused directly by this. In my mind the 
style should not have such a big impact on performance .

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:492301406a46: [Image Wallpaper] Fix thumbnail generation 
when model is reloaded in-flight (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28420?vs=78846=78980

REVISION DETAIL
  https://phabricator.kde.org/D28420

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h

To: broulik, #plasma, leinir, davidre, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah updated this revision to Diff 78978.
bshah added a comment.


  - proper object instead of QMetaObject invokeMethod

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28455?vs=78968=78978

BRANCH
  bshah/ksld-dbus-notify

REVISION DETAIL
  https://phabricator.kde.org/D28455

AFFECTED FILES
  CMakeLists.txt
  dbus/org.freedesktop.Notifications.xml
  dbus/org.kde.screensaver.Greeter.xml
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/notifications.cpp
  greeter/notifications.h

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28333: Add a new daemon for stats monitoring

[David Edmundson]

davidedmundson updated this revision to Diff 78977.
davidedmundson added a comment.


  Register bus name after loading plugins

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28333?vs=78658=78977

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28333

AFFECTED FILES
  CMakeLists.txt
  kstats/CMakeLists.txt
  kstats/autotests/CMakeLists.txt
  kstats/autotests/main.cpp
  kstats/client.cpp
  kstats/client.h
  kstats/ksysguard_iface.xml
  kstats/ksysguarddaemon.cpp
  kstats/ksysguarddaemon.h
  kstats/main.cpp
  kstats/test/CMakeLists.txt
  kstats/test/README.txt
  kstats/test/main.cpp
  libkstats/AggregateSensor.cpp
  libkstats/AggregateSensor.h
  libkstats/CMakeLists.txt
  libkstats/SensorContainer.cpp
  libkstats/SensorContainer.h
  libkstats/SensorObject.cpp
  libkstats/SensorObject.h
  libkstats/SensorPlugin.cpp
  libkstats/SensorPlugin.h
  libkstats/SensorProperty.cpp
  libkstats/SensorProperty.h
  libkstats/types.h
  plugins/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/ksgrd/ksgrd.json
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/ksgrd/ksgrdiface.h
  plugins/global/nvidia/CMakeLists.txt
  plugins/global/nvidia/nvidia.cpp
  plugins/global/nvidia/nvidia.h
  plugins/global/nvidia/nvidiaplugin.json

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638514 , @ngraham wrote:
  
  > Same error about not being able to find the module. Sorry for not being 
clear.
  
  
  Does the specified path contain (`/home/nate/kde/usr/lib64/gtk-3.0/`) 
`modules` directory with the `libcolorreload-gtk-module.so` file?
  If there it is, try launching GTK app with:
  
gtk-app --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
  
  The parameter must be **absolute** path.
  
  In D28072#638515 , @cblack wrote:
  
  > You can provide a full path to the library instead of letting GTK do name 
to library resolution.
  
  
  Yes, you can, but that's inconvenient. According to this 
 you can specify 
`GTK_PATH` environment variable, so that GTK knows where to search for modules. 
It works for me at least.
  
  I also noticed a **dynamic** recoloration bug: it doesn't work if the app is 
launched with the color scheme, that it was using in the previous launch. To 
make it work I have to change color scheme and relaunch the app. The app 
therefore changes its color scheme to a new one and it is now reacting to color 
scheme change properly (i.e. changes it without restart).

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28458: Bugfix ConverterRunner

[Alexander Lohnau]

alex added a comment.


  I don't know why but I cant land this patch(`arc land --preview` looks fine) 
and the previous commits worked:
  `fatal: remote error: service not enabled: /kdeplasma-addons`
  
  I would be thankful if you could commit this.

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Kai Uwe Broulik]

broulik added a comment.


  You reckon we should do a simple base class that just does 
`settings->isDefaults()` since that will be quite a common thing?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28462

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Kai Uwe Broulik]

broulik added a comment.


  Please include screenshots when you do UI changes.

INLINE COMMENTS

> CategoriesPage.qml:207
> +
> +width: 16
> +height: 16

`Kirigami.Units.iconSizes.small` and elsewhere

Why do you need this wrapper `Item`, though?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28462: [KCM] Add color state probe to allow system settings to display current default state

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, meven, crossi, hchain.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28462

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colorsstateprobe.cpp
  kcms/colors/colorsstateprobe.h

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, meven, crossi, hchain.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

AFFECTED FILES
  core/MenuItem.cpp
  core/MenuItem.h
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah planned changes to this revision.
bshah added a comment.


  I need to add methods for the communicating the actions back to notification 
server.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28455

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28428: [screenlocker] listen to notifications from the notification server

[Bhushan Shah]

bshah abandoned this revision.
bshah added a comment.


  Closed in favor of the more simpler version.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28428

To: bshah, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> davidedmundson wrote in greeterapp.cpp:497
> This pattern of fetching and poking the root object of a scene isn't one I 
> like, it's better to expose an object to the view that then has normal 
> signals and slots - but this does follow the convention already here, so I 
> can't really object.

Let's add a todo for future? Once this is done, I do have plan to change the 
OSD bit to also use greeter directly, instead of wayland protocol bit. That 
time I can update that.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28455

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah updated this revision to Diff 78968.
bshah added a comment.


  - fixup comments mentioned by David

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28455?vs=78952=78968

BRANCH
  bshah/ksld-dbus-notify

REVISION DETAIL
  https://phabricator.kde.org/D28455

AFFECTED FILES
  CMakeLists.txt
  dbus/org.kde.screensaver.Greeter.xml
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28427: [libnotificationmanager] forward notifications to lockscreen

[Bhushan Shah]

bshah added a subscriber: broulik.
bshah added a comment.


  > +1 to using global and per-notification blacklists rather than a 
per-notification whitelist
  
  Plan is to change this in future, but for now to keep code simple I and 
@broulik agreed on this solution.
  
  (Also I am closing this diff in favor of the  D28454 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28427

To: bshah
Cc: broulik, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> davidedmundson wrote in server_p.cpp:234
> "This" will lack any context when someone is actually debugging this.

"This" debug statement should be removed :P

> davidedmundson wrote in server_p.cpp:245
> I assume you forgot to have an
> 
> iface.Close(...)
> 
> line somewhere here

Yes, I haven't got full functionality working yet, this was more of RFC.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28454

To: bshah, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

[Bhushan Shah]

bshah updated this revision to Diff 78961.
bshah marked 2 inline comments as done.
bshah added a comment.


  - fix comments by David

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28454?vs=78951=78961

BRANCH
  bshah/greeter-notify

REVISION DETAIL
  https://phabricator.kde.org/D28454

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/server_p.cpp

To: bshah, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

[Eugene Popov]

epopov added a comment.


  I have no idea how to test code from **master** branch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Seems pretty simple and sensible.
  
  1 minor fixup needed.

INLINE COMMENTS

> server_p.cpp:234
> +hints, notification.timeout());
> +qCDebug(NOTIFICATIONMANAGER) << "This notification should be shown 
> on lockscreen";
> +}

"This" will lack any context when someone is actually debugging this.

> server_p.cpp:245
> +// just ignore it.
> +OrgKdeScreensaverGreeterInterface 
> iface(QStringLiteral("org.kde.screensaver.Greeter"),
> +QStringLiteral("/Greeter"), 
> QDBusConnection::sessionBus());

I assume you forgot to have an

iface.Close(...)

line somewhere here

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28454

To: bshah, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[David Edmundson]

davidedmundson added a comment.


  > @davidedmundson - is QIcon(QImage(...)) save?
  
  For the way it's used in the runner, yes.
  
  > Before this patch the icon was created in the BookmarkMatch::asQueryMatch 
method which was called from the secondary thread.
  
  Then my comment is happily refuted. I read the title and wanted to provide 
context for why it might have been like that making an assumption.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28455: add dbus interface to the greeter

[David Edmundson]

davidedmundson added a comment.


  I'd say we go for the simplest solution +++
  
  Given we have MPRIS on here, if we were to do any DBus lockdowns we would 
almost certainly want to use xdg-dbus-proxy, at which point this would continue 
to work.

INLINE COMMENTS

> greeterapp.cpp:139
> +(void) new GreeterAdapter(this);
> +
> QDBusConnection::sessionBus().registerService(QStringLiteral("org.kde.screensaver.Greeter"));
> +QDBusConnection::sessionBus().registerObject(QStringLiteral("/Greeter"), 
> this);

Register objects before registering a service.

DBus receiving is in another thread so you could hypothetically get a message 
between the two events.

Doesn't really matter if we lose a notification in this case, but it's a good 
practice

> greeterapp.cpp:497
> +// we invoke the notify method of the greeter root object
> +QMetaObject::invokeMethod(rootObject, "Notify", Qt::QueuedConnection,
> +  Q_ARG(uint, id),

This pattern of fetching and poking the root object of a scene isn't one I 
like, it's better to expose an object to the view that then has normal signals 
and slots - but this does follow the convention already here, so I can't really 
object.

> greeterapp.h:51
>  Q_OBJECT
> +Q_CLASSINFO("D-Bus Interface", "org.kde.screensaver.GreeterApp")
>  public:

You don't need this if you're using an adaptor

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28455

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28458: Bugfix ConverterRunner

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28458: Bugfix ConverterRunner

[Alexander Lohnau]

alex created this revision.
alex added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Skip empty parts when splitting the units(D27166: Refactor converter runner 
).
  PS: I had to set the locale to german to reproduce this issue,
  thats why I didn't noticed it in the first place.

TEST PLAN
  Does not display results for queries like 1/2

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi 
  I don't think it is very satisfactory to say that the perforrmance hit it is 
"the apps fault" ... It is not there without the change, and with other widgets 
styles (or is it ? Did any one check, e.g. oxygen which is quite resource heavy 
because of gradients and so ?)
  You can't expect applcations dev to go optimize their app for the need of a 
given style. especially if it is not trivial. 
  I don't see another choice, if such popular apps as kate and kdevelop are 
affected, than to go do the optimization 'ourself', if indeed this is the issue.
  At the minimum someone should try to profile this, using e.g. callgrind, to 
see where the curlprit is ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26934: KCM/Autostart Add a model to separate logic from UI

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in autostartmodel.h:52
> Why define `DisplayRole` as dedicated enum entry, rather than just using 
> `Qt::DisplayRole` in the code everywhere

I see, I meant my code to have all Roles used explicitly declared here rather 
than relying on the developer knowing about Qt::DisplayRole.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Kai Uwe Broulik]

broulik added a comment.


  I'm seeing another issue: everything with a slash is now interpreted as unit 
of volume, even just calculations:
  F8207700: Screenshot_20200331_091752.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27166

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28435: [System Tray] Update effective status on model insertion

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1d3b6e8f0a18: [System Tray] Update effective status on 
model insertion (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28435?vs=78895=78953

REVISION DETAIL
  https://phabricator.kde.org/D28435

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: broulik, #plasma, kmaterka, davidre, ahmadsamir, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  Currently this dbus interface allows the notification server to pass the
  notifications, which then are forwarded to greeter theme by calling the
  Notify method on the root object.
  
  This is alternative to D28428 

TEST PLAN
  tested using mobile greeter

REPOSITORY
  R133 KScreenLocker

BRANCH
  bshah/ksld-dbus-notify

REVISION DETAIL
  https://phabricator.kde.org/D28455

AFFECTED FILES
  CMakeLists.txt
  dbus/org.kde.screensaver.Greeter.xml
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart