KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/18/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 04:22:07 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 312 lines...][2020-04-13T04:46:27.748Z] [2020-04-13T04:46:27.748Z]  * Screencast portal, Support for screen sharing[2020-04-13T04:46:27.748Z] [2020-04-13T04:46:27.748Z] -- The following OPTIONAL packages have not been found:[2020-04-13T04:46:27.748Z] [2020-04-13T04:46:27.748Z]  * PipeWire, PipeWire - multimedia processing, [2020-04-13T04:46:27.748Z]Required for screencast portal[2020-04-13T04:46:27.748Z] [2020-04-13T04:46:27.748Z] -- Configuring done[2020-04-13T04:46:27.748Z] -- Generating done[2020-04-13T04:46:28.011Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-04-13T04:46:28.937Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project xdg-desktop-portal-kde --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-04-13T04:46:29.202Z] Scanning dependencies of target xdg-desktop-portal-kde_autogen[2020-04-13T04:46:29.202Z] [  3%] Automatic MOC for target xdg-desktop-portal-kde[2020-04-13T04:46:31.881Z] [  3%] Built target xdg-desktop-portal-kde_autogen[2020-04-13T04:46:31.881Z] [  6%] Generating user_interface.cpp, user_interface.h[2020-04-13T04:46:31.881Z] [ 10%] Generating ui_accessdialog.h[2020-04-13T04:46:31.881Z] [ 13%] Generating ui_appchooserdialog.h[2020-04-13T04:46:31.881Z] [ 16%] Generating ui_screenshotdialog.h[2020-04-13T04:46:31.881Z] [ 20%] Generating ui_userinfodialog.h[2020-04-13T04:46:31.881Z] [ 23%] Generating user_interface.moc[2020-04-13T04:46:32.479Z] Scanning dependencies of target xdg-desktop-portal-kde[2020-04-13T04:46:32.479Z] [ 26%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/xdg-desktop-portal-kde_autogen/mocs_compilation.cpp.o[2020-04-13T04:46:32.479Z] [ 30%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/xdg-desktop-portal-kde.cpp.o[2020-04-13T04:46:32.479Z] [ 33%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/access.cpp.o[2020-04-13T04:46:32.479Z] [ 36%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/accessdialog.cpp.o[2020-04-13T04:46:32.479Z] [ 40%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/account.cpp.o[2020-04-13T04:46:32.479Z] [ 43%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/appchooser.cpp.o[2020-04-13T04:46:32.479Z] [ 46%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/appchooserdialog.cpp.o[2020-04-13T04:46:32.479Z] [ 50%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/desktopportal.cpp.o[2020-04-13T04:46:32.479Z] [ 53%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/background.cpp.o[2020-04-13T04:46:32.479Z] [ 56%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/email.cpp.o[2020-04-13T04:46:32.479Z] [ 60%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/inhibit.cpp.o[2020-04-13T04:46:32.479Z] [ 63%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/filechooser.cpp.o[2020-04-13T04:46:35.126Z] [ 66%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/notification.cpp.o[2020-04-13T04:46:35.126Z] /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/src/access.cpp:45:40: warning: unused parameter 'results' [-Wunused-parameter][2020-04-13T04:46:35.126Z]   QVariantMap )[2020-04-13T04:46:35.126Z]^[2020-04-13T04:46:35.715Z] [ 70%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/print.cpp.o[2020-04-13T04:46:35.715Z] 1 warning generated.[2020-04-13T04:46:35.715Z] [ 73%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/request.cpp.o[2020-04-13T04:46:36.000Z] [ 76%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/session.cpp.o[2020-04-13T04:46:36.000Z] [ 80%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/screenshot.cpp.o[2020-04-13T04:46:36.000Z] [ 83%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/screenshotdialog.cpp.o[2020-04-13T04:46:36.302Z] [ 86%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/settings.cpp.o[2020-04-13T04:46:36.302Z] [ 90%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/utils.cpp.o[2020-04-13T04:46:36.302Z] [ 93%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/userinfodialog.cpp.o[2020-04-13T04:46:36.605Z] [ 96%] Building CXX object src/CMakeFiles/xdg-desktop-portal-kde.dir/user_interface.cpp.o[2020-04-13T04:46:38.747Z] /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/src/print.cpp:256:32: 

KDE CI: Plasma » bluedevil » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/6/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 13 Apr 2020 04:20:27 +
 Build duration:
25 min and counting
   CONSOLE OUTPUT
  [...truncated 159 lines...][2020-04-13T04:45:23.594Z] Retrieving: Plasma-kplotting-kf5-qt5[2020-04-13T04:45:23.594Z] Retrieving: Plasma-krunner-kf5-qt5[2020-04-13T04:45:23.594Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2020-04-13T04:45:23.594Z] Retrieving: Plasma-prison-kf5-qt5[2020-04-13T04:45:23.594Z] Retrieving: Plasma-purpose-kf5-qt5[2020-04-13T04:45:23.594Z] Retrieving: Plasma-qqc2-desktop-style-kf5-qt5[2020-04-13T04:45:23.594Z] Retrieving: Plasma-syndication-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[2020-04-13T04:45:35.112Z] + python3 -u ci-tooling/helpers/configure-build.py --product Plasma --project bluedevil --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --installTo /home/jenkins/install-prefix/[2020-04-13T04:45:35.112Z] == Using the following environment to perform the build:[2020-04-13T04:45:35.112Z] JOB_NAME  = 'Plasma/bluedevil/kf5-qt5 FreeBSDQt5.14'[2020-04-13T04:45:35.112Z] BUILD_NUMBER  = '6'[2020-04-13T04:45:35.112Z] LOGNAME   = 'jenkins'[2020-04-13T04:45:35.112Z] PAGER = 'more'[2020-04-13T04:45:35.112Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2020-04-13T04:45:35.112Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/display/redirect'[2020-04-13T04:45:35.112Z] MAIL  = '/var/mail/jenkins'[2020-04-13T04:45:35.112Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/6/display/redirect?page=changes'[2020-04-13T04:45:35.112Z] JENKINS_URL   = 'https://build.kde.org/'[2020-04-13T04:45:35.112Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-04-13T04:45:35.112Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.14'[2020-04-13T04:45:35.112Z] EDITOR= 'vi'[2020-04-13T04:45:35.112Z] ENV   = '/home/jenkins/.shrc'[2020-04-13T04:45:35.112Z] HUDSON_HOME   = '/home/production/data'[2020-04-13T04:45:35.112Z] BUILD_ID  = '6'[2020-04-13T04:45:35.112Z] OLDPWD= '/usr/home/jenkins'[2020-04-13T04:45:35.112Z] PWD   = '/usr/home/jenkins/workspace/Plasma/bluedevil/kf5-qt5 FreeBSDQt5.14'[2020-04-13T04:45:35.112Z] _ = '/usr/local/bin/java'[2020-04-13T04:45:35.112Z] TERM  = 'su'[2020-04-13T04:45:35.112Z] NODE_LABELS   = 'FreeBSD Builder Iota FreeBSDQt5.14'[2020-04-13T04:45:35.112Z] BUILD_TAG = 'jenkins-Plasma-bluedevil-kf5-qt5 FreeBSDQt5.14-6'[2020-04-13T04:45:35.112Z] BUILD_DISPLAY_NAME= '#6'[2020-04-13T04:45:35.112Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/6/display/redirect'[2020-04-13T04:45:35.112Z] USER  = 'jenkins'[2020-04-13T04:45:35.112Z] HOME  = '/home/jenkins'[2020-04-13T04:45:35.112Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/6/'[2020-04-13T04:45:35.112Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/bluedevil/job/kf5-qt5%20FreeBSDQt5.14/'[2020-04-13T04:45:35.112Z] HUDSON_URL= 'https://build.kde.org/'[2020-04-13T04:45:35.112Z] SHELL = '/bin/sh'[2020-04-13T04:45:35.112Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/bluedevil/kf5-qt5 FreeBSDQt5.14'[2020-04-13T04:45:35.112Z] STAGE_NAME= 'Configuring Build'[2020-04-13T04:45:35.112Z] NODE_NAME = 'FreeBSD Builder Iota'[2020-04-13T04:45:35.112Z] BLOCKSIZE = 'K'[2020-04-13T04:45:35.112Z] EXECUTOR_NUMBER   = '0'[2020-04-13T04:45:35.112Z] SHLVL = '0'[2020-04-13T04:45:35.112Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-04-13T04:45:35.112Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-04-13T04:45:35.112Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-04-13T04:45:35.112Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-04-13T04:45:35.112Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-04-13T04:45:35.112Z] XDG_DATA_DIRS = 

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 79981.
ngraham added a comment.


  Use new `showDefaultActionButtonWhenBusy` option to allow disconnecting while 
a connection attempt is in progress

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28034?vs=79522=79981

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28034

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: ngraham, #vdg, #plasma, jgrulich
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  Fix binding loops: D28787 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28034

To: ngraham, #vdg, #plasma, jgrulich
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28037: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R97:be8c0f186a06: [Applet] Port to ExpandableListItem 
(authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28037?vs=79978=79979

REVISION DETAIL
  https://phabricator.kde.org/D28037

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28037: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 79978.
ngraham added a comment.


  Update required Frameworks version

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28037?vs=79364=79978

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28037

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28035: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:b480831d5cf5: [Applet] Port to ExpandableListItem 
(authored by ngraham).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28035?vs=79437=79976

REVISION DETAIL
  https://phabricator.kde.org/D28035

AFFECTED FILES
  CMakeLists.txt
  plasma/package/contents/ui/ActionItem.qml
  plasma/package/contents/ui/VaultItem.qml
  plasma/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ivan
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: Adaptive panel opacity

[Nathaniel Graham]

ngraham added a comment.


  +1 for making this a user-controllable setting, but how does it interact with 
plasma themes where there isn't any transparency? Can we only show this UI for 
plasma themes with transparency?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28786: Add opacityMode

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

TEST PLAN
  D28627 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/opacity-mode-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28786

AFFECTED FILES
  shell/panelconfigview.cpp
  shell/panelconfigview.h
  shell/panelview.cpp
  shell/panelview.h

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

[Carson Black]

cblack updated this revision to Diff 79973.
cblack added a comment.


  Add configuration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28627?vs=79972=79973

BRANCH
  arcpatch-D28627

REVISION DETAIL
  https://phabricator.kde.org/D28627

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/views/Panel.qml

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

[Carson Black]

cblack updated this revision to Diff 79972.
cblack added a comment.


  Filter by screen

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28627?vs=79970=79972

BRANCH
  arcpatch-D28627

REVISION DETAIL
  https://phabricator.kde.org/D28627

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28785: Don't request blur when panel is opaque

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

TEST PLAN
  Probe panel windows with xprop or edit D28627 
 to make the panel translucent when it 
should be opaque

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/opaque-blur (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28785

AFFECTED FILES
  shell/panelview.cpp

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

[Carson Black]

cblack updated this revision to Diff 79970.
cblack added a comment.


  Fix errors

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28627?vs=79969=79970

BRANCH
  arcpatch-D28627

REVISION DETAIL
  https://phabricator.kde.org/D28627

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

[Carson Black]

cblack updated this revision to Diff 79969.
cblack added a comment.


  Refactor to state/transitions and don't render two FrameSvgItems at once

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28627?vs=79968=79969

BRANCH
  arcpatch-D28627

REVISION DETAIL
  https://phabricator.kde.org/D28627

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol added a subscriber: davidedmundson.
apol added a comment.


  This looks like a regression from e2d372d3dfd14ea3210a9e1f5755883bd2578c18 
, so 
I'll wait for @davidedmundson's comment.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28783

To: apol, #plasma, cblack
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

[Carson Black]

cblack updated this revision to Diff 79968.
cblack added a comment.


  Use D28784 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28627?vs=79494=79968

BRANCH
  arcpatch-D28627

REVISION DETAIL
  https://phabricator.kde.org/D28627

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

To: cblack, #plasma, davidedmundson, niccolove
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28784: [libtm] Add filterNotMaximized property

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  There is a `filterNotMaximized` property that filters out windows that are 
not maximized.
  Self explanatory.

TEST PLAN
  D28627 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/libtm-filter-maximised (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28784

AFFECTED FILES
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Tell the parent Dialog class what the location is so it can configure
  the dialog accordingly.
  
  Install the desktop file where it can be found by kwin to know about
  X-KDE-Wayland-Interfaces=org_kde_plasma_window_management.
  
  While at it, make sure we don't leak if we return early.

TEST PLAN
  Now I get the right animation

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: WIP: Made panel opaque on maximized window

[Niccolò Venerandi]

niccolove added a comment.


  I have a question though: we ship the pager widget in the panel that does the 
same by default. Wouldn't that have the same efficiency impact, if not even 
more?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: niccolove, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Arfrever Frehtes Taifersar Arahesis]

arfrever added inline comments.

INLINE COMMENTS

> CMakeLists.txt:23
>  
> -find_package(PipeWire)
> -set_package_properties(PipeWire PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(GBM)
> -set_package_properties(GBM PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(Epoxy)
> -set_package_properties(Epoxy PROPERTIES DESCRIPTION "libepoxy"
> -URL "https://github.com/anholt/libepoxy;
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -if (PipeWire_FOUND AND GBM_FOUND AND Epoxy_FOUND)
> -set (SCREENCAST_ENABLED true)
> +option(DISABLE_PIPEWIRE_SUPPORT "Disable PipeWire support. PipeWire is 
> needed for screen sharing and remote desktop" OFF)
> +if(DISABLE_PIPEWIRE_SUPPORT)

Could this option be renamed to positively sounding option enabled by default? 
(And word `SUPPORT` seems redundant.)

  option(ENABLE_PIPEWIRE "Enable PipeWire support. PipeWire is needed for 
screen sharing and remote desktop" ON)

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  pipewire-required

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma, apol
Cc: arfrever, apol, asturmlechner, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

Re: Update on Status of Gitlab Migration

[Johan Ouwerkerk]

On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk  wrote:
>
> >
> > We may need to do on-the-fly conversion of the kde: repo paths if they
> > won't be expressible as 'kde:foo' in the future, but we should have the
> > information needed to do this in kdesrc-build to make this happen
> > on-the-fly.
> >
>
> Yes, this should be fairly straight forward: we could do a `git remote
> set-url` based on what the repo metadata tells us before updating a
> local clone. In fact: we could build this right now and sell it as
> "automagically recover your upstream".  :)
>
> I might try to hack something up tomorrow or monday for that.
>

A basic version of this is now available via:
https://invent.kde.org/kde/kdesrc-build/-/merge_requests/27
With this feature sysadmin should now be free to change the repopath
value in the metadata YAML and kdesrc-build will reconfigure the
remote URL appropriately automatically. This works as long as the same
`kde:$path` expression works for both fetch and push, i.e. the layout
on the anongit.kde.org network must match with the layout of
git.kde.org/invent.kde.org. If necessary a simple path prefix change
could still work with a minor update to the pushInsteadOf mapping,
e.g. when repos on invent are mapped to kde/   instead of
/.

You can also experiment with setting invent.kde.org as the push URL by
setting x-invent-kde-push-urls to true in your rc file. The effect
should be visible through git remote -vv afterwards. (Disable the
setting and re-run again afterwards because this will obviously break
your push URLs as long as the Gitlab migration hasn't completed yet).

Regards,

- Johan

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  CMake bits look good.
  
  It's a bit of a shame that this whole complexity needs to be added, but oh 
well.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  pipewire-required

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma, apol
Cc: apol, asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Carson Black]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e680ff581a13: [applets/mediacontroller] Visually refresh 
media controller plasmoid (authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=79962=79963

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin, ngraham, broulik
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 79962.
cblack added 1 blocking reviewer(s): broulik.
cblack added a comment.
This revision now requires review to proceed.


  Trim whitespace

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=79961=79962

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin, ngraham, broulik
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 79961.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=79960=79961

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin, ngraham, broulik
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 79960.
cblack added a comment.


  Smaller fallback icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=79944=79960

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin, ngraham, broulik
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove added a comment.


  In D28467#646626 , @ngraham wrote:
  
  > Does `activeApplet.fullRepresentationItem` actually have a `header` 
property?
  
  
  Yes. I tried to console log it (...header) and it returns Toolbar qml 
element, which is correct, and the element supposed to have the visible 
property.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28710: Make accidental panel and panel widget deletion more difficult

[Nathaniel Graham]

ngraham updated this revision to Diff 79952.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28710?vs=79950=79952

BRANCH
  make-accidental-panel-and-panel-widget-deletion-harder (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28710

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
  kcms/autostart/autostart.cpp

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28710: Make accidental panel and panel widget deletion more difficult

[Nathaniel Graham]

ngraham updated this revision to Diff 79953.
ngraham added a comment.


  Correct the patch base (stupid arc)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28710?vs=79952=79953

BRANCH
  make-accidental-panel-and-panel-widget-deletion-harder (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28710

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28710: Make accidental panel and panel widget deletion more difficult

[Nathaniel Graham]

ngraham updated this revision to Diff 79950.
ngraham added a comment.


  - Also reposition the Remove Panel button pased on panel orientation
  - Ditch the overcomplicated loaders and components

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28710?vs=79739=79950

BRANCH
  make-accidental-panel-and-panel-widget-deletion-harder (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28710

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, #vdg, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Jan Grulich]

jgrulich marked 2 inline comments as done.
jgrulich added inline comments.

INLINE COMMENTS

> asturmlechner wrote in CMakeLists.txt:23-24
> maybe make it a proper cmake option?

I made it a cmake option. I have never used it before so please check if it's 
correct.

> asturmlechner wrote in CMakeLists.txt:51-52
> This is odd, is it a leftover or did you forget to add an actual KF5 
> dependency here?

It was a leftover, removed now.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Jan Grulich]

jgrulich updated this revision to Diff 79948.
jgrulich added a comment.


  Make DISABLE_PIPEWIRE_SUPPORT a cmake option and remove a leftover from 
previous change

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28677?vs=79684=79948

BRANCH
  pipewire-required

REVISION DETAIL
  https://phabricator.kde.org/D28677

AFFECTED FILES
  CMakeLists.txt
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: jgrulich, #plasma
Cc: asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham added a comment.


  Does `activeApplet.fullRepresentationItem` actually have a `header` property?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 79944.
cblack added a comment.


  Wrap progressbar to prevent height filling

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=79886=79944

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin, ngraham, broulik
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 79940.
davidre added a comment.


  Actually show the dialog

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=79938=79940

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 79938.
davidre added a comment.


  Do not use dialog.exec()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=79907=79938

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Noah Davis]

ndavis added a comment.


  You need to fix the git author info. If you upload a patch via the web UI 
instead of `arc`, the author info gets messed up.
  
  It's still working for me. I also still need to restart apps for changes to 
the global animation settings to apply.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

[Andreas Sturmlechner]

asturmlechner added a comment.


  Thanks for keeping pipewire optional, this is in line with how we have been 
packaging xdg-desktop-portal-kde in Gentoo so far, we had just been 
conditionally disabling the cmake finding of these 3 libraries to do it, and 
will switch over to using the new option then.

INLINE COMMENTS

> CMakeLists.txt:23-24
>  
> -find_package(PipeWire)
> -set_package_properties(PipeWire PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(GBM)
> -set_package_properties(GBM PROPERTIES
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -find_package(Epoxy)
> -set_package_properties(Epoxy PROPERTIES DESCRIPTION "libepoxy"
> -URL "https://github.com/anholt/libepoxy;
> -TYPE OPTIONAL
> -PURPOSE "Required for screencast portal"
> -)
> -
> -if (PipeWire_FOUND AND GBM_FOUND AND Epoxy_FOUND)
> -set (SCREENCAST_ENABLED true)
> +if(DISABLE_PIPEWIRE_SUPPORT)
> +message(STATUS "Disabling PipeWire support")
> +set(HAVE_PIPEWIRE_SUPPORT 0)

maybe make it a proper cmake option?

> CMakeLists.txt:51-52
> +
> +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED
> +)
>  endif()

This is odd, is it a leftover or did you forget to add an actual KF5 dependency 
here?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28677

To: jgrulich, #plasma
Cc: asturmlechner, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

[Luca Weiss]

z3ntu planned changes to this revision.
z3ntu added inline comments.

INLINE COMMENTS

> nicolasfella wrote in config.cpp:99
> That sounds like a job for std::all_of

I wasn't aware that C++ had such fancy methods :) I'm using equivalent 
functions a lot in Kotlin but they are honestly much nicer to use in Kotlin 
than in C++.

In this case instead of the "continue" keyword I would have to return true then 
I guess.

> romangg wrote in config.cpp:104
> Should we check if all or only one panel display are set to auto rotate. 
> Granted I'm not aware of a device with multiple panel displays which runs 
> KScreen but maybe you had a reason for using && here?
> 
> Just want to hear a rational if you had one. If you didn't and just picked && 
> by random it's also fine.

I thought it makes more sense to say "auto rotate is enabled when all panels 
have auto rotate enabled" rather than "auto rotate is enabled when at least one 
panel has auto rotate enabled" which is why I've chosen to do it this way.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28773

To: z3ntu, #plasma, bshah
Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

[Roman Gilg]

romangg added a comment.


  I'm not sure about the renaming. the lock... implies that the rotation stays 
the way it is at the moment (what it does). But I'm fine either way.
  
  These are normally two separate commits, one refactor and one feature 
addition. But since it's only a small change and Phabricator sucks let's not 
bitch too much about it.
  
  @bshah: ok with the change?

INLINE COMMENTS

> config.cpp:104
> +}
> +ret &= m_control->getAutoRotate(output);
> +}

Should we check if all or only one panel display are set to auto rotate. 
Granted I'm not aware of a device with multiple panel displays which runs 
KScreen but maybe you had a reason for using && here?

Just want to hear a rational if you had one. If you didn't and just picked && 
by random it's also fine.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28773

To: z3ntu, #plasma, bshah
Cc: romangg, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> config.cpp:99
> +{
> +bool ret = true;
> +for (KScreen::OutputPtr  : m_data->outputs()) {

That sounds like a job for std::all_of

> config.h:50
>  void setDeviceOrientation(QOrientationReading::Orientation orientation);
> +bool getAutoRotate();
>  void setAutoRotate(bool value);

const

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28773

To: z3ntu, #plasma, bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

[Luca Weiss]

z3ntu created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
z3ntu requested review of this revision.

REVISION SUMMARY
  lockAutoRotate(true) would enable the automatic rotation and
  lockAutoRotate(false) would disable auto rotation which is the opposite
  of what the function name would imply, so rename it to setAutoRotate.
  
  We also need a getter for the value to display the status in the UI.
  This getter checks if all applicable outputs have auto rotate enabled
  and returns that value.

TEST PLAN
  tested on Plasma Mobile

REPOSITORY
  R104 KScreen

BRANCH
  autorotate

REVISION DETAIL
  https://phabricator.kde.org/D28773

AFFECTED FILES
  kded/config.cpp
  kded/config.h
  kded/daemon.cpp
  kded/daemon.h
  kded/org.kde.KScreen.xml

To: z3ntu
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Martin Tobias Holmedahl Sandsmark]

sandsmark updated this revision to Diff 79916.
sandsmark added a comment.


  Now should reload the animation settings when changed anywhere.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28651?vs=79914=79916

REVISION DETAIL
  https://phabricator.kde.org/D28651

AFFECTED FILES
  kdecoration/config/breezeconfigwidget.cpp
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h

To: sandsmark, #breeze
Cc: ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  In D28651#643681 , @ndavis wrote:
  
  > I don't know enough about KDE configuration management to judge the code, 
but with this patch, changing animation speeds in SySe works if I restart apps 
after the change.
  
  
  The breeze plugin needs to do something like this: 
https://cgit.kde.org/plasma-integration.git/tree/src/platformtheme/khintssettings.cpp#n234
 (and now I see that the slot there is missing some stuff, I'll see if I can 
fix that later).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28651

To: sandsmark, #breeze
Cc: ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28651: Load and use global animation settings

[Martin Tobias Holmedahl Sandsmark]

sandsmark updated this revision to Diff 79914.
sandsmark added a comment.


  Also made it store to the global configuration. This way it is backwards 
compatible, but the config can also be changed from both places.
  
  I think it makes sense to have it both places, having it in the breeze 
settings avoids people having to go back and forth to tune their settings.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28651?vs=79566=79914

REVISION DETAIL
  https://phabricator.kde.org/D28651

AFFECTED FILES
  kdecoration/config/breezeconfigwidget.cpp
  kstyle/breezestyle.cpp

To: sandsmark, #breeze
Cc: ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 79907.
davidre added a comment.


  forgot to implement defaults()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=79831=79907

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Update on Status of Gitlab Migration

[Johan Ouwerkerk]

On Sun, Apr 12, 2020 at 1:06 AM Ben Cooksley  wrote:
>
> On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk  
> wrote:
> >
> > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk  
> > wrote:
> > >
> > > Yes the only reason why a cleanup script might be needed is if the
> > > logical path used to express the repo in dependency information
> > > changes at the same time. E.g. suppose a `frameworks/kf5foo` gets
> > > remapped to `frameworks/kf5/foo` or something like that. In that case
> > > unless you use the flat repository layout, kdesrc-build would try to
> > > clone a new `frameworks/kf5/foo` repo, leaving your old
> > > `frameworks/kf5foo` to consume some wasted disk space.
> > >
> >
> > This is obviously a poor example, but the same problem occurs if
> > something moves from playground to extragear. Basically if the
> > `projectpath` YAML key changes.
>
> I had been considering adding the Gitlab Project ID number to the YAML
> metadata files as a way of allowing us to track projects through their
> whole lifetime.
>

That would be very nice, because then `kdesrc-build` could implement
an `arc patch` type feature in a more straightforward fashion. So
people could type things like `kdesrc-build juk!55` as a shorthand for
checkout remote HEAD of whatever branch MR 55 is for `juk`.

Regards,

- Johan