KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 23 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/23/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 17 Apr 2020 04:18:52 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 342 lines...][2020-04-17T04:19:50.607Z]   problems in calling code that expects `find_package` result variables[2020-04-17T04:19:50.607Z]   (e.g., `_FOUND`) to follow a certain pattern.[2020-04-17T04:19:50.607Z] Call Stack (most recent call first):[2020-04-17T04:19:50.607Z]   /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:78 (find_package_handle_standard_args)[2020-04-17T04:19:50.607Z]   CMakeLists.txt:62 (find_package)[2020-04-17T04:19:50.607Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-04-17T04:19:50.607Z] [2020-04-17T04:19:50.607Z] -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.70.0") [2020-04-17T04:19:50.607Z] CMake Warning (dev) at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272 (message):[2020-04-17T04:19:50.607Z]   The package name passed to `find_package_handle_standard_args`[2020-04-17T04:19:50.607Z]   (KF5WidgetsAddons) does not match the name of the calling package (KF5).[2020-04-17T04:19:50.607Z]   This can lead to problems in calling code that expects `find_package`[2020-04-17T04:19:50.607Z]   result variables (e.g., `_FOUND`) to follow a certain pattern.[2020-04-17T04:19:50.607Z] Call Stack (most recent call first):[2020-04-17T04:19:50.607Z]   /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:78 (find_package_handle_standard_args)[2020-04-17T04:19:50.607Z]   CMakeLists.txt:62 (find_package)[2020-04-17T04:19:50.607Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-04-17T04:19:50.607Z] [2020-04-17T04:19:50.607Z] -- Found KF5WidgetsAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.70.0") [2020-04-17T04:19:50.607Z] CMake Warning (dev) at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:272 (message):[2020-04-17T04:19:50.607Z]   The package name passed to `find_package_handle_standard_args`[2020-04-17T04:19:50.607Z]   (KF5WindowSystem) does not match the name of the calling package (KF5).[2020-04-17T04:19:50.607Z]   This can lead to problems in calling code that expects `find_package`[2020-04-17T04:19:50.607Z]   result variables (e.g., `_FOUND`) to follow a certain pattern.[2020-04-17T04:19:50.607Z] Call Stack (most recent call first):[2020-04-17T04:19:50.607Z]   /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:78 (find_package_handle_standard_args)[2020-04-17T04:19:50.607Z]   CMakeLists.txt:62 (find_package)[2020-04-17T04:19:50.607Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-04-17T04:19:50.607Z] [2020-04-17T04:19:50.607Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.70.0") [2020-04-17T04:19:50.607Z] -- Found KF5: success (found suitable version "5.70.0", minimum required is "5.66.0") found components: CoreAddons Config I18n Declarative KIO Kirigami2 Notifications Plasma Wayland WidgetsAddons WindowSystem [2020-04-17T04:19:50.867Z] -- The following OPTIONAL packages have been found:[2020-04-17T04:19:50.867Z] [2020-04-17T04:19:50.867Z]  * PkgConfig[2020-04-17T04:19:50.867Z]  * KF5Completion (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5ItemViews (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5JobWidgets (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5Solid (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5Auth (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5Codecs (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5ConfigWidgets (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5XmlGui (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5Package (required version >= 5.69.0)[2020-04-17T04:19:50.867Z]  * KF5Service (required version >= 5.69.0)[2020-04-17T04:19:50.867Z] [2020-04-17T04:19:50.867Z] -- The following REQUIRED packages have been found:[2020-04-17T04:19:50.867Z] [2020-04-17T04:19:50.867Z]  * GBM, Mesa gbm library., [2020-04-17T04:19:50.867Z]Required for screencast portal[2020-04-17T04:19:50.867Z]  * Epoxy, libepoxy, [2020-04-17T04:19:50.867Z]Required for screencast portal[2020-04-17T04:19:50.867Z]  * Qt5PrintSupport[2020-04-17T04:19:50.867Z]  * Qt5Qml (required version >= 5.14.2)[2020-04-17T04:19:50.867Z]  * Qt5QmlModels (required version >= 5.14.2)[2020-04-17T04:19:50.867Z]  * Qt5QuickWidgets[2020-04-17T04:19:50.867Z]  * Qt5 (required version >= 5.14.0)[2020-04-17T04:19:50.867Z]  * Gettext[2020-04-17T04:19:50.867Z]  * KF5I18n (required version >= 5.66.0)[2020-04-17T04:19:50.867Z] 

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80340.
apol added a comment.


  Include the notification

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80285=80340

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28576: Converted to page and added Heading

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase, but LGTM!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28576

To: niccolove, #plasma, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:4a8adbaeac4e: Converted to Page with a PlasmoidHeading in 
the heading (authored by niccolove).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=80324=80327

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1a6b40cb5e0e: Make headings of systray and applet merge 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80315=80326

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit! Shipit real good!

REPOSITORY
  R97 Bluedevil

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 80324.
niccolove added a comment.


  rebase x3

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=80321=80324

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 80321.
niccolove added a comment.


  rebase x2

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=80320=80321

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 80320.
niccolove added a comment.


  rebase

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28467?vs=79889=80320

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28467

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM before the rebase though!

REPOSITORY
  R97 Bluedevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove added a comment.


  In D28467#649913 , @ngraham wrote:
  
  > Hmm, seems broke:
  >
  >   
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/FullRepresentation.qml:145:1:
 Expected token `}'
  >
  
  
  Forgot to rebase 若

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham added a comment.


  Sorry, I actually broke it in my attempt to rebase it so that it lands. You 
need to do the rebase on top of master:
  
git checkout master
git pull
git checkout [your branch]
git pull --rebase origin master
arc diff

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham added a comment.


  Hmm, seems broke:
  

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/FullRepresentation.qml:145:1:
 Expected token `}'

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28893: Detect Vivaldi based on binary name

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Vivaldi no longer includes its name in the User Agent, see [1].
  Try detecting it based on binary name instead.
  This could perhaps also be used to detect other chromium-based browsers such 
as Brave.
  
  [1] https://www.google.de/search?q=vivaldi+user+agent+change

TEST PLAN
  Should be good for 5.18 - coreaddons should have been an implicit dependency 
anyway?
  
  - MPRIS identifies it as Vivaldi again.
  - Its icon doesn't show up and I have no idea where the "vivadi" icon file it 
specifies in its desktop file is located

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28893

AFFECTED FILES
  CMakeLists.txt
  host/CMakeLists.txt
  host/settings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove requested review of this revision.
niccolove added a comment.


  Should finally work with latest D28575 

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

[Niccolò Venerandi]

niccolove updated this revision to Diff 80315.
niccolove added a comment.


  third one's a charm

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80314=80315

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

[Niccolò Venerandi]

niccolove updated this revision to Diff 80314.
niccolove added a comment.


  try 2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80313=80314

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

[Niccolò Venerandi]

niccolove updated this revision to Diff 80313.
niccolove added a comment.


  Only merge if header is actually visible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79483=80313

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28888: Fix navigation regressions

[Noah Davis]

ndavis added a comment.


  In D2#649712 , @cblack wrote:
  
  > In D2#649710 , @ngraham 
wrote:
  >
  > > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. 
Could they just go back to using real list items instead?
  >
  >
  >
  >
  >   That's what I initially attempted, but non-deterministic behaviour was 
caused by swapping out a list of cards for a list of listitems.
  
  
  Could you be more specific?

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28888: Fix navigation regressions

[Nathaniel Graham]

ngraham added a comment.


  I can understand that there are technical challenges, but, not to put too 
fine a point on it, this doesn't look very good: F8241927: 
Screenshot_20200416_101220.png 

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28888: Fix navigation regressions

[Carson Black]

cblack added a comment.


  In D2#649710 , @ngraham wrote:
  
  > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. 
Could they just go back to using real list items instead?
  
  
  That's what I initially attempted, but non-deterministic behaviour was caused 
by swapping out a list of cards for a list of listitems.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28888: Fix navigation regressions

[Nathaniel Graham]

ngraham added a comment.


  Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. 
Could they just go back to using real list items instead?

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D2

To: cblack, #vdg, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28888: Fix navigation regressions

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This patch fixes navigation regressions caused by larger cards in the gallery.
  
  - Keyboard focus is properly handled
  - Cards collapse to a smaller form when a second page is present

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  cblack/better-navigation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: cblack, #vdg, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart

D28873: Add SwipeNavigator component

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in SwipeNavigator.qml:55
> different tabbars should really depend only on whether it's a mobile device 
> or not (and be at bottom if mobile): a very small window on desktop is not a 
> mobile app

I think the tabbar should not be at the bottom on mobile. It's not necessary to 
touch the control as swiping from any point of the page should change the page, 
it is more visible when put at top, it is more consistent with kde and not-kde 
applications and introduces a position inconsistency between devices 
(touchscreen laptops should also be taken into consideration).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80285.
apol added a comment.


  Fix build

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80280=80285

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:1d5398acecaa: Add PageRouter component (authored by 
cblack).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28383?vs=80282=80283#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=80282=80283

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  Mainpage.dox
  autotests/CMakeLists.txt
  autotests/tst_pagerouter.qml
  docs/pics/PageRouterModel.svg
  docs/pics/PageRouterNavigate.svg
  docs/pics/PageRouterPop.svg
  docs/pics/PageRouterPush.svg
  examples/PageRoute.qml
  examples/PageRouter.qml
  examples/PageRouterCachePagesDo.qml
  examples/PageRouterCachePagesDont.qml
  examples/PageRouterColumnView.qml
  examples/PageRouterInitialRoute.qml
  examples/PageRouterRoutes.qml
  src/CMakeLists.txt
  src/controls/PageRow.qml
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 80282.
cblack marked an inline comment as done.
cblack added a comment.


  Use more descriptive name

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=80275=80282

BRANCH
  arcpatch-D28383

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  Mainpage.dox
  autotests/CMakeLists.txt
  autotests/tst_pagerouter.qml
  docs/pics/PageRouterModel.svg
  docs/pics/PageRouterNavigate.svg
  docs/pics/PageRouterPop.svg
  docs/pics/PageRouterPush.svg
  examples/PageRoute.qml
  examples/PageRouter.qml
  examples/PageRouterCachePagesDo.qml
  examples/PageRouterCachePagesDont.qml
  examples/PageRouterColumnView.qml
  examples/PageRouterInitialRoute.qml
  examples/PageRouterRoutes.qml
  src/CMakeLists.txt
  src/controls/PageRow.qml
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D28873: Add SwipeNavigator component

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> mart wrote in Page.qml:238
> again, not convinced we should have this, seems a bit oddly specific

it's not uncommon for apps to have one page associated with an ongoing task.
examples:

- clocks app running a progress indicator in reverse to indicate a timer
- app store running a progress indicator on "updates/downloads" tab
- gallery/online drive app running a progress indicator on a tab to indicate 
syncing progress

> mart wrote in SwipeNavigator.qml:30
> perhaps any custom heading should be via a custom item (or component?) to put 
> as a property (of type qqc2.tabbar)

i don't see how that relates to wanting a larger (bigscreen-sized) header?

> mart wrote in SwipeNavigator.qml:55
> different tabbars should really depend only on whether it's a mobile device 
> or not (and be at bottom if mobile): a very small window on desktop is not a 
> mobile app

it's still nice to have a collapsed form of the tabbar for small screen sizes

> mart wrote in SwipeNavigator.qml:66
> this should be page actions? other actions? what is the exact use case?

global actions

> mart wrote in SwipeTabBar.qml:12
> QtQuickControls do have a TabBar control, instead of having a completely 
> custom control

I'm aware, but I went with a custom control for more control of the 
presentation and functionality.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28873: Add SwipeNavigator component

[Carson Black]

cblack updated this revision to Diff 80281.
cblack marked 5 inline comments as done.
cblack added a comment.


  Address some feedback

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28873?vs=80259=80281

BRANCH
  cblack/lateral (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28873

AFFECTED FILES
  src/controls/Page.qml
  src/controls/SwipeNavigator.qml
  src/controls/private/SwipeTabBar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of creating the pipewire feeds in the portal, they will be
  created in KWin.
  Then the portal task becomes to orchestrate the permission and delivery
  to the app.
  
  Depends on D28882 

TEST PLAN
  None yet, just a PoC

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  src/CMakeLists.txt
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

[Nathaniel Graham]

ngraham added a comment.


  Yeah.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25728

To: filipf, #plasma, #vdg
Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Marco Martin]

mart accepted this revision.
mart added inline comments.

INLINE COMMENTS

> pagerouter.cpp:217
> +auto incomingRoutes = parseRoutes(route);
> +QList mut;
> +

more descriptive name

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28383

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D28881: [Applet] Fix connecting with a password

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2e6878a37f6e: [Applet] Fix connecting with a password 
(authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28881?vs=80274=80276

REVISION DETAIL
  https://phabricator.kde.org/D28881

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

To: ngraham, jgrulich, nicolasfella, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Carson Black]

cblack added a comment.


  In D28873#649570 , @camiloh wrote:
  
  > What about having as a view a component that is not a Kirigami.Page? Such 
as a StackView or a Rectangle. Why not use an attached property to define its 
title, icon and other props instead of focing to wrap those components into a 
kirigami.Page?
  
  
  Mmm, the point of this is to provide lateral navigation between pages, not 
arbitrary elements.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 80275.
cblack added a comment.


  Fix faulty navigateToRoute

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=80223=80275

BRANCH
  arcpatch-D28383

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  Mainpage.dox
  autotests/CMakeLists.txt
  autotests/tst_pagerouter.qml
  docs/pics/PageRouterModel.svg
  docs/pics/PageRouterNavigate.svg
  docs/pics/PageRouterPop.svg
  docs/pics/PageRouterPush.svg
  examples/PageRoute.qml
  examples/PageRouter.qml
  examples/PageRouterCachePagesDo.qml
  examples/PageRouterCachePagesDont.qml
  examples/PageRouterColumnView.qml
  examples/PageRouterInitialRoute.qml
  examples/PageRouterRoutes.qml
  src/CMakeLists.txt
  src/controls/PageRow.qml
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, mart

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  See D28881 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28034

To: ngraham, #vdg, #plasma, jgrulich
Cc: nicolasfella, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28881: [Applet] Fix connecting with a password

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: jgrulich, nicolasfella, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
ngraham requested review of this revision.

REVISION SUMMARY
  I could have sworn that I tested this during the initial ExpandableListItem 
port, but
  the code change required to fix it suggests that I either did not, or was 
smoking crack
  at the time. Sorry about the breakage.

TEST PLAN
  Entering a password in the password field and hit return; password is sent 
and it tries
  to connect

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  fix-connecting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28881

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

To: ngraham, jgrulich, nicolasfella, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Camilo Higuita]

camiloh added a comment.


  What about having as a view a component that is not a Kirigami.Page? Such as 
a StackView or a Rectangle. Why not use an attached property to define its 
title, icon and other props instead of focing to wrap those components into a 
kirigami.Page?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  Crap. I could have sworn I tested that, but I see you're right. Will fix ASAP.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28034

To: ngraham, #vdg, #plasma, jgrulich
Cc: nicolasfella, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 22 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/22/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 16 Apr 2020 13:17:00 +
 Build duration:
1 min 41 sec and counting
   CONSOLE OUTPUT
  [...truncated 232 lines...][2020-04-16T13:18:29.406Z] -- Detecting CXX compiler ABI info[2020-04-16T13:18:29.406Z] -- Detecting CXX compiler ABI info - done[2020-04-16T13:18:29.406Z] -- Detecting CXX compile features[2020-04-16T13:18:29.406Z] -- Detecting CXX compile features - done[2020-04-16T13:18:29.669Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T13:18:29.669Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-04-16T13:18:29.669Z] -- Looking for __GLIBC__[2020-04-16T13:18:29.945Z] -- Looking for __GLIBC__ - not found[2020-04-16T13:18:29.945Z] -- Performing Test _OFFT_IS_64BIT[2020-04-16T13:18:29.945Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-04-16T13:18:29.945Z] -- Performing Test HAVE_DATE_TIME[2020-04-16T13:18:30.203Z] -- Performing Test HAVE_DATE_TIME - Success[2020-04-16T13:18:38.355Z] -- Could NOT find PipeWire (missing: PipeWire_LIBRARIES PipeWire_INCLUDE_DIRS Spa_INCLUDE_DIRS) (found version "")[2020-04-16T13:18:38.355Z] -- Found GBM: /usr/local/lib/libgbm.so (found version "18.3.2") [2020-04-16T13:18:38.623Z] -- Found Epoxy: /usr/local/lib/libepoxy.so  [2020-04-16T13:18:40.592Z] -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2020-04-16T13:18:40.592Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T13:18:40.592Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.592Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T13:18:40.892Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/xdg-desktop-portal-kde/kf5-qt5 FreeBSDQt5.14/build/prefix.sh to set the environment for xdg-desktop-portal-kde.[2020-04-16T13:18:40.892Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.892Z] -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.892Z] -- Found KF5WidgetsAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.892Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.70.0") [2020-04-16T13:18:40.892Z] -- Found KF5: success (found suitable version "5.70.0", minimum required is "5.66.0") found components: CoreAddons Config I18n Declarative KIO Kirigami2 Notifications Plasma Wayland WidgetsAddons WindowSystem [2020-04-16T13:18:41.176Z] -- The following OPTIONAL packages have been found:[2020-04-16T13:18:41.176Z] [2020-04-16T13:18:41.176Z]  * PkgConfig[2020-04-16T13:18:41.176Z]  * KF5Completion (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5ItemViews (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5JobWidgets (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5Solid (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5Auth (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5Codecs (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5ConfigWidgets (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * KF5XmlGui (required version >= 5.69.0)[2020-04-16T13:18:41.176Z]  * 

D28875: Screensharing: support variable stride

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R838:d1f0ec4d3a4c: Screensharing: support variable stride 
(authored by jgrulich).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28875?vs=80262=80273

REVISION DETAIL
  https://phabricator.kde.org/D28875

AFFECTED FILES
  src/screencaststream.cpp

To: jgrulich, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28034: [Applet] Port to ExpandableListItem

[Nicolas Fella]

nicolasfella added a comment.


  This breaks entering a WiFi password for me. Pressing enter just closes the 
password field with no other reaction. Pressing the Connect button does nothing

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28034

To: ngraham, #vdg, #plasma, jgrulich
Cc: nicolasfella, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20132: Actually make the network list view show up

[Nicolas Fella]

nicolasfella added a comment.


  Is this still relevant?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20132

To: vkrause, jgrulich
Cc: nicolasfella, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28879: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

[Anton Parshukov]

sunny created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sunny requested review of this revision.

REVISION SUMMARY
  WidgetExplorer "get new widgets" dialogs live longer than WidgetExplorer, so 
it will be better to have external storage for that dialogs.
  If external storage isn't be set then behavior won't be changed.
  
  BUG: 412765
  Depends on D28878 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28879

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml
  desktoppackage/contents/views/Desktop.qml

To: sunny
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

[Anton Parshukov]

sunny created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sunny requested review of this revision.

REVISION SUMMARY
  WidgetExplorer "get new widgets" dialogs live longer than WidgetExplorer, so 
it will be better to have external storage for that dialogs.
  If external storage isn't be set then behavior won't be changed.
  
  BUG: 412765

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28878

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/widgetexplorer/widgetexplorer.cpp
  components/shellprivate/widgetexplorer/widgetexplorer.h
  components/shellprivate/widgetexplorer/widgetexplorerassistant.cpp
  components/shellprivate/widgetexplorer/widgetexplorerassistant.h

To: sunny
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28710: Make accidental panel and panel widget deletion more difficult

[Rik Mills]

rikmills added a comment.


  In D28710#647340 , @davidedmundson 
wrote:
  
  > We shouldn't be making UX changes on the stable branch
  
  
  I agree. This could make getting the 5.18.5 release accepted as a K/Ubuntu 
stable release update (SRU) in a few weeks time.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28710

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, rikmills, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Niccolò Venerandi]

niccolove added a comment.


  My opinion from the consistency side: I actually think this is a good 
possibility for the Consistency goal. After some digging around, my opinion is 
that
  
  > Tabs should only be used on application views that are user-editable (eg: 
when it's possible to open a new tab or close another).
  
  It's imo appropriate to have a different component for changing views, 
especially on Kiri. But of course, that component should be consistent. Right 
now we have big square sidebars, toolbars, etc etc etc etc etc
  
  F8241366: image.png 
  
  I think that this component //could// be a good solution, because we have a 
similar topbar on Maui:
  F8241370: photo_2020-04-16_10-22-45.jpg 
  Plus, this navigation view is really easy to replicate with toolbars (stupid 
wrong example, but you get what I mean):
  F8241377: Screenshot_20200416_102417.png 

  And this patch could add them for Kirigami as well.
  
  Of course, this assumes that some other stuff goes well:
  
  - Pressed buttons in toolbars should use highlight style (1px opaque line all 
around)
  - Possibly, buttons in toolbars should have an option to disable text if 
there's not enough space and they are not pressed
  - Apps should be okay with moving to a top centered mutually exclusive 
toolbuttons for navigating views
  - This patch should also use such highlight style
  - Possibly, Maui should drop his appviews component and use this one since it 
does the same thing, so this patch should coordinate with them and make sure 
this is feature-even
  
  We wouldn't get "swipe to change view" on qwidgets, but it's mostly for 
desktop so I think it's fine.
  
  For reference, I had done some consistency mockups in the past and this idea 
was already there:
  F8241385: image.png 
  
  A problem I see is that most application have a high number of views that 
won't fit horizontal space with labels (I'm looking at Skrooge, KMyMoney, 
Kontact, ...). Should they be fine with only displaying label for the current 
one? They probably would prefer a sidebar, which we currently don't 
consistently offer, so we end up with various inconsistent implementations.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28833: [kcm/touchpad] Simplify directory structure

[Luigi Toscano]

ltoscano added a comment.


  The Messages.sh script should have been changed as well. I pushed a change 
which fixes the message extraction:
  
  
https://commits.kde.org/plasma-desktop/197d3076dd120b464998ad20d3bf0ae7c9c76664

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28833

To: nicolasfella, #plasma, ngraham
Cc: ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> Page.qml:223
> + */
> +property variant icon
> +

for consistency, should be a private/ActionItemGroup.qml (which mimics the 
upstream qqc2 api icon.name/source/width/height/color)

> Page.qml:238
> + */
> +property var progress: undefined
> +

again, not convinced we should have this, seems a bit oddly specific

> SwipeNavigator.qml:30
> + */
> +property bool largeHeader: false
> +

perhaps any custom heading should be via a custom item (or component?) to put 
as a property (of type qqc2.tabbar)

> SwipeNavigator.qml:38
> + */
> +property alias layerStack: stackView
> +

"layers", to have the same api of pageRow

> SwipeNavigator.qml:55
> +states: [
> +State {
> +name: "small"

different tabbars should really depend only on whether it's a mobile device or 
not (and be at bottom if mobile): a very small window on desktop is not a 
mobile app

> SwipeNavigator.qml:66
> +Kirigami.ActionToolBar {
> +id: actionToolBar
> +anchors {

this should be page actions? other actions? what is the exact use case?

> SwipeTabBar.qml:12
> +
> +RowLayout {
> +id: swipeTabBarRoot

QtQuickControls do have a TabBar control, instead of having a completely custom 
control

> SwipeTabBar.qml:37
> +if (index == columnView.currentIndex) {
> +return i18nc("Accessibility text for a page tab. 
> Keep the text as concise as possible and don't use a percent sign.", "Current 
> page. Progress: %1 percent.", Math.round(modelData.progress*100))
> +} else {

this is kinda outside of the scope of the control.
I guess you have an use case for this, but it shouldn't be a swiss army knife, 
just a tabbar: it's more complicated but at the same time there will always be 
people that miss a feature and will reimplement the whole thing for that.
I think it should just be easy to provide custom items for individual tabs, 
when needed (or just an item to be placed inside a tab, not sure)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28875: Screensharing: support variable stride

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

TEST PLAN
  All current clients still work and also we now support higher stride we get 
from
  gbm_bo.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  variable-stride

REVISION DETAIL
  https://phabricator.kde.org/D28875

AFFECTED FILES
  src/screencaststream.cpp

To: jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28873: Add SwipeNavigator component

[Marco Martin]

mart added a comment.


  The tabbars have their own look, which it's against the consistency goal. I 
do prefer this look to the current breeze one, but this is a debate to have at 
the level of the future breeze direction.
  It's ok in the case of mobile with the tbbar on the bottom as it's a pretty 
standard mobile control with an established  look and feel, but a top tabbar on 
the desktop should look like any other tabbar

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson