D29570: Fix some alignments

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma
Cc: abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29571: [Kickoff] Add emacs/bash style keybindings

[Mariusz Libera]

mlibera added a comment.


  Does the mechanism of standard shortcuts really apply here? Just below the 
code I added is the code explicitly handling keys like Qt.Key_Up, Qt.Key_Down, 
Qt.Key_Tab, etc. Seems like it's all hardcoded. Adding those keybinding to 
standard shortcuts has no effect.
  
  Anyway, would you be willing to accept just a special handling for ctrl+n/p 
if this patch is too much?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29571

To: mlibera, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29571: [Kickoff] Add emacs/bash style keybindings

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  KDE has a concept of "standard shortcuts". Instead of duplicating this same 
code everywhere with various combinations for people doing all sorts of crazy 
bindings, which is eternal we should be just looking into fixing this (if it's 
indeed broken) or expanding upon it if needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29571

To: mlibera, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29571: [Kickoff] Add emacs/bash style keybindings

[Mariusz Libera]

mlibera created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlibera requested review of this revision.

REVISION SUMMARY
  Users used to emacs/bash style of navigation and editing might appreciate a 
basic support for it in Kickoff, especially Ctrl+n/p for next/previous entry.

TEST PLAN
  Check if the keys work as expected, i.e.:
  Ctrl+n - cursor key down, highlight next item in the list
  Ctrl+p - cursor key up, highlight previous item in the list
  Ctrl+h - backspace, removes last character in the search field
  Ctrl+e - end key, move cursor to the end of the search field text
  Ctrl+f - cursor key right, move cursor one character right in the search field
  Ctrl+b - cursor key left, move cursor one character left in the search field
  Ctrl+[ - esc, here the code in the patch copies Kickoff's handling of Esc 
key, that seems to always result in closing Kickoff despite an if condition

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29571

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: mlibera
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

[Niccolò Venerandi]

niccolove added a comment.


  For some reason, the heading is still one or two pixels off... still, much 
better than before

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29570: Fix some alignments

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This fixes some wrong alignments

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29570

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29359: Add context for "Automatic" strings

[Yuri Chornoivan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2bf19bb7c59d: Add context for Automatic 
strings (authored by yurchor).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29359?vs=81774=82379

REVISION DETAIL
  https://phabricator.kde.org/D29359

AFFECTED FILES
  libs/editor/settings/ui/802-1x.ui
  libs/editor/settings/ui/connectionwidget.ui
  libs/editor/settings/ui/infiniband.ui
  libs/editor/settings/ui/ipv4.ui
  libs/editor/settings/ui/ipv6.ui
  libs/editor/settings/ui/wificonnectionwidget.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29359: Add context for "Automatic" strings

[Eloy Cuadra]

ecuadra accepted this revision.
ecuadra added a comment.


  Yes. Sorry for the delay.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29359

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29359: Add context for "Automatic" strings

[Yuri Chornoivan]

yurchor added a comment.


  @ecuadra Ping?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29359

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari added a comment.


  In D28623#666890 , @trmdi wrote:
  
  > Just a question, SierraBreezeEnhanced has a feature called "Unison 
hovering". Does this support it?
  
  
  Also, I think, that to support that you actually need to do a lot of upstream 
changes.
  
  1. Provide unison hovering API for KDecoration (i.e. option must exist for 
all decorations)
  2. Provide unison hovering API for GTK, so that there will be a config option 
in gsettings to turn on/off unison hovering.
  3. Once the above is done it is actually possible to implement syncing. But I 
doubt that the above patches will be accepted.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari added a comment.


  In D28623#666890 , @trmdi wrote:
  
  > Just a question, SierraBreezeEnhanced has a feature called "Unison 
hovering". Does this support it?
  
  
  No. That's because it is the GTK, who is responsible for hovering behavior. I 
only change the appearance of the buttons. Behavior stays the same.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Tranter Madi]

trmdi added a comment.


  Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". 
Does this support it?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82365.
gikari added a comment.


  - Add support for aurorae themes
  - Plastic does not work, but in that case decoration buttons in GTK apps are 
Breeze

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82294=82365

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/auroraedecorationpainter.cpp
  kded/kwin_bridge/auroraedecorationpainter.h
  kded/kwin_bridge/decorationpainter.cpp
  kded/kwin_bridge/decorationpainter.h
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h
  kded/kwin_bridge/standarddecorationpainter.cpp
  kded/kwin_bridge/standarddecorationpainter.h

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Niccolò Venerandi]

niccolove added a comment.


  Generic +1 to the idea, but:
  
  - I would not go higher than 50 as panel width
  - The clock is too small, it probably needs a version where there's a new 
line between hour and minutes
  - We should check that all widgets work correctly in a vertical panel

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: niccolove, felixernst, davidedmundson, ahiemstra, broulik, filipf, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Felix Ernst]

felixernst added a comment.


  +1 to this change.
  Having the exact same panel and buttons on the left instead of at the bottom 
is a change that IMO even the most computer-illiterate Windows user should have 
no major trouble adapting to. Anyone else can change the panel position if they 
want to. In any case I can't picture a scenario in which it would stop someone 
from getting work done so I wouldn't be too worried about changing this default.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: felixernst, davidedmundson, ahiemstra, broulik, filipf, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D29548: Drag and drop assigning windows to activities in the default switcher

[Ivan Čukić]

ivan created this revision.
ivan added reviewers: Plasma, mart, davidedmundson, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ivan requested review of this revision.

REVISION SUMMARY
  When dragging a window from the taskbar onto the activity switcher
  applet, the switcher will pop up showing all the activities. When the
  user drops the task onto an activity, it will be moved to said activity.
  
  Alternatively, if the Control key is pressed, the window will be
  assigned to the destination activity as well as the current one (copy).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29548

AFFECTED FILES
  applets/showActivityManager/package/contents/ui/main.qml
  desktoppackage/contents/activitymanager/ActivityItem.qml
  imports/activitymanager/CMakeLists.txt
  imports/activitymanager/switcherbackend.cpp
  imports/activitymanager/switcherbackend.h

To: ivan, #plasma, mart, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart