D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

2020-05-23 Thread David Korth 
dkorth added a comment.


  The original version I wrote a few months back as a quick fix to reduce CPU 
usage. I do agree that the magic numbers shouldn't be hard-coded, since that's 
not easily maintained, though I'm not sure of the best approach. constexpr 
strlen() seems like it'd work, or alternatively, splitting the line on spaces.
  
  I'll look into rewriting it to be more robust and submit an update.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29808

To: dkorth, ahiemstra
Cc: sandsmark, ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

2020-05-23 Thread Jiří Paleček 
jpalecek added a comment.


  In D29808#673157 , @sandsmark 
wrote:
  
  > > It's all C code whereas the rest of the helper is C++. It also relies 
very heavily on magic numbers now.
  >
  >
  >
  > > I think a much simpler implementation would be to split each line on " ", 
select the fields we want and clean them up.
  >
  > I assume this is for performance reasons, but a tiny microbenchmark showing 
that it is actually faster would be nice.
  
  
  Hi! Just out of curiosity (I'm not the OP), I created a microbenchmark here: 
https://github.com/jpalecek/ksysguard-network-microbenchmark. As a fun project, 
I added a Boost.Sphinx implementation, which was remarkably easy. Not the most 
readable code ever, beware. Some bugs were found while doing this (in both old 
and new implementation), see the code.

INLINE COMMENTS

> sandsmark wrote in ConnectionMapping.cpp:167
> instead of 87 + 1, maybe have a `constexpr int lineLength = strlen("0: 
> 0100:0277 : 
> 0A : 00:  00 16741");` above with 
> the comment?
> or:
> 
>   constexpr const char *exampleLine = "0: 
> 0100:0277 : 
> 0A : 00:  00 16741";
>   constexpr int lineLength = strlen(exampleLine);
> 
> both more understandable and less prone to accidentally putting in the wrong 
> number.
> 
> same with all other magic string offset numbers here.

Actually I don't agree with that view. I don't think `lineLength = strlen("0: 
000...`)` is readable and less error prone than `87`, only 
longer by ~100 characters and a nightmare to check. With numbers, I can check 
with an editor that shows column numbers and simple arithmetic, but comparing 
such long strings made of spaces is hard.

If you want more robustness, I would suggest using the fact that the number 
columns are aligned with the header and using something like `inode_col = 
header.find("inode")`. Or counting the fields. That would also take care of the 
possibility that the columns may not be same width across architectures (?)

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D29808

To: dkorth, ahiemstra
Cc: sandsmark, ahiemstra, jpalecek, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D29726: BookmarksRunner: Change caching databases

2020-05-23 Thread Alexander Lohnau 
alex closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29726

To: alex, #plasma, ngraham, meven, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20569: Use more compact OSD

2020-05-23 Thread Mélanie Chauvel 
achauvel added a comment.


  I’m so happy that it has finally been merged! I wish I could express more 
often how glad I am of the work being done on KDE, but it would be quite 
annoying to spam every patch/bug report I care about. ^^
  
  I hope my contribution to the discussion was valuable BTW, as I’m often not 
able to contribute code-wise to KDE.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis
Cc: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, 
hein, Codezela, filipf, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29807: Change Chrome API design

2020-05-23 Thread Alexander Lohnau 
alex updated this revision to Diff 83131.
alex added a comment.


  Use iterator, remove unused include

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83118&id=83131

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/CMakeLists.txt
  runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
  runners/bookmarks/tests/chromium/Default/Bookmarks
  runners/bookmarks/tests/chromium/Local State
  runners/bookmarks/tests/chromium/Profile 1/Bookmarks
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 106 - Still Failing!

2020-05-23 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/106/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 23 May 2020 14:41:39 +
 Build duration:
25 min and counting
   CONSOLE OUTPUT
  [...truncated 4165 lines...][2020-05-23T15:06:44.858Z]   ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobal.h:375:1: note: 'dirs' has been explicitly marked deprecated here[2020-05-23T15:06:44.858Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT KStandardDirs *dirs();[2020-05-23T15:06:44.858Z] ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-23T15:06:44.858Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-23T15:06:44.858Z]^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-23T15:06:44.858Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T15:06:44.858Z]  ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:23: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-05-23T15:06:44.858Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-05-23T15:06:44.858Z]   ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-23T15:06:44.858Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-23T15:06:44.858Z]   ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-23T15:06:44.858Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-23T15:06:44.858Z]^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-23T15:06:44.858Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T15:06:44.858Z]  ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:58: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-05-23T15:06:44.858Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-05-23T15:06:44.858Z]  ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-23T15:06:44.858Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-23T15:06:44.858Z]   ^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-23T15:06:44.858Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-23T15:06:44.858Z]^[2020-05-23T15:06:44.858Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-23T15:06:44.858Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T15:06:44.858Z]  ^[2020-05-23T15:06:45.131Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:389:44: warning: 'getItem' is deprecated [-Wdeprecated-declarations][2020-05-23T15:06:45.131Z] const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-05-23T15:06:45.131Z]^[2020-05-23T15:06:45.131Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:1: note: 'getItem' has been explicitly marked deprecated here[2020-05-23T15:06:45.131Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString &caption, const QString

D29807: Change Chrome API design

2020-05-23 Thread Méven Car 
meven accepted this revision as: meven.
meven added a comment.
This revision is now accepted and ready to land.


  Two smalls things.
  
  Seems good to me otherwise.
  
  Give some times to other to have a final say before merging.

INLINE COMMENTS

> chromeprofile.cpp:33
> +const QStringList profilesConfigKeys = 
> localState.value(QStringLiteral("profile")).toMap()
> +.value(QStringLiteral("info_cache")).toMap().keys();
> +for (const QString &profile : profilesConfigKeys) {

Perhaps use an iterator instead of copying the keys.

> fetchsqlite.cpp:32
>  #include 
> +#include 
>  

Is this used here ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-23 Thread Matt Kovacs 
kkoma added a comment.


  In D29798#672261 , @ngraham wrote:
  
  > You're probably right. This was a pretty lazy patch.
  >
  > The inherent challenge here is that desktop wallpapers are per-containment 
("Containment" means a screen or activity), while the lock and login screens 
are per-session. A further complication is that the login screen is only able 
to display still images (though maybe that could change?). So there isn't a 
super clean way to have a single config UI work for everything.
  >
  > One thing I could imagine would be the following:
  >
  > We make a new KCM in System Settings called "Wallpaper". This KCM 
essentially displays the current desktop wallpapers UI with one exception: it 
has multiple Apply options:
  >
  > - Apply to desktop //(shown when there is only one containment)//
  > - Apply to current desktop //(shown when there is more than one 
containment)//
  > - Choose which desktops to apply it to //(shown when there is more than one 
containment; needs a clever UI)//
  > - Apply to all desktops //(shown when there is more than one containment)//
  > - Apply to lock screen //(always shown)//
  > - Apply to login screen //(always shown, but only enabled when the chosen 
wallpaper is a still image)//
  >
  >   Maybe a sheet with these options could appear when you click on the Apply 
button. They would each be checkable, so you could apply the wallpapers to 
everything all at once if you wanted to.
  >
  >   This is similar to how most smartphones handle this (as well as GNOME as 
of a recent version IIRC) and I think it works pretty well there.
  >
  >   Thoughts?
  
  
  That was basically my suggestion a while back, together with a hovering 
preview overlay for the grid view in the wallpaper selector. I am totally amped 
that this is coming to reality!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29798

To: ngraham, #vdg, #plasma
Cc: kkoma, mart, niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29827: Give users the ability to disable the microphone indicator

2020-05-23 Thread Méven Car 
meven added a comment.


  In D29827#673611 , @davidedmundson 
wrote:
  
  > It's an SNI, I thought the systemtray could already filter SNIs in the  
enties tab of the system tray?
  
  
  Currently it appears in the systray config only when the microphone is 
activated.
  I guess we should make it more permanent.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: davidedmundson, meven, bcooksley, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29827: Give users the ability to disable the microphone indicator

2020-05-23 Thread David Edmundson 
davidedmundson added a comment.


  It's an SNI, I thought the systemtray could already filter SNIs in the  
enties tab of the system tray?
  
  
  
  > I made different attempts to achieve this. The class was imagined like a 
singleton, but it's not really a singleton, anyway it's initialized by the 
volume applet and it stays there having only one instance.
  
  The class was a singleton within the given QML context, The configuration UI 
is another context, which is why it instantiated a new one.
  
  
  
  One major comment about the config that I don't understand.

INLINE COMMENTS

> ConfigGeneral.qml:114
> +Kirigami.FormData.label: i18n("Show an indicator when an application 
> is using the:")
> +checked: micIndicator.enabled
> +text: i18n("Microphone")

I don't see why we're doing this.

Firstly it's a bit messy with regards to when this binds and updates vs when 
kcfg overwrites this binding.

Secondly and much more importantly why should whether this is currently enabled 
or not ultimately change the config value stored of whether we show the 
indicator when something is recording?

Once that's gone the entire singleton aspect is a lot less relevant.

> microphoneindicator.cpp:320
> +
> +void MicrophoneIndicatorInterface::setStatus(bool status)
> +{

setStatus(bool) is confusing naming

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: davidedmundson, meven, bcooksley, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 105 - Still Failing!

2020-05-23 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/105/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 23 May 2020 10:52:03 +
 Build duration:
4 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 4172 lines...][2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-23T10:55:49.769Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-23T10:55:49.769Z]   ^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-23T10:55:49.769Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-23T10:55:49.769Z]^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-23T10:55:49.769Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T10:55:49.769Z]  ^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:58: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-05-23T10:55:49.769Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-05-23T10:55:49.769Z]  ^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-23T10:55:49.769Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-23T10:55:49.769Z]   ^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-23T10:55:49.769Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-23T10:55:49.769Z]^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-23T10:55:49.769Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T10:55:49.769Z]  ^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:389:44: warning: 'getItem' is deprecated [-Wdeprecated-declarations][2020-05-23T10:55:49.769Z] const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-05-23T10:55:49.769Z]^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:1: note: 'getItem' has been explicitly marked deprecated here[2020-05-23T10:55:49.769Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString &caption, const QString &label,[2020-05-23T10:55:49.769Z] ^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-23T10:55:49.769Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-23T10:55:49.769Z]^[2020-05-23T10:55:49.769Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-23T10:55:49.769Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-23T10:55:49.769Z]  ^[2020-05-23T10:55:50.363Z] 1 error generated.[2020-05-23T10:55:50.363Z] gmake[2]: *** [kcms/users/src/CMakeFiles/kcm_users.dir/build.make:142: kcms/users/src/CMakeFiles/kcm_users.dir/user.cpp.o] Error 1[2020-05-23T10:55:50.363Z] gmake[1]: *** [CMakeFiles/Makefile2:6638: kcms/users/src/CMakeFiles/kcm_users.dir/all] Error 2[2020-05-23T10:55:50.363Z] gmake[1]: *** Waiting for unfinished jobs[2020-05-23T10:55:50.363Z] [ 50%] Building CXX object kcms/icons/CMakeFiles/plasma-changeicons.dir/iconssettings.cpp.o[2020-05-23T10:55:50.624Z] 22 warnings generated.[2020-05-23T10:55:50.624Z] [ 50%] Linking CXX shared module ../../bin/kcm_emoticons.so[2

D29827: Give users the ability to disable the microphone indicator

2020-05-23 Thread Méven Car 
meven added a comment.


  In D29827#673569 , @kurmikon wrote:
  
  > In D29827#673551 , @ngraham 
wrote:
  >
  > > The name needs to be your full name ("Firstname Lastname"). This was a 
pre-existing requirement, it's just now enforced before patch submission, 
rather than afterwards.
  >
  >
  > I was using the full name @ngraham, but it was rejecting the same. I will 
retry later, but this process shouldn't be simplified to new users? It's not 
stated inside the guide and it's useless enforce this requirement since the 
commit is done with an account where the full name is set in the profile.
  
  
  Did you `git commit --amend --author "FirstName LastName "` ?
  You simply need to update the author in the commit itself.
  
  > Am I the only one experiencing this issue?
  
  Everybody would yes.
  Your problem was just your gitconfig had a pseudonym and kde git policy (for 
legal reasons) expect full names.
  
  Sorry it seems our documentation is not very clear about this fact currently.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: meven, bcooksley, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29827: Give users the ability to disable the microphone indicator

2020-05-23 Thread Giusy Margarita 
kurmikon added a comment.


  In D29827#673551 , @ngraham wrote:
  
  > The name needs to be your full name ("Firstname Lastname"). This was a 
pre-existing requirement, it's just now enforced before patch submission, 
rather than afterwards.
  
  
  I was using the full name @ngraham, but it was rejecting the same. I will 
retry later, but this process shouldn't be simplified to new users? It's not 
stated inside the guide and it's useless enforce this requirement since the 
commit is done with an account where the full name is set in the profile.
  
  Am I the only one experiencing this issue?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D29827

To: kurmikon, ngraham, #vdg, #plasma
Cc: bcooksley, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: KEmoticons, emoticons kcm

2020-05-23 Thread Volker Krause 
On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote:
> I was looking through some Plasma code and I saw that we have some
> fairly old emoticons KCM using KF5Emoticons.
> 
> Now while I know why this exists, it feels like it's more of a thing
> of the past from when people wrote :) instead of 🙂. While keeping it
> around for the few apps that might still use it (ktp? kopete?) could
> make sense, I'm afraid it's probably making it confusing for the users
> who expect this to actually allow them to customise their 🙂 but
> won't.
> 
> Do you think it would make sense to deprecate the framework and remove the
> KCM?

Absolutely! 

There's some discussion on this topic in https://phabricator.kde.org/T11585 
already. While direct usage of KEmoticons in applications is rare, there is a 
"backdoor dependency" via a KCoreAddons plug-in it provides.

Regards,
Volker