Re: Gitlab and plasma dev
The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to @people that I'd like to notice the review in the comment to the MR. Yeah, I'm annoyed by that, too. The problem with a pure mention is that there's no overview to see all of those. I typically don't go by my email inbox but by a list of merge requests and there isn't a "mentioned" search, just author or assignee. I also have to work around the fact that there's no list of all merge requests on all projects by doing a "Target-Branch is master" query, which shows me most but also misses stable branches.
Re: Gitlab and plasma dev
> Somehow it's possible to create a label that covers all of Plasma as the > VDG have one already. > > Would that workflow work for other devs? Sounds cool. The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to @people that I'd like to notice the review in the comment to the MR. Cheers, Ivan -- dr Ivan Čukić i...@cukic.co, https://cukic.co/ gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232 07AE 01C6 CE2B FF04 1C12
D29395: Refactor MediaController
kmaterka added a comment. Any update on this? I really like the idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
Re: Gitlab and plasma dev
Hi, > I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. > Somehow it's possible to create a label that covers all of Plasma as the VDG have one already. Good idea! I think having a "Needs changes" label would be very useful, even on a global scale, not just for Plasma. Then you could also filter those ones out from your search queries. However, given GitLab has this concept of resolved threads where it wouldn't let you merge until everything's remedied - maybe there already exists infrastructure we could leverage for this purpose? (probably only in EE, scnr) What I would like to see is a "VDG approved" or "Design approved" label to explicitly express for designers "we like the looks of it" or "the interaction pattern is sound" but that someone still needs to review the actual code. Nate's been doing this on Phabricator by doing this "Accepted by VDG" which I recall was an awkward dance of clicking accept and then unchecking oneself. Making this more explicit and user-friendly would be appreciated. Cheers Kai Uwe
Re: Gitlab and plasma dev
One thing I'm missing when I'm doing reviews is I don't have a nice way to separate merge requests that need review, and merge requests that are awaiting changes. I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. Somehow it's possible to create a label that covers all of Plasma as the VDG have one already. Would that workflow work for other devs? David
D29326: Bookmarks Runner: Fix extraction of firefox profile
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a960c028c71d: Bookmarks Runner: Fix extraction of firefox profile (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29326?vs=81720=83164 REVISION DETAIL https://phabricator.kde.org/D29326 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp To: alex, #plasma, ngraham, bruns, broulik, meven Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 110 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/110/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Wed, 27 May 2020 13:41:59 +
Build duration:
1 min 12 sec and counting
CONSOLE OUTPUT
[...truncated 4175 lines...][2020-05-27T13:43:08.355Z] ^[2020-05-27T13:43:08.355Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-27T13:43:08.355Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-27T13:43:08.355Z] ^[2020-05-27T13:43:08.355Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-27T13:43:08.355Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-27T13:43:08.355Z]^[2020-05-27T13:43:08.355Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-27T13:43:08.355Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-27T13:43:08.355Z] ^[2020-05-27T13:43:08.355Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:58: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-05-27T13:43:08.355Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-05-27T13:43:08.355Z] ^[2020-05-27T13:43:08.355Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-05-27T13:43:08.355Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-05-27T13:43:08.355Z] ^[2020-05-27T13:43:08.355Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-27T13:43:08.356Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-27T13:43:08.356Z]^[2020-05-27T13:43:08.356Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-27T13:43:08.356Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-27T13:43:08.356Z] ^[2020-05-27T13:43:08.356Z] [ 52%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/SwitchingTab.cpp.o[2020-05-27T13:43:08.356Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:389:44: warning: 'getItem' is deprecated [-Wdeprecated-declarations][2020-05-27T13:43:08.356Z] const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-05-27T13:43:08.356Z]^[2020-05-27T13:43:08.356Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:1: note: 'getItem' has been explicitly marked deprecated here[2020-05-27T13:43:08.356Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString , const QString ,[2020-05-27T13:43:08.356Z] ^[2020-05-27T13:43:08.356Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-05-27T13:43:08.356Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-05-27T13:43:08.356Z]^[2020-05-27T13:43:08.356Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-05-27T13:43:08.356Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-05-27T13:43:08.356Z] ^[2020-05-27T13:43:08.356Z] [ 52%] Building CXX object kcms/componentchooser/CMakeFiles/kcm_componentchooser.dir/componentchooserfilemanager.cpp.o[2020-05-27T13:43:08.614Z] [ 52%] Linking CXX shared module ../../bin/kcm_lookandfeel.so[2020-05-27T13:43:08.876Z] [ 52%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/PrivacyTab.cpp.o[2020-05-27T13:43:08.876Z] 22 warnings generated.[2020-05-27T13:43:08.876Z] [ 52%] Linking CXX executable
D29820: Correction when displaying "badger counter" icons using software rendering
mart added a comment. yes please on gitlab. are you sure you don't get double painting on opengl now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29820 To: brunogoncalves, ngraham Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
Re: Sunsetting PowerDevil's XRandrBrightness
Martin Steigerwald - 26.05.20, 14:35:39 CEST: > Hi Kai. > > Kai Uwe Broulik - 20.05.20, 21:31:07 CEST: > > PowerDevil has two (three, if you count DDC) means of controlling > > screen brightness: > > > > * Writing to sysfs (/sys/class/backlight and /sys/class/leds) > > * Using XRandr output property > > > > XRandR is doing X calls and we have some lovely animated screen > > brightness change. However, the UPower "backend" in PowerDevil is > > quite a spaghetti class and having multiple ways to control LEDs > > doesn't help. > > Read your blog post and tried the command there: > > % QT_LOGGING_RULES='powerdevil=true' > /usr/lib/x86_64-linux-gnu/libexec/ org_kde_powerdevil > > gave no output whatsoever. > > However as I am using the "modesetting" driver I bet it won't use > XRandR. > > Also that is on Debian Sid where KDE Frameworks currently is still at > 5.62. Sandro works on 5.70 currently. ThinkPad T520 with Intel > Sandybridge graphics. Actually I already had 5.69 from Debian experimental. 5.70 now coming in to unstable, so I can test again once it is available. -- Martin
