D29847: Fixes compile problem for freebsd because of missing crypt.h
ngraham added a reviewer: adridg. ngraham added a subscriber: adridg. ngraham added a comment. Adding @adridg as a reviewer. Note that we have moved to Gitlab, so future contributions should be submitted at invent.kde.org. Thanks! You can find the documentation at https://community.kde.org/Infrastructure/GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooksley, ngraham, adridg Cc: adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D29847: Fixes compile problem for freebsd because of missing crypt.h
usta created this revision. usta added reviewers: Plasma, bcooksley. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. usta requested review of this revision. REVISION SUMMARY Freebsd compile is not working last 17 days because of missing crypt.h crypt method is in unistd.h for freebsd so we dont need it and also I am not sure whether freebsd has crypt.h or not. can somebody with freebsd try this patch ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 AFFECTED FILES kcms/users/src/user.cpp To: usta, #plasma, bcooksley Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 129 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/129/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Sun, 07 Jun 2020 03:07:24 +
Build duration:
32 min and counting
CONSOLE OUTPUT
[...truncated 4032 lines...][2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:23: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-06-07T03:39:31.028Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-06-07T03:39:31.028Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T03:39:31.028Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T03:39:31.028Z]^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T03:39:31.028Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:58: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-06-07T03:39:31.028Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-06-07T03:39:31.028Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T03:39:31.028Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T03:39:31.028Z]^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T03:39:31.028Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T03:39:31.028Z] ^[2020-06-07T03:39:31.028Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:389:44: warning: 'getItem' is deprecated [-Wdeprecated-declarations][2020-06-07T03:39:31.028Z] const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-06-07T03:39:31.029Z]^[2020-06-07T03:39:31.029Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:1: note: 'getItem' has been explicitly marked deprecated here[2020-06-07T03:39:31.029Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString , const QString ,[2020-06-07T03:39:31.029Z] ^[2020-06-07T03:39:31.029Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T03:39:31.029Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T03:39:31.029Z]^[2020-06-07T03:39:31.029Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T03:39:31.029Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T03:39:31.029Z] ^[2020-06-07T03:39:31.029Z] [ 51%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/BlacklistedApplicationsModel.cpp.o[2020-06-07T03:39:31.297Z] [ 51%] Building CXX object
KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 128 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/128/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Sun, 07 Jun 2020 00:51:38 +
Build duration:
22 min and counting
CONSOLE OUTPUT
[...truncated 3621 lines...][2020-06-07T01:13:47.052Z] KGlobalSettings::self()->emitChange(KGlobalSettings::CursorChanged);[2020-06-07T01:13:47.052Z]^[2020-06-07T01:13:47.052Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kglobalsettings.h:51:7: note: 'KGlobalSettings' has been explicitly marked deprecated here[2020-06-07T01:13:47.052Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT KGlobalSettings : public QObject[2020-06-07T01:13:47.052Z] ^[2020-06-07T01:13:47.052Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T01:13:47.052Z] # define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T01:13:47.052Z]^[2020-06-07T01:13:47.052Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T01:13:47.052Z] # define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T01:13:47.052Z] ^[2020-06-07T01:13:47.324Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/krdb/krdb.cpp:228:7: warning: 'sprintf' is deprecated: Use asprintf(), arg() or QTextStream instead [-Wdeprecated-declarations][2020-06-07T01:13:47.324Z] tmp.sprintf("#define %s #%02x%02x%02x\n",[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/local/include/qt5/QtCore/qstring.h:381:5: note: 'sprintf' has been explicitly marked deprecated here[2020-06-07T01:13:47.324Z] QT_DEPRECATED_X("Use asprintf(), arg() or QTextStream instead")[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/local/include/qt5/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'[2020-06-07T01:13:47.324Z] # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:676:55: note: expanded from macro 'Q_DECL_DEPRECATED_X'[2020-06-07T01:13:47.324Z] #define Q_DECL_DEPRECATED_X(text) __attribute__ ((__deprecated__(text)))[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/krdb/krdb.cpp:544:23: warning: 'flush' is deprecated [-Wdeprecated-declarations][2020-06-07T01:13:47.324Z] QApplication::flush();[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/local/include/qt5/QtCore/qcoreapplication.h:169:5: note: 'flush' has been explicitly marked deprecated here[2020-06-07T01:13:47.324Z] QT_DEPRECATED static void flush();[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2020-06-07T01:13:47.324Z] # define QT_DEPRECATED Q_DECL_DEPRECATED[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.324Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:227:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2020-06-07T01:13:47.324Z] # define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T01:13:47.324Z] ^[2020-06-07T01:13:47.593Z] [ 49%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/kcm_activities.cpp.o[2020-06-07T01:13:47.883Z] [ 49%] Linking CXX executable ../../bin/lookandfeeltool[2020-06-07T01:13:48.173Z] 2 warnings generated.[2020-06-07T01:13:48.173Z] [ 49%] Building CXX object kcms/users/src/CMakeFiles/kcm_users.dir/user.cpp.o[2020-06-07T01:13:48.475Z] [ 49%] Built target lookandfeeltool[2020-06-07T01:13:48.475Z] [ 49%] Building CXX object kcms/activities/CMakeFiles/kcm_activities.dir/MainConfigurationWidget.cpp.o[2020-06-07T01:13:48.751Z] [ 49%] Linking CXX shared module ../../bin/kcm_desktoppaths.so[2020-06-07T01:13:49.044Z] 12 warnings generated.[2020-06-07T01:13:49.044Z] [ 49%] Building CXX object kcms/lookandfeel/CMakeFiles/kcm_lookandfeel.dir/__/cursortheme/xcursor/cursortheme.cpp.o[2020-06-07T01:13:49.044Z] [ 49%] Built target kcm_desktoppaths[2020-06-07T01:13:49.044Z] [ 49%] Building CXX object kcms/lookandfeel/CMakeFiles/kcm_lookandfeel.dir/__/cursortheme/xcursor/xcursortheme.cpp.o[2020-06-07T01:13:49.675Z] [ 49%] Building CXX object kcms/lookandfeel/CMakeFiles/kcm_lookandfeel.dir/lookandfeelsettings.cpp.o[2020-06-07T01:13:50.288Z]
Re: KRunProxy
El dissabte, 6 de juny de 2020, a les 19:00:59 CEST, David Faure va escriure: > In order to switch kdeclarative to > -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054700 > we need to port KRunProxy away from KRun, or to deprecate KRunProxy. > > AFAICS it exposes an object named KRun to QML files, but searching for > qml files with KRun in them leads to no results: > https://lxr.kde.org/search?_filestring=*.qml&_string=KRun > > Am I doing this wrong? Yes, this is the correct search https://lxr.kde.org/search?_filestring=.*%5C.qml&_advanced=1&_string=KRun&_casesensitive=1 >From what i can see it's only used in one place to launch ksysguard Cheers, Albert > Are there other file extensions to take into consideration? > > If not, can I deprecate KRunProxy? > >
KRunProxy
In order to switch kdeclarative to -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054700 we need to port KRunProxy away from KRun, or to deprecate KRunProxy. AFAICS it exposes an object named KRun to QML files, but searching for qml files with KRun in them leads to no results: https://lxr.kde.org/search?_filestring=*.qml&_string=KRun Am I doing this wrong? Are there other file extensions to take into consideration? If not, can I deprecate KRunProxy? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
String fix exception request for Plasma/5.19
Hi, it seems there is an duplicate string in ksysguard_plugins_global.po (thanks Paolo Zamponi for finding it) I sent a review request: https://invent.kde.org/plasma/ksysguard/-/merge_requests/8 I understand it's a bit late and we will have a new message to translate between Plasma 5.19.0 and 5.19.1 (in a week) and we can fix it in the translation (thanks to the different message context), but I think it's better to show the correct message to the English speakers. Would it be a problem to have it merged? Ciao -- Luigi
