D27034: Fix message box when passing a remote url that includes a file

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  This is wrong, isn't it? The logic was: if setDirectory is passed something 
that _isn't_ a directory, try to strip the filename.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27034

To: apol, #frameworks, ngraham
Cc: sandsmark, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 130 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/130/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sun, 07 Jun 2020 15:15:15 +
 Build duration:
3 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 4024 lines...][2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T15:18:09.880Z]^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T15:18:09.880Z]  ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:23: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-06-07T15:18:09.880Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-06-07T15:18:09.880Z]   ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-06-07T15:18:09.880Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-06-07T15:18:09.880Z]   ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T15:18:09.880Z]^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T15:18:09.880Z]  ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:370:58: warning: 'NetAccess' is deprecated [-Wdeprecated-declarations][2020-06-07T15:18:09.880Z] if (KIO::NetAccess::exists(QUrl(path), KIO::NetAccess::SourceSide, this)) {[2020-06-07T15:18:09.880Z]  ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kio/netaccess.h:68:7: note: 'NetAccess' has been explicitly marked deprecated here[2020-06-07T15:18:09.880Z] class KDELIBS4SUPPORT_DEPRECATED_EXPORT NetAccess : public QObject[2020-06-07T15:18:09.880Z]   ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4SUPPORT_DEPRECATED[2020-06-07T15:18:09.880Z]^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:25:54: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED __attribute__ ((__deprecated__))[2020-06-07T15:18:09.880Z]  ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/kcms/emoticons/emoticonslist.cpp:389:44: warning: 'getItem' is deprecated [-Wdeprecated-declarations][2020-06-07T15:18:09.880Z] const QString type = KInputDialog::getItem(i18n("New Emoticon Theme"), i18n("Choose the type of emoticon theme to create"),[2020-06-07T15:18:09.880Z]^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kinputdialog.h:209:1: note: 'getItem' has been explicitly marked deprecated here[2020-06-07T15:18:09.880Z] KDELIBS4SUPPORT_DEPRECATED_EXPORT QString getItem(const QString &caption, const QString &label,[2020-06-07T15:18:09.880Z] ^[2020-06-07T15:18:09.880Z] /usr/home/jenkins/install-prefix/include/KF5/KDELibs4Support/kdelibs4support_export_internal.h:29:68: note: expanded from macro 'KDELIBS4SUPPORT_DEPRECATED_EXPORT'[2020-06-07T15:18:09.880Z] #  define KDELIBS4SUPPORT_DEPRECATED_EXPORT KDELIBS4SUPPORT_EXPORT KDELIBS4

D27129: [Notifications] Allow expiring an entire group

[Méven Car]

meven accepted this revision as: meven.
meven added a comment.
This revision is now accepted and ready to land.


  Seems fine to me

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27129

To: broulik, #plasma, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27129: [Notifications] Allow expiring an entire group

[Kai Uwe Broulik]

broulik added a comment.


  Should we go with this now? I haven't seen it crash on me since I fixed the 
`checkIndex` thing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27129

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Ömer Fadıl Usta]

usta added a comment.


  In D29847#674807 , @adridg wrote:
  
  > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes
  >
  > There's already a CMake-time check for ``, it's just not used. 
(`HAVE_CRYPT_H`)
  
  
  @adridg having or not having crypt_h I think won't solve this problem because 
it looks like Linux needs it on the other hand BSD system doesn't have it and 
use unistd.h
  instead of crypt.h so doesn't we still need to check if the system is linux 
or not ? I have almost 0 knowledge about bsd systems so i think anyone who has 
knowledge 
  on this topic might be more suitable for this patch request. ( at first, I 
have just think about freebsd and now i can see there are other alternatives 
(net,open,... bsd has similar issue ) )

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, arrowd, sebas, apol, 
ahiemstra, mart

D28881: [Applet] Fix connecting with a password

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ConnectionItem.qml:234
> +} else if (connectionItem.customExpandedViewContent == 
> passwordDialogComponent) {
> +if (passwordDialogComponent.password != "") {
> +handler.addAndActivateConnection(DevicePath, 
> SpecificPath, passwordDialogComponent.password)

You can't access a `Component`. You'd need to access the instance created by 
the `Loader` in `ExpandableListItem` which isn't exposed to the user.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28881

To: ngraham, jgrulich, nicolasfella, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Adriaan de Groot]

adridg added a comment.


  https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes
  
  There's already a CMake-time check for ``, it's just not used. 
(`HAVE_CRYPT_H`)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, arrowd, sebas, apol, 
ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Ömer Fadıl Usta]

usta added a comment.


  or if this is just for linux think we can make it just directly 
  if defined(Q_OS_LINUX)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, arrowd, sebas, apol, 
ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Ömer Fadıl Usta]

usta updated this revision to Diff 83237.
usta added a project: FreeBSD.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29847?vs=83235&id=83237

REVISION DETAIL
  https://phabricator.kde.org/D29847

AFFECTED FILES
  kcms/users/src/user.cpp

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, arrowd, sebas, apol, 
ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Ömer Fadıl Usta]

usta added a comment.


  Sorry i have written one of them twice , so is this aproach wrong ?
  #if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && 
!defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> tcberner wrote in user.cpp:23
> wouldn't it be a bit more portable to check for the header file in cmake? 
> (OpenBSD also has the same issue, I would assume from [1])
> 
> [1] 
> https://www.freebsd.org/cgi/man.cgi?query=crypt&apropos=0&sektion=3&manpath=OpenBSD+6.7&arch=default&format=html

I never think about openbsd , yes you are right about it. So how about if we 
use something like :
#if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && 
!defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29847: Fixes compile problem for freebsd because of missing crypt.h

[Tobias C. Berner]

tcberner added inline comments.

INLINE COMMENTS

> user.cpp:23
>  #include 
> +#ifndef Q_OS_FREEBSD
>  #include 

wouldn't it be a bit more portable to check for the header file in cmake? 
(OpenBSD also has the same issue, I would assume from [1])

[1] 
https://www.freebsd.org/cgi/man.cgi?query=crypt&apropos=0&sektion=3&manpath=OpenBSD+6.7&arch=default&format=html

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart