D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added inline comments.

INLINE COMMENTS

> broulik wrote in kcmaccess.cpp:141
> Are you sure this shouldn't be something like
> 
>   modifiers & (ScrollMask | LockMask | NumMask)

good catch.

> broulik wrote in kcmaccess.desktop:9
> What about this? We still need to autostart kaccess on login.
> Perhaps, while at it, you could port it over to proper autostart mechanism 
> rather than abusing kcminit for that.

Can you elaborate on that? I don't really know what you mean.

> broulik wrote in kcmaccess.h:42
> Where is this being used?

It was used in the old code, I forgot to add in the Ui.

> broulik wrote in Bell.qml:89
> Why are you writing to a different property than you check for immutability?

changed the names on the kcfg file and forgot to update here. it's a bit 
annoying that part of the kconfig is string based and other part is proper code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack added a comment.


  In D29466#676411 , @ngraham wrote:
  
  > Putting it in KRunner could make at least a little bit of sense if it 
worked everywhere--i.e. with in-window menubars as well. However since it does 
not, I think the current location makes sense.
  >
  > Could you move this to GitLab maybe?
  
  
  https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/134

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: meven, ngraham, ognarb, Leon0402, trmdi, nicolasfella, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Nathaniel Graham]

ngraham added a comment.


  Putting it in KRunner could make at least a little bit of sense if it worked 
everywhere--i.e. with in-window menubars as well. However since it does not, I 
think the current location makes sense.
  
  Could you move this to GitLab maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: meven, ngraham, ognarb, Leon0402, trmdi, nicolasfella, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.15 - Build # 196 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.15/196/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Fri, 04 Sep 2020 13:28:19 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 114 test(s), Skipped: 0 test(s), Total: 114 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(59/85)58%
(322/559)58%
(322/559)43%
(32952/76352)33%
(14593/44417)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault88%
(139/158)88%
(139/158)66%
(20762/31398)51%
(10295/20114)colorcorrection100%
(7/7)100%
(7/7)79%
(677/857)59%
(238/401)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)78%
(456/585)63%
(140/221)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/383)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/692)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)34%
(164/486)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
(79/970)3%
(29/894)effects.diminactive33%
(1/3)33%
(1/3)15%
(36/239)2%
(3/158)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(47/657)1%
(5/550)effects.glide67%
(2/3)67%
(2/3)72%
(150/208)65%
(60/93)effects.highlightwindow100%
(2/2)100%
(2/2)43%
   

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.15 - Build # 33 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.15/33/
 Project:
stable-kf5-qt5 SUSEQt5.15
 Date of build:
Thu, 03 Sep 2020 23:09:41 +
 Build duration:
7 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kcms.lookandfeel.autotests.lookandfeel_kcmTest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report15%
(12/79)17%
(61/367)17%
(61/367)12%
(3875/31741)10%
(1804/18932)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.emojier0%
(0/1)0%
(0/1)0%
(0/180)0%
(0/107)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1098)0%
(0/620)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/339)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/4)0%
(0/4)0%
(0/368)0%
(0/234)applets.showdesktop.plugin0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/318)0%
(0/224)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/236)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(932/2367)28%
(420/1505)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/345)0%

D29466: [applets/appmenu] Add search to global application menu

[Méven Car]

meven added subscribers: ngraham, meven.
meven added a comment.


  In D29466#674210 , @trmdi wrote:
  
  > Can this be moved to krunner? In that case it can be used even when the 
user doesn't use global menu?
  
  
  I don't think think so, this search works in the app action menu items. 
Krunner is completely detached from applications.
  
  @ngraham any thoughts perhaps ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: meven, ngraham, ognarb, Leon0402, trmdi, nicolasfella, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carl Schwan]

ognarb added a comment.


  What is the state of this MR?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: ognarb, Leon0402, trmdi, nicolasfella, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart