D28487: Redesign of system monitor plasmoids

[Alex Debus]

alexde added a comment.


  Not sure, if this is part of the scope of this work, but do you also plan to 
add some meaningful labels and ticks to the axis?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28487

To: mart, #plasma
Cc: alexde, ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

[Alex Debus]

alexde added a comment.


  In D27198#607110 , @ngraham wrote:
  
  > I tried 1.4 but it looked a bit too small to me, and not sufficiently 
differentiated from the level 2 and 3 headings in content areas:
  
  
  When looking at the screenshots, 1.4 looks fine to me, but go with whatever 
you guys think looks better.  :)

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

[Alex Debus]

alexde added a comment.


  Looks way better, thanks Nate!
  
  Since case 1 to 3 are steps of 0.1 and from case 3 to 4 is a step of 0.2, how 
would it looke like with 1.40 instead of 1.50?
  Would it be too small? Would you like attach another screenshot please? :-)

REPOSITORY
  R169 Kirigami

BRANCH
  smaller-and-more-left-padded-page-titles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27198

To: ngraham, #vdg, #kirigami, manueljlin, mart
Cc: alexde, ahiemstra, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, davidedmundson, mart, hein

D15418: Dim application icon when it is not playing anything

[Alex Debus]

alexde added a comment.


  In D15418#604200 , @broulik wrote:
  
  > > Can't we dim label instead?
  >
  > I quite like that. Also not very obvious what it means, I guess..
  
  
  Not sure if it was already discussed, but what about adding an overlay 
mute-icon, similar to D3302 ? Maybe this is 
easier to understand?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D26392: Add option to easily configure and start a hotspot

[Alex Debus]

alexde added a comment.


  > UI-wise, this would probably be better off as a button than a checkbox.
  
  Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an 
action? Right now, I don't see the big difference.
  
  (I assume "hotspot" and "shared wifi" are equivalent.)
  
  1. If you have configured several hotspots in the KCM, you probably need to 
choose a default one or a specific one when activating the hotspot.
  2. What do you think about adding a small configure button for the default 
hotspot directly on the plasma-nm frontend  next to the hotspot checkbox/button?
- That would make it much easier for newcomers to use and configure their 
hotspot without first digging in the KCM.
  3. I also think that a hotspot (shared wifi) connection should be better 
separated from the other wifi connections in the KCM. If I create a new hotspot 
in the KCM now, it hides in the long list of known connections.
  4. That's somehow also true for the plasma-nm list of available networks: 
It's not really clear that a hotspot in the list is a indeed hotspot but not 
another access point.
  
  In D26392#587159 , @mthw wrote:
  
  > @apol You are right, it is not possible to create a hotspot if one is 
already connected to a WiFi network. Currently enabling hotspot disables your 
previous connection (WiFi) and hides available WiFi networks.
  
  
  Is this also true if one has two wifi network cards? IIRC I could run both 
with an additional usb netwok card simultaneously.
  
  ---
  
  @jgrulich do you intend to create another patch to display all connected 
clients, similiar to the list of active connections? :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Alex Debus]

alexde added a comment.


  In D21273#586877 , @luc4 wrote:
  
  > Probably the consequence of not reviewing changes? This one can probably be 
abandoned.
  
  
  What a shame!  As you are familiar with the code, you could probably review 
the other patch too and see if it there's space for improvements, which 
probably your patch already coveres. :)

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Alex Debus]

alexde added a comment.


  This patch looks pretty similar to the already merged one 
https://phabricator.kde.org/D25018. How are they related?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20569: RFC: Use more compact OSD

[Alex Debus]

alexde added a comment.


  Since the most common problem that people have is "the OSD gets in the way 
when I change the volume while playing a video", how about only changing those 
OSD styles for the "volume" and "brightness" and leave the rest as it is with 
their characteristic appearance and visual distinctiveness?
  
  The volume/brightness OSDs could be displayed horizontally like in the OT or 
vertically as I posted in another Diff 
:
  F7825127: Mockup.png 
  
  As Roman already suggested , the 
compact version could be used by default in full screen apps (only).
  Though, I personally would not mind to have options exposed in the 
systemsettings.
  
  ---
  
  P.S. Should this and the other discussion 
 probably summed up in a Task for further 
discussions?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, Fuchs, 
filipf, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D14949: Add option for whether to show the volume change OSD

[Alex Debus]

alexde added a comment.


  Personally I am in favour of the current Windows 10 style, a compact version 
in the top left corner.  I tried to to create a mockup to demonstrate how it 
could look like:  F7825127: Mockup.png 
  
  To make hopefully everyone happy (*), there could principally be two options 
exposed (eg via a combobox plus a preview button, which simulates the choice):
  
  - Default center big
  - Top left compact
  
  Additional there could be a radiobutton
  
  - Display none in full screen apps
  
  (*) except those, who do not like to introduce new options. :)
  P.S. I am not on reddit.

REVISION DETAIL
  https://phabricator.kde.org/D14949

To: anonym, #vdg
Cc: alexde, achauvel, amaiga, davidedmundson, filipf, rooty, graesslin, 
svenmauch, ngraham, romangg, mart, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25018: Move ACPI battery information from /proc/acpi to /sys

[Alex Debus]

alexde added a comment.


  In D25018#561268 , @jjorge wrote:
  
  > > Are states > 100 or < 0 really well defined? Is it save to assume that a 
state > 100 can be associated with 100?
  >
  > Yes : this is a percentage. States out of this value are bad hardware : I 
have a travel battery which shows crazy values along time, from 0,001Wh 
capacity till 901Wh (Real capacity is near 45Wh).
  
  
  How can you interpret these weird charge_now values correctly? If it goes 
from [1/1000, 901] Wh, while the real range is [0, 45] Wh, how does the charge 
curve look like while charging or discharging? 
  Are there (continues) values in [46, 901] Wh? Do you assume all of those as 
100%?

REPOSITORY
  R106 KSysguard

BRANCH
  acpi-move-battery-to-sysfs

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: alexde, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25018: Move ACPI battery information from /proc/acpi to /sys

[Alex Debus]

alexde added inline comments.

INLINE COMMENTS

> acpi.c:129
> +} else if (state < 0) {
> +state = 0; /* prevent insane numbers with bad hardware */
>  }

Are states > 100 or < 0 really well defined? Is it save to assume that a state 
> 100 can be associated with 100?

> acpi.c:161
> +} else if (state < 0) {
> +state = 0; /* prevent insane numbers with bad hardware */
> +}

Are states > 100 or < 0 really well defined? Is it save to assume that a state 
> 100 can be associated with 100 for example?

> nvidia.json:12
>  "Description[nn]": "Statistikk til prosessorspesifikke GPU-ressursar 
> for NVIDIA-kort",
> +"Description[pl]": "Statystyka dla zasobów GPU na proces dla kart 
> Nvidii",
>  "Description[pt]": "Estatísticas dos recursos do GPU por processo 
> nas placas Nvidia",

This should maybe be a part of a separate patch as it seems unrelated.

REPOSITORY
  R106 KSysguard

BRANCH
  acpi-move-battery-to-sysfs

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: alexde, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24379: [energy kcm] Fix Technology values

[Alex Debus]

alexde added a comment.


  As this it not in the scope of this patch, those values look suspicious to me 
too:
  
switch(model.battery.type) {
case 3: return i18n("Internal battery")
case 2: return i18n("UPS battery")
case 9: return i18n("Monitor battery")
case 4: return i18n("Mouse battery")
case 5: return i18n("Keyboard battery")
case 1: return i18n("PDA battery")
case 7: return i18n("Phone battery")
default: return i18n("Unknown battery")
  
  Is there a special reason for the weired order? Is it correct that case 0 and 
6 are missing and default to unknown? Maybe (I haven't looked deeper into it) 
this needs another patch.

INLINE COMMENTS

> main.qml:104
>  switch(value) {
> -case 0: return i18n("Unknown Technology")
> -case 1: return i18n("Lithium Ion")
> -case 2: return i18n("Lithium Polymer")
> -case 3: return i18n("Lithium Iron Phosphate")
> -case 4: return i18n("LeadAcid")
> -case 5: return i18n("Lead Acid")
> -case 6: return i18n("Nickel Metal Hydride")
> +case 0: return i18n("Unknown technology")
> +case 1: return i18n("Lithium ion")

Wouldn't it be better to define 0 as a default value?

> main.qml:110
> +case 6: return i18n("Nickel cadmium")
> +case 6: return i18n("Nickel metal hydride")
>  }

Now you have two times the case 6

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D24379

To: meven, ngraham, ltoscano
Cc: alexde, plasma-devel, ltoscano, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24036: Fix the last fix of the max y-range computation

[Alex Debus]

alexde updated this revision to Diff 66344.
alexde added a comment.


  The next loop starts with index+1. This rare case with index out of bounds 
should not happen, but just in case ...

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24036?vs=66343=66344

BRANCH
  ymax_again (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24036

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24036: Fix the last fix of the max y-range computation

[Alex Debus]

alexde added a comment.


  This range check should definitely be included. The other error, I don't know 
right away. If no one else spots it, I will check it on the weekend.
  
  Regards

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D24036

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24036: Fix the last fix of the max y-range computation

[Alex Debus]

alexde updated this revision to Diff 66343.
alexde added a comment.


  Add range check for index variable

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24036?vs=66340=66343

BRANCH
  ymax_again (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24036

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24036: Fix the last fix of the max y-range computation

[Alex Debus]

alexde added a comment.


  In D24036#533557 , @ngraham wrote:
  
  > I still get:
  >
  >   
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114:
 TypeError: Cannot read property 'x' of undefined
  >   
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114:
 TypeError: Cannot read property 'x' of undefined
  >
  
  
  I have seen this error myself before at another place, which was the 
scalePoint function if I remember it correctly -- simply where data[index].x is 
accessed the first time in the code path.
  As I haven't touched the data, it can be assumed that's not my fault that 
those values are undefined for some weird reason. 
  I could add a check in the Graph.qml to ignore those values or later 
investigate the reason behind this bug, when I definitely have more time. ;-)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D24036

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24036: Fix the last fix of the max y-range computation

[Alex Debus]

alexde created this revision.
alexde added reviewers: VDG, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The last fixed was not correct. This version should serve better.

REPOSITORY
  R102 KInfoCenter

BRANCH
  ymax_again (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24036

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D24029: Fix maximum y-value-range computation

[Alex Debus]

alexde created this revision.
alexde added reviewers: VDG, Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REVISION SUMMARY
  Rounding to the next 10 did not work if the maximum value was something like 
y_max = 30.947
  In this case modulo 10 gives 0 and therefore the maximum values becomes 30 in 
the end, though it should be 40
  otherwise the peak points outside of the chart.
  
  Floor(max) + 10 always works.

REPOSITORY
  R102 KInfoCenter

BRANCH
  ymax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24029

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66063.
alexde added a comment.


  Remove redundant and now wrong comment

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66062=66063

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66062.
alexde added a comment.


  Fix offset calculation for the one hour graph

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66055=66062

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  In D23520#531168 , @ngraham wrote:
  
  > Thanks, that's fixed now. However the "Last hour" graph still looks a 
little odd...
  >
  > F7350933: Screenshot_20190914_084935.png 

  
  
  Mm, I cannot reproduce this issue on my side and I cannot explain why you may 
experience it as the code behaves all the same of for all timespans. Very odd.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66055.
alexde added a comment.


  Fix typo in variable and by that make all X axis labels appear again.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66044=66055

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66044.
alexde added a comment.


  The former scaling of the x-Positions of the data points did not fit to the 
time axis.
  Now the x-values of the points, i. e. their timestamps, are correctly aligned.
  
  For some unknown reasons, all data points, which come before/after a certain, 
  abitrary timestamp, seem to have a non-valid timestamp = 0.
  That's why I have added a if-statement to ignore those values.
  
  This feels more like a workaround and the underlying issue should be fixed 
instead in the future.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66034=66044

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66034.
alexde added a comment.


  Remove redundant semicolons and move comment about unit (ms) to the 
declaration of the var

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=66031=66034

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 66031.
alexde added a comment.


  Use a switch statement for xTicksAt

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65457=66031

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: meven, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  *Friendly ping to the reviewers.*

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23746: Set a minimum window size to reasonable 800x600 px.

[Alex Debus]

alexde created this revision.
alexde added reviewers: VDG, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REPOSITORY
  R102 KInfoCenter

BRANCH
  minimum-window-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23746

AFFECTED FILES
  infocenter.cpp

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65457.
alexde added a comment.


  Set correct right border for the grid lines and ticks.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65428=65457

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65428.
alexde added a comment.


  Move stroke() out of the loop.
  Reduce line with by pixel.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65423=65428

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65423.
alexde added a comment.


  Shrink plotWidth a little bit so the earliest date on the right side may fit.
  Change the way the division widths are defined to hopefully make the code 
easier to understand
  and to maintain.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65413=65423

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  For some reason the xGridOffset seems sometimes to be wrong, and I have no 
explanation why. It especially happens for 1 hour graphs. F7320671: 
Screenshot_20190905_132313.png 

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde requested review of this revision.
alexde added a comment.


  I have changed some stuff, can you please review it again.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65413.
alexde added a comment.


  Rename variables to make their function clearer.
  Decrease the lower loop border by 1 to make sure that all
  possible grid lines are drawn.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65410=65413

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65410.
alexde added a comment.


  Fix issue that a date may be displayed unintentionally.
  Shrink right margin for grid lines and try to add an additional grid line
  on the right side if reasonable.
  Add more divisions for 2h and 24h graphs.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65409=65410

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65409.
alexde added a comment.


  Use dashed grid lines instead of solid lines. Grid lines with tick labels are 
less faint.
  Rename variable to make its function clearer.
  Show grid lines at all five minutes for the 1 hour graph.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65407=65409

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65407.
alexde added a comment.


  Align grid to 10 minutes for the 1h graph.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65321=65407

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65320.
alexde added a comment.


  - Set valid defaults.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64920=65320

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 65321.
alexde added a comment.


  Set valid defaults.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=65320=65321

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  Right now I only display the date under the tick mark if the date has changed 
and the tickmark number is odd, which I think is already good enough for this 
graph.
  However, indicating a date change at midnight (12 pm / 0 am) would make sense 
as well. If you prefer that and find a suitable position for the indicator 
label, I may implemement it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64920.
alexde added a comment.


  Fix displaying wrong variable.
  Add postfix "Str" to indicate that those vars are explicitely strings.
  Make sure that the date is only displayed when date has changed for <= 24h 
graphs.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64896=64920

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64896.
alexde added a comment.


  Improve the formatting's consistancy

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64892=64896

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64892.
alexde added a comment.


  Update comment

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64890=64892

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64890.
alexde added a comment.


  Omit the date if date equals today and the graph does not range over 24 hours.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64889=64890

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64889.
alexde added a comment.


  Resolve formatting issues
  
  - remove semicolons
  - replace tab indention by 4 spaces
  - add space between operator and arguments

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64840=64889

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde added a comment.


  > As you can see, it's kind of funny that only one of the labels has a date 
under it. This is fine for the multi-day graphs, but for the graphs that are 
entirely within the current day, I would recommend omitting the date.
  
  There's actually not such thing as a "single-day" graph. If you look at 0:30 
am at your "1 hour" graph, it will go from 11:30 pm to 0:30 am. :-) 
  But I am fine to omit the dates or at least the current day for all but the 
"48 hour" and "1 week" graphs. Just tell me what you prefer.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23520

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64840.
alexde added a comment.


  Set more sane left/right margins

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64805=64840

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde updated this revision to Diff 64805.
alexde added a comment.


  Set correct default value for a tick position

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23520?vs=64803=64805

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23520: Add time line to X axis

[Alex Debus]

alexde created this revision.
alexde added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The current energy plot does not display any time line. This patch adds a 
grid and time stamps to the X axis.
  It is assumed that the X axis of the plot ranges from [Now - Timespan, Now].
  The timestamps for the timespans greater than "1 hour" are aligned to either 
half hours or full hours. 
  The resolution respectively the divisions count or number of ticks is made 
dependend on the timespan.
  Dates are only shown if the date changes in the timespan.
  
  This patch may be only of temporary nature until kf5quickcharts 
 becomes production ready.
  
  As QML was absolutely new to me, I am looking forward to your review.

REPOSITORY
  R102 KInfoCenter

BRANCH
  energy-timeline (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23520

AFFECTED FILES
  Modules/energy/package/contents/ui/Graph.qml
  Modules/energy/package/contents/ui/main.qml

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Alex Debus]

alexde added a comment.


  > for various technical reasons that are not yet fixable
  
  Can you please point me to those? Is there ongoing work? I'm curious.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Alex Debus]

alexde added a comment.


  > DnD is not very intuitive for things that don't look inherently draggable
  
  That's why I draw a frame around the entries and also the mouse pointer could 
change to a hand. Otherwise I neither really like 1) or 2). How do other 
systems handle this?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23389: Use "Make default" buttons to switch the default device

[Alex Debus]

alexde added a comment.


  Just brainstorming: What about two sections, 1) "default" with a single entry 
and 2) "others". 
  The user could drag and drop the speaker to default place and the current 
default one would move downwards with an animation.F7276701: 
Screenshot_20190824_201127.png 

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: alexde, ndavis, anthonyfieroni, shubham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23237: Do not display vendor, Product and capacity in network plasmoid

[Alex Debus]

alexde added a comment.


  In D23237#514325 , @broulik wrote:
  
  > It literally says in the commit message that this will be moved exactly 
there.
  
  
  I definitely need more coffee, sorry. O:-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23237

To: meven, ngraham, #plasma, broulik, #vdg, filipf
Cc: alexde, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D23237: Do not display vendor, Product and capacity in network plasmoid

[Alex Debus]

alexde added a comment.


  In which GUI do I find "Vendor" and "Model" now?  There's the "Energy 
Information" in KInfocenter, which
  has a section "manufacturer" (in screenshot "Herstller"), but only lists the 
serial number. Maby it could go there? F7259918: Screenshot_20190819_105414.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23237

To: meven, ngraham, #plasma, broulik, #vdg, filipf
Cc: alexde, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22493: [Notifications] Move history items' icons over to the left a bit

[Alex Debus]

alexde added a comment.


  Friendly ping. :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22493: [Notifications] Move history items' icons over to the left a bit

[Alex Debus]

alexde added a comment.


  In D22493#496764 , @ngraham wrote:
  
  > Yeah, this patch touches only the history items, not the popups. I can do 
that too, if you'd like.
  
  
  Are you sure? When I applied this patch (+ units.iconSizes.medium) it looked 
like that:
  F7067500: Screenshot_20190721_131131.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22493

To: ngraham, broulik, #vdg, #plasma
Cc: alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  > For pictures (like people's faces in messenger notifications) I would still 
prefer the lager icons, though.
  
  I have to admit, that I'm not very much satisfied myself with the size. It 
could be a bit larger, something between medium and large. Maby we should 
discard it again. :P

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: broulik, pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  > You must run cmake for the whole repository; once done that, you can cd to 
the applets/notifications/ subdirectory of the builddir, and build only that 
part.
  
  What I also needed to install is
  
kdesignerplugin
  
  then
  
  So the procedure is as follows:
  
  1. cd plasma-workspace (root folder)
  2. cmake -DCMAKE_INSTALL_PREFIX=/usr .
  3. cd applets/notifcation
  4. make -j6
  5. sudo make install
  6. Log out & log in
  
  Is there a simly way to not override my working plasma desktop files?
  
  I am now going to attach the screenshot above.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: pino, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22605: Set notifications entry icon size to medium

[Alex Debus]

alexde added a comment.


  I would like to test it and post a screenshot, however I am not able to 
compile it:
  
  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..
  
  This resulted in
  
CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json):
  Unknown CMake command "kcoreaddons_desktop_to_json".
  
  
  
  5. I then added
  
find_package(KF5Plasma REQUIRED)
  
  to the CMakeLists.txt, which at least make cmake succeed. However, when I 
tried to compile it with
  
  6. make
  
  It breaks with
  
Scanning dependencies of target plasma_applet_notifications
[ 20%] Building CXX object 
CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o

/path/KDE/plasma-workspace/applets/notifications/notificationapplet.cpp:27:10: 
error: QQuickItem: File or directory not found
   27 | #include 
  |  ^~~~
Compilation terminated.
make[2]: *** [CMakeFiles/plasma_applet_notifications.dir/build.make:63: 
CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:233: 
CMakeFiles/plasma_applet_notifications.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
  
  I have the Qt development and kcoreaddons' files installed. I thought this 
procedure would be more straight forward. I'm looking forward to your advice. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22605

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22605: Set plasma-nm history entry icon size to medium

[Alex Debus]

alexde created this revision.
alexde added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexde requested review of this revision.

REVISION SUMMARY
  The current history entry icon is rather large and therefore
  hits the bottom of the entry in the list.
  As the margin between two entries is small, it looks more clear
  overall if the icon becomes smaller.
  
  BUG: 409855

REPOSITORY
  R120 Plasma Workspace

BRANCH
  plasma-nm-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22605

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: alexde, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Alex Debus]

alexde added a comment.


  In D18809#408482 , @davidre wrote:
  
  > Do you mean the Controls on the top? (...)  Please correct me if I'm wrong.
  
  
  Exactly, but let's wait for the expertise of Nate and the rest of the VDG 
team as I am not sure myself.
  
  > I guess this could be done like when you remove single images but we would 
need to think about a way to mark the removed folder in the list. Maybe in 
another patch?
  
  Same answer as above. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[Alex Debus]

alexde added a comment.


  Great work!
  
  Currently you have a very long folder list object. However, in my experience 
most users only have a few folders, where they store their wallpapers.
  So, what about saving space by positioning the folder list to the right of 
the controls? As we now display only folder names and not whole paths, the 
width should be fine and if you have more than 5 different folders, scrolling 
should be a good option.
  
  Further, if you are about to delete a folder, the images belonging to the 
selected folder, could be highlighted somehow. That way you know what you are 
about to remove without explicitely doing arduous investigation.
  
  What do you think?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Alex Debus]

alexde added a comment.


  In D17354#372274 , @ngraham wrote:
  
  > Changing the style just here would introduce inconsistency at a time when 
we're trying to make everything more consistent. The current FormLayout style 
is what we've decided on for the moment and I think it makes sense to fully 
implement it before we think about replacing it with something else. :)
  
  
  Sounds reasonable to me! ;) Can you please point me to the discussion? Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

[Alex Debus]

alexde added a comment.


  Thank you Nate! I am just curious if you considered to structure titles and 
options vertically, where the options are indeted by a tab:
  
  General
  
[  ] Show week number
  
  Available plugins
  
[  ] Plugin A
[  ] Plugin B
  
  That's would I personally would favor.
  
  Kind Regards

REPOSITORY
  R120 Plasma Workspace

BRANCH
  improve-calendar-settings-layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17354

To: ngraham, #plasma, #vdg, mart, davidedmundson
Cc: alexde, mvourlakos, abetts, zzag, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Alex Debus]

alexde added a comment.


  I would like to introduce another suggestion, which has not yet came up: If 
you don't want to blur everything, how about to only blur an rectangle 
underneath the login controls. That means a combination of early Plasma 5
  
  > The early Plasma 5 login screen put a dark translucent rectangle underneath 
the foreground elements, which worked just fine
  
  and the current one + the enhanced contrast:
  
  F6457437: Screenshot_20181129_233135.png 

  I am sorry that this a pretty bad mockup, but Gimp works completely 
counterintuitive to me. Otherwise it'd look better and there were round 
corners. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts, pstefan, 
broulik, rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart