Re: KRunner and KActivities

[Alexander Lohnau]

Heyho,

as stated in #Plasma, I will take care of it shortly ;)

Regards
Alex

On 11/20/23 18:57, Jonathan Riddell wrote:

I've just seen that KRunner uses KActivities but we moved activities
to Plasma and Runner is in Frameworks.  Whatever shall we do?

Joanthan

Re: Move krunner also to plasma bundle?

[Alexander Lohnau]

Heyho,

I discussed with David Edmundson that it might be a good idea to move
the milou QML bits to plasma-workspace. That allows easier codesharing
for some KFileItemActions integrations that Kai (and I in an abandoned
patch) have been working on. Though, this has the same issues regarding
the KWin overview effect.

Regarding Friedrichs points:
In KF5, KRunner has had a large dependency tree, including
plasma-frameworks in its public header. The model has been moved from
Milou to KRunner in KF6. This makes KRunner more useful (without having
to implement a model oneself) for consumers. Due to the model move,
there should no longer be many issues of synchronizing changes, because
logic like sorting is now in one place.

I do not think that is it makes sense to differentiate between stable
plugin APIs and other, unstable APIs. Maybe one non-plugin relevant API
is the model, but that only exposes stuff from the plugin API (like
QueryMatch properties).

Regards
Alex

On 11/5/23 18:17, Nate Graham wrote:

On 11/5/23 10:12, Nate Graham wrote:> +1, it's an integral part of
Plasma and I would support moving it there.

And Milou is already there. For that matter, I'd also support moving
both Milou and what's currently in the KRunner framework just into
plasma-workspace for simplicity since it's a required dependency anyway.

Nate


...Though on second thought, putting it in plasma-workspace would
probably not be ideal since then it would be harder to use KWin (which
embeds KRunner in the Overview effect) without Plasma. So maybe a
separate repo in Plasma would be better. Heck, maybe we could merge
the KRunner framework into the Milou repo and rename it have a name
that's at least tangentially related to its content. :)

Nate

KF6 KCModule & KQuickAddons::ConfigModule changes

[Alexander Lohnau]

Hello everyone,

I write regarding the KCModule refactoring.
This evening, I have merged the MRs that removed the old
KCModule/KQuickAddons(Managed)ConfigModule classes.

In order to avoid issues with your leftover files from previous
installations, please delete the following files:

~/kde/usr/include/KF6/KCMUtils/KCModuleData
~/kde/usr/include/KF6/KCMUtils/kcmoduledata.h
~/kde/usr/include/KF6/KConfigWidgets/KCModule
~/kde/usr/include/KF6/KConfigWidgets/kcmodule.h

I also recommend cleaning up any old KCMs of the "plasma/kcms/" plugin
namespace.
In Debian bases systems this is
~/kde/usr/lib/x86_64-linux-gnu/plugins/plasma/kcms/systemsettings/
For other distributions/plugin dirs, just check the install_manifest.txt
of repos that contain KCMs.

If there are issues with this, please write a mail or ping me on #kde-devel.

Regards
Alex

Loading RunCommand.qml file in KRunner using QRC

[Alexander . Lohnau]

Hello everyone,
 
I write this mail regarding the proposed change of 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2032.
Currently we load the main KRunner QML file “RunCommand.qml” from the look and 
feel KPackage. However, this has caused issues repeatedly in the past, because 
old/broken QML files can be loaded.
The idea from the beginning of Plasma 5 seemed to be that the design of Krunner 
should be changeable with the theme, however most of the code in this file is 
application logic.

The only issue is that the LNF mechanism is considered public API. Thus this 
change is considered controversial.
Merging it would mean that potential RunCommand.qml files from the LNF packages 
are just ignored. IMHO that is no problem.
 
Any thoughts?
 
Regards
Alexander

Cleanup of previous Applet builds

[Alexander . Lohnau]

Hello,

with the accompanying MRs 
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/458 a few 
plugin files got renamed
to ensure that their file name matches the plugin id. Please ensure that the 
old plugins are deleted,
with kdesrc-build the directory is 
~/kde/usr/lib/x86_64-linux-gnu/plugins/plasma/applets/.
After removing this dir, you should install plasma-workspace and optionally 
kdeplasma-addons (if that is part of your build setup).
Users of package managers will not have any issue, because there old files are 
deleted.
 
Regards
Alexander

 

Aw: Re: kcm_bluetooth changed ?

[Alexander . Lohnau]

Hello,

 

Usually the KCMs are opened by starting kcmshell or systemsettings with the module names as arguments,

meaning we resolve the location of the KCMs internally and don't require changes for consumers. kcmshell also checks if the plugin id

would match if the "kcm_" prefix is to the module name prepended, consequently "kcmshell5 bluetooth" works in both Plasma 5.23 and 5.24.

 

> If KDE/plamsa is such a moving target where  can not rely on compatibility even between minor versions, that is really not fun

 

Looking at liquidshell, there are multiple  cases where the available KCMs are checked at runtime to be compatible with old Plasma versions. While having to do this is not ideal, it is not anything new.

Luckily most of the changes to port the KCMs to the new metadata approach have already landed.
The KWin KCMs remain though, when porting those I will make sure to create a accompanying MR in liquidshell.

 

PS: You can check if the KPluginMetaData object is valid, instead of checking if the name is not empty :).

 

Regards
Alex


 
 

Gesendet: Sonntag, 13. Februar 2022 um 14:41 Uhr
Von: "Fusion Future" 
An: "Martin Koller" 
Cc: kde-frameworks-de...@kde.org, plasma-devel@kde.org, alexander.loh...@gmx.de
Betreff: Re: kcm_bluetooth changed ?

On 2022/2/13 21:31, Martin Koller wrote:
> But still I wonder if such a change is something like breaking ABI compatibility.
> If KDE/plamsa is such a moving target where I can not rely on compatibility even
> between minor versions, that is really not fun.
>

Perhaps the breakage is due to these commits [1-3]. Need to ask
Alexander Lohnau if there is a proper solution. I added him to the Cc list.

Sorry for the inconvenience.

[1]
https://invent.kde.org/plasma/bluedevil/-/commit/ac71faf781e1b3690f33bf54f27eeaaee7ec30e3
[2]
https://invent.kde.org/plasma/bluedevil/-/commit/87ad90b54592817d77d50c4284ff899659fa0550
[3]
https://invent.kde.org/plasma/bluedevil/-/commit/62856fe4d95ab4c1b795cf487ea0dbc61459412c

Re: plasma_install_package vs plasma_install_bundled_package

[Alexander Lohnau]

Hi,

in https://invent.kde.org/frameworks/kpackage/-/blob/master/
KF5PackageMacros.cmake#L109[1] there is the a JSON file created.

The initial discussion about this function was in 
https://phabricator.kde.org/D9197[2]. In
https://phabricator.kde.org/D19383[3] the topic was also discussed, but without 
getting a
conclusion.

There only being two users in all these years might be a sign that we don't 
really need it,
especially since in the initial patch description it was stated that it is 
experimental :)

Regards
Alex


On Thursday, July 29, 2021 2:29:01 PM CEST Nicolas Fella wrote:
> Hi,
>
> in
> https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMa
> cros.cmake#L12 we recommend using plasma_install_bundled_package over
> plasma_install_package.
>
> However in practice we always use the latter, except for plasma-pa and
> plasma-nm.
>
> I stumbled across this because the bundled version does not seem to
> create a metadata.json from the metadata.desktop like the other macro
> does. That means that the desktop file needs to be converted to json at
> runtime which comes with a significant performance overhead when loading
> a plasmoid.
>
> Now I'm wondering whether we should fix plasma_install_bundled_package
> or port the two users away from it and abandon it.
>
> Thoughts?
>
> Cheers
>
> Nico




[1] https://invent.kde.org/frameworks/kpackage/-/blob/master/
KF5PackageMacros.cmake#L109
[2] https://phabricator.kde.org/D9197

[3] https://phabricator.kde.org/D19383

D29807: Change Chrome API design

[Alexander Lohnau]

alex added a comment.


  Friendly Ping :-)
  
  Or should I just move this to gitlab?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28544: RecentDocuments Runner: Cleanup and formatting

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Will continue on gitlab

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28544

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a960c028c71d: Bookmarks Runner: Fix extraction of firefox 
profile (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29326?vs=81720=83164

REVISION DETAIL
  https://phabricator.kde.org/D29326

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

alex added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29326

To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29726

To: alex, #plasma, ngraham, meven, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: Change Chrome API design

[Alexander Lohnau]

alex updated this revision to Diff 83131.
alex added a comment.


  Use iterator, remove unused include

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83118=83131

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/CMakeLists.txt
  runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
  runners/bookmarks/tests/chromium/Default/Bookmarks
  runners/bookmarks/tests/chromium/Local State
  runners/bookmarks/tests/chromium/Profile 1/Bookmarks
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: Change Chrome API design

[Alexander Lohnau]

alex updated this revision to Diff 83118.
alex added a comment.


  Formatting, remove debug statement

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83116=83118

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/CMakeLists.txt
  runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
  runners/bookmarks/tests/chromium/Default/Bookmarks
  runners/bookmarks/tests/chromium/Local State
  runners/bookmarks/tests/chromium/Profile 1/Bookmarks
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Task will proceed on GitLab.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29384

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: Change Chrome API design

[Alexander Lohnau]

alex updated this revision to Diff 83116.
alex retitled this revision from "WIP: Change Chrome API design" to "Change 
Chrome API design".
alex edited the summary of this revision.
alex added reviewers: ngraham, meven.
alex added a comment.


  Change import, formatting

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83029=83116

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/CMakeLists.txt
  runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
  runners/bookmarks/tests/chromium/Default/Bookmarks
  runners/bookmarks/tests/chromium/Local State
  runners/bookmarks/tests/chromium/Profile 1/Bookmarks
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma, ngraham, meven
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: WIP: Change Chrome API design

[Alexander Lohnau]

alex updated this revision to Diff 83029.
alex marked an inline comment as done.
alex added a comment.


  Create test cases

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83028=83029

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/CMakeLists.txt
  runners/bookmarks/tests/chrome-config-home/.config/chromium/Local State
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-Sample.json
  runners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
  runners/bookmarks/tests/chromium/Default/Bookmarks
  runners/bookmarks/tests/chromium/Local State
  runners/bookmarks/tests/chromium/Profile 1/Bookmarks
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: WIP: Change Chrome API design

[Alexander Lohnau]

alex updated this revision to Diff 83028.
alex added a comment.


  Make constructor private

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29807?vs=83019=83028

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex, broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29807: WIP: Change Chrome API design

[Alexander Lohnau]

alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  - The FindProfile class was only for Chrome implemented => removed
  - Having ProfileBookmarks and Profile class is unnecessary, especially 
because they are only needed for Chrome
  - Better error handling
  
  TODO: Adjust tests for chrome
  Have a second look at the changes ;-)

TEST PLAN
  Should work as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  api_inconsistencies (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29807

AFFECTED FILES
  runners/bookmarks/CMakeLists.txt
  runners/bookmarks/browserfactory.cpp
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chrome.h
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/chromefindprofile.h
  runners/bookmarks/browsers/chromeprofile.cpp
  runners/bookmarks/browsers/chromeprofile.h
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/faviconfromblob.h
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp
  runners/bookmarks/tests/testchromebookmarks.h

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

alex added a comment.


  Friendly Ping @bruns or may I land this already ?
  And should this land on `Plasma/5.19`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29326

To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex updated this revision to Diff 82954.
alex added a comment.


  Adjust docstring for Browser::updateCacheFile

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29726?vs=82946=82954

BRANCH
  avid_unnecessary_copying (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29726

AFFECTED FILES
  runners/bookmarks/browser.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp

To: alex, #plasma, ngraham, meven, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex updated this revision to Diff 82946.
alex added a comment.


  Use enum for caching return type

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29726?vs=82790=82946

BRANCH
  avid_unnecessary_copying (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29726

AFFECTED FILES
  runners/bookmarks/browser.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> meven wrote in chrome.cpp:55
> Might as well check the returned value for error

If this fails only the icons are affected and the default icon will be 
displayed, this case will be handled in the FetchSqlite class

> meven wrote in fetchsqlite.cpp:42
> Can be removed as well

I would rather do that in another patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29726

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> meven wrote in fetchsqlite.cpp:87
> We might want to reuse database connection as long as the databaseFile did 
> not change

I will do that in a follow up patch :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29726

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex updated this revision to Diff 82790.
alex added a comment.


  Add space

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29726?vs=82789=82790

BRANCH
  avid_unnecessary_copying (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29726

AFFECTED FILES
  runners/bookmarks/browser.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex updated this revision to Diff 82789.
alex retitled this revision from "WIP BookmarksRunner: Change caching 
databases" to "BookmarksRunner: Change caching databases".
alex edited the summary of this revision.
alex edited the test plan for this revision.
alex added a comment.


  Copy chrome files only if they changed

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29726?vs=82772=82789

BRANCH
  avid_unnecessary_copying (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29726

AFFECTED FILES
  runners/bookmarks/browser.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/chromefindprofile.cpp
  runners/bookmarks/browsers/findprofile.h
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h
  runners/bookmarks/tests/testchromebookmarks.cpp

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29726: WIP BookmarksRunner: Change caching databases

[Alexander Lohnau]

alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The copying/updating of the cache has been removed from the FetchSqlite class.
  This allows the browsers to have handle the caching differently.
  
  The firefox sqlite files are only copied if they changed. Before they were 
copied
  for each match session.
  
  The default behaviour for chrome is keept (for now).

TEST PLAN
  Shows icons for results.
  Add new bookmarks, close browser, the new bookmarks should show up with icons.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  avid_unnecessary_copying (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29726

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/firefox.h
  runners/bookmarks/faviconfromblob.cpp
  runners/bookmarks/fetchsqlite.cpp
  runners/bookmarks/fetchsqlite.h

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6f103ebd7b3a: Kill Runner: Remove duplicate function 
calls and refactor (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=82669=82713

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex updated this revision to Diff 82669.
alex added a comment.


  Formatting

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=82666=82669

BRANCH
  arcpatch-D27513_1

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex updated this revision to Diff 82666.
alex added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=81006=82666

BRANCH
  arcpatch-D27513_1

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:63deb6a0125b: Kill Runner: Move config keys to new file 
(authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27576?vs=79224=82462

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

alex added a comment.


  @bruns LGTM?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29326

To: alex, #plasma, ngraham, bruns, broulik, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

[Alexander Lohnau]

alex updated this revision to Diff 81801.
alex added a comment.


  Formatting

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29384?vs=81800=81801

BRANCH
  append_runner_service_file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29384

AFFECTED FILES
  kcms/runners/kcm.cpp

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  This is required for T13079: Make runner KCMs easier to use 
.
  
  Depends on D29201 

TEST PLAN
  Print the constructor arguments from a runner KCM.
  You should see the file name.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  append_runner_service_file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29384

AFFECTED FILES
  kcms/runners/kcm.cpp

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:50c93e3c94e2: Konsole Runner: optimize and simplify 
(authored by alex).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=80485=81735

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik, meven
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

alex updated this revision to Diff 81720.
alex added a comment.


  Anchor in regex, comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29326?vs=81664=81720

BRANCH
  firefox_bookmarks_fix_extraction (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29326

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, ngraham, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> bruns wrote in firefox.cpp:185
> Can this ever be > 1?

For normal use not but if you have multiple versions of Firefox with multiple 
profiles installed and want to launch a profile in a specific version.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29326

To: alex, #plasma, ngraham, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex added a comment.


  In D27098#661482 , @meven wrote:
  
  > So yo won't be able to type "konsole myprofile" but I guess this is just 
fine.
  
  
  Yes you can do it :-)
  F8277455: Screenshot_20200502_081208.png 


REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D27098

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik, meven
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29319: KCM Plasmasearch: Do not intialize runners in config module

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a07b68a0093c: KCM Plasmasearch: Do not intialize runners 
in config module (authored by alex).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29319?vs=81692=81693

REVISION DETAIL
  https://phabricator.kde.org/D29319

AFFECTED FILES
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: alex, #plasma, davidedmundson, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29319: KCM Plasmasearch: Do not intialize runners in config module

[Alexander Lohnau]

alex updated this revision to Diff 81692.
alex added a comment.


  Change username from commit
  
  And thanks for the fast reviews!

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29319?vs=81645=81692

BRANCH
  arcpatch-D29319

REVISION DETAIL
  https://phabricator.kde.org/D29319

AFFECTED FILES
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: alex, #plasma, davidedmundson, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4f3835904ccd: Baloo Runner: Use 
X-Plasma-Request-Actions-Once property in service (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29320?vs=81646=81689

REVISION DETAIL
  https://phabricator.kde.org/D29320

AFFECTED FILES
  runners/baloo/plasma-runner-baloosearch.desktop

To: alex, #plasma, meven, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Is handled in separate patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28196

To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29326: Bookmarks Runner: Fix extraction of firefox profile

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, ngraham, bruns, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  BUG 418526
  The profile group with the value `Default=1` is not always the default 
profile, for example:
  F8192502: BugfixDoc 
  
  This patch originated from D28196 .

TEST PLAN
  If you create a new profile it will be extracted as the default profile
  (but the old value might still be cached see D28619 
).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  firefox_bookmarks_fix_extraction (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29326

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, ngraham, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:768e6a0a229d: BookmarksRunner: Remove caching of profile 
database path (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28619?vs=80580=81651

REVISION DETAIL
  https://phabricator.kde.org/D28619

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e518d45a4d61: BookmarksRunner: Early return and 
formatting (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28473?vs=79086=81648

REVISION DETAIL
  https://phabricator.kde.org/D28473

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Because the actions are always the same the X-Plasma-Request-Actions-Once 
property can be set to true.
  Depends on D29175 .

TEST PLAN
  Still displays action.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  implement_request_actions_once (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29320

AFFECTED FILES
  runners/baloo/plasma-runner-baloosearch.desktop

To: alex, #plasma, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29319: KCM Plasmasearch: Do not intialize runners in config module

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, davidedmundson, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The runners are loaded from the plugin info list 
`Plasma::RunnerManager::listRunnerInfo()`,
  because of that there is no need to create a RunnerManager and initialize the 
plugins.
  
  If you have a lot of additional plugins installed that do a lot of work in 
the init/reloadConfiguration
  method the loading time of the KCM is notable slower.
  
  Additionally the KCMUTILS_VERSION version check has been removed, because
  the KF5_MIN_VERSION is 5.69.

TEST PLAN
  All plugin should show up.
  To check this create a debug which prints the length of the `listRunnerInfo` 
list.
  Then you can verify that the length of the list is equal to the count
  of entries in the plugin selector. For this you can also use the xdotool 
utility:
  `sleep 5;for i in {1..myNum};  do sleep 0.1;xdotool key Down; done`.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  do_not_initialize_runners (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29319

AFFECTED FILES
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: alex, #plasma, davidedmundson, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

alex added a comment.


  @meven and others, may I ship this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex added a comment.


  Ping, regarding the question :-)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26111: Runner: make recentdocument use KActivityStats data

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> recentdocuments.cpp:98
> +QString destUrlString = url.adjusted(QUrl::RemoveFilename).path();
> +if (destUrlString.startsWith(homePath)) {
> +destUrlString = QLatin1String("~") + 
> destUrlString.mid(homePath.length());

You could use KShell:: tildeCollapse here :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex updated this revision to Diff 81006.
alex added a comment.


  Fix small issue from splitting up patch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=76149=81006

BRANCH
  arcpatch-D27513

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c55ffdca923a: BoorkmarksRunner: Set QIcon instead of 
Favicon pointer in BookmarkMatch (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28439?vs=78906=80992

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  Friendly Ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex added a comment.


  Should this(and the following patches) go to a stable branch, because they 
fix a bug that has been reported (418526)?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex updated this revision to Diff 80580.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28619?vs=80578=80580

REVISION DETAIL
  https://phabricator.kde.org/D28619

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex updated this revision to Diff 80578.
alex added a comment.


  Implement requested changes
  
  Thanks, I will do that after the bugfix is done :-)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28619?vs=79466=80578

BRANCH
  arcpatch-D28619

REVISION DETAIL
  https://phabricator.kde.org/D28619

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex added a comment.


  Friendly ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28619

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex added a comment.


  @ngraham and others, may I ship this?

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D27098

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex updated this revision to Diff 80485.
alex added a comment.


  Minor issue when rebasing

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=80484=80485

BRANCH
  arcpatch-D27098

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex updated this revision to Diff 80484.
alex added a comment.


  Rebase

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=79560=80484

BRANCH
  arcpatch-D27098

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28684: Kate Runner: Implement drag and drop for sessions

[Alexander Lohnau]

alex added a comment.


  The usecase is that you can pin the sessions to the taskbar. For instance if 
you have a quicklaunch widget in your panel for your favorite applications.
  
  And yeah I get the point about including this logic into Kate itself.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28684

To: alex, #plasma, #kate, cullmann, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28684: Kate Runner: Implement drag and drop for sessions

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, Kate, cullmann, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  You can now drag the sessions from the runner to the taskbar or the desktop.

TEST PLAN
  Create sessions in kate, start KRunner and search for kate.
  You should be able to attach the session to the taskbar and desktop using 
drag and drop.

REPOSITORY
  R114 Plasma Addons

BRANCH
  kate_runner_mimetype (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28684

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, #plasma, #kate, cullmann, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28663: Kate Runner: Cleanup and improvements

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, Kate, cullmann, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The overview feature has been removed, because this is already
  handled using the dektop actions(forgot to change this in D27109 
).
  Insteadof returning in the match method if the kate sessions are empty,
  the matching gets suspended when the sessions are (re)loaded.
  Additionally the check if the length of the trigger word is smaller than 3 
has been removed
  (and considering that the trigger word `kate` has 4 letters this made not 
that much sense ;-) ).

TEST PLAN
  Should compile and you can search for sessions like `kate `

REPOSITORY
  R114 Plasma Addons

BRANCH
  minor_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28663

AFFECTED FILES
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, #plasma, #kate, cullmann, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex updated this revision to Diff 79560.
alex added a comment.


  Suspend matching if the profiles are empty

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27098?vs=75930=79560

BRANCH
  arcpatch-D27098_1

REVISION DETAIL
  https://phabricator.kde.org/D27098

AFFECTED FILES
  runners/konsoleprofiles/CMakeLists.txt
  runners/konsoleprofiles/konsoleprofiles.cpp
  runners/konsoleprofiles/konsoleprofiles.h

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, 
broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28192: WIP: Refactor dictionary runner

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> sitter wrote in dictionaryrunner_config.cpp:29
> That's an implementation detail though, is it not? From the outside we 
> shouldn't make assumption about what the implementation does unless the 
> documentation says what we can assume.
> Today the baseclass may be useless, in 10 years it may not be.
> 
> Long-winded way of saying that I would leave the base class calls in. If 
> nothing else it's at least better form in terms of API contracts.

That makes sense but one question: The doc says: `...However, if you for some 
reason reimplement it and also are using KConfigXT, you must call this 
function`, does this mean we can assume that the base class is not needed?

PS: In this case it is not very relevant but I would like to understand concept 
for future patches .

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28192

To: alex, broulik, ngraham, sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex added a comment.


  > I would argue for just removing the `grp.writeEntry("dbfile", m_dbFile)` 
line. This keeps the current behavior for the second group, and still solves 
the problem for the first group when there is no config yet. Only users of the 
second group with an existing config have to do a one-time change to their 
config, e.g. resetting/removing the "dbfile" config value.
  
  But what about renaming the dbfile entry, maybe to `alternate_dbfile` ? Then 
the second group of users has to adapt to the changes and
  the first group can be sure that the default profile gets looked up correctly 
(in case the config already exists).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28619

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28619: BookmarksRunner: Remove caching of profile database path

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, bruns, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  As requested in D28196  this patch 
removes the caching feature.
  This caching causes issues when the user has multiple profiles, because the 
cached value
  is not updated as long as the database exists.
  
  Depends on D28473 .

TEST PLAN
  Should compile, no changes to lookup logic made.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarksrunner_firefox_fix_remove_caching (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28619

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, #plasma, bruns, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28544: RecentDocuments Runner: Cleanup and formatting

[Alexander Lohnau]

alex added a comment.


  I didn't knew this patch existed and that it introduces coneptual changes.
  This is just a patch with smaller improvements/cleanup. Because of this I 
suggest waiting for your patch to be merged and than rebasing .

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28544

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28544: RecentDocuments Runner: Cleanup and formatting

[Alexander Lohnau]

alex updated this revision to Diff 79244.
alex added a comment.


  Change import

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28544?vs=79243=79244

BRANCH
  recentdocuments_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28544

AFFECTED FILES
  runners/recentdocuments/recentdocuments.cpp
  runners/recentdocuments/recentdocuments.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28544: RecentDocuments Runner: Cleanup and formatting

[Alexander Lohnau]

alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik, meven, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  - Instead of early returning in the match method if the list of recent 
documents is empty the matching is suspended.
  - The imports have been cleaned up, redundant Q_UNUSED macros have been 
removed and the formatting has been changed.
  - Instead of getting the action using the id, all the actions are returned 
(in this case just the one that is set in the constructor).
  - The unnecessary comparison of the action has been removed and the replace 
method call uses a more performant overload.

TEST PLAN
  Should compile and show the recent documents.
  To test the suspendMatching: Clear the ~/.local/share/RecentDocuments folder, 
restart krunner.
  There should be no results. Then open a file in dolphin and the file shows up 
as a query result in krunner.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  recentdocuments_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28544

AFFECTED FILES
  runners/recentdocuments/recentdocuments.cpp
  runners/recentdocuments/recentdocuments.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

alex added a comment.


  Thanks! 
  
  And may I ship this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

alex updated this revision to Diff 79224.
alex added a comment.


  Fix wrong username

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27576?vs=78137=79224

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

[Alexander Lohnau]

alex added a comment.


  Quick question: I just realized that I committed the second commit with a 
wrong username (this will get rejected when I try to land the patch).
  What is the best way to solve this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex updated this revision to Diff 79086.
alex added a comment.


  Use categories for warnings, cleanup imports

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28473?vs=79083=79086

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex updated this revision to Diff 79083.
alex added a comment.


  Implement warnings

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28473?vs=79019=79083

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex updated this revision to Diff 79019.
alex added a comment.


  Implement requested changes.
  
  PS: I had already tested the migration locally and added it to the test plan.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28473?vs=79017=79019

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28473: BookmarksRunner: Early return and formatting

[Alexander Lohnau]

alex created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  As requested in D28196  this patch 
handles the early return and the formatting.
  Additionally QRegularExpression has been used instead of QRegExp and 
QStringLiteral instead of QString.

TEST PLAN
  Should compile and work exactly as before.
  
  Reviewers bruns broulik #plasma 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarksrunner_firefox_fix_prep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28473

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: alex
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28458: Bugfix ConverterRunner

[Alexander Lohnau]

alex added a comment.


  I don't know why but I cant land this patch(`arc land --preview` looks fine) 
and the previous commits worked:
  `fatal: remote error: service not enabled: /kdeplasma-addons`
  
  I would be thankful if you could commit this.

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28458: Bugfix ConverterRunner

[Alexander Lohnau]

alex created this revision.
alex added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Skip empty parts when splitting the units(D27166: Refactor converter runner 
).
  PS: I had to set the locale to german to reproduce this issue,
  thats why I didn't noticed it in the first place.

TEST PLAN
  Does not display results for queries like 1/2

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28458

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: alex, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  In D28439#638357 , @bruns wrote:
  
  > In D28439#638188 , 
@davidedmundson wrote:
  >
  > > QIcon isn't thread safe.
  >
  >
  > I think this is related to https://phabricator.kde.org/D5889?id=14601 ?
  >
  > I think we are save here, as the QIcon is created from an image stored on 
disk (absolute path to e.g. PNG), not from a theme.
  
  
  Thanks for the response, I was not sure if QIcon being not thread safe was 
meant in general or only for QIcon::fromTheme.
  
  PS: When I said docs I meant the QIcon class docs, but thanks 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  In D28439#638188 , @davidedmundson 
wrote:
  
  > QIcon isn't thread safe.
  
  
  Sorry, I wasn't aware about that and haven't found anything when I had a 
quick look at the docs before submitting this patch.
  
  But if I may ask: Why is this now not thread save but was before?
  Before this patch the icon was created in the BookmarkMatch::asQueryMatch 
method which was called from the secondary thread.
  And with this patch the icon gets created in the Browser::match method which 
gets called from the same thread.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex updated this revision to Diff 78906.
alex added a comment.


  Remove unused includes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28439?vs=78905=78906

BRANCH
  bookmarks_change_icon_handling_in_matches

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex created this revision.
alex added reviewers: apol, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Before: A pointer to the favicon gets written in the BookmarkMatch and using 
this pointer the icon gets created when the Plasma::QueryMatch gets created.
  Now: Using the favicon pointer the icon gets created and written to the 
BookmarkMatch, when the QueryMatch is created the icon value is read.
  
  This makes the code easier to unserstand and the BookmarkMatch is independent 
of the Favicon class.
  
  Depends on D28196 , because this bugfix 
is needed for my config.

TEST PLAN
  Should compile and display icons.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarks_change_icon_handling_in_matches

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28192: WIP: Refactor dictionary runner

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> sitter wrote in dictionaryrunner.cpp:90
> You could simply use the lastPartOfSpeech I would guess. From what I've seen 
> and what Kai tells me you really only need to set setData if you want to 
> implement actions (`::actionsForMatch`) and need to carry some information to 
> figure out what the match result was or what its actions ought to be, or 
> runability (`::run`). The latter in fact only appears to need id() so it can 
> persistently track how often a given thing was run and thus give it higher 
> relevance if the user chooses that option a lot.
> That is to say: the runner as-is wouldn't benefit from setData at all.

The current behavior is that KRunner closes when a match is selected.
But if you set the data, for instance:
`match.setData(QStringLiteral("Hello There!"));`
The text `Hello There!` will show up in KRunner (like in the converter runner).
The run method won't be called, because the match type is set to 
InformationalMatch.

So the runner would benefit from setData, or am I missing something?

> sitter wrote in dictionaryrunner_config.cpp:24
> I wouldn't remove this without good reason.
> 
> Without this blocking load() call the UI gets set up and shown and only then 
> the data gets loaded in a kinda async fashion. That is cool, but only iff the 
> KCM is actually equipped for handling the intermediate time frame with a "I'm 
> still loading" UI state (busyindicator or something; or is completely empty 
> at least). If that is not the case then relying on async load will result in 
> the KCM appearing in an incomplete state until the load() is run which may 
> take a noticeable amount of time depending on system performance. So, when 
> load() is doing trivial/cheap work it makes a whole lot of sense to call it 
> blockingly form the ctor.

Thanks for the detailed explanation.
Calling the method twice seemed weird to me but  as you have said the load 
method does only cheap work and it should not matter that much.

> sitter wrote in dictionaryrunner_config.cpp:29
> Could you elaborate on why you removed the baseclass calls for 
> load/save/defaults please?

The baseclass implementations for these methods handle the KConfigDialogManager 
widgets and the corresponding changed signals.
I removed them, because the KConfigDialogManager class is not used in this kcm 
and the signals are manually handled.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28192

To: alex, broulik, ngraham, sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex added a comment.


  Friendly Ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27513

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added a comment.


  Sh**t, should I make a new patch to fix this?
  
  And sorry ...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:5e760a0586bb: Refactor foreach, use Qt5 signal syntax, 
remove unnecessary method call (authored by davidedmundson, committed by alex).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=78368=78371

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added a comment.


  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added a comment.


  Small issue: Currently this patch can't be applied (from the master branch)  
because in R114:47381a65debe01a0a015e1aa423cbb78af649648 
 the 
line:
  `QStringList terms = query.split(QLatin1Char(' '), QString::SkipEmptyParts);` 
got changed.
  I don't know how to resolve this conflict and would be thankful for help :-).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dceb791c0779: WebShortcuts Runner: Refactor foreach, 
remove unnecessary method (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27566?vs=78338=78339

REVISION DETAIL
  https://phabricator.kde.org/D27566

AFFECTED FILES
  runners/webshortcuts/webshortcutrunner.cpp
  runners/webshortcuts/webshortcutrunner.h

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Alexander Lohnau]

alex updated this revision to Diff 78338.
alex added a comment.


  Coding style: put space before {

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27566?vs=76144=78338

BRANCH
  arcpatch-D27566

REVISION DETAIL
  https://phabricator.kde.org/D27566

AFFECTED FILES
  runners/webshortcuts/webshortcutrunner.cpp
  runners/webshortcuts/webshortcutrunner.h

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

[Alexander Lohnau]

alex added a comment.


  Ping @broulik :-)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  webshortcuts_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27566

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26799: Apply KDE coding style, minor optimizations

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Abandoning this, because there have been a few patches to the same kcm and 
this is mostly formatting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26799

To: alex, ngraham, meven, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex updated this revision to Diff 78336.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=78335=78336

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex updated this revision to Diff 78335.
alex added a comment.


  Minor improvements
  
  I had another look at the project and changed some other things:
  
  - optimize some overloads with QStringLiteral/QLatin1String
  - rename loaddata to loadData
  - remove the unnecessary check for the action in the run method
  - reuse the result of config()
  - make sure that the trigger word can only be required if it is not empty

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74848=78335

BRANCH
  arcpatch-D27070

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  CMakeLists.txt
  runners/converter/CMakeLists.txt
  runners/converter/autotests/CMakeLists.txt
  runners/converter/autotests/converterrunnertest.cpp
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck.h
  runners/spellchecker/spellcheck_config.cpp

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27166: Refactor converter runner

[Alexander Lohnau]

alex updated this revision to Diff 78281.
alex added a comment.


  Allow +/- before values, add testcase
  
  Small detail I forgot to add and a testcase for this.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27166?vs=78121=78281

BRANCH
  arcpatch-D27166_2

REVISION DETAIL
  https://phabricator.kde.org/D27166

AFFECTED FILES
  CMakeLists.txt
  runners/converter/CMakeLists.txt
  runners/converter/autotests/CMakeLists.txt
  runners/converter/autotests/converterrunnertest.cpp
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h

To: alex, broulik, ngraham, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Konsole Runner: optimize and simplify

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> alex wrote in konsoleprofiles.cpp:155
> It has been refactored and is now in line 132/188:
> `match.setRelevance((float) term.length() / (float) 
> data.displayName.length());`

Ups, 118 not 188

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26904: Use Qt5 syntax for signal, rename files

[Alexander Lohnau]

alex abandoned this revision.
alex added a comment.


  Abandoning this because of D27503: [KCM Spellchecking] port to 
KPropertySkeletonItem 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26904

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> apol wrote in konsoleprofiles.cpp:155
> Why has the relevance code been removed?

It has been refactored and is now in line 132/188:
`match.setRelevance((float) term.length() / (float) data.displayName.length());`

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Alexander Lohnau]

alex added a comment.


  Ping :-)

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart