D29570: Fix some alignments

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29570

To: niccolove, #vdg, #plasma
Cc: abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

[Andres Betts]

abetts added a comment.


  +1 from me!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

[Andres Betts]

abetts added a comment.


  I love this idea. I would request to keep the drag behavior and follow up 
with a second ticket to propose a change in the drag behavior for the panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29057: Introduce PlaceholderMessage component

[Andres Betts]

abetts added a comment.


  Look cool!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D28461: In sidebar mode show if a module is in default state or not

[Andres Betts]

abetts added a comment.


  If I am understanding correctly, this patch adds icons in the kcm list to 
indicate changes you can revert by going to the kcm. Basically, default 
settings have changed and now you have the possibility to see that changes have 
been made. I am not sure that I like the implementation. I have some questions.
  
  What will you do when all of them are changed in some way? Will the entire 
kcm list show an icon indicating change? If you think about it, KDE is the DE 
of changes and options. I feel all of these are going to show some kind of 
change, that could be overwhelming. At the end of the day, is it necessary? 
Wouldn't this be something that probably works best by having it in the 
reset/defaults button?
  
  Also, these icons indicate change, if you click on the item and then land in 
a kcm that doesn't present more clues as to what changed, then you are left 
with the default action to click defaults or reset on the kcm anyway. There 
doesn't seem to be much more value there.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Andres Betts]

abetts added a comment.


  I would suggest a circular button instead of square.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg, #plasma, hein, broulik
Cc: abetts, hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Andres Betts]

abetts accepted this revision.
abetts added a comment.


  Love it! Move forward!

REPOSITORY
  R31 Breeze

BRANCH
  draw_small_arrow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts
Cc: abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

[Andres Betts]

abetts added a comment.


  Suggestions:
  
  "To reduce eye strain, Night Color makes the colors on the screen warmer at 
the time of your choosing"
  
  Change to:
  
  "Night Color makes the screen colors warmer to reduce eye strain"
  
  "Night color temperature"
  
  Change to:
  
  "Temperature"
  
  Activation
  
  - Sunset/sunrise at current location
  - Sunset/sunrise at manual location
  - Manual times
  - Always on
  
  Change to:
  
  Time:
  
  - Sunset to sunrise at your location
  - Sunset to sunrise at different location
  - Custom time
  - Always on
  
  Instead of having latitude/longitude + Detect Location, swap to Detect 
Location + Lat/long after.
  
  "Color change begins at XX:XX"
  
  Change to:
  
  Night color begins at XX;XX
  
  Color fully changed, might not be necessary? Too much detail?
  
  "Color begins changing back at XX:XX"
  
  Change to
  
  Night color ends XX:XX
  
  Normal coloration restored by XX:XX, might be too much info.
  
  Since the color changes gradually, maybe we could add an option to 
enable/disable that function? Something like
  
  [X] Gradual activation
  [X] Change colors gradually

REPOSITORY
  R119 Plasma Desktop

BRANCH
  polish-nightcolor-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25920

To: ngraham, #vdg, #plasma, davidedmundson, romangg
Cc: abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D21860: Set a font for gtk applications in the fonts kcm

[Andres Betts]

abetts added a comment.


  How does this look?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #vdg, #plasma
Cc: abetts, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D21566: Improve label for Disk Monitor widget

[Andres Betts]

abetts added a comment.


  +1 on visuals

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21566

To: ngraham, #plasma, #vdg
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21701: [kcm-colors] Do not ship any additional color schemes

[Andres Betts]

abetts added a comment.


  +1 on principle. Many of these color themes are old and unmaintained.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21701

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, nicolasfella, plasma-devel, LeGast00n, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

[Andres Betts]

abetts added a comment.


  +1
  
  We might need to add some padding so the button frame doesn't overlay content 
on the background

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-toolbuttons-in-popup-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21629

To: ngraham, #plasma, #vdg, ndavis, filipf
Cc: abetts, filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D21610: Redesign Advanced tab

[Andres Betts]

abetts added a comment.


  +1 on visuals

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21471: [Notifications] Remove space between pause/stop and details button

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21471

To: broulik, #plasma, #vdg, hein, filipf
Cc: abetts, felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21341: Call KRunner KRunner

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21341

To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21193

To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21194: [Holidays plugin] Port partially to QQC2 and modernize UI

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21194

To: ngraham, #vdg, #plasma, ndavis
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D21105

To: ngraham, #vdg, #plasma, drosca
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-pressed-state-to-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21062

To: filipf, #vdg, #plasma, ngraham, davidedmundson
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Andres Betts]

abetts added a comment.


  Love it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20969: [potd] Modernize configuration settings

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20969

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20902: Add SDDM theme login load feedback

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-sddm-theme-login-load-feedback (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20902

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456936 , @ngraham wrote:
  
  > In D20851#456932 , @abetts wrote:
  >
  > > I agree with this too. Do you think it would be too weird of other 
methods are used? For example:
  > >
  > > - Use a more legible font that is independent from system font
  > > - Use current system font 1 or 2 points bigger
  >
  >
  > I don't think those would help. A part of the problem is that the label 
isn't on top; other things are on top of it. Just moving it to the top would 
help, The other part of the problem is that we need some way to ensure that the 
text has contrast with its background. It's a variant of the exact same problem 
we always have when we have text or icons floating on top of an arbitrary 
background. Every time we encounter this, the only feasible solution we have 
ever found is to give the text a background or a shadow.
  
  
  Can we try a non-blurred shadow instead? One that is offset by 1 px? that 
might help too. I think when we use blurred, it gets messy at those sizes.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456931 , @ngraham wrote:
  
  > Well, I find it almost impossible to read the text with the status quo 
version when there are a bunch of window outlines. In the first screenshot you 
can see that the number "1" is actually almost invisible. I'm open to 
suggestions for alternative ways to improve this.
  
  
  I agree with this too. Do you think it would be too weird of other methods 
are used? For example:
  
  - Use a more legible font that is independent from system font
  - Use current system font 1 or 2 points bigger

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20851: [Pager] Improve label legibility

[Andres Betts]

abetts added a comment.


  In D20851#456903 , @ndavis wrote:
  
  > To me, the white text with the shadows doesn't really improve legibility 
and just looks "off". For some reason, shadow behind small text messes with my 
eyes and makes it harder to focus on the actual text.
  
  
  I agree.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20851

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20533

To: meven, #plasma, ngraham, broulik, #vdg
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

[Andres Betts]

abetts added a comment.


  Love it!

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D20549

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D20569: RFC: Use more compact OSD

[Andres Betts]

abetts added a comment.


  I like the way that this is going. I also like the way that mobile does 
volume. Very understated. I think this is going the right direction.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, davidedmundson, hein, Codezela, Fuchs, filipf, zzag, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20407: [Folder View] Improve label crispness

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-folder-view-label-crispness (branched from Plasma/5.12)

REVISION DETAIL
  https://phabricator.kde.org/D20407

To: ngraham, fvogt, #plasma, hein, filipf
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham
Cc: abetts, hpereiradacosta, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20313: Hook up the main form layout with child form layouts

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20313

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D20266: Add new notification plasmoid

[Andres Betts]

abetts added a comment.


  In D20266#443993 , @ngraham wrote:
  
  > This UI is fantastic. A huge improvement over the status quo.
  >
  > It seems like there's no Do Not Disturb mode that stays on until manually 
turned off though?
  
  
  I was thinking too that where the label "Do not disturb" is located, when you 
turn on any of the time features, it could be like this
  
  [ ] Do not disturb "12 min remaining"
  [ ] Do not disturb "until disabled"
  
  Maybe having Do Not Disturb for a custom amount of time would also be helpful 
in case none of the options fit the user?
  
  Just tossing ideas

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20266

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  beautiful-vertical-spacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20257

To: filipf, hein, mart, #plasma, ngraham, davidedmundson
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg, ngraham
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20155: [SpinBox] Improve mouse wheel behavior

[Andres Betts]

abetts added a comment.


  Can you add a before/after video maybe? Just to see the changes

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D20155

To: broulik, #plasma
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19994: Add microphone indicator

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19994

To: broulik, #plasma, #vdg, drosca
Cc: abetts, filipf, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D12055: Remove border around menubars

[Andres Betts]

abetts added a comment.


  +1 for visual improvement

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19752: [Splash KCM] Use InlineMessage for testing error

[Andres Betts]

abetts added a comment.


  Could the message include some hints of what failed? Maybe the theme name? 
Something like:
  
  "Failed to test Adwaita splash screen, please check theme"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19752

To: broulik, #plasma, #vdg, filipf
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19802: [comic] Modernize configuration windows

[Andres Betts]

abetts added a comment.


  > You mean "General", "Appearance" etc. right? Yeah that happens when windows 
are stretched horizontally, but the window wouldn't be much narrower IRL tbh. 
Kirigami's FormLayout is center aligned and the category's title always remains 
left aligned. They're pretty far apart in full-screen:
  > 
  > F6704320: image.png 
  
  Awesome! Thank you, just wanted to be sure. +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: abetts, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19802: [comic] Modernize configuration windows

[Andres Betts]

abetts added a comment.


  The title labels appear to be very far from the content. Is that just the 
size on the images or does it actually look very far when the config screen is 
full size?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19802

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: abetts, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D19096: Improvements for long label items in Application Dashboard

[Andres Betts]

abetts added a comment.


  Does this patch only concern itself with the icons and labels below them or 
also the categories on the right? If so, it feels like the category labels on 
the right are huge in comparison to the icon labels. Maybe those also need some 
touch up?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg, broulik
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

[Andres Betts]

abetts added a comment.


  +1 visually

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19873

To: filipf, #plasma, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19825: Improve update states' UI

[Andres Betts]

abetts added a comment.


  +1
  
  Maybe the icon can be smaller, but in principle, yes!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19825

To: ngraham, apol, #vdg, #discover_software_store
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19747

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  While it makes sense to change it to the new form, the alignment feels odd 
because there are just a couple of items in the kcm. I wonder if having a title 
label would help ground the elements on the page.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-quickshare-config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19664

To: filipf, #vdg, #plasma, apol, ngraham
Cc: abetts, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19669

To: filipf, #vdg, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Andres Betts]

abetts added a comment.


  In D19687#429709 , @ngraham wrote:
  
  > In D19687#429700 , @abetts wrote:
  >
  > > One thing that might work is the behavior that google photos uses. When 
you select an item, the item shrinks by about 20% and a blue selection box 
appears around the image. It just makes it more noticeable that the item has 
been selected.
  >
  >
  > Since all items are selected by default here, I'm not sure that behavior 
would be the most appropriate.
  
  
  Oh I thought it was a selection. Could the checkbox be located at a top 
corner sticking out a bit?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Andres Betts]

abetts added a comment.


  In D19687#429373 , @davidre wrote:
  
  > In D19687#429332 , @ngraham 
wrote:
  >
  > > Also, this has nothing to do with your patch specifically, but seeing so 
many checkesd checkboxes in the slideshow's preview pane makes me realize just 
how much I want the Breeze style checkbox to actually look like a checkbox, 
with a checkmark instead of just a filled in roundrect.
  >
  >
  > Yeah also not a fan of that. I had the idea to give it maybe a small grey 
rectangle like the action icons as the empty checkboxes or the blue blob can be 
hard to spot. See the empty checkbox in the last row or the checkbox on Cascade 
in the screenshot.
  
  
  One thing that might work is the behavior that google photos uses. When you 
select an item, the item shrinks by about 20% and a blue selection box appears 
around the image. It just makes it more noticeable that the item has been 
selected.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

[Andres Betts]

abetts added a comment.


  How would the folders on the folder list on the left be removed as sources?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19687

To: davidre, #plasma, #vdg, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19670

To: filipf, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

[Andres Betts]

abetts added a comment.


  Is there any way that we can make the preview window have more right and left 
margins? When presented like this, it seems like it is actually another module 
that users interact with.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19651

To: GB_2, #plasma, #vdg
Cc: abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

[Andres Betts]

abetts added a comment.


  Would it be possible for the header labels to be a bit different? Not sure 
what would look best, bold, italics, a lighter shade of gray
  
  F6674017: Screen Shot 2019-03-08 at 8.49.54 AM.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19606

To: ngraham, #plasma, #vdg, ndavis, hein
Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

[Andres Betts]

abetts added a comment.


  Can it be more descriptive? Using two words might help it be extra clear what 
the button is about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19472

To: ngraham, #plasma, hein, davidedmundson, rooty
Cc: abetts, broulik, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19605

To: ndavis, #vdg, #breeze, zzag, davidedmundson
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Andres Betts]

abetts added a comment.


  +1 on visuals

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

[Andres Betts]

abetts added a comment.


  +1 on looks

REPOSITORY
  R120 Plasma Workspace

BRANCH
  splash-screen-uses-next-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19373

To: ngraham, #vdg, #plasma, rooty
Cc: abetts, davidedmundson, filipf, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19467: [colors-kcm] Fix blurry previews

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19315: Use ActionTextField to implement the searchField in system settings

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19315

To: ognarb, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Andres Betts]

abetts added a comment.


  In D19214#424110 , @rooty wrote:
  
  > In D19214#424106 , @ngraham 
wrote:
  >
  > > Hmm, the Kirigami text field doesn't look like that in an app. Must be 
some weird SDDM environment thing?
  > >
  > > Either way, let's fix the height issue *somehow*. :)
  >
  >
  > It's sorta ugly but what's tripping me up is... why doesn't it get smaller 
if i set pointSize to 1 (and gets bigger if I set it to, say, 32)
  
  
  Would putting the > button "inside" the password field make it look better?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: abetts, ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config-category-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19275

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Andres Betts]

abetts added a comment.


  In D19372#421386 , @rooty wrote:
  
  > In D19372#421381 , 
@davidedmundson wrote:
  >
  > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There 
was a whole Carousel system.
  >
  >
  > I'm not sold on this idea :D I'm just worried it'll come out tacky
  
  
  I would agree, if there is no visual work using effects to ease the 
transitions between states, then it looks pretty unrefined. Dave, is there 
anything that would help here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: davidedmundson, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Andres Betts]

abetts added a comment.


  In D19230#421336 , @ngraham wrote:
  
  > Sounds good. What should the string be? "Use region's default setting"?
  >
  > F6643429: Screenshot_20190227_114945.png 

  
  
  Yes, I am with @ndavis to use Regio

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Andres Betts]

abetts added a comment.


  In D19230#421229 , @ndavis wrote:
  
  > In D19230#421215 , @abetts wrote:
  >
  > > Do you think that "locale" is a very specific term? Could it be different?
  >
  >
  > The alternative would be "region", which is the term we use in the related 
settings KCM.F6643106: Screenshot_20190227_104128.png 

  
  
  That seems right to me

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Andres Betts]

abetts added a comment.


  Do you think that "locale" is a very specific term? Could it be different?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19379: [sddm-theme] Add a bottom panel

[Andres Betts]

abetts added a comment.


  Back in the day, when I proposed changes to these elements, I put them on the 
center. People said that it looked crowded, boring, etc... However, my 
reasoning was because the selections are too far in the corners. It wasn't a 
problem with smaller older screens but it would become a problem with 
ultra-wide, 4K monitors, etc. The options would be too far from the center 
where the user is. I don't know that the bar at the bottom is a good solution 
overall. But it does bring attention to the area.
  
  I can help with defining how they can look in the center?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19379

To: filipf, #vdg, #plasma, ngraham, rooty
Cc: abetts, broulik, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19185

To: ngraham, #vdg, #plasma, filipf
Cc: abetts, filipf, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19372: [sddm-theme] Enlarge user avatar in focus

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19372

To: rooty, #vdg, ngraham
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Andres Betts]

abetts added a comment.


  Can the text to the right of the list, "Trusted" be a different color and 
maybe a smaller font? When using the same font, color and size as the device 
name, it seems that they are the same thing. One is device name and the other 
is device status. I am just wondering if we could differentiate them visually.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, 
fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, 
ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Andres Betts]

abetts added a comment.


  I would probably add just a bit of left and right padding to the time as 
well. LGTM

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19173: [InlineMessage] Tint icon and text color

[Andres Betts]

abetts added a comment.


  Love the color change. More harmonious.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19173

To: filipf, #kirigami, #vdg, ngraham
Cc: abetts, mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D16886: [windowswitcher] Implement keyboard navigation

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: abetts, szafar, davidedmundson, Zren, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19077: WIP: Fix long labels not being wrapped

[Andres Betts]

abetts added a comment.


  Just added some visual adjustments (mockup)
  
  F6620598: Screen Shot 2019-02-17 at 4.56.46 PM.png 


REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19013

To: vpilo, #plasma, broulik, drosca
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Andres Betts]

abetts added subscribers: ngraham, fabianr, abetts.
abetts added a comment.


  I believe the list of devices should be in a white box. There should also be 
a couple of controls at the bottom right of the box containing the devices. 
@ngraham Is that right? @fabianr ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil
Cc: abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19036: [notifications] Lift up notification content if one line of body text droops

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19036

To: rooty, #plasma, #vdg
Cc: abetts, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Andres Betts]

abetts added a comment.


  In D18893#412372 , @rooty wrote:
  
  > Hey guys so I opened up another diff to deal with the icons specifically: 
D19020 
  >
  > > For this image with the dots and type, shouldn't that be centered and not 
touch the edge of the circle?
  >
  > That works too, but the idea here was to make it seem like it has more 
depth. Not sure though. Still open to any and all suggestions
  
  
  I would suggest to keep elements centered just to follow the general logic of 
the rest of the icons.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Andres Betts]

abetts added a comment.


  In D18893#412025 , @rooty wrote:
  
  > Thanks for accepting the patch!
  >  Should I land this and deal with the icons in another diff? Because this 
is in "plasma-workspace" and the icons are in "plasma-framework"?
  >
  > Then again, I might have to change the code here (the new icons have 
different labels).
  >  This is what I've got so far:
  >  F6614662: image.png 
  
  
  For this image with the dots and type, shouldn't that be centered and not 
touch the edge of the circle?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D18893

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf, davidedmundson, ngraham
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  login-prompt-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18893

To: rooty, #vdg, #plasma, filipf
Cc: abetts, davidedmundson, ngraham, filipf, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18779: Better window title display

[Andres Betts]

abetts added a comment.


  Love it!

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D18779

To: broulik, #plasma, #vdg, tcanabrava
Cc: abetts, rooty, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18681: Update Breeze Look and Feel theme previews

[Andres Betts]

abetts added a comment.


  Maybe I am asking for a lot... but could these be animated and show what the 
splash screen does? Maybe a gif animation on hover?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  update-breeze-lookandfeel-theme-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18681

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Andres Betts]

abetts added a comment.


  Does the hug allow for just a search button and a non-always visible search 
field?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18519: [KColorSchemeEditor] Turn Save button into Save As

[Andres Betts]

abetts added a comment.


  I guess the way that the new theme is created through the ui is also 
something to consider. Maybe, let's think of a cleaner theme editing process 
and then the save button will be easier to understand?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18519

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Andres Betts]

abetts added a comment.


  In D18419#400112 , @ngraham wrote:
  
  > That's good to hear! I'm glad we're on the same page. Let's make sure our 
plans in T8871: Systematic KCM reorganisation 
 reflect the consensus of a diverse set of 
opinions so we don't wind up needing to re-do it in the future.
  
  
  Great! :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Andres Betts]

abetts added a comment.


  In D18419#399881 , @abetts wrote:
  
  > In D18419#397699 , @ngraham 
wrote:
  >
  > > I'm trying to get a sense of when we should do this.
  > >
  > > 1. Improve text on existing QWidgets KCMs to conform to the HIG
  > > 2. Re-arrange weird layouts for existing QWidgets KCMs to conform to the 
HIG
  > > 3. Port all QWidgets KCMs to QML
  > > 4. Merge various KCMs together (e.g. Icons and Emoticons, Widget Style 
and GNOME Applications Style (GTK))
  > >
  > >   Between which items should this re-org be located?
  >
  >
  > I my mind, it would be #5 since we know that through the porting and 
improvements we make to the kcms, we end up making them look vastly different, 
in some cases. This makes it so that a KCM doesn't really belong to the same 
category anymore. We also discovered that we have a few KCMs with just a couple 
of options that would make them move to a new category. That would change the 
organization again.
  
  
  You're debating me on something I am not suggesting. I am not saying "stop 
reorganization, do it only just once". I am saying, let's take a piecemeal 
approach, little by little (which is our only option, really) and let users be 
eased into a new organization. I hope that's clear. What I am also saying is 
that it is best to take this reorganization piecemeal approach right now and 
come to a conclusion with it. One that can last for years. In essence, take the 
step by step reorg now. However, once we complete that work, we should hold off 
from reorganizations afterwards.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Andres Betts]

abetts added a comment.


  In D18419#397699 , @ngraham wrote:
  
  > I'm trying to get a sense of when we should do this.
  >
  > 1. Improve text on existing QWidgets KCMs to conform to the HIG
  > 2. Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG
  > 3. Port all QWidgets KCMs to QML
  > 4. Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and 
GNOME Applications Style (GTK))
  >
  >   Between which items should this re-org be located?
  
  
  I my mind, it would be #5 since we know that through the porting and 
improvements we make to the kcms, we end up making them look vastly different, 
in some cases. This makes it so that a KCM doesn't really belong to the same 
category anymore. We also discovered that we have a few KCMs with just a couple 
of options that would make them move to a new category. That would change the 
organization again.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Andres Betts]

abetts added a comment.


  Do you prefer a right click over a settings or 3-dot button?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12278: [Colors KCM] Port to new design

[Andres Betts]

abetts added a comment.


  It's amazing to see all the work that was done here. Thanks everyone for 
working together on this. I hope our users see this new KCM as a step forward.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg, davidedmundson
Cc: GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol

D18419: Adjust some KCMs to implement new Appearance section layout

[Andres Betts]

abetts added a comment.


  I am not opposed to a reorg as long as it doesn't touch the KCMs, but be 
aware that you "might" have to reorg again as we port KCMs. So, do you prefer 
to do it, potentially twice, or just once?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18401: [Look And Feel KCM] Use new icon

[Andres Betts]

abetts added a comment.


  +1 <3

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18401

To: ngraham, #vdg
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D16212: [Device Notifier] Add a button to unmount all devices

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham, broulik
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18255: Improve up/down display for Monitor widgets

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18255

To: ngraham, #plasma, #vdg
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18239: login screen with same behavior as lockscreen

[Andres Betts]

abetts added a comment.


  I agree with @ngraham here. I feel that it is not always wise to apply the 
same UX everywhere. It might feel right but there are user experiences that are 
common place for other systems and it could become distracting for the user to 
expect one thing and such thing behaves too much outside of that expectation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18239

To: mart, #plasma, #vdg, ngraham
Cc: abetts, ngraham, davidedmundson, plasma-devel, sukalyanbanga, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18206: Improve the Look and Feel KCM

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart