D8232: Add option to center shadow

[Andrew Lake]

alake added a comment.


  Ok, I agree now that there shouldn't be an option. I think it is fair to say 
that the contrast on the left side of overlapping windows could be improved. 
The proposed compromise solution actually looks decent too and it keeps the 
lighting reasonably consistent. The VDG and Hugo are discussing. Oh and in case 
it is sometimes forgotten, thanks for submitting the patch. :-)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, 
davidedmundson, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D8232: Add option to center shadow

[Andrew Lake]

alake added a comment.


  +1 for the centered shadow proposal as an option.
  
  I'd hesitate for this to be the default since to do it well, in my opinion, 
it'd take a complete lighting (re)design effort on Breeze to help ensure 
visually consistency.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D8232

To: rpelorosso, #breeze, #vdg, hpereiradacosta
Cc: alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson, mart, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D7694: Update app icons to match icon design guidelines

[Andrew Lake]

alake created this revision.
alake added a project: MyCroft Integration.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Simple update of the main app icons to follow icon design guidelines for 
margins. Also simplified svg file.F3898953: mycroft-plasma-appicon.svg 

  
  It's been a while since I used Phabricator so I hope I'm doing this right.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D7694

AFFECTED FILES
  image/breeze-dark/apps/16/mycroft-plasma-appicon.svg
  image/breeze-dark/apps/32/mycroft-plasma-appicon.svg
  image/breeze/apps/16/mycroft-plasma-appicon.svg
  image/breeze/apps/32/mycroft-plasma-appicon.svg
  plasmoid/contents/images/mycroft-plasma-appicon.svg

To: alake, #mycroft_integration
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92078
---


Ship it!




Ship It!

- Andrew Lake


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126953: Remove Theme Details KCM

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/#review91886
---


Ship it!




+1 from me!

- Andrew Lake


On Feb. 1, 2016, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126953/
> ---
> 
> (Updated Feb. 1, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This removes the theme editor thing in the Desktop Theme KCM.
> 
> Most settings in there are either broken or useless nowadays.
> 
> The only setting I would miss is different Analog Clock faces which could be 
> done in the Analog Clock directly. What I am missing in general is a custom 
> Panel color/texture or something like that which we don't have in here anyway.
> 
> 
> Diffs
> -
> 
>   kcms/desktoptheme/CMakeLists.txt 6168686 
>   kcms/desktoptheme/DesktopTheme.ui f57cdf8 
>   kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
>   kcms/desktoptheme/desktopthemedetails.h 475d893 
>   kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
>   kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
>   kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
>   kcms/desktoptheme/kcmdesktoptheme.h ac87862 
>   kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
>   kcms/desktoptheme/thememodel.cpp bb5bb94 
> 
> Diff: https://git.reviewboard.kde.org/r/126953/diff/
> 
> 
> Testing
> ---
> 
> Tab gone.
> 
> While at it I also replaced the status label with a proper KMessageWidget
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
---



Nice improvement. If the week numbers look ok then +1 from me.

- Andrew Lake


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

[Andrew Lake]

> On Oct. 26, 2015, 2:22 a.m., Andrew Lake wrote:
> > Proper close button is welcome. Generally looks good to me, though I do 
> > think the close button works better with the consistency of the normal 
> > background rather than the randomness of the thumbnail as a background. 
> > Other than that, thumbs up from me!
> 
> Martin Gräßlin wrote:
> hey that's not fair. For years there was complaint that we cannot put the 
> close button on the window. Now finally we made that possible and what? Move 
> close button outside again.
> 
> /me grumbles about waisted time and that I don't want to invest the time 
> to make that work on Wayland as it's really, really a difficult task.
> 
> Kai Uwe Broulik wrote:
> Also note that depending on the window geometry the thumbnail would get 
> wider eventually partially or entirely leaking behind the close button. The 
> partial case was what I wanted to avoid.
> 
> Marco Martin wrote:
> with the button outside the thumbnail, how would it look when there are 
> more thumbnails in the tooltip due to grouped windows?

I'm not sure I remember which complaint was "we cannot put the close button on 
the window" and what discussion resulted in putting it on the window, but sorry 
if my observation resulted betrays some inconsistency. If we want to leave the 
close button on the the thumbnail itself, then all I'd suggest is that we 
provide some kind of consistent background for the thing to sit on. As it is, I 
think the noise of the thumbnail background makes the button difficult to 
distinguish. Maybe moving it outside is not the right solution for that. And 
maybe that suggestion conflicts with something we already provided guidance on. 
I'd simply request we please assume any inconsistency in what I've said is 
because of my awful memory, not because I'm running some consistency-checker 
against what I previously said to screw over the hard work anyone has done.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87395
---


On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> -------
> 
> (Updated Oct. 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87395
---


Proper close button is welcome. Generally looks good to me, though I do think 
the close button works better with the consistency of the normal background 
rather than the randomness of the thumbnail as a background. Other than that, 
thumbs up from me!

- Andrew Lake


On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> ---
> 
> (Updated Oct. 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 350705
> https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I just found this patch I made a while ago. This turns the handmade close 
> button into a regular ToolButton (which is only shown when hovering) with a 
> proper size. Also, the button is always in the top right corner of the 
> *thumbnail* rather than the dialog
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> 
> File Attachments
> 
> 
> New close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86927
---


Is it fair to interpret this as a possible path to reducing the duplication of 
icons between the main icon theme and the plasma theme?

- Andrew Lake


On Oct. 16, 2015, 2:48 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 352506] Breeze High Contrast color scheme has defaults that are bad for people with low contrast sensitivity vision

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=352506

Andrew Lake <jamboar...@gmail.com> changed:

   What|Removed |Added

 CC||jamboar...@gmail.com
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Andrew Lake <jamboar...@gmail.com> ---
Thanks for reporting Erica. We'll work to improve that color scheme and post
candidate color schemes here that we hope you might help us test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Desktop Theme Details KCM

[Andrew Lake]

My own opinion, having written the original code, is that we should simply
remove it altogether. I consider it an extreme corner case for
customization that, at best, belongs in a Plasma theme creation tool, not
system settings.

Andrew

On Fri, Aug 21, 2015, 1:40 PM Kai Uwe Broulik k...@privat.broulik.de wrote:

 Hi all,

 I was just looking at the Desktop Theme Details KCM (System Settings →
 Workspace Design → Details) and figured it's of not much use anymore. Imho
 the
 way the interaction with it worked wasn't particularly good to begin with,
 suddenly creating a (Custom) theme when you edited another one, but the
 one
 you selected in the list above isn't neccessarily the theme you're using,
 etc.

 So, let's look at the options it offers:

 * Color Scheme: Kinda works but given it also influences the background
 contrast, conflicts with the dialog/panel backgrounds
 * Panel background: Doesn't always work (panel stays the same somtimes)
 * Kickoff: No effect? What should it change anyway, it's up to the applet
 (it
 changes dialogs/kickoff, if that is even used anymore..)
 * Task items: Completely screws up the task manager if I touch that
 * Widget background: Seems okay
 * Translucent background: also okay
 * Dialog background: doesn't do anything
 * Analog Clock: works, seems kinda valid usecase; though all other DEs I've
 seen just provide that in the clock itself
 * Sticky Notes: Dunno, should work, but then I haven't seen a theme with
 different sticky notes - we still use the Oxygen ones even now :) One
 thing I
 would like to see is a default color for the notes, so a dark theme can
 have
 black notes by default
 * Tooltip: doesn't do anything
 * Pager: seems to work
 * Run dialog: Given KRunner is a regular dialog nowadays doesn't do
 anything
 * Logout dialog: Provided by LNF theme anyway
 * Icons: Kinda works, mostly seems to affect only system tray, as most
 icons
 are provided by the overall icon theme

 What should we do with this thing?

 PS: Air and even more Oxygen Plasma theme are pretty broken, we should
 either
 fix them (especially task manager, potentially revert the follow theme
 color
 stuff to provide a more 4.x-esque look) or kill them.
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Mobile Vision, intended personas meeting notes

[Andrew Lake]

Ten thumbs up! (just need 4 more people to get to ten thumbs)

So exciting,
Andrew

On Mon, Aug 10, 2015, 1:01 PM Jens Reuterberg

wrote:

PRESENT: Ivan, Sebas, Thomas and Jens

MEETING GOAL:
write up a vision statement for Plasma Mobile and talk about the early work
of
the Plasma Mobile HIG and design goals.

The vision we ended with, after much debate of different wordings, what
should
and shouldn't be included in a vision statement was

VISION STATEMENT:
Plasma Mobile aims to become a complete software system for mobile devices.
It is designed to give privacy-aware users back the full-control over their
information and communication. Plasma Mobile takes a pragmatic approach and
is
inclusive to 3rd party software, allowing the user to choose which
applications and services to use. It provides a seamless experience across
multiple devices.
Plasma Mobile implements open standards, and -- unlike Android -- it is
developed in a transparent process that is open for the community to
participate in.

NOTES ON VISION STATEMENT:
We wanted the vision statement to reflect not the projects current position
but our future goals in full. A system for actual users with a focus on
privacy, control of information and your own system and working in the open
as
a community using open source.
We also included information about our pragmatism and how the phone intends
to
be easily adaptable to different apps from other eco-systems and also our
intent to make it a pairing with desktops.

PERSONAS:
We also talked about future Personas that we want to work towards when
creating user stories and scenarios and settled fairly quickly on Berna (the
office worker) and Susan (the recreational user).   (1)

DESIGN NOTES:
Further notes of interest during the meeting where a few bullet points
concerning future design goals for individual apps which will reach the HIG
in
the end
1) All applications should be private by default - no sending data in the
default configuration, must not phone home
2) Applications should try to include security and control of info. Should
be
apparent not hidden. This is not an excuse for geeky design.
3) Applications should always aim for integration between devices, for
example
using kdeconnect

FUTURE COMMUNICATION:
We also brainstormed on communication taglines for the project that will be
narrowed down further as time goes by (and should probably be a case for the
KDE Promo team) - centering mostly on user self control over his or her
information and communication but also communication ideas concerning
pragmatism.

Pragmatic to the bone
Think Similar
This is your phone, no one elses
Plasma's Satellite
Your phone. Your stuff. Your Plasma Mobile.
Plasma Mobile. Yours.
Yours
For your eyes only.
Yours truly.

All in all a very productive meeting.

-
1) https://techbase.kde.org/Projects/Usability/Principles/KDE4_Personas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82771
---


Very nice. A couple questions:
1. Are the inline selectiion handles grab-able? I assume yes.
2. Does this automatically appear when a selection is made or on right-click? I 
assume the former.

It would eventually be nice to have this solution for main application controls 
as well (or at least QtQuick controls)

Anyway, quite nice.

- Andrew Lake


On July 21, 2015, 9:35 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124374/
 ---
 
 (Updated July 21, 2015, 9:35 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This depends from https://codereview.qt-project.org/#/c/121659/
 provides the needed elements for touch based text selection and inline (no 
 separate window) menu for cut/copy/paste
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
 
 Diff: https://git.reviewboard.kde.org/r/124374/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 snapshot1.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

[Andrew Lake]

 On July 21, 2015, 4:20 p.m., Andrew Lake wrote:
  Very nice. A couple questions:
  1. Are the inline selectiion handles grab-able? I assume yes.
  2. Does this automatically appear when a selection is made or on 
  right-click? I assume the former.
  
  It would eventually be nice to have this solution for main application 
  controls as well (or at least QtQuick controls)
  
  Anyway, quite nice.
 
 Marco Martin wrote:
 It's purely for touchscreen interfaces, on a desktop system none of this 
 would appear/have effect: the menu would be a normal qmenu and only appear on 
 right click.
 so the blue things are draggable. The thing is supported by 
 qtquickcontrols out of the box, but is style-dependent and the upstream 
 qstyle based style doesn't support it

Very cool, thanks.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82771
---


On July 21, 2015, 9:35 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124374/
 ---
 
 (Updated July 21, 2015, 9:35 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This depends from https://codereview.qt-project.org/#/c/121659/
 provides the needed elements for touch based text selection and inline (no 
 separate window) menu for cut/copy/paste
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
 
 Diff: https://git.reviewboard.kde.org/r/124374/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 snapshot1.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124409: Begin fading the OSD immediately

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124409/#review82732
---


Nice! +1 from me.

- Andrew Lake


On July 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124409/
 ---
 
 (Updated July 20, 2015, 8:19 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This makes the OSD begin fading out over a long period of time immediately 
 after it has shown. Makes the OSD less annoying while currently reading 
 something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE
 
 
 Diffs
 -
 
   lookandfeel/contents/osd/Osd.qml 2288ec1 
   shell/osd.cpp 0573d51 
 
 Diff: https://git.reviewboard.kde.org/r/124409/diff/
 
 
 Testing
 ---
 
 Works. Quite enjoyable. As suggested by mklapetek
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: baloo monitor visibility

[Andrew Lake]

On Sat, Jul 18, 2015, 4:05 AM Vishesh Handa

 wrote:


 I was hoping to get it into KInfoCenter, and maybe have a way to
launch that from the

KCM



 Works for me.

- Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: baloo monitor visibility

[Andrew Lake]

It seems this desktop search monitor fits squarely into the powerful when
needed bucket. In that sense I don't think it is necessary to expose it
through any of the primary search interfaces (Alt-F2 or application menu).
That doesn't mean it should be completely hidden away since when it is
actually needed, it shouldn't be difficult to find.

I'm thinking perhaps we fold it into Search kcm as an indication of the
status of the search system. It could be helpful there if the user wants to
make a change to the search settings based on that information. I think we
should still do the plasmoid for the instances where the user might like to
do some long term monitoring. I'd suggest providing a way to access the
Search kcm from the plasmoid in case that user would like to make some
changes based on what they're seeing.

That's my 2c. Hope it helps,
Andrew

On Fri, Jul 17, 2015 at 1:33 AM Harald Sitter sit...@kde.org wrote:

 On Wed, Jul 15, 2015 at 10:39 AM, Pinak Ahuja pinak.ah...@gmail.com
 wrote:
  In fact I'm working on a plasmoid with the monitor's functionality, which
  will show up in the tray. Maybe we can hide the monitor from applications
  and add a button to plasmoid? i.e. if we do end up shipping the plasmoid.

 I think that would give it much more context, so that'd be cool.

 Mark and Martin do have a point in that it potentially being valuable
 without context though (such as when run from krunner by someone who
 knows what it does). I am not sure having it completely standalone is
 necessarily the way to go about this though. In particular I'd much
 rather have it be a KCM in ksysguard as it is a diagnostic tool for
 all intents and purposes (or kinfocenter... or fold it into the
 regular baloo KCM?).
 The one and only problem I have with the tool being in the menu is
 that it lacks any sort of context and at least to me file search is
 part of the workspace at large, so it being listed as a utility feels
 a lot like if for example the plasma wallpaper configuration was
 listed there.

 Perhaps you could ask the visual design group for some input on this?

 HS
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124234: Add option to always show all system tray icons

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124234/#review82025
---


Yeah, let's not bother with the dimming. It just introduces another 
visualization for a state that's ostensibly disabled. Hide or no hide, there is 
no try. :-)

- Andrew Lake


On July 2, 2015, 9:23 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124234/
 ---
 
 (Updated July 2, 2015, 9:23 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Bugs: 349812
 https://bugs.kde.org/show_bug.cgi?id=349812
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This adds an option to always show all system tray icons and never collapse 
 them into the popup. I've seen a couple of people already requesting this.
 
 
 Diffs
 -
 
   applets/systemtray/package/contents/config/main.xml 8e8996c 
   applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28 
   applets/systemtray/package/contents/ui/TaskDelegate.qml 221c6e7 
   applets/systemtray/package/contents/ui/main.qml e794d1c 
   applets/systemtray/plugin/host.h bd9728b 
   applets/systemtray/plugin/host.cpp 5c897fa 
 
 Diff: https://git.reviewboard.kde.org/r/124234/diff/
 
 
 Testing
 ---
 
 Enabled and disabled the option and tray icons along with the arrow came and 
 went, started music player and media controller properly appeared and 
 disappeared, started and quit KMail and its icon properla appeared and 
 disappeared with both options.
 
 
 File Attachments
 
 
 Settings dialog (disabled)
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png
 Settings dialog (enabled)
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png
 System Tray (disabled)
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png
 System Tray (enabled)
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png
 Better dialog layout
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png
 Dim System Tray
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 348513] Ugly breeze styling in libreoffice

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=348513

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 CC||jamboar...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Andrew Lake jamboar...@gmail.com ---
Indeed those are visual bugs that I can reproduce here as well. 

Best I can tell, the visual bugs are appear primarily in the drop-menus and
pop-up menus. Dialog boxes look generally ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123877: [digital-clock] Bring back font family and color options

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/#review80719
---


Just a couple observations:
1. I think it might be helpful to have a way to restore using the default font 
specified in the fonts kcm without having to explicitly know/set the font to 
match the default. A checkbox to enable/disable setting a custom font family as 
is done for the color might work.
2. Font style in the fonts kcm refers to face within a font family like 
weight (light, normal, bold, heavy) and emphasis (italic, oblique). So I think 
the label here should be Font not Font style for consistency.

Hope this helps!

- Andrew Lake


On May 21, 2015, 9:45 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123877/
 ---
 
 (Updated May 21, 2015, 9:45 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 348072
 https://bugs.kde.org/show_bug.cgi?id=348072
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This restores the custom font family and font color options; also clean ups 
 the layout a bit - we don't have a FormLayout, so that's the best it can get. 
 Did I mention dealing with ComboBox is horrible?
 
 
 Diffs
 -
 
   applets/digital-clock/package/contents/config/main.xml 5237160 
   applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 
   applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc 
 
 Diff: https://git.reviewboard.kde.org/r/123877/diff/
 
 
 Testing
 ---
 
 Checking and unchecking the custom color checkbox properly sets/unsets the 
 color, the Default font option restores the default font, options in the 
 dialog are properly restored when it opens, Apply button does not appear to 
 have become broken.
 
 
 File Attachments
 
 
 The clock
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
 Settings
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=346972

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||jamboar...@gmail.com

--- Comment #2 from Andrew Lake jamboar...@gmail.com ---
Fixed in 5.3 (commit 89d85cc3a)

*** This bug has been marked as a duplicate of bug 339863 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=346972

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED

--- Comment #6 from Andrew Lake jamboar...@gmail.com ---
Sorry, I maybe should not have marked this as duplicate. Let me explain.

The problem for the Breeze icon theme is that the rating icon was monochrome
black (Icon Grey technically). This was reported earlier against Breeze in bug
339863. During that bug review it was decided to re-assign it to KRatingPainter
and Christopher Feck attempted to update KRatingPainter to improve how it
handles monochrome low-saturation icons.  Unfortunately, despite Christopher's
effort, it somehow didn't work out. So the Breeze icon theme was updated to use
a yellow icon, which is similar to oxygen and so should work similar to Oxygen.

So while the problem is technically RESOLVED-FIXED for Breeze, KRatingPainter
might still have a little trouble with monochrome low-saturation icons until we
figure out why Christopher's patch didn't seem to work.

I'll change this to fixed for Breeze here. Hrvoje Senjan has already re-opened
the KRatingPainter bug 339863. If that bug gets resolved then we can update the
icon theme to take advantage of the fix to provide an even more distinct full
vs empty rating star icon.

Hope this helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79628
---

Ship it!


Ship It!

- Andrew Lake


On April 27, 2015, 9:35 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123539/
 ---
 
 (Updated April 27, 2015, 9:35 p.m.)
 
 
 Review request for Plasma, KDE Usability and Andrew Lake.
 
 
 Bugs: 342112
 https://bugs.kde.org/show_bug.cgi?id=342112
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 As suggested by Andrew show a badge kind of thing with the number of running 
 applets inside.
 
 
 Diffs
 -
 
   desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
 
 Diff: https://git.reviewboard.kde.org/r/123539/diff/
 
 
 Testing
 ---
 
 After fixing a nasty bug in the model it shows the proper number now. It also 
 doesn't break if you happen to have 10 or more widgets of the same kind. I 
 did not know what kind of font color to use.
 
 
 File Attachments
 
 
 Badge in action
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

[Andrew Lake]

 On April 23, 2015, 11:31 a.m., Eike Hein wrote:
   This is more an experiment on how much modules can be closely ported (and 
   in how much time).
  
  What's the benefit to the user of merging this version now?
 
 Marco Martin wrote:
 none.
 not too much pain as well tough.
 all of them have to eventually be ported tough and in order to get done, 
 one has to.. do it
 
 Eike Hein wrote:
  all of them have to eventually be ported tough and in order to get 
 done, one has to.. do it
 
 I'm just not a big fan of putting transitional pain (worse UI from a 
 weaker toolkit) on the user when there's an opportunity to avoid it, I guess 
 ... right now, Qt Quick has worse performance, no keyboard accelerator 
 management, no form layouts, limited widgets, some visual problems, etc. - 
 It's true of course that using it builds greater pressure to get it fixed, 
 but are we *certain* that actively hurting the quality of our releases is the 
 only path available?
 
 Marco Martin wrote:
 bah, right now accelerators and tab focus kinda works in that module..
 still kinda, but again, if the decision is to go in that direction, of 
 which i remeber it was talked about and decided, otherwise I wouldn't have 
 wasted two days on it ;)
 Now, I'm fine if now we decide to not port modules, but most of them 
 kindof have to be redone anyways, and I would prefer reding them once rather 
 than twice.
 
 David Edmundson wrote:
  It's true of course that using it builds greater pressure to get it 
 fixed, but are we certain that actively hurting the quality of our releases 
 is the only path available?
 
 It's not as simple as saying using new stuff /will/ hurt the quality 
 compared to the current state.
 
 This KCM wouldn't use form layouts, or any special widgets that we don't 
 have anyway. Keyboard accelorators and tab keys /should/ work in QQC so by 
 the time we finish with this, I think we can make it just as perfect /and/ 
 progress our QQC integration at the same time.
 
 Also it's not like these KCMs are truly perfect as-is. There are 8 open 
 bugs on the cursor KCM. I'd like to think paying some attention to these KCMs 
 will fix some of them.
 
 I do completely agree with you that users shouldn't be hurt by porting 
 efforts and we should have an absolutely no regressions at all policy before 
 merging, with no excuses about limitations in QQC.
 
 Martin Gräßlin wrote:
 I agree with David that we also should see this as a chance. For example 
 I always wondered why there is this strange preview area on the top, 
 instead of just previewing all cursors in the list directly. With QQC that 
 becomes quite easier and removes the it's probably because it would be a 
 nightmare with delegates.
 
 Marco Martin wrote:
 having all the previews inline could probably be simpler since i could 
 perhaps avoid a custom qquickpainteditem.. however, it would look very 
 crowded i think?
 
 Martin Gräßlin wrote:
 maybe only show them for the selected or on hover?
 
 Marco Martin wrote:
 this is very quick and dirty:
 http://wstaw.org/m/2015/04/24/plasma-desktopzp1576.png
 
 with very big delegates, it almost looks nice :)
 
 Sebastian Kügler wrote:
 I quite like it. Also, it's really not necessary to be able to view 5 or 
 more themes at the same time, this makes comparison already a lot easier.
 
 Marco Martin wrote:
 this is with a better layout:
 http://wstaw.org/m/2015/04/24/plasma-desktopUj1576.png
 there is still one thing that doesn't logically work too much, that is 
 the size combo box, since it depends from the theme selected (not all themes 
 have all the same sizes available) so that may have to be made inline as 
 well, not sure if it would work well tough
 
 Martin Gräßlin wrote:
  so that may have to be made inline as well, not sure if it would work 
 well tough
 
 Given that it already has this Available size, I think it could be a 
 neat idea to morph it into the delegate.
 
 (o) Resolution Dependent
 (o) |Dropdown| available sizes
 
 Fredrik Höglund wrote:
  For example I always wondered why there is this strange preview area 
 on the top, instead of just previewing all cursors in the list directly. With 
 QQC that becomes quite easier and removes the it's probably because it would 
 be a nightmare with delegates.
 
 * So that the appearance and behavior of the KCM is consistent with that 
 of the icon theme KCM.
 * So that the listview looks and behaves identically to other listviews.
 * To enable the user to get a quick overview of the installed themes 
 without having to scroll.
 * Each item in the listview provides three key points of data so as to 
 not overwhelm the user with information;
   a single large image of the most important cursor, the name of the 
 theme, and finally a short description.
 
 Every design decision was make 

Re: Plasma 5.3 beta tars

[Andrew Lake]

Thanks for taking the time report against that repo.

Everyone should be aware though that the official repo for Breeze icons and
all Breeze assets is the Breeze KDE project repo. The VDG should and will
respond to a KDE bugzilla report against Breeze about the icons. That
upstream repo is just a temporarily convenient working area and is synched
with the KDE Breeze repo periodically. In time, the KDE repo will be the
icon design working area as well. (We're working on it).

Andrew

On Tue, Apr 14, 2015, 6:32 AM Jonathan Riddell j...@jriddell.org wrote:

 On Sat, Apr 11, 2015 at 04:05:16AM +1000, Michael Palimaka wrote:
  I ran into a small issue with breeze - gtk-update-icon-cache can't
  handle paths with spaces so it now fails due to new icons
  (icons/actions/LO_icons_breeze/special folders).

 Reported
 https://github.com/NitruxSA/plasma-next-icons/issues/124

 dunno how it gets trickled down into KDE, for some reason KDE's icons
 aren't developed as part of KDE.

 Jonathan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System Settings app design freshening

[Andrew Lake]

On Sat, Apr 11, 2015 at 10:19 AM David Edmundson wrote:

 Questions:
   - would there still be tooltips on hover?


If they add more information than already available (like showing the
module icons) then I think tooltips would be fine.


   - there's a burger menu top right, what would be in it?


That menu would contain the Configure action currently shown as a
toolbutton, plus all the actions we currently have in the dropmenu of the
current Help toolbutton.


   - reset is changed to undo, is that a deliberate change?
 (FWIW, I like it if it is.)


It wasn't deliberate on my part, it just naturally flowed out of the forum
design thread. I agree though, I'm rather in favor of it.



 Only thing I think we can't do is the subtext in the list on the left.
 Probably best to proceed without that, rather than getting too hung up on
 it.


yeah, that part is admittedly aspirational at the moment but better to put
the idea out there as a potential opportunity to perhaps consider in the
longer term rather than something that should prevent anything else from
being implemented in the near term. :-)

 Thanks much for the feedback David. Please let us know if there is
anything else we can do from our (VDG) end,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-devel] Re: Default wallpaper

[Andrew Lake]

Thanks Johnathon,

For clarity, David updated the intended 5.3 default wallpaper, Next. I
added a few more wallpapers from the wallpaper competition (not default,
but meant to be shipped).

Hope that makes sense.

Thanks again,
Andrew

On Thu, Apr 9, 2015, 6:00 AM Jonathan Riddell j...@jriddell.org wrote:

 On Wed, Apr 08, 2015 at 11:25:07PM +0200, David Edmundson wrote:
 this is now all sorted.

 These were put in breeze, I've moved them now to
 plasma-workspace-wallpapers in svn.

 Jonathan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-devel] Re: Default wallpaper

[Andrew Lake]

Ahhh, I see that makes sense.

Thanks much,
Andrew


On Thu, Apr 9, 2015, 8:05 AM Marco Martin

wrote:


 basically the idea is that in breeze there stays only one wallpaper, the
default one,
while the other ones, usually photos, go in plasma-workspace-wallpapers in
svn
so the git repo doesn't get too much clobbered in huge binaries (even with
just the default one may become too big in the future

tough)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System Settings app design freshening

[Andrew Lake]

On Mon, Mar 30, 2015 at 1:47 AM Marco Martin wrote:

 what would the left sidebar do in the first mockup where everything is
 shown?



Those are links to modules in which recent changes were made. Selecting one
would take the user directly to that module.

Hope this helps,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

System Settings app design freshening

[Andrew Lake]

Recently it was mentioned that it would be nice to get system settings a
little more breezy. The VDG has been working on a system settings design
for a while and, after a little time trying to get the proposed designs
closer to something that might be more easily implemented, the design has
finally settled down.

To respond to the very helpful feedback that it can be difficult to dig
through the VDG forums to determine settled design proposals, we have
collected the results of the forum discussion here:
https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application

As noted on that page, this is *not* a proposal for the kcm designs; just
the system settings application. So ignore the kcm mockups and focus on the
system settings stuff. As always, we can tweak the proposal, as necessary,
to adjust to implementation challenges.

Hope this helps,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122948: Use fontSizeMode Text.Fit for NotificationIcon

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122948/#review77467
---

Ship it!


Ship It!

- Andrew Lake


On March 14, 2015, 3:13 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122948/
 ---
 
 (Updated March 14, 2015, 3:13 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 https://www.kde.org/announcements/plasma-5.2/full-screen.png
 There's nothing more to say. (Also use Connections rather than temp property)
 
 
 Diffs
 -
 
   applets/notifications/package/contents/ui/NotificationIcon.qml 1449c19 
 
 Diff: https://git.reviewboard.kde.org/r/122948/diff/
 
 
 Testing
 ---
 
 Font now automatically scales with the icon. Alignment can still be a little 
 bit off at times but properly centering text is a horrible task, also given 
 the frame and everything else is themable. We lack the triangle indicators 
 now, though.
 
 
 File Attachments
 
 
 Before in tray
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/38fc6d1c-a1f7-4ace-8df3-5803516862f8__notificationiconbefore.png
 After in tray
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/4cf0dd62-7d14-4f9c-81aa-045d5f02b709__notificationiconafter.png
 On Desktop
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/03/14/b5111380-e5f2-4f45-93e5-fb84da26b711__notificationiconafter1.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122522/#review75870
---


It might be worth investigating the use-case a bit further to try to understand 
if this is the best way to solve this. Is it useful? Yes. But there are 
potentiall negative impacts that should be balanced against the relative 
increase in utility.

We also need to belly up to identifying primary and secondary target personas 
and scenarios for Plasma (maybe a thing for the upcomign sprint). At best, I'd 
suggest that exposing the host name here would target a secondary persona and 
any associated scenarios. 

While I can't argue that the scenario in the bug report isn't legitimate, I'm 
not sure it warrants adding information to the lock-screen that is of 
little-to-no value to primary target personas and scenarios. The cost we're 
trying to mitigate in the bug report is that the user logs in/unlocks to 
identify the computer versus knowing it one interaction step earlier. 

For the lab/shared computers, the scenario requires that more than one computer 
is shared (probably in relative proximity to each other) and some particular 
need that requires knowing the computer identity *before* logging in/unlocking. 
Even in corporate environments that seems like quite a marginal scenario.

So for me, I'm struggling to see how the potentially negative impact of added 
information noise for what I think are the primary target personas and 
scenarios balances what is, I think, a marginal increase in utility for a 
marginal scenario for a secondary target persona.

Hope this helps!

- Andrew Lake


On Feb. 11, 2015, 1:59 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122522/
 ---
 
 (Updated Feb. 11, 2015, 1:59 p.m.)
 
 
 Review request for Plasma and Andrew Lake.
 
 
 Bugs: 294778
 https://bugs.kde.org/show_bug.cgi?id=294778
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 FEATURE: 294778
 FIXED-IN: 5.3.0
 
 
 Diffs
 -
 
   lookandfeel/contents/components/InfoPane.qml 
 18739ad96724f520ce8467ba5d4c9595e8a9e9ed 
 
 Diff: https://git.reviewboard.kde.org/r/122522/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 Screenshot of LockScreen with new info
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/02/11/771f0a24-aaa1-4bc4-afe8-53c44fe68d71__snapshot_TJ8703.png
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122488: Improved calendar navigation

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75633
---


Good stuff!

Perhaps add some visual hover feedback on the month/year so it's evident that 
it's live compared to hovering on other text.

Nothing other than that. Very nice!

- Andrew Lake


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122488/
 ---
 
 (Updated Feb. 8, 2015, 8:52 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This improves the calendar navigation by providing a Year overview showing 
 all 12 months in a grid, and a Decade overview showing the current decade 
 in a grid.
 
 A lot of code has just been moved around. The overviews use a QML ListModel 
 owing to laziness.
 
 See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that 
 mouse click effect!)
 
 
 Diffs
 -
 
   src/declarativeimports/calendar/calendar.cpp a766acb 
   src/declarativeimports/calendar/daydata.h 39ac086 
   src/declarativeimports/calendar/daysmodel.h ec88837 
   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
   src/declarativeimports/calendar/calendar.h ea20bf5 
 
 Diff: https://git.reviewboard.kde.org/r/122488/diff/
 
 
 Testing
 ---
 
 I changed the selection to be persistent during navigation; other than that, 
 should work as before, with the new overviews.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75566
---


Looks great! Might be helpful to see what it looks like with Kai suggestion for 
using a dialog background for improved visibility.

- Andrew Lake


On Feb. 6, 2015, 12:03 p.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122452/
 ---
 
 (Updated Feb. 6, 2015, 12:03 p.m.)
 
 
 Review request for Plasma and Martin Klapetek.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Emitting dbus signals allows interested parties to be notified about
 OSD changes. E.g. the lock screen might want to show the OSD values,
 but blocks the actual OSD, so it needs to be informed about changes
 to react on them.
 
 [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
 
 Allows to reuse the content of the Osd in other parts without
 having it to be a Dialog.
 
 [screenlocker] Support OnScreenDisplay messages
 
 KSld connects to the DBus signals for the OnScreenDisplay and forwards
 them to the greeter application through the private Wayland protocol.
 The idea here is to not have the greeter connect to the DBus as in future
 it would be preferable if the greeter cannot connect to DBus.
 
 The lookandfeel package might expose an object called onScreenDisplay.
 Whenever an OSD message is recieved by the greeter it looks for such an
 object and updates the osd specific properties.
 
 The default breeze lookandfeel package integrates the OsdItem from the
 same lookandfeel package.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.h 
 4a90fafee810940c3f932c8e2bfed10459adc425 
   ksmserver/screenlocker/greeter/greeterapp.cpp 
 a23b5625adc99661ab07534403ee23d005581c03 
   ksmserver/screenlocker/protocols/ksld.xml 
 bfb32190bf2529a14b39fac4c7e6029a5df811d0 
   ksmserver/screenlocker/waylandserver.h 
 5a8ed2249152277b505fe7a944b1b7251ef995d3 
   ksmserver/screenlocker/waylandserver.cpp 
 746032e1a7b1bad3625b9f0a156de059e5fba31a 
   lookandfeel/contents/lockscreen/LockScreen.qml 
 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
 
 Diff: https://git.reviewboard.kde.org/r/122452/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 Lock screen with volume OSD
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze cursor theme updates

[Andrew Lake]

On Thu Jan 08 2015 at 1:25:14 AM Marco Martin  wrote:

 should be integrated now, both themes.
 I included the whole sources, so modifications can be done directly in
 there
 in the future


Yay! Thanks Marco!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze Window Decoration status

[Andrew Lake]

On Sun Jan 04 2015 at 11:00:49 PM Martin Gräßlin wrote:

 I don't want special solutions for compositing disabled any more. It's
 too much a corner case nowadays. Compositing works and becomes more and
 more a requirement. This was a deliberate design decision when drafting
 KDecoration2 as for example it's no longer possible to have round
 borders without Compositing.


Thanks Martin, that helps my understanding. :-)

The vm installations I've encountered, including my current one [1], don't
have compositing enabled. One less thing to worry about. :-)

[1] http://wstaw.org/m/2015/01/06/no-composite-problem.png
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze Window Decoration status

[Andrew Lake]

On Sat Jan 03 2015 at 10:46:37 AM Kai Uwe Broulik wrote:

 Hi Andrew,

  - No window shadows.

 I do have shadows and they're quite gorgeous. Most likely compositing isn't
 enabled in your VM.


Ahh that must be it. Sounds like we need a window edge definition solution
for when compositing is not enabled, since right now overlapping windows
blend into each other. If folks have ideas please share. I'll chat with
other VDG folks as well.



 The only thing that I wonder is that the borders are hardly rounded now.
 They
 used to be rounder.


Hmm, the corner radii seem to match the original reference design, at least
in the compositing-disabled visuals I'm seeing. Send me a screenshot when
you get a chance.

If anyone else sees something that might be worth tweaking before the
artwork freeze, holler. :-)

Thanks much Kai!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Breeze Window Decoration status

[Andrew Lake]

I'm super excited that we have the C++ Breeze windec now available! I
running kubuntu-ci live in a vm and I wasn't sure if what I'm seeing
reflects the most current state of the windec. The two main things I
noticed are:
- No window shadows.
- The titlebar doesn't have the (subtle) gradient of the reference design.
- The button symbols are implemented _really_ nicely.

The first one is probably the most important to help define the window
boundary. Sorry if I'm bringing up stuff folks are already aware of and are
working on. If there's anything we can provide from the VDG side to help,
let us know.

Thanks again!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze Window Decoration status

[Andrew Lake]

On Sat Jan 03 2015 at 11:11:50 AM Andrew Lakewrote:

 On Sat Jan 03 2015 at 10:46:37 AM Kai Uwe Broulik wrote:

 Hi Andrew,

  - No window shadows.

 I do have shadows and they're quite gorgeous. Most likely compositing
 isn't
 enabled in your VM.


 Ahh that must be it. Sounds like we need a window edge definition solution
 for when compositing is not enabled, since right now overlapping windows
 blend into each other. If folks have ideas please share. I'll chat with
 other VDG folks as well.


After chatting with VDG folks here is a proposal for the edge of the
non-composite windows:
https://share.kde.org/public.php?service=filest=a0f8355a04acaa346e9a015d96e28846


Hope this helps and please let us know if there are any questions,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 342420] Provide default wallpaper in png format

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=342420

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Andrew Lake jamboar...@gmail.com ---
Thanks much David. The jpg versions have been repaced with the png version of
the wallpapers are now in breeze master.

I'll mark it resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.


Make the world a better place. Donate to our year end fundraiser 
https://www.kde.org/fundraisers/yearend2014/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 342420] Provide default wallpaper in png format

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=342420

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 CC||jamboar...@gmail.com

--- Comment #1 from Andrew Lake jamboar...@gmail.com ---
Is any VDG effort needed to resolve this or does the dev team already have the
wallpaper assets necessary to convert to png? Let us know if there's anything
we need to do?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=340063

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||jamboar...@gmail.com
 Status|UNCONFIRMED |CONFIRMED

--- Comment #5 from Andrew Lake jamboar...@gmail.com ---
I think the fade would be helpful in a utilitarian sense, and also add to the
overall visual polish. I'll confirm assuming there are no technical hurdles.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze icon theme structure

[Andrew Lake]

If there are no objections, I'll change the icons directory to match the
upstream repo directly later today.

Thanks,
Andrew

On Sun Nov 30 2014 at 9:01:42 AM Kai Uwe Broulik k...@privat.broulik.de
wrote:

 Given the index.theme has to specify what is where anway, I think the
 folder
 structure doesn't really matter?

 At least I've been running the Nitrux SA plasma-next-icons repository
 directly
 as main icon theme for a couple of days without a problem.

 Cheers,
 Kai Uwe

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Breeze icon theme structure

[Andrew Lake]

Marco,

The upstream repo for the breeze theme (
https://github.com/NitruxSA/plasma-next-icons) has a quite different
directory structure than the one in the KDE breeze repo (which is much
simpler). It's been that way from the start.

Anyway wasn't sure of the reasons for the difference in directory structure
so when I update the KDE repo, I attempt to put the icons from the upstream
repo in the directories that I think makes sense. It's no problem to keep
doing this, but is there any reason to not use the upstream repo directory
structure? Uri has some very specific reasons for that structure and I'm
not sure if I'm breaking the icon theme when I attempt to do the updates to
the KDE repo.

Thanks for any help,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Andrew Lake]

 On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote:
  Sorry if it's too much trouble, but would you be able to do a screenshot 
  showing a gtk app with these settings alongside a KF5 app?
 
 Jonathan Riddell wrote:
 http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png  GTK 2
 http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png  GTK 3 (the demo app 
 uses client side windows but the window border is still shown, I'm told this 
 bug is fixed in newer GTK)
 http://people.ubuntu.com/~jr/tmp/breeze-qt4.png  Qt 4
 
 Martin Gräßlin wrote:
 for GTK 3 it's important that the style doesn't set a shadow because 
 that's causing the strange effect you have in the screenshot.

Just on the visual result, I think the proposal is quite reasonable. There's a 
QtCurve Breeze settings file available in the breeze repo that comes pretty 
close to matching the feel of the native Breeze style, but I'm not aware of a 
QtCurve implementation in GTK3 (is there?). So I'm fine with this solution to 
keeping GTK2/3 apps looking similar and not looking too out of place when 
running in Plasma.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68621
---


On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120624/
 ---
 
 (Updated Oct. 19, 2014, 3:15 p.m.)
 
 
 Review request for Plasma and Hugo Pereira Da Costa.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 add gtkbreeze, kconf_update tool to set gtk settings on first login
 this checks if gtk settings are already set, if they are not or are set to 
 oxygen they update them, else it quits
 it does this for both gtk 2 and 3
 it sets gtk to the orion theme because it's available for both gtk 2 and 3 
 and it looks similar to breeze
 it sets the icons to oxygen because I could not get breeze icons to work with 
 gtk 2 or 3
 I also could not get icons to show on buttons or in menus in gtk 3
 
 
 Diffs
 -
 
   misc/CMakeLists.txt ff891a9 
   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
   misc/gtkbreeze/main.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/120624/diff/
 
 
 Testing
 ---
 
 run it and run gtk-demo and gtk3-demo
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68621
---


Sorry if it's too much trouble, but would you be able to do a screenshot 
showing a gtk app with these settings alongside a KF5 app?

- Andrew Lake


On Oct. 17, 2014, 3:47 p.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120624/
 ---
 
 (Updated Oct. 17, 2014, 3:47 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 add gtkbreeze, kconf_update tool to set gtk settings on first login
 this checks if gtk settings are already set, if they are not or are set to 
 oxygen they update them, else it quits
 it does this for both gtk 2 and 3
 it sets gtk to the orion theme because it's available for both gtk 2 and 3 
 and it looks similar to breeze
 it sets the icons to oxygen because I could not get breeze icons to work with 
 gtk 2 or 3
 I also could not get icons to show on buttons or in menus in gtk 3
 
 
 Diffs
 -
 
   misc/CMakeLists.txt ff891a9 
   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
   misc/gtkbreeze/main.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/120624/diff/
 
 
 Testing
 ---
 
 run it and run gtk-demo and gtk3-demo
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Auto-hiding panels

[Andrew Lake]

On Tue, Oct 14, 2014 at 6:51 AM, Àlex Fiestas wrote:

 On Tuesday 14 October 2014 10:43:42 Martin Klapetek wrote:
  I'd like to change this for Plasma panels to not have any resistance or
  very minimal one, basically get it into a state that slamming the mouse
  against a screen edge will show the panel easily, without requiring an
  additional push.
 I think we should ask VDG about this, it is a change in behavior and look
 and
 feel after all!

 Maybe just tweak to the edge triggering code might get us there as Martin
suggests. :-)

Best I can tell, the behavioral model from the user side is to move the
cursor far enough beyond the edge and the panel will appear. Based on that
behavioral model, I think the expectation would be that if the cursor is
moving relatively quickly when it get's to the edge it'll get to the magic
distance beyond the edge more quickly than if the cursor is moving
relatively slowly.

Another potential behavioral model could be a force model, where the panel
unhides when the edge is hit with a certain degree of force. Force based
models can be quite complex though since it usually requires some kind of
elastic resistance at the edge to allow triggering when moving the cursor
relatively slowly. Also, since there are very few uses of the cursor within
the screen boundaries that employ a force model, the user needs to maintain
quite different behavioral models of the the cursor behavior at the edge
versus the middle of the screen. It doesn't mean it can't be done, but I
think it can be quite tricky to do well. A simple magic distance past the
edge behavior is usually much simpler and more predictable I think and
should handle the fast versus slow edge approaches just fine.

Hope this helps,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: 5.1 Errata

[Andrew Lake]

Can anyone confirm that this bug exists in 5.1? I don't think the fix made
it in time, but I wanted to check before adding it to the errata.

https://bugs.kde.org/show_bug.cgi?id=339849

Thanks much,
Andrew

On Mon, Oct 13, 2014 at 3:54 AM, Jonathan Riddell j...@jriddell.org wrote:

 As discussed at hangout, if you know of bugs which users should be aware
 of please add them to

 https://community.kde.org/Plasma/5.1_Errata

 Jonathan


 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 339849] Can't set breeze dark color scheme

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=339849

--- Comment #3 from Andrew Lake jamboar...@gmail.com ---
I changed the filename as suggested and made the commit. I don't have
permissions to close this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 339863] full and empty stars are indistinguishable

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=339863

Andrew Lake jamboar...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||jamboar...@gmail.com

--- Comment #1 from Andrew Lake jamboar...@gmail.com ---
It appears the effect used to show an empty star is to desaturate the rating
(star) icon. The effect makes sense for hi color icon themes like oxygen.
However, monochrome or greyscale icons are by definition desaturated so the
effect doesn't result in any visible difference. We could add color to the
rating icon in the Breeze icon theme but that would break the style guidelines
for the icon theme, and might fairly be considered a band-aid for the
ineffectiveness of the desaturation effect to correctly produce the desired
empty star for monochrome and greyscale rating icons. One solution to the
underlying problem might be to decrease the opacity as well.

I'll confirm that this a problem, but I think the underlying problem is in the
components where ratings are displayed. I'm not entirely sure which components
those are.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 339863] full and empty stars are indistinguishable

[Andrew Lake]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #3 from Andrew Lake jamboar...@gmail.com ---
Thanks much Bhushan. 

One option would be to provide a new icon for the non-filled state. The
downside is that, except for breeze, no existing icon themes would have this
new icon. So I think it might be better to fix the underlying problem in
KRatingPainter.

My suggestion then is that the product for this bug be changed to
frameworks-kwidgetaddons since, as described, the greyscale conversion alone
won't produce a difference with any monochrome or greyscale icon sets.
Unfortunately, I don't currently have bugzilla permissions to do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Dark themes

[Andrew Lake]

Thanks much for the feedback Eike and David. :-)

With no noted objections and several thumbs up from our translators, I'll
commit the Breeze Dark icon theme to the Plasma/5.1 branch of the breeze
repo later this evening.

Thanks much,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Dark themes

[Andrew Lake]

Hello all,

I just realized that in pushing the Breeze Dark color scheme to the
Plasma/5.1 branch of the breeze repo, it likely violates the string freeze
(the name of the color scheme). So when I pushed the new Breeze Dark icon
theme I only pushed it to master since the icon theme name and description
are new strings.

The Breeze Dark icon theme allows the user to select an icon theme that
provides appropriate monochrome icon contrast for dark application color
schemes and also for the already-available Breeze Dark plasma theme. In the
latter case it provides some remedy for the icon visibility issues where
icons from the main icon theme are displayed (like on the Application
Launcher Leave tab, taskbar, etc.). So now I'm not sure what the least
bad result is;
A. Leave the breeze repo Plasma/5.1 branch as is with no remedy for the
main icon theme visibility issues with dark color schemes or the Breeze
Dark plasma theme OR
B. Revert the Breeze Dark color scheme commit in respect of string freeze
with similar downsides as A OR
C. Further violate the string freeze by pushing the Breeze Dark icon theme
to the Plasma/5.1 branch to provide a remedy for the icon visibility issues
with dark application color schemes and with the Breeze Dark plasma theme.
OR
D. ?

Of course the best solution would have been to get these changes in before
the string freeze. For that I apologize. But here we are, and I need some
help making a decision.

Thanks much for your patience and help,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Dark themes

[Andrew Lake]

On Sat, Oct 4, 2014 at 3:35 PM, Eike Hein wrote:



 On 05.10.2014 00:29, Andrew Lake wrote:

 C. Further violate the string freeze by pushing the Breeze Dark icon
 theme to the Plasma/5.1 branch to provide a remedy for the icon
 visibility issues with dark application color schemes and with the


 I don't think violating string freeze is critical for this.
 Our theme selection UIs usually provide visual feedback to
 get an idea of what an entry actually is/does, and the name
 functions more as, well, a name, or a brand, or however you
 want to put it. Realistically, nobody is going to stare at
 the screen in puzzlement over what Dark means in this
 context.

 That said, the standard protocol is to mail kde-i18n-doc
 and ask for a string freeze exception - the people with
 the relevant opinion here are our translators, not actually
 you or me.

 Thanks much Eike.  I'll make the request for an exception if there are no
objections to option C from others here.

Much respect,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze dark theme white edge outlines

[Andrew Lake]

Thanks for the feedback. Given the collection of responses so far, I'll go
ahead and leave the white outlines as they are.

Regarding duplication of svgs. Yes, the changes I prepared had separate
panel-background, dialog and tooltip svgs specifically for the dark theme.
The main reason is that reflective properties of the edge of the material
changes with color - brighter colors reflect more light, darker colors
reflect less. So where as the Cardboard Grey of the normal Breeze theme
needed a much brighter outline to better represent the quality of the edge,
the dark grey of the breeze dark theme would need a much less bright
outline. The current white outlines that we've grown to like are a happy
accident of the much brighter outline needed for the normal theme. Now,
we'll just say that those outlines are intentional. ;-)

In any event, I think there may be only so much complexity that's worth it
to avoid duplication of svgs. Beyond a certain point a theme of a different
color is, in the end, just a different theme. And these themes are a couple
of drunken grizzly bears to put together as is. :-)

Thanks much for the feedback!
Andrew
[back to visual bug hunting]

On Thu, Oct 2, 2014 at 2:25 AM, Marco Martin notm...@gmail.com wrote:

 On Wednesday 01 October 2014 16:21:03 Andrew Lake wrote:
  For anyone using the breeze dark theme, I've been meaning for a while to
  make some adjustments so that the edges aren't quite so pronounced and
 high
  contrast. It looks this way because it's currently using the same svgs
 (and
  edge highlights) from the normal breeze theme svgs.
 
  I have changes ready to push to reduce that high contrast edge outline,
 but
  I wanted to check to see if there was anyone that was particularly wedded
  to the those white outlines before I do. I'd do up a screen shot but just
  imagine those bright white outlines turned all the way down.
 
  Holler if anyone has any objections. :-)

 does the change involve duplicating the svgs?

 I quite like them as well, also i prefer duplication of images to be as
 little
 as possible (just yesterday i fixed some graphics glitches exactly in that,
 means next time work gets to be done double of the times)

 I am not that opposed to it, but if it has to be done i would prefer a way
 that doesn't duplicate svgs (that should be possible)

 --
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze dark theme white edge outlines

[Andrew Lake]

Cool Marco!

I'm totally fine with that as a solution instead of separate svgs. :-)

Of course, you'll still have to decide if you like the white outlines on
the dark theme or more subtle edge outlines. deep echo-y voiceThe
decision is in your hands. muwahahaha! /deep echo-y voice

Seriously though, while I wouldn't have proposed the more subtle outlines
if I didn't think they look better, I'm totally cool with whatever the
decision on this is from a visual standpoint. I think everyone knows the
timelines we're working with, so I say just make and decision and go for
it. :-)

Hope this helps!
Andrew

On Thu, Oct 2, 2014 at 11:13 AM, Marco Martin notm...@gmail.com wrote:

 On Thursday 02 October 2014 10:19:52 Andrew Lake wrote:
  Thanks for the feedback. Given the collection of responses so far, I'll
 go
  ahead and leave the white outlines as they are.
 
  Regarding duplication of svgs. Yes, the changes I prepared had separate
  panel-background, dialog and tooltip svgs specifically for the dark
 theme.

 I have an idea for a svg that should have automagically a pretty much solid
 white outline on breeze normal and a just a little bit brighter
 onbreeze-dark
 (attached)

 here only the top, topright and left elements are adjusted because
 lazyness,
 but if is a good concept i can finish it:

 there are two clones of the border pixel: one has the background color,
 solid
 (so gray/white on breeze and blackish on breeze-dark)
 then a second copy is on top of it, white/translucent, so will result in a
 dull white in the normal case, and a light gray in breeze-dark.

 --
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Breeze dark theme white edge outlines

[Andrew Lake]

For anyone using the breeze dark theme, I've been meaning for a while to
make some adjustments so that the edges aren't quite so pronounced and high
contrast. It looks this way because it's currently using the same svgs (and
edge highlights) from the normal breeze theme svgs.

I have changes ready to push to reduce that high contrast edge outline, but
I wanted to check to see if there was anyone that was particularly wedded
to the those white outlines before I do. I'd do up a screen shot but just
imagine those bright white outlines turned all the way down.

Holler if anyone has any objections. :-)

Thanks,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120222: When the button is being pressed draw background like it has focus

[Andrew Lake]

 On Sept. 22, 2014, 11:06 p.m., David Edmundson wrote:
  bump.

In case it matters, I have no objection to this change.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120222/#review67247
---


On Sept. 15, 2014, 6:29 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120222/
 ---
 
 (Updated Sept. 15, 2014, 6:29 p.m.)
 
 
 Review request for Plasma and Hugo Pereira Da Costa.
 
 
 Repository: breeze
 
 
 Description
 ---
 
 When the button is being pressed draw like it has focus
 
 PushButtons typically turn blue because they gain focus, whereas tool
 buttons don't. This means buttons look inconsistent.
 
 Also it fixes QtQuickControls push buttons which do change
 focus when pressed
 
 BUG: 339099
 
 
 Diffs
 -
 
   kstyle/breezestyle.cpp b0a3fc9 
 
 Diff: https://git.reviewboard.kde.org/r/120222/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

[Andrew Lake]

I'm running into a little bit of the inconsistency in systray icon sizes as
we're working to try to improve the systray icons.

http://wstaw.org/m/2014/09/21/5.1_systray_scaling_bug.png

The icons are still a WIP so please ignore that for the moment. All the
icons are 16x16 sitting on a padding rect in the svg. The only way I can
get all the icons to properly render at 16x16 is to use a 32x32 padding
rect for the example battery icon and a 24x24 padding rect for the klipper
icon (the first screenshot). If I put them both on a 24x24 rectangle the
battery icon appears to get scaled up resulting in both a bigger icon, and
the icon no longer aligned to the pixel grid resulting in bluriness (the
second screenshot) for the battery icon but a sharp klipper icon. The other
downside is that with such a big padding rect for the battery icon, where
it is used elsewhere the icon is really small.

The same thing happens with the network icons as the battery icons.

I'm not sure how to tell how the icon will be used, so I'm not what rule to
follow to ensure the icon sizes are rendered consistently.

I was going to file a bug, but I wasn't sure so I thought I'd chime in here.

Hope this helps,
Andrew

On Mon, Sep 15, 2014 at 12:56 AM, Marco Martin notm...@gmail.com wrote:

 On Friday 12 September 2014, Kai Uwe Broulik wrote:
  Hi,
 
  One of the problems is that most of the tray icons use a Plasma IconItem
  which follows the icon sizes (16, 22, 32, 48, ...) whereas a custom item
  does not.
 
  This is also the reason why battery and network usually appear in a
  different size since they're using SvgItem which doesn't have this magic.
 
  Imho that needs fixing in systray.

 I'm not sure that can be fixed in the systray, because it's still important
 for the clickable area to reach the screen edge(fitts law and all that
 jazz),
 so the actual item size should still touch the containment edges.

 and is the same thing for applets just in the panel, you would have the
 same
 problem, so in order to retain flexibility custom compactrepresentation
 items
 should still compute their size...

 What about a function
 units.roundToIconSize(size)  ?

 would still be manual, but very quick to do

 MouseArea {
 //the rootitem that goes to the edget

 Item {
 //whatever is graphics goes here
 width: units.roundToIconSize(parent.width)
 height: width
 anchors.centerIn: parent
 }

 }

 --
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

[Andrew Lake]

Correction: it's a 30x30 padding rect that gets the icon sizes the same,
not a 32x32 padding rect.

Hope this helps,
Andrew

On Sun, Sep 21, 2014 at 1:17 AM, Andrew Lake wrote:

 I'm running into a little bit of the inconsistency in systray icon sizes
 as we're working to try to improve the systray icons.

 http://wstaw.org/m/2014/09/21/5.1_systray_scaling_bug.png

 The icons are still a WIP so please ignore that for the moment. All the
 icons are 16x16 sitting on a padding rect in the svg. The only way I can
 get all the icons to properly render at 16x16 is to use a 32x32 padding
 rect for the example battery icon and a 24x24 padding rect for the klipper
 icon (the first screenshot). If I put them both on a 24x24 rectangle the
 battery icon appears to get scaled up resulting in both a bigger icon, and
 the icon no longer aligned to the pixel grid resulting in bluriness (the
 second screenshot) for the battery icon but a sharp klipper icon. The other
 downside is that with such a big padding rect for the battery icon, where
 it is used elsewhere the icon is really small.

 The same thing happens with the network icons as the battery icons.

 I'm not sure how to tell how the icon will be used, so I'm not what rule
 to follow to ensure the icon sizes are rendered consistently.

 I was going to file a bug, but I wasn't sure so I thought I'd chime in
 here.

 Hope this helps,
 Andrew

 On Mon, Sep 15, 2014 at 12:56 AM, Marco Martin notm...@gmail.com wrote:

 On Friday 12 September 2014, Kai Uwe Broulik wrote:
  Hi,
 
  One of the problems is that most of the tray icons use a Plasma IconItem
  which follows the icon sizes (16, 22, 32, 48, ...) whereas a custom item
  does not.
 
  This is also the reason why battery and network usually appear in a
  different size since they're using SvgItem which doesn't have this
 magic.
 
  Imho that needs fixing in systray.

 I'm not sure that can be fixed in the systray, because it's still
 important
 for the clickable area to reach the screen edge(fitts law and all that
 jazz),
 so the actual item size should still touch the containment edges.

 and is the same thing for applets just in the panel, you would have the
 same
 problem, so in order to retain flexibility custom compactrepresentation
 items
 should still compute their size...

 What about a function
 units.roundToIconSize(size)  ?

 would still be manual, but very quick to do

 MouseArea {
 //the rootitem that goes to the edget

 Item {
 //whatever is graphics goes here
 width: units.roundToIconSize(parent.width)
 height: width
 anchors.centerIn: parent
 }

 }

 --
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

[Andrew Lake]

On Sun, Sep 21, 2014 at 2:06 AM, Marco Martin  wrote:

 Btw, since we are refining systray icons, do they work also on a size of
 22x22(if not I'll fix the code)? I would love to get rid of the old hack of
 24x24, that is just a remnant of the xembed legacy icons


I changed the padding rect on klipper and the battery icons to 22x22 with
the same 16x16 icon size in both. The result is here:

http://wstaw.org/m/2014/09/21/5.1_scaling_bug_C.png

The klipper icon seems to render fine. The battery icon scales up.

With the fixes in-place or expected to be in-place, is it ok if I target a
22x22 padding rect for all icons?

Thanks for all your help!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

[Andrew Lake]

On Sep 21, 2014 3:47 PM, David Edmundson wrote:

 ​Padding inside the SVG?

Yes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

[Andrew Lake]

On Sun, Sep 21, 2014 at 5:39 PM, David Edmundson wrote:

  ​Padding inside the SVG?

 Yes

 I don't think this is the right long-term approach. We end up with
 problems like in the original post where it's difficult to make another
 item line up with an icon.

 IMHO padding should be applied at a QML level, not inside the component.
 It makes the behaviour a bit different to everything else.

 David

Sorry David, I wasn't terribly clear. I'm not advocating padding in the
asset as the correct way to handle padding. I was actually asking if I
should target the icon asset in the plasma theme icon svgs to a source size
of 22x22 instead of the varying sizes right now that appears to be
necessary to achieve consistent scaling and pixel grid alignment in the
systray. (For the specific icons I'm working on they *happen* to have some
padding in the asset relative to the visible portions of the asset, but
only as required to match the corresponding icons in the main icon theme.)

Sorry for the confusion. :-(
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119464: port ToolButton to QtControls

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/#review63169
---



src/declarativeimports/plasmacomponents/qml/ToolButton.qml
https://git.reviewboard.kde.org/r/119464/#comment43931

Just curious, any reason to not use ToolButton here?

http://qt-project.org/doc/qt-5/qml-qtquick-controls-toolbutton.html


- Andrew Lake


On July 25, 2014, 1:47 p.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119464/
 ---
 
 (Updated July 25, 2014, 1:47 p.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 this ports ToolButton.
 It's a different style than Button since it's way more complicated.
 
 The ugly thing here is that QtControls ToolButton doesn't have a flat 
 property, it should probably be upstreamed, at least for compatibility with 
 the qwidgets ToolButton
 
 
 Diffs
 -
 
   src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 
   src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 
 20caef6 
   src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 
 PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/119464/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119455: make Button a QtControl

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63086
---


Exciting! 

Might this eventually support a ButtonStyle.qml in the plasma theme that 
overrides the svg-based ButtonStyle if it's present? That way we could take the 
already developed Breeze ButtonStyle.qml and just ship it in the plasma theme.

- Andrew Lake


On July 24, 2014, 3:55 p.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119455/
 ---
 
 (Updated July 24, 2014, 3:55 p.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 this makes Button inherit from the QtControl and annd an accompaining 
 plasma-looking theme
 
 now, the ugly part of the patch:
 iconSource is an url, so it screws up passing freedesktop compatible names 
 (it expects names of pngs local to the qml file directory, testimony of the 
 main platform target for controls actually being android/ios). one solution 
 may be overriding iconSource as a normal string, but i would like the theme 
 working also on a plain Button, so it extract only the filename from the url.
 
 
 Diffs
 -
 
   src/declarativeimports/core/iconitem.cpp 38012cc 
   src/declarativeimports/plasmacomponents/qml/Button.qml 262e20f 
   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml 
 PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/119455/diff/
 
 
 Testing
 ---
 
 in both a normal plasma session or the widget gallery buttons work fine, 
 painting is 100% identical
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

(Updated June 23, 2014, 2:19 p.m.)


Review request for Plasma.


Changes
---

Use units.smallspacing for text background margins. Don't show text background 
on popups or widget view. Also decreased opacity to 0.4 to reduce heavy feel. 
 See attached screen capture.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs (updated)
-

  containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments (updated)


with latest changes showing it with selection background
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

(Updated June 24, 2014, 12:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs
-

  containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments


with latest changes showing it with selection background
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118883: Splash minor visual refinement

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118883/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

See before and after screenshots.


Diffs
-

  lookandfeel/contents/splash/Splash.qml f2246a4 

Diff: https://git.reviewboard.kde.org/r/118883/diff/


Testing
---


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/199ecc64-0dca-4574-8548-f5f4063e6b5b__splash0.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/b6dc5cb0-f847-4fac-b7bd-3b4721d05f88__splash1.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118883: Splash minor visual refinement

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118883/
---

(Updated June 22, 2014, 7:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

See before and after screenshots.


Diffs
-

  lookandfeel/contents/splash/Splash.qml f2246a4 

Diff: https://git.reviewboard.kde.org/r/118883/diff/


Testing
---


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/199ecc64-0dca-4574-8548-f5f4063e6b5b__splash0.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/b6dc5cb0-f847-4fac-b7bd-3b4721d05f88__splash1.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Background for login, splash, and lockscreen

[Andrew Lake]

This blurred, dimmed version of the default wallpaper has been committed
for use by the login, splash and lockscreen.

Much respect,
Andrew


On Sun, Jun 22, 2014 at 12:34 PM, Kai Uwe Broulik k...@privat.broulik.de
wrote:

 Well, imho the wallpaper on the lockscreen should be the one the user has
 chosen for his/her desktop, and there we cannot influence that. Even if the
 lockscreen wallpaper is configurable we don't have influence on its
 appearance either.

 Was just a thought, there may be a dozen of reasons not to do as I
 proposed ;)

 Cheers,
 Kai Uwe

 Am 22.06.2014 20:57 schrieb Martin Graesslin mgraess...@kde.org:
 
  On Saturday 21 June 2014 16:18:10 Kai Uwe Broulik wrote:
   Can't we just use QtGraphicalEffects and just blur (and/or desaturate
 and/or
   darken) whatever picture the user has chosen?
  
   The overall performance of these is great (at least on Android which
 is slow
   in any other QtQuick respect) but their instantiation takes ages, so
 might
   not be suitable for lockscreen which needs to start quickly or splash
 which
   shouldn't unnecessarily delay startup.
  
   So, umm, while writing this I figured it's not that good of an idea as
 I
   initially thought :-)
 
  so you suggest that on millions of devices we blur the window fullscreen
 every
  time the user logs in (lots of more important stuff to do) and locks the
  screen? Compared to preparing it once and just installing it? That
 sounds like
  a very bad memory-time tradeoff [1].
 
  Cheers
  Martin
 
  [1] https://en.wikipedia.org/wiki/Time-memory_tradeoff
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118891: Folder view icon text background

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

Review request for Plasma.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs
-

  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments


After: Folderview as desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

[Andrew Lake]

 On June 22, 2014, 11:29 p.m., Mark Gaiser wrote:
  Not a +1 or -1. Just my preference for this.
  - No background (aka, fully transparent) when nothing is selected.
  - Selected items should show the background as in your screenshot.
  
  Just my preference though :)

This change is for readability when nothing is selected. The normal icon 
selection background is unaffected.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/#review60739
---


On June 22, 2014, 11:09 p.m., Andrew Lake wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118891/
 ---
 
 (Updated June 22, 2014, 11:09 p.m.)
 
 
 Review request for Plasma.
 
 
 Bugs: 335070
 https://bugs.kde.org/show_bug.cgi?id=335070
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Addresses lack of contrast of folderview containment icon text on certain 
 backgrounds: Bug 335070
 
 The color of the text background is just the complement of the icon label 
 text with a 0.6 opacity applied.
 
 
 Diffs
 -
 
   containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 
 
 Diff: https://git.reviewboard.kde.org/r/118891/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 After: Folderview as desktop
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/488f6ed9-462f-4ff4-b50c-c951c5a0de66__icontextbackground.png
 
 
 Thanks,
 
 Andrew Lake
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118891: Folder view icon text background

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118891/
---

(Updated June 23, 2014, 12:41 a.m.)


Review request for Plasma.


Changes
---

Updated to remove configuration of the icon text color and use theme colors 
when folderview is the desktop background.


Bugs: 335070
https://bugs.kde.org/show_bug.cgi?id=335070


Repository: plasma-desktop


Description
---

Addresses lack of contrast of folderview containment icon text on certain 
backgrounds: Bug 335070

The color of the text background is just the complement of the icon label text 
with a 0.6 opacity applied.


Diffs (updated)
-

  containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 
  containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 

Diff: https://git.reviewboard.kde.org/r/118891/diff/


Testing
---


File Attachments (updated)


Icon text background
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/421aaadc-1b16-4d80-8929-694ac9b669b5__icontextbackground1.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Background for login, splash, and lockscreen

[Andrew Lake]

Hello all,

With the sharpness of the default background image in the login, splash and
lockscreen, both the foreground and background appear to be in focus -
causing a slightly uncomfortable lack of depth. Things seem to look better
with a defocused and slightly dimmed background - the foreground appears
sharp and in-focus relative to the background and the fade-to-desktop
effect with the default wallpaper has the pleasant visual side effect of
appearing to bring the desktop into focus.

Before I could get a screenshot my local neon install kinda flaked out. So
I've provided a link to the defocused and dimmed background image. I'm
hoping someone can try it out locally before I commit. It replaces the
background.png file in lookandfeel/contents/components/artwork and
lookandfeel/contents/splash/images.

(Also I'd be fine if the same thing were accomplished programmatically
instead.)

New background file:
http://wstaw.org/m/2014/06/21/background.png

Could someone try this out when you get a chance? I'll commit if there are
no objections.

Thanks,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Background for login, splash, and lockscreen

[Andrew Lake]

Just for clarity I'm only proposing the blurred version for the login,
splash and lockscreen. The normal, non-blurred version for actual desktop -
nuno's wallpaper - is untouched and I assumed that one, or a finished
version of it, would be default.

Whatever ends up as the default, I'd propose a blurred version of that for
the login, splash and lockscreen. I'd be totally fine if Nuno wanted to
revamp it altogether, or if we pick something else as default. That
screenshot I shared was just some nice wallpaper I took from deviantart. If
we wanted to use that one we'd need to contact the author.

I'll commit this for the login, splash and lockscreen for the time being
and gen up a new one - a couple minutes of effort - if we pick a different
default.

Much respect,
Andrew
On Jun 21, 2014 3:52 AM, Jens j...@ohyran.se wrote:

 I am +1 about blurring the login AND as for the wallpaper:
 I've talked to Nuno about it and there is some Mggrmmrl going on there
 since
 he has fallen out of love with it and we still need him to send us the
 proper
 SVG's off it so we can do several different resolutions of it.

 If Andrews wallpaper is the new default (assuming its homemade...
 Andrew?)
 or whatever it is we should get it sorted asap since we need to use it as
 the
 background for the login and it would be nice to put this issue to rest.

 If Andrews image isn't homebrewed I will hound Nuno some more to get it
 sent
 to me so we can just get that bit off our collective chests

 /Jens (post-midsummer, insanely tired)

 On Saturday 21 June 2014 12.45.59 Marco Martin wrote:
  On Saturday 21 June 2014 00:25:35 Andrew Lake wrote:
   Hello all,
  
   With the sharpness of the default background image in the login, splash
   and
   lockscreen, both the foreground and background appear to be in focus -
   causing a slightly uncomfortable lack of depth. Things seem to look
 better
   with a defocused and slightly dimmed background - the foreground
 appears
   sharp and in-focus relative to the background and the fade-to-desktop
   effect with the default wallpaper has the pleasant visual side effect
 of
   appearing to bring the desktop into focus.
  
   Before I could get a screenshot my local neon install kinda flaked
 out. So
   I've provided a link to the defocused and dimmed background image. I'm
   hoping someone can try it out locally before I commit. It replaces the
   background.png file in lookandfeel/contents/components/artwork and
   lookandfeel/contents/splash/images.
  
   (Also I'd be fine if the same thing were accomplished programmatically
   instead.)
  
   New background file:
   http://wstaw.org/m/2014/06/21/background.png
  
   Could someone try this out when you get a chance? I'll commit if there
 are
   no objections.
 
  ok, so this goes on login, splash and lockscreen, while the normal
  background is still in focus?
 
  sounds good to me
 
  btw just to be sure, this is going to be the final default background?
  (at some point i understood it could have been this one
 
 http://1.bp.blogspot.com/-pt8ssY4qgCQ/U3oNfW1csmI/MsA/LQvL-FvMiVQ/s1
  600/loving+it.png= since the desktop default icon seems to have a
 variant
  of it

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Launcher tab icons

[Andrew Lake]

Marco,

Per the discussion on the VDG forum, here are the launcher icons. For the
Leave tab, there's already a logout icon, so rather than create another
one, I suggest using that instead of the shutdown icon since it seems like
a better metaphorical representation of Leave.

Oh, and I'm not at my linux rig, so these will need the currentColorFix
script run on them.

Hope this helps and please let me know if there are any questions,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118644: Update battery monitor popup to use new icons

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118644/
---

Review request for Plasma and Kai Uwe Broulik.


Repository: plasma-workspace


Description
---

Update battery monitor to use new icons from new battery.svgz theme file in 
popup.

Also includes minor updates to vertical alignments of icon with text and slight 
increase in battery status text opacity.

(Requires replacing the battery.svgz theme file in the theme icons/ directory 
with the new one attached - I wasn't sure how to do a review request across two 
different repos)


Diffs
-

  applets/batterymonitor/contents/ui/BatteryIcon.qml 
308eaf85c8d41574f210086b6ce17a47e261a773 
  applets/batterymonitor/contents/ui/BatteryItem.qml 
655026b8e5a429f70e55aa8b9d01218139ac 
  applets/batterymonitor/contents/ui/BrightnessItem.qml 
0d7e8e2b4a2acae4e5a2ab43a9edefc812216ee6 
  applets/batterymonitor/contents/ui/PopupDialog.qml 
44f6f9dd55d6356c446f4c7352bc5bc03338d870 

Diff: https://git.reviewboard.kde.org/r/118644/diff/


Testing
---


File Attachments


New battery.svgz theme file
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/1b839cb5-f507-42c0-9314-cd9e0a17ee1f__battery.svgz
SS from my laptop
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/6bb20e04-22fd-4ad6-bff6-9afee5cfd4de__iconsreviewrequestss.png
new battery icon theme file
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/fa313439-cb6e-4b72-a4dd-c3a2042b7d30__battery.svgz
icon assets shown in mockup
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/102356b1-0d85-45fa-96de-93384e33__mockup_battery_monitor_2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118644: Update battery monitor popup to use new icons

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118644/
---

(Updated June 10, 2014, 5:09 p.m.)


Review request for Plasma and Kai Uwe Broulik.


Changes
---

oops added two copies of the svg theme file


Repository: plasma-workspace


Description
---

Update battery monitor to use new icons from new battery.svgz theme file in 
popup.

Also includes minor updates to vertical alignments of icon with text and slight 
increase in battery status text opacity.

(Requires replacing the battery.svgz theme file in the theme icons/ directory 
with the new one attached - I wasn't sure how to do a review request across two 
different repos)


Diffs
-

  applets/batterymonitor/contents/ui/BatteryIcon.qml 
308eaf85c8d41574f210086b6ce17a47e261a773 
  applets/batterymonitor/contents/ui/BatteryItem.qml 
655026b8e5a429f70e55aa8b9d01218139ac 
  applets/batterymonitor/contents/ui/BrightnessItem.qml 
0d7e8e2b4a2acae4e5a2ab43a9edefc812216ee6 
  applets/batterymonitor/contents/ui/PopupDialog.qml 
44f6f9dd55d6356c446f4c7352bc5bc03338d870 

Diff: https://git.reviewboard.kde.org/r/118644/diff/


Testing
---


File Attachments (updated)


New battery.svgz theme file
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/1b839cb5-f507-42c0-9314-cd9e0a17ee1f__battery.svgz
SS from my laptop
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/6bb20e04-22fd-4ad6-bff6-9afee5cfd4de__iconsreviewrequestss.png
icon assets shown in mockup
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/102356b1-0d85-45fa-96de-93384e33__mockup_battery_monitor_2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118644: Update battery monitor popup to use new icons

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118644/
---

(Updated June 10, 2014, 7:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Kai Uwe Broulik.


Repository: plasma-workspace


Description
---

Update battery monitor to use new icons from new battery.svgz theme file in 
popup.

Also includes minor updates to vertical alignments of icon with text and slight 
increase in battery status text opacity.

(Requires replacing the battery.svgz theme file in the theme icons/ directory 
with the new one attached - I wasn't sure how to do a review request across two 
different repos)


Diffs
-

  applets/batterymonitor/contents/ui/BatteryIcon.qml 
308eaf85c8d41574f210086b6ce17a47e261a773 
  applets/batterymonitor/contents/ui/BatteryItem.qml 
655026b8e5a429f70e55aa8b9d01218139ac 
  applets/batterymonitor/contents/ui/BrightnessItem.qml 
0d7e8e2b4a2acae4e5a2ab43a9edefc812216ee6 
  applets/batterymonitor/contents/ui/PopupDialog.qml 
44f6f9dd55d6356c446f4c7352bc5bc03338d870 

Diff: https://git.reviewboard.kde.org/r/118644/diff/


Testing
---


File Attachments


New battery.svgz theme file
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/1b839cb5-f507-42c0-9314-cd9e0a17ee1f__battery.svgz
SS from my laptop
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/6bb20e04-22fd-4ad6-bff6-9afee5cfd4de__iconsreviewrequestss.png
icon assets shown in mockup
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/102356b1-0d85-45fa-96de-93384e33__mockup_battery_monitor_2.png


Thanks,

Andrew Lake

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Visual design for logout/login/lockscreen

[Andrew Lake]

On Thu, Jun 5, 2014 at 9:47 AM, Aleix Pol aleix...@kde.org wrote:

 On Sat, Apr 5, 2014 at 12:32 AM, Andrew Lake jamboar...@gmail.com wrote:

 Hello,

 After reading Aaron's nearly year old blog entry again this week (
 http://aseigo.blogspot.de/2013/05/visual-harmony-in-plasma-workspaces-2.html)
 , especially the following quote:

  ...the log out dialog still has things that look like little push
 buttons and it still has inexplicable
  picture on the left, despite now being written in QML and having all
 the power that implies.
 
  Plasma Workspaces 2 is our opportunity to improve these parts by
 harmonizing and modernizing
  them. The log out interface ought to look like it belongs with the lock
 screen; the log in screen
  ought to mesh with the splash screen...
 
 We have a couple people who can do this kind of work, but they have lots
 on their plate already.
 This is a great opportunity for someone with a flair for design to get
 involved...

 I put a little effort into identifying a visual design that might get us
 a little bit closer. I apologize that I don't have any idea what work may
 have already been put into this area, so please don't take my ignorance as
 a dismissal of any work that has already occurred. I also shared this
 design with other members of the Visual Design Group and there were no
 objections to offering these designs here.

 Anyway here goes:
 Login: http://wstaw.org/m/2014/04/05/login_mockup.png
 Logout: http://wstaw.org/m/2014/04/03/logout_mockup.png
 Unlock: http://wstaw.org/m/2014/04/05/unlock_mockup.png
 Shutdown: http://wstaw.org/m/2014/04/03/shutdown_mockup2_1.png

 We're happy to provide any visual assets required, which shouldn't be
 much. (We already have a few to choose from). I won't speak to architecture
 since that's your wheelhouse, but my assumption is that the UI layer could
 be handled by the same QML package with enough hooks for the various
 existing underlying functionality to use. I would like to have offered up a
 QML package with this, but it's early days yet for my QML familiarity (but
 getting better fast). :-)

 Hope this is helpful and please let me know if there are any questions,
 Andrew Lake
 Community designer in the KDE Visual Design Group

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


 Hi,
 I've been trying to sort these out during this week, together with David.
 I've pushed a new Lock and Logout implementations following these mockups.
 They don't look like that yet but it's quite close and workable. The main
 issue
 being that we cannot hardcode a plasma theme from them, or maybe it's not
 an issue.

 Well, either way it would be interesting if somebody could take a look and
 see what it feels like, then maybe we can iterate it forward.

 Cheers!
 Aleix


Exciting! I'll be sure to take a look as soon as I update my daily neon
packages.

Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Visual design for logout/login/lockscreen

[Andrew Lake]

On Thu, Jun 5, 2014 at 10:30 AM, Marco Martin wrote:

 * don't bother wit the background, I think on top of the fullscreen
 blur/darken effect is fine (in this case even better than a background that
 covers everything)


Yes, I agree, that was the intention in the proposed visual design (and
intention I poorly communicated, sorry).

Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Icons status

[Andrew Lake]

On Thu, Jun 5, 2014 at 12:22 PM, Marco Martin wrote:

 Hi all,
 Just relying a message from Uri,
 toolbars and folders are almost complete, but all devices and mimetypes are
 still missing, so a little opinion poll is needed.

 I think that they should be shipped anyways, but default yes/no ?

 Cheers,
 Marco Martin


I thought the plan was to use Flattr (or Oxygen?) icons as a base and
replace with the new icons as we go. That way we'd have something that
functionally relatively complete, even if they change over time as the new
icons are completed. I may be entirely mistaken about that though (which
isn't the most unusual thing in the world).

Anyway to your question, I think we should ship them. If the situation is
like what I describe above (a version of which I'm using using on my
current install) then count my vote for defaulting to it. If the situation
is otherwise then I'm ambivalent.

Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
---


The group box HIG has been updated after discussion on the HIG mailing list. 
Using a group box with the 'flat' property set true is now recommended; it 
provides a consistent way to use spacing to group visual elements without the 
line-y, boxy noise of a visible frame. If you used group boxes here and 
followed this new guidance you should get the visual design you're aiming for 
with more consistent spacing.

Hope this helps!

- Andrew Lake


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118390/
 ---
 
 (Updated June 2, 2014, 4:04 p.m.)
 
 
 Review request for Plasma, Solid and KDE Usability.
 
 
 Repository: powerdevil
 
 
 Description
 ---
 
 This is a series of UI updates I've applied to the powerdevil KCMs. You can 
 find them as individual patch series in the sebas/kcmupdates branch.
 
 General:
 - Less icon usage, especially in the form layouts
 - Title casing throughout
 - Better HIG compliance (not 100%, but improved)
 - Energy Saving / Actions UI now scales with dialog
 - Proper usage of FormLayouts
 - A bunch of cleanups of dead code
 - Parenting fixes
 
 In Detail:
 
 * Improve Advanced Settings page
 
 - Use a QFormLayout, and do it properly
 - Fix up spacing and alignment
 - Remove icons before titles
 - Use Title Case for Labels
 - Shorter labels for better readability
 
 * Clean up brightness-OSD-related dead code
 
 
 * Make powerdevil actions layout stretch out horizontally
 
 
 * Compile-time connections in actionconfigwidget
 
 
 * widget and layout parenting fixes
 
 
 * No bold font, increased spacing instead
 
 This removes the bold fonts from the checkboxes, as that is non-standard
 in the HIG. In order to make it look a bit more structured between the
 sections, a bit of spacing is added.
 
 * Remove icons from actions
 
 The icons are really small and add more visual noise than being useful.
 
 * Streamline Comments of KCMs
 
 
 * Clean up dead code
 
 
 Diffs
 -
 
   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
 231c5d6 
   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
   daemon/actions/powerdevilaction.desktop 5b74fea 
   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
   daemon/powerdevil.desktop 20d31c9 
   kcmodule/activities/activitypage.cpp 48e9c6c 
   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
   kcmodule/common/actionconfigwidget.cpp 2161c84 
   kcmodule/common/actioneditwidget.cpp 4c67b4f 
   kcmodule/global/GeneralPage.cpp d025e42 
   kcmodule/global/generalPage.ui 2ce7cef 
   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
   kcmodule/profiles/EditPage.cpp a674ccb 
   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
   kcmodule/profiles/profileEditPage.ui dc26579 
   powerdevil.notifyrc 36acdb6 
 
 Diff: https://git.reviewboard.kde.org/r/118390/diff/
 
 
 Testing
 ---
 
 Tested in kcmshell5 and systemsettings, still fully functional.
 
 
 File Attachments
 
 
 Energy Saving page before
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
 Energy Saving page after
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
 Advanced page after
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
 Advanced page before
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png
 
 
 Thanks,
 
 Sebastian Kügler

Re: Review Request 118390: Powerdevil KCM Updates

[Andrew Lake]

 On June 2, 2014, 4:26 p.m., Andrew Lake wrote:
  The group box HIG has been updated after discussion on the HIG mailing 
  list. Using a group box with the 'flat' property set true is now 
  recommended; it provides a consistent way to use spacing to group visual 
  elements without the line-y, boxy noise of a visible frame. If you used 
  group boxes here and followed this new guidance you should get the visual 
  design you're aiming for with more consistent spacing.
  
  Hope this helps!
 
 Sebastian Kügler wrote:
 It helps partly, but it still makes aligning the widgets in different 
 groupboxes really hard. I'd really prefer just simple spacing. If we make it 
 hard to align things properly, people just won't. In this specific case in 
 powerdevil, using groupboxes really seems overkill as well, we can do just 
 fine with section titles and a bit of spacing (as can be seen here).

Honestly, if in any one instance we can achieve the same consistency in spacing 
without using the groupbox I'm fine with deviating from the guidelines. They 
are, after all, guidelines. I understand the impact in terms alignment and 
there are times when we have to trade strict compliance with one guideline to 
reap the benefits of complying with the another.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
---


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118390/
 ---
 
 (Updated June 2, 2014, 4:04 p.m.)
 
 
 Review request for Plasma, Solid and KDE Usability.
 
 
 Repository: powerdevil
 
 
 Description
 ---
 
 This is a series of UI updates I've applied to the powerdevil KCMs. You can 
 find them as individual patch series in the sebas/kcmupdates branch.
 
 General:
 - Less icon usage, especially in the form layouts
 - Title casing throughout
 - Better HIG compliance (not 100%, but improved)
 - Energy Saving / Actions UI now scales with dialog
 - Proper usage of FormLayouts
 - A bunch of cleanups of dead code
 - Parenting fixes
 
 In Detail:
 
 * Improve Advanced Settings page
 
 - Use a QFormLayout, and do it properly
 - Fix up spacing and alignment
 - Remove icons before titles
 - Use Title Case for Labels
 - Shorter labels for better readability
 
 * Clean up brightness-OSD-related dead code
 
 
 * Make powerdevil actions layout stretch out horizontally
 
 
 * Compile-time connections in actionconfigwidget
 
 
 * widget and layout parenting fixes
 
 
 * No bold font, increased spacing instead
 
 This removes the bold fonts from the checkboxes, as that is non-standard
 in the HIG. In order to make it look a bit more structured between the
 sections, a bit of spacing is added.
 
 * Remove icons from actions
 
 The icons are really small and add more visual noise than being useful.
 
 * Streamline Comments of KCMs
 
 
 * Clean up dead code
 
 
 Diffs
 -
 
   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 
 231c5d6 
   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
   daemon/actions/powerdevilaction.desktop 5b74fea 
   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
   daemon/powerdevil.desktop 20d31c9 
   kcmodule/activities/activitypage.cpp 48e9c6c 
   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
   kcmodule/common/actionconfigwidget.cpp 2161c84 
   kcmodule/common/actioneditwidget.cpp 4c67b4f 
   kcmodule/global/GeneralPage.cpp d025e42 
   kcmodule/global/generalPage.ui 2ce7cef 
   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
   kcmodule/profiles/EditPage.cpp a674ccb 
   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
   kcmodule/profiles/profileEditPage.ui dc26579 
   powerdevil.notifyrc 36acdb6 
 
 Diff: https://git.reviewboard.kde.org/r/118390

Re: Ship with Aurorae and Qtcurve or not...

[Andrew Lake]

On Fri, May 30, 2014 at 6:44 AM, Sebastian Kügler wrote:

 On Thursday, May 29, 2014 15:09:33 Marco Martin wrote:
  just to give a shot on every and single options, i gave a try to
 modifying
  oxygen in order to make it look like breeze (therefore sharing all the
  things  that it does that are not related to painting, like drag the
 window
  from anywhere)
  this is the half done, half missing attempt (ignore the non changed
  elements) http://wstaw.org/m/2014/05/29/plasma-desktophP1414.png
 
  is pretty hacky, but *maybe* is possible to have in the end only a
  different  stylehelper (and pixelmetrics/stylehints)
  so could be something worth exploring in the future

 That's pretty neat: I quite like the approach to change Oxygen, since it
 has a
 lot of knowledge encoded and is actively maintained. Have we talked with
 Hugo
 about ways to adjust Oxygen to Breeze?


Pretty cool stuff indeed!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

[Andrew Lake]

 On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote:
  Good improvements in general!
  There are two changes which are not HIG-compliant:
  - Control labels which are written next to the controls (checkboxes, spin 
  boxes etc.) do not use Title Capitalization. See 
  http://techbase.kde.org/Projects/Usability/HIG/Capitalization for details. 
  Therefore most of the capitalization changes have to be reverted, I'm 
  afraid.
  - For grouping controls (as in the case of Battery Levels and Events) the 
  HIG recommends using group boxes (see 
  http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply 
  spacing
  Apart from those two things, the changes look fine to me!

 - For grouping controls (as in the case of Battery Levels and Events) the HIG 
 recommends using group boxes (see 
 http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply 
 spacing

Hmm, may be time to update that portion of the HIG since, from a visual design 
standpoint, spacing can be quite effective at grouping visual elements while 
avoiding more visual chrome. In this case, for the Advanced page, a bit more 
spacing between the Battery Levels group and the Events group should provide 
enough visual distinction between the groups. Also, the checkboxes in the 
Events group can probably be left-aligned under Events since they're unrelated 
to the widgets from the Battery Levels group and likely better match the 
alignment guidelines for making the checkboxes span two columns 
(http://techbase.kde.org/Projects/Usability/HIG/Alignment).

Otherwise, the changes look quite nice to me!


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58692
---


On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118390/
 ---
 
 (Updated May 28, 2014, 11:33 p.m.)
 
 
 Review request for Plasma, Solid and KDE Usability.
 
 
 Repository: powerdevil
 
 
 Description
 ---
 
 This is a series of UI updates I've applied to the powerdevil KCMs. You can 
 find them as individual patch series in the sebas/kcmupdates branch.
 
 General:
 - Less icon usage, especially in the form layouts
 - Title casing throughout
 - Better HIG compliance (not 100%, but improved)
 - Energy Saving / Actions UI now scales with dialog
 - Proper usage of FormLayouts
 - A bunch of cleanups of dead code
 - Parenting fixes
 
 In Detail:
 
 * Improve Advanced Settings page
 
 - Use a QFormLayout, and do it properly
 - Fix up spacing and alignment
 - Remove icons before titles
 - Use Title Case for Labels
 - Shorter labels for better readability
 
 * Clean up brightness-OSD-related dead code
 
 
 * Make powerdevil actions layout stretch out horizontally
 
 
 * Compile-time connections in actionconfigwidget
 
 
 * widget and layout parenting fixes
 
 
 * No bold font, increased spacing instead
 
 This removes the bold fonts from the checkboxes, as that is non-standard
 in the HIG. In order to make it look a bit more structured between the
 sections, a bit of spacing is added.
 
 * Remove icons from actions
 
 The icons are really small and add more visual noise than being useful.
 
 * Streamline Comments of KCMs
 
 
 * Clean up dead code
 
 
 Diffs
 -
 
   kcmodule/profiles/profileEditPage.ui 
 dc2657943a2bb63f137ad11b77b254b3782f0407 
   kcmodule/profiles/powerdevilprofilesconfig.desktop 
 e95b908dfea30a4a15ccd8c89d4ceb36256e2185 
   kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 
   kcmodule/global/powerdevilglobalconfig.desktop 
 1d4aa2238b2fa02dfa984f9163f133c941ff509e 
   kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 
   kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 
   kcmodule/common/actioneditwidget.cpp 
 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 
   kcmodule/common/actionconfigwidget.cpp 
 2161c84b68e5fc3b56240a482ed77825ce4a5f03 
   kcmodule/activities/powerdevilactivitiesconfig.desktop 
 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 
   kcmodule/activities/activitypage.cpp 
 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd 
   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 
 4d96273697f11864716dae0204009d52264be99f 
   daemon/actions/bundled/runscriptconfig.cpp 
 c0d3adb6651320702bb6503e505b6ebdc06d6004 
   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 
 31772679560a256dcf9f66aefbb4cf02351bd5d3 
   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 
 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 
   daemon/actions/bundled/dimdisplayconfig.cpp 
 f683935994e4a5a08fd7da6ceb95ba7b726ac708 
   daemon/actions/bundled/brightnesscontrolconfig.cpp 
 

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---

Ship it!


Ship It!

- Andrew Lake


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118337/
 ---
 
 (Updated May 27, 2014, 9:42 a.m.)
 
 
 Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
 Pfeiffer.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 
 PM_DefaultLayoutSpacing is deprecated and replaced by both
 PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
 
 Qt Layouts now query for these, not the default spacing.
 
 See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
 
 There are some other deprecated enums, which are mostly not a problem.
 
 
 Diffs
 -
 
   kstyle/oxygenstyle.cpp 8bcb79a 
 
 Diff: https://git.reviewboard.kde.org/r/118337/diff/
 
 
 Testing
 ---
 
 Spacing between labels and controls is now restored o/
 
 
 File Attachments
 
 
 compositing_kcm
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Andrew Lake]

 On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
  Ship It!

In case anyone is wondering why this arbitrary fellow said Ship It!, I just 
wanted to provide an explicit thumbs up that this matches the 4px spacing basis 
grid recommended in the HIG 
(http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We 
can tackle individual layout designs separately to get the spacing even better.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118337/
 ---
 
 (Updated May 27, 2014, 9:42 a.m.)
 
 
 Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
 Pfeiffer.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 
 PM_DefaultLayoutSpacing is deprecated and replaced by both
 PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
 
 Qt Layouts now query for these, not the default spacing.
 
 See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
 
 There are some other deprecated enums, which are mostly not a problem.
 
 
 Diffs
 -
 
   kstyle/oxygenstyle.cpp 8bcb79a 
 
 Diff: https://git.reviewboard.kde.org/r/118337/diff/
 
 
 Testing
 ---
 
 Spacing between labels and controls is now restored o/
 
 
 File Attachments
 
 
 compositing_kcm
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Andrew Lake]

 On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
  Ship It!
 
 Andrew Lake wrote:
 In case anyone is wondering why this arbitrary fellow said Ship It!, I 
 just wanted to provide an explicit thumbs up that this matches the 4px 
 spacing basis grid recommended in the HIG 
 (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We 
 can tackle individual layout designs separately to get the spacing even 
 better.
 
 Christoph Feck wrote:
 I hope no HIG ever suggest a fixed amount of pixels, but an amount 
 relative to the font size.

Till we get a credible resolution-independent approach to laying out all visual 
elements, including typeface, pixels is probably the best guidance guidance we 
can come up with.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/118337/
 ---
 
 (Updated May 27, 2014, 9:42 a.m.)
 
 
 Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
 Pfeiffer.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 
 PM_DefaultLayoutSpacing is deprecated and replaced by both
 PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
 
 Qt Layouts now query for these, not the default spacing.
 
 See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
 
 There are some other deprecated enums, which are mostly not a problem.
 
 
 Diffs
 -
 
   kstyle/oxygenstyle.cpp 8bcb79a 
 
 Diff: https://git.reviewboard.kde.org/r/118337/diff/
 
 
 Testing
 ---
 
 Spacing between labels and controls is now restored o/
 
 
 File Attachments
 
 
 compositing_kcm
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Next visual polish feedback from VDG core folks

[Andrew Lake]

Great, thanks. Bug reports it is. :-)

Andrew


On Sat, May 24, 2014 at 8:33 AM, Eike Hein h...@kde.org wrote:


  Feedback on visual glitches bugs is as useful as any other bug report.


 What's more, poor visual polish is a critical barrier to
 adoption. Assuming we're of the opinion that people using
 our stuff is a swell idea, we should treat the problems
 as important.

 Developers tend not to because it doesn't match their own
 experience of the system, or their value system, but that
 doesn't mean that I'm not using it because it looks fugly
 isn't very _real_, and often less subjective than one
 might think.


 Cheers,
 Eike

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Next visual polish feedback from VDG core folks

[Andrew Lake]

Hello all,

I just had a quick question. If I have some feedback on areas to visually
polish up for the Plasma Next release, should I file a bug or just share
them via the email list?

I honestly would rather just pitch in and submit review requests for
patches but, unfortunately, I just don't have the bandwidth to do that. And
*really* I hate being that guy in the peanut gallery yapping on about
visuals and not pitching in to try to fix them. But I also didn't want to
just be silent if the feedback would be useful.

Anyway, let me know your preference.

Thanks for your help and patience,
Andrew Lake
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

[Andrew Lake]

No problem on merging Marco.


On Fri, May 16, 2014 at 4:39 AM, Marco Martin notm...@gmail.com wrote:

 On Thursday 15 May 2014, Marco Martin wrote:
  On Monday 05 May 2014, Andrew Lake wrote:
   I went ahead and added a 'working' branch and added the following:
  going into resuscitating dead threads again:
 
  can the working branch be merged now?

 ping again,
 just to remind about how horribly late we are about all of this
 (ie later today i am going to merge, no matter what)

 --
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Andrew Lake]

On Fri, May 16, 2014 at 6:29 AM, Jens Reuterberg wrote:

 I am already pinged and have pinged Andrew


Best I can tell, the new Plasma Next plan for visuals is:
* Widget style: QtCurve with Breeze settings applied for qt4 and qt5
QWidget apps
* Window decoration: Oxygen with background gradient off (looks quite
decent to me)
* Icons: (Actions/Places icons from new theme + Oxygen)? OR (the new
theme)? I'm ok with either approach.
* Plasma theme: Breeze (done)
* Cursors: Breeze (done)
* Colors: Breeze color scheme

That all looks great to me. I'm not sure what else I can do from my end to
help, but if there's anything I can do please let me know.

Do we need to get the icons into the breeze project repo?
Are there any other visual assets that are needed but not yet in place?
Are there any tweaks needed to any of the existing visual assets that I can
help with from the VDG side?

Thanks,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Where we are now... (VDG)

[Andrew Lake]

On May 13, 2014 4:55 AM, Ivan Čukić wrote:

  I tried that last week, and it looked really underwhelming. We *can*
remove
  gradient and adjust color scheme, but at that point, it becomes clear
that
  our artwork is half-assed, in Oxygen, the Breeze color scheme lacks
depth
  and contrast. Try it for yourself.

 I have tried it and have to agree. The colour scheme does not suit oxygen
at
 all.


Thanks, this is helpful. The main motivation was to make the application
and the desktop portions look a little less like they're from different
ends of the universe. It seems that specific color scheme didn't accomplish
that. I think we can come up with a color scheme better suited to Oxygen
(better depth and contrast) and that uses a similar palette to the plasma
theme. If we think its worth it I'll do that today.

Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt Quick Controls style

[Andrew Lake]

Thanks for testing and reporting this Jan. The style needs to be tested
like this to uncover any issues and so that we'll eventually have a fully
functional, first class Qt Quick Controls style.

Thanks again!

Andrew


On Mon, May 12, 2014 at 7:43 AM, Jan Grulich jgrul...@redhat.com wrote:

 On Monday 12 of May 2014 16:32 David Edmundson wrote:
  On Mon, May 12, 2014 at 3:49 PM, Jan Grulich jgrul...@redhat.com
 wrote:
   I just tested it with our fresh QML version of kde-nm-connection editor
   and I found two issues:
  
   1) Headers in TableView don't have visible sort indicators
 
  It seems [2] is showing the sort indicator.
 
  Does it only not work with the qtcurve theme?
  Can you see if that theme works in oxygen-demo?
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel

 I have set sortIndicatorVisible to true and it works with qtcurve theme and
 also in oxygen-demo, so I guess something is missing in Breeze style,
 because
 I'm able to change sorting order, but I don't see indicators.

 Jan

 --
 Jan Grulich
 Red Hat Czech, s.r.o
 jgrul...@redhat.com
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt Quick Controls style

[Andrew Lake]

Oh and the style is now officially housed in the Breeze project
repo: g...@git.kde.org:breeze.git

Thanks much



On Mon, May 12, 2014 at 7:43 AM, Jan Grulich jgrul...@redhat.com wrote:

 On Monday 12 of May 2014 16:32 David Edmundson wrote:
  On Mon, May 12, 2014 at 3:49 PM, Jan Grulich jgrul...@redhat.com
 wrote:
   I just tested it with our fresh QML version of kde-nm-connection editor
   and I found two issues:
  
   1) Headers in TableView don't have visible sort indicators
 
  It seems [2] is showing the sort indicator.
 
  Does it only not work with the qtcurve theme?
  Can you see if that theme works in oxygen-demo?
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel

 I have set sortIndicatorVisible to true and it works with qtcurve theme and
 also in oxygen-demo, so I guess something is missing in Breeze style,
 because
 I'm able to change sorting order, but I don't see indicators.

 Jan

 --
 Jan Grulich
 Red Hat Czech, s.r.o
 jgrul...@redhat.com
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze QML window decoration

[Andrew Lake]

On Mon, May 5, 2014 at 6:54 AM, Martin Gräßlin wrote:

 On Sunday 04 May 2014 22:28:23 Andrew Lake wrote:
  Based on the design we came up with in the VDG forum, I completed a first
  go at doing up a Aurorae QML window decoration.
 
  I added it to the 'working' branch of the Breeze repo. As far as I can
 tell
  it works about as well as the Plastik QML decoration.

 some feedback after running the deco for most of today:
 * in maximized state there is still a round corner in top left and top
 right
 * I experience a slight flicker when mouse over buttons
 * there's a config dialog (which looks like forked from Plastik) which is
 not
 updated in the deco? Maybe remove?
 * Changing button sizes has no effect - this is important for accessibility


I made a few updates that should fix most of these issues now. Thanks for
everyone's patience.

Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Where we are now... (VDG)

[Andrew Lake]

On Mon, May 12, 2014 at 1:22 AM, Marco Martin wrote:

 so of all that, let's see what we have, what we don't and how we can make
 shippable

 * plasma theme: check
 * wallpaper: once is ready, where we do put it?
 * widget style: we have the qtcurve settings, i failed as well to contact
 the
 (supposedly new) maintainers
 * icons: those should also be imported somewhere
 * am i missing something?


The full list in the Breeze project repo is:
* colors - ready to ship (still need to set as default)
* cursors - ready to ship as default (I assume this is being set as default)
* widget styles: qtcurve settings - ready to ship (Also need to ship
QtCurve as an included style like Fusion and MS Window 9x. Still need
to figure out how to get QtCurve to use it by default since its settings UI
is not yet in Qt5 port.)
* widget styles: Qt Quick controls style - A few bug fixes remain but
should be ready to ship
* window decoration: Aurorae QML - ready to ship
* window decoration: Aurorae svg - ready to ship
* wallpapers: once they're ready I say put 'em here. We'll need to get them
selected and a default chosen before the artwork freeze on May 29th (is
that date still right?)

 Not in the Breeze project repo:
* plasma theme - ready to ship (probably a few minor fixes before artwork
freeze)
* icons - with the actions complete pretty well fleshed out and everything
else baselined on Flattr, I'm thinking we're closing in on something very
much shippable.

If it's not already done, we still need to disable the oxygen background
gradient since, far as I can tell, that's still our default window
decoration and widget style for the first release.

Hope this helps!

Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

[Andrew Lake]

On May 5, 2014 4:32 AM, Marco Martin wrote:

 On Monday 05 May 2014, Andrew Lake wrote:
  - Window Decoration: I added the newly implemented Aurorae QML window
  decoration and the current Aurorae SVG theme (which has a some buttons
  missing for now).

 I am seeing a  qml folder with the actual aurorae decoration and an svg
 folder with graphics, but no cmake to install it.
 shouldn't be in the same package as the qml files?

No, actually those are two separate Auroras themes. One is the new
QML-based theme - no svg, no C++. One is the old-style svg based theme
we've been using on Plasma Current for quick validation. For Plasma Next
the QML-based one is the target and is the most complete one right now.

Hope this helps,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

[Andrew Lake]

On May 5, 2014 5:55 AM, Marco Martin wrote:
 ok,
 so now everything is installed by the toplevel cmake, hopefully in the
proper
 place.

Yay, thanks!

One thing I noticed, does the top level cmake include the Breeze color
scheme? Both the controls style and the QML windec use the system color
scheme, so the visuals won't be quite complete without it.

Thanks again Marco!
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel