Re: Can we remove or quiet down the commit bot in the chatrooms

[Carson Black]

Or in the territory of using a Matrix bot to post commits, I could add
Matrix capabilities to my bot [1] that's already been monitoring
invent.kde.org for roughly a year now and has been posting notifications to
Telegram for that time.

[1] https://invent.kde.org/cblack/kijetesantakalu_lukin

Carl Schwan  schrieb am Mi., 19. Mai 2021, 14:48:

> Le mercredi, mai 19, 2021 8:37 PM, Nate Graham  a écrit :
>
> > I find it rather difficult to use #plasma for chats and discussions
> > because of the near-constant spam from the commit announcement bot.
> >
> > It's not that it's useless to have commits announced, but when it
> > happens in a room where humans are interacting, it's rather disruptive
> > and spammy. Maybe we could move the bot into a dedicated commit announce
> > room so that the people who care about this can still see the
> > announcements there?
>
> I did something similar in kde-www and ihmo this is so much better
> experience.
> >
> > Alternatively could we change the bot so that it sends one message for
> > each commit instead of like 4 or 5?
>
> Another alternative would be to switch from skreamer for commit
> notification
> to the Matrix gitlab bot[1]. This provides the improvement of sending
> notifications as notices in Matrix so that Matrix clients don't create
> notifications for these type of messages and also display the events using
> a lighter color. This would also notify us about new MR (but I guess this
> is configurable if not desirable).
>
> Carl
>
> [1]: https://github.com/maubot/gitlab
> >
> > Nate
>
>
>

T13927: Pop shell in KDE Plasma

[Carson Black]

cblack added a comment.


  In T13927#245978 , @ngraham wrote:
  
  > What is "pop shell"?
  
  
  Pop Shell is the name of the extension that system76 ships with their GNOME 
shell to make the window management closer to tiling WMs or Android/iPadOS

TASK DETAIL
  https://phabricator.kde.org/T13927

To: plasma-devel, cblack
Cc: cblack, niccolove, ngraham, rafasantos, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29876: ScreenPool: Store primary connector separately

[Carson Black]

cblack added a comment.


  Thanks for the patch, however we use GitLab now for contributing code.
  
  Would you mind opening this as an MR at 
https://invent.kde.org/plasma/plasma-workspace?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29876

To: genpfault
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack abandoned this revision.
cblack added a comment.


  https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/305

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack added a comment.


  oooh man, this'll be a doozy to rebase :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack added a comment.


  In D27271#676512 , @ngraham wrote:
  
  > Could you move this and the dependent patches to Gitlab? It would be good 
to get this in for 5.21.
  
  
  Sure

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack added a comment.


  In D29466#676411 , @ngraham wrote:
  
  > Putting it in KRunner could make at least a little bit of sense if it 
worked everywhere--i.e. with in-window menubars as well. However since it does 
not, I think the current location makes sense.
  >
  > Could you move this to GitLab maybe?
  
  
  https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/134

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: meven, ngraham, ognarb, Leon0402, trmdi, nicolasfella, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:ea978ea6eb36: [kstyle] Tools area (authored by cblack).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=83075=83253

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27669: [kstyle] Tools area

[Carson Black]

cblack added a comment.


  In D27669#673112 , @ndavis wrote:
  
  > what are some ways the issue of toolbar colors not being perfectly in sync 
with titlebar colors could be fixed or worked around?
  
  
  When animating? Wayland.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> nicolasfella wrote in appmenumodel.h:70
> const

actions are needed as non-const

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack updated this revision to Diff 83175.
cblack marked 5 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29466?vs=82144=83175

BRANCH
  arcpatch-D29466

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 83095.
cblack added a comment.


  Rename to kcm_users

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=83079=83095

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/kcm_users.desktop
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29395: Refactor MediaController

[Carson Black]

cblack updated this revision to Diff 83084.
cblack added a comment.


  Guess that segfault wants to resolve itself :D

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29395?vs=83073=83084

BRANCH
  arcpatch-D29395_1

REVISION DETAIL
  https://phabricator.kde.org/D29395

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/Media.qml
  applets/mediacontroller/contents/ui/main.qml
  applets/mediacontroller/contents/ui/qmldir

To: cblack, #plasma
Cc: iasensio, broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in UserDetailsPage.qml:97
> Pfp?

profile picture

> broulik wrote in UserDetailsPage.qml:219
> Is this `RowLayout` needed?

it's a convenience for the default alignment of a layout (`Qt.AlignVCenter | 
Qt.AlignLeft`)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29395: Refactor MediaController

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Media.qml:6
> Make this a `QtObject`

Seems to cause a segfault with the data source.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: iasensio, broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29464: [applets/appmenu] Hide old menu before showing new menu

[Carson Black]

cblack closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29464

To: cblack, #plasma, #kwin, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29464: [applets/appmenu] Hide old menu before showing new menu

[Carson Black]

cblack updated this revision to Diff 83083.
cblack added a comment.


  Only do that on Wayland

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29464?vs=82041=83083

BRANCH
  arcpatch-D29464

REVISION DETAIL
  https://phabricator.kde.org/D29464

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

To: cblack, #plasma, #kwin, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 83079.
cblack added a comment.


  Focus the stackSwitcher when opening the sheet

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=83074=83079

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 83075.
cblack added a comment.


  Properly determine if tools area should be drawn on QDialogs with auto set

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=81137=83075

BRANCH
  arcpatch-D27669_2

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 83074.
cblack marked 17 inline comments as done.
cblack added a comment.


  Address code concerns; add escape keyboard gesture

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82214=83074

BRANCH
  arcpatch-D28154_1

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29395: Refactor MediaController

[Carson Black]

cblack updated this revision to Diff 83073.
cblack marked 8 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29395?vs=81831=83073

BRANCH
  arcpatch-D29395

REVISION DETAIL
  https://phabricator.kde.org/D29395

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/Media.qml
  applets/mediacontroller/contents/ui/main.qml
  applets/mediacontroller/contents/ui/qmldir

To: cblack, #plasma
Cc: broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> broulik wrote in ExpandedRepresentation.qml:99
> Unrelated cleanup

a cleanup is unrelated in a cleanup patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29465: [applets/appmenu] Improve menu feel

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bf337f552a02: [applets/appmenu] Improve menu feel 
(authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29465?vs=82043=83069

REVISION DETAIL
  https://phabricator.kde.org/D29465

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29694: Introduce Avatar component

[Carson Black]

cblack added a comment.


  This is being moved to GitLab.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29694

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson

D29694: Introduce Avatar component

[Carson Black]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:cce0214570af: Introduce Avatar component (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29694?vs=82961=83049

REVISION DETAIL
  https://phabricator.kde.org/D29694

AFFECTED FILES
  src/CMakeLists.txt
  src/avatar.cpp
  src/avatar.h
  src/controls/Avatar.qml
  src/controls/templates/private/BorderPropertiesGroup.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson

D28873: Add SwipeNavigator component

[Carson Black]

cblack abandoned this revision.
cblack added a comment.


  Moving to a GitLab MR

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, 
plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, 
davidedmundson

D28873: Add SwipeNavigator component

[Carson Black]

cblack added a comment.


  In D28873#672598 , @mart wrote:
  
  > what should happen in this case?
  >  F8331924: Screenshot_20200518_114607.png 

  
  
  My answer would be "set a minimum window size", though on mobile that 
probably wouldn't be applicable.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, 
plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, 
davidedmundson

D28873: Add SwipeNavigator component

[Carson Black]

cblack updated this revision to Diff 82965.
cblack added a comment.


  Improve the small toolbar

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28873?vs=82962=82965

BRANCH
  cblack/lateral (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28873

AFFECTED FILES
  src/controls/Page.qml
  src/controls/SwipeNavigator.qml
  src/controls/private/SwipeTabBar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg
Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, 
plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, 
davidedmundson

D28873: Add SwipeNavigator component

[Carson Black]

cblack updated this revision to Diff 82962.
cblack added a comment.


  Rebase on master

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28873?vs=80804=82962

BRANCH
  cblack/lateral (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28873

AFFECTED FILES
  src/controls/Page.qml
  src/controls/SwipeNavigator.qml
  src/controls/private/SwipeTabBar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg
Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, 
plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, 
davidedmundson

D29694: Introduce Avatar component

[Carson Black]

cblack updated this revision to Diff 82961.
cblack added a comment.


  Unsplit template and control for documentation purposes

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29694?vs=82957=82961

BRANCH
  cblack/avatar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29694

AFFECTED FILES
  src/CMakeLists.txt
  src/avatar.cpp
  src/avatar.h
  src/controls/Avatar.qml
  src/controls/templates/private/BorderPropertiesGroup.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson

D29694: Introduce Avatar component

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> mart wrote in Avatar.qml:52
> enum values should be written and explained here

F8323278: ksnip_20200515-114734.png 

Unfortunately; splitting into a template throws documentation out of the 
window; which is why I didn't use one initially.

I don't really like writing documentation if it's not going to be seen.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29694

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson

D29694: Introduce Avatar component

[Carson Black]

cblack updated this revision to Diff 82957.
cblack marked 3 inline comments as done.
cblack added a comment.


  Split into a template; make borders customisable

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29694?vs=82783=82957

BRANCH
  cblack/avatar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29694

AFFECTED FILES
  src/CMakeLists.txt
  src/avatar.cpp
  src/avatar.h
  src/controls/Avatar.qml
  src/controls/templates/Avatar.qml
  src/controls/templates/private/BorderPropertiesGroup.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson

D29694: Introduce Avatar component

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> mart wrote in kirigamiplugin.cpp:259
> I don't like this, as even tough is called "private" is really public api as 
> there isn't really any way to make a c++ type not accessible.
> nothing in that c++ class seems really to be necessary to be c++

the string manipulation used for generating initials isn't particularly 
feasible to do in javascript; especially the stuff that prods QChars

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29694

To: cblack, #kirigami, #vdg, mart
Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, davidedmundson

D28873: Add SwipeNavigator component

[Carson Black]

cblack added a comment.


  In D28873#671043 , @ngraham wrote:
  
  > In that window, there's plenty of space for the component to expand 
horizontally. I would prefer to avoid scrolling tabs; their interaction is 
usually not great.
  
  
  It's collapsing because there isn't enough space to fit all of the labels.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, 
fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D29694: Introduce Avatar component

[Carson Black]

cblack updated this revision to Diff 82783.
cblack added a comment.


  Avoid trying to display initials of non-Latin characters

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29694?vs=82780=82783

BRANCH
  cblack/avatar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29694

AFFECTED FILES
  src/CMakeLists.txt
  src/avatar.cpp
  src/avatar.h
  src/controls/Avatar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg
Cc: ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, ahiemstra, davidedmundson, mart

D29694: Introduce Avatar component

[Carson Black]

cblack created this revision.
cblack added reviewers: Kirigami, VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
filipf added a comment.
cblack updated this revision to Diff 82775.
cblack edited the test plan for this revision.
cblack updated this revision to Diff 82776.
cblack updated this revision to Diff 82777.
cblack updated this revision to Diff 82778.
cblack updated this revision to Diff 82780.
cblack requested review of this revision.


  Cool stuff. The commit message needs to be expanded to explain where and how 
this will be used, and also needs to list key implentation feats (initials, 
colors).
  
  I believe we use avatars in launcher menus, the user menu, and lock, login, 
logout (3L) screens. The 3L have no action involved with the avatar so there's 
no need to buttonify it in any way for that use case. Visually they're fine as 
is. Launcher menus and the kcm are obviously different. But the main question 
is actually what do we intend to do with not using Kirigami on the desktop? 
That makes this component only usable in kcms?

cblack added a comment.


  Add documentation; fix bugs.

cblack added a comment.


  EOF newline

cblack added a comment.


  EOF newline for the QML file

cblack added a comment.


  Code hygiene

cblack added a comment.


  Comment the code.

REVISION SUMMARY
  An Avatar component displays an avatar.

TEST PLAN
  F8317303: ksnip_20200513-134838.png <https://phabricator.kde.org/F8317303> 
(2x scale)
  
Row {
spacing: Kirigami.Units.smallSpacing
Kirigami.Avatar {
name: "Carson Black"
}
Kirigami.Avatar {
name: "Marco Martin"
}
Kirigami.Avatar {
name: "Carl Schwan"
}
Kirigami.Avatar {
name: "Kai Uwe Broulik"
}
Kirigami.Avatar {
name: "Nate Graham"
}
Kirigami.Avatar {
name: "Roman Gilg"
initialsMode: Kirigami.Avatar.InitialsMode.UseIcon
}
Kirigami.Avatar {
name: "David Redondo"
source: "/home/jpontaoski/Pictures/Barista/barista.svg.png"
}
}

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/avatar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29694

AFFECTED FILES
  src/CMakeLists.txt
  src/avatar.cpp
  src/avatar.h
  src/controls/Avatar.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, #vdg
Cc: filipf, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29288: Improve PageRouter API

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:db704d344b2c: Improve PageRouter API (authored by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29288?vs=81555=82567

REVISION DETAIL
  https://phabricator.kde.org/D29288

AFFECTED FILES
  examples/PageRouterWatchedRoute.qml
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D29637: Introduce ImageColors

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> colorutils.h:182
> +/**
> + * Returns the Cielab "Chroma" of the color which is a slightly better 
> quantificator for how much a color appears 
> https://en.wikipedia.org/wiki/Colorfulness
> + * This is how much a color looks diffenent from a gray of the same

Returns the CIELAB chroma of the given color.
  
  CIELAB chroma may give a better quantification of how vibrant a color is 
compared to HSV saturation.
  
  \sa https://en.wikipedia.org/wiki/Colorfulness
  \sa https://en.wikipedia.org/wiki/CIELAB_color_space

> imagecolors.h:64-70
> + * The source which colors should be analyzed, it can be:
> + * * Any Item: it will be rendered to an image and the static grab 
> + * analyzed. It won't be updated if the item changes, but manual 
> + * calls to update() are needed.
> + * * A QImage (for example coming from a QAbstractItemModel data role)
> + * * A QIcon (for example coming from a QAbstractItemModel data role)
> + * * An icon name: an icon name present in the theme.

The source from which colors should be extracted from.
  `source` can be one of the following:
  * Item
  * QImage
  * QIcon
  * Icon name
  
  Note that an Item's color palette will only be extracted once unless you call 
`update()`, regardless of how the item hanges.

> imagecolors.h:75-82
> + * A list of the color palette extracted from the image.
> + * It uses K-means-clustering tecnique, by averaging groups of
> + * "similar" colors https://en.wikipedia.org/wiki/K-means_clustering
> + * it's a list of maps containing the following keys:
> + * * "color": the color of the cluster
> + * * "ratio": the ratio from 0 to 1 of diffusion of the cluster in the 
> image
> + * * "contrastingColor": another color from the clusters (if possible) 
> that is the nearest to its negative

A list of colors and related information about then.
  
  Each list item has the following properties:
  * `color`: The color of the list item.
  * `ratio`: How dominant the color is in the source image.
  * `contrastingColor`: The color from the source image that's closest to the 
inverse of `color`.
  
  The list is sorted by `ratio`; the first element is the most dominant color 
in the source image and the last element is the least dominant color of the 
image.
  
  \note K-means clustering is used to extract these colors; see 
https://en.wikipedia.org/wiki/K-means_clustering.

> imagecolors.h:86-89
> +/**
> + * If true, it should be considered a "Dark" color palette (this if the 
> dominant color is darker than a 50% gray
> + */
> +Q_PROPERTY(bool isDarkPalette READ isDarkPalette NOTIFY paletteChanged)

I think it would be better to have this return a `ColorUtils::Brightness` enum.

> imagecolors.h:92
> +/**
> + * The average color of the whole image.
> + */

The average color of the source image.

> imagecolors.h:97
> +/**
> + * The dominant color of the image. This is the color of the cluster 
> which covers the bigger area of the image
> + */

The dominant color of the source image.
  
  The dominant color of the image is the color of the largest cluster in the 
image.
  \sa https://en.wikipedia.org/wiki/K-means_clustering

> imagecolors.h:102
> +/**
> + * Suggested "contrasting" color to the dominant one. It's the color in 
> the palette nearest to the negative of the dominant
> + */

The color closest to the inverse of the dominant color found in the source 
image.

> imagecolors.h:107-109
> + * An "accent" color extracted from the image, heuristically found most 
> "vibrant" color from the cluster with highest CIELab Chroma
> + * https://en.wikipedia.org/wiki/Colorfulness#Chroma
> + * which is a better indication than saturation as doesn't decrease with 
> lightness

An accent color extracted from the source image.
  
  The accent color is the color cluster with the highest CIELAB chroma in the 
source image.
  
  \sa https://en.wikipedia.org/wiki/Colorfulness#Chroma

> imagecolors.h:114-116
> + * A color suggested for foreground items over the image
> + * * on dark palettes will be closestToWhite if light enough, or a very 
> light gray otherwise
> + * * on light palettes will be closestToBlack if dark enough or a very 
> dark gray

A color suitable for rendering text and other foreground over the source image.
  
  On dark items, this will be the color closest to white in the image if it's 
light enough, or a bright gray otherwise.
  On light items, this will be the color closest to black in the image if it's 
dark enough, or a dark gray otherwise.

> imagecolors.h:120-124
> +/**
> + * A color suggested for background items over the image, like a dialog 
> frame
> + * * on light palettes will be closestToWhite if light enough, or a very 
> light gray otherwise
> + * * on dark palettes will be closestToBlack if dark enough or a very 
> dark gray
> + 

D29637: Introduce ImageColors

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> imagecolorstest.qml:1
> +
> +import QtQuick 2.12

There's no test cases here, this should probably go in examples.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29637

To: mart, #kirigami
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Carson Black]

cblack added a comment.


  While this is neat, I'm fairly sure that creating the CSS for this in a 
manner that works across themes is going to be hard if not impossible. Even our 
own Breeze GTK uses palette swaps rather than unique pixmaps for every state.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29535: Change panel thickness adjustment UI to use a SpinBox

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> ToolBar.qml:119-120
> +
> +from: 2
> +to: 960
> +stepSize: 2

These values seem arbitrary. Could it be possible to base off the screen 
dimensions?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29535

To: ngraham, abetts, #vdg, #plasma
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

[Carson Black]

cblack added a comment.


  In D29514#665869 , @ngraham wrote:
  
  > Hmm, on my system, the file is located at 
`/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find 
it:
  >
  >   -- The following features have been disabled:
  >  
  >* XorgServer, XServer header needed for touchpad KCM (X11 backend)
  >  
  >   -- The following OPTIONAL packages have not been found:
  >  
  >* XorgServer, XServer header needed for touchpad KCM (X11 backend)
  >
  
  
  That's the source package location, not where you'd expect to find the 
headers for usage by other packages. You'd probably be looking for 
`/usr/include/xorg/xserver-properties.h`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29514

To: asturmlechner, #plasma, zzag
Cc: cblack, ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82214.
cblack marked 4 inline comments as done.
cblack added a comment.


  Parent temporary file to the application

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82212=82214

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82212.
cblack added a comment.


  realize you forgot to change the name of the argument in the body as well

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82211=82212

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82211.
cblack added a comment.


  Refine method signature and add a comment for less ambiguity

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82210=82211

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:121
> Normally the app creating a temp file would clean it up.
> 
> A quick fix would be
> file = new QTemporaryFile(this);
> 
> It's sort of leaking the object, but on exit it'll tidy everything up.

that looks like it could possibly run into race conditions, as the applyjob is 
executed asynchronously and IIRC is able to still be running when everything 
else, including this, has destructed and removed one of the files it could be 
using

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82210.
cblack marked an inline comment as done.
cblack added a comment.


  Parent the dynamically created user to the model

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82209=82210

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29288: Improve PageRouter API

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> cblack wrote in pagerouter.h:443
> It could possibly be a list, but not of pure strings. You want to be able to 
> watch a list of routes?

Watching a list of routes is probably going to result in both clunky code and 
clunky API design in return for minimal gains.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29288

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82209.
cblack marked 4 inline comments as done.
cblack added a comment.


  Address some of the code feedback from d_ed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82158=82209

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack marked 5 inline comments as done.
cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:94
> what's this for?

used as a hook for QML to know when the KCM needs to apply

> davidedmundson wrote in kcm.cpp:97
> This is an odd method name.
> 
> I don't really understand what it's doing, some sort of title casing?

taking the initials of a user's real name

> davidedmundson wrote in kcm.cpp:121
> so who cleans this up?

whoever is normally cleaning up tempfiles

> davidedmundson wrote in usermodel.cpp:72
> why are we resetting the whole model instead of just dataChanged() on the 
> relevant row

i couldn't figure out how to use those correctly. some help would be 
appreciated.

> davidedmundson wrote in usermodel.cpp:78
> The ones not logged in will be sorted randomly.
> 
> Also note that if the intention is to have your user at the top, this check 
> won't suffice as you can have 2 things logged in.

> Also note that if the intention is to have your user at the top, this check 
> won't suffice as you can have 2 things logged in.

loggedIn compares the UID of the user to the UID of the currently running 
program, which means only one user can be logged in at a time by our metric.

> davidedmundson wrote in usermodel.cpp:96
> this is marked as done, yet I can't see where ?

users are parented to the model, which will use normal QObject destructor 
behaviour to clean them

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29288: Improve PageRouter API

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> mart wrote in pagerouter.h:443
> could this be just a QStringList?

It could possibly be a list, but not of pure strings. You want to be able to 
watch a list of routes?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29288

To: cblack, #kirigami
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82158.
cblack marked 9 inline comments as done.
cblack added a comment.


  Address code and icon feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82150=82158

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29081: [QStyle] Make menu titles look less like menu items

[Carson Black]

cblack added a comment.


  In D29081#665203 , @ndavis wrote:
  
  > Big +1 to the idea, but this shouldn't use `darker()` because that won't 
look right in Breeze Dark.
  
  
  Personally, I think this will look fine when always using `darker()`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82150.
cblack added a comment.


  Fix faceValid checking

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82137=82150

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack updated this revision to Diff 82144.
cblack added a comment.


  Clear search text on application change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29466?vs=82141=82144

BRANCH
  cblack/appmenu-search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack updated this revision to Diff 82141.
cblack added a comment.


  Add better non-Wayland guards

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29466?vs=82138=82141

BRANCH
  cblack/appmenu-search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack added a comment.


  In D29466#665145 , @gikari wrote:
  
  > Is it possible to integrate the search into the help menu, if it exists 
already or create an entry for it. Much like macOS does.
  >  F8290151: Screenshot_20200506_214642.png 

  
  
  There's no reliable way to figure out which menu is the "help" one, and 
there's not a reliable way of modifying a menu for this kind of functionality 
besides appending a new entry to the end.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack updated this revision to Diff 82125.
cblack added a comment.
cblack updated this revision to Diff 82138.
cblack added a dependency: D29486: xdgshellclient: Allow menus from panels to 
take focus.
cblack requested review of this revision.


  Better search

cblack added a comment.


  Fix some quirks

REVISION SUMMARY
  The global application menu has a search field now

TEST PLAN
  F8288104: ksnip_20200505-223308.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82137.
cblack added a comment.


  begone, kule

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82135=82137

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82135.
cblack added a comment.


  Make sure arc diff does what it should

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82048=82135

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> systemclipboard.cpp:61
> +
> +#include "qwayland-wlr-data-control-unstable-v1.h"
> +

Is there a reason this `#include` is all the way down here instead of at the 
top of the file?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28154: Add users KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:54
> Could this be a BasicListItem with a title and subtitle, or is that not 
> possible because you can't render the avatar+circle into an image source to 
> feed it?

Not possible, AFAIK. At least not as long as grabbing to an image fails. Would 
also be inefficient compared to just having the items directly in the 
scenegraph.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82048.
cblack added a comment.


  Address code issue and add reset functionality

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82046=82048

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82046.
cblack marked an inline comment as done.
cblack added a comment.


  Fix item alignment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82025=82046

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29465: [applets/appmenu] Improve menu feel

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The appmenu applet now accurately replicates the hover behaviour of a regular 
menubar.

TEST PLAN
  Before: you need to click to engage all menus.
  After: the appmenu applet copies the behaviour of a QMenuBar when it comes to 
clicks and hovers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-better-menu-behaviour (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29465

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29464: [applets/appmenu] Hide old menu before showing new menu

[Carson Black]

cblack added a comment.


  FWIW, I don't notice the flickering behaviour mentioned in the comment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29464

To: cblack, #plasma, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29464: [applets/appmenu] Hide old menu before showing new menu

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Hiding the old menu after the new menu is shown isn't possible on Wayland:
  
qt.qpa.wayland: setGrabPopup called with a parent, 
QtWaylandClient::QWaylandXdgSurface(0x17dd550) which does not match the current 
topmost grabbing popup, QtWaylandClient::QWaylandXdgSurface(0x120d9f0) 
According to the xdg-shell protocol, this is not allowed. The wayland QPA 
plugin is currently handling it by setting the parent to the topmost grabbing 
popup. Note, however, that this may cause positioning errors and popups closing 
unxpectedly because xdg-shell mandate that child popups close before parents

TEST PLAN
  Before, Wayland: Trying to open a menu under Wayland while one is already 
open fails.
  After, Wayland: Trying to open a menu under Wayland while one is already open 
succeeds.
  Ensure no regressions on X11.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-menu-fix-wayland (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29464

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

To: cblack, #plasma, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82025.
cblack marked 4 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82020=82025

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82020.
cblack added a comment.


  Fix permission denied bouncing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82016=82020

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82016.
cblack added a comment.


  Add Messages.sh

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82015=82016

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82015.
cblack added a comment.


  Add Messages.sh

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82012=82015

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82012.
cblack added a comment.


  Use section headers instead of font weights

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82010=82012

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82010.
cblack added a comment.


  Improved dirty state handling

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82008=82010

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82008.
cblack added a comment.


  Address the page oddities

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82006=82008

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82006.
cblack added a comment.


  Take care of that feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=80942=82006

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28888: Fix navigation regressions

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:f98e5d33f46b: Fix navigation regressions (authored by 
cblack).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2?vs=81713=81889

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: cblack, #vdg, #kirigami, ndavis, mart
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D29106: Introduce RouterWindow control

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d2060bf4a12a: Introduce RouterWindow control (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29106?vs=80922=81888

REVISION DETAIL
  https://phabricator.kde.org/D29106

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_routerwindow.qml
  src/controls/RouterWindow.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:5b8868783c01: Implement smallFont in Kirigami plugin 
(authored by cblack).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29307?vs=81642=81884

REVISION DETAIL
  https://phabricator.kde.org/D29307

AFFECTED FILES
  CMakeLists.txt
  kirigami-plasmadesktop-integration/CMakeLists.txt
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h

To: cblack, #kirigami, mart
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Carson Black]

cblack added a comment.


  In D29395#662576 , @ngraham wrote:
  
  > Now the inner image has a greater top margin than bottom margin. Also, 
could the artist and album be allowed to become two-line strings before 
eliding, maybe? F8282138: Screenshot_20200503_202710.png 

  
  
  ... what? This patch doesn't (or shouldn't) result in visual changes.
  
  I don't notice any visual changes on my system.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  MediaController is refactored to:
  
  1. make the code easier to read and therefore more maintainable
  2. stop dumping errors like there's no tomorrow into the console

TEST PLAN
  Use, ensure no regressions are found.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/refactor-mediacontroller (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29395

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/Media.qml
  applets/mediacontroller/contents/ui/main.qml
  applets/mediacontroller/contents/ui/qmldir

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28888: Fix navigation regressions

[Carson Black]

cblack updated this revision to Diff 81713.
cblack added a comment.


  Use normal list delegates

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2?vs=81214=81713

BRANCH
  cblack/better-navigation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: cblack, #vdg, #kirigami
Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28627: Adaptive panel opacity

[Carson Black]

cblack added a comment.


  @davidedmundson can you take another look at the general direction of the 
code here? I'd like to know your thoughts on the direction this code is using 
before I start spending time sanding off the rough parts

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

cblack added a comment.


  In D29307#660851 , @filipf wrote:
  
  > How does this relate to D14562 
  
  
  
  
  1. This would have been a companion patch to it if the author didn't abandon 
it
  2. But they did, so this is implementing the new interface created in D29304 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D29307

To: cblack, #kirigami
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29301: [applets/mediacontroller] Elide text

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0dcc58a10628: [applets/mediacontroller] Elide text 
(authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29301?vs=81598=81661

REVISION DETAIL
  https://phabricator.kde.org/D29301

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

cblack updated this revision to Diff 81642.
cblack added a comment.


  Add explanatory comment

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29307?vs=81609=81642

BRANCH
  cblack/smallfont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29307

AFFECTED FILES
  CMakeLists.txt
  kirigami-plasmadesktop-integration/CMakeLists.txt
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29307: Implement smallFont in Kirigami plugin

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

TEST PLAN
  F8273961: image.png  F8273893: font.qml 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  cblack/smallfont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29307

AFFECTED FILES
  CMakeLists.txt
  kirigami-plasmadesktop-integration/CMakeLists.txt
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29294: Add support for layers to PagePoolAction.

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> tst_layers.qml:19-25
> +function initTestCase() {
> +mainWindow.show()
> +}
> +
> +function cleanupTestCase() {
> +mainWindow.close()
> +}

You want to use `when: windowShown`

> tst_layers.qml:27
> +
> +function applicationWindow() { return mainWindow; }
> +

Unused.

> PagePoolAction.qml:63
> +  * This is intended for use with PageRow layers to allow 
> PagePoolActions to
> +  * push context-specific pages onto the layers stack. 
> +  */

@since 5.70
  @since org.kde.kirigami 2.12

> PagePoolAction.qml:161
> +
> +property QtObject _private: QtObject {
> +id: _private

this isn't how you do private objects, drop `property QtObject _private` and 
access by ID

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29294

To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9368dcc28f66: Introduce Theme::smallFont (authored by 
cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29304?vs=81603=81604

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami, mart
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29304: Introduce Theme::smallFont

[Carson Black]

cblack updated this revision to Diff 81603.
cblack added a comment.


  Drop Rust-ism

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29304?vs=81601=81603

BRANCH
  cblack/smallFont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29304: Introduce Theme::smallFont

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Like defaultFont, but smaller.

TEST PLAN
  F8273893: font.qml 

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/smallFont (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29304

AFFECTED FILES
  src/controls/Theme.qml
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29301: [applets/mediacontroller] Elide text

[Carson Black]

cblack updated this revision to Diff 81598.
cblack retitled this revision from "[applets/mediacontroller] Drop maximum 
height on songTitle" to "[applets/mediacontroller] Elide text".
cblack edited the test plan for this revision.
cblack added a comment.


  Elide text

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29301?vs=81593=81598

BRANCH
  cblack/layout-fixeroni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29301

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29301: [applets/mediacontroller] Drop maximum height on songTitle

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

TEST PLAN
  Before: F8273701: image.png 
  After: F8273704: image.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/layout-fixeroni (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29301

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29074: Make BasicListItem more useful by giving it a subtitle property

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> BasicListItem.qml:31
> + * Optional; if not defined, the list item will only have a main label
> + * @since 2.12
> + */

@since 5.70
  @since org.kde.kirigami 2.12

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29074

To: ngraham, #vdg, #kirigami, mart
Cc: cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29288: Improve PageRouter API

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack updated this revision to Diff 81555.
cblack added a comment.
cblack requested review of this revision.


  Add missing EOF linebreak

REVISION SUMMARY
  This patch fixes shortcomings in the PageRouter API regarding ease of use, 
verbosity, idiomaticness, and signals.
  
  Introduced:
  
  - `pushFromHere()` and `popFromHere()`: pushing and popping operations that 
operate from the current route
  - `watchedRoute` and `watchedRouteActive`: declarative counterpart to 
`routeActive` that responds to signals
  - Navigation signals

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/pagerouter-api-improvements

REVISION DETAIL
  https://phabricator.kde.org/D29288

AFFECTED FILES
  examples/PageRouterWatchedRoute.qml
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29290: IGNORE THIS - TESTING A PHAB THING

[Carson Black]

cblack added a comment.


  submit the revision as a draft (`arc diff --draft`) so you don't cause 
useless emails next time

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29290

To: davidedmundson, qi437103
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29279: Don't play volume feedback if max volume is reached

[Carson Black]

cblack added a comment.


  In D29279#659922 , @nicolasfella 
wrote:
  
  > To be clear: the 95%->100% transition still emits a sound, but 100%->100% 
does not any more
  
  
  Yes, that's what I rely on to know that I'm at maximum volume-when the volume 
of the feedback doesn't change. If I press a volume key and don't get auditory 
feedback, that makes me feel like I hit the volume down key by mistake, and I'm 
at 0% volume.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vol

REVISION DETAIL
  https://phabricator.kde.org/D29279

To: nicolasfella, #plasma, drosca, ngraham
Cc: cblack, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29279: Don't play volume feedback if max volume is reached

[Carson Black]

cblack added a comment.


  Not sure how I feel about this change. I often rely on auditory feedback 
rather than visual feedback to confirm that I'm at maximum volume.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vol

REVISION DETAIL
  https://phabricator.kde.org/D29279

To: nicolasfella, #plasma, drosca, ngraham
Cc: cblack, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

[Carson Black]

cblack accepted this revision as: cblack.
cblack added a comment.


  +1 from a design standpoint here.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  make-small-font-smaller-when-changing-all-font-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29262: Less segfaulty PageRouterAttached

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e0107f5854dc: Less segfaulty PageRouterAttached (authored 
by cblack).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29262?vs=81466=81468

REVISION DETAIL
  https://phabricator.kde.org/D29262

AFFECTED FILES
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart