[Powerdevil] [Bug 348529] When screen is locked, turn off screen with a shorter timeout

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #50 from Chris  ---
Created attachment 155925
  --> https://bugs.kde.org/attachment.cgi?id=155925=edit
Shorten screen power off timeout when screen is locked

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] When screen is locked, turn off screen at some point

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #45 from Chris  ---
(In reply to Bug Janitor Service from comment #44)
> A possibly relevant merge request was started @
> https://invent.kde.org/plasma/powerdevil/-/merge_requests/116

The merge request is about "dimming" the screen. It's also about people wanting
to "watch their screensaver for a while". A lot of fancy things.
It is completely unrelated to "turn off screen".
Additionally screen dimming is only relevant for laptop screen.
All in all the two issues are completely unrelated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] When screen is locked, turn off screen at some point

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #43 from Chris  ---
(In reply to Aleix Pol from comment #42)
> I'm sorry, I was just pointed to this MR and am not sure what the problem
> exactly is. 
> 
> Shouldn't the default mechanisms from PowerDevil kick in here and eventually
> dpms=off the screen?
> 
> One thing that the new changes offer is that the script can be switched to
> use "kscreen-doctor --dpms off" instead of messing with the powerdevil
> profiles.
> 
> Also you can press Esc to dim the screen, although I understand this isn't
> exactly what we're after here.

I think the point is to have two different "screen energy saving" timers, one
for the plain idle session, and the other for when the screen is locked. I
think every device but kde/plasma has this feature nowadays:
https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/monitor-powers-off-when-pc-locked,
also android, gnome iiuc; the Phosh timer in this circumstance is so short that
unlocking the screen is challenging...

I think the script above does just that, it did prove useful, but I'm not sure
it's robust at all. And it's a lot of tinkering.
(https://bugs.kde.org/show_bug.cgi?id=348529#c33)

The new command "kscreen-doctor --dpms off" is awesome for wayland users, but I
think it's more about the timer, just as expressed with the new name: "turn
screen off at some point".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #40 from Chris  ---
(In reply to Kai Uwe Broulik from comment #4)
> That script isn't particularly efficient.
> I like the idea of reducing the timeout for turning off the screen when it's
> locked (and/or making that a separate option since you might not want it to
> turn off at all while not locked), though. I added it to my todo list.
> Thanks.

What do you think of the script there
https://bugs.kde.org/show_bug.cgi?id=348529#c33?
It does not, on the face of it, rely on an infinite loop, and it works both
with x11 and wayland.

dbus-monitor --session "type='signal',interface='org.freedesktop.ScreenSaver'"
|
  while read x; do
case "$x" in
  *"boolean true"*)
echo SCREEN_LOCKED;
kwriteconfig5 --file powermanagementprofilesrc --group AC --group
DPMSControl --key idleTime 60;
qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement
org.kde.Solid.PowerManagement.refreshStatus
;;
  *"boolean false"*)
echo SCREEN_UNLOCKED;
kwriteconfig5 --file powermanagementprofilesrc --group AC --group
DPMSControl --key idleTime 600;
qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement
org.kde.Solid.PowerManagement.refreshStatus
;;
esac
  done

It is quick and dirty cut and paste but I think it works, and I don't see why
not?

As they say in https://bugs.kde.org/show_bug.cgi?id=348529#c39, it could help
having something like that integrated in System-Settings, instead on relying on
users hacks.

It is annoying having 30W plus, of monitor LED, glowing unnecessarily.
(https://www.thehomehacksdiy.com/how-much-power-watts-does-a-monitor-use/)

Keep in mind that for most users, monitor power button is not an option because
it scrambles up all the settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #38 from Chris  ---
(In reply to mágoa mångata from comment #36)
> This bug is kind of annoying. Is there any problem about not solving it?
> Since this is small bug. It's not resolved for 7 years!
> I think the only thing to do is to add an option for lock screen timeout in
> the power settings.

Have you tried the `kde-saver-script.sh` script from above? My system is now so
well behaved in that regard that I don't need that anymore. But I believe that
should work just fine. And that both with x11 (which I no longer use), and
wayland.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #37 from Chris  ---
(In reply to Chris from comment #34)
> The script above should work nicely, but it doesn't, not consistently at
> least.
> Related bugs:
> https://bugs.kde.org/show_bug.cgi?id=348082 "monitor is randomly powered
> back on"
> https://bugs.kde.org/show_bug.cgi?id=422455 "Monitor power saving won't work
> when using DisplayPort cable"

Those two bugs no longer bother me, for a few month now, latest debian-sid,
wayland as pure as possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #34 from Chris  ---
The script above should work nicely, but it doesn't, not consistently at least.
Related bugs:
https://bugs.kde.org/show_bug.cgi?id=348082 "monitor is randomly powered back
on"
https://bugs.kde.org/show_bug.cgi?id=422455 "Monitor power saving won't work
when using DisplayPort cable"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348082] monitor is randomly powered back on when using ddcutil support

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348082

--- Comment #20 from Chris  ---
I've been experiencing this bug for a few years.
My debian kde version is now sid/experimental/wayland. (Plasma 5.21)
Powerdevil is installed, but nothing ddcutil: debian doesn't have the
dependency.
I think the bug description should be reverted to what it was until a week ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

[Chris]

https://bugs.kde.org/show_bug.cgi?id=348529

Chris  changed:

   What|Removed |Added

 CC||inkbottle...@gmail.com

--- Comment #33 from Chris  ---
I've tried the following on debian sid with Plasma 5.21, Framework 5.82, and
most importantly Wayland:

$ cat ./kde-saver-script.sh 
#! /bin/bash
#
https://unix.stackexchange.com/questions/353998/run-script-on-screen-lock-in-kde
# Run the script in a terminal and then type Ctrl+Alt+L, and then the screen
should turn off after only 60 sec.
# Once you unlocked the screen, the turn off screen timer is set back to 600
sec.
dbus-monitor --session "type='signal',interface='org.freedesktop.ScreenSaver'"
|
  while read x; do
case "$x" in
  *"boolean true"*)
echo SCREEN_LOCKED;
kwriteconfig5 --file powermanagementprofilesrc --group AC --group
DPMSControl --key idleTime 60;
qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement
org.kde.Solid.PowerManagement.refreshStatus
;;
  *"boolean false"*)
echo SCREEN_UNLOCKED;
kwriteconfig5 --file powermanagementprofilesrc --group AC --group
DPMSControl --key idleTime 600;
qdbus org.kde.Solid.PowerManagement /org/kde/Solid/PowerManagement
org.kde.Solid.PowerManagement.refreshStatus
;;
esac
  done

And it works, very well indeed. But sometimes, even though it worked when you
left the room, when you come back you find the screen turned on, and stubbornly
refusing to turn off all by itself.
Consistency is of the essence here: save the planet, turn off the screen.

Even though it's not working, the "turn off screen" seems much more consistent
with Wayland than it was with x11.
(https://blog.martin-graesslin.com/blog/2015/09/comparing-dpms-on-x11-and-wayland/)

And maybe obvious improvements to the script could fix it.

Note that I did do `sudo systemd-inhibit --list`, when I observed the "turn
off" action was failing, but nothing stuck out. So I have no idea on what went
wrong.

However the "turn off screen" thing seems consistent without my script meddling
into it, and only the settings in "power management / energy saving". So it is
likely that the poor script above is missing some mandatory settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[Chris Holland]

Zren added a comment.


  > The `plasma-framework` patch is D29463 
  
  Ran my KirigamiDevicePixelRatioTest.qml with 
`QT_QUICK_CONTROLS_STYLE=Plasma`, `/usr/.../styles/org.kde.desktop`, 
`/usr/.../styles/org.kde.desktop.plasma`, and `/usr/.../Kirigami.2`.
  
  F8323548: 2020-05-15___13-01-16.png 
  F8323479: 2020-05-15___12-52-18.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29462

To: Zren, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[Chris Holland]

Zren created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I recently noticed that `Kirigami.Units.devicePixelRatio` was `1.3` even 
though I was at the default 96dpi when writing a widget's config.
  
  F8287886: 2020-05-05___19-00-48.png 
  
  There's 4 different `Units.qml`, and I'm not certain which does what. 2 are 
in `krigiami` and the other 2 are in `plasma-framework`.
  
$ locate /Units.qml | grep /usr/
/usr/lib/qt/qml/org/kde/kirigami.2/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/Plasma/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop.plasma/Units.qml
  
  
  
  - 2 years ago `kirigami/src/controls/Units.qml` 
 
(`/usr/lib/qt/qml/org/kde/kirigami.2/Units.qml`) was changed from `13/10 = 1.3` 
to multiply by `13*0.75` so that `9.75/10 = 0.975` (then `max(1, 0.975) = 1`).
  
  -
  
  Which means this patch modifies the other file owned by `kirigami`:
  
$ pacman -Qo 
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop/Units.qml is 
owned by kirigami2 5.69.0-1
  
  Note that this patch **does not fix** `qmlscene 
KirigamiDevicePixelRatioTest.qml`, nor a `plasmashell` widget, nor a 
`plasmoidviewer` widget. I'm not sure what uses the `org.kde.desktop` style, as 
`qmlscene` uses the `org.kde.desktop.plasma` it seems. The `plasma-framework` 
patch should fix `qmlscene`.

TEST PLAN
  You can edit 
`/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop/Units.qml` to test 
this patch.
  
  -
  
  To test the `plasma-frameworks` patch:
  
  Editing 
`/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop.plasma/Units.qml` 
then running:
  
  - https://gist.github.com/Zren/621338b8cda7c550d7b43f8ea1ba71a7
  - `qmlscene KirigamiDevicePixelRatioTest.qml`
  
  and `Kirigami.Units.devicePixelRatio` should equal `1`.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29462

AFFECTED FILES
  src/controls/Units.qml
  src/styles/org.kde.desktop/Units.qml

To: Zren
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27346: emojier: Improve resizing performance

[Chris Holland]

Zren added a comment.


  As in `clip: true`?
  
delegate: MouseArea {
width: emojiView.cellWidth
height: emojiView.cellHeight
clip: true

Rectangle { border.color: "#ff0"; anchors.fill: parent; border.width: 
1; color: "transparent" }

QQC2.Label {
font.pointSize: -1
font.pixelSize: Math.floor(emojiView.desiredSize / 2)

Rectangle {
width: parent.contentWidth
height: parent.contentHeight
border.color: "#f00"
anchors.centerIn: parent
border.width: 1
color: "transparent"
}
}
}
  
  F8105518: 2020-02-15___20-04-25.png 
  F8105516: 2020-02-15___20-03-15.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: ngraham, Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27346: emojier: Improve resizing performance

[Chris Holland]

Zren added a comment.


  Not sure. Backwards compatibility?
  
  Firefox renders a couple of them fine, while the TaskManager widget doesn't. 
Could it be the "Noto" font? The facepalm ones not working are 3 glyphs merged 
together (facepalm+skincolor+sex). It's rendering (facepalm+skincolor) fine 
though.
  
  - https://emojipedia.org/person-facepalming/
  - https://emojipedia.org/man-facepalming/
  - https://emojipedia.org/woman-facepalming/
  
  F8099948: 2020-02-12___12-28-35.png 
  
  There are some glyphs that don't render in firefox either. They don't have a 
Google (who works on Noto) emoji.
  
  - https://emojipedia.org/person-in-manual-wheelchair/
  - https://emojipedia.org/person-red-hair/
  - https://emojipedia.org/person-curly-hair/
  
  F8099960: 2020-02-12___12-33-13.png 
  
  So we'll need to account for double glyphs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27346: emojier: Improve resizing performance

[Chris Holland]

Zren added a comment.


  FixedSize 25pt does help, but "2 glyph emojis" will overlap each other.
  
  F8099880: 2020-02-12___11-38-36.png 
  F8099891: screen-2020-02-12_11.34.09.mp4 

  
Rectangle {
width: parent.contentWidth
height: parent.contentHeight
border.color: "#f00"
anchors.centerIn: parent
border.width: 1
color: "transparent"
}

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27346

To: apol, #plasma
Cc: Zren, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27337: [Emojier] Optimize performance

[Chris Holland]

Zren added a comment.


  I used `Loader` as I didn't want loading glyphs to block scrollbar 
responsiveness. `GridView` reuses delegates, but I don't think it's the 
`MouseArea` + `Label` constructor that's slow. I think it's the "rendering the 
emoji glyph" in the GUI draw that is the root cause.
  
  The cell spacing code re-renders the glyph (which is a slow process), which 
is why I removed it. Though I guess we can use `anchor.centerIn`:
  
MouseArea {
id: mouse
width: emojiView.cellWidth
height: emojiView.cellHeight

Label {
anchor.centerIn: mouse
width: emojiView.desiredSize
height: emojiView.desiredSize
}
}
  
  ... to keep the cell spacing if that's a requirement.
  
  Using `fontSizeMode: Qt.VerticalFit` would make emoji's overflow 
horizontally. Various "hand + skin tone" emoji's that don't yet have a custom 
emoji are 2x wider than they are tall.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27337

To: Zren, apol, #plasma
Cc: broulik, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27337: [Emojier] Optimize performance

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  BUG: 417454
  
  The emojier fairly slow. Launching is slow. Resizing the window is slow. 
Changing pages is slow. Scrolling is also slow.
  
  On launch, the sidebar widens from `0px`, resizing the `GridView`, which 
resizes `cellWidth` as we abuse it's the width calculation to create cell 
spacing. Resizing 1000 emoji Labels is slow. This also happens when you resize 
the window. The cpu core spikes to 100% (on a 2.8Ghz cpu).
  
  F8098605: screen-2020-02-11_18.21.04.mp4 

  
  After selecting an emoji, closing, and reopening, the recent emoji's is shown 
first (without a search box) which opens faster since it has much less work. 
However switching to the all emoji page resurfaces the problem.
  
  Scrolling is also a problem, as loading the emoji `QQC2.Label`s is slow. So 
we'll use a `Loader { asynchronous: true }`. I'm not sure why it loads them 
from bottom to top.
  
  Here's what it looks like after this patch. Resizing no longer blocks, nor 
does scrolling.
  
  F8098612: screen-2020-02-11_18.18.37.mp4 


TEST PLAN
  How I compile and run emojier by itself:
  https://gist.github.com/Zren/1d16e51199c9e47718ccfe41755d8ee2

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27337

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/ui/CategoryPage.qml

To: Zren
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Chris Holland]

Zren added a comment.


  I don't care if Inactive Blur  is 
upstreamed or not as all my code is GPL. I didn't upstream it since I thought 
the feature was niche enough I shouldn't burden others with it's maintenance.
  
  This doesn't blur the desktop widgets, only the wallpaper, which looks weird. 
I had never thought about blurring the root "desktop" window using KWin. That's 
an interesting idea!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26773

To: niccolove, #plasma
Cc: Zren, ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:59cd237a7146: [TabBox] Add Thumbnail Grid window switcher 
(authored by Zren).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26681?vs=73648=73675

REVISION DETAIL
  https://phabricator.kde.org/D26681

AFFECTED FILES
  windowswitchers/CMakeLists.txt
  windowswitchers/thumbnail_grid/contents/ui/main.qml
  windowswitchers/thumbnail_grid/metadata.desktop

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

Zren updated this revision to Diff 73648.
Zren edited the summary of this revision.
Zren added a comment.


  Fix implicitWidth error by using Layout.min/maxWidth.
  Scale captionRow.spacing by dpi.
  Take into account the close button is 30x30.
  Use a ColumnLayout for thumbnailGridItems instead of anchoring.
  Add Item container for KWin.ThumbnailItem so it's not cliping the bottom of 
the window thumbnail.
  Remove "keybindings don't work" comment that no longer applies.
  Use `const` for function variables.
  644 (RW-R--R--) file permission.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26681?vs=73590=73648

REVISION DETAIL
  https://phabricator.kde.org/D26681

AFFECTED FILES
  windowswitchers/CMakeLists.txt
  windowswitchers/thumbnail_grid/contents/ui/main.qml
  windowswitchers/thumbnail_grid/metadata.desktop

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:183
> you can use Layout.preferredWidth
> 
> One shouldn't specifiy a width/height from an item inside a layout

Uhg, I was using `width: parent.height` and `height: parent.height` but changed 
it when cleaning it up. I must've not staged all the changes before diffing. 
This has made me notice another bug though.

By using `height: parent.height`, I was basically setting it at `height: 22`, 
which is smaller than the "close button" which is 30x30.

  width: parent.height
  height: parent.height

F7884740: 2020-01-15___12-05-59.png 

  Layout.fillHeight: true
  Layout.minimumWidth: height
  Layout.maximumWidth: Layout.minimumWidth

This makes the icon slightly larger than I'm used to.
F7884741: 2020-01-15___12-04-32.png 

I've also noticed why I added `clip: true` to the `KWin.ThumbnailItem`, 
apparently the close button is 30x30, which is taller than the 
`captionRow.height: 22`. Here's a look at the overflow after removing `clip: 
true` and `clipTo: parent`:
Outlines with: `Rectangle { anchors.fill: parent; border.color: "#f00"; 
border.width: 1; color: "transparent" }`
F7884784: 2020-01-15___12-31-12.png 

I've fixed it all in the latest diff:
F7884833: 2020-01-15___12-38-31.png 
F7884834: 2020-01-15___12-55-01.png 

> davidedmundson wrote in main.qml:231
> GridView has it's own input handling you shouldn't need this anyway.
> 
> If keyboard doesn't work, chances are your activeFocus is incorrect.
> 
> I can only see focus: true on
> 
>   id: dialogMainItem
> 
> it should be on the gridview instead

Arrow keys work. Sorry, forgot to this comment.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

To: Zren, romangg, #plasma
Cc: zzag, davidedmundson, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26681: [TabBox] Thumbnail Grid window switcher

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Cleaned up my code from https://github.com/Zren/kwin-tabbox-thumbnail_grid
  
  The column is calculated recursively, but survived a stress test.
  https://github.com/Zren/kwin-tabbox-thumbnail_grid/pull/2
  
  > I tested when "show desktop" is configured to be hidden since I know it 
didn't like it with modding by 0 items in the python test. "show desktop" will 
show up on an empty desktop though so there's always at least 1 item it seems.
  
  I wrote a python script to easily test the recursive column calculation with 
__ number of windows.
  
https://github.com/Zren/kwin-tabbox-thumbnail_grid/blob/master/test_recursion.py

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26681

AFFECTED FILES
  windowswitchers/CMakeLists.txt
  windowswitchers/thumbnail_grid/contents/ui/main.qml
  windowswitchers/thumbnail_grid/metadata.desktop

To: Zren
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx updated this revision to Diff 65769.
chrisx set the repository for this revision to R111 KSysguard Library.
chrisx added a comment.


  @meven Sorry I've totally forgotten about your suggestions when I was 
updating the patch...
  I have renamed `DetailsDlg` to `ProcessDetailsDialog`. But I've got some 
minor issues with code indentation. I have tried out `uncrustify-kf5` (which 
didn't even work out-of-box. Instead of formatting the files in-place, it 
produced `*.uncrustify` files instead. I have uncrustify 0.69, and I worked 
around the issue by adding `--replace` to the arguments for uncrystify in 
`uncrustify-kf5`). But the script produces way too many changes in some files I 
changed. One of those files is `processes_linux_p.cpp`, which uses both spaces 
and tabs for indentation. So at this moment I've only committed some of the 
indentation changes.
  Any further help with pushing this patch forward would be greatly appreciated.

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12827?vs=65628=65769

REVISION DETAIL
  https://phabricator.kde.org/D12827

AFFECTED FILES
  lsofui/lsof.h
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/CMakeLists.txt
  processui/ProcessDetailsDialog.cpp
  processui/ProcessDetailsDialog.h
  processui/ProcessDetailsDialogUI.ui
  processui/ksysguardprocesslist.cpp
  processui/ksysguardprocesslist.h

To: chrisx, broulik, davidedmundson, mart
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx added a comment.


  Patch updated. Any suggestions?

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson, mart
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx updated this revision to Diff 65628.
chrisx added a reviewer: mart.
chrisx added a comment.


  Rebased to master. Removed uses of deprecated class (QRegExp). Tidied the 
code up a bit.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12827?vs=35891=65628

REVISION DETAIL
  https://phabricator.kde.org/D12827

AFFECTED FILES
  lsofui/lsof.h
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/CMakeLists.txt
  processui/DetailsDlg.cpp
  processui/DetailsDlg.h
  processui/DetailsDlgUI.ui
  processui/ksysguardprocesslist.cpp
  processui/ksysguardprocesslist.h

To: chrisx, broulik, davidedmundson, mart
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx added a comment.


  In D12827#513118 , @meven wrote:
  
  > I quite like this feature @chrisx
  >  I hope you can still push it forward after all this time.
  
  
  I'll definitely update the patch if the maintainers show more interest in 
merging. After all I don't really like the idea of having WebKit (back when the 
patch was authored) or Chromium in my system monitor in order to view memory 
details.
  ... and I have to admit that my code style is a complete mess. I'll fix it in 
the next patch (if there is one).

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Chris Holland]

Zren added a comment.


  Another option I believe is to keep the 

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Chris Holland]

Zren added a comment.


  Was skimming the Plasma Scripting API today for something else and found 
where I saw the "update scripts" before:
  
  - 
https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Update_scripts
  - 
https://github.com/KDE/plasma-desktop/tree/master/desktoppackage/contents/updates
  
  It looks like you can only provide update scripts in the "shell" kpackage.
  Leaving the links here for me to experiment with it in the future.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

To: Zren, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> configAppearance.qml:137
> +icon.name: "preferences-desktop-locale"
> +onClicked: KCMShell.open("formats.desktop")
> +}

Was afk today sorry.

Do we need `visible: KCMShell.authorize("formats.desktop").length > 0` here? It 
hides the contextmenu item in `main.qml` if the user doesn't have permission.

https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/package/contents/ui/main.qml#L109

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: cfeck, totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:58e6cc6e119f: [weather] envcan: Fix typo in lowercase 
icon lookup string (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19176?vs=52122=52485

REVISION DETAIL
  https://phabricator.kde.org/D19176

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19233: [plasmoidviewer] Add --nobuttons flag to hide button bar

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  This also fixes the `Background { id: backgroundButtons }` not hiding by 
binding it's visibility to `buttons.visible`.
  
  Is the "bugfix" worth splitting into it's own commit and backporting to 5.15, 
while the new feature goes into master/5.16?

TEST PLAN
  - Patch 
`/usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/views/`
  - Compile and run `build/bin/plasmoidviewer -a org.plasma.digitalclock 
--nobuttons`
  - Run `build/bin/plasmoidviewer -a org.plasma.digitalclock` and confirm the 
"hide" button still works.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D19233

AFFECTED FILES
  plasmoidviewer/main.cpp
  plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml
  plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml
  plasmoidviewer/view.cpp
  plasmoidviewer/view.h

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in DigitalClock.qml:305
> You should check if panel orientation, now it's broken horizontal view?

This is inside a `State { when: plasmoid.formFactor == 
PlasmaCore.Types.Vertical }`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren
Cc: ngraham, davidedmundson, Zren, abetts, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Chris Holland]

Zren added a comment.


  https://doc.qt.io/qt-5/qt.html#CheckState-enum
  
  `i18n("Use locale default")` should be in the middle (`currentIndex=1`). 12h 
should be `currentIndex=0`, and 24h should be `currentIndex=2`
  
  
https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/package/contents/config/main.xml#L64
  
  People upgrading from 5.15 will have either "force 12h" (`0`) or "force 24h" 
(`2`) serialized to file. KConfig doesn't serialize the default values to file 
(`1`).
  
  Make sure to test changing `contents/config/main.xml` to simulate "loading" a 
different config value from file.
  

  Force the clock to use 12/24 hour time, instead of following 
the user locale.
  1

  
  with `0` and `2` to make sure it selects 12h/24h when the config opens.
  
  Right now the config should be selecting 12h (`currentIndex=1`), however 
`currentIndex` is the default `currentIndex=0` as mentioned in the Qt Docs.
  
  - 
https://doc.qt.io/qt-5.11/qml-qtquick-controls2-combobox.html#currentIndex-prop
  
  If you really want the "locale default" at the top, you'll need to use the 
following pattern for the model
  
textRole: "label"
model: [
  { label: i18n("Use locale default"), value: 1 },
  { label: i18n("12-hour"), value: 0 },
  { label: i18n("24-hour"), value: 2 },
]
Component.onCompleted: {
  // select index with value == cfg_use24hFormat
  // watch cfg_use24hFormat for changes
}
  
  
  
  - https://doc.qt.io/qt-5.11/qml-qtquick-controls2-combobox.html#model-prop
  - https://doc.qt.io/qt-5.11/qml-qtquick-controls2-combobox.html#textRole-prop

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

[Chris Holland]

Zren created this revision.
Zren added reviewers: Plasma, kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  The capital `S` breaks the icon match.
  
  It was broken in Plasma 5.6 

 => Plasma 5.7 
,
 so I guess I'll merge 5.12 => 5.14 => 5.15 => master, assuming we still need 
to backport to 5.14 for Debian?  
  
https://github.com/KDE/plasma-workspace/blob/Plasma/5.12/dataengines/weather/ions/envcan/ion_envcan.cpp#L294
  
  Do I bother putting `FIXED-IN: 5.15.2` if there's no bug report?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19176

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19174: [weather] envcan: Document urls for example data + list all warnings

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I can place this in the `ion_envcan.h` or the `ion_envcan.cpp`. It's not 
worth backporting so it'll get merged to master.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19174

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

[Chris Holland]

Zren closed this revision.
Zren added a comment.


  Shoot, I accidentally forgot the Phab Rev link in the commit message (though 
I remembered the bugzilla tags). I've setup a `.git/hook/prepare-commit-msg` 
-like thing for Sublime Text 
 to prevent this 
happening in the future.
  
  - `Plasma/5.15` commit: 
https://cgit.kde.org/plasma-workspace.git/commit/?id=006c4f5f9ee8dfb3d95604a706d01b968c1e1c8a
  - `master` merge commit: 
https://cgit.kde.org/plasma-workspace.git/commit/?id=8f1a7ae6cd1de8f6f59c66d4a049f77e74497493

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19021

To: Zren, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

[Chris Holland]

Zren created this revision.
Zren added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  In 12h system locales (eg: en_US), checked=1 is cast as
  Qt::PartiallyChecked=1 which defaults to the system locale (12h).
  Since it's no longer a tri-state button, the user can't select
  Qt::Checked=2 which forces the 24h state.
  
  BUG: 404292
  
  FIXED-IN: 5.15.1

TEST PLAN
  - Run `LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock` 
and confirm it's a 2 state button that doesn't enable 24h clock.
  - Patch 
`/usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/configAppearance.qml`
  - Run `LC_TIME="en_US.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock` 
and confirm it's a 3 state button that does force the 24h clock.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19021

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Chris Holland]

Zren added a comment.


  In D18961#410792 , @kossebau wrote:
  
  > > we no longer have to install the widget to .../share/plasma/plasmoids/
  >
  > No experience here, but do we not still need to install the QML extension 
plugins to have the applet working? Or is there some mechanism to load them 
also from the build dir now?
  
  
  
  
  - We still need the private QML plugin for the `Util.___` functions yes, but 
you don't need to reinstall those if you only touched the QML.
  - `plasmoidviewer -a package` does not populate `plasmoid.nativeInterface`, 
so any code touching the `nativeInterface` config (all of it) doesn't work when 
you use that to test. I'm not 100% sure why the relative path isn't loading the 
`nativeInterface` even though the metadata `X-KDE-PluginInfo-Name` should be 
the same. I'll need to dive into `plasmoidviewer`'s code.
  - After the patch, we only need the `nativeInterface` to migrate the code. If 
it doesn't load the `nativeInterface`, plasma uses a placeholder `QObject {}`, 
which skips the migration code.
  
  In D18961#410784 , @kossebau wrote:
  
  > Though it breaks my technically-perfect-solution-aiming engineer's heart :)
  >  please be prepared for some 2 weeks time needed on my side to get over 
this :)
  
  
  lol, take your time. This is for the Plasma 5.16/5.17 release cycle so we've 
ages to choose this or develop a different patch.
  
  So long as the migration code is in Ubuntu 20.04, and Debian 11 (Bullseye) in 
2021. We can take it out before 22.04 or Debian 12 (Bookworm) in 2023. Anyone 
jumping 2 LTS versions usually expects some hiccups when upgrading.
  
  Note: kicker used a similar migration method (QML onCompleted) to port their 
`plasmoid.configuration.favorites` => SQLiteDB.  
  
https://github.com/KDE/plasma-desktop/blob/master/applets/kicker/package/contents/ui/main.qml#L115

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

To: Zren, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  If `plasmoid.nativeInterface.source != ""`, we copy it to 
`plasmoid.configuration.source` + same
  with all other properties besides `needsToBeSquare` which is a "session" 
variable that updated
  right after the migration code.
  
  The selected weather `services` StringList is not a `nativeInterface` 
property, so it needs to be copied differently.
  
  -
  
  We could also copy the other properties the using the 
`configValues().services` pattern if you want the code consistent.
  
  This is a pure QML solution. Ideally, the final patch will have a few more 
C++ functions/enums exposed to the QML. The `DisplayUnits.qml` properties could 
be turned into functions. Eg:
  
Utils.parseTemperatureUnitId(plasmoid.configuration.temperatureUnitId)
  
  That way we don't have magic numbers (`6001 // Celcius`)  littered throughout 
`DisplayUnits.qml`.
  
  -
  
  Ideally, we'll only keep the `nativeInterface` + migration code until Plasma 
5.19 assuming Plasma 5.18 is the next Plasma LTS version. We could remove the 
migration code earlier, as having the user re-setup their weather widget isn't 
terribly cumbersome for the user.
  
  Once it no longer depends on the `nativeInterface`, users can easily fork the 
default weather widget.
  
  Immendiate benefits are that we no longer have to install the widget to 
`.../share/plasma/plasmoids/` to test the widget's QML. We can now use 
`plasmoidviewer -a package`. Note that we still need to install to 
`~/.local/share/plasma/plasmoids/` to test the `nativeInterface` migration code 
as mentioned in the test plan.

TEST PLAN
  - Apply patch.
  - Copy `weather/package` to `~/.local/share/plasma/plasmoids/` and rename the 
`package` directory to `org.kde.plasma.weather`.
  - Restart plasmashell with `kstart5 -- plasmashell --replace`
  - The settings should have migrated, and the widget should still work.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18961

AFFECTED FILES
  applets/weather/package/contents/config/main.xml
  applets/weather/package/contents/ui/CompactRepresentation.qml
  applets/weather/package/contents/ui/DisplayUnits.qml
  applets/weather/package/contents/ui/config/ConfigAppearance.qml
  applets/weather/package/contents/ui/config/ConfigUnits.qml
  applets/weather/package/contents/ui/config/ConfigWeatherStation.qml
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml
  applets/weather/package/contents/ui/main.qml

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:46204a5e2a84: [weather] Fix weather Notices tab not 
showing (authored by Zren).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18936?vs=51449=51455#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18936?vs=51449=51455

REVISION DETAIL
  https://phabricator.kde.org/D18936

AFFECTED FILES
  applets/weather/package/contents/ui/NoticesView.qml

To: Zren, kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren added a comment.


  Ah, `NoticesView.qml` in Plasma 5.12 was slightly different.
  
  - 
https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml
  - 
https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/Notice.qml
  
  `Notice.qml` used `Column`, so I can't apply the heading centering in the 
first patch. Uhg. I forgot it still used a C++ `nativeInterface` model back 
then as well so it's... difficult to test.
  
  I'll just do do the `(model[0].length > 0 || model[1].length > 0)` + `Notice 
{ visibility: model.length > 0 }` in the 5.12 commit. It'll probably have merge 
conflicts merging to 5.14 I'll need to fix which I could apply the centering 
in. Or should I make that a 2nd commit in the 5.14 branch?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

To: Zren, kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren added a comment.


  Note: Env Canada lists all their Warnings + Watches for all of Canada at 
https://weather.gc.ca/warnings/index_e.html should anyone need to test in the 
future.
  
  Is there any other Ion besides EnvCanada that currently displays "Warnings"?
  
  I can definitely push to `5.12` right now. I'll ping you if I have trouble 
with merging down to 5.14/5.15/master.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

To: Zren, kossebau, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren updated this revision to Diff 51449.
Zren edited the summary of this revision.
Zren added a comment.


  Add `Layout.alignment: Qt.AlignHCenter` to the `PlasmaExtras.Heading`
  
  F6608836: 2019-02-11___17-47-22.png 

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18936?vs=51445=51449

REVISION DETAIL
  https://phabricator.kde.org/D18936

AFFECTED FILES
  applets/weather/package/contents/ui/NoticesView.qml
  applets/weather/package/contents/ui/SwitchPanel.qml

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren added a comment.


  I just noticed that the "Warnings Issued" text is left aligned. Might as well 
center align it while we're at it.
  
  Add this as a child of `PlasmaExtras.Heading` to debug:
  
Rectangle { anchors.fill: parent; border.color: "#f00"; border.width: 1; 
color: "transparent"; }
  
  F6608826: 2019-02-11___17-39-46.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18936: [weather] Fix weather Notices tab not showing

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  `Toronto, ON` in the `Env Canada` ion currently has a weather warning. The 
weather widget's code currently has a bug that will only show the Notices tab 
if there's both a "warning" AND a "watch".
  
  This patch also hides the empty Warnings/Watches heading.
  
  -
  
  The code populating the `noticesModel` is found here for reference:  
  
https://github.com/KDE/kdeplasma-addons/blame/e0f0400dc7f263a29f86cf71924de6e9e24836d0/applets/weather/package/contents/ui/main.qml#L316
  
  F6608772: 2019-02-11___17-12-17.png 
  
  We also fix the bug in the following screenshot:
  
  F6608783: 2019-02-11___17-17-08.png 
  
  -
  
  I don't see any existing bugs reporting this issue:  
  
https://bugs.kde.org/buglist.cgi?component=weather_id=1587716=bug_id%20DESC=kdeplasma-addons_format=advanced

TEST PLAN
  - Patched `NoticesView.qml` and `SwitchPanel.qml` in 
`/usr/share/plasma/plasmoids/org.kde.plasma.weather/contents/ui/`
  - Ran `plasmawindowed org.kde.plasma.weather`
  - Selected a location with a warning

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D18936

AFFECTED FILES
  applets/weather/package/contents/ui/NoticesView.qml
  applets/weather/package/contents/ui/SwitchPanel.qml

To: Zren
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18696: Update `libdbusmenuqt` and the AppMenu plugin

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> CMakeLists.txt:27
>  
> -# add_subdirectory(test)
> +add_subdirectory(test)

We do not bundle the libdbusmenuqt test directory in this repo. So you need to 
comment this line out otherwise it will not build with the test directory 
missing.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D18696

To: ntninja, Zren, majohnson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18580: Accept commas to separate processes on the Search Edit

[Chris Rizzitello]

rizzitello added a comment.


  +1

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D18580

To: tcanabrava
Cc: rizzitello, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the 
Informative Alt+Tab skin (authored by Zren).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16093?vs=43263=49829

REVISION DETAIL
  https://phabricator.kde.org/D16093

AFFECTED FILES
  windowswitchers/informative/contents/ui/main.qml

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Chris Holland]

Zren added a comment.


  I forgot to merge this after david's patch was merged. I just tested this in 
the Neon Beta ISO to confirm the fix still works.
  
  In D16093#359639 , @ngraham wrote:
  
  > Hmm, this does not actually work for me. Seems like it logically should, 
but it doesn't.
  
  
  I'm guessing you didn't restart the `kwin_x11 --replace` process after 
manually patching the qml file, as I believe the old version is still kwin's 
cache/memory. Changing to another skin and back won't reload the skin, you need 
to restart kwin. That or you tested without D16693 
 that forwards keyboard events to the qml 
skin.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  There was a few +1s, but I wasn't exactly sure who specifically "approves" 
this for a merge to `plasma-workspace` or `digital-clock` specifically. My bad, 
I shouldn't of left this feature to the last minute and felt rushed to get it 
in. I'll try to avoid the time before the betas when submitting in the future.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: broulik, karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, 
ndavis, rooty, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:235fa8107dab: [Digital Clock] Add ability to set a custom 
date format string (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18019?vs=49332=49421

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma, #vdg
Cc: karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, 
rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D18206: Improve the Look and Feel KCM

[Chris Rizzitello]

rizzitello added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  > D18155 
  
  Looking at the alternative patch, I've renamed the config key variable to 
`customDateFormat`. Most of the differences stem from not using a "variant" 
data type for `DigitalClock.qml`'s `dateFormat` variable. The `string 
formatDate(datetime date, variant format)` (qt doc link 
) accepts a variant 
type.
  
  In D18019#390579 , @davidedmundson 
wrote:
  
  > So for those reasons, I'm inclined to say +1.
  
  
  Assuming there's no objection to this, I'll merge this Sunday night. The beta 
is Thurs, so I assume that's the cutoff date?
  
  > I don't think the answers to the same question apply to the "First Day of 
the Week" patch.
  
  Fair enough. With that setting, the user sort of expects every date selection 
calendar popup (Qt/Gtk) to follow that setting. Where as with this setting, the 
user's expectation is that it should only change the panel's clock widget.
  
  > I don't think we need the colour formatting link. It's a niche within a 
niche. Removing it "solves" the escaping issue as it means the user is doing 
something undocumented in the first place.
  
  Sounds good. Until there's an embedded list of examples (D18168 
) it could just overwhelm the user with 2 
different syntaxes.
  
  -
  
  Final note. We're using `Qt.formatDate()`, which means the "time formats" 
`hh`, `mm`, `ss`, `t` (time zone), and `zzz` (millis) are not replaced with 
their value. Implementing that would require duplicating the "sizehelper 
timeMetrics" code for the date format though, which I can't guarantee a bugless 
patch this soon before the 5.15 Beta. If I finish D18168 
, then it might help suggest to the user 
that only the "date variables" are accepted.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, 
rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren updated this revision to Diff 49332.
Zren edited the summary of this revision.
Zren edited the test plan for this revision.
Zren added a comment.


  - Rename config key from `dateFormatStr` and config TextField 
`dateFormatTextField` to `customDateFormat`.
  - Remove the "Color Format Documentation" link.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18019?vs=49137=49332

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma, #vdg
Cc: karpenyamichael, davidedmundson, abetts, cfeck, ngraham, mart, ndavis, 
rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18168: [WIP] [Digital Clock] Embed date formatting variable documentation

[Chris Holland]

Zren created this revision.
Zren added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Assuming D18019  is merged, this would:
  
  -
  
  Provides an easy lookup of the date format variables for the user so the user 
does not need to Alt+Tab between windows.
  
  You can click a variable or it's rendered text to insert the variable into 
the TextField. It will add a space `" "` unless the text is empty.
  
  You can also drag a variable and drop it onto the text field to insert it.
  
  -
  
  F6539261: screen-2019-01-10_14.46.15.mp4 

  
  To Do:
  
  [ ] Delete the selected text first before inserting.
  [ ] I should check if we should add a space afterwards as well in case the 
text cursor is in the middle of a word.
  [ ] I should not add a space if there's already a space in front.
  [ ] Select the inserted text
  [ ] `TextField.focus = true` instead of drawing a rectangular outline above 
the TextField to demonstrate we can drop?
  [ ] Move the `TextField.cursorPosition` when a hovering with a drag

TEST PLAN
  - Test clicking to add.
  - Test dragging and dropping.
  - Test adding with the `cursorPosition` at the start of a word, and make sure 
it adds a space after (but not before).
  - Test adding with the `cursorPosition` inside a word, and make sure it adds 
a space before and after.
  - Test adding with the `cursorPosition` at the end of a word, and make sure 
it adds a space before (but not after).
  - Test adding with a selection, and make sure it deletes the existing 
selected text first before adding.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18168

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DateFormatTable.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma, #vdg
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren updated this revision to Diff 49137.
Zren edited the summary of this revision.
Zren added a comment.


  Translate the "Time Format Documentation" link.
  Add a link to QML's Text RichText docs under the "Color Format Documentation" 
label (translated).
  Place the 2 links below the text field.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18019?vs=48815=49137

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren, #plasma, #vdg
Cc: abetts, cfeck, ngraham, mart, ndavis, rooty, plasma-devel, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  The "show date" / "show seconds" toggles only affect the current widget 
instance as well. It would be nice if plasma had a 
`plasmoid.globalConfiguration.dateFormatStr` API which all widget instances (on 
all panels/screens) were bound to, so the user only had to configure it once 
for all screens. Though a person might have a clock on a vertical panel on one 
screen, and a thin horizontal panel on the other that might require a different 
configuration. That's an edge case example though.
  
  -
  
  I played around with a prettier looking example table.
  
  F6538091: 2019-01-10___02-37-24.png 
  F6538098: 2019-01-10___02-42-25.png 
  
  However I couldn't settle on anything. We can focus on a fancy TextField with 
embedded documentation later.
  
  For now though, I'd like to know this feature with the 2 documentation links 
can be merged. Is it to late to get added to Plasma 5.15? The Beta is next week.
  
  F6538107: 2019-01-10___03-04-57.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: abetts, cfeck, ngraham, mart, ndavis, rooty, plasma-devel, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  In D18019#388829 , @ndavis wrote:
  
  > Shouldn't the documentation explain that apostrophes need to be used or is 
the fact that they need to be used unusual and specific to this clock widget?
  
  
  The time format docs mentions:
  http://doc.qt.io/qt-5/qml-qtqml-qt.html#formatDateTime-method
  
  > All other input characters will be ignored. Any sequence of characters that 
are enclosed in single quotes will be treated as text and not be used as an 
expression.
  
  Which you can combine with QML's RichText documentation:
  http://doc.qt.io/qt-5/qml-qtquick-text.html#textFormat-prop
  
  The time format docs do not provide an example of using single quotes, and 
you'd need a person with a programmers mindset to use the escape character with 
the rich text docs to get the examples above.
  
  A user is more likely to try and use `ddd d` which 
would turn into `Tue 8` and give up... Though now 
that I think of it, `ddd` is the only color that would need to be escaped. 
`aaa`, `bbb`, `ccc`, `eee`, `fff` are not date format variables so they are 
ignored. `font` has a `t`  (time zone), but since it has `fon` in front of it, 
the date formatting ignores it. `` is similar. `color=` is ignored 
since it has no variables in it. `` and `` is also ignored.
  
  We could probably get away with just linking to the rich text documentation. 
I've been over-complicating it in Event Calendar for a while now it seems. 
Should the link's label be `i18n("Text Color Documentation")` or `i18n("Rich 
Text Documentation")`?
  
  -
  
  In D18019#388876 , @mart wrote:
  
  > is this the right place for it? (a text field to enter the "magic" date 
format letters is a very geeky ui, and i would prefer to not go there) 
shouldn't be a generic localization/date format setting? (and with also a 
graphical ui to generate this)
  
  
  The user can already change the Date Formatting globally to a specific 
Locale's time format (right click widget > Set Time Format...), which is 
limiting.
  
  The widget's Long Format uses a ridiculous width on the panel:
  F6536135: 2019-01-08___10-21-26.png 
  
  While the Short Format does not display the day of the week, includes the 
year (which isn't useful after January) and since Canada/US puts the Month 
first, annoying to read since the month is represented as a number as well.
  F6536137: 2019-01-08___10-24-05.png 
  
  Changing the global Time Format requires the user to **restart plasma** to 
apply and see the changes directly in the panel. Changing the global format 
also isn't desired since people tend to use an over simplified date format  in 
the panel (eg: `Tue 31` or `Jan 31`), but will still want legible timestamps 
everywhere else (eg: Dolphin).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: mart, ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added a comment.


  In D18019#388811 , @ndavis wrote:
  
  > I'm leaning towards no, but a second link to text formatting documentation 
might be a good idea.
  
  
  Adding a second link is pretty easy, though I wrote this before I noticed 
your edit. A second link would look better + simpler to maintain though. Though 
without a RichText example, the user might not understand the need to escape 
using apostrophes without an example (`''ddd''` ).
  
  > I'm leaning towards no, but an example of the custom time formatting and 
another of Rich Text formatting would be a good idea.
  
  Here's an example table, using an unconventional method of drawing a grid.
  
  F6533733: 2019-01-08___00-40-47.png 
  
QtLayouts.GridLayout {
id: exampleFormatsTable
columns: 2

property var model: [
"-MM-dd",
"MMM d",
"''ddd''d",
"''ddd''d",
]

Repeater {
model: exampleFormatsTable.model.length * 2

Item {
id: cell
property int padding: units.smallSpacing
implicitWidth: exampleLabel.implicitWidth + padding*2
implicitHeight: exampleLabel.implicitHeight + padding*2
QtLayouts.Layout.fillWidth: true
readonly property int row: Math.floor(index / 
exampleFormatsTable.columns)
readonly property int column: index % 
exampleFormatsTable.columns

Rectangle {
anchors.fill: parent
color: exampleLabel.color
opacity: 0.1
}

QtControls.Label {
id: exampleLabel
anchors.left: parent.left
anchors.top: parent.top
anchors.margins: cell.padding

textFormat: cell.column === 0 ? Text.PlainText : 
Text.RichText
text: {
var exampleFormat = exampleFormatsTable.model[cell.row]
if (cell.column === 0) {
return exampleFormat
} else {
return Qt.formatDate(new Date(), exampleFormat)
}
}
}
}

}
}

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> configAppearance.qml:145
> +'name': "custom"
>  }
>  ]

Does this also need a `i18nc("custom date format", "Custom")` translation 
context?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18018: [Digital Clock] Add ability to change first day of week

[Chris Holland]

Zren added a comment.


  In D18018#387920 , @davidedmundson 
wrote:
  
  > Is there a use case for having it configurable inside the plasmoid 
separately from configuring it system wide?
  
  
  https://bugs.kde.org/show_bug.cgi?id=390330#c5
  
  > Just change the locale to Egypt [مصر - العربية (ar_EG)] (the user prefers 
en_US) and many countries in the region and the start of the week will be 
Saturday.
  >  Changing the local from systemsettings will results in too many changes 
across KDE that I do not want. Since I can no longer change every minor detail 
in the Regional settings I had to edit files directly to achieve what I want.
  
  F6531531: image.png 
  
  I don't believe anyone asked if he changed the "time locale" to ar_EG while 
leaving the rest at en_US. However testing with `LC_TIME="ar_EG.UTF-8"` shows 
that it would change the hour/month/year into arabic, which probably wasn't 
desired.
  
LC_TIME="ar_EG.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock
LANGUAGE="ar_EG:ar" LANG="ar_EG.UTF-8" LC_TIME="ar_EG.UTF-8" plasmoidviewer 
-a org.kde.plasma.digitalclock
  
  The ability to customize Qt's `en_US` locale's `firstDayOfWeek` system wide 
would be nice. It would be difficult to do though I assume? We'd essentially 
need to create a new locale right? Thus the simplicity of making just the 
widget configurable.
  
  Right now with the patch, the `firstDayOfWeek` in the widget would be 
different than the Qt Widget calendar in "Adjust Date and Time...". So we might 
get new bug reports of the user annoyed that the feature only affects the 
digitalclock widget.
  
  It also only affecting the current screen, as they'd need to change it on 
every screen's panel, but that is also a gripe with the "Show Date" toggle as 
well.

INLINE COMMENTS

> pino wrote in configCalendar.qml:68
> this needs a context (using i18nc), otherwise translators have no idea what 
> "Default" means

Is this informative enough? `i18nc("locale's default day of week", "Default")`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18018

To: Zren, #plasma
Cc: abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18019: [Digital Clock] Add ability to set a custom date format string

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Adds a new `dateFormatStr` config key which is used when the `dateFormat` 
"StringEnum" is set to `custom`.
  Shows a link to the Qt time formatting documentation above the text field.
  Qt doc link and text field are hidden when not set to custom date format.
  
  CCBUG: 340982
  
  -
  
  - Should I add presets like Event Calendar?
  
  F6530111: 2019-01-06___13-15-19.png 
  
  F6530110: 2019-01-06___13-14-56.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: Zren
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18018: [Digital Clock] Add ability to change first day of week

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  CCBUG: 390330
  
  The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to 
represent the locale's default value.
  
  -
  
  If you have issues with the enum starting at -1, just say so and I'll shift 
it to Default=0, Sunday=1, Monday=2.
  
  F6530020: 2019-01-06___12-06-02.png 
  
  F6530016: 2019-01-06___11-55-41.png 

TEST PLAN
  - Open config > Calendar Tab > Change to First day of week to Wednesday
  - Open Digital Clock popup, confirm it starts at Wednesday
  - Close the widget config.
  - Reopen the widget config and confirm the ComboBox is populated with the 
correct (new) value.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18018

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/digital-clock/package/contents/ui/configCalendar.qml

To: Zren
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

[Chris Holland]

Zren added a comment.


  That still requires the user to drag a button, which isn't exactly obvious or 
a normal behaviour, just to discover what it is. It doesn't look like a desktop 
widget, not that the user would recognize it as one, as KDE by default does not 
display any desktop widgets the user can compare it with.
  
  The name "Desktop Toolbox" doesn't really describe it properly either. It's a 
button that opens a context menu. "Toolbox" usually refers to GIMP's "tool 
selection panel" where you have several buttons in a grid. The Panel has a 
"toolbox" to adjust the height of the panel.
  
  An alternative solution would be to put a heading in the context menu.
  
  Here's a quick mockup by editing 
`/usr/share/plasma/packages/org.kde.desktoptoolbox/contents/ui/` by treating 
`modelData.enabled = false` as a "heading".
  
  F6521409: 2019-01-02___16-13-00.png 
  
  Here's another mockup using `PlasmaExtras.Heading` instead.
  
  F6521429: 2019-01-02___16-25-16.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17921

To: Zren, #plasma, #vdg
Cc: ngraham, plasma-devel, squeakypancakes, alexde, IohannesPetros, GB_2, 
rooty, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Even when a user scours the system settings + desktop config looking how to 
disable this button, the user will have no indication this feature is called 
the "Desktop Toolbox". The button itself will show the current activity when 
not placed in a corner (eg: "Default" activity). When you click the menu, it 
does not have a "Desktop Toolbox" label either.
  
  -
  
  So I suggest that we show the icon next to the checkbox. Here's what it looks 
like with all 4 combinations of Breeze Light/Dark Color Theme + Desktop Theme.
  
  F6521014: 2019-01-02___10-54-43.png 
  
  F6521013: 2019-01-02___10-53-24.png 
  
  F6521012: 2019-01-02___10-52-57.png 
  
  F6521011: 2019-01-02___10-54-15.png 

TEST PLAN
  - Copy `/usr/share/plasma/plasmoids/org.kde.desktopcontainment` to 
`~/.local/share/plasma/plasmoids/`
  - Edit `contents/ui/ConfigTweaks.qml`
  - Reopen the Desktop Settings > Tweaks (no restart of plasma is needed since 
the config window is destroyed and reloaded each time it's opened).
  - Delete `~/.local/share/plasma/plasmoids/org.kde.desktopcontainment/` when 
you're finished testing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17921

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigTweaks.qml

To: Zren
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15888: new icons (Breeze style)

[Chris Holland]

Zren added a comment.


  We're currently trying to draw the C++ Breeze/forks window decorations in 
T9899  (and 
https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs 
obsolete. However we can merge these in the short term until that code is ready.
  
  Oddly enough, the previous SVGs didn't follow the color scheme (nor do the 
new ones but thats fine).
  
  Breeze (aka default)
  
  
  F6392367: 2018-11-04___20-48-52.png 
  
  F6392366: 2018-11-04___20-49-22.png 
  
  F6392365: 2018-11-04___20-49-32.png 
  
  F6392364: 2018-11-04___20-49-46.png 
  
  Breeze Dark
  ===
  
  F6392363: 2018-11-04___20-51-15.png 
  
  F6392362: 2018-11-04___20-51-29.png 
  
  F6392361: 2018-11-04___20-51-39.png 
  
  F6392360: 2018-11-04___20-51-50.png 

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D15888

To: borisg, martinkostolny, #plasma, #vdg, broulik, ngraham
Cc: Zren, IlyaBizyaev, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) 
to exit the app (authored by Zren).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16521?vs=44472=44504

REVISION DETAIL
  https://phabricator.kde.org/D16521

AFFECTED FILES
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/main.cpp

To: Zren, ngraham
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  QML `Shortcut` requires Qt 5.5, so we bumped QtQuick to 2.5.
  
  https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html
  
  As discussed in D16516 

TEST PLAN
  Tested `Ctrl+Q` with search text field focused, and after clicking an icon 
with the grid view item focused. Both attempts exited the app.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D16521

AFFECTED FILES
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/main.cpp

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16516: [cuttlefish] Auto-focus on search textfield when app opens

[Chris Holland]

Zren added a comment.


  - https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html
  - http://doc.qt.io/qt-5/qkeysequence.html#StandardKey-enum
  - http://doc.qt.io/archives/qt-4.8/qkeysequence.html#standard-shortcuts
  - `QKeySequence::Quit`
  - http://doc.qt.io/qt-5/qml-qtqml-qt.html#quit-method
  
  So adding this should work... but doesn't.
  
// cuttlefish.qml
import QtQuick 2.5
Item {
Shortcut {
sequence: StandardKey.Quit
onActivated: Qt.quit()
}
}
  
  We get:
  
Signal QQmlEngine::quit() emitted, but no receivers connected to handle it.
  
  
  
  > to quit a C++ application when this method is called, connect the 
QQmlEngine::quit() signal to the QCoreApplication::quit() slot.
  
  Hmmm.
  
  Skimming Google/StackOverflow, we need to add:
  
// main.cpp
#include 
QObject::connect(settingsapp->engine(), ::quit, , 
::quit);
  
  I wonder if we should be doing the shortcut in C++ as a QAction... oh well, 
discuss that in the patch. Patch incoming.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D16516

To: Zren, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16516: [cuttlefish] Auto-focus on search textfield when app opens

[Chris Holland]

Zren added a comment.


  In D16516#350641 , @ngraham wrote:
  
  > YES
  
  
  lol, that annoyed you too eh? It's been bugging me for ages.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D16516

To: Zren, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16516: [cuttlefish] Auto-focus on search textfield when app opens

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:542388f984cf: [cuttlefish] Auto-focus on search textfield 
when app opens (authored by Zren).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16516?vs=7=8

REVISION DETAIL
  https://phabricator.kde.org/D16516

AFFECTED FILES
  cuttlefish/package/contents/ui/Tools.qml

To: Zren, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16516: [cuttlefish] Auto-focus on search textfield when app opens

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

TEST PLAN
  Manually edited 
`/usr/share/plasma/packages/org.kde.plasma.cuttlefish/contents/ui/Tools.qml`, 
then launched cuttlefish.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D16516

AFFECTED FILES
  cuttlefish/package/contents/ui/Tools.qml

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[Chris Holland]

https://bugs.kde.org/show_bug.cgi?id=304696

Chris Holland  changed:

   What|Removed |Added

 CC||zrenf...@gmail.com

--- Comment #14 from Chris Holland  ---
As Oliver said in 2013, it looks like this is the intended behaviour since it
was first written (8 years ago?).

https://github.com/KDE/powerdevil/blame/master/daemon/actions/bundled/dimdisplay.cpp#L64

At 50% the set idle duration, it dims to 50% brightness.
At 75% the set idle duration, it dims to 12.5% brightness.
At 100% the set idle duration, it dims to 0% brightness.

We could maybe use different values, say 90% brightness, then 70% brightness,
before dropping to 0% at the specified time.

I wonder if there'd be issues with changing it to 5/4 (125% idle duration) and
3/2 (150% idle duration) so that it doesn't start dimming before the user's
explicitly defined value.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D16327: Update libdbusmenuqt folder

[Chris Holland]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by 
Zren).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16327?vs=43949=44177

REVISION DETAIL
  https://phabricator.kde.org/D16327

AFFECTED FILES
  CMakeLists.txt
  plugin/libdbusmenuqt/CMakeLists.txt
  plugin/libdbusmenuqt/com.canonical.dbusmenu.xml
  plugin/libdbusmenuqt/dbusmenuimporter.cpp
  plugin/libdbusmenuqt/dbusmenuimporter.h
  plugin/libdbusmenuqt/dbusmenushortcut_p.cpp
  plugin/libdbusmenuqt/dbusmenushortcut_p.h
  plugin/libdbusmenuqt/dbusmenutypes_p.h

To: Zren
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16394: Hide Buttons With Empty Text (Gtk Separators)

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R884:942169541d33: Hide Buttons With Empty Text (Gtk 
Separators) (authored by Zren).

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16394?vs=44133=44176

REVISION DETAIL
  https://phabricator.kde.org/D16394

AFFECTED FILES
  package/contents/ui/AppMenu.qml

To: Zren, broulik
Cc: trmdi, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16327: Update libdbusmenuqt folder

[Chris Holland]

Zren added a comment.


  For now, I'm going to merge this so I can keep the widget in sync with the 
global menu widget. We can revisit linking to a shared library later on.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16327

To: Zren
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16394: Hide Buttons With Empty Text (Gtk Separators)

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Fixes issue #146 on GitHub:
  https://github.com/kotelnik/plasma-applet-active-window-control/issues/146
  
  This is the same method the global menu widget uses:
  
https://github.com/KDE/plasma-workspace/blob/master/applets/appmenu/package/contents/ui/main.qml#L131

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16394

AFFECTED FILES
  package/contents/ui/AppMenu.qml

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16327: Update libdbusmenuqt folder

[Chris Holland]

Zren added a comment.


  KNotifications provides an example of linking to `dbusmenu-qt5`:
  https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49
  
  However

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16327

To: Zren
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16327: Update libdbusmenuqt folder

[Chris Holland]

Zren added a comment.


  Yeah, I'm not 100% sure why the Active Window Control widget needs it. I 
assume it should be dynamically linking to the 
`/usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2`, but I wanted to update all the 
common code first before making major refactoring.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16327

To: Zren
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16329: Add a ReadMe with install from Git instructions and bugzilla links

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  TODO: Figure out all the build dependencies.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16329

AFFECTED FILES
  ReadMe.md

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16328: Saner config defaults

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Make sure the buttons have a dedicated place, filling the entire height of 
the panel rather than only 50%. We could probably limit the size of the buttons 
to be the same max size as panel icons.
  
  This enables the AppMenu by default, assuming the user will compile the 
widget rather than downloading a zipped `.plasmoid`.
  
  - Enable Fill the Width so the "double click to maximize" is available by 
default.
  - Enable `appmenuDoNotHide` so it's similar to Global Menu
  
  Should probably also make `showButtonOnlyWhenMaximized` true as well, once 
I've also patched AWC to always keep a blank area dedicated for the buttons as 
it currently slides the title/menu to where the buttons were.
  
  F6339169: screen-2018-10-19_16.53.17.mp4 


REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16328

AFFECTED FILES
  package/contents/config/main.xml

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16327: Update libdbusmenuqt folder

[Chris Holland]

Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I needed to add `include(ECMQtDeclareLoggingCategory)` to the root 
`CMakeLists.txt` to get it to compile.
  
  https://github.com/KDE/plasma-workspace/tree/master/libdbusmenuqt
  
  I've no idea why the annotations for the qdbus ItemsPropertiesUpdated signal 
used `In0` instead of `Out0`.
  
  
https://github.com/kotelnik/plasma-applet-active-window-control/blob/master/plugin/libdbusmenuqt/com.canonical.dbusmenu.xml#L5

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D16327

AFFECTED FILES
  CMakeLists.txt
  plugin/libdbusmenuqt/CMakeLists.txt
  plugin/libdbusmenuqt/com.canonical.dbusmenu.xml
  plugin/libdbusmenuqt/dbusmenuimporter.cpp
  plugin/libdbusmenuqt/dbusmenuimporter.h
  plugin/libdbusmenuqt/dbusmenushortcut_p.cpp
  plugin/libdbusmenuqt/dbusmenushortcut_p.h
  plugin/libdbusmenuqt/dbusmenutypes_p.h

To: Zren
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Chris Rizzitello]

rizzitello added a comment.


  In D16031#341646 , @davidedmundson 
wrote:
  
  > Why should the login screen look different to the lock screen?
  
  
  This is a response to user complaints about the login screen receiving the 
same blur used on the lock screen when the controls are shown. Since the 
controls are always shown on the login screen you get a blurry background on 
the login screen. Now if you are saying this looks good and we should now think 
about using it in place of the blur on the lock screen. I Think we could do 
that now since the main reason to use blur in the first place was to controls 
more visible.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D16031

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello
Cc: davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, filipf, 
rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Chris Rizzitello]

rizzitello accepted this revision as: rizzitello.
rizzitello added a comment.
This revision is now accepted and ready to land.


  This Looks Great!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D16031

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello
Cc: rizzitello, abetts, pstefan, broulik, rikmills, filipf, rooty, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren added a comment.


  Sorry, just merged both to master. Thanks davidedmundson for the patches that 
updated the ComboBox.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma, davidedmundson
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:347f43c42b70: Add Get Wallpaper Plugins... 
button to Config Desktop dialog (authored by Zren).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12041?vs=32246=43256

REVISION DETAIL
  https://phabricator.kde.org/D12041

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

To: Zren, #plasma, davidedmundson
Cc: mart, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to 
open GHNS dialog (authored by Zren).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=42950=43255

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma, davidedmundson
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren updated this revision to Diff 42950.
Zren added a comment.


  - Got rid of the signal+slot that emits KNewStuff changes since 
wallpaperComboBox is automagically updated.
  - Reordered the command arguments so the variable is last in 
`wallpaperplugin.knsrc`.
  - Put the `plasmoids.knsrc` and `wallpaperplugin.knsrc` filepaths on separate 
lines in the `CMakeList.txt`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=33951=42950

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren added a comment.


  Finally got around to updating this patch and formally testing with 
`kdesrc-build` (sort of) in Neon Unstable which has Frameworks 5.51.
  
  F6306500: screen-2018-10-05_16.35.50.mp4 

  
  Updated diff incoming as soon as I figure out how to diff 
`~/kde/src/.../plasma-workspace` since they aren't git repos.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15862: option to specify icons spacing for systray

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> Zren wrote in main.qml:310
> Hmm. We might want to scale by DPI. While the default 0px will not be 
> affected by DPI, if a Look And Feel sets it to 10px, it would look different 
> for users with 1x DPI and 2x DPI.
> 
> Eg:
> 
>   spacing: plasmoid.configuration.iconsSpacing * units.devicePixelRatio

We probably need to round it too so that the icons start on integer coordinates.

  spacing: Math.round(plasmoid.configuration.iconsSpacing * 
units.devicePixelRatio)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15862

To: mvourlakos, #plasma, davidedmundson
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15862: option to specify icons spacing for systray

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> main.qml:310
>  id: tasksRow
> -spacing: 0
> +spacing: plasmoid.configuration.iconsSpacing
>  height: parent.height - (vertical && expander.visible ? 
> expander.height : 0)

Hmm. We might want to scale by DPI. While the default 0px will not be affected 
by DPI, if a Look And Feel sets it to 10px, it would look different for users 
with 1x DPI and 2x DPI.

Eg:

  spacing: plasmoid.configuration.iconsSpacing * units.devicePixelRatio

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15862

To: mvourlakos, #plasma, davidedmundson
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx added a comment.


  Any updates on whether this patch could be merged? It has been a long wait. 
If there are any improvements I can make to the patch I will be more than happy 
to put more work into it.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson
Cc: garywang, broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren added a comment.


  Awesome!
  
  The KPackage patch will end up in... Frameworks 5.51?
  And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 
(according to `plasma-workspace`'s `CMakeList.txt`).
  So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe, 
wait for the 5.14 release on Oct 9th.
  Frameworks 5.51 is released Oct 13th, so it'll be easier to test after that 
(though I'll try to build `kpackage` with the patch and test it in a sec).
  Alright, I'll set a reminder on Oct 17 (just after 5.14.1) to merge my 2 
patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14869: [RFC] Increase default font sizes by 1 pt

[Chris Rizzitello]

rizzitello added a comment.


  > ... do people change their screen resolutions very often anymore?
  
  Yes I have to change my resolution quite often and its almost always because 
of one of two things.
  
  1. Some application that was in fullscreen at a specific resolution has 
crashed (often a game via wine). This maybe solved by using wayland?
  2. I've added a new screen and its not set to the correct resolution ( A 
second / third screen). This is alot less of an issue then the first one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: mart, oysteins, rooty, filipf, safaalfulaij, rikmills, harmathy, rkflx, 
abetts, davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14869: [RFC] Increase default font sizes by 1 pt

[Chris Rizzitello]

rizzitello added a comment.


  In D14869#312041 , @filipf wrote:
  
  > > ! In D14869#311980 , @rooty 
wrote:
  > > you can always put in a wizard that runs on booting for the first time 
and asks people for their preferences... i still wouldn't hardcode them (what 
if you change your mind later on)
  >
  > I think this is a good idea. We still get some newcomers complaining that 
the configuration options are too much for them so we could make a simplified 
wizard that would address the essentials. This would also perhaps tone down the 
need for and discussion about flipping defaults. We could have questions such 
as:
  >
  > - how would you like your desktop to be organized? Windows style, Mac 
style, Ubuntu style etc.
  > - do you prefer a light or dark theme? -> with allowing an option for a 
light theme with a dark panel
  > - how big should the fonts be? -> just a slider with real-time preview, if 
not of Plasma then sample text in the dialog
  > - do you wish to use single click or double click to open files?
  > - etc. -> something else of relevance
  >
  >   It wouldn't even necessarily have to pop-out upon first boot, just be 
somewhere prominent in system settings. But even if it pops-out, that's not 
that unprecedented in the Linux world, XFCE for example asks you for the 
preferred panel configuration. And you can always add a big SKIP button.
  
  
  I am all for a new user wizard. I have stated this on several of these kinds 
of threads.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: mart, oysteins, rooty, filipf, safaalfulaij, rikmills, harmathy, rkflx, 
abetts, davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14869: [RFC] Increase default font sizes by 1 pt

[Chris Rizzitello]

rizzitello added a comment.


  > How does your suggestion relate to both the DPI value of your hardware and 
what Xorg uses? Do we actually set a higher DPI value for Hi(gher)DPI hardware 
automatically, so the actual size to the eye is independent of the display in 
use? If not, why not?
  
  I have several HiDpi displays on a few machines and  Not a single one has 
changed the dpi for me. I have had to set the dpi on each machine. After that 
is done pretty much all scaling issues go away. Other then the occasional icon 
or control w/ a hard coded size. I do not use scaling on my hidpi displays at 
all it is not needed after the dpi is correctly set.
  
  > Other Os sizes.
  
  Looking around the net and trying on some windows machines here it seams they 
really bury the font size settings since i was not able to find them in the 
font or display area, they only provide an option to adjust scale of the screen 
or the dpi . To change the font setting you need to modify the theme your 
using.  After digging around I checked on windows 7 the default for is 9pt. 
every thing with a font. I was not able to find that box on the windows 10 
machine tried on.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: rooty, filipf, safaalfulaij, rikmills, harmathy, rkflx, abetts, 
davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D14869: [RFC] Increase default font sizes by 1 pt

[Chris Rizzitello]

rizzitello added a comment.


  The title bar with the bold font looks nice at both sizes.
  
  >   Reduced text density (obviously)
  
  Our defaults are not very dense so the loss of density is only going to be 
bad, except for the case of small screens. On those its more then reasonable to 
assume you will need to adjust your fonts and the sizes of things in general 
anyway.
  
  >   Some UI elements become larger, reducing overall screen density. It's 
particularly noticeable with Kickoff and the Task Manager. Are we willing to 
live with that, or should we investigate whether or nor that kind of scaling 
should happen? 
  
  To try to figure out how much larger things will be with these new defaults 
for the fonts I used gimp's scale tool with the provided images. Its looking 
like the average element will be 10% larger with the bump up in font size. This 
should effect any element that has text, all qlabels without text and anything 
using Font Metrics.
  
  > There are also some widgets like the System Tray whose icons become spaced 
very slightly farther apart for basically no reason (there's no text). Is this 
a bug we should fix?
  
  Yes, We should look into why these widgets are acting that way.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: abetts, davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14869: [RFC] Increase default font sizes by 1 pt

[Chris Rizzitello]

rizzitello added a comment.


  Honestly if you look at the last before and after shot the text now looks 
worse then when it was 10 pt. I think the issue is more your hinting then the 
font size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

[Chris]

https://bugs.kde.org/show_bug.cgi?id=375840

Chris  changed:

   What|Removed |Added

 CC||scrutini...@pm.me

--- Comment #8 from Chris  ---
Same here on Debian Stretch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10362: Swap reveal password button logic

[Chris Rizzitello]

rizzitello added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  In D10362#202592 , 
@elvisangelaccio wrote:
  
  > Would it be possible to implement this feature like in the Windows 10 lock 
screen? (i.e. don't toggle the state; reveal the password only as long as the 
button is pressed). I feel like it would remove the security issue in the first 
place (as there isn't anymore a persistent state where the password can be 
visible).
  
  
  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: broulik, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, #frameworks

D14234: [Folder View] Improve file name text rendering

[Chris Holland]

Zren added a comment.


  I tested the `x: -main.x % 1` code.
  
  Before:
  F6120560: 2018-07-19___13-46-20.png 
  
  After:
  F6120562: 2018-07-19___13-47-29.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14234

To: broulik, #plasma, hein, davidedmundson, ngraham
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart