D25428: Improved support for desktop "Folder View"

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  bump!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D25428: Improved support for desktop "Folder View"

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Any update on the status of this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D28461: In sidebar mode show if a module is in default state or not

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  How about instead of a blue dot there's instead an option in the SySe 
hamburger button menu to use search to filter out any settings pages where 
settings haven't been changed, meaning that only settings with changes made to 
them are then listed in the search results?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart

D28461: In sidebar mode show if a module is in default state or not

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  IMHO this is wholly pointless a change, currently. Most people won't care 
about if they've made changes or not in SySe from the defaults, and quite 
frankly seeing that indicator on the sidebar would potentially even deter user 
customisation if not utterly confuse people. If it was an optional setting in 
settings to show these changed settings indicators on the sidebar (such as a 
checkbox item in the SySe menu) that you could turn off by default, I wouldn't 
mind this at all.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D28461

To: bport, #plasma, ervin, meven, crossi, hchain, #vdg
Cc: The-Feren-OS-Dev, ndavis, broulik, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In my honest opinion, it'd probably be good to also get rid of Breeze Light 
in a separate patch as TBH as I see it right now Breeze will make Breeze Light 
redundant by default post-this-patch since they'll both be Breeze Light in a 
sense. It just seems redundant to me to be honest having Breeze Light next to 
Breeze... Light... by default.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D28317#635865 , @ngraham wrote:
  
  > Sure, that seems reasonable. I guess the question is whether we should ship 
it in this repo, or make it a GHNS thing, as with the other old colorschemes 
like Norway, Wonton Soup, Honeycomb, etc.
  
  
  TBH I think making it a Get New Hot Stuff item would be a better fit for it. 
I mean, other things that have changed their theme colours, such as Google 
Chrome, have moved their original colour sets into their respective Stores too 
so I don't really see why Breeze would be that much of an exception. You might 
also want to put Breeze Classic Light in GHNS too for the OG light theme 
purists.
  (Note: I'm not counting stuff like Windows in this mention since their 
'Classic' themes are more-so just for compatibility sake rather than a random 
cosmetic change)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, 
LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28281: Add options for OSD feedback

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D28281#634702 , @sgoth wrote:
  
  > Cool thanks!
  >
  > As this is my first contribution via phabricator, can you give me a short 
advice on how to proceed?
  >  Do i "arc land" it myself? To master?
  
  
  IIRC you can only do that if you get an accepted application for becoming a 
"KDE Developer", otherwise you'll need a KDE Developer to land it for you, 
which will most likely happen anyway.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volumeosdcfg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack
Cc: The-Feren-OS-Dev, cblack, drosca, ngraham, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  For the lack of text on Full Name, is there any chance some hint text could 
appear in the full name text box when the textbox value is empty saying 
something along the lines of "Full Name" or something?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, 
zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77210.
The-Feren-OS-Dev added a comment.


  Redone, again.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77209=77210

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77209.
The-Feren-OS-Dev added a comment.


  One more diff tweak to make it normal-er.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=77208=77209

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 77208.
The-Feren-OS-Dev added a comment.


  Rebased on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75913=77208

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: kmaterka, gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  
`applications:systemsettings.desktop,applications:org.kde.discover.desktop,preferred://filemanager,preferred://browser`
  
  There is currently an issue that might make this cumbersome, unless it was 
fixed very recently as part of the patch work for this, being that 
preferred://browser causes duplicated entries for stuff like Vivaldi, etc 
(they'll be separate from the preferred:// pins meaning the preferred:// item 
basically acts as a quick launcher which is far from what is intended). Similar 
problem with preferred://filemanager. I would've used those instead of hard 
pins to vivaldi.desktop and org.kde.dolphin.desktop by default in Feren OS if 
it wasn't for that aforementioned issue being there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  The main point of this patch is the spacing increase between tray icons that 
this hitbox size increase gives, which makes the tray look less cramped as a 
result.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Went to check on different DPIs again to be sure it's fine and it definitely 
looks fine to me, scaling up the hitbox padding additions (and therefore the 
icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an 
issue.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#620052 , @IlyaBizyaev 
wrote:
  
  > In D27466#620050 , 
@The-Feren-OS-Dev wrote:
  >
  > > This patch only affects the System Tray widget itself, not anything else 
on the panel. Only the spacing around the icons that are part of the System 
Tray applet itself will be changed by this patch.
  >
  >
  > I understand, but, as I mentioned, for me it already looks like what you 
expect to achieve with this.
  >  Is it maybe DPI or font dependent, causing the spacing to be smaller in 
your local setup?
  
  
  I have 1.0 DPI scaling, though the system tray icon spacing is indeed 
controlled by DPI scaling due to the 'units.smallSpacing' size unit.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#620037 , @IlyaBizyaev 
wrote:
  
  > Repeating my comment on the previous diff for this change: on my machine, 
the current spacing for systray elements already looks like your "after" 
screenshot. With normal usage, my systray area (icons + clock + a note widget) 
takes up 1/4 of the panel. Does it mean that after this change, it's going to 
be even larger?
  
  
  This patch only affects the System Tray widget itself, not anything else on 
the panel. Only the spacing around the icons that are part of the System Tray 
applet itself will be changed by this patch.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27466#619931 , @ngraham wrote:
  
  > So at this point it's just one pixel, and I don't see the huge harm. :) 
However the last patch to adjust this (D27438 
) proved quite controversial, so we should 
wait for more opinions to avoid unduly ruffling feathers. :)
  
  
  To be fair, part of the issue with the previous patch was that it didn't 
increase hitbox size while increasing spacing, while this one does, so 
hopefully there won't be too many issues with this.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75913.
The-Feren-OS-Dev added a comment.


  Updated diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75912=75913

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75912.
The-Feren-OS-Dev added a comment.


  Updated diff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75873=75912

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75911.
The-Feren-OS-Dev marked an inline comment as done.
The-Feren-OS-Dev added a comment.


  Moved baseSize declaration and changed it to a standard variable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75869=75911

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75873.
The-Feren-OS-Dev added a comment.


  You gotta love arc/git sometimes...

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75872=75873

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75872.
The-Feren-OS-Dev added a comment.


  Arcanist please

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75871=75872

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75871.
The-Feren-OS-Dev added a comment.


  Hopefully fixed the diff again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75870=75871

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75870.
The-Feren-OS-Dev added a comment.


  Updated diff to be in line with parent patch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75864=75870

BRANCH
  arcpatch-D27465_1

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75869.
The-Feren-OS-Dev added a comment.


  Tidied up code a bit and introduced new baseSize variable  - Slightly 
increase system tray icon hitboxes in Non Tablet Mode Plasma

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75863=75869

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27469

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  ...and now the split is complete.
  https://phabricator.kde.org/D27466

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75863.
The-Feren-OS-Dev added a comment.


  Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode 
padding addition

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75862=75863

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27465: Add foundations for two future patches to complete the splitting of patch D27438

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75862.
The-Feren-OS-Dev added a comment.


  Make the click areas of system tray icons larger in Kirigami Tablet Mode

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75860=75862

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27465: Added foundations for two future patches to complete the splitting of patch D27438

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  ngraham recommended that I split up https://phabricator.kde.org/D27438 into 
three patches:
  
  1. This patch - the foundation code to get landed first so that the other two 
patches can be done as patches that change two separate lines instead of just 
one
  
  2. Tablet Mode increases tray icon spacing
  
  3. Increase tray icon spacing slightly on Non-Tablet Mode (half of the amount 
it increases by in Tablet Mode)
  
  This patch is the start of that process, made to be landed first so that 
patches 2 and 3 can then follow while only having a diff that affects one 
different line each of this patch's changed lines.

TEST PLAN
  Test that System Tray still works after these changes have been made

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  The initial patch of the three, now I've thought up a suitable way of doing 
this, has been made:
  https://phabricator.kde.org/D27465

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Actually, on second thought, @ngraham I'm not even sure if step 2 would even 
be worth it on its own, if possible.
  
  On your suggestion you have it adjusted to have step 3's tablet mode checker 
in step 2. If I don't have that check in place, for step 2, then it'd just be 
how it currently is anyway on master, effectively resulting in nothing to edit 
for a patch. I'll definitely do Step 3 as a patch, though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613097 , @ngraham wrote:
  
  > ...one to increase the spacing when in tablet mode, and another one to 
increase the spacing when in desktop mode. At this point each patch will be 
changing a different line in the function
  
  
  Due to how the current patch handles it, I'll probably have to all of step 3 
one patch since they change the same line as each other, but for sure I can 
split steps 2 and 3(1)+3(2) of your post into individual patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev abandoned this revision.
The-Feren-OS-Dev added a comment.


  Alright, I'll start splitting the patches up now. Marking this one as 
Abandoned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613104 , @IlyaBizyaev 
wrote:
  
  > I agree with @broulik in that the spacing already feels quite excessive, or 
at least doesn't need to be increased (:
  >
  > Does this depend on DPI/panel size maybe?
  
  
  Units.smallSpacing should change depending on the DPI, from what I've heard.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  How would I split it into two patches? Both patches would edit the exact same 
line.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Dominic Hayes]

The-Feren-OS-Dev accepted this revision.
The-Feren-OS-Dev added a comment.
This revision is now accepted and ready to land.


  Had to lower the cmake version requirement to be able to compile this, but 
this works just fine, and it's definitely something that'd be nice to have. I 
can't see any regressions nor leaks, either on this current patch version.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, davidedmundson, nicolasfella, GB_2, ngraham, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75851.
The-Feren-OS-Dev added a comment.


  Tweaked an added comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75850=75851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613051 , @davidre wrote:
  
  > In D27438#613050 , 
@The-Feren-OS-Dev wrote:
  >
  > > In D27438#612719 , @davidre 
wrote:
  > >
  > > > There is now not clickable space between items:
  > > >  F8108239: grafik.png  F8108241: 
grafik.png 
  > > >  At least it should be clickable
  > >
  > >
  > > For future reference, how do you get that size examining mode in Plasma 
Desktop Workspace?
  >
  >
  > That's inside gammaray
  
  
  For some reason I couldn't get gammaray to do that over here, but I did come 
up with a new method for the patch that should increase hitboxes as well as 
icon spacing. Could you check if it does so, just to be sure?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75850.
The-Feren-OS-Dev added a comment.


  Changed method used for increasing spacing between tray icons to something 
that increases hitbox sizes as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75804=75850

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#612719 , @davidre wrote:
  
  > There is now not clickable space between items:
  >  F8108239: grafik.png  F8108241: 
grafik.png 
  >  At least it should be clickable
  
  
  For future reference, how do you get that size examining mode in Plasma 
Desktop Workspace?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75804.
The-Feren-OS-Dev added a comment.


  One more patch update to keep the change consistent with the rest of the code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75803=75804

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Fair point, just checked that now and they're indeed the same. Got confused 
with 0.65 as 0.65 looks different to 0.5.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: filipf, ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75803.
The-Feren-OS-Dev added a comment.


  Went to 0.5, because 0.6 indeed looks just like 0.5 in execution

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75800=75803

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: filipf, ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75800.
The-Feren-OS-Dev added a comment.


  Changed value to Math.round(units.smallSpacing * 0.7)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75785=75800

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Nevermind, then, I guess something changed between now and Plasma 5.18.1 
master code meaning that no longer works, back to the old method...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev planned changes to this revision.
The-Feren-OS-Dev marked an inline comment as done.
The-Feren-OS-Dev added a comment.


  Managed to come to a good compromise, however now I've hit a bit of a 
roadblock.
  
  I've found that by editing these lines:
  
property int left: Math.round(units.smallSpacing / 2)
property int top: Math.round(units.smallSpacing / 2)
property int right: Math.round(units.smallSpacing / 2)
property int bottom: Math.round(units.smallSpacing / 2)
  
  ...to replace them with this:
  
property int left: Math.round(units.smallSpacing * 0.85)
property int top: Math.round(units.smallSpacing * 0.85)
property int right: Math.round(units.smallSpacing * 0.85)
property int bottom: Math.round(units.smallSpacing * 0.85)
  
  ...provides a better looking tray while not being that big spacing wise, 
while ALSO increasing hitboxes for each tray icon in the process:
  F8107457: image.png 
  
  However, there's one problem: Those lines aren't in the file currently being 
patched. They are there on the compiled version of the file, but for some 
reason they seem to be absent from the pre-compiled version of the file. I'll 
do some investigation, however for now I'll just mark as Changed Planned until 
I find a solution to the roadblock preventing me from replacing this patch with 
a better rendition of it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  After a bit more digging around the code, I found another alternative way to 
do this which also fixes a bug I just noticed with this patch (there's clicking 
deadzones in-between the tray icons), however the method for doing it causes 
this spacing:
  
  F8107436: image.png 
  
  I'll do a bit more digging on this alternative way to see if I can get it to 
be a spacing we can all agree on more than the current one.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#612484 , @ngraham wrote:
  
  > Also, it's nice to have the "after" versions right after each corresponding 
"before" version so you can more easily compare them by clicking on one and 
navigating between them with the arrow keys. :)
  
  
  Also done

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#612463 , @ngraham wrote:
  
  > To make this patch easier to review without applying it, please add all the 
various sets of before-and-after images to the Test Plan section, not in 
comments.
  
  
  Done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  VS same but with / 2:
  F8107328: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#612459 , @ndavis wrote:
  
  > Please check how this looks with a vertical panel.
  
  
  Looks a whole lot better on Vertical than without spacing IMHO (unitSpacing):
  F8107323: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Which one would people prefer?
  Units.smallSpacing:
  F8107285: image.png 
  
  Units.smallSpacing / 2:
  F8107287: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Would people prefer that above design to 4px? ^

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Here's it with / 2 added to the spacing value:
  F8107253: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to 3

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75785.
The-Feren-OS-Dev added a comment.


  Changed spacing to units.smallSpacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75783=75785

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to 3

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Before:
  F8107198: image.png 
  
  After:
  F8107205: image.png 
  
  Patch update coming in a bit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Set System Tray Plasmoid spacing value from 0 to 3

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  In my honest opinion Plasma's System Tray Plasmoid's current spacing value is 
currently set to 0, which leads to most of the tray icons looking rather 
cramped when put next to each other. This small patch increases the System Tray 
Plasmoid's spacing value from its current 0 value to 3.

TEST PLAN
  1. Change 'spacing: 0' to 'spacing: 3' in 
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/main.qml
 - what this patch is basically doing anyway
  2. Reload plasmashell and add a System Tray Plasmoid if one isn't already 
added

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  To make it stretch to the borders, simply just remove padding from panel.svgz 
and from the Plasmoid highlight SVG.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27384#611135 , @davidedmundson 
wrote:
  
  > I still don't fully understand the bug and the fix
  >
  > So what we're saying is:
  >  Something changes us to needs save early on startup
  >  We emit changed early
  >  That gets lost (?)
  >  So we have to reset back to unchanged after loading so that future changes 
will enable the apply button?
  
  
  In case it makes any more sense: The bug made Fonts KCM never indicate that 
unsaved changes have been made, meaning you can never Apply any changes since 
it doesn't think anything was changed that is now pending being applied. Apply 
is always insensitive. This patch however fixes that for me and others who were 
affected by this issue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Other people are confirming that this patch also fixes the issue:
  https://bugs.kde.org/show_bug.cgi?id=416358

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Dominic Hayes]

The-Feren-OS-Dev accepted this revision.
The-Feren-OS-Dev added a comment.
This revision is now accepted and ready to land.


  I can confirm this fixes the bug.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, 
The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Started building plasma-desktop over here on an affected machine with this 
diff applied

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27384

To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Since this is related, I'll just drop my concept design for Colours KCM for 
reference on a possible colour schemes header design to consider. Ignore the 
button at the bottom, I've realised now that that idea is pointless since we 
removed so many colour schemes by now out of the box.
  
  F8095773: Colour Schemes KCM Mockup.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24706: [RFC] Change button style

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  How about doing what GNOME does with Adwaita where a small drop shadow is 
applied on the bottom of the button to create the illusion of a push-in-able 
button only for the shadow to then go when the button is being pushed down?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, LeGast00n, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 68612.
The-Feren-OS-Dev added a comment.


  Edited code based on feedback and added Latte Dock layout and 
BorderlessMaximisedWindow value changing functionality

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23117?vs=68610=68612

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23117

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 68610.
The-Feren-OS-Dev marked an inline comment as done.
The-Feren-OS-Dev added a comment.


  Added support for BorderlessMaximizedWindows and specifying a Latte Layout  - 
Based on a code review, re-added original behaviour for Splash Screen setting 
if there's no 'defaults' file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23117?vs=66489=68610

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23117

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  @fvogt Nope, but now you've mentioned that I've added an extra line if 
there's no defaults file found to set the Splash Screen to be the Look & Feel 
name like it originally would do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23117

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 66489.
The-Feren-OS-Dev added a comment.


  - Based on a code review, re-added original behaviour for Splash Screen 
setting if there's no 'defaults' file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23117?vs=63632=66489

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23117

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: fvogt, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Pong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23117

To: The-Feren-OS-Dev, #plasma, davidedmundson, mart
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23117: kcmlookandfeel - Fixed Splash Screen applying

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  This is a small change to the Look & Feel KCM Code to fix 
https://bugs.kde.org/show_bug.cgi?id=409015 by changing the Splash Screen 
changing code a little bit.
  This revision makes Look & Feel check if the package has specified a Splash 
Screen, that it wants Plasma to change the user's current Splash Screen to, or 
not via the 'defaults' file and a check for the 'splashrc' 'Theme' value in 
there. If there isn't a value found it will revert back to the old method of 
applying Splash Screens - applying the Look & Feel name as the Splash Screen. 
If a value is found however, ksplashrc's Theme value will be set to that value 
instead of the Look & Feel's name.
  
  The reason for having the fallback in this code to the old behaviour is that 
many popular Look & Feels, such as the Adapta Look & Feel, all rely on the 
fallback method of applying Splash Screens to have their Splash Screens be 
applied, and if the fallback isn't there nothing will then their currently 
applied Splash Screen simply won't change at all unless the Look & Feel package 
specifies a Splash Screen theme.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23117

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: The-Feren-OS-Dev
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart