Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- I have implemented the local browsing search only to the Videos section as of now, but the application crashes, and it searches on the drive selection window, but doesn't search on the folder and file selection window after that. Please look into it and suggest where I am going wrong. Once this is done, it's the same implementation for images and songs. I would do that similarly. Diffs - browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 Diff: https://git.reviewboard.kde.org/r/117615/diff/ Testing --- Errors yet there so testing on hold. Thanks, Harshit Agarwal
Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- I have implemented the local browsing search only to the Videos section as of now, but the application crashes, and it searches on the drive selection window, but doesn't search on the folder and file selection window after that. Please look into it and suggest where I am going wrong. Once this is done, it's the same implementation for images and songs. I would do that similarly. Diffs - browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 Diff: https://git.reviewboard.kde.org/r/117615/diff/ Testing --- Errors yet there so testing on hold. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 20, 2014, 2:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/mainwindow.h f224060 shells/newshell/mainwindow.cpp f721d68 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 19, 2014, 6:40 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Sorry had tested only when one media is passed from command line while pmc is open. Tested and working now. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/mainwindow.h f224060 shells/newshell/mainwindow.cpp f721d68 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 18, 2014, 4:13 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Removed the play() function. Tested working from commandline url send. Other functionalities working as tested before. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 18, 2014, 10 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- removed the void MainWindow::playPlaylist() function, and introduced a slot to getMediaPlayer() in addNewInstanceArgsPlaylist(). Tested for playing a different file from the command line while PMC is open. Operating as expected. Rest of the implementation working as planned. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml bac33c2 browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/mainwindow.h f224060 shells/newshell/mainwindow.cpp f721d68 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- (Updated March 16, 2014, 6:09 a.m.) Status -- This change has been discarded. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The Play All button when clicked multiple times, was adding all the media multiple times onto the playlist. This is resolved, and now it adds the media only single time if the button is clicked multiple times. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 8aaddcc browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116824/diff/ Testing --- It has been tested with the local files in Music as well as the Videos section. Patch found to be consistent. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 9:30 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Implemented the thing pointed out by Shantanu. Now the media plays from the point where it is added. That is, it starts playing the new PlayAll media when it is clicked, even when there is media present in the playlist before. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:29 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Apologies for the wrong patch. That did not contain a line. Please review this instead. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:08 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- const (Something I need to remember always :P) As for the dual getPlaylist() call, I substituted it with getMediaPlayer(), so the effect remains the same, while avoiding to load the playlist twice, and the media can be played through the command line (tested). Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml bac33c2 browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 15, 2014, 6:21 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Changed the patch. Now it plays the first media when PlayAll is pressed, and works for the All Music section too! Now it is loading the playlist in the init() function. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs (updated) - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 shells/newshell/package/contents/ui/mediacenter.qml 714e561 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The Play All button when clicked multiple times, was adding all the media multiple times onto the playlist. This is resolved, and now it adds the media only single time if the button is clicked multiple times. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 8aaddcc browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116824/diff/ Testing --- It has been tested with the local files in Music as well as the Videos section. Patch found to be consistent. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button
On March 15, 2014, 7:43 p.m., Shantanu Tushar wrote: In general I don't see why N clicks of a button won't repeat the action N times, sounds very logical to me. So not sure if it needs fixing. Agreed, but PlayAll should be a single click feature right? Either we deactivate the button after a single click. On March 15, 2014, 7:43 p.m., Shantanu Tushar wrote: browsingbackends/localfiles/localfilesabstractbackend.cpp, line 153 https://git.reviewboard.kde.org/r/116824/diff/1/?file=254233#file254233line153 Where is model1 set? I don't see it being assigned any value ever. I'm actually assigning the current model value to model1 when the playAll button would be clicked. Since it is a global var, it would store the value of the previous model. And hence, when the next time a new call is initiated, it first checks with the previous model element, if the values are different, then only it adds the media to the playlist. Initially, i didn't assign any value to it, so the condition becomes true by default and the first click of the PlayAll button would always add the media - Harshit --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/#review52999 --- On March 15, 2014, 6:58 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- (Updated March 15, 2014, 6:58 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The Play All button when clicked multiple times, was adding all the media multiple times onto the playlist. This is resolved, and now it adds the media only single time if the button is clicked multiple times. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 8aaddcc browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116824/diff/ Testing --- It has been tested with the local files in Music as well as the Videos section. Patch found to be consistent. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC Home Screen Bug
The home screen text was kept bigger keeping in mind the big screen applications of PMC where the user might be viewing the software from a large distance (say, sitting on a couch). So I don't think we need to make it responsive. The big text on small window adjust by adding the scroll feature to itself when the window height is less than the menu height. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Sat, Mar 8, 2014 at 10:34 PM, Atul Dubey ug201212...@iitj.ac.in wrote: The home screen text is not responsive it overlaps with each other if we resize the app window to small sizes.. It would be better if we could set a condition as per the app height and width and either resize the text accordingly or hide the unimportant text... ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
On March 3, 2014, 6:01 a.m., Sujith Haridasan wrote: Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the Play All starts working as per my observation. Let me know if I am wrong. Test Cases: 1. With an pre-empty playlist, added videos from a folder on the local drive. Result: The videos get added on clicking the PlayAll Button, and the first video starts playing, window remains in the file browser only. 2. With a pre-filled playlist, and some video playing from the playlist, went to another folder and clicked PlayAll to a new set of videos. They get added to the existing playlist and the video continues without breaking. 3. With a single video playing from the local drive, and an empty playlist before, clicked PlayAll on a list of videos from a folder. They get added to the playlist, but do not disturb the current video playing. - Harshit --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review51736 --- On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 2, 2014, 10:53 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
Multiple additions should have happened. Okay i'll look into it. Thanks for informing! Kudos for correcting the clock! :) Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Fri, Feb 28, 2014 at 12:48 AM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi Harshit, Thanks for the guidance while going through this i observed two more thing that is after creating playlist if you browse music and click on '+' sign on a thumbnail of a song multiple times it is adding same song multiple time in playlist. i tried to figure it out in source code but no luck. And the clock in footer shows 0:00AM in mid-night instead of 12:00AM that i figured out and solved. --- Thanks Regards Maulik Kotadia On Thu, Feb 27, 2014 at 11:57 PM, Harshit Agarwal see.hars...@gmail.comwrote: Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.com wrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Thanks Regards *Maulik Kotadia * Mail to : maulikkota...@gmail.com Conatct : +91-972-768-6244 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
*Should not Apologies. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Fri, Feb 28, 2014 at 1:17 AM, Harshit Agarwal see.hars...@gmail.comwrote: Multiple additions should have happened. Okay i'll look into it. Thanks for informing! Kudos for correcting the clock! :) Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Fri, Feb 28, 2014 at 12:48 AM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi Harshit, Thanks for the guidance while going through this i observed two more thing that is after creating playlist if you browse music and click on '+' sign on a thumbnail of a song multiple times it is adding same song multiple time in playlist. i tried to figure it out in source code but no luck. And the clock in footer shows 0:00AM in mid-night instead of 12:00AM that i figured out and solved. --- Thanks Regards Maulik Kotadia On Thu, Feb 27, 2014 at 11:57 PM, Harshit Agarwal see.hars...@gmail.comwrote: Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.com wrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Thanks Regards *Maulik Kotadia * Mail to : maulikkota...@gmail.com Conatct : +91-972-768-6244 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/ --- (Updated Feb. 27, 2014, 4:52 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Through this patch, the user can go to the previous window through the backspace key also. The issue with the focus on the Search Bar has been solved. The backspace option works only when the search bar is not in focus. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116063/diff/ Testing --- It has been tested. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.
No I do not posses a KDE Developer account. Would you please commit the changes? Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 11:09 PM, Sinny Kumari ksi...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116032/ Ship it! Nice work and good start Harshit! If you don't have KDE developer account, I will commit changes on behalf of you :) - Sinny Kumari On February 24th, 2014, 10:29 p.m. UTC, Harshit Agarwal wrote: Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. By Harshit Agarwal. *Updated Feb. 24, 2014, 10:29 p.m.* *Repository: * plasma-mediacenter Description The media window was stopping on the last frame of the video whenever a video was played from the local drive. Ideally it should go back to the last video listing window at the completion of the video-play. This has been implemented now. Testing It has been tested on multiple machines, and through commandline also. Diffs - shells/newshell/package/contents/ui/mediacenter.qml (b6cb87c) View Diff https://git.reviewboard.kde.org/r/116032/diff/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Through this patch, the user can go to the previous window through the backspace key also. The issue with the focus on the Search Bar has been solved. The backspace option works only when the search bar is not in focus. Diffs - shells/newshell/package/contents/ui/0001-Patch-for-reverting-the-window-back-to-the-original-.patch f7b0a45 shells/newshell/package/contents/ui/0002-Implementation-of-going-back-to-the-previous-window-.patch e0d7283 Diff: https://git.reviewboard.kde.org/r/116063/diff/ Testing --- It has been tested. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116063/ --- (Updated Feb. 26, 2014, 7:45 a.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Through this patch, the user can go to the previous window through the backspace key also. The issue with the focus on the Search Bar has been solved. The backspace option works only when the search bar is not in focus. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116063/diff/ Testing --- It has been tested. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116032/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The media window was stopping on the last frame of the video whenever a video was played from the local drive. Ideally it should go back to the last video listing window at the completion of the video-play. This has been implemented now. Diffs - shells/newshell/package/contents/ui/mediacenter.qml b6cb87c Diff: https://git.reviewboard.kde.org/r/116032/diff/ Testing --- Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116032/ --- (Updated Feb. 24, 2014, 10:29 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The media window was stopping on the last frame of the video whenever a video was played from the local drive. Ideally it should go back to the last video listing window at the completion of the video-play. This has been implemented now. Diffs - shells/newshell/package/contents/ui/mediacenter.qml b6cb87c Diff: https://git.reviewboard.kde.org/r/116032/diff/ Testing (updated) --- It has been tested on multiple machines, and through commandline also. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Ideas Critical to PMC
This is not exactly a critical idea, but I would like the opinion of people working in this project before deciding upon it's implementation. Does the Plasma Media Center needs to have changing backgrounds? We can implement it as an option (user-select) in the settings menu. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav...@gmail.comwrote: Hello all, I was unfortunate not to be there with you all for the conf.kde.in, which as I've been hearing was a huge success. I feel really gutted about the same. I'd have so dearly loved to have attended a few workshops on programming with Qt and KDE API's(if there were any). But another important thing that was mentioned to me was that during the conf.kde.in the ideas critical to PMC would be mentioned. I hope that there has been some resolution on the same. I'm starting this thread, hoping to hear some of the ideas that you may have. It'd be great if someone could spread some light on the current scenario on regarding the same. Maybe the next critical Idea stems from this thread :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)
Apologies. I wasn't aware of the thread hacking act. My rationale behind changing the background is to enable the user to customize the Media Center to his/her own will. If they see something which is customized as their own, they would automatically spend more time on it, thus using and depending upon it's features more. A better alternative for achieving the same goal is most welcome! Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 10:48 AM, Shantanu Tushar Jha shant...@kde.orgwrote: Hi Harshit, First of all, just a note, whenever you have a new thing to discuss, it is a bad idea to reply to an existing thread which is not directly related (this is popularly known as hacking others' threads :P) To the topic, I personally don't think it is a good idea to let the user change the background of the media center. The rationale behind this is that the background is part of our UI so changing it can lead to visual inconsistency. I'll love to hear from others' views on this, especially our Usability folks. Cheers, On Tue, Feb 25, 2014 at 4:21 AM, Harshit Agarwal see.hars...@gmail.comwrote: This is not exactly a critical idea, but I would like the opinion of people working in this project before deciding upon it's implementation. Does the Plasma Media Center needs to have changing backgrounds? We can implement it as an option (user-select) in the settings menu. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav...@gmail.com wrote: Hello all, I was unfortunate not to be there with you all for the conf.kde.in, which as I've been hearing was a huge success. I feel really gutted about the same. I'd have so dearly loved to have attended a few workshops on programming with Qt and KDE API's(if there were any). But another important thing that was mentioned to me was that during the conf.kde.in the ideas critical to PMC would be mentioned. I hope that there has been some resolution on the same. I'm starting this thread, hoping to hear some of the ideas that you may have. It'd be great if someone could spread some light on the current scenario on regarding the same. Maybe the next critical Idea stems from this thread :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
