[Differential] [Commented On] D3753: Fix comparing pa_cvolume objects
shumski added a comment. I can confirm the bug is fixed with this. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3753 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, davidedmundson Cc: shumski, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Changed Subscribers] D3222: Correctly set i18n suffix in mousemark spinbox.
shumski added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > KIO > +TextWidgets > NewStuff > Note, "new" dependency was already linked implicitly in other kwin, but we > need to add it for this KCM. For completeness sake, ktextwidgets devel files where not present in buildroot, before this patch, when building kwin. Of KF5, only kparts, khtml and kdelibs4support are publicly pulling in ktextwidgets. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3222 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, graesslin Cc: shumski, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128763/#review99643 --- src/declarativeimports/core/windowthumbnail.cpp (line 231) <https://git.reviewboard.kde.org/r/128763/#comment67000> This is added in Qt 5.6, but: set (REQUIRED_QT_VERSION "5.3.0") which is also wrong. - Hrvoje Senjan On Sept. 3, 2016, 10:33 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128763/ > --- > > (Updated Sept. 3, 2016, 10:33 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > WindowThumbnail did some open GL operations, discarding old textures, in the > GUI thread. Whislt it's not going to cause a threading issue (as > updatePaintNode always ran when the main thread was blocked) we're not meant > to mix threads with openGL contexts. > > It also seems to have a GL leak on nvidia, which was previously masked > by the double delete fixed in https://git.reviewboard.kde.org/r/126131/diff/2/ > It seems only one worked, and in the applied version we went with the wrong > one. > > This patch makes use of QQuickItem::releaseResources to delete the GL > textures on window change and destructor; it's then removed from > stopRedirecting so that start/stop redirecting handles xcb on the GUI thread > and updatePaintNode/discardPixmap is the GL stuff on the render thread. > > See http://doc.qt.io/qt-5/qquickitem.html#graphics-resource-handling > > REVIEW: > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.h > 7276f95de16e71006618f3282d8eaf419a199d1d > src/declarativeimports/core/windowthumbnail.cpp > d106994315099ab6e6f948c31a606d5309ae03e2 > > Diff: https://git.reviewboard.kde.org/r/128763/diff/ > > > Testing > --- > > Using nvidia with proprietory drivers (which puts me > QSG_RENDER_LOOP=threaded) mouse over the panel a lot. VRAM didn't increase. > Previews still appear. > "Used Dedicated Memory:" in nvidia-settings remained roughly static, rather > than constantly increasing. > > > Thanks, > > David Edmundson > >
[Differential] [Changed Subscribers] D2372: Make powerdevil normal executable instead of kded module
shumski added inline comments.
INLINE COMMENTS
> CMakeLists.txt:135
>
> -install(TARGETS kded_powerdevil DESTINATION ${PLUGIN_INSTALL_DIR}/kf5/kded)
> +install(TARGETS powerdevil DESTINATION ${CMAKE_INSTALL_FULL_LIBEXECDIR_KF5})
> +install(FILES ${CMAKE_CURRENT_BINARY_DIR}/powerdevil.desktop
PowerDevil isn't a Framework, so this var is wrong.
> powerdevil.desktop.cmake:1
> [Desktop Entry]
> Type=Service
Maybe autostart for this should be limited to Plasma only?
REPOSITORY
rPOWERDEVIL Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D2372
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bshah, #plasma, broulik, graesslin
Cc: shumski, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
[Differential] [Updated] D1722: Import next-gen libtaskmanager.
shumski added a comment. Plasma addons don't build against this change: /home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.6.90git~20160524T120553~https://phabricator.kde.org/rKDEPLASMAADDONS7d85a2cf3c6c968a41ab30425c62b2f058408a3e/applets/activitypager/plugin/activitypager.cpp:53:30: fatal error: taskmanager/task.h: No such file or directory REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, davidedmundson, lbeltrame, graesslin Cc: shumski, lbeltrame, graesslin, broulik, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 17, 2016, 8:19 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and David Faure. Changes --- Submitted with commit 27ebf75bd44101976d8392eec4ff4d20f495fb69 by Hrvoje Senjan to branch Plasma/5.6. Repository: plasma-desktop Description --- Address David's issues in previous rr's regarding the code. Diffs - kcms/componentchooser/componentchooserbrowser.cpp 5795c2b kcms/componentchooser/componentchooserfilemanager.cpp a04cced kcms/componentchooser/componentchooserterminal.cpp 36f1296 kcms/input/mouse.cpp f7d030f kcms/migrationlib/kdelibs4config.h bb2dca2 Diff: https://git.reviewboard.kde.org/r/127918/diff/ Testing --- Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 17, 2016, 7:40 p.m.) Review request for Plasma and David Faure. Changes --- Fix issues Repository: plasma-desktop Description --- Address David's issues in previous rr's regarding the code. Diffs (updated) - kcms/componentchooser/componentchooserbrowser.cpp 5795c2b kcms/componentchooser/componentchooserfilemanager.cpp a04cced kcms/componentchooser/componentchooserterminal.cpp 36f1296 kcms/input/mouse.cpp f7d030f kcms/migrationlib/kdelibs4config.h bb2dca2 Diff: https://git.reviewboard.kde.org/r/127918/diff/ Testing --- Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 17, 2016, 6:42 p.m.) Review request for Plasma and David Faure. Repository: plasma-desktop Description --- Address David's issues in previous rr's regarding the code. Diffs (updated) - kcms/componentchooser/componentchooserbrowser.cpp 5795c2b kcms/componentchooser/componentchooserfilemanager.cpp a04cced kcms/componentchooser/componentchooserterminal.cpp 36f1296 kcms/input/mouse.cpp f7d030f kcms/migrationlib/kdelibs4config.h bb2dca2 Diff: https://git.reviewboard.kde.org/r/127918/diff/ Testing --- Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- (Updated May 16, 2016, 10:52 p.m.) Review request for Plasma and David Faure. Changes --- Update code touched by me in previous commits wrt SimpleConfig. Mouse.cpp is now ugly, but unfortunately necessary to avoid the kconfig bug. Repository: plasma-desktop Description --- Address David's issues in previous rr's regarding the code. Diffs (updated) - kcms/componentchooser/componentchooserbrowser.cpp 5795c2b kcms/componentchooser/componentchooserterminal.cpp 36f1296 kcms/input/mouse.cpp f7d030f kcms/migrationlib/kdelibs4config.h bb2dca2 Diff: https://git.reviewboard.kde.org/r/127918/diff/ Testing --- Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 127918: Cleanup and fixup KConfig handling for componentchooser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- Review request for Plasma and David Faure. Repository: plasma-desktop Description --- Address David's issues in previous rr's regarding the code. Diffs - kcms/componentchooser/componentchooserbrowser.cpp 5795c2b kcms/migrationlib/kdelibs4config.h bb2dca2 Diff: https://git.reviewboard.kde.org/r/127918/diff/ Testing --- Default browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123281: Avoid triggering bug 340691
> On May 13, 2016, 8:43 p.m., David Faure wrote: > > kcms/migrationlib/kdelibs4config.h, line 28 > > <https://git.reviewboard.kde.org/r/123281/diff/1/?file=360341#file360341line28> > > > > I just noticed a compiler warning in this method: the "mode" argument > > isn't used. This part of the commit can't possibly have changed anything, > > then. > > Either it should actually be used, or it should be removed. Otherwise > > it's just confusing, as this patch shows You're right. Furthermore, the bug is about the source, not the target. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/#review95454 ------- On April 7, 2015, 1:46 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123281/ > --- > > (Updated April 7, 2015, 1:46 p.m.) > > > Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. > > > Repository: plasma-desktop > > > Description > --- > > With Kdelibs4Migration we know exactly which file to modify, so it is both > correct to use KConfig::SimpleConfig, and should help avoiding triggering the > mentioned bug. > As similar fix was applied for bug 343583. > > > Diffs > - > > kcms/icons/icons.cpp 16a3141 > kcms/migrationlib/kdelibs4config.h 0c1b7fe > > Diff: https://git.reviewboard.kde.org/r/123281/diff/ > > > Testing > --- > > Changed the default browser in systemsettings5, the config got written in > both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)
> On May 13, 2016, 8:59 p.m., David Faure wrote: > > kcms/componentchooser/componentchooserbrowser.cpp, line 86 > > <https://git.reviewboard.kde.org/r/123288/diff/1/?file=360453#file360453line86> > > > > This change makes it impossible for me to choose another browser than > > firefox on OpenSuSE, where /etc/xdg/kdeglobals says > > BrowserApplication=firefox. > > > > (comment added in https://bugs.kde.org/show_bug.cgi?id=340691#c9) > > > > SimpleConfig means that upon saving, kconfig doesn't know it has to > > write > > BrowserApplication[$d] > > It does when I remove SimpleConfig, which fixes the bug for me. > > > > This seems pretty logical to me, so this fix is clearly wrong. If > > something has to be fixed around some "copyTo" that the bug mentions, then > > it has to be fixed differently. Indeed. Though once you remove the SimpleConfig, the bug will be exposed again for kde4 kdeglobals. I.e. will point to both KF5 kdeglobals. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/#review95455 --- On April 7, 2015, 8:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123288/ > --- > > (Updated April 7, 2015, 8:50 p.m.) > > > Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. > > > Repository: plasma-desktop > > > Description > --- > > We only need to sync the changes to kde4 kdeglobals once users changes the > defaults, hence only users KF5 kdeglobals need to be evaluated. > This workarounds (though the change is IMO correct anyway) the kconfig bug, > as we can otherwise pass both local and systemwide kdeglobals into copyTo > method. > > > Diffs > - > > kcms/componentchooser/componentchooserbrowser.cpp f2b81ef > kcms/componentchooser/componentchooserterminal.cpp be52334 > kcms/input/mouse.cpp 69759bd > > Diff: https://git.reviewboard.kde.org/r/123288/diff/ > > > Testing > --- > > W/o the patch i had both > BrowserApplication[$e]=chromium-browser.desktop (local adjustement) > BrowserApplication=firefox.desktop (distro branding) > > in ~/.kde4/share/config/kdeglobals > now i have only locally adjusted value > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1237: Fix compilation with gcc 4.8
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND34d54f760d2c: Fix compilation with gcc 4.8 (authored by shumski). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1237?vs=2980=3005 REVISION DETAIL https://phabricator.kde.org/D1237 AFFECTED FILES src/server/subcompositor_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shumski, graesslin Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 2 lines] D1237: Fix compilation with gcc 4.8
shumski created this revision. shumski added a reviewer: graesslin. shumski set the repository for this revision to rKWAYLAND KWayland. shumski added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1237 AFFECTED FILES src/server/subcompositor_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shumski, graesslin Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127346: Infrastructure for Plasmoid integration testing
> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22> > > > > PlasmaQuick doesn't have any headers installed, so the build fails. > > Aleix Pol Gonzalez wrote: > Are you sure? https://paste.kde.org/p7zxnmpr2 Well, with KF5.20.0 they aren't installed here (cmake 3.4.3). I see that somehow with master (and cmake 3.3.1) they are. Anyhow with master, the error (plasma-framework bug) is ``` [ 191s] In file included from /usr/include/KF5/PlasmaQuick/AppletQuickItem:1:0, [ 191s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.5.90git~20160316T165610~e7f09ba/shell/coronatesthelper.cpp:22: [ 191s] /usr/include/KF5/plasmaquick/appletquickitem.h:31:32: fatal error: plasmaquick_export.h: No such file or directory [ 191s] compilation terminated. ``` - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93604 --- On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127346/ > --- > > (Updated March 16, 2016, 12:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Makes it possible to test how/if a plasmoid behaves correctly on the most > similar environment possible to what the user would find on a production > system. > > * Loads a plasmoid on a panel and the desktop. > * Lets it test his own stuff > * Notifies, when done, if failed. > > There's still more to look into: > > * what objects need to be passed, besides the `Plasma::AppletQuickItem`. > * good things to test > * how to test other shells than the desktop shell > > Nevertheless, it looks to me that it's a step forward. Comments welcome. > > > Diffs > - > > applets/analog-clock/contents/tests/test.qml PRE-CREATION > shell/CMakeLists.txt e553133 > shell/main.cpp d6e3640 > shell/shellcorona.cpp 54667da > shell/shellmanager.h 17acbc6 > shell/shellmanager.cpp 3c3638f > shell/testcorona.h PRE-CREATION > shell/testcorona.cpp PRE-CREATION > shell/tests/CMakeLists.txt PRE-CREATION > shell/tests/testLayout.js.in PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127346/diff/ > > > Testing > --- > > > Thanks, > > Aleix Pol Gonzalez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127346: Infrastructure for Plasmoid integration testing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93604 --- shell/testcorona.cpp (line 22) <https://git.reviewboard.kde.org/r/127346/#comment63836> PlasmaQuick doesn't have any headers installed, so the build fails. - Hrvoje Senjan On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127346/ > --- > > (Updated March 16, 2016, 12:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Makes it possible to test how/if a plasmoid behaves correctly on the most > similar environment possible to what the user would find on a production > system. > > * Loads a plasmoid on a panel and the desktop. > * Lets it test his own stuff > * Notifies, when done, if failed. > > There's still more to look into: > > * what objects need to be passed, besides the `Plasma::AppletQuickItem`. > * good things to test > * how to test other shells than the desktop shell > > Nevertheless, it looks to me that it's a step forward. Comments welcome. > > > Diffs > - > > applets/analog-clock/contents/tests/test.qml PRE-CREATION > shell/CMakeLists.txt e553133 > shell/main.cpp d6e3640 > shell/shellcorona.cpp 54667da > shell/shellmanager.h 17acbc6 > shell/shellmanager.cpp 3c3638f > shell/testcorona.h PRE-CREATION > shell/testcorona.cpp PRE-CREATION > shell/tests/CMakeLists.txt PRE-CREATION > shell/tests/testLayout.js.in PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127346/diff/ > > > Testing > --- > > > Thanks, > > Aleix Pol Gonzalez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127346: Infrastructure for Plasmoid integration testing
> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22> > > > > PlasmaQuick doesn't have any headers installed, so the build fails. > > Aleix Pol Gonzalez wrote: > Are you sure? https://paste.kde.org/p7zxnmpr2 > > Hrvoje Senjan wrote: > Well, with KF5.20.0 they aren't installed here (cmake 3.4.3). > I see that somehow with master (and cmake 3.3.1) they are. > Anyhow with master, the error (plasma-framework bug) is > ``` > [ 191s] In file included from > /usr/include/KF5/PlasmaQuick/AppletQuickItem:1:0, > [ 191s] from > /home/abuild/rpmbuild/BUILD/plasma-workspace-5.5.90git~20160316T165610~e7f09ba/shell/coronatesthelper.cpp:22: > [ 191s] /usr/include/KF5/plasmaquick/appletquickitem.h:31:32: fatal > error: plasmaquick_export.h: No such file or directory > [ 191s] compilation terminated. > ``` > > Aleix Pol Gonzalez wrote: > What do you mean? that some cmake versions install some headers and some > others don't? It looks to me that there might be an issue with your > installation... Diff between plasma-framework 5.20.0 and master (for src/plasmaquick/CMakeLists.txt) http://paste.opensuse.org/75789267 So it's not strange, just that i don't see how this is not in tarball - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93604 --- On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127346/ > --- > > (Updated March 16, 2016, 12:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Makes it possible to test how/if a plasmoid behaves correctly on the most > similar environment possible to what the user would find on a production > system. > > * Loads a plasmoid on a panel and the desktop. > * Lets it test his own stuff > * Notifies, when done, if failed. > > There's still more to look into: > > * what objects need to be passed, besides the `Plasma::AppletQuickItem`. > * good things to test > * how to test other shells than the desktop shell > > Nevertheless, it looks to me that it's a step forward. Comments welcome. > > > Diffs > - > > applets/analog-clock/contents/tests/test.qml PRE-CREATION > shell/CMakeLists.txt e553133 > shell/main.cpp d6e3640 > shell/shellcorona.cpp 54667da > shell/shellmanager.h 17acbc6 > shell/shellmanager.cpp 3c3638f > shell/testcorona.h PRE-CREATION > shell/testcorona.cpp PRE-CREATION > shell/tests/CMakeLists.txt PRE-CREATION > shell/tests/testLayout.js.in PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127346/diff/ > > > Testing > --- > > > Thanks, > > Aleix Pol Gonzalez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/ --- (Updated March 9, 2016, 5:21 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Harald Sitter. Changes --- Submitted with commit 73b5509bd45719e8cbbee95142d25d373172bfe1 by Hrvoje Senjan to branch Plasma/5.6. Repository: breeze-plymouth Description --- KDECompilerSettings aren't included so this wasn't spotted earlier, but we pass the flag anyway in openSUSE's %cmake_kf5 macro. Diffs - CMakeLists.txt 3a4cd73 breeze-text/CMakeLists.txt 17501cb Diff: https://git.reviewboard.kde.org/r/127296/diff/ Testing --- Now builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop > file which is reverse domain name dot binaryname. How the desktop file which > launched the application is called, doesn't really matter. A misunderstanding ;-) I'm merely talking about people losing their favourite after upgrading to 5.6. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/#review93306 --- On March 8, 2016, 4:18 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127308/ > --- > > (Updated March 8, 2016, 4:18 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > The desktop file name should include the reverse domain name and must > much the binary. > > > Diffs > - > > app/CMakeLists.txt 3fa8dbb52b4cd8fd553c67a768fcd68c51cb83e4 > app/systemsettings.desktop > > Diff: https://git.reviewboard.kde.org/r/127308/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/#review93306 --- Do we want a kconf_update script with that for all hte people that have systemsettings.desktop as favourite in launchers? - Hrvoje Senjan On March 8, 2016, 4:18 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127308/ > --- > > (Updated March 8, 2016, 4:18 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > The desktop file name should include the reverse domain name and must > much the binary. > > > Diffs > - > > app/CMakeLists.txt 3fa8dbb52b4cd8fd553c67a768fcd68c51cb83e4 > app/systemsettings.desktop > > Diff: https://git.reviewboard.kde.org/r/127308/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/ --- Review request for Plasma and Harald Sitter. Repository: breeze-plymouth Description --- KDECompilerSettings aren't included so this wasn't spotted earlier, but we pass the flag anyway in openSUSE's %cmake_kf5 macro. Diffs - CMakeLists.txt 3a4cd73 breeze-text/CMakeLists.txt 17501cb Diff: https://git.reviewboard.kde.org/r/127296/diff/ Testing --- Now builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 127086: Raise the required CMake version to 3.4.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/#review92924 --- Isn't raising the version a bit of a overkill for a module that only indicates RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4. - Hrvoje Senjan On Feb. 16, 2016, 12:13 p.m., Elias Probst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127086/ > --- > > (Updated Feb. 16, 2016, 12:13 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Since fea67bd2 plasma-workspace requires CMake >= 3.4.0 as > pkg_get_variable used in cmake/FindIsoCodes.cmake isn't available in previous > releases. > > > Diffs > - > > CMakeLists.txt c2debaa3aeb24b4da9918642b8931002c205d228 > > Diff: https://git.reviewboard.kde.org/r/127086/diff/ > > > Testing > --- > > Updated from CMake 3.3.1 to 3.4.3 and cmake/FindIsoCodes.cmake succeeded. > > > Thanks, > > Elias Probst > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg
> On Jan. 20, 2016, 11:26 p.m., Hrvoje Senjan wrote: > > so i lost kmail icon in tray after this it seems > > Marco Martin wrote: > do you have an empty space or no icon at all? empty space. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/#review91390 --- On Jan. 19, 2016, 10:17 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126792/ > --- > > (Updated Jan. 19, 2016, 10:17 a.m.) > > > Review request for Plasma. > > > Bugs: 353358 > http://bugs.kde.org/show_bug.cgi?id=353358 > > > Repository: plasma-framework > > > Description > --- > > When showing QIcons in IconItem, it would ignore stylesheet colors. > This tries to load QIcons created with QIcon::fromTheme as svg, by using the > icon name returned from QIcon::name. > > > Diffs > - > > src/declarativeimports/core/iconitem.cpp 9129aa1 > > Diff: https://git.reviewboard.kde.org/r/126792/diff/ > > > Testing > --- > > Set app icons to breeze light, desktop theme as breeze dark. Icons in desktop > toolbox now follows the color scheme. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/#review91390 --- so i lost kmail icon in tray after this it seems - Hrvoje Senjan On Jan. 19, 2016, 10:17 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126792/ > --- > > (Updated Jan. 19, 2016, 10:17 a.m.) > > > Review request for Plasma. > > > Bugs: 353358 > http://bugs.kde.org/show_bug.cgi?id=353358 > > > Repository: plasma-framework > > > Description > --- > > When showing QIcons in IconItem, it would ignore stylesheet colors. > This tries to load QIcons created with QIcon::fromTheme as svg, by using the > icon name returned from QIcon::name. > > > Diffs > - > > src/declarativeimports/core/iconitem.cpp 9129aa1 > > Diff: https://git.reviewboard.kde.org/r/126792/diff/ > > > Testing > --- > > Set app icons to breeze light, desktop theme as breeze dark. Icons in desktop > toolbox now follows the color scheme. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126381: kwayland backend for libkscreen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review90076
---
backends/CMakeLists.txt (line 3)
<https://git.reviewboard.kde.org/r/126381/#comment61717>
Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be
marked as required in top CMakeLists.tyt
- Hrvoje Senjan
On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
>
> (Updated Dec. 22, 2015, 12:46 a.m.)
>
>
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
>
>
> Repository: libkscreen
>
>
> Description
> ---
>
> This adds a kwayland backend to libkscreen.
>
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
>
> Enlisting outputs
>
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
>
> Configuring outputs
>
> The backend asks the global OutputManagement interface for an
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
>
> For this to work, the compositor should support the Wayland
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and
> OuputConfiguration.
>
> General working
>
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
>
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
>
>
> Diffs
> -
>
> CMakeLists.txt efac5ce
> autotests/CMakeLists.txt 07b7bbc
> autotests/configs/default.json 3ac3e19
> autotests/testconfigserializer.cpp 1af3069
> autotests/testkwaylandbackend.cpp PRE-CREATION
> autotests/testkwaylandconfig.cpp PRE-CREATION
> backends/CMakeLists.txt ff5d751
> backends/kwayland/CMakeLists.txt PRE-CREATION
> backends/kwayland/README.md PRE-CREATION
> backends/kwayland/waylandbackend.h PRE-CREATION
> backends/kwayland/waylandbackend.cpp PRE-CREATION
> backends/kwayland/waylandconfig.h PRE-CREATION
> backends/kwayland/waylandconfig.cpp PRE-CREATION
> backends/kwayland/waylandoutput.h PRE-CREATION
> backends/kwayland/waylandoutput.cpp PRE-CREATION
> backends/kwayland/waylandscreen.h PRE-CREATION
> backends/kwayland/waylandscreen.cpp PRE-CREATION
> src/backendmanager.cpp 89ae31e
> src/config.cpp e8b8a8f
> src/screen.h 4cd1e82
> tests/CMakeLists.txt d5e41d5
> tests/kwayland/CMakeLists.txt PRE-CREATION
> tests/kwayland/main.cpp PRE-CREATION
> tests/kwayland/waylandconfigreader.h PRE-CREATION
> tests/kwayland/waylandconfigreader.cpp PRE-CREATION
> tests/kwayland/waylandtestserver.h PRE-CREATION
> tests/kwayland/waylandtestserver.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
>
>
> Testing
> ---
>
> The patch contains a test server, which is used for the autotests.
>
> The test server uses KWayland's server classes and is set up from the json
> config data we use for the other tests. That means that the backends runs
> against a real server to test everything.
>
> I also tested the kscreen UI, which also works as expected.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89369 --- i had the similar problem after commit f35e514 (only empty panel would be shown). this patch fixes the problem here. - Hrvoje Senjan On Dec. 11, 2015, 7:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126320/ > --- > > (Updated Dec. 11, 2015, 7:48 p.m.) > > > Review request for KDE Frameworks, Plasma and Alex Richardson. > > > Repository: plasma-framework > > > Description > --- > > plasma-scriptengine.desktop defines the property "X-Plasma-ComponentTypes" > as Type=QStringList. When reading it using KPluginMetaData::value(..) it > expects a QString back. This used to work but regressed in kcoreaddons in > commit cfd18cf09b559a050fd6a2680ad4e71eeb950383. Now I'm not sure if calling > KPluginMetaData::value(..) on a property that is known to be a stringlist > should actually return a QString (Alex?), but making it read the property > as a stringlist works and is correct and also fixes Plasma startup for me. > > > Diffs > - > > src/plasma/scripting/scriptengine.cpp 1b132de > > Diff: https://git.reviewboard.kde.org/r/126320/diff/ > > > Testing > --- > > Plasma would get stuck on startup, now I can run Plasma again. > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"
> On Dec. 8, 2015, 7:51 a.m., Martin Gräßlin wrote: > > -2 for another reason: the display system should not be a user facing part. > > That's a technical detail which will go away in a year or two. Do you want > > to rename it back to Plasma then? If at all we should change the X11 > > session to have the name adjusted. > > David Edmundson wrote: > If you think that, why provide the .desktop file at all when it's not > ready? > > Sebastian Kügler wrote: > I think as long as Wayland is the experimental option, it should say so. > The specialization makes it easier to recognize the stable/X11 session. > > David Edmundson wrote: > What I don't get is why we're installing this file by default at all. > We *know* that without a kdeinit patch everything freezes. So we've just > added an option that we *know* will only give a black screen. That's both > pointless and setting a bad impression. > > Martin Gräßlin wrote: > > We know that without a kdeinit patch everything freezes. > > To be fair I didn't know that it would freeze when the session file got > added. I thought it was related to another KDE session running and not just > to sddm having started an X server. > > > That's both pointless and setting a bad impression. > > We are not installing the file. Distros are. I don't expect any sane > distro to provide the wayland session installed by default. It should be > possible to install it, though and this includes a patched kdeinit. This is > something AFAIK Arch already did before we provided the session file. It is installed by CMake w/o any patches and is said to be provided in the release announcement, so i guess it is safe to say that it is installed by default. If upstream would prefer the session is not provided, best is 1) don't install it at all via CMake, 2) notify kde-distro-packagers that the session should rather not be provided. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126275/#review89235 --- On Dec. 8, 2015, 3:09 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126275/ > --- > > (Updated Dec. 8, 2015, 3:09 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > The commit/review says it's displayed as "Plasma (Wayland)" > but the name is just "Plasma", making it confusing in login > manager. > > > Diffs > - > > plasmawayland.desktop.cmake c5d5757 > > Diff: https://git.reviewboard.kde.org/r/126275/diff/ > > > Testing > --- > > Sddm now clearly shows which "Plasma" is Waylandplasma. > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126248: change icons in breeze plasma theme
> On Dec. 5, 2015, 5:56 p.m., Hrvoje Senjan wrote: > > Andreas, battery is almost invisible with breeze dark -> > > http://i.imgur.com/aY1igIu.jpg > > andreas kainz wrote: > you have right the problem is also the old one from master doesn't work > in breeze dark. maybe marco can have a look why the color change don't work. > > Andreas ka wrote: > should work now > > http://commits.kde.org/plasma-framework/42952018ad26aa5b66cda74e7a2ea69a80187ffa sorry, still the same. also for the amarok icon... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126248/#review89151 --- On Dec. 6, 2015, 1:01 p.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126248/ > --- > > (Updated Dec. 6, 2015, 1:01 p.m.) > > > Review request for Plasma and Uri Herrera. > > > Repository: plasma-framework > > > Description > --- > > - amarok icon now works > - add missint nm icons (https://bugs.kde.org/show_bug.cgi?id=355412) > - change the battery icon to be more full than now > https://bugs.kde.org/show_bug.cgi?id=355864 > - system icons are now available in monochrome for 22px size > (https://bugs.kde.org/show_bug.cgi?id=355664) > > > Diffs > - > > src/desktoptheme/breeze/icons/amarok.svgz 1cafc36 > src/desktoptheme/breeze/icons/battery.svgz 0b90ff2 > src/desktoptheme/breeze/icons/network.svgz b7524f0 > src/desktoptheme/breeze/icons/system.svgz 8528bfe > > Diff: https://git.reviewboard.kde.org/r/126248/diff/ > > > Testing > --- > > use the plasma theme monochrome system icons look good for panel applet, user > switch screen, > > Please check the battery icons cause sometime they are looking to bold. it's > my first plasma theme change. > > > Thanks, > > andreas kainz > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126248: change icons in breeze plasma theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126248/#review89151 --- Andreas, battery is almost invisible with breeze dark -> http://i.imgur.com/aY1igIu.jpg - Hrvoje Senjan On Dec. 5, 2015, 8:26 a.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126248/ > --- > > (Updated Dec. 5, 2015, 8:26 a.m.) > > > Review request for Plasma and Uri Herrera. > > > Repository: plasma-framework > > > Description > --- > > - amarok icon now works > - add missint nm icons (https://bugs.kde.org/show_bug.cgi?id=355412) > - change the battery icon to be more full than now > https://bugs.kde.org/show_bug.cgi?id=355864 > - system icons are now available in monochrome for 22px size > (https://bugs.kde.org/show_bug.cgi?id=355664) > > > Diffs > - > > src/desktoptheme/breeze/icons/amarok.svgz 1cafc36 > src/desktoptheme/breeze/icons/battery.svgz 0b90ff2 > src/desktoptheme/breeze/icons/network.svgz b7524f0 > src/desktoptheme/breeze/icons/system.svgz 8528bfe > > Diff: https://git.reviewboard.kde.org/r/126248/diff/ > > > Testing > --- > > use the plasma theme monochrome system icons look good for panel applet, user > switch screen, > > Please check the battery icons cause sometime they are looking to bold. it's > my first plasma theme change. > > > Thanks, > > andreas kainz > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126250: knetattach: Changing host port does not enable connect button
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126250/#review89150 --- Andrea, did this build for you? - Hrvoje Senjan On Dec. 5, 2015, 4:55 p.m., Andrea Scarpino wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126250/ > --- > > (Updated Dec. 5, 2015, 4:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > After a connection failed, changing host port does not enable the connect > button. > > > Fix this by listening on valueChanged > > > Diffs > - > > knetattach/knetattach.cpp 9a47d8fdf714115c790afabecb641f475fd16629 > > Diff: https://git.reviewboard.kde.org/r/126250/diff/ > > > Testing > --- > > > Thanks, > > Andrea Scarpino > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126234: Fix build with Qt 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126234/#review89132 --- Jan, Martin, i guess this can also go to 5.5 branch? - Hrvoje Senjan On Dec. 4, 2015, 10:23 a.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126234/ > --- > > (Updated Dec. 4, 2015, 10:23 a.m.) > > > Review request for Plasma, Martin Gräßlin and Hrvoje Senjan. > > > Repository: kwin > > > Description > --- > > Fix build with Qt 5.6 > > A recent change [1] led to Qt5PlatformSupport.pc not being installed > anymore. Pkg-config was only used for finding the paths, and the actual > include flags and library names were hardcoded in KWin's > FindQt5PlatformSupport.cmake anyway, so let's just focus on finding > Qt5Gui, the module which provides this Qt5PlatformSupport library, and > work from there. > > Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream > Gerrit change. > > [1] https://codereview.qt-project.org/140954/ > > REVIEW: 126234 > > > Diffs > - > > cmake/modules/FindQt5PlatformSupport.cmake > 90a8438ac80e48b09463ba5f34a72b2d7567ea5d > > Diff: https://git.reviewboard.kde.org/r/126234/diff/ > > > Testing > --- > > > Thanks, > > Jan Kundrát > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126234: Fix build with Qt 5.6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126234/#review89090 --- 2nd best solution after not using Qt5PlatformSupport at all :D - Hrvoje Senjan On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126234/ > --- > > (Updated Dec. 3, 2015, 6:37 p.m.) > > > Review request for Plasma, Martin Gräßlin and Hrvoje Senjan. > > > Repository: kwin > > > Description > --- > > Fix build with Qt 5.6 > > A recent change [1] led to Qt5PlatformSupport.pc not being installed > anymore. Pkg-config was only used for finding the paths, and the actual > include flags and library names were hardcoded in KWin's > FindQt5PlatformSupport.cmake anyway, so let's just focus on finding > Qt5Gui, the module which provides this Qt5PlatformSupport library, and > work from there. > > Thanks to Hrvoje Senjan (shumski) for pointing me towards the upstream > Gerrit change. > > [1] https://codereview.qt-project.org/140954/ > > REVIEW: 126234 > > > Diffs > - > > cmake/modules/FindQt5PlatformSupport.cmake > 90a8438ac80e48b09463ba5f34a72b2d7567ea5d > > Diff: https://git.reviewboard.kde.org/r/126234/diff/ > > > Testing > --- > > > Thanks, > > Jan Kundrát > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- >assuming, that is, distros push out the updates together don't assume this ;-) at least send a mail to kde-distro-packagers about the sideeffects if those 3 are pushed asynchronously - Hrvoje Senjan On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 6:06 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125811: detect gtk engine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/#review87948 --- cmake/FindGTKEngine.cmake (line 17) <https://git.reviewboard.kde.org/r/125811/#comment60331> KDE_INSTALL_FULL_LIBDIR rather? - Hrvoje Senjan On Oct. 27, 2015, 10:22 a.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125811/ > --- > > (Updated Oct. 27, 2015, 10:22 a.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: breeze-gtk > > > Description > --- > > first attempt at detecting gtk 2 pixmap engine as runtime dependency > > but it doesn't work if you set cmake path to different from gtk engine > > and I don't know if it works on distros that use /usr/lib64/ rather than > /usr/lib/x86_86-linux-gnu > > > Diffs > - > > CMakeLists.txt 9d7b7a7 > cmake/FindGTKEngine.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125811/diff/ > > > Testing > --- > > works for me unless I install outwith /usr/ > > > Thanks, > > Jonathan Riddell > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87673 --- ksmserver/screenlocker/CMakeLists.txt (line 39) <https://git.reviewboard.kde.org/r/125838/#comment60155> you also didn't set the SOVERSION - Hrvoje Senjan On Oct. 29, 2015, 12:12 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125838/ > --- > > (Updated Oct. 29, 2015, 12:12 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > --- > > To make screenlocker in wayland possible, kwin_wayland will need to link to > libksld. > > (if packagers can look at this patch it would be nice) > > > Diffs > - > > ksmserver/CMakeLists.txt 6398990 > ksmserver/screenlocker/tests/CMakeLists.txt 7f0db74 > ksmserver/screenlocker/ksldapp.h 9058824 > ksmserver/screenlocker/CMakeLists.txt cf93334 > ksmserver/screenlocker/autotests/CMakeLists.txt 7e7acdc > > Diff: https://git.reviewboard.kde.org/r/125838/diff/ > > > Testing > --- > > builds/installs and tests pass > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87575 --- ksmserver/screenlocker/CMakeLists.txt (line 41) <https://git.reviewboard.kde.org/r/125838/#comment60127> if this will be shared lib, please extract private vs. public deps. ksmserver/screenlocker/CMakeLists.txt (line 78) <https://git.reviewboard.kde.org/r/125838/#comment60128> >To make screenlocker in wayland possible, kwin_wayland will need to link to libksld. but here you skip the symlink? - Hrvoje Senjan On Oct. 28, 2015, 12:07 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125838/ > --- > > (Updated Oct. 28, 2015, 12:07 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > --- > > To make screenlocker in wayland possible, kwin_wayland will need to link to > libksld. > > (if packagers can look at this patch it would be nice) > > > Diffs > - > > ksmserver/CMakeLists.txt a0c8852 > ksmserver/screenlocker/CMakeLists.txt 5ded06e > ksmserver/screenlocker/autotests/CMakeLists.txt 7e7acdc > ksmserver/screenlocker/ksldapp.h 9058824 > ksmserver/screenlocker/tests/CMakeLists.txt 7f0db74 > > Diff: https://git.reviewboard.kde.org/r/125838/diff/ > > > Testing > --- > > builds/installs and tests pass > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125706: Install kconf_update script in kdelibs4 directory
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125706/#review87090 --- >because kmix is a kdelibs4 application well, only when it's built that way :D KMIX_KF5_BUILD will enable KF5 codepath/buildsystem. IOW, you need to make sure both cases are covered - Hrvoje Senjan On Oct. 19, 2015, 6:30 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125706/ > --- > > (Updated Oct. 19, 2015, 6:30 p.m.) > > > Review request for Plasma, David Edmundson and Harald Sitter. > > > Repository: plasma-pa > > > Description > --- > > Install kconf_update script in kdelibs4 directory because kmix is a kdelibs4 > application and installing it in kf5 directories won't do anything > > This uses kde4-config. I looked at using KDELibs4 cmake classes from > KDELibs4/KDELibsDependencies.cmake but couldn't work out how to load it in > cmake and it has the wrong values set for its variables anyway. > > > Diffs > - > > data/CMakeLists.txt b652a0f > > Diff: https://git.reviewboard.kde.org/r/125706/diff/ > > > Testing > --- > > Installs to the right place > > > Thanks, > > Jonathan Riddell > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125610/#review86735 --- quick search on lxr.kde.org shows there are more uses of that interface, so changing the name now won't be easy (or recommended IMO) - Hrvoje Senjan On Oct. 12, 2015, 6:53 p.m., Rex Dieter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125610/ > --- > > (Updated Oct. 12, 2015, 6:53 p.m.) > > > Review request for Plasma. > > > Bugs: 351500 > https://bugs.kde.org/show_bug.cgi?id=351500 > > > Repository: plasma-workspace > > > Description > --- > > Exclusively use org.kde.kuiserver5 dbus service so it doesn't conflict with > kde4's org.kde.kuiserver from kde-runtime > > > Diffs > - > > dataengines/applicationjobs/kuiserverengine.cpp 93ef2d6 > kuiserver/CMakeLists.txt 0f7c29e > kuiserver/org.kde.kuiserver.service.in 7a86d07 > kuiserver/org.kde.kuiserver.xml 7d465bc > kuiserver/org.kde.kuiserver5.service.in PRE-CREATION > kuiserver/org.kde.kuiserver5.xml PRE-CREATION > kuiserver/progresslistmodel.h 490a683 > kuiserver/progresslistmodel.cpp fe147f3 > > Diff: https://git.reviewboard.kde.org/r/125610/diff/ > > > Testing > --- > > Applied patch, confirmed kuiserver builds, and plasma still functions as > expected (it runs on plasma session login). Admittedly, I'm not privy to > kuiserver's detailed purpose, so wasn't sure how to test it specifically. > > > Thanks, > > Rex Dieter > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125555: Port KAuth return code error checking in fontinst
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/#review86603
---
kcms/kfontinst/dbus/FontInst.cpp (line 958)
<https://git.reviewboard.kde.org/r/12/#comment59612>
Shouldn't this be if (!j->exec()) { ?
- Hrvoje Senjan
On Oct. 8, 2015, 3:38 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/12/
> ---
>
> (Updated Oct. 8, 2015, 3:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> ---
>
> Someone whilst porting had simply commented it out
> This causes the install dialog to freeze if there's a problem.
>
> CCBUG: 344473
> CCBUG: 300951
> CCBUG: 345234
>
>
> Diffs
> -
>
> kcms/kfontinst/dbus/FontInst.cpp 42413c1a05717f416681ef32317b8914c2ba35ec
>
> Diff: https://git.reviewboard.kde.org/r/12/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> David Edmundson
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125408: kcm_keyboard: Port away from KDELibs4Support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125408/#review85994 --- kcms/keyboard/keyboard_daemon.h (line 24) <https://git.reviewboard.kde.org/r/125408/#comment59350> This still needs KDELibs4Support, whether the include is still needed, haven't checked - Hrvoje Senjan On Sept. 26, 2015, 10:15 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125408/ > --- > > (Updated Sept. 26, 2015, 10:15 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Port away from KDELibs4Support > > > Diffs > - > > kcms/keyboard/CMakeLists.txt abf3cf8 > kcms/keyboard/bindings.h d597907 > kcms/keyboard/bindings.cpp 968721f > kcms/keyboard/kcm_keyboard_widget.cpp c7a3589 > kcms/keyboard/keyboard_daemon.h 4d7587f > kcms/keyboard/keyboard_daemon.cpp f2f757f > > Diff: https://git.reviewboard.kde.org/r/125408/diff/ > > > Testing > --- > > Builds fine, changing global shortcut still works. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124298: Remove logitech-mouse-related code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124298/ --- (Updated July 10, 2015, 6:23 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin. Changes --- Submitted with commit a029fb591ae6ddba5e23c5d5874afa7f2935fbd9 by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- As was agreed in review 124275. Newest device the code supports is from 2004. Code uses deprecated libusb library. It's questionable whether out-of-the-box support is working. Diffs - CMakeLists.txt ff413a1 kcms/input/CMakeLists.txt 67f664d kcms/input/logitechmouse.cpp 49364ea kcms/input/mouse.h 177fcda kcms/input/mouse.cpp 195f29f Diff: https://git.reviewboard.kde.org/r/124298/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124298: Remove logitech-mouse-related code
On July 8, 2015, 7:09 p.m., Kai Uwe Broulik wrote: kcms/input/CMakeLists.txt, line 43 https://git.reviewboard.kde.org/r/124298/diff/1/?file=383779#file383779line43 You probably also want to delete the logitechmouse_base.ui file Yeah, deleted that one and header locally, but this isn't shown with git diff... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124298/#review82235 --- On July 8, 2015, 7:05 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124298/ --- (Updated July 8, 2015, 7:05 p.m.) Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin. Repository: plasma-desktop Description --- As was agreed in review 124275. Newest device the code supports is from 2004. Code uses deprecated libusb library. It's questionable whether out-of-the-box support is working. Diffs - CMakeLists.txt ff413a1 kcms/input/CMakeLists.txt 67f664d kcms/input/logitechmouse.cpp 49364ea kcms/input/mouse.h 177fcda kcms/input/mouse.cpp 195f29f Diff: https://git.reviewboard.kde.org/r/124298/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124275: Allow building kcminput without libusb-compat
On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: Looks good to me too, as long as it works. OTOH, it looks like a bad reason to offer an homogeneous experience, albeit being a not really interesting bit of Plasma. I submited this patch to upstream due to two reasons: 1) number of supported hardware features is limited at best (according to link i posted, newest supported mouse is from 2004) 2) code is already #ifdef'ed, there is a small step to also let the buildsystem know the same - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82157 --- On July 6, 2015, 8:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- (Updated July 6, 2015, 8:41 p.m.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin Gräßlin. Repository: plasma-desktop Description --- Some distros are slowly targetting to get rid of the old libusb (see discussion in http://lists.opensuse.org/opensuse-factory/2015-07/msg00158.html) As the code mouse.[cpp,h] and logitechmouse.[cpp,h] is already ready for such an option, allow cmake to recognize this also. Diffs - kcms/CMakeLists.txt d8a69a3 kcms/input/CMakeLists.txt ee5c9c3 Diff: https://git.reviewboard.kde.org/r/124275/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124275: Allow building kcminput without libusb-compat
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin Gräßlin. Repository: plasma-desktop Description --- Some distros are slowly targetting to get rid of the old libusb (see discussion in http://lists.opensuse.org/opensuse-factory/2015-07/msg00158.html) As the code mouse.[cpp,h] and logitechmouse.[cpp,h] is already ready for such an option, allow cmake to recognize this also. Diffs - kcms/CMakeLists.txt d8a69a3 kcms/input/CMakeLists.txt ee5c9c3 Diff: https://git.reviewboard.kde.org/r/124275/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review81977 --- Ship it! Ship It! - Hrvoje Senjan On July 2, 2015, 1:07 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/ --- (Updated July 2, 2015, 1:07 a.m.) Review request for Plasma. Bugs: 349658 https://bugs.kde.org/show_bug.cgi?id=349658 Repository: plasma-desktop Description --- Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for. Also drop XBINDIR, as it wasn't being used at all. Should give something like this directory: ``` $ ls /usr/share/X11/xkb/ compat geometry keycodes rules symbols types ``` Diffs - ConfigureChecks.cmake 4fc4bce config-workspace.h.cmake eda8996 kcms/keyboard/xkb_rules.cpp 9fd0324 Diff: https://git.reviewboard.kde.org/r/124215/diff/ Testing --- re-compiled on my system, everything still works. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix
On June 30, 2015, 8:21 p.m., Hrvoje Senjan wrote: IMO best would be to use pkg-config to query for xkb_base variable... (if xkeyboard-config is really needed during buildtime) Aleix Pol Gonzalez wrote: What do we get? Also ```pkg-config --list-all``` doesn't list any *xkb* for me... pkg-config --variable=xkb_base xkeyboard-config - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review81912 --- On June 30, 2015, 4:53 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/ --- (Updated June 30, 2015, 4:53 p.m.) Review request for Plasma. Bugs: 349658 https://bugs.kde.org/show_bug.cgi?id=349658 Repository: plasma-desktop Description --- Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for. Also drop XBINDIR, as it wasn't being used at all. Should give something like this directory: ``` $ ls /usr/share/X11/xkb/ compat geometry keycodes rules symbols types ``` Diffs - kcms/keyboard/xkb_rules.cpp 9fd0324 ConfigureChecks.cmake 4fc4bce config-workspace.h.cmake eda8996 Diff: https://git.reviewboard.kde.org/r/124215/diff/ Testing --- re-compiled on my system, everything still works. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review81912 --- IMO best would be to use pkg-config to query for xkb_base variable... (if xkeyboard-config is really needed during buildtime) - Hrvoje Senjan On June 30, 2015, 4:53 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/ --- (Updated June 30, 2015, 4:53 p.m.) Review request for Plasma. Bugs: 349658 https://bugs.kde.org/show_bug.cgi?id=349658 Repository: plasma-desktop Description --- Instead of looking for X11 libraries and then looking stuff up, just find the directory we're looking for. Also drop XBINDIR, as it wasn't being used at all. Should give something like this directory: ``` $ ls /usr/share/X11/xkb/ compat geometry keycodes rules symbols types ``` Diffs - kcms/keyboard/xkb_rules.cpp 9fd0324 ConfigureChecks.cmake 4fc4bce config-workspace.h.cmake eda8996 Diff: https://git.reviewboard.kde.org/r/124215/diff/ Testing --- re-compiled on my system, everything still works. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- I would keep this for safety until Plasma 5.4 is released, then try to remove it again First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates continue doing so in the future ;-) Please don't remove anything ever, KF5 promises backward compatibility forever, not until $someotherproductversion... Distros where assured over and over again in the famous thread that no-bugfix-only KF5 releases will be a good thing for everyone, and they should be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with kde-workspace 4.11.99). If a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications. - Hrvoje Senjan On May 6, 2015, 7:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 7:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.
https://bugs.kde.org/show_bug.cgi?id=345209 --- Comment #4 from Hrvoje Senjan hrvoje.sen...@gmail.com --- It shows Fully charged - i shall believe it =) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.
https://bugs.kde.org/show_bug.cgi?id=345209 --- Comment #1 from Hrvoje Senjan hrvoje.sen...@gmail.com --- From the looks of it, 2b1a48742876a5fb548a71e7a6a52717dcb55ada in plasma-framework fixed this one. At least sddm user has now the following processes: sddm 935 0.0 0.1 40912 4840 ?Ss 03:43 0:00 /usr/lib/systemd/systemd --user sddm 937 0.0 0.0 72768 1764 ?S03:43 0:00 (sd-pam) sddm 1061 0.0 0.0 14184 1696 ?S03:43 0:00 dbus-launch --autolaunch 3e9b548e87a6e6e3afed740e03c5 --binary-syntax --close-stderr sddm 1108 0.0 0.0 39316 2432 ?Ss 03:43 0:00 /bin/dbus-daemon --fork --print-pid 5 --print-address 7 --session -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123281: Avoid triggering bug 340691
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/ --- Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Repository: plasma-desktop Description --- With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug. As similar fix was applied for bug 343583. Diffs - kcms/icons/icons.cpp 16a3141 kcms/migrationlib/kdelibs4config.h 0c1b7fe Diff: https://git.reviewboard.kde.org/r/123281/diff/ Testing --- Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123281: Avoid triggering bug 340691
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/ --- (Updated April 7, 2015, 11:46 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Changes --- Submitted with commit b2fc8174d5733fe3b051f839944870b4f51b8c52 by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug. As similar fix was applied for bug 343583. Diffs - kcms/icons/icons.cpp 16a3141 kcms/migrationlib/kdelibs4config.h 0c1b7fe Diff: https://git.reviewboard.kde.org/r/123281/diff/ Testing --- Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/ --- (Updated April 7, 2015, 6:50 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Changes --- Submitted with commit 1c56fb2195511f4a2e5ff6e94d70dafedb11657e by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- We only need to sync the changes to kde4 kdeglobals once users changes the defaults, hence only users KF5 kdeglobals need to be evaluated. This workarounds (though the change is IMO correct anyway) the kconfig bug, as we can otherwise pass both local and systemwide kdeglobals into copyTo method. Diffs - kcms/componentchooser/componentchooserbrowser.cpp f2b81ef kcms/componentchooser/componentchooserterminal.cpp be52334 kcms/input/mouse.cpp 69759bd Diff: https://git.reviewboard.kde.org/r/123288/diff/ Testing --- W/o the patch i had both BrowserApplication[$e]=chromium-browser.desktop (local adjustement) BrowserApplication=firefox.desktop (distro branding) in ~/.kde4/share/config/kdeglobals now i have only locally adjusted value Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123289/ --- Review request for Plasma, David Edmundson and Marco Martin. Bugs: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description --- We're interested only in local/users kdeglobals in this case. Diffs - misc/kde4breeze/src/main.cpp 361f965 Diff: https://git.reviewboard.kde.org/r/123289/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123289/ --- (Updated April 7, 2015, 7:16 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, David Edmundson and Marco Martin. Changes --- Submitted with commit 7272e6914ef9b756bbbeb132b63a4e39a79f11e9 by Hrvoje Senjan to branch master. Bugs: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description --- We're interested only in local/users kdeglobals in this case. Diffs - misc/kde4breeze/src/main.cpp 361f965 Diff: https://git.reviewboard.kde.org/r/123289/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123088: Adding libkactivities-stats to the build
On March 26, 2015, 4:34 p.m., Hrvoje Senjan wrote: the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` Ivan Čukić wrote: Is it fixed if you replace with this (seems this is a nice 1.56 bug): bool thisValid = !!currentValue; bool otherValid = !!other.currentValue; Alex Richardson wrote: Seems they are using c++11 `explicit operator bool()`, so I wouldn't call it a bug but intentional. builds with https://build.opensuse.org/package/view_file/KDE:Unstable:Frameworks/plasma5-desktop/boost.diff?expand=1 - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- On March 26, 2015, 2:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 2:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt
Re: Review Request 123088: Adding libkactivities-stats to the build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review78065 --- the library doesn't seem to like boost 1.56: ``` In file included from ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:78:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool thisValid = currentValue; ^ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:79:14: error: no viable conversion from 'const boost::optionalResult' to 'bool' bool otherValid = other.currentValue; ^~~ ../lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:96:16: error: no viable conversion from 'const boost::optionalResult' to 'bool' return currentValue; ^~~~ 1 warning and 3 errors generated. ``` or with gcc: ``` [ 232s] In file included from /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset.cpp:425:0: [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::operator==(const KActivities::Experimental::Stats::ResultSet::const_iterator::Private) const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:76:27: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool thisValid = currentValue; [ 232s]^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:77:33: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in initialization [ 232s] bool otherValid = other.currentValue; [ 232s] ^ [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp: In member function 'bool KActivities::Experimental::Stats::ResultSet::const_iterator::Private::isValid() const': [ 232s] /home/abuild/rpmbuild/BUILD/plasma-desktop-5.2.91git~20150326T143831~cc30975/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optionalKActivities::Experimental::Stats::ResultSet::Result' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` - Hrvoje Senjan On March 26, 2015, 2:47 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 26, 2015, 2:47 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 8714f89 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION lib/kactivities-stats/src/common/database/schema
Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- (Updated March 23, 2015, 11:01 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Martin Gräßlin and Jan Grulich. Changes --- Submitted with commit 17a144bc8c210eae0893bac327e836b0d546e215 by Hrvoje Senjan to branch master. Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition. Also adjusted the surrounding files to make them build with this. It is needed to avoid symbol collision with gtk/gio. (I have no idea what changed in NM 1.0.0 that is exposes the failure, it builds fine with older versions - but would like to know if there's a better solution ;-) Diffs - dataengines/geolocation/CMakeLists.txt 7a477c1 dataengines/geolocation/geolocation.cpp 678f25f dataengines/geolocation/geolocationprovider.cpp 6db8026 Diff: https://git.reviewboard.kde.org/r/123091/diff/ Testing --- The error was: ``` In file included from /usr/include/qt5/QtCore/qobject.h:40:0, from /usr/include/qt5/QtCore/qtimer.h:42, from /usr/include/qt5/QtCore/QTimer:1, from ../dataengines/geolocation/geolocation.h:21, from ../dataengines/geolocation/geolocation.cpp:18: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’ GDBusSignalInfo **signals; ^ In file included from /usr/include/glib-2.0/gio/gio.h:53:0, from /usr/include/libnm/nm-types.h:24, from /usr/include/libnm/nm-object.h:29, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /usr/include/KF5/NetworkManagerQt/ipconfig.h:34, from /usr/include/KF5/NetworkManagerQt/device.h:33, from /usr/include/KF5/NetworkManagerQt/manager.h:31, from /usr/include/KF5/NetworkManagerQt/Manager:1, from ../dataengines/geolocation/geolocation.cpp:25: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration GDBusSignalInfo **signals; ^ /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123088: Adding libkactivities-stats to the build
On March 20, 2015, 10:23 p.m., Marco Martin wrote: +1 from here (will read it more) Eike Hein wrote: +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade Ivan Čukić wrote: Waiting for +2 since +1 +1 = 1.98 on the first Pentium processor. :) From buildsystem/packager point of view i am wondering is installing cmake files and headers needed here? If yes, then maybe better place would be plasma-workspace which also installs both, unlinke plasma-desktop. If no, then it would be great to avoid installing headers, cmake conf shlibs devel symlink. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/#review77854 --- On March 20, 2015, 10:07 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ --- (Updated March 20, 2015, 10:07 p.m.) Review request for Plasma, Eike Hein and Marco Martin. Repository: plasma-desktop Description --- The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d. The idea came from Eike. While it has downsides, it also has a few benefits: - no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility; - when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files; - no need to sync the releases and think about which KActivities version plasma 5.x will be used against; - I guess I'm forgetting more benefits. :) The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch) Diffs - CMakeLists.txt 2d43890 lib/kactivities-stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in PRE-CREATION lib/kactivities-stats/README PRE-CREATION lib/kactivities-stats/src/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/Messages.sh PRE-CREATION lib/kactivities-stats/src/common/database/Database.h PRE-CREATION lib/kactivities-stats/src/common/database/Database.cpp PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h PRE-CREATION lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/common.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml PRE-CREATION lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml PRE-CREATION lib/kactivities-stats/src/common/specialvalues.h PRE-CREATION lib/kactivities-stats/src/lib/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/CMakeLists.txt PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.h PRE-CREATION lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake PRE-CREATION lib/kactivities-stats/src/lib/stats/query.h PRE-CREATION lib/kactivities-stats/src/lib/stats/query.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultmodel.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.h PRE-CREATION lib/kactivities-stats/src/lib/stats/resultwatcher.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.h PRE-CREATION lib/kactivities-stats/src/lib/stats/terms.cpp PRE-CREATION lib/kactivities-stats/src/lib/stats/version.h PRE-CREATION
Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- Review request for Plasma, Martin Gräßlin and Jan Grulich. Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition. Also adjusted the surrounding files to make them build with this. It is needed to avoid symbol collision with gtk/gio. (I have no idea what changed in NM 1.0.0 that is exposes the failure, it builds fine with older versions - but would like to know if there's a better solution ;-) Diffs - dataengines/geolocation/CMakeLists.txt 7a477c1 dataengines/geolocation/geolocation.cpp 678f25f dataengines/geolocation/geolocationprovider.cpp 6db8026 Diff: https://git.reviewboard.kde.org/r/123091/diff/ Testing --- The error was: ``` In file included from /usr/include/qt5/QtCore/qobject.h:40:0, from /usr/include/qt5/QtCore/qtimer.h:42, from /usr/include/qt5/QtCore/QTimer:1, from ../dataengines/geolocation/geolocation.h:21, from ../dataengines/geolocation/geolocation.cpp:18: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’ GDBusSignalInfo **signals; ^ In file included from /usr/include/glib-2.0/gio/gio.h:53:0, from /usr/include/libnm/nm-types.h:24, from /usr/include/libnm/nm-object.h:29, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /usr/include/KF5/NetworkManagerQt/ipconfig.h:34, from /usr/include/KF5/NetworkManagerQt/device.h:33, from /usr/include/KF5/NetworkManagerQt/manager.h:31, from /usr/include/KF5/NetworkManagerQt/Manager:1, from ../dataengines/geolocation/geolocation.cpp:25: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration GDBusSignalInfo **signals; ^ /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123091/ --- (Updated March 21, 2015, 2:16 a.m.) Review request for Plasma, Martin Gräßlin and Jan Grulich. Changes --- Fix build for the plasma-geolocation-ip module also Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition. Also adjusted the surrounding files to make them build with this. It is needed to avoid symbol collision with gtk/gio. (I have no idea what changed in NM 1.0.0 that is exposes the failure, it builds fine with older versions - but would like to know if there's a better solution ;-) Diffs (updated) - dataengines/geolocation/CMakeLists.txt 7a477c1 dataengines/geolocation/geolocation.cpp 678f25f dataengines/geolocation/geolocationprovider.cpp 6db8026 Diff: https://git.reviewboard.kde.org/r/123091/diff/ Testing --- The error was: ``` In file included from /usr/include/qt5/QtCore/qobject.h:40:0, from /usr/include/qt5/QtCore/qtimer.h:42, from /usr/include/qt5/QtCore/QTimer:1, from ../dataengines/geolocation/geolocation.h:21, from ../dataengines/geolocation/geolocation.cpp:18: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected unqualified-id before ‘public’ GDBusSignalInfo **signals; ^ In file included from /usr/include/glib-2.0/gio/gio.h:53:0, from /usr/include/libnm/nm-types.h:24, from /usr/include/libnm/nm-object.h:29, from /usr/include/libnm/nm-access-point.h:29, from /usr/include/libnm/NetworkManager.h:26, from /usr/include/KF5/NetworkManagerQt/ipconfig.h:34, from /usr/include/KF5/NetworkManagerQt/device.h:33, from /usr/include/KF5/NetworkManagerQt/manager.h:31, from /usr/include/KF5/NetworkManagerQt/Manager:1, from ../dataengines/geolocation/geolocation.cpp:25: /usr/include/glib-2.0/gio/gdbusintrospection.h:155:24: error: expected ‘;’ at end of member declaration GDBusSignalInfo **signals; ^ /usr/include/glib-2.0/gio/gdbusintrospection.h:155:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122315/ --- (Updated March 19, 2015, 11:22 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit c3cb87a1b580e0805a9f14d89e5a176d56862c6e by Hrvoje Senjan to branch master. Repository: kwrited Description --- this was the case in all(most?) of kde4 timeline, but with the KF5 port kpty didn't expose utempter presence Diffs - CMakeLists.txt 8c29e1b Diff: https://git.reviewboard.kde.org/r/122315/diff/ Testing --- working Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122919: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122919/#review77434 --- src/CMakeLists.txt https://git.reviewboard.kde.org/r/122919/#comment53173 you where almost right in rev1 of the patch ;-) this line would welcome e.g. set(HAVE_XFIXES TRUE) othewise the ifdefs are never compiled. whether you want to fix this in this review is up to you - Hrvoje Senjan On March 13, 2015, 6 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122919/ --- (Updated March 13, 2015, 6 p.m.) Review request for Plasma. Repository: sddm-kcm Description --- I can't find any reference to these dependencies, so remove them. Diffs - CMakeLists.txt 79c1faff6087575296d49c3926732c92c391eccc src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c Diff: https://git.reviewboard.kde.org/r/122919/diff/ Testing --- Inspected source. Builds. No library links to the affected dependencies before and after the change. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122919: Remove unused dependencies.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122919/#review77431
---
src/CMakeLists.txt
https://git.reviewboard.kde.org/r/122919/#comment53170
grep -irn xfixes
src/CMakeLists.txt:50:if (X11_Xfixes_FOUND)
src/CMakeLists.txt:51: target_link_libraries(kcm_sddm ${X11_Xfixes_LIB})
src/CMakeLists.txt:52:endif (X11_Xfixes_FOUND)
src/cursortheme/cursortheme.cpp:31:#ifdef HAVE_XFIXES
src/cursortheme/cursortheme.cpp:33:# include X11/extensions/Xfixes.h
src/cursortheme/cursortheme.cpp:144:#ifdef HAVE_XFIXES
src/cursortheme/cursortheme.cpp:146:if (haveXfixes())
src/cursortheme/cursortheme.cpp:148:
XFixesSetCursorName(QX11Info::display(), cursor,
src/cursortheme/cursortheme.cpp:154:bool CursorTheme::haveXfixes()
src/cursortheme/cursortheme.cpp:158:#ifdef HAVE_XFIXES
src/cursortheme/cursortheme.cpp:163:if
(XFixesQueryExtension(QX11Info::display(), event_base, error_base))
src/cursortheme/cursortheme.cpp:166:
XFixesQueryVersion(QX11Info::display(), major, minor);
src/cursortheme/cursortheme.h:102:static bool haveXfixes();
src/cursortheme/cursortheme.h:119:// Convenience function that uses
Xfixes to tag a cursor with a name
- Hrvoje Senjan
On March 12, 2015, 4:30 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122919/
---
(Updated March 12, 2015, 4:30 p.m.)
Review request for Plasma.
Repository: sddm-kcm
Description
---
I can't find any reference to these dependencies, so remove them.
Diffs
-
CMakeLists.txt 52e1ace5fb9cee4afa0711b4f6bc0b851500d427
src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c
Diff: https://git.reviewboard.kde.org/r/122919/diff/
Testing
---
Inspected source. Builds. No library links to the affected dependencies
before and after the change.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77309 --- src/quickaddons/CMakeLists.txt https://git.reviewboard.kde.org/r/122886/#comment53094 you need also KF5::Auth as public, the new public header has a kauthaction include - Hrvoje Senjan On March 10, 2015, 12:28 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 12:28 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122733: Fix path traversal checks in KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review77011 --- this has broken wallpaper loading here... there's loads of Attempting to read file from invalid package! file type: metadata file name: package path: /usr/share/wallpapers/Aghi/ ... warnings... - Hrvoje Senjan On March 3, 2015, 6:53 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ --- (Updated March 3, 2015, 6:53 p.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kpackage Description --- They did not canonicalize the package base directory path so it would always fail when the package base path contained symlinks Diffs - src/kpackage/package.cpp eb4a09b987970e89f28587426b21d63731634087 src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122810: Adjust kdeclarative public deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122810/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kdeclarative Description --- kio isn't used publicly in neither of the 2 shared libraries, but kpackage and kconfig are (publicly). make sure we find them as deps Diffs - KF5DeclarativeConfig.cmake.in 2250239 src/kdeclarative/CMakeLists.txt f99a374 Diff: https://git.reviewboard.kde.org/r/122810/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122810: Adjust kdeclarative public deps
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122810/ --- (Updated March 4, 2015, 3:05 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kdeclarative Description --- kio isn't used publicly in neither of the 2 shared libraries, but kpackage and kconfig are (publicly). make sure we find them as deps Diffs - KF5DeclarativeConfig.cmake.in 2250239 src/kdeclarative/CMakeLists.txt f99a374 Diff: https://git.reviewboard.kde.org/r/122810/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace
https://bugs.kde.org/show_bug.cgi?id=344612 Hrvoje Senjan hrvoje.sen...@gmail.com changed: What|Removed |Added CC||hrvoje.sen...@gmail.com --- Comment #13 from Hrvoje Senjan hrvoje.sen...@gmail.com --- yeah, we have the helper splited as a package on openSUSE, so lib can be coinstalled (ftr. the patch you pasted is not 'an openSUSE' patch) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122726: Make touchpad KCM optional depending on whether we find synaptics
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122726/#review76650 --- find_package(KDED REQUIRED) is also missing... - Hrvoje Senjan On Feb. 26, 2015, 12:02 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122726/ --- (Updated Feb. 26, 2015, 12:02 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- Make touchpad KCM optional depending on whether we find synaptics Diffs - CMakeLists.txt f98a189 cmake/modules/FindSynaptics.cmake PRE-CREATION kcms/CMakeLists.txt 5ff1780 kcms/touchpad/src/backends/x11.cmake 3496333 Diff: https://git.reviewboard.kde.org/r/122726/diff/ Testing --- Mine still builds.. .once pushed we'll find out if build.kde.org passes again. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kio-extras] [Bug 343634] Web Shortcuts segfault
https://bugs.kde.org/show_bug.cgi?id=343634 Hrvoje Senjan hrvoje.sen...@gmail.com changed: What|Removed |Added CC||hrvoje.sen...@gmail.com Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Hrvoje Senjan hrvoje.sen...@gmail.com --- *** This bug has been marked as a duplicate of bug 342228 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #60 from Hrvoje Senjan hrvoje.sen...@gmail.com --- kded5 bt w/ Davids patch: #0 0x7f505a91685f in pthread_cond_wait@@GLIBC_2.3.2 () at /lib64/libpthread.so.0 #1 0x7f505b89796b in QWaitCondition::wait(QMutex*, unsigned long) (time=18446744073709551615, this=0xd11fe0) at thread/qwaitcondition_unix.cpp:128 #2 0x7f505b89796b in QWaitCondition::wait(QMutex*, unsigned long) (this=this@entry=0xd11fc8, mutex=mutex@entry=0xd11fa0, time=time@entry=18446744073709551615) at thread/qwaitcondition_unix.cpp:200 #3 0x7f505b89657e in QThread::wait(unsigned long) (this=this@entry= 0x7fffac915880, time=time@entry=18446744073709551615) at thread/qthread_unix.cpp:670 #4 0x7f502ad73462 in PowerDevilUPowerBackend::kjobExecInThread(KJob*) (job=job@entry=0xd95ed0) at /home/hrvoje/Src/local/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp:594 #5 0x7f502ad73576 in PowerDevilUPowerBackend::brightnessValue(PowerDevil::BackendInterface::BrightnessControlType) const (this= 0xb6d580, type=optimized out) at /home/hrvoje/Src/local/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp:308 #6 0x7f502ad710cd in PowerDevilUPowerBackend::init() (this=optimized out) at /home/hrvoje/Src/local/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp:182 #7 0x7f502ab215db in PowerDevil::Core::loadCore(PowerDevil::BackendInterfac---Type return to continue, or q return to quit--- e*) (this=0xcb51a0, backend=backend@entry=0xb6d580) at /home/hrvoje/Src/local/powerdevil/daemon/powerdevilcore.cpp:87 #8 0x7f502ad649bc in KDEDPowerDevil::init() (this=0xc87670) at /home/hrvoje/Src/local/powerdevil/daemon/kdedpowerdevil.cpp:89 #9 0x7f505baa1506 in QObject::event(QEvent*) (this=0xc87670, e=optimized out) at kernel/qobject.cpp:1245 #10 0x7f505c72fb5c in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x8a9bf0, receiver=receiver@entry=0xc87670, e=e@entry= 0xc74760) at kernel/qapplication.cpp:3722 #11 0x7f505c734bc0 in QApplication::notify(QObject*, QEvent*) (this= 0x7fffac916350, receiver=0xc87670, e=0xc74760) at kernel/qapplication.cpp:3505 #12 0x7f505ba70e55 in QCoreApplication::notifyInternal(QObject*, QEvent*) (this=0x7fffac916350, receiver=0xc87670, event=event@entry=0xc74760) at kernel/qcoreapplication.cpp:930 #13 0x7f505ba72cef in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (event=0xc74760, receiver=optimized out) at kernel/qcoreapplication.h:228 #14 0x7f505ba72cef in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (receiver=receiver@entry=0x0, event_type=event_type@entry=0, data=0x8a9d60) at kernel/qcoreapplication.cpp:1534 #15 0x7f505ba73328 in QCoreApplication::sendPostedEvents(QObject*, int) (receiver=receiver@entry=0x0, event_type=event_type@entry=0) ---Type return to continue, or q return to quit--- at kernel/qcoreapplication.cpp:1392 #16 0x7f505bac8d23 in postEventSourceDispatch(GSource*, GSourceFunc, gpointer) (s=0x91bed0) at kernel/qeventdispatcher_glib.cpp:271 #17 0x7f5059c97a04 in g_main_context_dispatch () at /usr/lib64/libglib-2.0.so.0 #18 0x7f5059c97c48 in () at /usr/lib64/libglib-2.0.so.0 #19 0x7f5059c97cec in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #20 0x7f505bac819c in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) (this=0x9105c0, flags=...) at kernel/qeventdispatcher_glib.cpp:418 #21 0x7f505ba6edab in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) (this=this@entry=0x7fffac916280, flags=..., flags@entry=...) at kernel/qeventloop.cpp:204 #22 0x7f505ba76436 in QCoreApplication::exec() () at kernel/qcoreapplication.cpp:1183 #23 0x7f505dfcf73a in kdemain () at /usr/lib64/libkdeinit5_kded5.so #24 0x7f505dc48b45 in __libc_start_main () at /lib64/libc.so.6 #25 0x004007ee in _start () -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #58 from Hrvoje Senjan hrvoje.sen...@gmail.com --- from short testing the patch seems to resolves the CPU problem. however: 1) for locking the screen, it now takes some 30s to actually show the locker, 2) konsole action (right click) is blocked with: 0 0x7f6f482e94ad in poll () at /lib64/libc.so.6 #1 0x7f6f3bf1926a in () at /lib64/libdbus-1.so.3 #2 0x7f6f3bf180bf in () at /lib64/libdbus-1.so.3 #3 0x7f6f3bf025bc in () at /lib64/libdbus-1.so.3 #4 0x7f6f3bf02f69 in () at /lib64/libdbus-1.so.3 #5 0x7f6f3bf0352d in dbus_connection_send_with_reply_and_block () at /lib64/libdbus-1.so.3 #6 0x7f6f42666780 in QDBusConnectionPrivate::sendWithReply(QDBusMessage const, int, int) (error=0x7fff89162670, timeout_milliseconds=-1, message=0x2077aa0, connection=optimized out) at qdbus_symbols_p.h:135 #7 0x7f6f42666780 in QDBusConnectionPrivate::sendWithReply(QDBusMessage const, int, int) (this= 0x206b910, message=..., sendMode=optimized out, timeout=-1) at qdbusintegrator.cpp:2046 #8 0x7f6f426533c3 in QDBusConnection::call(QDBusMessage const, QDBus::CallMode, int) const (this=this@entry=0x23e2b10, message=..., mode=mode@entry=QDBus::Block, timeout=optimized out) at qdbusconnection.cpp:576 #9 0x7f6f426717ef in QDBusAbstractInterface::callWithArgumentList(QDBus::CallMode, QString const, QListQVariant const) (this=this@entry=0x7fff891629b0, mode=QDBus::Block, mode@entry=QDBus::AutoDetect, method=..., args=...) at qdbusabstractinterface.cpp:476 #10 0x7f6f426725b5 in QDBusAbstractInterface::call(QDBus::CallMode, QString const, QVariant const, QVariant const, QVariant const, QVariant const, QVar---Type return to continue, or q return to quit--- iant const, QVariant const, QVariant const, QVariant const) (this=this@entry=0x7fff891629b0, mode=mode@entry=QDBus::AutoDetect, method=..., arg1=..., arg2=..., arg3=..., arg4=..., arg5=..., arg6=..., arg7=..., arg8=...) at qdbusabstractinterface.cpp:746 #11 0x7f6f42672771 in QDBusAbstractInterface::call(QString const, QVariant const, QVariant const, QVariant const, QVariant const, QVariant const, QVariant const, QVariant const, QVariant const) (this=this@entry=0x7fff891629b0, method=..., arg1=..., arg2=..., arg3=..., arg4=..., arg5=..., arg6=..., arg7=..., arg8=...) at qdbusabstractinterface.cpp:689 #12 0x7f6f433c783c in KIO::favIconForUrl(QUrl const) (url=...) at /usr/src/debug/kio-5.7.0git/src/core/global.cpp:339 #13 0x7f6f433c8085 in KIO::iconNameForUrl(QUrl const) (url=...) at /usr/src/debug/kio-5.7.0git/src/core/global.cpp:356 #14 0x7f6f21034352 in SearchProvider::iconName() const (this=optimized out) at /usr/src/debug/kio-5.7.0git/src/urifilters/ikws/searchprovider.cpp:111 #15 0x7f6f4731313a in KUriFilterData::iconNameForPreferredSearchProvider(QString const) const (this=optimized out, provider=...) at /usr/src/debug/kio-5.7.0git/src/widgets/kurifilter.cpp:381 #16 0x7f6f47f83883 in Konsole::SessionController::updateWebSearchMenu() () at /usr/lib64/libkonsoleprivate.so.3 #17 0x7f6f47f89697 in Konsole::SessionController::showDisplayContextMenu(QPoint const) () at /usr/lib64/libkonsoleprivate.so.3 #18 0x7f6f4494e12f in QMetaObject::activate(QObject*, int, int, void**) (a=0---Type return to continue, or q return to quit--- x7fff89162eb0, r=0x2384940, this=0x2380270) at ../../src/corelib/kernel/qobject_impl.h:124 #19 0x7f6f4494e12f in QMetaObject::activate(QObject*, int, int, void**) (sender=0x23efd50, signalOffset=optimized out, local_signal_index=optimized out, argv=0x7fff89162eb0) at kernel/qobject.cpp:3702 #20 0x7f6f47fbfc55 in Konsole::TerminalDisplay::configureRequest(QPoint const) () at /usr/lib64/libkonsoleprivate.so.3 #21 0x7f6f47fa5269 in Konsole::TerminalDisplay::mousePressEvent(QMouseEvent*) () at /usr/lib64/libkonsoleprivate.so.3 #22 0x7f6f4561d50a in QWidget::event(QEvent*) (this=0x23efd50, event= 0x7fff891633b0) at kernel/qwidget.cpp:8652 #23 0x7f6f47fa5cca in Konsole::TerminalDisplay::event(QEvent*) () at /usr/lib64/libkonsoleprivate.so.3 #24 0x7f6f455ddb5c in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x2094b20, receiver=receiver@entry=0x23efd50, e=e@entry=0x7fff891633b0) at kernel/qapplication.cpp:3722 #25 0x7f6f455e34e6 in QApplication::notify(QObject*, QEvent*) (this=optimized out, receiver=0x23efd50, e=0x7fff891633b0) at kernel/qapplication.cpp:3280 #26 0x7f6f4491ee55 in QCoreApplication::notifyInternal(QObject*, QEvent*) (this= 0x7fff89163cd0, receiver=receiver@entry=0x23efd50, event=event@entry=0x7fff891633b0) at kernel/qcoreapplication.cpp:930 #27 0x7f6f455e1eb1 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEv---Type return to continue, or q return to quit--- ent*, QWidget*, QWidget*, QWidget**, QPointerQWidget, bool) (event=0x7fff891633b0, receiver=0x23efd50) at ../../src/corelib/kernel
Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122315/ --- Review request for Plasma. Repository: kwrited Description --- this was the case in all(most?) of kde4 timeline, but with the KF5 port kpty didn't expose utempter presence Diffs - CMakeLists.txt 8c29e1b Diff: https://git.reviewboard.kde.org/r/122315/diff/ Testing --- working Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter
On Jan. 29, 2015, 8:53 p.m., Lukáš Tinkl wrote: Ship It! if/when r122313 gets approved, i'll push this one to master (dunno if 5.2 would be a good target?) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122315/#review75000 --- On Jan. 29, 2015, 8:48 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122315/ --- (Updated Jan. 29, 2015, 8:48 p.m.) Review request for Plasma. Repository: kwrited Description --- this was the case in all(most?) of kde4 timeline, but with the KF5 port kpty didn't expose utempter presence Diffs - CMakeLists.txt 8c29e1b Diff: https://git.reviewboard.kde.org/r/122315/diff/ Testing --- working Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121563: Fix build with Qt 5.5/dev branch in release mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121563/ --- (Updated Jan. 19, 2015, 11:32 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: libksysguard Description --- same as review 121562: since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c Make the empty Q_ASSERT still check its argument for validity the build shall fail. alternative is to guard the Q_ASSERT with QT_NO_DEBUG Diffs - processcore/processes.cpp 6c0effc Diff: https://git.reviewboard.kde.org/r/121563/diff/ Testing --- builds with both 5.4 dev branch Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #42 from Hrvoje Senjan hrvoje.sen...@gmail.com --- i'm also having two kded5 processes, user's and sddm's. however, only users goes wild. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #44 from Hrvoje Senjan hrvoje.sen...@gmail.com --- i've just tried kdm, and managed to reproduce the issue still... it's essential that the helper, and not XRandBrightness is used. also, i've tried locally to revert the logic in powerdevil (switch to !job-exec(), instead of checking it's successful first, and that resolved for me bug 342597. one caveat is that the slider then has 9/9 which is a regression i'd say compared to 5.1.x. the logic switch does not help this bug though) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121563: Fix build with Qt 5.5/dev branch in release mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121563/ --- (Updated Jan. 17, 2015, 6:12 p.m.) Review request for Plasma. Changes --- guard the assert instead Repository: libksysguard Description --- same as review 121562: since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c Make the empty Q_ASSERT still check its argument for validity the build shall fail. alternative is to guard the Q_ASSERT with QT_NO_DEBUG Diffs (updated) - processcore/processes.cpp 6c0effc Diff: https://git.reviewboard.kde.org/r/121563/diff/ Testing --- builds with both 5.4 dev branch Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #33 from Hrvoje Senjan hrvoje.sen...@gmail.com --- nope, it is the same process -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 340892] System Settings's Power management complains about power management service
https://bugs.kde.org/show_bug.cgi?id=340892 Hrvoje Senjan hrvoje.sen...@gmail.com changed: What|Removed |Added CC||hrvoje.sen...@gmail.com --- Comment #5 from Hrvoje Senjan hrvoje.sen...@gmail.com --- this one is probably fixed with commit ee9e92ff4e555252742326124cd7a5d3b574a27c in kauth. check the path in /usr/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 337674] kded5 is eating CPU
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #30 from Hrvoje Senjan hrvoje.sen...@gmail.com --- Created attachment 90381 -- https://bugs.kde.org/attachment.cgi?id=90381action=edit sligthly more debug i am also getting the CPU murdering after recent changes to powerdevil dataengine powerdevil itself (see also bug 342597) this one can be reproduced on my setup at 99% of the time after doing a switch user routine. after going back to original session, kded5 is busy -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342570] New: kde4breeze copies contents of systemwide kdeglobals
https://bugs.kde.org/show_bug.cgi?id=342570 Bug ID: 342570 Summary: kde4breeze copies contents of systemwide kdeglobals Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: major Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: hrvoje.sen...@gmail.com after seeing in bug 340691 the issue is not in kconfig and testing with kconfig commit 915976c1238be811f169eab1b02f7e8dad6410e0, i have noticed that the fault lies in kde4breeze. steps to reproduce are, as written: have /etc/xdg/kdeglobals with [General] BrowserApplication=firefox inside; start a plasma 5 session with a clean user, change default browser either with kcm, or by hand in ~/.config/kdeglobals, logout, login - observe the ~/.config/kdeglobals, it has both firefox and browser added by user this *does not* happen after mentioned commit, but if i add Value=5 (iow, so upd is again valid), the users kdeglobals have written in the systemwide values Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 342420] New: Provide default wallpaper in png format
https://bugs.kde.org/show_bug.cgi?id=342420 Bug ID: 342420 Summary: Provide default wallpaper in png format Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: grave Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: hrvoje.sen...@gmail.com Plasma tries to load wallpaper in that format, but currently git master of new wallpaper has them in jpg format. Changing the suffix in plasma-framework is not wise, as that will break Plasma 5.1.x Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121563: Fix build with Qt 5.5/dev branch in release mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121563/ --- Review request for Plasma. Repository: libksysguard Description --- same as review 121562: since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c Make the empty Q_ASSERT still check its argument for validity the build shall fail. alternative is to guard the Q_ASSERT with QT_NO_DEBUG Diffs - processcore/processes.cpp 6c0effc Diff: https://git.reviewboard.kde.org/r/121563/diff/ Testing --- builds with both 5.4 dev branch Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Powerdevil] [Bug 341775] New: Powerdevil kded triggers kded5 loop
https://bugs.kde.org/show_bug.cgi?id=341775 Bug ID: 341775 Summary: Powerdevil kded triggers kded5 loop Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: grave Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: hrvoje.sen...@gmail.com Since 697e505f37b9128d68ef2b0ce5c9d7f80ca422ff - Emit signal when maximum brightness changes, i am getting kded5 killing the CPU... obtained backtrace: Thread 1 (Thread 0x7f79784fb780 (LWP 23601)): #0 0x7f7973df7a80 in () at /usr/lib64/libglib-2.0.so.0 #1 0x7f7973df7cec in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #2 0x7f7975c26f9c in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #3 0x7f7975bcdbbb in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #4 0x7f7976fdaa6e in KJob::exec() () at /usr/lib64/libKF5CoreAddons.so.5 #5 0x7f795d87cb94 in PowerDevilUPowerBackend::brightnessValueMax(PowerDevil::BackendInterface::BrightnessControlType) const (this=optimized out, type=optimized out) at /usr/src/debug/powerdevil-5.1.90git/daemon/backends/upower/powerdevilupowerbackend.cpp:384 #6 0x7f795d442a92 in BrightnessControlAdaptor::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (this=0x15417e0) ---Type return to continue, or q return to quit--- at /usr/src/debug/powerdevil-5.1.90git/build/daemon/brightnesscontroladaptor.cpp:63 #7 0x7f795d442a92 in BrightnessControlAdaptor::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=_o@entry=0x15417e0, _c=_c@entry=QMetaObject::InvokeMetaMethod, _id=_id@entry=8, _a=_a@entry=0x7fff181aa440) at /usr/src/debug/powerdevil-5.1.90git/build/daemon/brightnesscontroladaptor.moc:153 #8 0x7f795d442ce3 in BrightnessControlAdaptor::qt_metacall(QMetaObject::Call, int, void**) (this=0x15417e0, _c=QMetaObject::InvokeMetaMethod, _id=8, _a=0x7fff181aa440) at /usr/src/debug/powerdevil-5.1.90git/build/daemon/brightnesscontroladaptor.moc:216 #9 0x7f797749d67f in QDBusConnectionPrivate::deliverCall(QObject*, int, QDBusMessage const, QVectorint const, int) (this=this@entry= 0x1117010, object=object@entry=0x15417e0, msg=..., metaTypes=..., slotIdx=13) at qdbusintegrator.cpp:990 #10 0x7f79774a1dac in QDBusConnectionPrivate::activateCall(QObject*, int, QDBusMessage const) (this=this@entry=0x1117010, object=0x15417e0, flags=flags@entry=273, msg=...) at qdbusintegrator.cpp:902 #11 0x7f79774a2823 in QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode, QDBusMessage const, int) (this=0x1117010, node=..., msg=..., pathStartPos=optimized out) at qdbusintegrator.cpp:1463 #12 0x7f79774a426e in QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x17f58c0) at qdbusintegrator.cpp:1577 #13 0x7f7975c002b6 in QObject::event(QEvent*) () at /usr/lib64/libQt5Core.so.5 #14 0x7f797688da9c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5 #15 0x7f7976892b00 in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQt5Widgets.so.5 #16 0x7f7975bcfc55 in QCoreApplication::notifyInternal(QObject*, QEvent*) () at /usr/lib64/libQt5Core.so.5 #17 0x7f7975bd1aef in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () at /usr/lib64/libQt5Core.so.5 #18 0x7f7975c27b23 in () at /usr/lib64/libQt5Core.so.5 #19 0x7f7973df7a04 in g_main_context_dispatch () at /usr/lib64/libglib-2.0.so.0 #20 0x7f7973df7c48 in () at /usr/lib64/libglib-2.0.so.0 #21 0x7f7973df7cec in g_main_context_iteration () at /usr/lib64/libglib-2.0.so.0 #22 0x7f7975c26f9c in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 ---Type return to continue, or q return to quit--- #23 0x7f7975bcdbbb in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () at /usr/lib64/libQt5Core.so.5 #24 0x7f7976fdaa6e in KJob::exec() () at /usr/lib64/libKF5CoreAddons.so.5 #25 0x7f795d87d196 in PowerDevilUPowerBackend::brightnessValue(PowerDevil::BackendInterface::BrightnessControlType) const (this= 0x153a620, type=optimized out) at /usr/src/debug/powerdevil-5.1.90git/daemon/backends/upower/powerdevilupowerbackend.cpp:354 #26 0x7f795d442a62 in BrightnessControlAdaptor::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (this=0x15417e0) at /usr/src/debug/powerdevil-5.1.90git/build/daemon/brightnesscontroladaptor.cpp:57 #27 0x7f795d442a62 in BrightnessControlAdaptor::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=_o@entry=0x15417e0, _c=_c@entry=QMetaObject::InvokeMetaMethod, _id=_id@entry=7, _a=_a@entry=0x7fff181aaec0) at
Re: Review Request 121355: Expose actual and maximum brightness value in dataengine
On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery monitor accordingly. Kai Uwe Broulik wrote: Oh, umm, sorry, misread that. What's the value of Maximum Screen Brightness in the dataengine? Make sure you've restarted kded and plasma. Hrvoje Senjan wrote: this happened (noticed it) after upgrade - logout - login =). the powerdevil KCM corectly has screen brigtness slider, so issue is exposed only here... Kai Uwe Broulik wrote: Please test whether https://git.reviewboard.kde.org/r/121364/ together with https://git.reviewboard.kde.org/r/121365/ help in your situation. nope, no change. aditionally, with that patches, i get kded5 murdering the CPU... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71445 --- On Dec. 5, 2014, 10:06 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- (Updated Dec. 5, 2014, 10:06 p.m.) Review request for Plasma and Solid. Repository: plasma-workspace Description --- Now that we can finally use absolute brightness values, rather than a fixed 0-100% range, those values should be exposed in the dataengine instead. This allows us to eg. properly handle keyboard brightness controls which usually have just a few steps. I adjusted battery monitor accordingly. It also cleans up the code by moving stuff into lambdas and gets rid of the ugly availability stuff by just relying on the maximum values to determin whether it's available. We still don't have means, though, to detect changes in these at runtime. Diffs - dataengines/powermanagement/powermanagementengine.h ffad13e dataengines/powermanagement/powermanagementengine.cpp 04aa49b dataengines/powermanagement/powermanagementjob.cpp c4e4510 Diff: https://git.reviewboard.kde.org/r/121355/diff/ Testing --- Works as expected, I need someone without keyboard or screen brightness to test the availability. File Attachments Battery monitor with keyboard https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121355: Expose actual and maximum brightness value in dataengine
On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery monitor accordingly. Kai Uwe Broulik wrote: Oh, umm, sorry, misread that. What's the value of Maximum Screen Brightness in the dataengine? Make sure you've restarted kded and plasma. Hrvoje Senjan wrote: this happened (noticed it) after upgrade - logout - login =). the powerdevil KCM corectly has screen brigtness slider, so issue is exposed only here... Kai Uwe Broulik wrote: Please test whether https://git.reviewboard.kde.org/r/121364/ together with https://git.reviewboard.kde.org/r/121365/ help in your situation. Hrvoje Senjan wrote: nope, no change. aditionally, with that patches, i get kded5 murdering the CPU... i am now guessing the problem with me is that helper is used, and not XRandrBrightness - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71445 --- On Dec. 5, 2014, 10:06 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- (Updated Dec. 5, 2014, 10:06 p.m.) Review request for Plasma and Solid. Repository: plasma-workspace Description --- Now that we can finally use absolute brightness values, rather than a fixed 0-100% range, those values should be exposed in the dataengine instead. This allows us to eg. properly handle keyboard brightness controls which usually have just a few steps. I adjusted battery monitor accordingly. It also cleans up the code by moving stuff into lambdas and gets rid of the ugly availability stuff by just relying on the maximum values to determin whether it's available. We still don't have means, though, to detect changes in these at runtime. Diffs - dataengines/powermanagement/powermanagementengine.h ffad13e dataengines/powermanagement/powermanagementengine.cpp 04aa49b dataengines/powermanagement/powermanagementjob.cpp c4e4510 Diff: https://git.reviewboard.kde.org/r/121355/diff/ Testing --- Works as expected, I need someone without keyboard or screen brightness to test the availability. File Attachments Battery monitor with keyboard https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121355: Expose actual and maximum brightness value in dataengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71445 --- i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway - Hrvoje Senjan On Dec. 5, 2014, 10:06 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- (Updated Dec. 5, 2014, 10:06 p.m.) Review request for Plasma and Solid. Repository: plasma-workspace Description --- Now that we can finally use absolute brightness values, rather than a fixed 0-100% range, those values should be exposed in the dataengine instead. This allows us to eg. properly handle keyboard brightness controls which usually have just a few steps. I adjusted battery monitor accordingly. It also cleans up the code by moving stuff into lambdas and gets rid of the ugly availability stuff by just relying on the maximum values to determin whether it's available. We still don't have means, though, to detect changes in these at runtime. Diffs - dataengines/powermanagement/powermanagementengine.h ffad13e dataengines/powermanagement/powermanagementengine.cpp 04aa49b dataengines/powermanagement/powermanagementjob.cpp c4e4510 Diff: https://git.reviewboard.kde.org/r/121355/diff/ Testing --- Works as expected, I need someone without keyboard or screen brightness to test the availability. File Attachments Battery monitor with keyboard https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121355: Expose actual and maximum brightness value in dataengine
On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: i've lost brightness control in battery monitor after this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway Kai Uwe Broulik wrote: Please update your plasma-workspace, I've adjusted battery monitor accordingly. Kai Uwe Broulik wrote: Oh, umm, sorry, misread that. What's the value of Maximum Screen Brightness in the dataengine? Make sure you've restarted kded and plasma. this happened (noticed it) after upgrade - logout - login =). the powerdevil KCM corectly has screen brigtness slider, so issue is exposed only here... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71445 --- On Dec. 5, 2014, 10:06 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- (Updated Dec. 5, 2014, 10:06 p.m.) Review request for Plasma and Solid. Repository: plasma-workspace Description --- Now that we can finally use absolute brightness values, rather than a fixed 0-100% range, those values should be exposed in the dataengine instead. This allows us to eg. properly handle keyboard brightness controls which usually have just a few steps. I adjusted battery monitor accordingly. It also cleans up the code by moving stuff into lambdas and gets rid of the ugly availability stuff by just relying on the maximum values to determin whether it's available. We still don't have means, though, to detect changes in these at runtime. Diffs - dataengines/powermanagement/powermanagementengine.h ffad13e dataengines/powermanagement/powermanagementengine.cpp 04aa49b dataengines/powermanagement/powermanagementjob.cpp c4e4510 Diff: https://git.reviewboard.kde.org/r/121355/diff/ Testing --- Works as expected, I need someone without keyboard or screen brightness to test the availability. File Attachments Battery monitor with keyboard https://git.reviewboard.kde.org/media/uploaded/files/2014/12/04/c00db2e1-5278-4a1b-bd32-ff36777b91c6__batterykeyboardsteps.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121259: [oxygen] fix kde4 build/configure/cmake stage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121259/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen Description --- it's used unconditionally since r121083 Diffs - CMakeLists.txt b7cfc8e Diff: https://git.reviewboard.kde.org/r/121259/diff/ Testing --- KF5 and kde4 builds succeed Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121259: [oxygen] fix kde4 build/configure/cmake stage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121259/ --- (Updated Nov. 26, 2014, 7:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen Description --- it's used unconditionally since r121083 Diffs - CMakeLists.txt b7cfc8e Diff: https://git.reviewboard.kde.org/r/121259/diff/ Testing --- KF5 and kde4 builds succeed Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
On Nov. 11, 2014, 11:43 p.m., Hrvoje Senjan wrote: 5.1.1 out. should 5(.1.x) be targeted at all? Thomas Lübking wrote: As this is now a straightforward port of what there is in KDE SC 4 and DrKonqui is atm. useless and crashreports for KF/5 currently suck in 80% of all cases (not the users fault - they say crash and post the shell output ;-) I clearly vote for pushing it into 5.1 Findings on whether a certain method can be hardcoded and other improvements then would point 5.2 or whatever else. I'm however not sure whether we should abandon the bugzilla version check + depending security stuff so easily. Once because as Ian mentioned there might be interest in extending KCrash to allow different bugzilla servers (evtl. even move it to Tier1). And also because one cannot be sure that bugzilla does not jump onto yet another security bandwagon with the release after the next one. thanks. unless then someone yells not to push, will commit in a few hours. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/#review70263 --- On Oct. 29, 2014, 9:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Oct. 29, 2014, 9:41 p.m.) Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f Diff: https://git.reviewboard.kde.org/r/120876/diff/ Testing --- builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Nov. 12, 2014, 6:57 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f Diff: https://git.reviewboard.kde.org/r/120876/diff/ Testing --- builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/#review70263 --- 5.1.1 out. should 5(.1.x) be targeted at all? - Hrvoje Senjan On Oct. 29, 2014, 9:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Oct. 29, 2014, 9:41 p.m.) Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f Diff: https://git.reviewboard.kde.org/r/120876/diff/ Testing --- builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121025: fix build, Kdelibs4Migration header is only available and used on kf5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121025/#review69955 --- kstyle/config/oxygenstyleconfig.cpp https://git.reviewboard.kde.org/r/121025/#comment48939 shouldn't it be reverse? - Hrvoje Senjan On Nov. 6, 2014, 11:13 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121025/ --- (Updated Nov. 6, 2014, 11:13 p.m.) Review request for Plasma. Repository: oxygen Description --- fix build, Kdelibs4Migration header is only available and used on kf5 Diffs - kstyle/config/oxygenstyleconfig.cpp 750b490f08e8c1e3a9d41e229391dfb16c936b41 Diff: https://git.reviewboard.kde.org/r/121025/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120936: [KInfoCenter] Set the correct version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/ --- (Updated Nov. 6, 2014, 1 a.m.) Review request for Plasma. Changes --- sorry for latish reply, i forgot about this review. adjusted patch now to use suggested approach. Repository: kinfocenter Description --- bonus - dropped dep on plasma-framework Diffs (updated) - CMakeLists.txt b30a581 Modules/infosummary/CMakeLists.txt 5ae1faf Modules/infosummary/infosum.cpp 7330036 config-workspace.h.cmake 66c1d63 Diff: https://git.reviewboard.kde.org/r/120936/diff/ Testing --- yes Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120936: [KInfoCenter] Set the correct version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/ --- (Updated Nov. 6, 2014, 7:59 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kinfocenter Description --- bonus - dropped dep on plasma-framework Diffs - CMakeLists.txt b30a581 Modules/infosummary/CMakeLists.txt 5ae1faf Modules/infosummary/infosum.cpp 7330036 config-workspace.h.cmake 66c1d63 Diff: https://git.reviewboard.kde.org/r/120936/diff/ Testing --- yes Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
On Oct. 30, 2014, 11:39 a.m., Ian Wadham wrote: The following ideas are concerns about design, rather than coding. I do not know what the underlying objectives of Frameworks are, including who is intended to use it and for what, so I will be guided by you and Thomas and the Frameworks team. IF Frameworks is for use in KDE software only and IF the bugs.kde.org database is the same for all users of KDE software world-wide (both KDE 4 and KF 5) and will never go back to using cookies, THEN you can actually dispense with all the Bugzilla version-checking code in the current patch and all the security methods except for UsePasswords. This is because UsePasswords has actually been supported since Bugzilla version 3.2 (i.e. since before the UseCookies version of Bugzilla [4.3.x] which KDE software had in June/July and before). I spotted this potential simplification late in the https://git.reviewboard.kde.org/r/120431/ process: too late to bring it up at that point. It is, in fact, why I was able to test UsePasswords mode... :-) OTOH, IF Frameworks is also for use in non-KDE software (presumably based on Qt), THEN you need to keep the version checking, because you probably cannot know what database and Bugzilla version that other software might prefer to use. This scenario can happen. I saw an enquiry by a FOSS developer only recently (on one of the Apple FOSS lists I think). He liked KCrash and Dr Konqi, wanted to use them in his own software package and was asking what might be involved. In both potential uses of Frameworks, you can dispense with the UseTokens security method altogether and go straight to UsePasswords. At first reading, I thought that was what you had done in your original patch, Hrvoje... :-) So you could have UseCookies and UsePasswords --- or just UsePasswords. Also you can, I think, drop the call to Bugzilla's login when using UsePasswords mode. Support for login calls will be discontinued in a future version of Bugzilla (after 4.5.0). I do not think you need a login call if you are sending a user name and password with every database update call. If I am right about that, dropping the login call will give Dr K even more future-proofing against currently announced Bugzilla changes. Of course, you will still need a login dialog or some way to get a username and password, from KWallet or whatever... I wrote a message about this stuff and it was forwarded to the k-f-d list recently (I am not subscribed there). Did you see it? You might also be able to strip out the Dr Konqi code that checks if the KCookieJar is available, or make it conditionally compiled. You could avoid a few more of Dr Konqi's dependencies that way. Finally, whatever you decide, it would be good to keep the basics of the Bugzilla-version-checking code, in case of other announced changes to Bugzilla software in the future. I am thinking particularly of changes to the database schema, call parameters, return values, etc. as Bugzilla evolves. I do not know what the underlying objectives of Frameworks are, including who is intended to use it and for what, so I will be guided by you and Thomas and the Frameworks team. Frameworks are just more/less splitted, fine grained kdelibs + bits pieces from kde-runtime, with relevant features pushed to upstream Qt. I wrote a message about this stuff and it was forwarded to the k-f-d list recently (I am not subscribed there). Did you see it? I did not, but i shall check the archives. Just to be clear, i am not working on DrKonqi in the KF5/Plasma 5 world - i just wanted to have DrKonqi in that world functional again. Hence, it would be nice if someone approves until 5.1.1 tagging. We can take a look at the design for the code in master, there is no hurry ;-) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/#review69516 --- On Oct. 29, 2014, 9:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Oct. 29, 2014, 9:41 p.m.) Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 drkonqi/bugzillaintegration
Review Request 120936: [KInfoCenter] Set the correct version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/ --- Review request for Plasma. Repository: kinfocenter Description --- bonus - dropped dep on plasma-framework Diffs - CMakeLists.txt 6c1dd1d Modules/infosummary/CMakeLists.txt 5ae1faf Modules/infosummary/infosum.cpp e58beb0 Diff: https://git.reviewboard.kde.org/r/120936/diff/ Testing --- yes Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
