D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd updated this revision to Diff 58698.
smithjd added a comment.


  - [Plasma Search KCM] Re-organize the tab and widget layouts.
  - Add edit actions.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15341?vs=41183=58698

BRANCH
  master-krunnerkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15341

AFFECTED FILES
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Allow modifying the keyboard shortcuts.

[James Smith]

smithjd updated this revision to Diff 58697.
smithjd added a comment.


  - [KRunner] Change start of line shortcut to CTRL + S.
  - [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.
  - Make edit actions configurable.
  - Follow standard shortcuts nomenclature.
  - Fix clear action.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14739?vs=41182=58697

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/view.cpp
  krunner/view.h
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15684: DateTime Runner timezone and 24 hour clock time conversion.

[James Smith]

smithjd added a comment.


  Timezone name expansion and multiple matches:
  F6561200: Screenshot_20190121_164314.png 

  
  24-hr conversion and multiple matches:
  F6561199: Screenshot_20190121_164852.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D15684

To: smithjd, #plasma, mart
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15684: DateTime Runner timezone and 24 hour clock time conversion.

[James Smith]

smithjd updated this revision to Diff 49976.
smithjd added a comment.


  - [DateTime Runner] Add from-zone, to-zone and 24-hour time conversion. 
Improve timezone lookups (i.e. identical zone names now return all matches). 
The zone name is now used instead of the abbreviation in matches.
  - Rebase to current master.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15684?vs=46297=49976

BRANCH
  master-timeconverter (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15684

AFFECTED FILES
  runners/datetime/datetimerunner.cpp
  runners/datetime/datetimerunner.h

To: smithjd, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15684: DateTime Runner timezone and 24 hour clock time conversion.

[James Smith]

smithjd updated this revision to Diff 46297.
smithjd added a comment.


  Rebase around multiple zone matching, and some improvements.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15684?vs=43091=46297

BRANCH
  master-timeconverter (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15684

AFFECTED FILES
  runners/datetime/datetimerunner.cpp
  runners/datetime/datetimerunner.h

To: smithjd, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15684: DateTime Runner timezone and 24 hour clock time conversion.

[James Smith]

smithjd updated this revision to Diff 43091.
smithjd added a comment.


  - [DateTime Runner] Show a date match if needed on conversion both to and 
from local

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15684?vs=42274=43091

BRANCH
  master-timeconverter (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15684

AFFECTED FILES
  runners/datetime/datetimerunner.cpp
  runners/datetime/datetimerunner.h

To: smithjd, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

[James Smith]

smithjd added a comment.


  > A slightly smarter approach would be for Plasma Vaults itself to add such a 
rule for whatever mountpoint is chosen during new vault creation.
  
  What about exposing these config options on dbus? 
("includeFolders"),("excludeFolders")
  
  That would make for 4 new entries (add/remove for each) on the 
org.kde.baloo.main interface.

TASK DETAIL
  https://phabricator.kde.org/T8066

To: michaelh, smithjd
Cc: ngraham, smithjd, bruns, nicolasfella, ivan, plasma-devel, alexeymin, 
michaelh, ashaposhnikov, astippich, spoorun, abrahams

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

[James Smith]

smithjd added a comment.


  What's wrong with a .balooignore file in the root of the vault? Tracker uses 
.trackerignore.

TASK DETAIL
  https://phabricator.kde.org/T8066

To: michaelh, smithjd
Cc: smithjd, bruns, nicolasfella, ivan, plasma-devel, alexeymin, michaelh, 
ashaposhnikov, astippich, spoorun, abrahams

D15684: DateTime Runner timezone and 24 hour clock time conversion.

[James Smith]

smithjd updated this revision to Diff 42274.
smithjd added a comment.


  - [DateTime Runner] Add two new syntaxes for conversion to and from 24 hour 
time.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15684?vs=42113=42274

BRANCH
  master-timeconverter (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15684

AFFECTED FILES
  runners/datetime/datetimerunner.cpp
  runners/datetime/datetimerunner.h

To: smithjd, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15684: DateTime Runner timezone and 24 hour clock time conversion.

[James Smith]

smithjd created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
smithjd requested review of this revision.

REVISION SUMMARY
  Convert time to and from other time zones. Report time in 24 hr time.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master-timeconverter (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15684

AFFECTED FILES
  runners/datetime/datetimerunner.cpp
  runners/datetime/datetimerunner.h

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#323730 , @ngraham wrote:
  
  > In D15341#323715 , @smithjd 
wrote:
  >
  > > KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.
  >
  >
  > Can you explain why the fact that KRunner does more than the search fields 
in Kicker/Kickoff and Dolphin is a justification for allowing you to customize 
a small subset of the navigation shortcuts there, but not elsewhere? Help me 
understand where you're coming from. If you'd want to use [ctrl] + [e] and 
[ctrl] + [s]  (etc.) to navigate in KRunner, why wouldn't you want to use them 
elsewhere too? What's the difference?
  
  
  Global in-application shortcuts can already be customized. The problem is 
that often the desired shortcut is already assigned to some other action, such 
as Ctrl+S for saving across all applications. Reassigning Ctrl+S **globally** 
just for one application is terrible from a HIG perspective, so an 
application-specific override must be considered. A welcome side-effect from 
this is the large number of shortcuts now available to KRunner that don't 
impact global actions.
  
  In KRunner a larger percentage of the functionality is derived of text input, 
Dolphin / Kicker / Kickoff aren't similar to bash / KRunner in this regard and 
so wouldn't benefit as much from configurable input navigation shortcuts. The 
global shortcuts will still have the same actions as other applications unless 
the global shortcut is used for a KRunner action.
  
  IMO, this feature should already be a part of KRunner, though it hasn't had 
an outstanding absence. The notion that global shortcuts should be shuffled for 
a single application is wrong. Changing the global shortcut for the same 
//type// of input navigation may suit the user, though this shouldn't be 
encouraged for only a single application. Promoting global shortcuts over an 
application-specific configureability is always wrong, and less right when 
there's already a patch. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#323704 , @ngraham wrote:
  
  > In D15341#323672 , @smithjd 
wrote:
  >
  > > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  >
  >
  >
  >
  > 1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, 
with the exception that they have a semi-hardcoded list of enabled runners.
  > 2. Not sure how that would make a difference anyway; the point is, if these 
navigation shortcuts are valuable for the KRunner input field, why wouldn't 
they be useful for every input field?
  
  
  KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#322618 , @ngraham wrote:
  
  > I appreciate the patch and the fact that you considered the prior comments 
in D14739 . But I must admit I'm still left 
with a nagging question: "Why?"
  >
  > Why here? Why not elsewhere? How about the search field in Kicker and 
Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be 
done everywhere? And if it can't be done everywhere due to conflicts (i.e. 
because [ctrl] + [a] and [ctrl] + [s] have existing meanings in GUI software), 
then should it be done at all?
  
  
  Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  
  > It just seems sort of random to add this very heavyweight configuration UI 
here in the KCM to change shortcuts for KRunner that basically nobody but you 
would ever want to change. :) > Pretty much the only KRunner-related shortcut 
that your average user might actually want to change in the KCM is the 
activation shortcut, and that's not here--though I would be happy to > see a 
patch to add just that on the main page, without adding another tab. If we 
absolutely must add alternative hidden power user CLI-inspired navigation 
shortcuts to KRunner (which I'm > not yet convinced on), let's just do it, and 
not wrap it in a whole bunch of user-visible configuration UI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
smithjd requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master-krunnerkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15341

AFFECTED FILES
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd updated this revision to Diff 41182.
smithjd added a comment.


  - [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14739?vs=39467=41182

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/view.cpp
  krunner/view.h
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd abandoned this revision.
smithjd added a comment.


  Closing this because it breaks at least the settings:// ioslave, and the 
tags:// slave no longer has urls attached to the filename.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd added a comment.


  In D13291#314199 , @bruns wrote:
  
  > In D13291#314195 , @smithjd 
wrote:
  >
  > > kioclient5 ls settings:/
  > > system-administration
  > >
  > > dolphin settings:/
  > >  System Administration
  >
  >
  > In dolphin, you can click on "System Administration". With kioclient5, I 
can use `kioclient5 ls settings:/system-administration` (dito for dolphin). 
Does this still work after your change?
  
  
  No.
  
  "The file or folder System Administration does not exist."
  
  This used to work for the Baloo tags:// ioslave, though it's less useful for 
that now that the slave no longer appends the full url to the filename. The 
working command was something like kioclient5 cp tags:/foo/. ~/bar. This 
successfully duplicated the tagged files and tag folder structure. I can't 
remember if I tested a single file, though if you needed a single file you 
probably wouldn't be digging in the tags:// ioslave anyway...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd added a comment.


  kioclient5 ls settings:/
  system-administration
  
  dolphin settings:/
  System Administration

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  Perhaps the intent of this patch could change to adding a KShortcutsDialog to 
the kcm where the MOVETOSTARTOFLINE and MOVETOENDOFLINE keyboard shortcuts 
could be reassigned?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  In D14739#306749 , @davidedmundson 
wrote:
  
  > We also have
  >
  > system settings -> shortcuts -> standard shortcuts
  >
  > These can have alternatives which would work for this. I don't know if 
these work with QQC2 TextFields, we should fix it if not. Setting alternatives 
would require unsetting 2 existing default application shortcuts, leaving 
CTRL-S and CTRL-E unavailable for default actions for other applications. 
Setting alternatives works for textFields.
  >
  > Thanks for kconfig magic you can override them (without a gui) on a per-app 
basis albeit there's no UI for that.
  
  
  I can't seem to find any information on this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  Most of the keys on that side of the keyboard are already bound globally into 
combos, so the best solution IMO is to intercept the required keycombos in 
KRunner instead of having to rearrange the global app keycombos around KRunner. 
This is what this patch does to implement bash-style cursor jumps in KRunner, 
though this is not so great on the HIG front as the intercepted combos are both 
standard application shortcuts, also duplicating the standard application 
shortcuts for beginning of line / end of line.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  Yes, except the CTRL + S combo is default for save in other applications, 
with no easy way I can think of to reassign it for just KRunner.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  I now see that KDE has default application shortcuts for beginning of line 
and end of line (HOME and END) and skip word forwards or backwards (CTRL + 
RARROW/LARROW), that also work in KRunner, that should obsolete this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  I tend to frequenty hit additional keys while not watching the runner window. 
Although the shortcut is no longer in common with Bash (the CTRL + S shortcut 
would also have made more sense for Bash) the idea is the same. You can already 
do this from the keyboard, but it requires a select all keycombo AND an arrow 
key each time you need to jump forward or backwards.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd updated this revision to Diff 39467.
smithjd added a comment.


  - [KRunner] Change start of line shortcut to CTRL + S.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14739?vs=39437=39467

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
smithjd requested review of this revision.

REVISION SUMMARY
  CTRL + A moves the cursor to the beginning of the text entry,
  CTRL + E moves it to the end.

TEST PLAN
  Open KRunner, enter some text. Check if CTRL + A moves the
  cursor to before the first character in the textfield. Next, check if 
  CTRL + E moves the cursor back to the empty space after the text.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13291: Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
smithjd requested review of this revision.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master-lsfix

REVISION DETAIL
  https://phabricator.kde.org/D13291

AFFECTED FILES
  kioclient/kioclient.cpp

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

(Updated Jan. 16, 2016, 5:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit d11c7535bafe7a9bae2d72ab003da77137a22b8f by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Add clearActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

[James Smith]

> On Jan. 15, 2016, 1:54 a.m., David Edmundson wrote:
> > do you have commit access?

no.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91122
---


On Jan. 15, 2016, 1:52 a.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 15, 2016, 1:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add clearActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126742: Add removeAllActions() to remove every applet interface action.

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Add removeAllActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 
ad6849990789e0f960ff074e1a9db21ef64381ef 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 
8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

[James Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

(Updated Jan. 15, 2016, 1:52 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

removeAllActions() ->clearActions().


Summary (updated)
-

Add clearActions() to remove every applet interface action.


Repository: plasma-framework


Description (updated)
---

Add clearActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs (updated)
-

  src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel