from:"John Salatas"

Night Color Widget (Redshift Control Widget adapt to kwin's Night Color)

2019-10-24 Thread John Salatas


Hey guys!

I was thinking about resurrecting the Redshift Control Widget, as 
apparently there are users (including me) that find it very convenient 
to be able to enable/disable Night Color with just a click.


Anyway I have some questions that I hope you might be able to 
answer. Currently Redshift Control Widget interacts with the redshift 
command through cli commands using an executable datasource engine [1]. 
Given the fact that kwin exposes a dbus interface for the Night Color 
functionality [2], I was thinking that the most straightforward approach 
would be to change the cli commands executed by the executable 
datasource engine and instead of interacting with the redshift command, 
I could use something like qdbus [3], or dbus-send [4] to send messages 
to the kwin's DBus interface.


So my first question is whether I'm right with the above approach. Might 
it be better to communicate with the DBus at some other way? How? Can 
you point me to some documentation, or example implementation?


Furthermore, in case that I want to call setNightColorConfig which 
requires a QHash argument [5], how can I encode it 
for either qdbus or dbus-send?


Finally, I'm not sure if it is better to just create a new git repo and 
create a new widget from scratch borrowing/duplicating most of the 
existing code, or if it is better to continue with the existing 
repo/code and rename the widget from Redshift Control Widget to Night 
Color Widget, or whatever! (btw I'm one of the maintainers of Redshift 
Control Widget) :\


Thank you in advance!

John Salatas


References

[1] 
https://phabricator.kde.org/source/plasma-redshift-control/browse/master/package/contents/ui/main.qml$123


[2] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h


[3] https://manpages.ubuntu.com/manpages/bionic/en/man1/qdbus.1.html

[4] https://dbus.freedesktop.org/doc/dbus-send.1.html

[5] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h$97

Night Color Widget (adapt Redshift Control Widget to kwin's Night Color functionality)

2019-10-24 Thread John Salatas


Hey guys!

I was thinking about resurrecting the Redshift Control Widget, as 
apparently there are users (including me) that find it very convenient 
to be able to enable/disable Night Color with just a click.


Anyway I have some questions that I hope you might be able to 
answer. Currently Redshift Control Widget interacts with the redshift 
command through cli commands using an executable datasource engine [1]. 
Given the fact that kwin exposes a dbus interface for the Night Color 
functionality [2], I was thinking that the most straightforward approach 
would be to change the cli commands executed by the executable 
datasource engine and instead of interacting with the redshift command, 
I could use something like qdbus [3], or dbus-send [4] to send messages 
to the kwin's DBus interface.


So my first question is whether I'm right with the above approach. Might 
it be better to communicate with the DBus at some other way? How? Can 
you point me to some documentation, or example implementation?


Furthermore, in case that I want to call setNightColorConfig which 
requires a QHash argument [5], how can I encode it 
for either qdbus or dbus-send?


Finally, I'm not sure if it is better to just create a new git repo and 
create a new widget from scratch borrowing/duplicating most of the 
existing code, or if it is better to continue with the existing 
repo/code and rename the widget from Redshift Control Widget to Night 
Color Widget, or whatever! (btw I'm one of the maintainers of Redshift 
Control Widget) :\


Thank you in advance!

John Salatas


References

[1] 
https://phabricator.kde.org/source/plasma-redshift-control/browse/master/package/contents/ui/main.qml$123


[2] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h


[3] https://manpages.ubuntu.com/manpages/bionic/en/man1/qdbus.1.html

[4] https://dbus.freedesktop.org/doc/dbus-send.1.html

[5] 
https://phabricator.kde.org/source/kwin/browse/master/colorcorrection/colorcorrectdbusinterface.h$97

D17249: Preserve screen colour doesn't work as expected

2019-03-06 Thread John Salatas

This revision was automatically updated to reflect the committed changes.
Closed by commit R885:1e2a920633d7: Preserve screen colour doesnt work as 
expected (authored by jsalatas).

REPOSITORY
  R885 Redshift Control for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17249?vs=46524=53324

REVISION DETAIL
  https://phabricator.kde.org/D17249

AFFECTED FILES
  package/contents/ui/main.qml

To: jsalatas, #plasma, martinkostolny, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17249: Preserve screen colour doesn't work as expected

2019-02-26 Thread John Salatas

jsalatas added a comment.


  ping? :)

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17249

To: jsalatas, #plasma, martinkostolny
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17249: Preserve screen colour doesn't work as expected

2018-11-29 Thread John Salatas

jsalatas created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jsalatas requested review of this revision.

REVISION SUMMARY
  If you are using a  custom icc profile, this should be restored during day 
time.
  
  see also 
  https://github.com/kotelnik/plasma-applet-redshift-control/issues/54

TEST PLAN
  Tested in my PC. Works as expected.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17249

AFFECTED FILES
  package/contents/ui/main.qml

To: jsalatas
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

2017-02-25 Thread John Salatas

jsalatas added a comment.


  In https://phabricator.kde.org/D4491#89982, @anthonyfieroni wrote:
  
  > ElideMiddle on basic regex match for path
  
  
  I like the idea but ElideMiddle doesn't seem to work for me: Seems that it 
just keeps the left part of the text that it can fit and ignores anything else 
:\
  
  F2613693: Screenshot_20170225_231250.png 

  
  PS: I know about docker but still prefer VMs :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma:_design, #plasma, hein, subdiff
Cc: jsalatas, markg, broulik, subdiff, hein, plasma-devel, davidedmundson, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Changed Subscribers] D4491: Let make taskmanager tooltip readable again

2017-02-25 Thread John Salatas

jsalatas added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:108
>  height: undefined
> +maximumLineCount: 2
>  elide: Text.ElideRight

Is it possible to have it always fixed to 2 lines and not just max to 2? 
Otherwise having either 1 or 2 line we would end up in unaligned/bad-looking 
tooltips (see screenshot), although I guess I can live with this :)

F2612301: Screenshot_20170225_185007.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma:_design, #plasma, hein, subdiff
Cc: jsalatas, markg, broulik, subdiff, hein, plasma-devel, davidedmundson, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4800: [Task Manager] text elide doesn't work for Tooltips

2017-02-25 Thread John Salatas

jsalatas added a comment.


  In https://phabricator.kde.org/D4800#89954, @subdiff wrote:
  
  > Removing the undefineds increases the margins between the lines again. 
@anthonyfieroni had another fix for the elide a few days ago by setting the 
maximumLineCount property. He hadn't yet pushed it though. I would go for his 
solution if it retains the margins. You could try if it works for you as well. 
It's the last revision of https://phabricator.kde.org/D4491.
  
  
  Yeap! I guess the result is the same to the one I want to achieve.
  
  Thanks for mentioning it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4800

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #vdg, anthonyfieroni, subdiff
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Abandoned] D4800: [Task Manager] text elide doesn't work for Tooltips

2017-02-25 Thread John Salatas

jsalatas abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4800

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #vdg, anthonyfieroni, subdiff
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Commented On] D4800: [Task Manager] text elide doesn't work for Tooltips

2017-02-25 Thread John Salatas

jsalatas added a comment.


  If you agree, I believe this should be committed to 5.9 branch and not wait 
until 5.10.
  
  Please confirm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4800

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #vdg, anthonyfieroni, subdiff
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 3 lines] D4800: [Task Manager] text elide doesn't work for Tooltips

2017-02-25 Thread John Salatas

jsalatas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Seems that `height: undefined` cause the elide not to work in the Tooltip 
headings

TEST PLAN
  Before
  F2611512: before.png 
  
  After
  F2611516: after.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4800

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #vdg, anthonyfieroni, subdiff
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Closed] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-19 Thread John Salatas

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:1858d6fafb58: Consistent conversion from/to cursor to/from 
coordinates (authored by jsalatas).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4538?vs=11494=11507

REVISION DETAIL
  https://phabricator.kde.org/D4538

AFFECTED FILES
  autotests/src/kateview_test.cpp
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma, #ktexteditor, cullmann
Cc: brauch, cullmann, plasma-devel, kwrite-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated, 26 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-18 Thread John Salatas

jsalatas updated this revision to Diff 11494.
jsalatas added a comment.


  1. I abandoned the 3rd issue I mention in the summary about the line 
`scrollPos(max, max.column(), calledExternally);` as I could neither verify nor 
disprove if this was intended or not.
  
  2. In `cursorToCoordinate()` I added an extra check to see if we are behind 
end of line and return and invalid point (-1, -1):
  
if (cursor.column() > layout.lineLayout().textLength()) {
return QPoint(-1, -1);
}
  
  as according to QT's documentation 
(http://doc.qt.io/qt-5/qtextline.html#cursorToX)
  
  > If cursorPos is not a valid cursor position, the nearest valid cursor 
position will be used instead, and cursorPos will be modified to point to this 
valid cursor position.
  
  and without this extra check, the "behind end of line should give an invalid 
cursor" tests in kateview_test.cpp would fail.
  
  3. I also added the relevant tests to kateview_test.cpp, as per cullmann's 
feedback.
  
  4. KDevelop seems to work.
  
  I have checked it and I didn't see any issues to the Navigation Widget popup 
tooltips which indeed seems to extensively use coversions between cursors and 
coordinates, as mentioned by brauch. Furthermore:
  
  - cursorPositionCoordinates isn't used in kdevelop and kdevplatform, so the 
2nd issue described in the summary shouldn't affect kdevelop and kdevplatform 
in any way.
  - 1st issue in the summary is related to cursors/positions at the end of 
line, so my intuition suggests that it wouldn't be related to any context 
related to kdevelop. :)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4538?vs=11137=11494

REVISION DETAIL
  https://phabricator.kde.org/D4538

AFFECTED FILES
  autotests/src/kateview_test.cpp
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma, #ktexteditor
Cc: brauch, cullmann, plasma-devel, kwrite-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-14 Thread John Salatas

jsalatas added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma, #ktexteditor
Cc: plasma-devel, kwrite-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-09 Thread John Salatas

jsalatas updated the summary for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #frameworks, #plasma
Cc: plasma-devel, kwrite-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 6 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

2017-02-09 Thread John Salatas

jsalatas created this revision.
jsalatas added reviewers: Frameworks, Plasma.
jsalatas set the repository for this revision to R39 KTextEditor.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: kwrite-devel, plasma-devel.

REVISION SUMMARY
  This patch addresses 3 issues
  
  1. Currently if you try to convert the cursor to coordinates and then convert 
these coordinates back to a cursor again, it produces an invalid cursor (-1, 
-1) when the original cursor is located at the end of line
  
  2. Converting back to cursor coordinates that have been produced by 
`cursorToCoordinate(view->cursorPosition())` and 
`coordinatesToCursor(view->cursorPositionCoordinates())` doesn't always produce 
the same results as the `includeBorder` option doesn't seem to be used 
consistently.
  
  3. Although I cannot find a test case for this, it doen't seem to make any 
sense the line `scrollPos(max, max.column(), calledExternally);` in 
`KateViewInternal::makeVisible` function.   Was it supposed to be that way (ie 
force when the last line is not empty and not force when it is), or is it just 
a typo? :\  I would appreciate any reasoning about this!

TEST PLAN
  1. Create a new app with a single `KTextEditor::View` widget (similar to 
kwrite).
  
  2. connect the view's `cursorPositionChanged` signal with a slot in the 
window which contains the following code
  
qDebug() << " original cursor" << view->cursorPosition();
QPoint p1 = view->cursorToCoordinate(view->cursorPosition());
KTextEditor::Cursor c1 = view->coordinatesToCursor(p1);
qDebug() << "converted cursor" << c1;
qDebug() << "converted cursor 2" << 
view->coordinatesToCursor(view->cursorPositionCoordinates());
  
  
  
  3. Run the application and start typing (I typed 52 characters in the first 
line) and then pressed the  key sometimes)
  
  4. Press Back Arrow key until you are in the beginning of the document.
  
  In steps 3 and 4 the three cursors are the same (this wasn't the case before).
  
  Before you get something like the following
  
original cursor (0, 1)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 2)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 3)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 4)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 5)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 6)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 7)
converted cursor (-1, -1)
..
 original cursor (0, 48)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 49)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 50)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 51)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 52)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (1, 0)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (2, 0)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (3, 0)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
.
 original cursor (0, 52)
converted cursor (-1, -1)
converted cursor 2 (-1, -1)
 original cursor (0, 51)
converted cursor (0, 51)
converted cursor 2 (-1, -1)
 original cursor (0, 50)
converted cursor (0, 50)
converted cursor 2 (-1, -1)
 original cursor (0, 49)
converted cursor (0, 49)
converted cursor 2 (-1, -1)
 original cursor (0, 48)
converted cursor (0, 48)
converted cursor 2 (-1, -1)
 original cursor (0, 47)
converted cursor (0, 47)
converted cursor 2 (0, 51)
 original cursor (0, 46)
converted cursor (0, 46)
converted cursor 2 (0, 50)
 original cursor (0, 45)
converted cursor (0, 45)
converted cursor 2 (0, 49)
 original cursor (0, 44)
converted cursor (0, 44)
converted cursor 2 (0, 48)
 original cursor (0, 43)
converted cursor (0, 43)
converted cursor 2 (0, 47)
 original cursor (0, 42)
converted cursor (0, 42)
converted cursor 2 (0, 46)
 original cursor (0, 41)
converted cursor (0, 41)
converted cursor 2 (0, 45)
.
 original cursor (0, 6)
converted cursor (0, 6)
converted cursor 2 (0, 10)
 original cursor (0, 5)
converted cursor (0, 5)
converted cursor 2 (0, 9)
 original cursor (0, 4)
converted cursor (0, 4)
converted cursor 2 (0, 8)
 original cursor (0, 3)
converted cursor (0, 3)
converted cursor 2 (0, 7)
 original cursor (0, 2)
converted cursor (0, 2)
converted cursor 2 (0, 6)
 original cursor (0, 1)
converted

[Differential] [Commented On] D4197: Delete KCModule before deleting QApplication

2017-01-18 Thread John Salatas

jsalatas added a comment.


  Seems to work.
  
  It also fixes another (maybe related) issue in network mananager:
  
  1. Right Click the nm applet and choose "Configure Network Connections"
  2. Click "Add new connection"
  3. Having the "Choose a connection type" window open, click "Cancel" on the 
main configuration window.
  
  Without this patch, trying to open nm's configuration settings again, doesn't 
work and you get the following error
  
  "kcmshell5 with modules ' "org.kde.kcmshell_kcm_networkmanagement.desktop" ' 
is already running."
  
  The patch proposed here seems to fix it.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D4197

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: jsalatas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D4181: Sonnet: segfault in trigrams generation

2017-01-18 Thread John Salatas

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and 
expose MAXGRAMS constant in the header (authored by jsalatas).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4181?vs=10308=10336

REVISION DETAIL
  https://phabricator.kde.org/D4181

AFFECTED FILES
  data/CMakeLists.txt
  data/gentrigrams.cpp
  src/core/guesslanguage.cpp
  src/core/guesslanguage.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, mart
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 14 lines] D4181: Sonnet: segfault in trigrams generation

2017-01-17 Thread John Salatas

jsalatas created this revision.
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to R246 Sonnet.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This patch fixes a Segmentation fault in trigrams generation when weeding out 
trigrams.
  
  I also moved the MAXGRAMS constant to the header file, just for consistency 
(gentrigrams.cpp had a hardoced value of 300).

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D4181

AFFECTED FILES
  data/CMakeLists.txt
  data/gentrigrams.cpp
  src/core/guesslanguage.cpp
  src/core/guesslanguage.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Abandoned] D4153: Network manager configuration model is unreadable

2017-01-16 Thread John Salatas

jsalatas abandoned this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

2017-01-16 Thread John Salatas

jsalatas added a comment.


  BTW: I don't know how I did it but while testing it, at some point 
configuration didn't open at all and plasma produced the following error
  
  "kcmshell5 with modules ' "org.kde.kcmshell_kcm_networkmanagement.desktop" ' 
is already running."
  
  I cannot reproduce it and it may be related to the crash that happens from 
time to time when you close the configuration window :\

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

2017-01-16 Thread John Salatas

jsalatas added a comment.


  In https://phabricator.kde.org/D4153#77549, @jgrulich wrote:
  
  > Icons problem solved F2049814: kcm.patch 
. Can you please test this patch?
  
  
  Perfect :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

2017-01-15 Thread John Salatas

jsalatas added a comment.


  In https://phabricator.kde.org/D4153#77525, @jgrulich wrote:
  
  > I'm trying to get rid of Plasma QML components so it uses same colors which 
are used by the rest of application.
  
  
  I guess that would be a better approach as it seems that plasma and 
application themes don't always mix well.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 4 lines] D4153: Network manager configuration model is unreadable

2017-01-15 Thread John Salatas

jsalatas updated this revision to Diff 10204.
jsalatas added a comment.


  Previous diff was incomplete.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4153?vs=10203=10204

REVISION DETAIL
  https://phabricator.kde.org/D4153

AFFECTED FILES
  kcm/qml/Dialog.qml
  kcm/qml/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D4153: Network manager configuration model is unreadable

2017-01-15 Thread John Salatas

jsalatas created this revision.
jsalatas added reviewers: Plasma, Plasma: Design, jgrulich.
jsalatas set the repository for this revision to R116 Plasma Network Management 
Applet.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It seems that for some application/plasma theme combinations (bug #374905) 
and also form 3rd party themes (bug #374976), the new network manager 
configuration model is unreadable.
  
  The attached seems to correctly handle all cases of Breeze and Breeze dark 
application/plasma theme combinations, however the result doesn't look (always) 
aesthetically pleasant. Is there a better way yo do it? :\

TEST PLAN
  Breeze dark application scheme, Breeze dark Plasma theme
  F2049636: dd.png 
  
  Breeze dark application scheme, Breeze light Plasma theme
  F2049637: dl.png 
  
  Breeze light application scheme, Breeze light Plasma theme
  F2049641: ll.png 
  
  Breeze light application scheme, Breeze dark Plasma theme
  F2049638: ld.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

AFFECTED FILES
  kcm/qml/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow scrolling is no longer intuitive

2017-01-13 Thread John Salatas

https://bugs.kde.org/show_bug.cgi?id=375005

John Salatas <jsala...@gmail.com> changed:

   What|Removed |Added

 CC||jsala...@gmail.com

--- Comment #5 from John Salatas <jsala...@gmail.com> ---
You can also use the keyboard's up/down arrow keys, for more precision/control.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D3847: SWT/Eclipse toolbar fix

2016-12-30 Thread jsalatas (John Salatas)

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:85fd0772a125: SWT/Eclipse toolbar fix (authored by 
jsalatas).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3847?vs=9436=9482

REVISION DETAIL
  https://phabricator.kde.org/D3847

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/styles
  Breeze-gtk/gtk-2.0/widgets/styles

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #breeze, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3847: SWT/Eclipse toolbar fix

2016-12-28 Thread jsalatas (John Salatas)

jsalatas created this revision.
jsalatas added a reviewer: Breeze.
jsalatas set the repository for this revision to R98 Breeze for Gtk.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In eclipse running with  SWT gtk2 the buttons in the toolbar don't behave as 
they should:
  
  1. There is no highlighting when hovering
  2. For toggle buttons there is no active/inactive indication.

TEST PLAN
  Tested in KDE Neon User as of December, 28th
  
  Before
  F1588340: before.png 
  
  After 
  F1588341: after.png 
  
  Besides these two issues the patch seems to (unintentionally) improve some 
real-estates (see for example secondary toolbar buttons in Package Explorer and 
Outline views).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D3847

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/styles
  Breeze-gtk/gtk-2.0/widgets/styles

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2913: Make the background of the logout screen darker

2016-10-06 Thread jsalatas (John Salatas)

jsalatas abandoned this revision.
jsalatas added a comment.


  I just tested it in a normal PC (ie not Virtual Machine) with 3D acceleration 
and the background is indeed blurred as davidedmundson said.
  
  So I'm abandoning this, as it seems a very minor issue.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2913

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: mart, davidedmundson, plasma-devel, apol, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 2 lines] D2913: Make the background of the logout screen darker

2016-10-03 Thread jsalatas (John Salatas)

jsalatas updated the test plan for this revision.
jsalatas updated this revision to Diff 7058.
jsalatas added a comment.


  According to mart's suggestion there is already a rectangle, so there is no 
need to add a new one (the "after" screenshot is also updated to reflect this)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2913?vs=7038=7058

REVISION DETAIL
  https://phabricator.kde.org/D2913

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: mart, davidedmundson, plasma-devel, apol, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2913: Make the background of the logout screen darker

2016-10-02 Thread jsalatas (John Salatas)

jsalatas added a comment.


  There is no blur effect (I'm running it in a Virtual Machine with no 3D 
acceleration).
  
  Here is the output of the qdbus org.kde.KWin /KWin supportInformation command
  
# qdbus org.kde.KWin /KWin supportInformation
KWin Support Information:
The following information should be used when requesting support on e.g. 
http://forum.kde.org.
It provides information about the currently running instance, which options 
are used,
what OpenGL driver and which effects are running.
Please post the information provided underneath this introductory text to a 
paste bin service
like http://paste.kde.org instead of pasting into support threads.

==

Version
===
KWin version: 5.8.90
Qt Version: 5.7.0
Qt compile version: 5.7.0
XCB compile version: 1.11.1

Operation Mode: X11 only

Build Options
=
KWIN_BUILD_DECORATIONS: yes
KWIN_BUILD_TABBOX: yes
KWIN_BUILD_ACTIVITIES: yes
HAVE_INPUT: yes
HAVE_DRM: yes
HAVE_GBM: yes
HAVE_X11_XCB: yes
HAVE_EPOXY_GLX: yes
HAVE_WAYLAND_EGL: yes

X11
===
Vendor: The X.Org Foundation
Vendor Release: 11803000
Protocol Version/Revision: 11/0
SHAPE: yes; Version: 0x11
RANDR: yes; Version: 0x14
DAMAGE: yes; Version: 0x11
Composite: yes; Version: 0x4
RENDER: yes; Version: 0xb
XFIXES: yes; Version: 0x50
SYNC: yes; Version: 0x31
GLX: yes; Version: 0x0

Decoration
==
Plugin: org.kde.breeze
Theme:
Blur: 0
onAllDesktopsAvailable: true
alphaChannelSupported: true
closeOnDoubleClickOnMenu: false
decorationButtonsLeft: 0, 2
decorationButtonsRight: 6, 3, 4, 5
borderSize: 3
gridUnit: 10
font: Noto Sans,10,-1,0,50,0,0,0,0,0
smallSpacing: 2
largeSpacing: 10

Options
===
focusPolicy: 0
nextFocusPrefersMouse: false
clickRaise: true
autoRaise: false
autoRaiseInterval: 0
delayFocusInterval: 0
shadeHover: false
shadeHoverInterval: 250
separateScreenFocus: false
placement: 4
focusPolicyIsReasonable: true
borderSnapZone: 10
windowSnapZone: 10
centerSnapZone: 0
snapOnlyWhenOverlapping: false
rollOverDesktops: true
focusStealingPreventionLevel: 1
legacyFullscreenSupport: false
operationTitlebarDblClick: 5000
operationMaxButtonLeftClick: 5000
operationMaxButtonMiddleClick: 5015
operationMaxButtonRightClick: 5014
commandActiveTitlebar1: 0
commandActiveTitlebar2: 30
commandActiveTitlebar3: 2
commandInactiveTitlebar1: 4
commandInactiveTitlebar2: 30
commandInactiveTitlebar3: 2
commandWindow1: 7
commandWindow2: 8
commandWindow3: 8
commandWindowWheel: 31
commandAll1: 10
commandAll2: 3
commandAll3: 14
keyCmdAllModKey: 16777251
showGeometryTip: false
condensedTitle: false
electricBorderMaximize: true
electricBorderTiling: true
electricBorderCornerRatio: 0.25
borderlessMaximizedWindows: false
killPingTimeout: 5000
hideUtilityWindowsForInactive: true
inactiveTabsSkipTaskbar: false
autogroupSimilarWindows: false
autogroupInForeground: true
compositingMode: 2
useCompositing: true
compositingInitialized: true
hiddenPreviews: 1
glSmoothScale: 2
colorCorrected: false
xrenderSmoothScale: false
maxFpsInterval: 1666
refreshRate: 0
vBlankTime: 600
glStrictBinding: true
glStrictBindingFollowsDriver: true
glCoreProfile: false
glPreferBufferSwap: 97
glPlatformInterface: 1
windowsBlockCompositing: true

Screen Edges

desktopSwitching: false
desktopSwitchingMovingClients: false
cursorPushBackDistance: 1x1
timeThreshold: 150
reActivateThreshold: 350
actionTopLeft: 0
actionTop: 0
actionTopRight: 0
actionRight: 0
actionBottomRight: 0
actionBottom: 0
actionBottomLeft: 0
actionLeft: 0

Screens
===
Multi-Head: no
Active screen follows mouse: no
Number of Screens: 1

Screen 0:
-
Name: VGA-1
Geometry: 0,0,1920x950
Refresh Rate: 59.8991


Compositing
===
Compositing is active
Compositing Type: XRender

Loaded Effects:
---
zoom
slidingpopups
kwin4_effect_login
slide
screenshot
kwin4_effect_translucency
kwin4_effect_windowaperture
minimizeanimation
desktopgrid
kwin4_effect_morphingpopups
kwin4_effect_fade
kwin4_effect_maximize
presentwindows
kwin4_effect_dialogparent
highlightwindow
screenedge
kscreen

Currently Active Effects:
-

Effect Settings:

zoom:
zoomFactor: 1.2
mousePointer: 0
mouseTracking: 0
enableFocusTracking: false

[Differential] [Request, 8 lines] D2913: Make the background of the logout screen darker

2016-10-02 Thread jsalatas (John Salatas)

jsalatas created this revision.
jsalatas added reviewers: Plasma, Plasma: Design.
jsalatas added a subscriber: apol.
jsalatas set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There are cases (based on the active window contents) that the elements of 
the logout screen aren't readable. Making the background of the logout screen 
darker seems to fix the problem.

TEST PLAN
  Before
  F347888: before.png 
  
  After
  F347889: after.png 

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2913

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: plasma-devel, apol, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2901: Constrain kickoff config button label size

2016-09-30 Thread jsalatas (John Salatas)

jsalatas accepted this revision.
jsalatas added a reviewer: jsalatas.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2901

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, jsalatas
Cc: jsalatas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 55 lines] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons

2016-09-30 Thread jsalatas (John Salatas)

jsalatas removed rPLASMADESKTOP Plasma Desktop as the repository for this 
revision.
jsalatas updated this revision to Diff 7013.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2900?vs=7012=7013

REVISION DETAIL
  https://phabricator.kde.org/D2900

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons

2016-09-30 Thread jsalatas (John Salatas)

jsalatas added a reviewer: Plasma: Design.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2900

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 57 lines] D2900: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons

2016-09-30 Thread jsalatas (John Salatas)

jsalatas created this revision.
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures we don't end up with a white icon (dark Plasma theme) on a light 
gray (default application colors) background. It also makes the configuration 
(draggable) buttons look more like a live preview.
  
  similar to: https://phabricator.kde.org/D2884

TEST PLAN
  Breeze dark application scheme, Breeze dark Plasma theme
  F346143: bb.png 
  Breeze dark application scheme, Breeze light Plasma theme
  F346138: bw.png 
  Breeze light application scheme, Breeze light Plasma theme
  F346139: ww.png 
  Breeze light application scheme, Breeze dark Plasma theme
  F346142: wb.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2900

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Widget's Configuration Icon Colors

2016-09-29 Thread John Salatas

Hi!

My desktop is configured as follows:
Look and Feel: Breeze
Desktop Theme: Breeze

Screenshot 1 shows Kickoff's Application Launcher Settings

Now I change Desktop Theme to Breeze Dark

Screenshot 2 shows Kickoff's Application Launcher Settings again.

As you can see the Icon (start-here-kde) and the Menu Buttons appear as
white. Is there any way to change the SVG's icon color (not the button's)
to dark (possibly text color or something dark)?

Thanks!

[Screenshot 1]: http://jsalatas.ictpro.gr/01.png
[Screenshot 2]: http://jsalatas.ictpro.gr/02.png


John Salatas
Email: jsala...@gmail.com
Web Page: http://jsalatas.ictpro.gr

Widget's Configuration Icon Colors

2016-09-22 Thread John Salatas


Hi!

My desktop is configured as follows:
Look and Feel: Breeze
Desktop Theme: Breeze

Screenshot 1 shows Kickoff's Application Launcher Settings

Now I change Desktop Theme to Breeze Dark

Screenshot 2 shows Kickoff's Application Launcher Settings again.

As you can see the Icon (start-here-kde) and the Menu Buttons appear as 
white. Is there any way to change the SVG's icon color (not the 
button's) to dark (possibly text color or something dark)?


Thanks!

[Screenshot 1]: http://jsalatas.ictpro.gr/01.png
[Screenshot 2]: http://jsalatas.ictpro.gr/02.png



John Salatas
Web Page: http://jsalatas.ictpro.gr

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-09-22 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

(Updated Sept. 22, 2016, 12:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 361210
https://bugs.kde.org/show_bug.cgi?id=361210


Repository: plasma-desktop


Description
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also according 
to bug 361210 to reorganize them.

In the attached screenshot you can see

1) the configuration options: These are just the menu buttons than can be 
rearranged or hidden/shown via drag n drop
2) The Kickoff menu with just 3 menu items (the other two are hidden).


Diffs
-

  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
  applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing
---

ested in KDE Neon Developer Stable (as of July 14, 2016)


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png


Thanks,

John Salatas

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-09-21 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review99397
---



Reopened due to 
https://bugs.kde.org/show_bug.cgi?id=369160

- John Salatas


On Sept. 18, 2016, 2:48 p.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated Sept. 18, 2016, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 361210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged or hidden/shown via drag n drop
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> ested in KDE Neon Developer Stable (as of July 14, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-09-18 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

(Updated Sept. 18, 2016, 2:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ece1610945e382dbec2cd67495fd5bf7c8e0b764 by David 
Edmundson to branch master.


Bugs: 361210
https://bugs.kde.org/show_bug.cgi?id=361210


Repository: plasma-desktop


Description
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also according 
to bug 361210 to reorganize them.

In the attached screenshot you can see

1) the configuration options: These are just the menu buttons than can be 
rearranged or hidden/shown via drag n drop
2) The Kickoff menu with just 3 menu items (the other two are hidden).


Diffs
-

  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
  applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing
---

ested in KDE Neon Developer Stable (as of July 14, 2016)


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png


Thanks,

John Salatas

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-07-18 Thread John Salatas



> On July 10, 2016, 8:49 p.m., Thomas Pfeiffer wrote:
> > Nice feature, but the UI unnecessarily mixes two different interaction 
> > patterns: Checkboxes and drag
> > What I'd prefer to do (and we should introduce that as a general paradigm 
> > for such things): Put a box "Hidden tabs" below the visualization of the 
> > active tabs and allow to add and remove via drag and drop. 
> > The visualization would be:
> > 
> > ---
> > Visible Tabs:
> > [ ] [ ] [ ] (ideally visualized like the actual Plasmoid)
> > 
> > "Hidden Tabs"
> > [ ] [ ]
> > 
> > Drag tabs between the boxes to show/hide them, or reorder the visible tabs 
> > by dragging. 
> > 
> > ---
> > That way reaordering and show/hide would work in the same way, and the 
> > "Visible Tabs" box would always exactly represent reality.
> 
> John Salatas wrote:
> Updated as per your suggestions.

ping? 
:)


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97267
---


On July 14, 2016, 10:42 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 14, 2016, 10:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 361210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged or hidden/shown via drag n drop
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> ested in KDE Neon Developer Stable (as of July 14, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-14 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/
---

(Updated July 14, 2016, 11:04 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 7f060403a2d44fc76b2b14fc9ebf43ee272d1c54 by Marco Martin 
to branch master.


Repository: plasma-workspace


Description
---

Configuration option for system tray's icon sizes in order to be handled by 
look & feel themes/packages.


Diffs
-

  applets/systemtray/package/contents/config/main.xml 65a7029 
  applets/systemtray/package/contents/ui/main.qml a66ea69 

Diff: https://git.reviewboard.kde.org/r/128400/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-14 Thread John Salatas



> On July 14, 2016, 10:33 a.m., Viorel-Cătălin Răpițeanu wrote:
> > Is there any status update on this commit? Should it be integrated?

I'm done with it. Hopefully someone will commit to git as I don't have commit 
rights in order to do it myself.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97384
---


On July 12, 2016, 8:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 12, 2016, 8:29 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Configuration option for system tray's icon sizes in order to be handled by 
> look & feel themes/packages.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-07-14 Thread John Salatas



> On July 10, 2016, 8:49 p.m., Thomas Pfeiffer wrote:
> > Nice feature, but the UI unnecessarily mixes two different interaction 
> > patterns: Checkboxes and drag
> > What I'd prefer to do (and we should introduce that as a general paradigm 
> > for such things): Put a box "Hidden tabs" below the visualization of the 
> > active tabs and allow to add and remove via drag and drop. 
> > The visualization would be:
> > 
> > ---
> > Visible Tabs:
> > [ ] [ ] [ ] (ideally visualized like the actual Plasmoid)
> > 
> > "Hidden Tabs"
> > [ ] [ ]
> > 
> > Drag tabs between the boxes to show/hide them, or reorder the visible tabs 
> > by dragging. 
> > 
> > ---
> > That way reaordering and show/hide would work in the same way, and the 
> > "Visible Tabs" box would always exactly represent reality.

Updated as per your suggestions.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97267
---


On July 14, 2016, 10:42 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 14, 2016, 10:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 361210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged or hidden/shown via drag n drop
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> ested in KDE Neon Developer Stable (as of July 14, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-07-14 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

(Updated July 14, 2016, 10:42 a.m.)


Review request for Plasma.


Bugs: 361210
https://bugs.kde.org/show_bug.cgi?id=361210


Repository: plasma-desktop


Description (updated)
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also according 
to bug 361210 to reorganize them.

In the attached screenshot you can see

1) the configuration options: These are just the menu buttons than can be 
rearranged or hidden/shown via drag n drop
2) The Kickoff menu with just 3 menu items (the other two are hidden).


Diffs (updated)
-

  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
  applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing (updated)
---

ested in KDE Neon Developer Stable (as of July 14, 2016)


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-12 Thread John Salatas



> On July 12, 2016, 11:40 a.m., Kai Uwe Broulik wrote:
> >

done


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97313
---


On July 12, 2016, 8:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 12, 2016, 8:29 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Configuration option for system tray's icon sizes in order to be handled by 
> look & feel themes/packages.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-12 Thread John Salatas



> On July 12, 2016, 7:46 a.m., Marco Martin wrote:
> >
> 
> John Salatas wrote:
> done

I just realized that I cannot commit to git and (obviously) marking it as 
submitted it doesn't submit it :)

Can someone submit it for me? 

Thanks!


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97305
---


On July 12, 2016, 8:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 12, 2016, 8:29 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Configuration option for system tray's icon sizes in order to be handled by 
> look & feel themes/packages.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-12 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/
---

(Updated July 12, 2016, 8:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
---

Configuration option for system tray's icon sizes in order to be handled by 
look & feel themes/packages.


Diffs
-

  applets/systemtray/package/contents/config/main.xml 65a7029 
  applets/systemtray/package/contents/ui/main.qml a66ea69 

Diff: https://git.reviewboard.kde.org/r/128400/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-11 Thread John Salatas



> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote:
> > Visual aspects should stay under the theme's control. Therefore, from the 
> > usability perspective, there should be no user option, instead the look & 
> > feel theme should be able to control the icon size.
> 
> John Salatas wrote:
> I don't think that currently the theme controls it. It scales to follow 
> the panel's size up to a certain size which is hardcoded: 
> units.iconSizes.medium
> 
> Why units.iconSizes.medium and not units.iconSizes.smallMedium? Is this a 
> design decision or just a random pickup? :\
> 
> What I'm proposing here is let the user choose instead of having an 
> arbitrary maximum size hardcoded. :\
> 
> Marco Martin wrote:
> i do think smallmedium would be a better default.
> in order to do as Thomas suggests, it can have the configuration value, 
> but not exposed from the config dialog (and yeah, defaulting to smallmedium).
> then, look and feel packages can contain default setups for applets, it 
> would be that one that make it theme-controlled.
> 
> Also, i would save in the config smallmedium/medium etc, instead of a 
> pixel size value, in order to still survive DPI changes, screen migration etc.

OK. I just updated the diff file. The system tray now has the iconSize option 
which is not exposed from the config dialog. 

Look and feel packages can set this value according to the documentation at 
https://userbase.kde.org/KDE_System_Administration/PlasmaTwoDesktopScripting#Default_applets_config_from_Look_and_Feel_packages

That is by creating a file name org.kde.plasma.private.systemtray.js in the 
plasmoidsetupscripts subfolder of the Look and Feel package with the following 
contents

applet.currentConfigGroup = new Array("General");
applet.writeConfig("iconSize", 1);
applet.reloadConfig();

Of course a user can still modify this value by manually editing his 
~/.config/plasma-org.kde.plasma.desktop-appletsrc


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97212
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Configuration option for system tray's icon sizes in order to be handled by 
> look & feel themes/packages.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

2016-07-09 Thread John Salatas



> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual 
> > tabs, see Bug 361210, but not a corner-case solution for just the favorites.
> 
> John Salatas wrote:
> Yes! That would be great! Not sure if I can implement it through drag and 
> drop, but I could give it a try :\
> 
> Kai Uwe Broulik wrote:
> As a first step already having the infrastructure in the applet, ie. a 
> stringlist setting favorites,applications,history,... and 
> the applet placing the tabs as configured would be nice.
> 
> A fancy settings UI with drag and drop could be added at a later stage.
> 
> David Edmundson wrote:
> Or should we just hide if a model is empty?
> 
> We have an existing bug on the leave tab existing even if all the entries 
> are disabled with kiosk.
> 
> Kai Uwe Broulik wrote:
> I made a patch for that a while ago (eg. hide History tab when empty) but 
> it was rejected for... "performance" reasons.

Patch updated as per Kai Uwe Broulik's suggestion. 

Not sure if I did it the correct way but I guess I didn't as it is actually my 
first qml application :\

I would appreciate your feedback!


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---


On July 9, 2016, 6:48 p.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 9, 2016, 6:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 36210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged via drag n drop and the also include a checkbox (checked: show it, 
> unchecked: hide it).
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/code/ButtonTools.js PRE-CREATION 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 8, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

2016-07-09 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

(Updated July 9, 2016, 6:48 p.m.)


Review request for Plasma.


Bugs: 361210
https://bugs.kde.org/show_bug.cgi?id=361210


Repository: plasma-desktop


Description (updated)
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide any menu and also according 
to bug 36210 to reorganize them.

In the attached screenshot you can see

1) the configuration options: These are just the menu buttons than can be 
rearranged via drag n drop and the also include a checkbox (checked: show it, 
unchecked: hide it).
2) The Kickoff menu with just 3 menu items (the other two are hidden).


Diffs (updated)
-

  applets/kickoff/package/contents/code/ButtonTools.js PRE-CREATION 
  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
  applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing (updated)
---

Tested in KDE Neon Developer Stable (as of July 8, 2016)


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-08 Thread John Salatas



> On July 8, 2016, 11:21 a.m., Thomas Pfeiffer wrote:
> > Visual aspects should stay under the theme's control. Therefore, from the 
> > usability perspective, there should be no user option, instead the look & 
> > feel theme should be able to control the icon size.

I don't think that currently the theme controls it. It scales to follow the 
panel's size up to a certain size which is hardcoded: units.iconSizes.medium

Why units.iconSizes.medium and not units.iconSizes.smallMedium? Is this a 
design decision or just a random pickup? :\

What I'm proposing here is let the user choose instead of having an arbitrary 
maximum size hardcoded. :\


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97212
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-08 Thread John Salatas



> On July 8, 2016, 9:45 a.m., Heiko Tietze wrote:
> > Please add a screenshot. But actually I wonder why size matters. Aren't 
> > icons adjusted according the panel height anymore? That would by a minus 
> > one.
> 
> Kai Uwe Broulik wrote:
> They are. For system tray only up to a certain point, though, at which it 
> will become two or more rows, like with task manager, so the tray doesn't 
> fill half the panel width. This patch adds a setting to define the maximum 
> size for the icons.

https://bugsfiles.kde.org/attachment.cgi?id=99911

The upper one is with medium size which I find it too big.

I would preffer the smallMedium size (lower one).


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97202
-------


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128402: Kickoff: Add option to hide Favorites tab

2016-07-08 Thread John Salatas



> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > What I would instead like is the ability to re-arrange and hide individual 
> > tabs, see Bug 361210, but not a corner-case solution for just the favorites.

Yes! That would be great! Not sure if I can implement it through drag and drop, 
but I could give it a try :\


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review97199
---


On July 8, 2016, 6:35 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated July 8, 2016, 6:35 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide Favorites from the kickoff
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-08 Thread John Salatas



> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
> yes they are
> 
> John Salatas wrote:
> My "problem" that medium size seems to be too large for me and according 
> to the bug #364431 this doesn't seem to be the case for all users. So I 
> though that it would be better if the size was controled by the user :\
> 
> FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 
> resolution and the medium size icons seems too large in both of them :\
> 
> Kai Uwe Broulik wrote:
> It can be controlled, by changing the panel size. If the size changed 
> between Plasma 5.6 and 5.7 that's a bug. If it was large before already then 
> this is expected and as it should be.

Indeed, there was a change from 5.6 to 5.7 (it was large before). 

In any case, can't we just consider what I'm proposing here (the ability to 
change the icon size in the systray) as a new feature? :)


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-08 Thread John Salatas



> On July 8, 2016, 7:21 a.m., Kai Uwe Broulik wrote:
> > Thanks for your patch!
> > 
> > However, I don't think there should be such an option. There's no other 
> > applet which has this and applets in the panel usually follow the panel 
> > size indefinitely. Perhaps add the "usability" group to have them decide.
> > 
> > Also, I don't think this single option deserves a separage page, it would 
> > fit just fine at the top of the "General" page imho.
> 
> John Salatas wrote:
> Thanks for your feedback! 
> 
> I updated the diff and I believe I have addressed all of the issues you 
> pointed.
> 
> I also added the usability group. 
> 
> IMHO I don't think having this option is bad as I guess that the 
> "correct" icon size is depended to the monitor so maybe it is better to be 
> controlled by the user instead of having a fixed value :\
> 
> Marco Martin wrote:
> well, depending from the monitor means it should depend from the monitor 
> dpi, rather than the user (and yes, medium size was definitely too big, but i 
> don't think it grants an option to explicitly control this)
> 
> Kai Uwe Broulik wrote:
> iconSizes are scaled with DPI, no?
> 
> Marco Martin wrote:
> yes they are

My "problem" that medium size seems to be too large for me and according to the 
bug #364431 this doesn't seem to be the case for all users. So I though that it 
would be better if the size was controled by the user :\

FYI: I have two monitors: one 15 inch and one 24 Inch both with 1920x1080 
resolution and the medium size icons seems too large in both of them :\


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97186
---


On July 8, 2016, 8:56 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 8:56 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-08 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/
---

(Updated July 8, 2016, 8:41 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

I didn't like the recent changes in systray icon size related to bug #364431, 
so I created this patch in order to make the systray's icon size user 
configurable


Diffs (updated)
-

  applets/systemtray/package/contents/code/IconSizeTools.js PRE-CREATION 
  applets/systemtray/package/contents/config/main.xml 65a7029 
  applets/systemtray/package/contents/ui/ConfigGeneral.qml 4fcfcf6 
  applets/systemtray/package/contents/ui/main.qml a66ea69 

Diff: https://git.reviewboard.kde.org/r/128400/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128400: Configuration option for System Tray's icon size

2016-07-08 Thread John Salatas



> On July 8, 2016, 6:57 a.m., Anthony Fieroni wrote:
> > About me, size of systray icons must depend on panel size. Same for space 
> > between items.

Well... I guess it's just a matter of personal taste. I'm using a rather high 
panel and the default icon size (units.iconSizes.medium) seems rather big. I 
would prefer units.iconSizes.smallMedium instead. 

You can compare the two choices in the screenshot I uploaded in bug #364431 
(https://bugsfiles.kde.org/attachment.cgi?id=99911): the upper is the default 
size (units.iconSizes.medium) and the lower which I prefer is 
units.iconSizes.smallMedium


- John


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/#review97184
---


On July 8, 2016, 4:29 a.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128400/
> ---
> 
> (Updated July 8, 2016, 4:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I didn't like the recent changes in systray icon size related to bug #364431, 
> so I created this patch in order to make the systray's icon size user 
> configurable
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/config/main.xml 65a7029 
>   applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
>   applets/systemtray/package/contents/ui/main.qml a66ea69 
> 
> Diff: https://git.reviewboard.kde.org/r/128400/diff/
> 
> 
> Testing
> ---
> 
> Tested in KDE Neon Developer Stable (as of July 7, 2016)
> 
> 
> Thanks,
> 
> John Salatas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128402: Kickoff: Add option to hide Favorites tab

2016-07-08 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab 
in kickoff is somewhat redundant, as I have added launchers for all of my 
favorites in the Icons-Only Task Manager.
So in this patch I'm introducing an option to hide Favorites from the kickoff


Diffs
-

  applets/kickoff/package/contents/config/main.xml 2de73ba 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 

Diff: https://git.reviewboard.kde.org/r/128402/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128400: Configuration option for System Tray's icon size

2016-07-07 Thread John Salatas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128400/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

I didn't like the recent changes in systray icon size related to bug #364431, 
so I created this patch in order to make the systray's icon size user 
configurable


Diffs
-

  applets/systemtray/package/contents/config/main.xml 65a7029 
  applets/systemtray/package/contents/ui/ConfigIcons.qml PRE-CREATION 
  applets/systemtray/package/contents/ui/main.qml a66ea69 

Diff: https://git.reviewboard.kde.org/r/128400/diff/


Testing
---

Tested in KDE Neon Developer Stable (as of July 7, 2016)


Thanks,

John Salatas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

61 matches

Mail list logo