from:"Jonah Brüchert"

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

2020-04-29 Thread Jonah Brüchert

jbbgameich added a comment.


  Did you possibly forget to commit the changes to the header file?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29226

To: broulik, #plasma, dfaure
Cc: jbbgameich, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8473aad62ed4: PlaceholderMessage: Remove Plasma units 
usage (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29209?vs=81263=81274

REVISION DETAIL
  https://phabricator.kde.org/D29209

AFFECTED FILES
  src/controls/PlaceholderMessage.qml

To: jbbgameich, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Jonah Brüchert

jbbgameich created this revision.
jbbgameich added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Probably this was forgotten when importing the new component into Kirigami

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29209

AFFECTED FILES
  src/controls/PlaceholderMessage.qml

To: jbbgameich, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28468: Add property initializer support to PagePool

2020-04-01 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:bb5a6c13ec0b: Add property initializer support to 
PagePool (authored by masonm, committed by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28468?vs=79059=79090

REVISION DETAIL
  https://phabricator.kde.org/D28468

AFFECTED FILES
  src/controls/PagePoolAction.qml
  src/pagepool.cpp
  src/pagepool.h

To: masonm, #kirigami, mart
Cc: plasma-devel, mart, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson

D26956: Remove export header from static install

2020-03-21 Thread Jonah Brüchert

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0aa162f2e838: Remove export header from static install 
(authored by masonm, committed by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26956?vs=74470=78202

REVISION DETAIL
  https://phabricator.kde.org/D26956

AFFECTED FILES
  src/libkirigami/CMakeLists.txt

To: masonm, #kirigami, mart, apol
Cc: jbbgameich, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D27837: Fix about page with Qt 5.15

2020-03-21 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6223aa661c61: Fix about page with Qt 5.15 (authored by 
jbbgameich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27837?vs=78200=78201#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27837?vs=78200=78201

REVISION DETAIL
  https://phabricator.kde.org/D27837

AFFECTED FILES
  src/controls/AboutPage.qml

To: jbbgameich, #kirigami, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27837: Fix about page with Qt 5.15

2020-03-21 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 78200.
jbbgameich added a comment.


  rebase

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27837?vs=76948=78200

BRANCH
  about-page-qt-515 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27837

AFFECTED FILES
  kirigami.qrc.in
  src/controls/AboutPage.qml

To: jbbgameich, #kirigami, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D26956: Remove export header from static install

2020-03-20 Thread Jonah Brüchert

jbbgameich added a comment.


  @apol is your question answered now / can I land this?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D26956

To: masonm, #kirigami, mart, apol
Cc: jbbgameich, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28148: Fix broken paths in kirigami.qrc.in

2020-03-20 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9949457f31ba: Fix broken paths in kirigami.qrc.in 
(authored by masonm, committed by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28148?vs=78042=78112

REVISION DETAIL
  https://phabricator.kde.org/D28148

AFFECTED FILES
  kirigami.qrc.in

To: masonm, #kirigami, #vdg, apol
Cc: plasma-devel, #vdg, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27843: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert

jbbgameich created this revision.
jbbgameich added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Can be landed once Frameworks can depend on Qt 5.14

TEST PLAN
  Everything still work (It won't work with Qt < 5.14)

REPOSITORY
  R169 Kirigami

BRANCH
  515-connection-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27843

AFFECTED FILES
  src/controls/FormLayout.qml
  src/controls/private/ActionButton.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/private/globaltoolbar/BreadcrumbControl.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml
  src/controls/templates/SwipeListItem.qml

To: jbbgameich, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27838: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 76950.
jbbgameich added a comment.


  Fix syntax error

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27838?vs=76949=76950

BRANCH
  5.15-connections-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27838

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Menu.qml

To: jbbgameich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27838: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Fixes deprecation warnings with Qt 5.15

TEST PLAN
  No deprecations warnings, everything still works

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  5.15-connections-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27838

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Menu.qml

To: jbbgameich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27837: Fix about page with Qt 5.15

2020-03-04 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  UrlButton exists since since org.kde.kirigami 2.6, before the file was 
resolved from the current directory but doesn't seem to be anymore with 5.15

REPOSITORY
  R169 Kirigami

BRANCH
  about-page-qt-515 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27837

AFFECTED FILES
  src/controls/AboutPage.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D25989: Don't build and install app templates on android

2019-12-14 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3bc41934f9d6: Dont build and install app templates 
on android (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25989?vs=71517=71518

REVISION DETAIL
  https://phabricator.kde.org/D25989

AFFECTED FILES
  CMakeLists.txt

To: jbbgameich, #kirigami, #android, nicolasfella
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

2019-12-14 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 71517.
jbbgameich added a comment.


  Follow suggestion

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25989?vs=71516=71517

BRANCH
  android-no-app-templates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25989

AFFECTED FILES
  CMakeLists.txt

To: jbbgameich, #kirigami, #android
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

2019-12-14 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  They increase apk sizes and are really not required in an apk.

REPOSITORY
  R169 Kirigami

BRANCH
  android-no-app-templates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25989

AFFECTED FILES
  CMakeLists.txt

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25175: FormLayout: Fix label height if wide mode is false

2019-11-06 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:839983aa3604: FormLayout: Fix label height if wide mode 
is false (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25175?vs=69355=69356

REVISION DETAIL
  https://phabricator.kde.org/D25175

AFFECTED FILES
  src/controls/FormLayout.qml

To: jbbgameich, #kirigami, #plasma:_mobile, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D25175: FormLayout: Fix label height if wide mode is false

2019-11-06 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 69355.
jbbgameich edited the test plan for this revision.
jbbgameich added a comment.


  Use implicit height instead of font metrics

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25175?vs=69353=69355

BRANCH
  fix/formlayout-label-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25175

AFFECTED FILES
  src/controls/FormLayout.qml

To: jbbgameich, #kirigami, #plasma:_mobile
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D25175: FormLayout: Fix label height if wide mode is false

2019-11-06 Thread Jonah Brüchert

jbbgameich added inline comments.

INLINE COMMENTS

> mart wrote in FormLayout.qml:277
> fontmetrics is the default font height, and this being an heading may be more 
> (when is heading)
> does it work if instead you do here
> return implicitHeight  ?

It works but produces a slightly smaller margin. But it looks good as well so 
I'll update the diff.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25175

To: jbbgameich, #kirigami, #plasma:_mobile
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D25109: Make it impossible to open the progress view sheet multiple times

2019-11-06 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:762a36fcd96b: Make it impossible to open the progress 
view sheet multiple times (authored by jbbgameich).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25109?vs=69167=69354

REVISION DETAIL
  https://phabricator.kde.org/D25109

AFFECTED FILES
  discover/qml/ProgressView.qml

To: jbbgameich, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25175: FormLayout: Fix label height if wide mode is false

2019-11-06 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  previously the height of the label was based on the content's height. However 
this doesn't work in non wide mode. With this change it preserves the previous 
behaviour in wide mode were it makes sense but uses a constant height in 
non-wide mode.

TEST PLAN
  FormLayouts with large content items don't have large margins between the 
items anymore when wideMode = false.

REPOSITORY
  R169 Kirigami

BRANCH
  fix/formlayout-label-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25175

AFFECTED FILES
  src/controls/FormLayout.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25109: Make it impossible to open the progress view sheet multiple times

2019-11-01 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  It used to be possible after resizing the window so narrowly that the drawer 
switched into modal mode and back to its original width.
  There is still the question of why the sheet is sometimes left behind the 
drawer, but that's probably something for another patch.

TEST PLAN
  Multiple ProgressView sheets can't be opened at the same time anymore

REPOSITORY
  R134 Discover Software Store

BRANCH
  progress-view-open-only-once (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25109

AFFECTED FILES
  discover/qml/ProgressView.qml

To: jbbgameich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Jonah Brüchert

jbbgameich added a comment.


  Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 
branch back into master?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mobile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24451

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-07 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:91e6cf9694cd: metadata: Add form factors to make kcm 
appear on mobile again (authored by jbbgameich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24451?vs=67400=67403#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24451?vs=67400=67403

REVISION DETAIL
  https://phabricator.kde.org/D24451

AFFECTED FILES
  src/kcm/kcm_pulseaudio.desktop

To: jbbgameich, #plasma:_mobile, #plasma, nicolasfella, bshah
Cc: bshah, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24451: metadata: Add form factors to make kcm appear on mobile again

2019-10-06 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Seems to be required to make the kcm visible in plasma-settings

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mobile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24451

AFFECTED FILES
  src/kcm/kcm_pulseaudio.desktop

To: jbbgameich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23897: Port mobile_wifi kcm to newer APIs

2019-09-16 Thread Jonah Brüchert

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:4ca3d7aa14c7: Port mobile_wifi kcm to newer APIs 
(authored by jbbgameich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23897?vs=65902=66259

REVISION DETAIL
  https://phabricator.kde.org/D23897

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23897: Port mobile_wifi kcm to newer APIs

2019-09-16 Thread Jonah Brüchert

jbbgameich added a comment.


  ping

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D23897

To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-16 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:eb364c963630: Compensate smaller icon sizes on mobile in 
the ActionButton (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23941?vs=66040=66202

REVISION DETAIL
  https://phabricator.kde.org/D23941

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-14 Thread Jonah Brüchert

jbbgameich added a comment.


  I believe the new icon sizes were intentional for the drawer and own uses of 
Kirigami.Icon, but they influence the size of the whole ActionButton as well 
making it rather hard to click on a touch screen.
  Probably Camilo tested his changes only with mauikit which doesn't even use 
the bottom action nuttons.
  
  F7351130: Screenshot_20190914-175603.png 

  (I had to hide some jabber ids in my contact list, I hope the action buttons 
are still visible properly)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23941

To: jbbgameich, mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23941: Compensate smaller icon sizes on mobile in the ActionButton

2019-09-14 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  They became smaller since D22572 . This 
should restore the intended state.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23941

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D23897: Port mobile_wifi kcm to newer APIs

2019-09-12 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
jbbgameich requested review of this revision.

REVISION SUMMARY
  - Controls.Button can display icons on its own now
  - Use kcm.push() and kcm.pop()
  - Use Kirigami.ListSectionHeader instead of custom code

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23897

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: jbbgameich, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

2019-07-26 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:59b1f923be29: Add comment / description to the 
translations kcm (authored by jbbgameich).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18860?vs=61958=62592

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma, ngraham, bshah
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22654: Fix typo

2019-07-22 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:00ccd9019816: Fix typo (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22654?vs=62328=62334

REVISION DETAIL
  https://phabricator.kde.org/D22654

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: jbbgameich, #kirigami, davidedmundson, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22654: Fix typo

2019-07-22 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 62328.
jbbgameich added a comment.


  Fix another occurence

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22654?vs=62324=62328

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22654

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: jbbgameich, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22654: Fix typo

2019-07-22 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  leftLargin -> leftMargin

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22654

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D18860: Add comment / description to the translations kcm

2019-07-18 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 61958.
jbbgameich added a comment.


  Update comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18860?vs=61930=61958

BRANCH
  arcpatch-D18860

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08a802656df5: kcms: translations: use 
availableDomainTranslations from plasmashell instead of… (authored by 
jbbgameich).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22503?vs=61894=61931

REVISION DETAIL
  https://phabricator.kde.org/D22503

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/translationsmodel.cpp

To: jbbgameich, hein
Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

2019-07-17 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 61930.
jbbgameich added a comment.


  Update description once again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18860?vs=51321=61930

BRANCH
  arcpatch-D18860

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma, ngraham
Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  The kcm might be used with different settings apps like plasma-settings, in 
that case systemsettings is not installed.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  translations-no-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22503

AFFECTED FILES
  kcms/translations/translations.cpp
  kcms/translations/translationsmodel.cpp

To: jbbgameich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18860: Add comment / description to the translations kcm

2019-06-24 Thread Jonah Brüchert

jbbgameich added a comment.


  ping

REVISION DETAIL
  https://phabricator.kde.org/D18860

To: jbbgameich, hein, #plasma, ngraham
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D21029: UpdatesPage: Don't try to translate version numbers

2019-05-05 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Fixes a I18N_ARGUMENT_MISSING warning in the ui that appears sometimes while 
discover is looking for updates.

TEST PLAN
  Version numbers are still displayed, and no warnings are visible

REPOSITORY
  R134 Discover Software Store

BRANCH
  updates-page-i18n-versions (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21029

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20675: LoadingPage: Use Kirigami.Heading

2019-04-18 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f061345ad6fe: LoadingPage: Use Kirigami.Heading (authored 
by jbbgameich).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20675?vs=56565=56568

REVISION DETAIL
  https://phabricator.kde.org/D20675

AFFECTED FILES
  discover/qml/LoadingPage.qml

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20674: Word wrap "No backends found" error message

2019-04-18 Thread Jonah Brüchert

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:4d644303be08: Word wrap No backends found 
error message (authored by jbbgameich).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20674?vs=56564=56566

REVISION DETAIL
  https://phabricator.kde.org/D20674

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: jbbgameich, #discover_software_store, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20675: LoadingPage: Use Kirigami.Heading

2019-04-18 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Unifies the look of the loading message with the other messages in discover.

TEST PLAN
  Font size is correct when installing a package e.g from a flatpak ref.

REPOSITORY
  R134 Discover Software Store

BRANCH
  loading-kirigami-heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20675

AFFECTED FILES
  discover/qml/LoadingPage.qml

To: jbbgameich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

2019-02-12 Thread Jonah Brüchert

jbbgameich added a comment.


  I'm sorry, I'm not yet used to the Phabricator workflow. My attempt to 
convert this revision into a proper arc diff I can land failed, since this was 
initially created by pasting `git diff` output. If possible, can you land the 
patch?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18971: UpdatesPage: Fix icon sizing on small screens

2019-02-12 Thread Jonah Brüchert

jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  On Small screens (e.g phones), not all list items have the same height, for 
example when a package has a long version string.
  Since the width of the icon was previously copied from the height, this 
resulted in inconsistent icon sizes.
  
  This patch sets the icon size to a constant value, which fixes the problem.
  
  BUG: 404070

TEST PLAN
  Icon sizes are consistent and still correctly sized

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18971

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

2019-02-12 Thread Jonah Brüchert

jbbgameich added a comment.


  Thanks, done.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

2019-02-12 Thread Jonah Brüchert

jbbgameich added a comment.


  Yes, this looks like the same problem. Since the UpdatesPage width is being 
decreased when opening the "More information", it's the same effect as on a 
phone screen where the width is always that small.
  Can / should I somehow tag this patch so it marks the bug as resolved?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

To: jbbgameich, #discover_software_store
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18964: UpdatesPage: Fix icon sizing on small screens

2019-02-12 Thread Jonah Brüchert

jbbgameich created this revision.
jbbgameich added a reviewer: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  On Small screens (e.g phones), not all list items have the same height, for 
example when a package has a long version string.
  Since the width of the icon was previously copied from the height, this 
resulted in inconsistent icon sizes.
  
  This patch sets the icon size to a constant value, which fixes the problem.

TEST PLAN
  Icon sizes are consistent and still correctly sized

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18964

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: jbbgameich, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18860: Add comment / description to the translations kcm

2019-02-10 Thread Jonah Brüchert

jbbgameich updated this revision to Diff 51321.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18860?vs=51210=51321

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D18860: Add comment / description to the translations kcm

2019-02-08 Thread Jonah Brüchert

jbbgameich created this revision.
jbbgameich added reviewers: hein, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Fixes inconsistency with other kcms

TEST PLAN
  comment is displayed in plasma-settings

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18860

AFFECTED FILES
  kcms/translations/kcm_translations.desktop

To: jbbgameich, hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

51 matches

Mail list logo