D28068: Cleanup file resolving

2020-03-17 Thread Keith Zubot-Gephart 
keithzg requested changes to this revision.
keithzg added a comment.
This revision now requires changes to proceed.


  Compiles when included in an Android Debug build but when attempting to run 
an application I hit an immediate crash on startup with:
  
  name=Android logcat
QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:8:1: Type Kirigami.ApplicationWindow unavailable
qrc:/android_rcc_bundle/qml/org/kde/kirigami.2/ApplicationWindow.qml: No 
such file or directory
  
  Trying an Android Release compile still fails on the pre-exisiting error of 
being unable to include `` in
  
  name=kirigamiplugin.cpp
#ifdef KIRIGAMI_BUILD_TYPE_STATIC
#include 
#endif
  
  So unfortunately nothing is better and one side of things is worse, from the 
perspective of Android + QMake :(

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28068

To: nicolasfella, #kirigami, mart, keithzg, vkrause
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28065: Add missing types to qrc

2020-03-15 Thread Keith Zubot-Gephart 
keithzg added a comment.


  Can confirm this solves my crash when trying to run on Android, which 
previous killed my app on startup if trying to use a `CardsListView`:
  
LOGCAT: W quickgear: QQmlApplicationEngine failed to load component
LOGCAT: W quickgear: qrc:/qml/main.qml:17:28: Type ShowsPage unavailable
LOGCAT: W quickgear: qrc:/qml/ShowsPage.qml:30:2: Type 
Kirigami.CardsListView unavailable
LOGCAT: W quickgear: qrc:/org/kde/kirigami/CardsListView.qml:27:1: 
CardsListViewPrivate is not a type
  
  Now it's all good :)

REPOSITORY
  R169 Kirigami

BRANCH
  types

REVISION DETAIL
  https://phabricator.kde.org/D28065

To: nicolasfella, apol
Cc: keithzg, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart