D13095: Scren brightness follow a quatratic progression

[Kevin Slagle]

kjslag added a comment.


  > Well it's not me that matters; it's all the other people with weird screens 
like mine, as well as the prople whose screens don't do this. We need to wither 
come up with a solution that works for everyone, or else mark some class of 
screen as misconfigured so we can tell those people to file kernel bugs.
  
  My goal was to propose a solution that should work for everyone. For your 
laptop and the solution I proposed, the lowest brightness would still turn off 
the backlight, and the next brightness would turn it on, just as it currently 
does. For screens like mine where only brightness=0 turns off the display, the 
solution I proposed would never turn off the backlight. In both cases, it 
doesn't seem like there would be a regression.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: kjslag, sharvey, zzag, ngraham, romangg, plasma-devel, LeGast00n, 
ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13095: Scren brightness follow a quatratic progression

[Kevin Slagle]

kjslag added a comment.


  In D13095#467997 , @ngraham wrote:
  
  > Moving the brightness to zero is supposed to turn the //backlight// off, 
not the //screen// right?
  
  
  I don't see why. It seems better to put the screen into a low energy mode 
than to just turn off the backlight in order to save more watts. It also seems 
strange for the brightness slider to go all the way down to zero brightness. Do 
any other desktop environments or operating systems do that?
  
  In D13095#467733 , @kjslag wrote:
  
  > In order to deal with Nate's problem, perhaps instead of starting with 
brightness=0, we could just start with the next increment of brightness, which 
happens to be 2 for Nate. Nate's situation would be similar to before the patch 
was applied: only the lowest brightness setting turns off his screen. So there 
wouldn't be a regression for Nate.
  
  
  Are there still any objections to this solution?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: kjslag, sharvey, zzag, ngraham, romangg, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D13095: Scren brightness follow a quatratic progression

[Kevin Slagle]

kjslag added a comment.


  @romangg The current code selects from a discrete set of brightness levels 
which starts at zero. I was suggesting just removing the zero brightness level 
and using the next level as the minimum brightness level.
  
  I didn't realize turning off the screen at the lowest brightness level was an 
intended feature. My past 3 laptops didn't do that, and I've never seen a 
laptop do that on any operating system. It seems like an unintuitive feature 
and could confuse someone who doesn't realize that their screen is black 
because the brightness is all the way down. Perhaps it would be better to add a 
different hotkey for this function. (That's what I did.)
  
  Also note that setting brightness=0 probably isn't a power efficient way to 
turn the screen off. My laptop uses 4W less energy when I turn the screen off 
with
  xset dpms force off
  than when I set brightness=0.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: kjslag, sharvey, zzag, ngraham, romangg, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D13095: Scren brightness follow a quatratic progression

[Kevin Slagle]

kjslag added a comment.


  I like the idea of this patch. I just reassigned my brightness hotkeys to a 
small script that does almost exactly what this patch does before I discovered 
this patch.
  
  In order to deal with Nate's problem, perhaps instead of starting with 
brightness=0, we could just start with the next increment of brightness, which 
happens to be 2 for Nate. Nate's situation would be similar to before the patch 
was applied: only the lowest brightness setting turns off his screen. So there 
wouldn't be a regression for Nate.
  
  On my laptop, brightness=0 turns the screen off and brightness 1 through 46 
correspond to the minimum brightness, and max_brightness=24242. My proposal 
would also be better for me since then my screen wouldn't turn off with the 
minimum brightness.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D13095

To: thsurrel, #plasma, broulik, ngraham
Cc: kjslag, sharvey, zzag, ngraham, romangg, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart