D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Kishore Gopalakrishnan]

kishoreg added a comment.


  @ngraham There are no issues on the login screen. Everything fits fine there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23786

To: kishoreg, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 66601.
kishoreg added a comment.


  Rebase on `Plasma/5.17` branch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23786?vs=65896&id=66601

REVISION DETAIL
  https://phabricator.kde.org/D23786

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: kishoreg, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Kishore Gopalakrishnan]

kishoreg added a comment.


  Is this fine, or should I revert to the previous diff I uploaded?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23786

To: kishoreg, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 65896.
kishoreg added a comment.


  @filipf Is this better?
  
  Screenshot on small display (1366x768): F7342190: 
Screenshot_20190912_082244.png 
  
  Screenshot on big display (1920x1080): F7342191: 
Screenshot_20190912_082220.png 

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23786?vs=65643&id=65896

REVISION DETAIL
  https://phabricator.kde.org/D23786

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: kishoreg, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

[Kishore Gopalakrishnan]

kishoreg created this revision.
kishoreg added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  This patch removes some spacing which was making the 'switch users' button 
get slightly cut off on small displays (1366x768). Quite a few old laptops have 
screens of this size, so it is good to take into account that display size as 
well, as long as it doesn't negatively affect the appearance for large displays.
  
  BUG: 410801
  
  Before this patch:
  Lockscreen on small display (1366x768): F7330101: 
Screenshot_20190908_153934.png 
  Lockscreen on big display (1920x1080): F7330096: 
Screenshot_20190908_153856.png 
  
  After this patch:
  Lockscreen on small display (1366x768): F7330105: 
Screenshot_20190908_153559.png 
  Lockscreen on big display (1920x1080): F7330103: 
Screenshot_20190908_153646.png 

TEST PLAN
  Lock screen when connected to a low-res display and check that the 'switch 
users' button isn't cut off.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23786

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: kishoreg, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

[Kishore Gopalakrishnan]

kishoreg added a comment.


  The problem is that the original patch was changing the maximum range of the 
sliders for application streams and microphones as well. This seemed a bit 
counter-intuitive, as for example capping the volumes of both the speaker and 
the music player at 15% would lead to an 'effective volume' of 2.25%. There was 
also the issue that the slider maximum ranges for applications displayed this 
weird behaviour of having the reduced range applied only after the user 
interacted with them. In addition, the behaviour was inconsistent with the 
behaviour when the maximum volume is >100% (it doesn't automatically apply 
'raise maximum volume' to application streams, for instance). After applying 
this patch, the limit only applies to the hardware volume keys and scrolling on 
the applet, which is also consistent with the behaviour when the limit is set 
to >100%.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23768

To: kishoreg, ngraham, romangg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

[Kishore Gopalakrishnan]

kishoreg created this revision.
kishoreg added reviewers: ngraham, romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  Recently, I submitted this patch (https://phabricator.kde.org/D23082) which 
had a side-effect which I hadn't noticed at the time: If the user-configured 
maximum volume for the applet was less than 100%, it would also use this as the 
maximum value on the sliders for all streams.
  
  Before this patch:
  Devices tab: F7326896: Screenshot_20190907_163232.png 

  Applications tab: F7326898: Screenshot_20190907_163203.png 

  I have set the maximum volume in the applet settings to be 15%, and this 
setting is applied to all the sliders. Even the sliders which are intially at 
100% get their maximum reset to 15% as soon as I interact with them. Note, for 
example, how even the microphone volume is capped at 15%.
  
  After this patch:
  Devices tab: F7326904: Screenshot_20190907_164055.png 

  Applications tab: F7326905: Screenshot_20190907_162913.png 

  The maximum volume is still set to 15% in the applet settings, but this is 
does not affect the maximum values of the sliders for the device or application 
streams.

TEST PLAN
  1. Right-click on applet > 'Configure audio
  2. Try to set maximum volume < 100% and click 'OK'.
  3. Scroll on the systray icon to change maximum volume. Check if it is 
limited to the configured maximum.
  4. Open the applet and check that all the streams are not limited to the 
value to the value the user configured in the applet.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23768

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: kishoreg, ngraham, romangg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23082: Allow to set maximum volume < 100%

[Kishore Gopalakrishnan]

kishoreg created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  Currently one cannot set the maximum volume < 100%. This feature is required 
because some earphones / speakers are more sensitive than others and may get 
damaged at high volumes. In particular, one easily ends up overshooting safe 
volume levels when using the mouse scroll wheel to change the volume. After 
this change, one can safely use the mouse wheel to change volume.
  
  BUG: 404387

TEST PLAN
  1. Right-click on applet > 'Configure audio volume'.
  2. Try to set maximum volume < 100% and click 'OK'.
  3. Scroill on the systray icon to change maximum volume. Check if it is 
limited to the configured maximum.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23082

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21828: Invert controls direction for process priority slider

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 59864.
kishoreg added a comment.


  Do the same for the ionice slider too.

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21828?vs=59862&id=59864

REVISION DETAIL
  https://phabricator.kde.org/D21828

AFFECTED FILES
  processui/ReniceDlgUi.ui

To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21828: Invert controls direction for process priority slider

[Kishore Gopalakrishnan]

kishoreg created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  Since low 'nice' values correspond to high priority, the slider labels are 
inverted so that 'higher' corresponds to a lower nice number. However, this was 
not done for the slider control, resulting in the arrow keys moving the slider 
in the direction opposite to that expected by the user. This patch fixes this 
by setting invertedControls to 'true' for the priority slider.
  
  BUG: 408074

TEST PLAN
  1. Open Ksysguard.
  2. Go to the tab that lists processes.
  3. Right click on a process and select 'Set Priority'.
  4. Click on the slider that sets the CPU priority.
  5. Press the left and right arrow keys on the keyboard and check if they move 
the slider in the appropriate direction.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21828

AFFECTED FILES
  processui/ReniceDlgUi.ui

To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21620: Handle Esc properly when focus is in searchbox

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 59340.
kishoreg marked an inline comment as done.
kishoreg added a comment.


  Added explanatory comment.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21620?vs=59260&id=59340

REVISION DETAIL
  https://phabricator.kde.org/D21620

AFFECTED FILES
  applet/contents/ui/Toolbar.qml

To: kishoreg, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21620: Handle Esc properly when focus is in searchbox

[Kishore Gopalakrishnan]

kishoreg created this revision.
kishoreg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
kishoreg requested review of this revision.

REVISION SUMMARY
  BUG: 408290
  
  If we place the focus in the searchbar, pressing Esc once dismisses the 
searchbar. However, pressing Esc after this does not dismiss the popup unless 
one manually intereacts with some other element in the popup. This patch fixes 
the issue.

TEST PLAN
  1. Open the Networks popup in the systray.
  2. Click the search icon above the channels list.
  3. Click in the search area to place focus there.
  4. Press Esc. Searchbar disappears.
  5. Press Esc again. Check that the popup closes.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21620

AFFECTED FILES
  applet/contents/ui/Toolbar.qml

To: kishoreg, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58849.
kishoreg edited the test plan for this revision.
kishoreg added a comment.


  Removed colon to keep string unchanged.
  
  Screenshot: F6858284: Screenshot_20190529_201418.png 


REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58838&id=58849

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui
  kcms/baloo/folderselectionwidget.cpp

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg added a comment.


  In D21414#471615 , @ngraham wrote:
  
  > With no items in the list view, the size looks perfect to me:
  >
  > F6858199: Screenshot_20190529_080727.png 

  >
  > Are you seeing something different?
  
  
  The initial size when it opens is set correctly. However, it doesn't seem to 
properly set a vertical minimum size, so one is able to make the window small 
enough that some of the widgets are accessible only by scrolling. I don't have 
any window rules that might apply to this window. I can also reproduce this in 
another user.
  
  Initial size set correctly: F6858259: Screenshot_20190529_200319.png 

  
  Minimum size while resizing is not set properly: F6858261: 
Screenshot_20190529_200346.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58838.
kishoreg edited the test plan for this revision.
kishoreg added a comment.


  Moved buttons to the left. F6858110: Screenshot_20190529_180905.png 

  
  I'll try to figure out how to set the size hint properly.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58797&id=58838

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui
  kcms/baloo/folderselectionwidget.cpp

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg added a comment.


  BTW, if I open the window standalone (from krunner), it allows me to resize 
it vertically so that the entire window gets scrollbars. F6856837: 
Screenshot_20190528_220702.png 
  I can't do this horizontally. Is there some vertical minimum size hint I have 
to set for the entire window? The minimum size is obeyed correctly when we open 
it as part of the System Settings window. Is this intended behaviour or a known 
bug? The result is a bit awkward to use, with scrollbars within scrollbars.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: GB_2, abetts, bruns, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58797.
kishoreg added a comment.


  Screenshot as of this diff: F6856823: Screenshot_20190528_220210.png 

  
  Are there any other changes that need to be made?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58786&id=58797

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58786.
kishoreg added a comment.


  This is awkward. I hadn't realized that I was supposed to use one space for 
indentation. Fixed as per the preexisting convention.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58784&id=58786

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58784.
kishoreg added a comment.


  I seem to have messed up the indentation in my previous diff. Here it is with 
the indentation fixed.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58781&id=58784

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg marked an inline comment as done.
kishoreg added a comment.


  BTW, checkboxes in other KCMs also seem to have the same spacing as this one 
had before this change. Is there a way to globally apply this spacing / padding 
consistently to QCheckBoxes in all KCMs for the sake of consistency? Perhaps 
some sort of global stylesheet that this should go into?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58781.
kishoreg added a comment.


  I've added a colon after the 'Do not search in these locations' text. I've 
also added spacing between the checkboxes and their text. I've put in 10 px for 
now. Is there a better way to do this?
  
  Without additional space after checkbox: F6856451: 
Screenshot_20190528_175816.png 
  
  With additional space after checkbox: F6856452: 
Screenshot_20190528_180003.png 
  
  The change seems to have slightly reduced the vertical space between the 
checkboxes, so should I add padding to the stylesheet?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58723&id=58781

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg updated this revision to Diff 58723.
kishoreg edited the summary of this revision.
kishoreg added a comment.


  This patch incorporates Nate's suggestion to remove the box around the 
'exclude folders' area. I've added screenshots of all three cases (with spacer, 
with box, and without box) to a previous comment.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21414?vs=58684&id=58723

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg added a comment.


  Before change: F6854280: Screenshot_20190519_105621.png 

  Initial patch: F6854282: Screenshot_20190527_181359.png 

  With box removed: F6854285: Screenshot_20190527_190128.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

To: kishoreg, #baloo, #vdg, ngraham
Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

[Kishore Gopalakrishnan]

kishoreg created this revision.
kishoreg added a reviewer: Baloo.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  I just removed a spacer. It seems like it was added intentionally, so I'm not 
sure if removing it breaks something. I couldn't find any broken behaviour with 
this change.
  
  BUG: 407709

TEST PLAN
  1. Open kcm_baloofile. Check if the exclude folders section fills all 
available space.
  2. Resize the window to make it larger. Check that the exclude folders 
section resizes to match the window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21414

AFFECTED FILES
  kcms/baloo/configwidget.ui

To: kishoreg, #baloo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart