D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  I don't see why, it was proposed after mine and it is already merged... Does 
not seem to need a review.
  Thanks for answering though.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  Probably the consequence of not reviewing changes? This one can probably be 
abandoned.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: alexde, meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21273: Add support for newer linux kernel power_supply API

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson, broulik, hein
Cc: meven, alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  Sorry but someone will have to also commit for me, I don't have commit access.
  Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 updated this revision to Diff 64689.
luc4 added a comment.


  Updated according to requests.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22774?vs=63248=64689

REVISION DETAIL
  https://phabricator.kde.org/D22774

AFFECTED FILES
  applets/notes/package/contents/ui/ShortcutMenuItem.qml
  applets/notes/package/contents/ui/main.qml
  applets/notes/plugin/documenthandler.cpp
  applets/notes/plugin/documenthandler.h

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  In D22774#519403 , @davidedmundson 
wrote:
  
  > > Could you update the title and summary so they reflect what's in the 
patch now?
  >
  > This isn't done (or at least phabricator is being unhelpful and not showing 
it if you have)
  
  
  Not sure if I understand, sorry. I changed the title and I read an update 
message:
  
  > luc4 retitled this revision from Add a button to the notes applet to clear 
formatting to In the note applet, always paste without formatting by default. 
Add an action to paste preserving formatting in the contextual menu..
  
  Sorry, not very comfortable with phabricator yet.

INLINE COMMENTS

> davidedmundson wrote in main.qml:238
> Where does this libplasma5 domain come from?

I think I copied from here: https://git.reviewboard.kde.org/r/121698/diff/1/#. 
Is it outdated maybe?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21470: Properly read stderr when data is ready from the daemon.

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21470

To: luc4, davidedmundson, mlaurent, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  Anyone?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 updated this revision to Diff 63248.
luc4 added a comment.


  I updated the TextArea element to QtQuickControls 2 (this may not be 
necessary) and I added a menu with a look more consistent with the rest of 
Plasma. The menu includes the same actions we had before: undo, redo, copy, 
cut, paste, delete, clear and select all. In addition, I added a new paste 
action (now the default paste action), which pastes without formatting. Also, I 
set the shortcut to remove formatting before pasting.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22774?vs=62634=63248

REVISION DETAIL
  https://phabricator.kde.org/D22774

AFFECTED FILES
  applets/notes/package/contents/ui/ShortcutMenuItem.qml
  applets/notes/package/contents/ui/main.qml
  applets/notes/plugin/documenthandler.cpp
  applets/notes/plugin/documenthandler.h

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  Hello, I'm not a Plasma expert, but I tried to investigate the situation a 
bit in Qt and plasma-framework. My understanding is that the notes applet is 
using TextArea from QtQuick.Controls 1. TextArea 1 creates an edit menu inside 
Qt, probably the one defined in EditMenu_base.qml 
.
 I see it is probably possible to replace this. Not sure if this can be 
modified, it is not public.
  
  I could not find a default edit menu in QtQuick.Controls 2. I see that 
plasma-framework also includes a template for TextArea from QtQuick.Controls 2. 
It may be possible to define a edit menu in the template, making it disabled by 
default. This would have the benefit of showing a menu with a more consistent 
look.
  
  Can someone confirm this? What about upgrading the TextArea element in notes 
to QtQuick.Controls 2 and adding the menu in the template in plasma-frameworks? 
Or is there a edit menu available already somewhere? If someone could provide a 
hint I may be able to go on with this. Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  Also notice that the current aspect doesn't look good nor consistent with the 
rest of Plasma.
  In my researches I found this: 
https://git.reviewboard.kde.org/r/121698/diff/1/#, which is a bit what I'm 
doing. I'll stop with this until an agreement is found.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  I started to reimplement the menu. This is how it looked for me:
  
  F7135687: Screenshot_20190801_223211.png 

  
  this is how a new menu would look like (some items and shortcuts are missing):
  
  F7135723: shot.png 
  
  Do you think I'm on the right track? Or do you think it is possible to add an 
item to the previous menu somehow? Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  I had a look at the code. It is my understanding the menu is provided by Qt 
and it is probably styled somewhere. Is this correct? I can't find a way to 
modify it, so I guess I'll have to create an entirely new menu. Before I go on, 
can someone maybe confirm if I'm on the right track? Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  I'll try to implement that behavior then.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 added a comment.


  Yes, I couldn't find a better icon so I temporarily used this.
  
  All the options you proposed are perfectly fine for me. I personally find the 
button sufficient but if you decide for something else I can try to update my 
patch. Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22774: Add a button to the notes applet to clear formatting

[Luca Carlon]

luc4 created this revision.
luc4 added reviewers: davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REVISION SUMMARY
  It frequently happens to me that formatting is preserved when pasting into 
the note, making the note a bit confusing. I added a button to remove 
formatting from the pasted text so that I can apply a different one with the 
other buttons. For example this is what I get when pasting from konsole:
  
  F7104991: Screenshot_20190727_124929.png 

  
  but I'd personally prefer to be able to do something like this, in this 
specific case:
  
  F7104992: Screenshot_20190727_125006.png 

  
  Do you think this makes sense? Would you be against integrating this?
  Thanks.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml
  applets/notes/plugin/documenthandler.cpp
  applets/notes/plugin/documenthandler.h

To: luc4, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 marked an inline comment as done.
luc4 added a comment.


  I do not have commit access, can someone do it for me? Thank you guys for 
your help!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 updated this revision to Diff 62488.
luc4 added a comment.


  Updated to respect code conventions.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22306?vs=62338=62488

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/plugin/draghelper.cpp
  applets/kicker/plugin/draghelper.h

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 updated this revision to Diff 62338.
luc4 added a comment.


  Removed volatile modifier, not probably useful in that context.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22306?vs=62170=62338

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/plugin/draghelper.cpp
  applets/kicker/plugin/draghelper.h

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 updated this revision to Diff 62170.
luc4 added a comment.


  This is another implementation that follows the same principale of the 
previous ones, but moves the responsibility of maintaining the state to the 
`dragHelper` object. This requires to postpone the reset of the state after the 
onRelease event.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22306?vs=61994=62170

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml
  applets/kicker/plugin/draghelper.cpp
  applets/kicker/plugin/draghelper.h

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 added a comment.


  Hello! Thank you for your help! I can see the logs now.
  Unfortunately I cannot update my patch according to your notes. According to 
the logs I added, I do not see values that I wouldn't expect. Can you describe 
somehow how to reproduce the behavior you reported?
  Thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 updated this revision to Diff 61994.
luc4 added a comment.


  Also reset the state variable during onPress.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22306?vs=61271=61994

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 added a comment.


  Unfortunately I'm not able to get logs from plasma-desktop. Can someone 
explain how (assuming this is possible) to write logs in this portion of code 
and read? Or can you point me to docs? I tried to add console.log calls and 
read using journalctl but I don't see the logs. Can someone help so I can check 
the values of those variables? Thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

To: luc4, ngraham, trmdi, #plasma
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22306: Do not skip code launching application in application dashboard

[Luca Carlon]

luc4 created this revision.
luc4 added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REVISION SUMMARY
  Since Plasma 5.16, clicks over the icons are frequently ignored. See 
https://bugs.kde.org/show_bug.cgi?id=408748 for more info. This patch is an 
attempt to fix that seems to work for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22306

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridView.qml

To: luc4, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21470: Properly read stderr when data is ready from the daemon.

[Luca Carlon]

luc4 created this revision.
luc4 added reviewers: davidedmundson, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REVISION SUMMARY
  When stderr data is sent from the daemon, it seems that libksysguard was 
actually reading the stdout buffer. Also, as the comment states, it was trying 
to read potentially incomplete UTF-8 data. This patch reads from stderr and 
also only reads entire lines, preventing incomplete UTF-8 data buffers.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21470

AFFECTED FILES
  ksgrd/SensorShellAgent.cpp

To: luc4, davidedmundson, mlaurent
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

[Luca Carlon]

luc4 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REPOSITORY
  R106 KSysguard

BRANCH
  batt

REVISION DETAIL
  https://phabricator.kde.org/D21273

AFFECTED FILES
  ksysguardd/Linux/acpi.c

To: luc4
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Thank you: "Luca carlon ".

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Should I do something else or will someone else take care of committing?

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Hello. No, sorry, I don't think I have it.

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  I added the explicit charset to all scss files.

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 updated this revision to Diff 54514.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19931?vs=54457=54514

REVISION DETAIL
  https://phabricator.kde.org/D19931

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 added a comment.


  Happened on KDE Neon in docker.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

To: luc4, gepardo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

[Luca Carlon]

luc4 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D19931

AFFECTED FILES
  src/gtk318/widgets/_notebook.scss
  src/gtk320/widgets/_treeview.scss

To: luc4
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart