D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

2020-03-09 Thread Marcus Behrendt 
mbehrendt added a comment.


  Okay. I just tested with other themes. 
  Was so used to Materia that I forgot about them.
  Yeah an option would make sense then. 
  I'd like to look into this but that will probably take some time.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

2020-03-09 Thread Marcus Behrendt 
mbehrendt added a comment.


  In D27939#624440 , @mvourlakos 
wrote:
  
  > I think it is better to have an option for this in order to not be applied 
always when the user reverses the indicator..
  >
  > And also are you sure that this way the growing circle animation of the 
indicator is still working correctly?
  
  
  I am not sure if an option makes sense here as the group triangle looks kind 
of broken when reversed
  F8167640: 2020-03-09_17-24.png 
  
  Circle animation still works
  F8167643: circle.flv 

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

2020-03-08 Thread Marcus Behrendt 
mbehrendt created this revision.
mbehrendt added a reviewer: mvourlakos.
mbehrendt added a project: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mbehrendt requested review of this revision.

REVISION SUMMARY
  The triangle indicating window grouping would not move to the other side.
  Like for the BackLayer this is done for the corresponding part of the 
FrontLayer

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D27939

AFFECTED FILES
  indicators/org.kde.latte.plasma/package/ui/FrontLayer.qml

To: mbehrendt, mvourlakos
Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, 
jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, niccolove, ragreen, lavender, 
ZrenBot, ngraham, himcesjf, mvourlakos, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D17467: digital-clock: Show events on initial expansion for all time zones

2018-12-13 Thread Marcus Behrendt 
mbehrendt added inline comments.

INLINE COMMENTS

> mart wrote in CalendarView.qml:60
> another way you can try is to do it on Component.onCompleted: {  }

Yes I laready considered that. But when I tried your suggestion, I figured out 
what the real problem was that the events are initially not shown. So there is 
no need to manually initialize the holidaysList. According to that I updated 
the revision and diff.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

To: mbehrendt, #plasma, plasma-devel
Cc: mart, broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D17467: digital-clock: Show events on initial expansion for all time zones

2018-12-11 Thread Marcus Behrendt 
mbehrendt marked an inline comment as done.
mbehrendt added inline comments.

INLINE COMMENTS

> mart wrote in CalendarView.qml:60
> instead of storing a local hasExpanded, could you just check for 
> holidaysList.model not being null?

No, the model initially seems to be an empty list.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

To: mbehrendt, #plasma, plasma-devel
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D17467: digital-clock: Show events on expanding applet

2018-12-11 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47409.
mbehrendt added a comment.


  remove local variable "currentDate" and use "getDate" instead of "getDay"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47407=47409

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt, #plasma, plasma-devel
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D17467: digital-clock: Show events on expanding applet

2018-12-11 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47407.
mbehrendt added a comment.


  Total overhaul of the patch. 
  I think I found the root cause for the events not being displayed.
  I also  inserted some if clauses to reduce calculations.
  I also removed setting holidaysList.model = null as I could not reproduce the 
issue that was mentioned in the comment.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47317=47407

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt, #plasma, plasma-devel
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D17467: digital-clock: Show events on expanding applet

2018-12-10 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47317.
mbehrendt added a comment.


  more simplifications

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47256=47317

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

2018-12-10 Thread Marcus Behrendt 
mbehrendt added a reviewer: Plasma.
mbehrendt added a comment.




REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

To: mbehrendt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

2018-12-10 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47256.
mbehrendt marked an inline comment as done.
mbehrendt added a comment.


  fix typos

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47255=47256

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

2018-12-10 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47255.
mbehrendt added a comment.


  only once set hasExpanded = true

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47252=47255

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

2018-12-10 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47252.
mbehrendt added a comment.


  This should even be lighter

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47248=47252

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

2018-12-10 Thread Marcus Behrendt 
mbehrendt updated this revision to Diff 47248.
mbehrendt added a comment.


  Besides checking for isExpanded this prevents from updating the holidaysList 
twice by checking if the date needs to be reset.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17467?vs=47241=47248

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

2018-12-09 Thread Marcus Behrendt 
mbehrendt created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mbehrendt requested review of this revision.

REVISION SUMMARY
  When expanding the digital-clock applet the holidayList is not updated, so 
that events for the current day are not shown. 
  In order to show the events for the current day after expansion one had to 
click on another day in the month view and then click back to the current day.
  
  This patch fixes that by properly updating the holidaysList's model. It also 
reduces redundancy by putting the update routine in a separate function.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: mbehrendt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart