D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Maximiliano Curia]

maximilianocuria added inline comments.

INLINE COMMENTS

> queryptrace.cpp:26
> +server.sun_family = AF_UNIX;
> +sprintf(server.sun_path, "/tmp/kcrash_%lld", 
> QCoreApplication::applicationPid());
> +if (::connect(sfd, (struct sockaddr *), sl) == 0) {

Please honour TMPDIR or, even better, use QTemporaryDir (this will also make 
the generated path unpredictable), and create the socket inside.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks
Cc: maximilianocuria, adridg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12781: Fix filetypestest

[Maximiliano Curia]

maximilianocuria closed this revision.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D12781

To: maximilianocuria, #plasma, kossebau, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12780: Avoid including the generated config-X11 private header

[Maximiliano Curia]

maximilianocuria closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12780

To: maximilianocuria, #plasma, mlaurent, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12781: Fix filetypestest

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, kossebau.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  Concatenating strings results in paths like: ".qttestconfig" instead of
  the expected ".qttest/config". QMimeDatabase doesn't check the cache
  files on every call, but only if at least 5 seconds have passed.
  
  The failed tests can be seen here:
  
https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.10/lastCompletedBuild/testReport/(root)/TestSuite/filetypestest/
  and:
  
https://ci.debian.net/data/autopkgtest/unstable/amd64/k/kde-cli-tools/266696/log.gz

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  fix_tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12781

AFFECTED FILES
  keditfiletype/tests/filetypestest.cpp

To: maximilianocuria, #plasma, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12780: Avoid including the generated config-X11 private header

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, mlaurent.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

TEST PLAN
  building the installed headers no longer fails

REPOSITORY
  R120 Plasma Workspace

BRANCH
  priv_header_include (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12780

AFFECTED FILES
  libtaskmanager/virtualdesktopinfo.h

To: maximilianocuria, #plasma, mlaurent
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria added a comment.


  Btw, Debian users confirmed that this fixes the issue: 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897687
  
  And in the "Kwallet does not work" thread here: 
https://lists.debian.org/debian-kde/2018/05/threads.html#1

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12702

To: maximilianocuria, #plasma, aacid
Cc: tsimonq2, asturmlechner, rdieter, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria added a comment.


  I'm not sure, but I think that pam could be called from a process that has 
the stdin/stdout/stderr redirected to pipes, so disconnecting those for a long 
lived process would avoid a possible broken pipe. Now, if that's so, why it's 
not clossing stdin and stdout, I don't know.
  
  Also, why hardcode the 64 instead of closing all the available fds (see 
https://github.com/openssh/openssh-portable/blob/master/openbsd-compat/bsd-closefrom.c
 as an example).
  
  I guess there is room for improvement, but the change here follows the same 
logic of the original behavior. The original code starts kwalled without an 
stderr, and so does this version.
  
  Happy hacking,

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12702

To: maximilianocuria, #plasma, aacid
Cc: tsimonq2, asturmlechner, rdieter, davidedmundson, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

This revision was automatically updated to reflect the committed changes.
Closed by commit R107:8da1a47035fc: Avoid giving an stderr to kwallet (authored 
by maximilianocuria).

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12702?vs=33675=33676

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: asturmlechner, rdieter, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria updated this revision to Diff 33675.
maximilianocuria added a comment.


  Update comments as suggested.
  
  I'll push this, and ask the users that reported the issue to also test the 
  fixed version.
  
  Thanks.

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12702?vs=33663=33675

BRANCH
  cve_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: asturmlechner, rdieter, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria added a comment.


  I can reproduce the issue in openbox and cinnamon. I think this is related to 
qt5ct which always tries to print things to stderr. I guess having the debug 
messages enabled would also trigger the issue.
  
  The problem is no longer present with either version of the patch.

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12702

To: maximilianocuria, #plasma, aacid
Cc: asturmlechner, rdieter, davidedmundson, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria updated this revision to Diff 33663.
maximilianocuria added a comment.


  A somewhat simpler version, just delay the close(2) call.
  I was testing this and trying to look for some documentation about the use of
  the fds in pam modules. I'm pretty sure that you can't keep them, but I've 
found
  anything that talks about this.

REPOSITORY
  R107 KWallet PAM Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12702?vs=33657=33663

BRANCH
  cve_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12702: Avoid giving an stderr to kwallet

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, aacid.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  The fixes for CVE-2018-10380 introduced a regression for most users not
  using kde, and some for kde sessions. In particular the reorder of the
  close calls and creating a new socket caused that the socket is always
  assigned the file descriptor 2, aka stderr.
  
  BUG: 393856

TEST PLAN
  It works

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  cve_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12702

AFFECTED FILES
  pam_kwallet.c

To: maximilianocuria, #plasma, aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12658: Migrate to ecm_qt_declare_logging_category

[Maximiliano Curia]

maximilianocuria closed this revision.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D12658

To: maximilianocuria, #plasma, ivan, lbeltrame, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12658: Migrate to ecm_qt_declare_logging_category

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, ivan, lbeltrame.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  During D12656 , it was suggested that it 
would be better to migrate to
  ecm_qt_declare_logging_category.

TEST PLAN
  It builds

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  log_category

REVISION DETAIL
  https://phabricator.kde.org/D12658

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/service/Activities.cpp
  src/service/Application.cpp
  src/service/CMakeLists.txt
  src/service/Debug.cpp
  src/service/Debug.h
  src/service/Event.cpp
  src/service/Module.cpp
  src/service/Plugin.cpp
  src/service/Resources.cpp
  src/service/ksmserver/KSMServer.cpp
  src/service/plugins/runapplication/CMakeLists.txt
  src/service/plugins/runapplication/RunApplicationPlugin.cpp
  src/service/plugins/sqlite/CMakeLists.txt
  src/service/plugins/sqlite/Database.cpp
  src/service/plugins/sqlite/Database.h
  src/service/plugins/sqlite/ResourceLinking.cpp
  src/service/plugins/sqlite/ResourceScoreCache.cpp
  src/service/plugins/sqlite/StatsPlugin.cpp
  src/service/plugins/sqlite/Utils.h
  src/service/plugins/virtualdesktopswitch/VirtualDesktopSwitchPlugin.cpp

To: maximilianocuria, #plasma, ivan, lbeltrame
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12656: Use category logging

[Maximiliano Curia]

maximilianocuria closed this revision.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D12656

To: maximilianocuria, #plasma, lbeltrame, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12656: WIP: Use category logging

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Plasma, lbeltrame, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  Without this kactivitymanagerd logs way too much information about the
  users activities/actions (see the reported Debian bug as an example) by
  default. Logging categories can be easily enabled by the developers that
  are interested in this information.
  
  This change uses the categories that were already defined in Debug.cpp,
  using resources for database and utils related messages, activities for
  activities for activities and ksm related, and applications for the
  rest.
  
  Debian-BUG: https://bugs.debian.org/897388

TEST PLAN
  It builds

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  log_category (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12656

AFFECTED FILES
  src/common/database/Database.cpp
  src/common/database/Database.h
  src/service/Activities.cpp
  src/service/Application.cpp
  src/service/Plugin.cpp
  src/service/ksmserver/KSMServer.cpp
  src/service/plugins/runapplication/CMakeLists.txt
  src/service/plugins/runapplication/RunApplicationPlugin.cpp
  src/service/plugins/sqlite/CMakeLists.txt
  src/service/plugins/sqlite/Database.cpp
  src/service/plugins/sqlite/ResourceLinking.cpp
  src/service/plugins/sqlite/ResourceScoreCache.cpp
  src/service/plugins/sqlite/Utils.h
  src/utils/continue_with.h
  src/utils/dbusfuture_p.cpp
  src/utils/debug_and_return.h

To: maximilianocuria, #plasma, lbeltrame, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Kscreenlocker 5.10.5.1

[Maximiliano Curia]

¡Hola David!

El 2017-08-31 a las 18:12 +0100, David Edmundson escribió:
Kscreenlocker has a feature that doesn't play nicely with the latest nvidia 
driver making the entire thing crash.


Given locking the screen is quite an important operation, we've made an 
immediate release that works round that issue.


The tarball is named 5.10.5.1  as 5.10.5 has already been publicly released and 
is at the usual place.



No other part of Plasma 5.10.5 has been re-generated.


Thanks for the fix and the release, could you please also push the git tag for
5.10.5.1?

Happy hacking,
--
"EIEIO Go home and have a glass of warm, dairy-fresh milk"
-- The GNU C Library Reference Manual, Chapter 2.2, Error Codes
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Re: KWin 5.10.3.1 update

[Maximiliano Curia]

¡Hola Martin!

El 2017-07-09 a las 14:52 +0200, Martin Flöser escribió:
If there are changes which can be backported we will do. Please do 
not cherry pick changes, that makes it impossible for us to ensure 
the quality or investigate bugs.



That's not what I was trying to do here.


With my Debian hat on, Plasma LTS is what I'm trying to keep in the 
stable release, for components not under a LTS release cherry picking 
might be our only option, though.


Then there is no need to ask, we will backport the changes which make 
sense. Bugfixes are dangerous as this issue here shows.


I'm asking because not every maintainer tracks lts, or at least not every 
issue in the lts. Sorry if it bothers you, but I still need to ask for issues 
that I can't test on my own.


Happy hacking,
--
"Haskell is faster than C++, more concise than Perl, more regular than Python,
more flexible than Ruby, more typeful than C#, more robust than Java, and has
absolutely nothing in common with PHP."
-- Audrey Tang
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Re: KWin 5.10.3.1 update

[Maximiliano Curia]

¡Hola Martin!

El 2017-07-08 a las 14:45 +0200, Martin Flöser escribió:

Am 2017-07-07 15:54, schrieb Maximiliano Curia:

El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió:
KWin has received an update to the 5.10.3 release. 5.10.3.1 
contains a fix for https://bugs.kde.org/show_bug.cgi?id=381870 
Freeze in KWin::checkGLError on startup which affects machines 
with an NVidia card.



The change is 
https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07



https://www.kde.org/info/plasma-5.10.3.php


kwin-5.10.3.1 4.4MB 
199e3a2593e9e66bbd6521ee8a25a012003d15f6b4bf2f102c70b798c9abd03a



Is this fix backportable to the 5.8 branch?



NO! The fix is for a regression introduced with 5.10.3.


The bug referenced mentions that the issue was seen in 5.8 and 5.9, that's why 
I'm asking.


If there are changes which can be backported we will do. Please do not 
cherry pick changes, that makes it impossible for us to ensure the 
quality or investigate bugs.


That's not what I was trying to do here.

With my Debian hat on, Plasma LTS is what I'm trying to keep 
in the stable release, for components not under a LTS release cherry picking 
might be our only option, though.


Happy hacking,
--
"If I ask another professor what he teaches in the introductory programming
course, whether he answers proudly "Pascal" or diffidently "FORTRAN," I know
that he is teaching a grammar, a set of semantic rules, and some finished
algorithms, leaving the students to discover, on their own, some process of
design."
-- Robert W. Floyd
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Re: KWin 5.10.3.1 update

[Maximiliano Curia]

¡Hola Jonathan!

El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió:
KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for 
https://bugs.kde.org/show_bug.cgi?id=381870 
Freeze in KWin::checkGLError on startup 
which affects machines with an NVidia card.



The change is 
https://commits.kde.org/kwin/aefb5f4dd9d41aa7377d56ece203089c73aefe07



https://www.kde.org/info/plasma-5.10.3.php


kwin-5.10.3.1 4.4MB 
199e3a2593e9e66bbd6521ee8a25a012003d15f6b4bf2f102c70b798c9abd03a


Is this fix backportable to the 5.8 branch?

Happy hacking,
--
"Las computadoras son inútiles, solo pueden darte respuestas."
-- Pablo Picasso
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/
---

(Updated Dec. 14, 2016, 1:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

The sddm breeze theme battery icon is trying to access the battery
percent. In a batteryless system it produces the syslog message:
Nov 14 22:28:23 samd sddm-greeter[3210]: 
file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
assign [undefined] to int

Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016

Debian-Bug: https://bugs.debian.org/844194


Diffs
-

  lookandfeel/contents/components/Battery.qml 
c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 

Diff: https://git.reviewboard.kde.org/r/129528/diff/


Testing
---


Thanks,

Maximiliano Curia

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

> On Nov. 22, 2016, 11:05 a.m., David Edmundson wrote:
> > lookandfeel/contents/components/Battery.qml, line 48
> > <https://git.reviewboard.kde.org/r/129528/diff/1/?file=486387#file486387line48>
> >
> > Given we don't actually care about the value used as long as it's an 
> > int as this will be hidden anyway, this can be just:
> > 
> > percent: pmSource.data["Battery"]["Percent"] || 0
> > 
> > without a function.
> 
> Maximiliano Curia wrote:
> I've changed this and the "Has Battery" (which I'm not sure if it can 
> ever be undefined, but it surely isn't always true). But, I won't be able to 
> test this right now.

Tested, the second version works fine.


- Maximiliano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101053
---


On Nov. 22, 2016, 1:04 p.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129528/
> ---
> 
> (Updated Nov. 22, 2016, 1:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The sddm breeze theme battery icon is trying to access the battery
> percent. In a batteryless system it produces the syslog message:
> Nov 14 22:28:23 samd sddm-greeter[3210]: 
> file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
> assign [undefined] to int
> 
> Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
> 
> Debian-Bug: https://bugs.debian.org/844194
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/Battery.qml 
> c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 
> 
> Diff: https://git.reviewboard.kde.org/r/129528/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

> On Nov. 22, 2016, 11:05 a.m., David Edmundson wrote:
> > lookandfeel/contents/components/Battery.qml, line 48
> > <https://git.reviewboard.kde.org/r/129528/diff/1/?file=486387#file486387line48>
> >
> > Given we don't actually care about the value used as long as it's an 
> > int as this will be hidden anyway, this can be just:
> > 
> > percent: pmSource.data["Battery"]["Percent"] || 0
> > 
> > without a function.

I've changed this and the "Has Battery" (which I'm not sure if it can ever be 
undefined, but it surely isn't always true). But, I won't be able to test this 
right now.


- Maximiliano


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/#review101053
-------


On Nov. 22, 2016, 10:50 a.m., Maximiliano Curia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129528/
> ---
> 
> (Updated Nov. 22, 2016, 10:50 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The sddm breeze theme battery icon is trying to access the battery
> percent. In a batteryless system it produces the syslog message:
> Nov 14 22:28:23 samd sddm-greeter[3210]: 
> file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
> assign [undefined] to int
> 
> Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016
> 
> Debian-Bug: https://bugs.debian.org/844194
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/Battery.qml 
> c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 
> 
> Diff: https://git.reviewboard.kde.org/r/129528/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/
---

(Updated Nov. 22, 2016, 1:04 p.m.)


Review request for Plasma.


Changes
---

Drop auxiliar function


Repository: plasma-workspace


Description
---

The sddm breeze theme battery icon is trying to access the battery
percent. In a batteryless system it produces the syslog message:
Nov 14 22:28:23 samd sddm-greeter[3210]: 
file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
assign [undefined] to int

Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016

Debian-Bug: https://bugs.debian.org/844194


Diffs (updated)
-

  lookandfeel/contents/components/Battery.qml 
c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 

Diff: https://git.reviewboard.kde.org/r/129528/diff/


Testing
---


Thanks,

Maximiliano Curia

Review Request 129528: Fix "Unable to assign [undefined] to int" log

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129528/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

The sddm breeze theme battery icon is trying to access the battery
percent. In a batteryless system it produces the syslog message:
Nov 14 22:28:23 samd sddm-greeter[3210]: 
file:///usr/share/sddm/themes/breeze/components/Battery.qml:39:18: Unable to 
assign [undefined] to int

Based on https://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016

Debian-Bug: https://bugs.debian.org/844194


Diffs
-

  lookandfeel/contents/components/Battery.qml 
c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf 

Diff: https://git.reviewboard.kde.org/r/129528/diff/


Testing
---


Thanks,

Maximiliano Curia

Re: Review Request 127963: Adding missing license

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/
---

(Updated May 19, 2016, 2:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.

The list of LGPL-2 only files is:
 examples/kpart/containmentshell.cpp
 examples/kpart/containmentshell.h
 examples/kpart/main.cpp
 examples/kpart/testshellpluginloader.cpp
 examples/kpart/testshellpluginloader.h
 src/kpart/plasmakpartview.cpp
 src/kpart/scripting/rect.cpp
 src/plasma/private/package_p.h
 src/plasma/private/packagestructure_p.h
 src/plasma/private/servicejob_p.h


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127963/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127963: Adding missing license

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127963/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but
some parts of the code are under a LGPL-2 only license and the LGPL
license requires shipping the full text with the source code.

The list of LGPL-2 only files is:
 examples/kpart/containmentshell.cpp
 examples/kpart/containmentshell.h
 examples/kpart/main.cpp
 examples/kpart/testshellpluginloader.cpp
 examples/kpart/testshellpluginloader.h
 src/kpart/plasmakpartview.cpp
 src/kpart/scripting/rect.cpp
 src/plasma/private/package_p.h
 src/plasma/private/packagestructure_p.h
 src/plasma/private/servicejob_p.h


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127963/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

[Maximiliano Curia]

On 10/12/15 17:45, Martin Klapetek wrote:
> However if I'm not mistaken, that set_target_properties call does not
> do what you imply it does. Setting empty PREFIX means that it will
> not prepend "lib" to the filename, eg. "libpam_kwallet.so", but will instead
> name it "pam_kwallet.so".
Oh, you are right. Sorry for the misleading comment.
> If you want to have it installed in /lib, just set CMAKE_INSTALL_PREFIX
> to "/", then it should install into /lib correctly.
Sadly setting the CMAKE_INSTALL_PREFIX in the Debian package seems to have no 
effect, so I'm stuck with the previous patch till I find a more elegant 
solution.

Happy hacking,
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

[Maximiliano Curia]

Hi,

On 28/08/15 04:39, Pinak Ahuja wrote:
> https://git.reviewboard.kde.org/r/124962/
> By Pinak Ahuja.
> 
> /Updated Aug. 28, 2015, 7:39 a.m./
> 
> *Repository: * kwallet-pam
> 
> pam_kwallet5.so was being installed to /lib(64) irrespective of what the
> installation prefix was set to. This patch fixes it.
> 
> pam_kwallet5.so seems to install under the directory set as 
> CMAKE_INSTALL_PREFIX
> 
> 
>   * CMakeLists.txt (f60ac41)
> 
> View Diff 

Sorry that I haven't seen this review before plasma 5.5 was released
(containing this change), but pam modules are traditionally installed in /lib,
that is, with an empty prefix. In the same CMakeLists.txt you can read the
intention to honor this:
set_target_properties (${library_name} PROPERTIES PREFIX "")

Sadly, this alone is not sufficient, thus the / in the install rule.

This change forces me to introduce the attached patch in the Debian package,
as pam modules should be available even if /usr is not mounted.

Happy hacking,
Index: kwallet-pam/CMakeLists.txt
===
--- kwallet-pam.orig/CMakeLists.txt	2015-12-10 14:12:47.823621683 +0100
+++ kwallet-pam/CMakeLists.txt	2015-12-10 20:45:45.967413893 +0100
@@ -36,7 +36,6 @@
 endif()
 
 add_library (${library_name} SHARED ${pam_kwallet_SRCS})
-set_target_properties (${library_name} PROPERTIES PREFIX "")
 target_link_libraries (${library_name}
${PAM_LIBRARIES}
${LIBGCRYPT_LIBRARIES}


signature.asc
Description: OpenPGP digital signature
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124290: Add missing licenses

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124290/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

There are quite a number of files under the LGPL-2.1 license and variants, and
some LGPL-2 *only* files, and thus it's recommeded to distribute the complete
license/

This patch was done after the rejection of the Debian ftpmasters of
plasma-desktop (https://lists.debian.org/debian-qt-kde/2015/07/msg00269.html)


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 
  COPYING.LIB PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124290/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124290: Add missing licenses

[Maximiliano Curia]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124290/
---

(Updated July 8, 2015, 8:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit dc41d66cb4422ce97c97c9ac71a0c1cd894e0bcd by Diane Trout 
on behalf of Maximiliano Curia to branch master.


Repository: plasma-desktop


Description
---

There are quite a number of files under the LGPL-2.1 license and variants, and
some LGPL-2 *only* files, and thus it's recommeded to distribute the complete
license/

This patch was done after the rejection of the Debian ftpmasters of
plasma-desktop (https://lists.debian.org/debian-qt-kde/2015/07/msg00269.html)


Diffs
-

  COPYING.LGPL-2 PRE-CREATION 
  COPYING.LIB PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124290/diff/


Testing
---


Thanks,

Maximiliano Curia

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: No co-installability of plasma 1 and 2

[Maximiliano Curia]

In article 25673324.XNmJUoyzAe@martin-desktop you wrote:
 in todays hangout Alex asked whether kwin binary is going to be renamed to
 kwin5 to make it possible to co-install plasma 1 and plasma 2.

 My opinion of that is, that we don't need to have things co-installable. 
 After 
 all kde-workspace doesn't provide libraries where it is useful to have them
 co-installable. It's applications.

What do you mean kde-workspace doesn't provide useful libraries? There are a
number of third party applications that depend on them.

Having a non-coinstallable kde-workspace 4.11 with the kf5 one means breaking
those applications, unless you keep an ABI compatible interface between
kde-workspace 4.11 and the kf5 one.

If you also plan to do an API change, it means to adapt those apps before they
are available for plasma2.

 My main argument is that our binary is currently called kwin and not 
 kwin4 
 and there also was no kwin3 binary. So in the past we didn't rename all our
 binaries and given that I don't see a reason to do so for Plasma2.

I wasn't part of the debian kde team when the migration from kde3 to kde4 took
place, but it's not a happy memory.

 If a distribution wants to provide Plasma1 and Plasma2 at the same time, they
 can just install them to different prefixes like how project neon does it. 
 The 
 time span when users might want to co-install Plasma 1 and 2 is very short.
 Maybe one release cycle. I don't think that it's worth the effort to change
 hundreds of binaries, libraries, plugins, desktop files, source code to 
 locate 
 and load plugins for this short period of time.

 Anybody who disagrees? Your arguments please :-)

I think that this should be discussed in the packagers list, which will help to
sync our points of views among different distributions.

I can't predict the future, or how disruptive the change from kde 4 to kf5
will be for our users. As far as I could see, it shouldn't be, but the gnome
migration to gnome 3, the fallback support drop, etc, has brought new kde users
and some heartfillings about migrations, so making it as smooth as possible
will probably pay of.

-- 
Porque no respeta el orden natural en el que se leen las cosas
 ¿Por qué contestar al principio del mensaje es malo?
Saludos /\/\ /\  `/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel