T13927: Pop!_os style window tiling

[Mikhail Zolotukhin]

gikari added a comment.


  Please, excuse me for shameless plug, but I am currently working on a "new" 
tiling script extension to KWin here . I've 
observed, that the other tiling extensions' development was stale over the year 
and decided to fork one of them with the goal of making the code base more 
modern and new developer friendly. Also, I am aiming for the **Wayland 
support** and wanted to publish the script on the KDE Store once that's ready, 
but my Wayland session is not stable right now on Plasma 5.22, and I haven't 
found a good way to debug the script right now in the VM (I just want to see 
script logs for now). In the end, I really want the script to be an **official 
KDE project** and to be a part of default Plasma distribution once it's mature 
enough (don't want to be a perfectionist, so I am not sure where to draw a line 
here).
  
  For those who are interested, Bismuth is a fork of Krohnkite - which is a 
very powerful extension that provides tiling window manager experience in 
Plasma. Right now it is working pretty much the same on the X11 session as 
Krohnkite. The only differences are only visible from the developers' 
perspective: I ported the project to the new more intuitive and documented 
build system, ported the codebase to ES modules and introduced the new unit 
testing framework (still WIP, as there were no real working unit-tests before, 
lol. I am going to fix it, of course). I also introduced some basic CI workflow 
with formatting, linting and building along with some other smaller changes.
  
  So, if someone is really interested in getting Bismuth off the ground, I 
would encourage them to take a look and contributing 
 in all possible 
ways!

TASK DETAIL
  https://phabricator.kde.org/T13927

To: gikari
Cc: gikari, ervin, kloop, plasma-devel, cblack, niccolove, ngraham, rafasantos, 
Orage, cacarry, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

kde-gtk-config repository name change

[Mikhail Zolotukhin]

Hello,

I am the de facto maintainer of the kde-gtk-config repository. As of now the 
name of this repository on GitLab is "KDE GTK Configurator" and the description 
is "Syncs KDE settings to GTK applications". I think there could be a better 
name and a description for the project. Current one has a couple of issues:

1. Current repository name itself does not show the purpose of the things, that 
it contains. Why it exists? What problem it actually solves?
2. The description is not accurate. It's not only about syncing some kde (maybe 
Plasma?) settings to GTK. It also provides a way to set a GTK theme in Plasma.
3. The name does not show its relation to Plasma and the fact, that that 
"Configurator" only works in that desktop envinroment.

Actually the code's job in that repository is providing a smooth experience for 
GTK applications in Plasma, so that they looks more native, in other words it 
integrates GTK into Plasma.

Given all of that I think the better name for the repository would be 
"plasma-gtk-integration", On GitLab it could be called "Plasma GTK Integration" 
with the description "Components necessary to integrate GTK applications into 
the Plasma Desktop".

What do people think of that change? Does anyone have any suggestions to 
improve the renaming?

Best regards,
Mikhail Zolotukhin

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  OK, let's wait a bit more until GIMP transitions. Still I would like to 
combine the GTK2 and GTK3 themes selection into one combobox or a list.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29749

To: gikari, cblack, #plasma, #vdg
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  See D29749 

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D29748

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/2

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26777: [App Style KCM] Port away from QDBusInterface

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  I have a better idea of how to get rid of the dbus calls entirely in the 
future.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26777

To: gikari, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

[Mikhail Zolotukhin]

gikari added a comment.


  In D29749#671032 , @ngraham wrote:
  
  > 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. 
I'm not saying don't do this, but maybe it's a bit premature?
  
  
  Yes. That's why i only hide the UI. The backend still sets the GTK2 theme too 
alongside with GTK3. This only removes the possibility to select different 
themes for different versions of GTK.
  
  > 2. Now that the GTK theme page only has one small row of items in it, it 
seems a bit silly to have on a separate page. It feels like it could be moved 
into the footer on the main page.
  
  The amount of the elements is still too many for an inline setting, may be 
popup would suffice. However I want to do something like this:
  F8319943: image.png 
  (Mind the tabs, that's an old mockup)
  
  In general I made these patches, so that:
  
  1. I could move the preview management code into plasma-dekstop (for GTK2 it 
relays on direct config management and it's very hacky)
  2. After that make the KCM use  KConfigXT (and additionally prettify it). 
This allows this bug   to be fixed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29749

To: gikari, cblack, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since Inkscape is finally moved to GTK3, it's time to start GTK2
  deprecation process.
  
  What this does is just a hiding GUI for setting GTK2 themes.
  Despite of that, GTK2 will be set implicitly along with the GTK3 theme.
  
  Some FAQ:
  Q: What if there is no GTK2 theme with the name of GTK2 one?
  A: Chances of that is close to zero. Most, if not all, GTK3 themes
  contain gtk-2.0 folder along with gtk-3.0 one. Even if there is such
  a theme, currently it also will not work. That's because of xsettingsd,
  that overrides GTK2 configuration file.
  
  Q: What about Breeze Dark GTK2 theme for GIMP?
  A: GIMP has a dark theme inside. Breeze-dark will not work for the same
  reason as the above - xsettingsd with only one theme for GTK2 and GTK3.
  
  GUI changes: now there only one option for GHNS and only one combo for themes,
  title for GHNS has changed

TEST PLAN
  1. Apply D29748  and this patch
  2. Restart Kded5
  3. Open Application Style KCM > GTK Style
  4. Change GTK Theme, check if both GTK2 and GTK3 apps have the same theme
  5. Check Get New... is working

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hide-gtk2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29749

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/gtk2_themes.knsrc
  kcms/style/gtk3_themes.knsrc
  kcms/style/gtk_themes.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/package/contents/ui/GtkStylePage.qml

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Since Inkscape is finally moved to GTK3, it's time to start GTK2
  deprecation process.
  
  What this does is just a hiding direct interface for setting GTK2 themes.
  Despite of that, GTK2 will be set implicitly along with the GTK3 theme.
  
  Some FAQ:
  Q: What if there is no GTK2 theme with the name of GTK2 one?
  A: Chances of that is close to zero. Most, if not all, GTK3 themes
  contain gtk-2.0 folder along with gtk-3.0 one. Even if there is such
  a theme, currently it also will not work. That's because of xsettingsd,
  that overrides GTK2 configuration file.
  
  Q: What about Breeze Dark GTK2 theme for GIMP?
  A: GIMP has a dark theme inside. Breeze-dark will not work for the same
  reason as the above - xsettingsd with only one theme for GTK2 and GTK3.

TEST PLAN
  See KCM revision

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  hide-gtk2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29748

AFFECTED FILES
  CMakeLists.txt
  gtkproxies/CMakeLists.txt
  gtkproxies/preview.c
  gtkproxies/preview.ui
  gtkproxies/reload.c
  kconf_update/gtktheme.cpp
  kded/configeditor.cpp
  kded/configeditor.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/themepreviewer.cpp
  kded/themepreviewer.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari added a comment.


  In D28623#666890 , @trmdi wrote:
  
  > Just a question, SierraBreezeEnhanced has a feature called "Unison 
hovering". Does this support it?
  
  
  Also, I think, that to support that you actually need to do a lot of upstream 
changes.
  
  1. Provide unison hovering API for KDecoration (i.e. option must exist for 
all decorations)
  2. Provide unison hovering API for GTK, so that there will be a config option 
in gsettings to turn on/off unison hovering.
  3. Once the above is done it is actually possible to implement syncing. But I 
doubt that the above patches will be accepted.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari added a comment.


  In D28623#666890 , @trmdi wrote:
  
  > Just a question, SierraBreezeEnhanced has a feature called "Unison 
hovering". Does this support it?
  
  
  No. That's because it is the GTK, who is responsible for hovering behavior. I 
only change the appearance of the buttons. Behavior stays the same.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82365.
gikari added a comment.


  - Add support for aurorae themes
  - Plastic does not work, but in that case decoration buttons in GTK apps are 
Breeze

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82294=82365

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/auroraedecorationpainter.cpp
  kded/kwin_bridge/auroraedecorationpainter.h
  kded/kwin_bridge/decorationpainter.cpp
  kded/kwin_bridge/decorationpainter.h
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h
  kded/kwin_bridge/standarddecorationpainter.cpp
  kded/kwin_bridge/standarddecorationpainter.h

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari added a comment.


  In D28623#666400 , @cblack wrote:
  
  > While this is neat, I'm fairly sure that creating the CSS for this in a 
manner that works across themes is going to be hard if not impossible.
  
  
  I'm not completely sure about this right now, but currently I'm only think of 
supporting our own GTK theme - Breeze-GTK.
  
  > Even our own Breeze GTK uses palette swaps rather than unique pixmaps for 
every state.
  
  I got it working somehow on Breeze Gtk:
  F8300792: buttons.mp4 
  
  However I'm not sure how to provide CSS, that I'm using now. It's rather big 
to hardcore IMO. Should I use Sass and install generated file in 
`~/.config/gtk-3.0/windowdecorations.css`, so I could just enable/disable it 
with include statement?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82294.
gikari added a comment.


  Export buttons with fixed geometry (Now all buttons are exported with the 
same size)

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82266=82294

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82266.
gikari added a comment.


  Support the maximize button in the checked state

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82206=82266

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82206.
gikari added a comment.


  - Render buttons to SVGs

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82167=82206

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82167.
gikari added a comment.


  - Make buttons work with Breeze theme by respecting pallete.

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82143=82167

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82143.
gikari edited the summary of this revision.
gikari edited the test plan for this revision.
gikari added a comment.


  - Use unique_ptr for buttons
  - Propagate events to buttons
  
  Things to do:
  
  - Figure out why does this only work with some decorations (hello and sierra 
breeze enchanced) and for some does not (breeze, plastic, particially oxygen)
  - Properly scale images into Pixmap
  - Consider exporting in SVG
  - Write CSS into custom gtk css file

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82124=82143

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Mikhail Zolotukhin]

gikari added a comment.


  Is it possible to integrate the search into the help menu, if it exists 
already or create an entry for it. Much like macOS does.
  F8290151: Screenshot_20200506_214642.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82124.
gikari added a comment.


  - Export decorations as png images
  
  Global things to do:
  
  - Export decorations in 3 different states: normal, clicked and hovered
  - Consider exporting in SVG
  - Write CSS into custom gtk css file

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=79488=82124

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fd6f3bacc91e: [GTK Subpage] Hide Breeze Dark for GTK3 
(authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29176?vs=81166=81178

REVISION DETAIL
  https://phabricator.kde.org/D29176

AFFECTED FILES
  kcms/style/gtkthemesmodel.cpp

To: gikari, cblack
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29176: [GTK Subpage] Hide Breeze Dark for GTK3

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Given, that Breeze GTK grabs its colors from color scheme and Breeze
  Dark doesn't do that creating by that confusion within the users, dark
  theme should be hidden from the list of available GTK3 themes.
  
  Keeping dark variant may be useful for other desktop environments where
  there is no dynamic recoloring and there aren't any color scheme settings.
  
  CCBUG: 413198

TEST PLAN
  Check if the GTK3 combobox in Application Style > GNOME/GTK Application Style 
does not have the "Breeze-Dark" option.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hide-breeze-gtk-dark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29176

AFFECTED FILES
  kcms/style/gtkthemesmodel.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 
applications (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=79263=80166

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma, ngraham
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28070: [KRDB] Remove GTK3 color export

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:23aeddc99ad6: [KRDB] Remove GTK3 color export (authored 
by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28070?vs=9=80165

REVISION DETAIL
  https://phabricator.kde.org/D28070

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h
  kcms/style/kcmstyle.cpp

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  So, is it ok to land? If so, approve please.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28658: [krdb] Drop GTK2 colour exporting

[Mikhail Zolotukhin]

gikari resigned from this revision.
gikari added a comment.


  No objections from me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28658

To: cblack, #plasma, ngraham, davidedmundson
Cc: gikari, fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28658: [krdb] Drop GTK2 colour exporting

[Mikhail Zolotukhin]

gikari added a comment.


  We also need to remove the remaining GTK stuff from here once D28070 
 and D28072 
 are landed. Does anyone else wants to test 
the later?

INLINE COMMENTS

> krdb.cpp:642
>// Export colors to non-(KDE/Qt) apps (e.g. Motif, GTK+ apps)
>if (exportColors)
>{

Is this somewhat relevant to GTK?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28658

To: cblack, #plasma, ngraham, gikari, davidedmundson
Cc: gikari, fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  Hm, this is bizarre. I've tested once again and now the bug I mentioned 
before is gone.
  
  @ngraham Did you launch system settings (colors section) **after applying** 
D28070  to plasma-desktop? Without that 
patch it won't work possibly due to conflicts.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638800 , @gikari wrote:
  
  > I also noticed a **dynamic** recoloration bug: it doesn't work if the app 
is launched with the color scheme, that it was using in the previous launch. To 
make it work I have to change color scheme and relaunch the app. The app 
therefore changes its color scheme to a new one and it is now reacting to color 
scheme change properly (i.e. changes it without restart).
  
  
  Can you reproduce this behavior?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#643693 , @ngraham wrote:
  
  > Still doesn't work for me:
  >
  >   gnome-chess --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
  >   Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module"
  >
  
  
  Actually the specified module is loaded. The error message comes from the 
module specified in the settings.ini.
  
  If it weren't the message would be something like this (i.e. mentioning 
absolute module path):
  
Gtk-Message: 17:56:18.012: Failed to load module 
"/home/gikari/kde/usr/lib/gtk-3.0/modules/libcolorreload-gtkd-module.so"
  
  Check the recoloration - does it work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 79488.
gikari added a comment.


  - Add missed Licence header
  - Remove unnecessary CMake commands

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=79485=79488

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Currently GTK applications with Client Side Decoration always use
  decorations from the respected GTK CSS theme. Because of CSS nature
  different themes may handle decorations in the headerbars differently,
  therefore making modifying them via user css a very hard task. However,
  what we can do is to use decoration appearance syncing in our own theme
  
  - Breeze GTK.
  
  Breeze GTK uses images (.svg and .png) for representing decoration
  buttons (close, minimize, maximize) appearance. So to achieve the goal
  what we can do (hypothetically) is the following:
  
  1. Ask KWin to render current decoration buttons to custom QPainters. For 
each button we must export every state (clicked, hovered, normal).
  2. QPainters then export decoration buttons to pixmaps or/and svg.
  3. Then we will save those images to assets folder in 
`~/.config/gtk-3.0/assets` or something like that.
  4. Then we will create custom .css for Breeze GTK, that tells the theme to 
use these saved images for decorations.
  
  I am currently having trouble with the first part, trying to ask KWin to
  do QPainter stuff. Currently it crashes, without any understandable for
  me reason. If someone can, please help.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 79263.
gikari added a comment.


  - Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=78823=79263

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  @ngraham Did you manage to load the recoloration module into the GTK app by 
one or another way?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:0580098ab4cd: [GTK Config] Parameterise GTK config editing 
(authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=79089=79156

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari updated this revision to Diff 79089.
gikari marked 2 inline comments as done.
gikari added a comment.


  - Remove `explicit` QVariant wrappers

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=77909=79089

BRANCH
  arcpatch-D27100

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari added a comment.


  Ping

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638514 , @ngraham wrote:
  
  > Same error about not being able to find the module. Sorry for not being 
clear.
  
  
  Does the specified path contain (`/home/nate/kde/usr/lib64/gtk-3.0/`) 
`modules` directory with the `libcolorreload-gtk-module.so` file?
  If there it is, try launching GTK app with:
  
gtk-app --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
  
  The parameter must be **absolute** path.
  
  In D28072#638515 , @cblack wrote:
  
  > You can provide a full path to the library instead of letting GTK do name 
to library resolution.
  
  
  Yes, you can, but that's inconvenient. According to this 
 you can specify 
`GTK_PATH` environment variable, so that GTK knows where to search for modules. 
It works for me at least.
  
  I also noticed a **dynamic** recoloration bug: it doesn't work if the app is 
launched with the color scheme, that it was using in the previous launch. To 
make it work I have to change color scheme and relaunch the app. The app 
therefore changes its color scheme to a new one and it is now reacting to color 
scheme change properly (i.e. changes it without restart).

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638356 , @ngraham wrote:
  
  > The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but 
nonetheless there is no effect. :(
  
  
  Is the GTK application throwing the same error, that the module is not found, 
or recoloration does not work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638170 , @ngraham wrote:
  
  > Hmm, when following those instructions, I get the following console error:
  >
  >   Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  >
  >
  > And the color scheme doesn't change. The `colorreload-gtk3-module` target 
did get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`
  
  
  Try `export GTK_PATH='$PREFIX/kde/usr/lib/gtk-3.0/' ` before launching app. 
This should make module to load.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638173 , @cblack wrote:
  
  > GTK™ isn't too fond of trying to load stuff from outside the standard 
directories.
  
  
  How can this be fixed?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 78823.
gikari marked an inline comment as done.
gikari added a comment.


  - Rebase on master
  - Add recoloration module check

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77860=78823

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  In D28360#636687 , @kossebau wrote:
  
  >   Edit: and yes, I agree CMake has awful flaws here when it comes to our 
needs to properly communicate dependencies to fellow developers & packagers. I 
am trying to give you best practices done so far elsewhere in KDE software to 
deal with this, to ensure consistent patterns in the approach to the same 
problem :)
  
  
  Did I understand correctly, that to make the dependency required for 
distribution packagers you need to substitute existing code with the following 
(i.e. only change the `PURPOSE` text, but keep `find_package` as it was):
  
find_package(XSettingsd)
set_package_properties(XSettingsd PROPERTIES
DESCRIPTION "XSettingsd daemon"
TYPE RUNTIME
PURPOSE "Required to have GTK Config kded module to apply settings to 
GTK applications on the fly"
)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari added a comment.


  Everything is fine on CI.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  In D28360#636610 , @kossebau wrote:
  
  > Edit: The proposed solution to make it simply required only forces 
packagers to add that and all what it pulls in as build-time dependency to 
their package creation, even if not needed for the package creation itself at 
all, which is not something packagers like (wastes resources on package build 
servers).
  
  
  The thing is that xsettigsd is a daemon, which allows some settings, which 
were set to GTK applications, to be applied to the current running GTK 
applications without restarting them. Without it settings are still applied, 
but GTK applications must be restarted in order to use new settings. Daemon 
absence is the user experience sacrifice and IMO we should use this daemon by 
default. So, that's why I proposed making the daemon dependency mandatory.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  In D28360#636435 , @eszlari wrote:
  
  > In D28360#636418 , @gikari wrote:
  >
  > > But the option is enabled by default and needs to be explicitly disabled. 
This seems to be an overengineered solution. It basically says, that XSettingsd 
is an optional dependency, which already is.
  >
  >
  > But it make the packager aware, that this dependency exists, instead of at 
runtime, the end user wondering, why his/her Plasma desktop behaves differently 
from others.
  >
  > Anecdote: obs-studio checks for pulseaudio at compile time, but fails 
silently(!) when it can't find it, leading users to wonder, why they can't 
record audio.
  
  
  Again, why not just make XSettingsd required? It's simpler.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  But the option is enabled by default and needs to be explicitly disabled. 
This seems to be an overengineered solution. It basically says, that XSettingsd 
is an optional dependency, which already is.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  In D28360#636404 , @eszlari wrote:
  
  > I would like to have this in 5.18
  
  
  We cannot add mandatory dependencies to the stable branches/releases. 
Currently it's an optional dependency. If you want to make it mandatory, only 
5.19 and later are possible options.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  Why just not make xsettingsd required?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +include(GNUInstallDirs)
> +

May be this could be moved to parent CMakeLists with other includes?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari accepted this revision.
gikari added a comment.
This revision is now accepted and ready to land.


  Ok, let's keep our eyes on CI now. Everything should be fine, since the 
dependencies didn't change.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D28086

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:22
> +pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0)
> +pkg_check_modules(giomm REQUIRED IMPORTED_TARGET giomm-2.4)
> +

If I understand correctly this line is redundant.

> CMakeLists.txt:7
>  target_compile_definitions(gtk_preview PRIVATE 
> "-DDATA_DIR=\"${KDE_INSTALL_FULL_DATADIR}/kcm-gtk-module/\"")
> -target_link_libraries(gtk_preview ${GTK2_LIBRARIES} ${GTK2_GIOMM_LIBRARY})
> +target_link_libraries(gtk_preview PkgConfig::GTK+2 PkgConfig::giomm)
>  install(TARGETS gtk_preview RUNTIME DESTINATION "${LIBEXEC_INSTALL_DIR}")

And `PkgConfig::giomm` is redundant too.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari added a comment.


  See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for 
possible resolution

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari added a comment.


  This has been reverted. @cblack, please take a look 

 at what has happened. Seems like CI is missing some dependency.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77909.
gikari added a comment.


  Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=77185=77909

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:3
> +
> +enable_language(C)
> +

Why is this needed? Aren't the CMake default languages in project (parent 
CMakeLists) both `CXX` and `C`?

> reloader.c:35
> +__attribute__((visibility("default"))) void gtk_module_init(gint *argc, 
> gchar ***argv[]) {
> +path = g_strconcat(g_get_home_dir(), "/.config/gtk-3.0/colors.css", 
> NULL);
> +file = g_file_new_for_path(path);

This is hardcoded directory.  The $XDG_CONFIG_HOME may be set to something 
other, not only the default.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77860.
gikari edited the summary of this revision.
gikari added a comment.


  - Remove the recolor module. It is D28076 
 now

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77855=77860

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#629441 , @cblack wrote:
  
  > In D28072#629439 , @gikari wrote:
  >
  > > > You simply test the recolouration like how it's been up until 
now—restart the applications.
  > >
  > > It doesn't work. This is what I was talking about:
  > >
  > > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  >
  >
  > You seem to be testing with Nautilus, which doesn't actually close when you 
press the close button.
  
  
  Yes, you're right, but I also tested it with Lutris. It also does not work. 
But with gedit it works fine.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  > You simply test the recolouration like how it's been up until now—restart 
the applications.
  
  It doesn't work. This is what I was talking about:
  
  > It seems like it applies randomly whenever the GTK app would like to update 
the colors, but with that module it's predictable.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari planned changes to this revision.
gikari added a comment.


  - I should add the recoloration module to autoload with GTK applications
  
  In D28072#629422 , @cblack wrote:
  
  > The GTK+ module shouldn't be in this patch, as it and the functions to 
write CSS are separate changes.
  
  
  Then how do I test the recoloration? It seems like it applies randomly 
whenever the GTK app would like to update the colors, but with that module it's 
predictable. Or do you mean to make it as a separate patch, but make this one 
depend on it?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77855.
gikari added a comment.


  - Rebase on master
  - Add recoloration module

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77723=77855

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari accepted this revision.
gikari added a comment.
This revision is now accepted and ready to land.


  Fine.  It builds.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari requested changes to this revision.
gikari added a comment.
This revision now requires changes to proceed.


  I reverted the commits ( R99:306e01d86ab9a891ec70219802ce01572b0d4025 
 and 
R99:306e01d86ab9a891ec70219802ce01572b0d4025 
 ) 
for recoloration module, to fix the CI. I think you need to create a new 
revision to add recolaration module in a proper way and with proper fixes to 
GNOME libraries handling.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari added a comment.


  It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` 
module? It actually uses it inside already, but with some bugs, that prevents 
from building last patch.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added a comment.


  I tried to change these ones to `GTK3_LIBRARY` and `GLIB2_LIBRARY`, but now 
it throws this:
  
/home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:37: 
undefined reference to `g_type_check_instance_cast'

INLINE COMMENTS

> CMakeLists.txt:10
> +  ${GLIB_LIBRARIES}
> +  ${GTK_LIBRARIES}
> +)

It seems like you use other variables, than in other parts of kde-gtk-config.
In other places it uses `GTK3_LIBRARY` and `GLIB2_LIBRARY` variables from find 
module. The versions also appear in `target_include_directories` command.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added a comment.


  Seems like I've made a mistake. This does not build.
  
/home/gikari/kde/src/kde-gtk-config/color-reload-module/reloader.c:21:10: 
fatal error: gtk/gtk.h: No such file or directory
   21 | #include 
  |  ^~

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28070: [KRDB] Remove GTK3 color export

[Mikhail Zolotukhin]

gikari updated this revision to Diff 9.
gikari added a comment.


  Fix "forgetting to pull local master"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28070?vs=7=9

BRANCH
  remove-gtk3-color-export-from-krdb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28070

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h
  kcms/style/kcmstyle.cpp

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28070: [KRDB] Remove GTK3 color export

[Mikhail Zolotukhin]

gikari updated this revision to Diff 7.
gikari added a comment.


  Diff against master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28070?vs=6=7

BRANCH
  remove-gtk3-color-export-from-krdb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28070

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colorssettings.kcfgc
  kcms/fonts/fontssettings.kcfgc
  kcms/icons/iconssettingsbase.kcfgc
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h
  kcms/style/kcmstyle.cpp
  kcms/style/stylesettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28070: [KRDB] Remove GTK3 color export

[Mikhail Zolotukhin]

gikari updated this revision to Diff 6.
gikari added a comment.


  Rebase on master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28070?vs=77720=6

BRANCH
  remove-gtk3-color-export-from-krdb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28070

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colorssettings.kcfgc
  kcms/fonts/fontssettings.kcfgc
  kcms/icons/iconssettingsbase.kcfgc
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h
  kcms/style/kcmstyle.cpp
  kcms/style/stylesettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari added a comment.


  Ping

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:702607595599: [GTK Config] Port all settings to 
KConfigWatcher (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27957?vs=77320=4

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27956: [Various KCMs] Notify about changes in GTK related settings

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:eede3025c84b: [Various KCMs] Notify about changes in GTK 
related settings (authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27956?vs=77313=3

REVISION DETAIL
  https://phabricator.kde.org/D27956

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colorssettings.kcfgc
  kcms/fonts/fontssettings.kcfgc
  kcms/icons/iconssettingsbase.kcfgc
  kcms/style/stylesettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: gikari, #plasma, ngraham, ervin, bport, meven
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:a581035b3f47: [GTK Config] Construct font style by hand 
instead of relying on Qt function (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27380?vs=76312=2

REVISION DETAIL
  https://phabricator.kde.org/D27380

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h

To: gikari, #plasma, ervin, bport, meven, davidedmundson, ngraham
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added a comment.


  
  
  > GTK needs to be configured to load the GTK module `colorreload-gtk-module`.
  
  You mean we need to add `gtk-modules=colorreload-gtk-module` to settings.ini? 
 And how to add this module to autoload in Wayland?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  color-reload-module (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:3
>  set(PROJECT_VERSION "5.17.80")
> -cmake_minimum_required(VERSION 2.8.12)
> +cmake_minimum_required (VERSION 3.4)
>  

Extra space

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  color-reload-module (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari accepted this revision.
gikari added a comment.
This revision is now accepted and ready to land.


  Nice! Does it need to be manually passed to GTK apps when testing D28072 
?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  color-reload-module (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +project(libcolorreload C)
> +

Why is this needed?

> CMakeLists.txt:3
> +
> +find_package(PkgConfig REQUIRED)
> +include(GNUInstallDirs)

Move to parent CMakeLists.txt

> CMakeLists.txt:4
> +find_package(PkgConfig REQUIRED)
> +include(GNUInstallDirs)
> +

Same

> CMakeLists.txt:6
> +
> +pkg_check_modules (GLIB glib-2.0)
> +pkg_check_modules (GTK gtk+-3.0)

Remove space before `(` and I guess this could also go to parent CMakeLists.txt?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:9
> +
> +add_library(
> +colorreload-gtk-module SHARED

add_library(colorreload-gtk-module SHARED
  reloader.c
  )

> CMakeLists.txt:14
> +
> +target_link_libraries(
> +colorreload-gtk-module PRIVATE

Sorry, this is a nitpick, but could you please make this look like this:

  target_link_libraries(colorreload-gtk-module
PRIVATE
  ${GLIB_LIBRARIES}
  ${GTK_LIBRARIES}

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari requested changes to this revision.
gikari added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:1
> +cmake_minimum_required ( VERSION 3.14 )
> +project ( libcolorreload C )

Would you mind setting this at the parent CMakeLists.txt?

> CMakeLists.txt:2
> +cmake_minimum_required ( VERSION 3.14 )
> +project ( libcolorreload C )
> +

Would you mind making this as a subproject?

> CMakeLists.txt:10
> +
> +add_library ( colorreload-gtk-module 
> +  SHARED

Also, could you remove spaces around parentaces to match the CMake style with 
the one, that is in kded and kconf_update directories?

> CMakeLists.txt:14
> +
> +target_link_libraries(
> +colorreload-gtk-module

Isn't the PUBLIC/PRIVATE modifiers a good modern CMake practice? The same for 
target_include_directories

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> configeditor.cpp:107
> +modifyColorsCssFile(colorsDefinitions);
> +// FIXME Find a way to update colors on the fly
> +}

Also, I would like to move D24275  to 
kde-gtk-config repo too with autoloading the module to all GTK applications.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 application

[Mikhail Zolotukhin]

gikari created this revision.
gikari added a reviewer: cblack.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Move from krdb (see D28070 ) with some 
refactorings.
  
  Depends on D28070 
  Depends on D24275 
  Depends on D27956 
  Depends on D27957 

TEST PLAN
  This is how I got it to work, improvements to the process is appreciated
  
  1. Apply the above patches
  2. In breeze-gtk patch: `git rebase master`
  3. Compile breeze-gtk and then copy `$PREFIX/kde/usr/share/themes/Breeze` to 
`/usr/share/themes` (replacing the existing Breeze (make a backup))
  4. Run GTK application with a module from D24275 
 (see the patch for the instructions)
  5. Run systemsettings and reapply Breeze theme from Application Style KCM
  6. Go to colors KCM, open it side by side with GTK3 application launched 
before
  7. Restart `kded5`
  8. Change the color scheme. The GTK3 application should change it colors.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28070: [KRDB] Remove GTK3 color export

[Mikhail Zolotukhin]

gikari created this revision.
gikari added a reviewer: cblack.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  This will be moved to kde-gtk-config module, once ready.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-gtk3-color-export-from-krdb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28070

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h
  kcms/style/kcmstyle.cpp

To: gikari, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari closed this revision.
gikari added a comment.


  https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: cfeck, jriddell, ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77320.
gikari added a comment.


  - Add forgotten toolbar style

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27957?vs=77317=77320

BRANCH
  port-all-to-kconfigwatcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: [GTK Config] Remove redundant reparse configuration call

[Mikhail Zolotukhin]

gikari abandoned this revision.
gikari added a comment.


  In favor of D27957 

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Also remove redundant reparse configuration calls and change
  the ways of reading some settings accordingly.
  
  Depend on: D27956 

TEST PLAN
  1. Apply D27956 
  2. Restart kded5
  3. Apply all the settings possible:
- Fonts
- Icons
- Color Scheme (for dark theme preference setting)
- Icons on buttons
- Icons in menus
- Toolbar style
- Scrollbar behaviour (what happens if you click on scrollbar)
- Animations speed (though I haven't touch it in this diff)
- Decorations button order
  4. Check if all the settings are correctly applied to GTK applications

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  port-all-to-kconfigwatcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27956: [Various KCMs] Notify about changes in GTK related settings

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Also save colors before saving colorScheme name, so that we can
  correctly use heuristic in GTK Config, after the moment we know, that
  color scheme has changed.

TEST PLAN
  Check if the order of saving colors and saving color scheme name does not 
break anything.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  notify-about-changes-in-gtk-related-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27956

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colorssettings.kcfgc
  kcms/fonts/fontssettings.kcfgc
  kcms/icons/iconssettingsbase.kcfgc
  kcms/style/stylesettings.kcfgc
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port cursor theme sync to KConfigWatcher

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:715e497d94b9: [Gtk Config] Port cursor theme sync to 
KConfigWatcher (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27943?vs=77293=77304

REVISION DETAIL
  https://phabricator.kde.org/D27943

AFFECTED FILES
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27942: [Cursors KCM] Notify about cursor change

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1fb3c36496cf: [Cursors KCM] Notify about cursor change 
(authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27942?vs=77275=77303

REVISION DETAIL
  https://phabricator.kde.org/D27942

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc

To: gikari, #plasma, ngraham, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77293.
gikari marked an inline comment as done.
gikari added a comment.


  Update function name

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27943?vs=77276=77293

BRANCH
  cursors-to-config-watcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27943

AFFECTED FILES
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> ngraham wrote in gtkconfig.h:89
> `onKcmInputSettingsChange` (capitalize the I in Input)
> 
> Maybe also capitalize KCM?
> 
> Or maybe call it `onCursorSettingsChange`

This name comes from configuration file name and this function (theoretically) 
triggers on every change of the config, not necessary on cursor theme change, 
so I think that naming it `onCursorSettingsChange` is not very fair.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27943

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27943: [Gtk Config] Port fonts sync to KConfigWatcher

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Port from deprecated dbus signal to KConfigWatcher.
  
  Depends on: D27942 

TEST PLAN
  1. Apply D27942 
  2. Restart kded5
  3. Apply any cursor theme from KCM
  4. Check if GTK applications heve the changed cursor

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  cursors-to-config-watcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27943

AFFECTED FILES
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27942: [Cursors KCM] Notify about cursor change

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Notify all users of `KConfigWatcher` about cursor theme change.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  notify-about-cursor-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27942

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27107: [GTK Config] Remove redundant reparse configuration call

[Mikhail Zolotukhin]

gikari added a comment.


  Ping! After D27904  this should be 
working.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26777: [App Style KCM] Port away from QDBusInterface

[Mikhail Zolotukhin]

gikari added a comment.


  Ping! Do I sound reasonable? Any suggestions how can it be simplified without 
depending on `kde-gtk-config`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26777

To: gikari, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

[Mikhail Zolotukhin]

gikari added a comment.


  Ping! Does it work for everybody? For me everything is OK.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari added a comment.


  Ok. So, can I land it or should I wait for other reviewers? Also, should I 
make the dependency `REQUIRED` or leave it optional?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari added a comment.


  In D25324#624229 , @eszlari wrote:
  
  > This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  
  
  `xsettingsd` is started by the daemon itself, if it's not instantiated 
already.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Mikhail Zolotukhin]

gikari added a comment.


  Ping!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich
Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77185.
gikari added a comment.


  Use `arg` instead of + + + + + +

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=74855=77185

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart