D26499: remove an unused header

[Miklós Máté]

miklosm added a reviewer: Plasma: Workspaces.
miklosm added a comment.


  Can I get a review on this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26499

To: miklosm, #plasma_workspaces
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26499: remove an unused header

[Miklós Máté]

miklosm created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
miklosm requested review of this revision.

REVISION SUMMARY
  It was imported from libksysguard, but I don't know why.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26499

AFFECTED FILES
  dataengines/systemmonitor/sensorclient.h

To: miklosm
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm added a comment.


  BTW the updateInterval, which caused the conflict, is not as useful as it 
sounds, because the data source sends new data at a fixed 1Hz frequency.

REVISION DETAIL
  https://phabricator.kde.org/D12857

To: miklosm, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm updated this revision to Diff 35855.
miklosm added a comment.


  Rebased on current master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12857?vs=34080=35855

REVISION DETAIL
  https://phabricator.kde.org/D12857

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: miklosm, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm added a comment.


  In D12857#274212 , @ngraham wrote:
  
  > Do you need someone to land this for you, Miklós?
  
  
  Yes, please.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12857

To: miklosm, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm added a comment.


  In D12857#273608 , @ngraham wrote:
  
  > Screenshot please! See 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots
  
  
  Screenshots of how the network monitor looks like on a vertical panel:
  Before:
  F5890087: Screenshot_20180604_221905.png 

  After:
  F5890089: Screenshot_20180604_221924.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12857

To: miklosm, #plasma, mart
Cc: ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm added inline comments.

INLINE COMMENTS

> mart wrote in cpu.qml:45
> CPU usage should be removed from the context as this is now used for 
> different things?

It's used for the same things as before. The only change is that this function 
no longer formats the whole label, just returns the string that goes into the 
label.

The other widgets don't specify this much info in the context, so it can be 
trimmed. I don't know how many translations need to be updated though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12857

To: miklosm, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

[Miklós Máté]

miklosm created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
miklosm requested review of this revision.

REVISION SUMMARY
  When the applet is on a vertical panel, its horizontal size is limited, and 
the speedLabel clashes with the name label. I fixed that by moving the speed 
values below the sensor name in this case.
  
  I also added some cleanups unintentionally (the first three hunks), as I 
couldn't find a way to change the diff after it's submitted. They remove an 
unneeded import, and fix some uninitialized variable warnings. Feel free to 
ignore them.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12857

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: miklosm
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12853: Calendar widget: fix resize

[Miklós Máté]

miklosm created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
miklosm requested review of this revision.

REVISION SUMMARY
  If the fullRepresentation has a minimum size, the applet cannot be shrinked 
back to show the compactRepresentation.
  
  Alternative fix: make the switch size larger than the minimum size of the 
fullRepresentation

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12853

AFFECTED FILES
  applets/calendar/package/contents/ui/main.qml

To: miklosm
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Review Request 129308: Calendar: clear selection on opening

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/
---

(Updated Dec. 14, 2016, 11:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c30edd9bedfd13459eecdf110fcb61d8f465523a by David 
Edmundson on behalf of Miklós Máté to branch Plasma/5.8.


Repository: plasma-workspace


Description
---

When opening the calendar popup of the digital clock plasmoid, the selection is 
on the day the popup was last opened -- possibly days or weeks ago. This patch 
fixes that.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 

Diff: https://git.reviewboard.kde.org/r/129308/diff/


Testing
---


Thanks,

Miklós Máté

Re: Review Request 129308: Calendar: clear selection on opening

[Miklós Máté]

> On Nov. 2, 2016, 3:49 p.m., David Edmundson wrote:
> > do you have commit access?
> 
> Miklós Máté wrote:
> I don't have commit access.

I noticed that this hasn't been committed yet. Is there something wrong with 
the patch?


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Nov. 2, 2016, 1:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 1:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

[Miklós Máté]

> On Nov. 2, 2016, 2:49 p.m., David Edmundson wrote:
> > do you have commit access?

I don't have commit access.


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

[Miklós Máté]

> On Nov. 2, 2016, 1:53 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/CalendarView.qml, line 53
> > <https://git.reviewboard.kde.org/r/129308/diff/1/?file=483828#file483828line53>
> >
> > This original code is trying to make sure we only reset once instead of 
> > twice as one will be wasteful.
> > 
> > Wouldn't changing it to if (isExpanded) work correctly too?

I don't know how expensive it is to reset the selection, but sure, using "if 
(isExpanded)" works too.


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100502
-------


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129309: Fix broken systemloadviewer tooltip

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129309/#review100492
---


Ship it!




Oh, you're right. I forgot to add this to my commit. Thanks for fixing it.

- Miklós Máté


On Nov. 2, 2016, 7:15 a.m., Antonio Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129309/
> ---
> 
> (Updated Nov. 2, 2016, 7:15 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Miklós Máté.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Commit 346b492 broke the systemloadviewer tooltip, it's trying to use a 
> variable that is not defined.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml bf299b7 
> 
> Diff: https://git.reviewboard.kde.org/r/129309/diff/
> 
> 
> Testing
> ---
> 
> Tooltip works again
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

Re: Review Request 129230: Count only applications in memory usage

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/
---

(Updated Oct. 19, 2016, 10:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 346b492b362a1ee74ea809de80c0cdaa60ef1dda by David 
Edmundson on behalf of Miklós Máté to branch Plasma/5.8.


Repository: kdeplasma-addons


Description
---

This restores the behavior of the widget to match the original C++ version. 
Buffers and cached do not really contribute to memory usage, because file 
system cache gets dropped, if applications need more memory. See MemFree vs. 
MemAvailable in /proc/cpuinfo.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 

Diff: https://git.reviewboard.kde.org/r/129230/diff/


Testing
---


Thanks,

Miklós Máté

Re: Review Request 129230: Count only applications in memory usage

[Miklós Máté]

> On Oct. 19, 2016, 8:45 p.m., David Edmundson wrote:
> > Thanks
> > 
> > Do you have commit access?
> > Also there's a bug report on this that should be closed with this commit.

I don't have commit access. Do you mean bug #366342 ?


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/#review100147
---


On Oct. 19, 2016, 8:35 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129230/
> ---
> 
> (Updated Oct. 19, 2016, 8:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This restores the behavior of the widget to match the original C++ version. 
> Buffers and cached do not really contribute to memory usage, because file 
> system cache gets dropped, if applications need more memory. See MemFree vs. 
> MemAvailable in /proc/cpuinfo.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 
> 
> Diff: https://git.reviewboard.kde.org/r/129230/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Review Request 129230: Count only applications in memory usage

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129230/
---

Review request for Plasma.


Repository: kdeplasma-addons


Description
---

This restores the behavior of the widget to match the original C++ version. 
Buffers and cached do not really contribute to memory usage, because file 
system cache gets dropped, if applications need more memory. See MemFree vs. 
MemAvailable in /proc/cpuinfo.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9b2ad1e 

Diff: https://git.reviewboard.kde.org/r/129230/diff/


Testing
---


Thanks,

Miklós Máté