Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been discarded. Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter. Diffs - browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop 93b7c62 browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop a06a168 browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop 9d04068 browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 Diff: https://git.reviewboard.kde.org/r/117139/diff/ Testing --- Thanks, Nikolaos Chatzidakis
Re: Review Request 117101: This patch fixes font size behaviour when pmc is resized.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/ --- (Updated Sept. 22, 2016, 8:38 p.m.) Status -- This change has been discarded. Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This is my first patch trying to hack PMC. Untill now, whenever PMC was resized, the menu strings font size remained fixed. Now it changes the font size according to parents dimensions. Diffs - mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 mediaelements/mediawelcome/MediaWelcome.qml a3108d8 Diff: https://git.reviewboard.kde.org/r/117101/diff/ Testing --- The size of the icons in the menus remains the same, due to the file format (png). Converting these graphics to SVG may solve the graphics resize issue as well. Thanks, Nikolaos Chatzidakis
Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 11:42 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Removed bool variable and fixed parenthesis. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs (updated) - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 12:31 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch resolves the crash of PMC if it's running for the first time and its data directory does not exist in ~/.kde4/share/apps. Diffs - libs/mediacenter/mediacenter.cpp 35240d3 Diff: https://git.reviewboard.kde.org/r/117368/diff/ Testing --- Tested the fix, it creates the directory if it doesn't exist (first-time-run assumption). Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop 93b7c62 browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop 9d04068 browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop a06a168 Diff: https://git.reviewboard.kde.org/r/117139/diff/ Testing --- Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- (Updated March 28, 2014, 5:12 p.m.) Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This patch is created to provide uniform string format to pmc according to our Visual Design Group's guidelines ( http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu strings are converted so words start with capital letter. Diffs - browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop 93b7c62 browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop 9d04068 browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop a06a168 Diff: https://git.reviewboard.kde.org/r/117139/diff/ Testing --- Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117101: This patch fixes font size behaviour when pmc is resized.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/ --- Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This is my first patch trying to hack PMC. Untill now, whenever PMC was resized, the menu strings font size remained fixed. Now it changes the font size according to parents dimensions. Diffs - mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 mediaelements/mediawelcome/MediaWelcome.qml a3108d8 Diff: https://git.reviewboard.kde.org/r/117101/diff/ Testing --- The size of the icons in the menus remains the same, due to the file format (png). Converting these graphics to SVG may solve the graphics resize issue as well. Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
