D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

[Paul McAuley]

paulm added a comment.


  In D28356#636593 , @ndavis wrote:
  
  > KDE4 was unpopular because it was heavier and buggier, not because the 
titlebar buttons were different. I didn't like KDE back then either (I mainly 
used GNOME 2 and Unity), but I did like the window decorations. I think the 
current buttons are clear enough as they are and any change would be more of a 
branding change than a usability change. KDE 1 copied a lot from CDE, including 
the titlebar buttons. Windows 3.1 is different enough that we're pretty 
obviously not copying it. We also have a maximized symbol, unlike Windows 3.1.
  
  
  I have been with KDE from the KDE1 days and personally generally liked KDE4 
(have never strayed to GNOME :P). I just never liked Windows 3.1's interface 
nor the Oxygen Windows 3.1-style titlebar buttons (the maximized/restore symbol 
exists on both and is the same concept - an up arrow fused with a down arrow, 
though less obvious with Oxygen):
  F8202431: win3x-windows-31-screen.png 
  
  I was also a CDE user on HP-UX back in the day, and think CDE's window 
controls are no bad thing!
  
  I just think there is a reason why a lot of people are being recommended 
desktops like Cinnamon, MATE and XFCE etc. to relatives rather than KDE despite 
Plasma being technically better. It is little things like this where 
style/branding being prioritised over thinking about how a new user will find 
intuitiveness/familiarity that is keeping "the year of the Linux desktop" far 
away!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28356

To: paulm, #vdg, #breeze, hpereiradacosta, cblack, davidre, ndavis
Cc: ndavis, davidre, broulik, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm added a comment.


  I went ahead and made an Aurorae version of this 
 just to get a feel for how much I could 
theme. Overall, I am disappointed with Aurorae as Plasma is not as easily 
customizable as would first meet the eye. Aurorae alone will not let you 
customize the titlebar buttons as comprehensively as one would initially think:
  
  - The in-application Application Style also needs titlebar-like button icons 
as provided in Breeze kstyle (as menitoned by David above)
  - Aurorae does not obey system colour settings, especially for the titlebar 
itself
  - GTK applications which use the client side window decorations in the 
titlebar (e.g. Gedit) still require updated SVG files
  - GTK applications such as Chromium require updated .png files (generated 
with a Python script using Cairo libraries)
  - The icon theme also needs updated as the titlebar buttons are also 
referenced in other places throughout the UI such as in application menus, in 
right-click menus and notification pop-ups.
  
  It would be much better if you could change the titlebar button style in one 
place and would change it in all of these places. That obviously would require 
some serious rearchitecting of the theme engine.
  
  Therefore, working with what we have now, I also decided to be a bit more 
bold and try to propose this as the default theme in D28358 
 /  T12793 
 - this implements the 'Classik' theme 
changes without the selection box. I also implemented all the changes in the 
places listed above (GTK and icons) to try and give complete consistency.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis, ngraham
Cc: davidre, ngraham, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

[Paul McAuley]

paulm added a comment.


  > It seems MacOS can get away with colored circles without people complaining 
about usability.
  
  I would argue that MacOS does this very badly, and that MacOS usability is 
not as great as the fanatics would attest.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28356

To: paulm, #vdg, #breeze, hpereiradacosta, cblack, davidre
Cc: davidre, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

[Paul McAuley]

paulm added a comment.


  In D28356#636309 , @cblack wrote:
  
  > IMO, the maximise and minimise buttons are a step backwards from the 
current decorations in terms of legibility and aesthetics.
  >  Minimise especially, considering that a square has no meaning at all. 
Maximise is also less aesthetically pleasing than the current one IMO.
  >
  > However, I like the new keep below and keep above icons.
  
  
  I would beg to disagree. After having this for a while on my system I feel 
the opposite and can't look at the aesthetics of Breeze-Oxygen any more!
  
  The square minimize icon does not mean nothing - it now visually describes 
what the window looks like once minimized (i.e. compressed), as does maximize 
(i.e. expanded into a large square).
  
  There is no visual description with the existing arrows which could mean many 
things. The existing arrows don't have a clear meaning at all - it is not clear 
whether the down arrow, for example would move the window down, minimize, 
restore, provide a drop-down menu, scroll etc. As I said in the task, I've seen 
several users put off KDE just because of the unorthodox nature of Plasma's 
titlebar buttons.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28356

To: paulm, #vdg, #breeze, hpereiradacosta, cblack, davidre
Cc: davidre, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28358: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze-GTK

[Paul McAuley]

paulm created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
paulm requested review of this revision.

REVISION SUMMARY
  As described in T12793  , this patch 
applies the KDE1-style 'Classik' titlebar icon styles to Breeze.
  
  In D28356  for Breeze it modifies both 
kdecoration and kstyle so that there will be consistency when titlebar-like 
buttons are used within applications.
  
  For Breeze-GTK both new SVG files are added (affecting GTK applications with 
client-side-decorations in the titlebar like gedit), and the python script has 
been updated to generate new .png files with Cairo (affecting applications like 
Chromium).
  
  For Breeze-Icons, the action icons for window operations have been updated to 
match the 'Classik' style.
  
  Screenshot from before applying patch:
  F8201866: before_with_Breeze-oxygen.png 
  
  Screenshot from after applying patch:
  F8201868: after_with_Classik.png 
  
  Annotated version of previous screenshot, labelled in red with which modules 
are rendering which icons:
  F8201871: Classik_mods_annotated.png 
  
  Another screenshot showing all the titlebar icons after the patch:
  F8201885: Classic_Breeze_buttons_2160.png 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D28358

AFFECTED FILES
  src/assets/breeze-close-active-symbolic.svg
  src/assets/breeze-close-hover-symbolic.svg
  src/assets/breeze-close-symbolic.svg
  src/assets/breeze-maximize-active-symbolic.svg
  src/assets/breeze-maximize-hover-symbolic.svg
  src/assets/breeze-maximize-symbolic.svg
  src/assets/breeze-maximized-active-symbolic.svg
  src/assets/breeze-maximized-hover-symbolic.svg
  src/assets/breeze-maximized-symbolic.svg
  src/assets/breeze-minimize-active-symbolic.svg
  src/assets/breeze-minimize-hover-symbolic.svg
  src/assets/breeze-minimize-symbolic.svg
  src/render_assets.py

To: paulm
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze, Breeze-GTK and Breeze-Icons

[Paul McAuley]

paulm updated this revision to Diff 78684.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28356?vs=78682=78684

REVISION DETAIL
  https://phabricator.kde.org/D28356

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp

To: paulm, #vdg, #breeze, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze, Breeze-GTK and Breeze-Icons

[Paul McAuley]

paulm updated this revision to Diff 78682.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28356?vs=78679=78682

REVISION DETAIL
  https://phabricator.kde.org/D28356

AFFECTED FILES
  src/assets/breeze-close-active-symbolic.svg
  src/assets/breeze-close-hover-symbolic.svg
  src/assets/breeze-close-symbolic.svg
  src/assets/breeze-maximize-active-symbolic.svg
  src/assets/breeze-maximize-hover-symbolic.svg
  src/assets/breeze-maximize-symbolic.svg
  src/assets/breeze-maximized-active-symbolic.svg
  src/assets/breeze-maximized-hover-symbolic.svg
  src/assets/breeze-maximized-symbolic.svg
  src/assets/breeze-minimize-active-symbolic.svg
  src/assets/breeze-minimize-hover-symbolic.svg
  src/assets/breeze-minimize-symbolic.svg
  src/render_assets.py

To: paulm, #vdg, #breeze, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze, Breeze-GTK and Breeze-Icons

[Paul McAuley]

paulm created this revision.
paulm added reviewers: VDG, Breeze, hpereiradacosta.
paulm added a project: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
paulm requested review of this revision.

REVISION SUMMARY
  As described in T12793  , this patch 
applies the KDE1-style 'Classik' titlebar icon styles to Breeze.
  
  For Breeze it modifies both kdecoration and kstyle so that there will be 
consistency when titlebar-like buttons are used within applications.
  
  For Breeze-GTK both new SVG files are added (affecting GTK applications with 
client-side-decorations in the titlebar like gedit), and the python script has 
been updated to generate new .png files with Cairo (affecting applications like 
Chromium).
  
  For Breeze-Icons, the action icons for window operations have been updated to 
match the 'Classik' style.
  
  Screenshot from before applying patch:
  F8201866: before_with_Breeze-oxygen.png 
  
  Screenshot from after applying patch:
  F8201868: after_with_Classik.png 
  
  Annotated version of previous screenshot, labelled in red with which modules 
are rendering which icons:
  F8201871: Classik_mods_annotated.png 
  
  Another screenshot showing all the titlebar icons after the patch:

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28356

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp

To: paulm, #vdg, #breeze, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, trickyricky26, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

[Paul McAuley]

paulm added a comment.


  In D28087#628873 <https://phabricator.kde.org/D28087#628873>, @ngraham wrote:
  
  > Nice. Can we have an email address so the patch gets landed with correct 
authorship information?
  
  
  No problem:
  Paul McAuley 
  
  (surprised you don't get this with the submitted .patch file)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28087

To: paulm, #breeze, hpereiradacosta
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm added a comment.


  In D27938#624385 , @ngraham wrote:
  
  > > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp 
whereby the "Draw a circle around close button" setting does not reset to 
Defaults properly.
  >
  > Would you mind extracting this into its own patch and submitting it 
separately? Sounds like a good fix, regardless of whether or not this patch 
gets merged in its current form or in another form. In general it's best to 
have each patch/commit do only one thing and not combine new features and 
bugfixes.
  
  
  This is now submitted at https://phabricator.kde.org/D28087

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis, ngraham
Cc: davidre, ngraham, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D28087: Fix Defaults not being set properly in Breeze window decoration settings for 'Draw a circle around close button'

[Paul McAuley]

paulm created this revision.
paulm added reviewers: Breeze, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
paulm requested review of this revision.

REVISION SUMMARY
  This fixes a small bug in the Breeze window decoration settings where 
clicking on 'Defaults' did nothing to change 'Draw a circle around close 
button' . This patch now causes 'Draw a circle around close button' to default 
correctly.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28087

AFFECTED FILES
  kdecoration/config/breezeconfigwidget.cpp

To: paulm, #breeze, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm added a comment.


  In D27938#624385 , @ngraham wrote:
  
  > > A small bug is also fixed in kdecoration/config/breezeconfigwidget.cpp 
whereby the "Draw a circle around close button" setting does not reset to 
Defaults properly.
  >
  > Would you mind extracting this into its own patch and submitting it 
separately? Sounds like a good fix, regardless of whether or not this patch 
gets merged in its current form or in another form. In general it's best to 
have each patch/commit do only one thing and not combine new features and 
bugfixes.
  
  
  Sure, I can do that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm added a comment.


  In D27938#624382 , @ngraham wrote:
  
  > Can you add a bit more information about what your goal is here? You're 
adding different icon styles for the titlebar buttons that you can use while 
still using the Breeze window decoration theme? Before-and-after screenshots 
would help too. See also 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots
  
  
  Hi Nate. Yes, the changes allow you to have different sets of icon styles for 
the titlebar buttons, while still keeping the overall Breeze style. I have 
updated the summary. The motivation to add it was mainly to add the 'Classic' 
button icon style, while also preserving the 'Oxygen' style of button icons for 
those who like it. I have added screenshots to the summary, and will maybe make 
another video to show it tomorrow.
  
  > Could you add a few words regarding why you think adding this option to the 
Breeze window decoration theme is right right place for this, as opposed to 
creating a new window decoration theme or just changing the default appearance? 
If there's something wrong with the current button appearance, maybe we should 
just change it. If not, and this is just to satisfy people with different 
aesthetic preferences, why not make a different window decoration theme?
  
  I added these options to the Breeze window decoration because I liked the 
overall Breeze style (shading, colours, configurability etc.), just not the 
icons for the window control buttons (I just don't think the 'Oxygen' style 
buttons are logical and often initially found myself confused by them, not 
knowing whether an up-arrow means restore or maximize, not knowing whether a 
down-arrow means minimize or restore, and not having a clue what the diamond 
means! I tried to replace it with buttons that visually describe the outcome of 
the click). However, I know there are some people attached to the 
'Oxygen'-style buttons so didn't just want to arrogantly remove them or 
arrogantly change defaults without some discussion or demonstration (which I 
hope this provides).
  
  With regards to why not a separate theme, that was actually my original plan, 
but I wanted to use Breeze as the base. When I asked 3 years ago if there was 
an Aurorae theme for Breeze that I could edit I was told there was not and that 
it was just C++; is this still the case today? Can the Breeze theme be easily 
forked and redistributed in the GetHotNewStuff dialogue box? If so, how, and 
where to share? I also wanted to change the Application Style as well as the 
Window Decorations (i.e. the style of buttons to dock/undock and close etc. 
within applications with dockable panes). Can you easily fork, redistribute and 
download new Application Styles in the GetHotNewStuff dialogue box as well?
  
  With regards to why not just change the default titlebar button icons. Yes, 
of course I do indeed think the default titlebar button icons should be changed 
to what I have called 'Classic' by default :). However, I do realise that 
defaults can be contentious things that can cause a lot of debate!! With this 
patch people can at least see the 'Classic' style for themselves and discuss 
before committing to anything new.
  
  I also think the tiny square minimize icon with 'Classic' visually fits in 
nicely with the Icons Only Task Manager.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

To: paulm, hpereiradacosta, #breeze, ndavis
Cc: ngraham, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D27938: 'Classic' and 'Redmond' button icon styles, configurable via Breeze window decoration settings

[Paul McAuley]

paulm created this revision.
paulm added a reviewer: hpereiradacosta.
paulm added projects: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
paulm requested review of this revision.

REVISION SUMMARY
  This implements as described at https://phabricator.kde.org/T12793
  
  Modifications have been made to both kdecoration and kstyle so that window 
decorations for both normal windows and MDI applications will be affected, with 
new designs placed in libbreezecommon as are shared between both. A 
configuration in the Breeze window decoration settings will affect both 
kdecoration and kstyle so .kcfg files in each have been updated. 'Oxygen' 
remains the default style as at present.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27938

AFFECTED FILES
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/breezeconfigwidget.cpp
  kdecoration/config/ui/breezeconfigurationui.ui
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  libbreezecommon/CMakeLists.txt
  libbreezecommon/breezerenderdecorationbuttonicon.cpp
  libbreezecommon/breezerenderdecorationbuttonicon.h
  libbreezecommon/breezestyleclassic.cpp
  libbreezecommon/breezestyleclassic.h
  libbreezecommon/breezestyleoxygen.cpp
  libbreezecommon/breezestyleoxygen.h
  libbreezecommon/breezestyleredmond.cpp
  libbreezecommon/breezestyleredmond.h

To: paulm, hpereiradacosta
Cc: plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, 
ndavis, ZrenBot, firef, ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart