D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari abandoned this revision.
eszlari added a comment.


  OK, found it.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari added a comment.


  How can I close this? (phabricator UI really sucks, I hope the move to Gitlab 
is completed soon)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari added a comment.


  In D28360#636448 , @gikari wrote:
  
  > Again, why not just make XSettingsd required? It's simpler.
  
  
  To quote yourself: "We cannot add mandatory dependencies to the stable 
branches/releases."
  
  I think it's important to get it in 5.18 LTS.
  
  In D28360#636610 , @kossebau wrote:
  
  > Can you tell which packagers missed that this is a required runtime 
dependency?
  
  
  https://packages.ubuntu.com/focal/kde-config-gtk-style
  
https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec
  
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/kde-gtk-config/kde-gtk-config-5.18.3.ebuild
  
  > Edit: The proposed solution to make it simply required only forces 
packagers to add that and all what it pulls in as build-time dependency to 
their package creation, even if not needed for the package creation itself at 
all, which is not something packagers like (wastes resources on package build 
servers).
  
  But they don't have to! They can just compile with
  
cmake -DENABLE_XSETTINGSD=OFF ...

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari added a comment.


  In D28360#636418 , @gikari wrote:
  
  > But the option is enabled by default and needs to be explicitly disabled. 
This seems to be an overengineered solution. It basically says, that XSettingsd 
is an optional dependency, which already is.
  
  
  But it make the packager aware, that this dependency exists, instead of at 
runtime, the end user wondering, why his/her Plasma desktop behaves differently 
from others.
  
  Anecdote: obs-studio checks for pulseaudio at compile time, but fails 
silently(!) when it can't find it, leading users to wonder, why they can't 
record audio.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari added a comment.


  In D28360#636406 , @gikari wrote:
  
  > In D28360#636404 , @eszlari 
wrote:
  >
  > > I would like to have this in 5.18
  >
  >
  > We cannot add mandatory dependencies to the stable branches/releases. 
Currently it's an optional dependency. If you want to make it mandatory, only 
5.19 and later are possible options.
  
  
  That's why I made it an option, so that it fails explicitly but can still be 
disabled.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari added a comment.


  In D28360#636403 , @gikari wrote:
  
  > Why just not make xsettingsd required?
  
  
  It is set to REQUIRED (and ON by default), but can be disabled, mainly 
because I would like to have this in 5.18, and it seems safer that way.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
eszlari requested review of this revision.

REVISION SUMMARY
  This way, packagers won't miss this new runtime dependency.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

AFFECTED FILES
  CMakeLists.txt

To: eszlari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Peter Eszlari]

eszlari added a comment.


  In D25324#624299 , @gikari wrote:
  
  > In D25324#624229 , @eszlari 
wrote:
  >
  > > This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  >
  >
  > `xsettingsd` is started by the daemon itself, if it's not instantiated 
already. The daemon itself launches at startup, because it is a kded module.
  
  
  You are right, sorry for the noise! I must have mixed up someting while 
testing it on the Kubuntu 20.04 preview.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25324: [GTK Config] Add XSettingsd as a runtime dependency

[Peter Eszlari]

eszlari added a comment.


  > BUG: 418263
  
  This bug is not fixed by this patch. `xsettingsd` needs to be started in 
`plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future).
  
  > FIXED-IN: 5.19
  
  I would be nice, if this could make it to 5.18, so that `xsettingsd` would 
end up on the Kubuntu 20.04 ISO image (https://phabricator.kde.org/T12753).

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  xsettingsd-dependency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich, ngraham
Cc: ngraham, eszlari, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D25324: Display a warning, if xsettingsd is not found

[Peter Eszlari]

eszlari added a comment.


  In D25324#563373 , @gikari wrote:
  
  > In D25324#563347 , @eszlari 
wrote:
  >
  > > But seems, this only applies to dependencies checked by find_package().
  >
  >
  > I'm confused.
  >
  > Does it mean, I should create custom `FindXsettingsd.cmake` module for 
xsettingsd, then write something like this:
  >
  >   find_package(Xsettingsd)
  >   set_package_properties(Xsettingsd PROPERTIES
  >   TYPE RUNTIME
  >   DESCRIPTION "Provides settings to X11 applications via the XSETTINGS 
specification"
  >   URL "https://github.com/derat/xsettingsd;
  >   )
  >
  >
  > ?
  
  
  Yes. Maybe you can take inspiration from this commit:
  
https://cgit.kde.org/kinfocenter.git/commit/?id=35b19106c5cb64c4705a3682269826d4be6510f2

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari
Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25324: Display a warning, if xsettingsd is not found

[Peter Eszlari]

eszlari added a comment.


  I guess he refers to:
  
  
https://cmake.org/cmake/help/latest/module/FeatureSummary.html#command:set_package_properties
  
  But seems, this only applies to dependencies checked by find_package().

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari
Cc: eszlari, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24743: Update GTK settings according to Plasma settings

[Peter Eszlari]

eszlari added a comment.


  In D24743#562745 , @gikari wrote:
  
  > I'm not very proficient in CMake, so how can I do that?
  
  
  https://cmake.org/cmake/help/latest/command/find_program.html

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: eszlari, zzag, ervin, ngraham, broulik, nicolasfella, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, 
firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Peter Eszlari]

eszlari added a comment.


  Maybe a warning about the runtime dependency on xsettingsd should be added to 
cmake, so distro packagers know about it.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: eszlari, zzag, ervin, ngraham, broulik, nicolasfella, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, 
firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D20242: Add flatpak mime types

[Peter Eszlari]

eszlari added a comment.


  I think, for my small contributions, this would be overkill, but thanks for 
your trust! :-)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20242

To: eszlari, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20242: Add flatpak mime types

[Peter Eszlari]

eszlari created this revision.
eszlari added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
eszlari requested review of this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D20242

AFFECTED FILES
  discover/CMakeLists.txt

To: eszlari, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

[Peter Eszlari]

eszlari added a comment.


  peter.eszl...@gmail.com

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

To: eszlari, davidedmundson, ngraham, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

[Peter Eszlari]

eszlari added inline comments.

INLINE COMMENTS

> broulik wrote in startkde.cmake:98
> Where does `kdeglobals_kscreen_scalefactor` come from?

Line 52.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

To: eszlari, davidedmundson, ngraham, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14697: X11: set GDK_SCALE (try 2)

[Peter Eszlari]

eszlari created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
eszlari requested review of this revision.

REVISION SUMMARY
  BUG: 387849

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14697

AFFECTED FILES
  startkde/startkde.cmake

To: eszlari
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart