D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham abandoned this revision.
shubham added a comment.


  Pushed here 38ebcf09b1631175d5a1b4d857622c5313146a60

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, #vdg, ngraham, ognarb
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham added a comment.


  @broulik Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham added a comment.


  @broulik Ping??

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham added a comment.


  @broulik Friendly ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:35e18420a76a: [kcm_nightcolor] Set 2 decimal places 
precision for coordinates (authored by shubham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28958?vs=80495=80517

REVISION DETAIL
  https://phabricator.kde.org/D28958

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: shubham, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

[Shubham]

shubham created this revision.
shubham added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  coor

REVISION DETAIL
  https://phabricator.kde.org/D28958

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/main.qml

To: shubham, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham added a comment.


  @broulik Ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28686

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham updated this revision to Diff 79686.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28686?vs=79662=79686

REVISION DETAIL
  https://phabricator.kde.org/D28686

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/logic.js

To: shubham, broulik, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28686: [Battery Monitor] Choose better wording

[Shubham]

shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wording

REVISION DETAIL
  https://phabricator.kde.org/D28686

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/logic.js

To: shubham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

[Shubham]

shubham added a comment.


  +1
  Personally I had faced this issue when I had bought a new monitor and tried 
to listen to music through its speakers. I couldn't figure out how to switch 
play back devices for couple of days or so.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23389

To: ngraham, drosca, #plasma, #vdg
Cc: shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23044: [Notifications] Swing the bell when there is a new notification

[Shubham]

shubham added a comment.


  Personally I do not like info button to be swung like a bell, however VDG are 
the right people to decide  this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23044

To: broulik, #plasma, #vdg
Cc: shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5a79ff3db16f: Remove duplicate occurence of Qt5::DBus in 
CMakeLists.txt (authored by shubham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22619?vs=62213=62214

REVISION DETAIL
  https://phabricator.kde.org/D22619

AFFECTED FILES
  applets/pager/CMakeLists.txt

To: shubham, davidedmundson, broulik, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22588: [Pager] Don't link kdelibs4support

[Shubham]

shubham added a comment.


  I have put up a patch to remove duplicate occurrence of DBus here.
  https://phabricator.kde.org/D22619

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22588

To: broulik, #plasma, hein, davidedmundson
Cc: pino, shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

[Shubham]

shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22619

AFFECTED FILES
  applets/pager/CMakeLists.txt

To: shubham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22588: [Pager] Don't link kdelibs4support

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> CMakeLists.txt:18
>Qt5::Core
>Qt5::DBus
>Qt5::Qml

Could you please remove this or the occurrence below at line 21?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22588

To: broulik, #plasma, hein
Cc: shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22481: Do not show play/pause button when no media is playing

[Shubham]

shubham created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22481

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: shubham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20804: RFC: Try getting the X keyboard grab multiple times

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> interface.h:116
>  
> +void AboutToLock();
> +

Shouldn't this and the above function name start with small letter?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20804

To: davidedmundson, #plasma, #kwin
Cc: shubham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:c62901d8aed6: Dont show tooltip when search field 
has text and set a timeout period (authored by shubham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18766?vs=51272=51496

REVISION DETAIL
  https://phabricator.kde.org/D18766

AFFECTED FILES
  discover/qml/SearchField.qml

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Shubham]

shubham added a comment.


  In D18766#409139 <https://phabricator.kde.org/D18766#409139>, @ngraham wrote:
  
  > Yes, let's land it. Please land it on the 5.15 branch and then merge to 
master. If you don't know how to do that, I can help you.
  
  
  Help will be welcome.

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text

[Shubham]

shubham added a comment.


  @ngraham Is it now behaving as it should?

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  In D18766#408901 <https://phabricator.kde.org/D18766#408901>, @ngraham wrote:
  
  > Works for me, no segfault. I don't see any reason why this change could 
cause that. @shubham, does the segfault stop happening when you build Discover 
from source without this change?
  
  
  I should have told that the segafault is unrelated to this change. Even 
without this change, done kind of segafault appears, because of some 
dependencies etc maybe.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  It compiles but I could not test this. When I run the plasma-discover 
segmentation fault prevails.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham updated this revision to Diff 51272.
shubham added a comment.


  Remove timeout period

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18766?vs=50977=51272

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

AFFECTED FILES
  discover/qml/SearchField.qml

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  @apol about the timeout?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  >> I'm not sure you even need to add the `timeout: ` line at all.
  
  A tooltip with a negative timeout does not hide automatically. The default 
value is -1.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol, ngraham
Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham added a comment.


  When user is typing text, the tooltip continuosly shown above distracts and 
looks ugly

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham marked an inline comment as done.
shubham added a comment.


  @apol I have noticed that the tooltip is seen even when there is text 
present, also the duration for which it appears is very long

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D18766

To: shubham, apol
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham updated this revision to Diff 50977.
shubham added a comment.


  Use length

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18766?vs=50975=50977

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

AFFECTED FILES
  discover/qml/SearchField.qml

To: shubham, apol
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18766: Don't show tooltip when search field has text and set a timeout period

[Shubham]

shubham created this revision.
shubham added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Earlier, the tooltip was continuosly shown even though it was observed when 
search field was empty.

TEST PLAN
  Hover over search field

REPOSITORY
  R134 Discover Software Store

BRANCH
  search

REVISION DETAIL
  https://phabricator.kde.org/D18766

AFFECTED FILES
  discover/qml/SearchField.qml

To: shubham, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17751: Add shadow to Hour's hand

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:975df8f8930c: Add shadow to Hours hand (authored by 
shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17751?vs=49728=49796

REVISION DETAIL
  https://phabricator.kde.org/D17751

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, mart, hein, #vdg, ngraham, davidedmundson
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17751: Add shadow to Hour's hand

[Shubham]

shubham updated this revision to Diff 49728.
shubham added a comment.


  Updating D17751 <https://phabricator.kde.org/D17751>: Add shadow to Hour's 
hand
  Use harcoded pixel values

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17751?vs=49656=49728

BRANCH
  hand

REVISION DETAIL
  https://phabricator.kde.org/D17751

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, mart, hein, #vdg, ngraham, davidedmundson
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17751: Add shadow to Hour's hand

[Shubham]

shubham updated this revision to Diff 49656.
shubham added a comment.


  1. Set the hour hand shadow's topMargin to -6px and second hand shadow's 
topMargin to 2px
  2. Use units.smallSpacing instead of hardcoding the values

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17751?vs=48055=49656

BRANCH
  hand

REVISION DETAIL
  https://phabricator.kde.org/D17751

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, mart, hein, #vdg, ngraham, davidedmundson
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17751: Add shadow to Hour's hand

[Shubham]

shubham added a comment.


  ngraham I will put those changes in effect

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17752: Remove full representation of analog clock

[Shubham]

shubham abandoned this revision.
shubham added a comment.


  Abandon in favor of above discussion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Shubham]

shubham added a comment.


  @rooty yeah, it depends on the available space. The main motive should be 
full up the empty space.
  @ngraham Is there any possible representation where we can just eliminate or 
use up that empty space.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Shubham]

shubham added a comment.


  In D17598#384293 <https://phabricator.kde.org/D17598#384293>, @ngraham wrote:
  
  > In D17598#384289 <https://phabricator.kde.org/D17598#384289>, @shubham 
wrote:
  >
  > > Looking nice. Not being nitpicky, what's the default behaviour, the icon 
should be on top or to the free space on the left?
  >
  >
  > There is no real rule here. It's more of "what looks good" in a designey 
sense. :)
  
  
  Well then it's good, conveying the message without actually the need to read 
it.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Shubham]

shubham added a comment.


  Looking nice. Not being nitpicky, what's the default behaviour, the icon 
should be on top or to the free space on the left?

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: rooty, shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Shubham]

shubham accepted this revision.
shubham added a comment.
This revision is now accepted and ready to land.


  Looks good this way round. +1

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-no-connectivity-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol, shubham
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Shubham]

shubham added a comment.


  It will look much better.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17598: Improve "No internet connection!" error message

[Shubham]

shubham added a comment.


  Shouldn't the second part of the sentence be in its own line?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17598

To: ngraham, #discover_software_store, #vdg, apol
Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17751: Add shadow to Hour's hand

[Shubham]

shubham added a comment.


  In D17751#381435 <https://phabricator.kde.org/D17751#381435>, @ndavis wrote:
  
  > In D17751#381431 <https://phabricator.kde.org/D17751#381431>, @shubham 
wrote:
  >
  > > How could the shadow appearance be fixed? In breeze icons?
  >
  >
  > No, the SVG that the analog clock uses is in plasma-framework
  
  
  Can you tell me how to fix it in plasma framework svg?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D6056: [Run Command] Auto-close on focus loss only if query field is empty

[Shubham]

shubham added a comment.


  Year and half old patch, lucky it got noticed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6056

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D17751: Add shadow to Hour's hand

[Shubham]

shubham added a comment.


  How could the shadow appearance be fixed? In breeze icons?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham
Cc: abetts, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17752: Remove full representation of analog clock

[Shubham]

shubham created this revision.
shubham added reviewers: hein, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Full representation of analog clock showed a calendar, which does not makes 
sense for two reasons:
  
  1. It shows a massive calendar which clogs the window and looks ugly.
  2. User can click in the system tray instead.

TEST PLAN
  Create analog clock widget. Try to click on it.
  Nothing happens.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cal

REVISION DETAIL
  https://phabricator.kde.org/D17752

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, hein, mart
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17751: Add shadow to Hour's hand

[Shubham]

shubham created this revision.
shubham added reviewers: mart, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

TEST PLAN
  Add new analog clock widget from "Add widget" on right click context m

REPOSITORY
  R120 Plasma Workspace

BRANCH
  hour

REVISION DETAIL
  https://phabricator.kde.org/D17751

AFFECTED FILES
  applets/analog-clock/contents/ui/analogclock.qml

To: shubham, mart, hein
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:743e5583ced0: Make Status and Notification popup 
consistent with others. (authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17556?vs=47562=47564

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:998d1a02c670: Remove period ( . ) character from the end 
(authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17574?vs=47551=47563

REVISION DETAIL
  https://phabricator.kde.org/D17574

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham added a comment.


  could I go ahead pushing it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham updated this revision to Diff 47562.
shubham added a comment.


  Use units.smallSpacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17556?vs=47552=47562

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, #vdg, broulik, #plasma, mart
Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Shubham]

shubham added a comment.


  my battery drained in "After" image even though it was charging : )

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham updated this revision to Diff 47552.
shubham edited the summary of this revision.
shubham removed a reviewer: hein.
shubham added a comment.


  use 5px margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17556?vs=47497=47552

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, #vdg, broulik, #plasma, mart, hein
Cc: abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17574: Remove period ( . ) character from the end

[Shubham]

shubham created this revision.
shubham added reviewers: Plasma, VDG.
shubham added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Before:
  F6476200: 1.png <https://phabricator.kde.org/F6476200>
  
  After:
  F6476201: 2.png <https://phabricator.kde.org/F6476201>

TEST PLAN
  Hover over battery monitor in system tray

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: shubham, #plasma, #vdg
Cc: plasma-devel, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham added a comment.


  @broulik In all others, if you notice it is 0

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17556: Make Status and Notification popup consistent with others.

[Shubham]

shubham created this revision.
shubham added a project: Plasma.
Herald edited subscribers, added: plasma-devel; removed: Plasma.
shubham requested review of this revision.

REVISION SUMMARY
  1. Remove the left margin.
  2. Change '&' to "and".
  
  Before:
  F6474493: be.png <https://phabricator.kde.org/F6474493>
  
  After:
  F6474494: af.png <https://phabricator.kde.org/F6474494>

TEST PLAN
  Open System Tray.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:977d2aadd522: Show tooltip for pinning system tray and 
calendar (authored by shubham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17532?vs=47433=47437

REVISION DETAIL
  https://phabricator.kde.org/D17532

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

[Shubham]

shubham updated this revision to Diff 47433.
shubham edited the summary of this revision.
shubham added a comment.


  "Keep Open"

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17532?vs=47432=47433

REVISION DETAIL
  https://phabricator.kde.org/D17532

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17532: Show tooltip for pinning system tray and calendar

[Shubham]

shubham created this revision.
shubham added reviewers: mart, Plasma.
shubham added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REVISION SUMMARY
  F6472870: 1.png <https://phabricator.kde.org/F6472870>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17532

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: shubham, mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17360: Added "Transparent with light text" theme for Desktop Notes

[Shubham]

shubham added a comment.


  Congrats on your first patch.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17360

To: IamMaxim, #plasma, davidedmundson
Cc: shubham, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D16257: Use correct wording, since it is an action word(not a noun)

[Shubham]

shubham created this revision.
shubham added a reviewer: Plasma.
shubham added a project: Plasma.
Herald added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16257

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml

To: shubham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14652: Port to KRun::runApplication

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e0d50ff1d88d: Port to KRun::runApplication (authored by 
shubham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14652?vs=39199=39206

REVISION DETAIL
  https://phabricator.kde.org/D14652

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp

To: shubham, jgrulich, hein, abetts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14652: Port to KRun::runApplication

[Shubham]

shubham created this revision.
shubham added reviewers: jgrulich, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
shubham requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14652

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp

To: shubham, jgrulich, dfaure
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Project: Better touch screen support in the Plasma workspace

[Shubham Chowdhary]

Hello,
I came across the Touch screen support Idea for KDEsoc and I am interested
in contributing for the same. How should I go about for the same. I have
basic knowledge of Qt and experienced in C++. Moreover I have been using
plasma,KDE for quite some time now.

Thanks.

   Sent with Mailtrack