Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated Aug. 20, 2014, 7:13 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63445 --- weird issue when using reviewboard with the chrome. that why the diff are always error. I have upload successfully with the newest fixed patch - TOM Harrison On July 29, 2014, 3:24 p.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118180/ > --- > > (Updated July 29, 2014, 3:24 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 327580 > http://bugs.kde.org/show_bug.cgi?id=327580 > > > Repository: kde-workspace > > > Description > --- > > bug patch for slideshow dir list missing > > > Diffs > - > > libs/plasmagenericshell/backgrounddialog.cpp 645de3f > > Diff: https://git.reviewboard.kde.org/r/118180/diff/ > > > Testing > --- > > > Thanks, > > TOM Harrison > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 3:24 p.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs (updated) - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 3:19 p.m.) Status -- This change has been discarded. Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 2:15 p.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing (updated) --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:05 a.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing (updated) --- I will fix it soon. something wrong with the patch. Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:04 a.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs (updated) - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Status -- This change has been discarded. Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 21, 2014, 1:12 p.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs (updated) - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? > > Sebastian Kügler wrote: > Yes, don't use tabs at all for code indentation, use 4 spaces. It should > look consistent with the surrounding code after that. OK, I have fix in the patch. I will upload later, if it could detect as a patch.. - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 ------- On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118180/ > --- > > (Updated 六月 5, 2014, 10:32 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 327580 > http://bugs.kde.org/show_bug.cgi?id=327580 > > > Repository: kde-workspace > > > Description > --- > > bug patch for slideshow dir list missing > > > Diffs > - > > libs/plasmagenericshell/backgrounddialog.cpp 645de3f > > Diff: https://git.reviewboard.kde.org/r/118180/diff/ > > > Testing > --- > > > Thanks, > > TOM Harrison > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > what kind of issue? tab and space different ? - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --- On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118180/ > --- > > (Updated 六月 5, 2014, 10:32 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 327580 > http://bugs.kde.org/show_bug.cgi?id=327580 > > > Repository: kde-workspace > > > Description > --- > > bug patch for slideshow dir list missing > > > Diffs > - > > libs/plasmagenericshell/backgrounddialog.cpp 645de3f > > Diff: https://git.reviewboard.kde.org/r/118180/diff/ > > > Testing > --- > > > Thanks, > > TOM Harrison > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
> On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for reminding for the missing reviewers. > > Christoph Feck wrote: > I guess nobody looked at it yet because in the list it appears as > "already approved". I will ping plasma developers. I am still waiting the plasma reviewer to approve :(, though I am using this path already. - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review59300 ------- On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118180/ > --- > > (Updated 六月 5, 2014, 10:32 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 327580 > http://bugs.kde.org/show_bug.cgi?id=327580 > > > Repository: kde-workspace > > > Description > --- > > bug patch for slideshow dir list missing > > > Diffs > - > > libs/plasmagenericshell/backgrounddialog.cpp 645de3f > > Diff: https://git.reviewboard.kde.org/r/118180/diff/ > > > Testing > --- > > > Thanks, > > TOM Harrison > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118180: slideshow BUG patch fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 5, 2014, 10:32 a.m.) Review request for kde-workspace and Plasma. Bugs: 327580 http://bugs.kde.org/show_bug.cgi?id=327580 Repository: kde-workspace Description --- bug patch for slideshow dir list missing Diffs - libs/plasmagenericshell/backgrounddialog.cpp 645de3f Diff: https://git.reviewboard.kde.org/r/118180/diff/ Testing --- Thanks, TOM Harrison ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
