Re: Plasma Firewall

[Tomaz Canabrava]

People, I have spend a great deal of time fine tuning the Firewall, I hope
it's ready for a release.

On Wed, Jun 3, 2020 at 6:33 PM Tomaz Canabrava  wrote:

> Lots of nitpicks fixed, still missing some, I'll finish the rest today.
>
>
> On Fri, May 22, 2020 at 6:10 PM Ivan Čukić  wrote:
>
>> Hi Kai,
>>
>>
>> This is something that Plasma has been missing for a long time. Thanks to
>> everyone involved!
>>
>>
>> A few comments from a quick run-through over kcm/core:
>>
>> # Style issues
>>
>> - Some enums use MACRO_STYLE, some NormalStyle
>>
>> - Some one-line if bodies in the same file have {}, some do not
>>
>> - Double plural interfaces_names
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/firewallclient.cpp#L56
>>
>> - Personal preference - error handling in the if instead of out. This:
>>   if (!m_currentBackend) { return nullptr; }
>>   return proper;
>> instead of this:
>>   if (m_currentBackend) { return proper; }
>>   return nullptr;
>>
>> - Missing m_ prefix for member variables:
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> profile.h#L108
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/profile.h#L108>
>>
>> - s/getRule/ruleAt/ - we don't usually have 'get' in the API if we can
>> avoid
>> it:
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> ifirewallclientbackend.h#L50
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/ifirewallclientbackend.h#L50>
>>
>> - Could use a pipe through clang-format
>>
>>
>> # Non-style issues:
>>
>> - Should be ||, not && in:
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> rulelistmodel.cpp#L37
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/rulelistmodel.cpp#L37>
>>
>> - Can be a const or a ref-to-const, no need for qAsConst after:
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> firewallclient.cpp#L58
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/firewallclient.cpp#L58>
>>
>> - Should add m_currentBackend = nullptr; after delete
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> firewallclient.cpp#L248
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/firewallclient.cpp#L248>
>> (otherwise you get UB on 270 if no plugins have been found)
>>
>> - Logic-wise - it would be better to redesign (if possible) not to allow
>> m_currentBackend == nullptr instead of asserting and checking in each
>> function
>> (for example, to show a UI that can not call anything in the backend is
>> no
>> backend is loaded)
>>
>> - Wrong order - sort m_profiles and then replace it with a new contents?
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> ifirewallclientbackend.cpp#L36
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/ifirewallclientbackend.cpp#L36>
>>
>> - cbegin/cend instead of begin/end:
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> ifirewallclientbackend.cpp#L42
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/ifirewallclientbackend.cpp#L42>
>>
>> - [] instead of [name]
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> ifirewallclientbackend.cpp#L43
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/ifirewallclientbackend.cpp#L43>
>>
>> - mark member functions that can be const as const
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> ifirewallclientbackend.h#L89
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/ifirewallclientbackend.h#L89>
>>
>> - else if for chained checks of reader.name() == something
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> profile.cpp#L163
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/profile.cpp#L163>
>>
>> - !...isEmpty is not needed - adds.contains(":") covers !...isEmpty
>> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
>> rule.cpp#L46
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/rule.cpp#L46>
>>
>> - Assigning long-lived parents is naughty:
>> https://invent.kde.org/tcanabrava/
>> plasma-firewall/-/blob/master/kcm/backends/ufw/ufwclient.cpp#L318
>> <https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/backends/ufw/ufwclient.cpp#L318>
>>
>>
>>
>> So much from me at this point.
>>
>> Cheers,
>> Ivan
>>
>>
>>
>> --
>> dr Ivan Čukić
>> i...@cukic.co, https://cukic.co/
>> gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12
>>
>>
>>

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added inline comments.

INLINE COMMENTS

> broulik wrote in kcmaccess.cpp:141
> Are you sure this shouldn't be something like
> 
>   modifiers & (ScrollMask | LockMask | NumMask)

good catch.

> broulik wrote in kcmaccess.desktop:9
> What about this? We still need to autostart kaccess on login.
> Perhaps, while at it, you could port it over to proper autostart mechanism 
> rather than abusing kcminit for that.

Can you elaborate on that? I don't really know what you mean.

> broulik wrote in kcmaccess.h:42
> Where is this being used?

It was used in the old code, I forgot to add in the Ui.

> broulik wrote in Bell.qml:89
> Why are you writing to a different property than you check for immutability?

changed the names on the kcfg file and forgot to update here. it's a bit 
annoying that part of the kconfig is string based and other part is proper code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

Re: Plasma Firewall

[Tomaz Canabrava]

Lots of nitpicks fixed, still missing some, I'll finish the rest today.


On Fri, May 22, 2020 at 6:10 PM Ivan Čukić  wrote:

> Hi Kai,
>
>
> This is something that Plasma has been missing for a long time. Thanks to
> everyone involved!
>
>
> A few comments from a quick run-through over kcm/core:
>
> # Style issues
>
> - Some enums use MACRO_STYLE, some NormalStyle
>
> - Some one-line if bodies in the same file have {}, some do not
>
> - Double plural interfaces_names
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/firewallclient.cpp#L56
>
> - Personal preference - error handling in the if instead of out. This:
>   if (!m_currentBackend) { return nullptr; }
>   return proper;
> instead of this:
>   if (m_currentBackend) { return proper; }
>   return nullptr;
>
> - Missing m_ prefix for member variables:
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> profile.h#L108
> 
>
> - s/getRule/ruleAt/ - we don't usually have 'get' in the API if we can
> avoid
> it:
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> ifirewallclientbackend.h#L50
> 
>
> - Could use a pipe through clang-format
>
>
> # Non-style issues:
>
> - Should be ||, not && in:
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> rulelistmodel.cpp#L37
> 
>
> - Can be a const or a ref-to-const, no need for qAsConst after:
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> firewallclient.cpp#L58
> 
>
> - Should add m_currentBackend = nullptr; after delete
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> firewallclient.cpp#L248
> 
> (otherwise you get UB on 270 if no plugins have been found)
>
> - Logic-wise - it would be better to redesign (if possible) not to allow
> m_currentBackend == nullptr instead of asserting and checking in each
> function
> (for example, to show a UI that can not call anything in the backend is no
> backend is loaded)
>
> - Wrong order - sort m_profiles and then replace it with a new contents?
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> ifirewallclientbackend.cpp#L36
> 
>
> - cbegin/cend instead of begin/end:
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> ifirewallclientbackend.cpp#L42
> 
>
> - [] instead of [name]
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> ifirewallclientbackend.cpp#L43
> 
>
> - mark member functions that can be const as const
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> ifirewallclientbackend.h#L89
> 
>
> - else if for chained checks of reader.name() == something
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> profile.cpp#L163
> 
>
> - !...isEmpty is not needed - adds.contains(":") covers !...isEmpty
> https://invent.kde.org/tcanabrava/plasma-firewall/-/blob/master/kcm/core/
> rule.cpp#L46
> 
>
> - Assigning long-lived parents is naughty:
> https://invent.kde.org/tcanabrava/
> plasma-firewall/-/blob/master/kcm/backends/ufw/ufwclient.cpp#L318
> 
>
>
>
> So much from me at this point.
>
> Cheers,
> Ivan
>
>
>
> --
> dr Ivan Čukić
> i...@cukic.co, https://cukic.co/
> gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12
>
>
>

D29028: feat(wayland): add Wrapland plugin

[Tomaz Canabrava]

tcanabrava added a comment.


  I understand David's point: Wrapland project has one developer and we don't 
know how successful it will be, while the other backends have developers. What 
would happen if you suddenly quit / disappear and the project dies? Then 
kscreen will have a folder of dead code.
  
  This is a Plugin, it can live in any folder / project, you already forked 
KWinFT, create a new project to put this KScreen plugin, we can't scale to N 
projects adding code as plugins that will need to be maintained for quite a 
while in the future.
  
  > Come on man, do you really want to make this ugly? I thought we would still 
treat each other with respect David. :(
  
  Your words. His words are technical, Please don't distort things and make it 
about you.
  
  > Which "established practices" does this not satisfy?
  
  It's an external library that does not solve any problem within the plasma, 
nor adds value to plasma users. It's an experimental project, with only one 
developer, not stable, not ready, not core. You can see on this picture that we 
are not blocking your project here because of $excuse, but this is something 
that we do if the project is not core, please check the date.
  F8253102: image.png 
  
  There's more information on the full phabricator ticket:
  https://phabricator.kde.org/D20265
  
  > How would that look in detail?
  
  That will give you the possibility to create plugins for KScreen that are not 
bound to KScreen code, then you can create your project in gitlab and have 
different release schedules, in a way that:
  1 - The plugin code is independent to KDE Releases
  2 - We have a clear separation on project responsabilities
  3 - Being independent means that it can also test with experimental libraries.
  
  > Why is this even relevant?
  
  We need to be sure that the code of the project will always be buildable 
through the lifespan of Plasma 5.19, and right now we can't guarantee it.
  
  Create this code outside of KSCreen as a plugin. We will gladly accept code 
that install the Interface Headers to make that possible. :)

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: tcanabrava, apol, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 76053.
tcanabrava added a comment.


  - Simplify function / remove desktopResized

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26986?vs=74565=76053

BRANCH
  wip_fix_screenlocker_detach_reattach

REVISION DETAIL
  https://phabricator.kde.org/D26986

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/main.cpp

To: tcanabrava, graesslin, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 74565.
tcanabrava added a comment.


  - Simplify Architecture

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26986?vs=74556=74565

BRANCH
  wip_fix_screenlocker_detach_reattach

REVISION DETAIL
  https://phabricator.kde.org/D26986

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/main.cpp

To: tcanabrava
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava added a comment.


  In D26986#602373 , @davidedmundson 
wrote:
  
  > This is definitely an area for improvement.
  >
  > This code was initially written before QGuiApplication::screenRemoved 
existed, which is why it's like this.
  >  I think this solution is overly complex, you have the pointer to what 
changed in screenRemoved, we then discard that information and then go through 
loops to effectively retrieve that information we originally had.
  >  With a refactor that could be cleaner.
  
  
  I'll try to refactor.
  
  > As for your initial bug you're trying to fix:
  >  You're still in a race to see if kscreenlocker can update before kwin 
renders something, this might make kscreenlocker faster, but it won't resolve 
it being a race.
  
  I'll poke vlad to see how to proceed here.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26986

To: tcanabrava
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This patch tries - and fails - to fix the flicker of screens while
  the kscreenlocker_greeter is active. The reasoning of the patch is
  simple:
  
  instead of deleting the overlays in the vector untill we have as
  many overlays as screens, we check if a overlay belongs to a screen
  that's currently plugged in, deleting only those that don't have
  a screen anymore.
  
  and then, instead of going thru all of the views and updating the
  geometry and position, we only set that once for each overlay created.
  
  This is not by all means something that I want to merge, as currently
  is broken, but given the current implementation is also broken I think
  it's safe to assume a 'v1' so we can discuss what's wrong on both
  implementations.
  
  To test the bug: plug two monitors, run the locker, detach and reattach
  the monitors. on detaching (but not reattaching) the monitor will flicker
  and display the contents of what's behind the locked screen.

REPOSITORY
  R133 KScreenLocker

BRANCH
  wip_fix_screenlocker_detach_reattach

REVISION DETAIL
  https://phabricator.kde.org/D26986

AFFECTED FILES
  greeter/greeterapp.cpp

To: tcanabrava
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava marked 4 inline comments as done.
tcanabrava added a comment.


  F7877402: Screenshot_20200111_155924.PNG 

  
  With OverlaySheet

INLINE COMMENTS

> anthonyfieroni wrote in kcm.cpp:41
> https://doc.qt.io/qt-5/qqmlengine-obsolete.html

The non obsolete version is in Qt 5.14, we can't use yet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham
Cc: anthonyfieroni, mart, ngraham, broulik, ervin, davidedmundson, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73281.
tcanabrava added a comment.


  - Merge branch 'master' into arcpatch-D25449
  - Use OverlaySheet

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73236=73281

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop
  kcms/formats/writeexports.h

To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham
Cc: anthonyfieroni, mart, ngraham, broulik, ervin, davidedmundson, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D26489: Use qmlRegisterAnonymousType

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R112:7a6b1a037e65: Use qmlRegisterAnonymousType (authored by 
tcanabrava).

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26489?vs=73276=73278

REVISION DETAIL
  https://phabricator.kde.org/D26489

AFFECTED FILES
  lib/draghelper.cpp
  lib/previewplugin.cpp

To: tcanabrava, broulik
Cc: meven, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26489: Use qmlRegisterAnonymousType

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73276.
tcanabrava added a comment.


  - Move typeRegistration to the Plugin instanciation

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26489?vs=72962=73276

BRANCH
  arcpatch-D26489

REVISION DETAIL
  https://phabricator.kde.org/D26489

AFFECTED FILES
  lib/draghelper.cpp
  lib/previewplugin.cpp

To: tcanabrava, broulik
Cc: meven, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73274.
tcanabrava marked 16 inline comments as done.
tcanabrava added a comment.


  - ListElement does not handle i18n calls, use raw array
  - Dont complain about null background - Failing on Qt 5.14
  - Add Key entries to the kconfigxt generator
  - ArtsBell* -> CustomBell*
  - kModifiers* -> KeyboardModifiers*
  - Rename mouse settings
  - Remove deprecated call
  - Fix nitpicks
  - Fix Qml Style
  - Use QFileDialog to look for audio files
  - Fix Binary checks
  - Mark as Q_INVOKABLE, not Q_SCRIPTABLE
  - Use QtQuick Dialogs for the audio file
  - Fix orca calls
  - Use Label instead of placeholder text
  - Fix icon & text for search audio files
  - Fix Triggers
  - Trigger orcaInstalled() only when entering ScreenReader
  - Add explanation for magic number
  - Add transient window for the KNofityConfigWidget dialog
  - Fix KConfig Misuse
  - Explain property
  - Audible Bell Layout
  - Add string context

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=73058=73274

BRANCH
  arcpatch-D25375

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73236.
tcanabrava added a comment.


  - Fix esc and click outside to close the overlay

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73209=73236

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop
  kcms/formats/writeexports.h

To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73209.
tcanabrava added a comment.


  - Fix some keyboard whoes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73188=73209

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop
  kcms/formats/writeexports.h

To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  (Ignore my broken Theme - i'm trying to discover what's happening.)
  
  F7874644: Screenshot_20200110_121232.PNG 

  F7874646: Screenshot_20200110_121252.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73188.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Remove code dependant on Qt 5.14
  - Mark that we will use some text in the future
  - Remove uneeded virtual
  - Update role names to something more explicit
  - Correctly handle wrong indices
  - Update Qml Library
  - Handle keyboard navigation
  - Use correct method for extracting data from the model
  - Nitpicks
  - Correctly compare locales
  - Fix metadata

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73145=73188

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop
  kcms/formats/writeexports.h

To: tcanabrava, ervin, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava marked 23 inline comments as done.
tcanabrava added inline comments.

INLINE COMMENTS

> broulik wrote in kcm.cpp:37
> You're not importing this anywhere, and this still works? Makes me wonder why 
> Qt went through the trouble of introducing this when it makes no diference 
> over `qmlRegisterType()` ...
> 
> Please also use a KCM-specific import name for this, such as 
> `org.kde.private.kcms.formats`

I also don't know but now I have deprecated warnings on the terminal to change 
for that.

> davidedmundson wrote in localemodel.cpp:15
> c1 == QLocale::c()
> 
> might be better than comparing names?

old, unmodified code. Changing now.

> ervin wrote in localemodel.cpp:106
> This sounds like a std::find_if

it does, but the std::find_if has a worse readability than a for loop, at least 
for simple cases. I'm excited to be able to use ranges tougth.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  
  
  > Imho a custom `ComboBox` with a search field in its popup or something like 
that would be a better control.
  
  I tried to use the combobox (but of course phabricator destroys my history so 
it's hard to even look at it). I had problems with the velocity because of the 
amount of items that are loaded in the model and the flag pixmaps.

INLINE COMMENTS

> mart wrote in kcm.cpp:39
> this is 5.14 only from which we can't depend yet

ah, ok. I was having deprecated warnings, that's why I removed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73145.
tcanabrava added a comment.


  - Readd writeexports.h

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73135=73145

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop
  kcms/formats/writeexports.h

To: tcanabrava, ervin, #vdg, #plasma, mart
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73135.
tcanabrava added a comment.


  - Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73130=73135

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop

To: tcanabrava, ervin
Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73130.
tcanabrava added a comment.


  - Change how we set locales
  - Set the locale
  - Add missing files
  - Typos
  - Set the correct size of the list

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=73061=73130

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/CountryList.qml
  kcms/formats/package/contents/ui/LocaleInput.qml
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop

To: tcanabrava, ervin
Cc: broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73061.
tcanabrava added a comment.


  - Correctly extract qml
  - Update documentation text
  - Remove deprecated calls
  - Correct placement of pointer and reference symbols
  - Rename variables on kconfigxt and use name and key
  - Correct constructor
  - Use auto
  - Use qAsConst
  - Return a map directly
  - Inheit from the generated settings to use usrSave

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25449?vs=70122=73061

BRANCH
  arcpatch-D25449

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatsettings_impl.cpp
  kcms/formats/formatsettings_impl.h
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop

To: tcanabrava, ervin
Cc: ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73058.
tcanabrava added a comment.


  - Use QFileDialog to look for audio files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=73057=73058

BRANCH
  arcpatch-D25375

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava marked 4 inline comments as done.
tcanabrava added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:53
> title should already be translated; no need to put this in an `i18n()` call

this was a ListElement Q_NOOP_TR issue

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73057.
tcanabrava marked 5 inline comments as done.
tcanabrava added a comment.


  - ListElement does not handle i18n calls, use raw array
  - Dont complain about null background - Failing on Qt 5.14
  - Add Key entries to the kconfigxt generator
  - ArtsBell* -> CustomBell*
  - kModifiers* -> KeyboardModifiers*
  - Rename mouse settings
  - Remove deprecated call
  - Fix nitpicks
  - Fix Qml Style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=71008=73057

BRANCH
  arcpatch-D25375

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  In D25375#575980 , @ervin wrote:
  
  > I think we discussed this already, but I'm not sure so before it gets 
lost... :-)
  >
  > Please consider using both key and name for your kcfg items, this allows to 
both respect the past storage format and provide nicer property names on the 
C++/QML side. Currently the storage used names are leaking to the internal API.
  
  
  Done.

INLINE COMMENTS

> cblack wrote in CMakeLists.txt:17
> What purpose does this serve? It looks like you're simply printing a list of 
> source files with a Portuguese header.

stray debug. fixed.

> cblack wrote in kcmaccess.cpp:194
> You could consider using glib for a stable ABI instead of invoking a command 
> line that could change at any time. Also would reduce dependencies for most 
> distros, as glib's command line tools are often packaged separately from glib 
> itself.

care to elaborate? This is old code and I haven't touched it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26183: Fix build with Qt 5.14

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added a comment.


  since this is commited already I'm closing, and opened a follow up commit:
  https://phabricator.kde.org/D26489

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D26183

To: tcanabrava, davidedmundson, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26489: Use qmlRegisterAnonymousType

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R112 Milou

BRANCH
  useQmlRegisterAnonymousType

REVISION DETAIL
  https://phabricator.kde.org/D26489

AFFECTED FILES
  lib/draghelper.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26183: Fix build with Qt 5.14

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R112:dfecda35d4c7: Fix build with Qt 5.14 (authored by 
tcanabrava).

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26183?vs=72067=72114

REVISION DETAIL
  https://phabricator.kde.org/D26183

AFFECTED FILES
  lib/draghelper.cpp

To: tcanabrava, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26183: Fix build with Qt 5.14

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R112 Milou

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26183

AFFECTED FILES
  lib/draghelper.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

[Tomaz Canabrava]

tcanabrava added a comment.


  I would also say that 'Baloo' means nothing to users, and File search should 
be used instead. It's an internal name, not really a brand.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25278

To: ngraham, #vdg, #baloo
Cc: tcanabrava, bruns, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D24374: WIP: Initial port of the Date and Time KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  F7802151: kcm_clock.png  Quite ugly I'm 
afraid.
  I'll port this to KConfigXT over next week.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24374

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  Updated texts by ngraham sugestions.

INLINE COMMENTS

> ngraham wrote in ActivationGestures.qml:50
> This section doesn't have anything to do with activation gestures. Its 
> checkboxes might be better placed on other pages more relevant to their 
> content.

Agree. This is a 1 to 1 translation of the old KCM. I'm doing the changes you 
requested.

> ngraham wrote in ModifierKeys.qml:51
> Can be shortened to "Use system bell when modifier keys are used" (I *think* 
> this is what the string is trying to  communicate; correct me if I'm wrong)

I can't correct you here, those where the original texts and since haven't got 
a clue on what they are talking about I choose not to change them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 71008.
tcanabrava added a comment.


  - Fix localization calls

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=71005=71008

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 71005.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Typos and onToggled instead of onCheckStateChanged
  - Better UX / Texts
  - Text updates
  - Remove ActivationGestures page, Fix orca information

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70754=71005

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  showcase_kcofig_issue

REVISION DETAIL
  https://phabricator.kde.org/D25745

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/showcasekconfigerror/CMakeLists.txt
  kcms/showcasekconfigerror/Messages.sh
  kcms/showcasekconfigerror/README
  kcms/showcasekconfigerror/kcm.cpp
  kcms/showcasekconfigerror/kcm.h
  kcms/showcasekconfigerror/kcm_showcasekconfigerror.desktop
  kcms/showcasekconfigerror/package/contents/ui/main.qml
  kcms/showcasekconfigerror/package/metadata.desktop
  kcms/showcasekconfigerror/showcasekconfigerrorsettings.kcfg
  kcms/showcasekconfigerror/showcasekconfigerrorsettings.kcfgc

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  Missing apply button being enabled seems something related to 
ManagedConfigModule. I don't know what to do there yet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70754.
tcanabrava marked 6 inline comments as done.
tcanabrava added a comment.


  - Add missing setButtons
  - Fix Typo

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70751=70754

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70751.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Fix factory name

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70749=70751

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70749.
tcanabrava added a comment.


  - Fixes
  - Fixes texts and UI
  - Simplify Algorithm
  - Fix Enable / Disable status

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70103=70749

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25449: Start of the new Formats KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Detangle the code, implement models and start the Qml

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_formats

REVISION DETAIL
  https://phabricator.kde.org/D25449

AFFECTED FILES
  kcms/formats/CMakeLists.txt
  kcms/formats/Messages.sh
  kcms/formats/README
  kcms/formats/formats.desktop
  kcms/formats/formatssettings.kcfg
  kcms/formats/formatssettings.kcfgc
  kcms/formats/kcm.cpp
  kcms/formats/kcm.h
  kcms/formats/kcm_formats.desktop
  kcms/formats/kcmformats.cpp
  kcms/formats/kcmformats.h
  kcms/formats/kcmformatswidget.ui
  kcms/formats/localemodel.cpp
  kcms/formats/localemodel.h
  kcms/formats/package/contents/ui/main.qml
  kcms/formats/package/metadata.desktop

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70103.
tcanabrava added a comment.


  - Fixes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=69947=70103

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  In D25379#565509 , @davidedmundson 
wrote:
  
  > I was under the impression we were killing this KCM in the very near future.
  >
  > The relevant workboard entry: https://phabricator.kde.org/T7292
  
  
  While the KCM does not die we abandon it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25379

To: tcanabrava
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25280: [Baloo KCM] Purge index when disabling indexing

[Tomaz Canabrava]

tcanabrava added a comment.


  I gree with david's questioning, sometimes I disable indexing when I'm about 
to do something heavy, to re-enable it later. I don't want to lose all my data.
  perhaps there should be a box `purge database data`  instead of purging on 
disable?

INLINE COMMENTS

> main.qml:43
> +text: i18n("Turning off file search will remove all existing 
> index data.");
> +
> +}

stray newline

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, #vdg, #baloo
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70018.
tcanabrava added a comment.


  - Fix speed of the models
  - Simplify Logic
  - Speed up emoticon loading
  - Re-Enable updateBtn
  - Re-enable remove theme
  - Move more data to the Models
  - Re-enable the rest of the functions
  - Remove ui file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25379?vs=69952=70018

BRANCH
  kcm_emoticon

REVISION DETAIL
  https://phabricator.kde.org/D25379

AFFECTED FILES
  kcms/emoticons/CMakeLists.txt
  kcms/emoticons/editdialog.cpp
  kcms/emoticons/editdialog.h
  kcms/emoticons/emoticonslist.cpp
  kcms/emoticons/emoticonslist.h
  kcms/emoticons/emoticonslist.ui
  kcms/emoticons/emoticonsmodel.cpp
  kcms/emoticons/emoticonsmodel.h
  kcms/emoticons/emoticonthemesmodel.cpp
  kcms/emoticons/emoticonthemesmodel.h
  kcms/emoticons/helpers.cpp
  kcms/emoticons/helpers.h

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Before we port this to Qml we need to simplify the code
  it's currently monolithycal, and need to be split into at least
  two models and a few helper classes.
  
  Load Emoticon from the Models
  
  Problem: Something is *very* heavy. I think creating and
  destroying KEmoticons is not the best approach, I'll load
  everything and store in memory for next commit

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_emoticon

REVISION DETAIL
  https://phabricator.kde.org/D25379

AFFECTED FILES
  kcms/emoticons/CMakeLists.txt
  kcms/emoticons/editdialog.cpp
  kcms/emoticons/editdialog.h
  kcms/emoticons/emoticonslist.cpp
  kcms/emoticons/emoticonslist.h
  kcms/emoticons/emoticonslist.ui
  kcms/emoticons/emoticonsmodel.cpp
  kcms/emoticons/emoticonsmodel.h
  kcms/emoticons/emoticonthemesmodel.cpp
  kcms/emoticons/emoticonthemesmodel.h
  kcms/emoticons/helpers.cpp
  kcms/emoticons/helpers.h

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  After squashing the commits to remove the broken history, arc diff opened a 
new revision.
  https://phabricator.kde.org/D25375

INLINE COMMENTS

> ervin wrote in kcmaccessibilitymouse.kcfg:34
> Wouldn't an Enum be more suited here?

This i a spinBox with a range from 0 to 1000 in the original code, so I dont 
think an enum will be better there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This rewrites the Accessibility KCM to use Qml and the new Managed
  Config classes.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69945.
tcanabrava added a comment.


  - Use Plasma KCM
  - Adapt to FormLayout
  - Fix label
  - Space every tab equally
  - Form layout port
  - FormLayout
  - Simplify Qml
  - Port to Form Layout
  - A much much better layout than tabs
  - Beginning of KConfigXt Port
  - Add KConfigXt stubs
  - Fix install
  - Fix wrong values accessed
  - s/visibleBell/visualBell
  - Fix Many issues with the KConfigXT port
  - Fixes
  - Fix all the KConfigXT noiseances
  - Add background to the List
  - Add single-connects
  - Fix Layout
  - Adapt to new ManagedConfig
  - Re-add X11Info

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=69651=69945

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  In D24224#561693 , @ngraham wrote:
  
  > It doesn't compile:
  >
  >   /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal 
error: kns3/downloaddialog.h: No such file or directory
  >   1 | #include "kns3/downloaddialog.h"
  > |  ^~~
  >
  >
  > Also we should be using the new QML-based GHNS dialog where possible, now 
that it's a first-class citizen.
  
  
  There's no KNS3 on Accessibility

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69651.
tcanabrava added a comment.


  - Fix Layout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=69650=69651

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava, ngraham, bport
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  F7759258: image.png 

INLINE COMMENTS

> bport wrote in CMakeLists.txt:24
> Not sure why we have this change in this code review, seems unrelated

completely unrelated, thanks for spotting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69650.
tcanabrava added a comment.


  - Use Plasma KCM
  - Adapt to FormLayout
  - Fix label
  - Space every tab equally
  - Form layout port
  - FormLayout
  - Simplify Qml
  - Port to Form Layout
  - A much much better layout than tabs
  - Beginning of KConfigXt Port
  - Add KConfigXt stubs
  - Fix install
  - Fix wrong values accessed
  - s/visibleBell/visualBell
  - Fix Many issues with the KConfigXT port
  - Fixes
  - Fix all the KConfigXT noiseances
  - Add background to the List
  - Add single-connects

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=68019=69650

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava, ngraham, bport
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  F7605185: kcm_access.png 
  Now it uses a Vertical List, providing a better navigation mode, The Settings 
where also rewritten using KConfigXT so I don't need to deal with all the 
possible properties. This actually hit a hard limit in the KConfigXT framework 
and I had to split in multiple files. aparently KConfigXT can't handle more 
than 32 settings at the moment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 68019.
tcanabrava added a comment.


  - Use Plasma KCM
  - Adapt to FormLayout
  - Fix label
  - Space every tab equally
  - Form layout port
  - FormLayout
  - Simplify Qml
  - Port to Form Layout
  - A much much better layout than tabs
  - Beginning of KConfigXt Port
  - Add KConfigXt stubs
  - Fix install
  - Fix wrong values accessed
  - s/visibleBell/visualBell
  - Fix Many issues with the KConfigXT port
  - Fixes
  - Fix all the KConfigXT noiseances

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=67571=68019

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava, ngraham
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> bport wrote in kcmaccess.h:32-67
> Using KConfigXT will remove lots of boilerplate code (tons of property 
> declaration + associated methods and easiest, load, save and defaults method).
>  And with the work done by @ervin on KConfigXT and KQuickAddons::ConfigModule 
> you will have benefits (defaults, reset, apply button state for example will 
> be handled automatically)

Will look at it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  In D24224#545013 , @broulik wrote:
  
  > Can you please follow KDE Frameworks coding style
  
  
  Sorry, it was by mistake. I'll fix the style.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM 
Rewrite (authored by tcanabrava).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67572=67701

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67572.
tcanabrava added a comment.


  - Fix Strings
  - Fix margins

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67568=67572

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  this now depends on https://phabricator.kde.org/D23835 - There's an issue 
with saving (the save is not activated for some reason, I need to investigate.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67571.
tcanabrava added a comment.


  - Use Plasma KCM
  - Adapt to FormLayout
  - Fix label
  - Space every tab equally
  - Form layout port
  - FormLayout
  - Simplify Qml
  - Port to Form Layout

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=66834=67571

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: mart, ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava marked 2 inline comments as done.
tcanabrava added a comment.


  I still need to play a bit with the folder save / load. the code from the old 
kcm is quite strange. it saves "included folders", but there's nothing using 
that. perhaps it's safer if we just remove everything that's not used.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67568.
tcanabrava added a comment.


  - fix Comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67567=67568

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67567.
tcanabrava marked 7 inline comments as done.
tcanabrava added a comment.


  - Simplify Checkboxes
  - Fix previouslyEnabled logic
  - Tell Qml that we have the values
  - Move code around
  - Fix QSet math
  - Qml gives us a Url, we want the Local file
  - use folderAdded and folderRemoved
  - Remove debug information
  - Add spacing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67563=67567

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67563.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button
  - Fix borders and background for the Baloo KCM
  - Use kirigami BasicListItem
  - Spacing
  - Fix mapping of roles
  - Fix delegate / Mouse integration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=66643=67563

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24374: WIP: Initial port of the Date and Time KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67277.
tcanabrava added a comment.


  wq  - Restore colors metatada, and correctly set the datetime metadata
  
  - s/kcmclock/kcm_clock
  - Fix author
  - kcm_name break kauth, it needs kcmname =/
  - Fix missing property, Add a Qml Clock (from the Qt Demos)
  - Add a Time Zone list.
  - Fix many layout mistakes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24374?vs=67223=67277

BRANCH
  kcm_datetime

REVISION DETAIL
  https://phabricator.kde.org/D24374

AFFECTED FILES
  kcms/dateandtime/CMakeLists.txt
  kcms/dateandtime/clock.desktop
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/dtime.h
  kcms/dateandtime/kcmclock.desktop
  kcms/dateandtime/main.cpp
  kcms/dateandtime/main.h
  kcms/dateandtime/package/contents/ui/Clock.qml
  kcms/dateandtime/package/contents/ui/center.png
  kcms/dateandtime/package/contents/ui/clock-night.png
  kcms/dateandtime/package/contents/ui/clock.png
  kcms/dateandtime/package/contents/ui/hour.png
  kcms/dateandtime/package/contents/ui/main.qml
  kcms/dateandtime/package/contents/ui/minute.png
  kcms/dateandtime/package/contents/ui/second.png
  kcms/dateandtime/package/metadata.desktop

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24374: WIP: Initial port of the Date and Time KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67223.
tcanabrava added a comment.


  - Fix KAuth usage

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24374?vs=67219=67223

BRANCH
  kcm_dateandtime

REVISION DETAIL
  https://phabricator.kde.org/D24374

AFFECTED FILES
  kcms/colors/package/metadata.desktop
  kcms/dateandtime/CMakeLists.txt
  kcms/dateandtime/clock.desktop
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/dtime.h
  kcms/dateandtime/kcm_clock.desktop
  kcms/dateandtime/main.cpp
  kcms/dateandtime/main.h
  kcms/dateandtime/package/contents/ui/main.qml
  kcms/dateandtime/package/metadata.desktop

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24374: WIP: Initial port of the Date and Time KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This is mostly the c++ part, missing the Qml - however this one should
  be easy to do - with the exception of the visual clock, and the
  KAuth integration that aparently is missing from the QuickAddons

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_dateandtime

REVISION DETAIL
  https://phabricator.kde.org/D24374

AFFECTED FILES
  kcms/colors/package/metadata.desktop
  kcms/dateandtime/CMakeLists.txt
  kcms/dateandtime/clock.desktop
  kcms/dateandtime/dtime.cpp
  kcms/dateandtime/dtime.h
  kcms/dateandtime/kcm_clock.desktop
  kcms/dateandtime/main.cpp
  kcms/dateandtime/main.h
  kcms/dateandtime/package/contents/ui/main.qml
  kcms/dateandtime/package/metadata.desktop

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24187: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added a comment.


  closing this as arc diff opened two reviews with the same content =/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24187

To: tcanabrava
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava added a comment.


  got it, updating.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  In D24224#537680 , @whiting wrote:
  
  > Thanks for taking this on Tomaz, Just throwing some ideas out but if it 
would help to have less tabs it might be useful to put all the keyboard 
features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, 
Keyboard Filters and Activation Gestures) The top groupbox of Activation 
Gestures items could be moved to their respective groupboxes also so there are 
less groupboxes on the Keyboard tab than before on these 3 tabs.
  
  
  I'll try  - I don't like the amount of tabs, but maybe joining three tabs 
together is too much.
  The Orca tab has only one option, there's `configure notifications buttons` 
twice. we need a bit of love there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava
Cc: whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66834.
tcanabrava added a comment.


  - Make buttons work

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=66831=66834

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This is a 1 - 1 translation of the QWidgets version of the Accessibility
  KCM - Most of the functionality is there, and the layout is the same
  with minor edits. We do need a better layout, this one does not behave
  correctly in Qml (the tabs are too many and if a tab gets out of the
  window, there's no way to click in it without resizing the whole window)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66823.
tcanabrava added a comment.


  - Remove the ui file
  - Rename kcm_access to kcmaccess
  - Fix typos
  - Qml Loads. Now, fix beaury
  - Fix imports and labels
  - Fix most layouts
  - Fix layout for the mouse navigation
  - Initial Working Gestures
  - Add boilerplate
  - Fixes on bell
  - Fix functionality

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66782=66823

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66782.
tcanabrava added a comment.


  - Initial Working Gestures

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66781=66782

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66781.
tcanabrava added a comment.


  - Rename kcm_access to kcmaccess
  - Fix typos
  - Qml Loads. Now, fix beaury
  - Fix imports and labels
  - Fix most layouts
  - Fix layout for the mouse navigation

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66758=66781

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66758.
tcanabrava added a comment.


  - Remove the ui file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66746=66758

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  please don't review it yet
  
  Remove uneeded Item
  
  Beginning of the Modifier Keys
  
  KeyboardFilters start
  
  Activation Gestures wip
  
  Wip of the MouseNavigation
  
  Small fixes and screen reader wip.
  
  Compiles - still doesn't link
  
  compile and link

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66643.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button
  - Fix borders and background for the Baloo KCM

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=66258=66643

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66258.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65378=66258

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22762: Take in consideration flat() for the All Applications menu

[Tomaz Canabrava]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b159222aa558: Take in consideration flat() for the All 
Applications menu (authored by tcanabrava).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22762?vs=62606=66207#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22762?vs=62606=66207

REVISION DETAIL
  https://phabricator.kde.org/D22762

AFFECTED FILES
  rootmodel.cpp

To: tcanabrava, davidedmundson, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 65378.
tcanabrava added a comment.


  - Name fixes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65375=65378

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/metadata.desktop
  kcms/baloo/package/ui/main.qml

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 65375.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65369=65375

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/metadata.desktop
  kcms/baloo/package/ui/main.qml

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/metadata.desktop
  kcms/baloo/package/ui/main.qml

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23461: Remove 'magic' filtering of recent apps

[Tomaz Canabrava]

tcanabrava added a comment.


  @ngraham I agree with you completely. it's basically removing a bit of code, 
smaller patch and the code behaves without surprises.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23461

To: tcanabrava, hein, davidedmundson
Cc: mart, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23461: Remove 'magic' filtering of recent apps

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 64818.
tcanabrava added a comment.


  - Revert "Remove filtering of recent apps that are in the favorites"
  - Add a new Q_PROPERTY to the Recents Model to filter out or not favorites

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23461?vs=64798=64818

BRANCH
  removeMagicFiltering

REVISION DETAIL
  https://phabricator.kde.org/D23461

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: tcanabrava, hein, davidedmundson
Cc: mart, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23461: Remove 'magic' filtering of recent apps

[Tomaz Canabrava]

tcanabrava added subscribers: ngraham, mart.
tcanabrava added a comment.


  In D23461#520710 , @davidedmundson 
wrote:
  
  > > Is there a reason to change kicker? If not, it needs to be a property.
  
  
  There was a discussion a week ago with @mart and @ngraham and the result was 
"yeah, looks like it's a bug dressed as a feature, it's better that we 
streamline this."
  So we voted to change kicker as the current behavior is "unpredictable" to 
the user.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23461

To: tcanabrava, hein, davidedmundson
Cc: mart, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23461: Remove 'magic' filtering of recent apps

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 64798.
tcanabrava added a comment.


  - Revert "Remove 'magic' filtering of recent apps"
  - Remove filtering of recent apps that are in the favorites

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23461?vs=64654=64798

BRANCH
  removeMagicFiltering

REVISION DETAIL
  https://phabricator.kde.org/D23461

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: tcanabrava, hein, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23461: Remove 'magic' filtering of recent apps

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  The recent app wasn't displayed if it's recent *and* favorites.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  removeMagicFiltering

REVISION DETAIL
  https://phabricator.kde.org/D23461

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22890: Add new class AllAppsModel that gives us a list of installed Apps

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 62965.
tcanabrava added a comment.


  - Add copyright information and docs

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22890?vs=62964=62965

BRANCH
  allAppsModel

REVISION DETAIL
  https://phabricator.kde.org/D22890

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/plugin/allappsmodel.cpp
  applets/kicker/plugin/allappsmodel.h
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/kickerplugin.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22890: Add new class AllAppsModel that gives us a list of installed Apps

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  The idea is to replace the rootModel.allAppsModel with this
  in the future, right now it's a way to not break the rootModel with
  more code. This represents currently a flat list of Apps, no pagination
  nor groups.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  allAppsModel

REVISION DETAIL
  https://phabricator.kde.org/D22890

AFFECTED FILES
  applets/kicker/CMakeLists.txt
  applets/kicker/plugin/allappsmodel.cpp
  applets/kicker/plugin/allappsmodel.h
  applets/kicker/plugin/appsmodel.h
  applets/kicker/plugin/kickerplugin.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22762: Take in consideration flat() for the All Applications menu

[Tomaz Canabrava]

tcanabrava added a comment.


  @hein I'll try to follow your approach.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22762

To: tcanabrava, davidedmundson, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22762: Take in consideration flat() for the All Applications menu

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b9eb1e70c96: Take in consideration flat() for the All 
Applications menu (authored by tcanabrava).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22762?vs=62604=62606

REVISION DETAIL
  https://phabricator.kde.org/D22762

AFFECTED FILES
  applets/kicker/plugin/rootmodel.cpp

To: tcanabrava, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22762: Take in consideration flat() for the All Applications menu

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  flatAllApps

REVISION DETAIL
  https://phabricator.kde.org/D22762

AFFECTED FILES
  applets/kicker/plugin/rootmodel.cpp

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22445: WIP: Open from cache / Open Normally

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Initial work to display the backtraces when plasma starts
  
  Parse the files on plasma startup to construct the file model
  
  WIP: Load cached data

REPOSITORY
  R871 DrKonqi

BRANCH
  restoreWithGui

REVISION DETAIL
  https://phabricator.kde.org/D22445

AFFECTED FILES
  src/CMakeLists.txt
  src/cachemodel.cpp
  src/cachemodel.h
  src/cachewidget.cpp
  src/cachewidget.h
  src/debuggermanager.cpp
  src/drkonqi.cpp
  src/drkonqi.h
  src/drkonqibackends.cpp
  src/drkonqibackends.h
  src/main.cpp
  src/parser/backtraceparser.h

To: tcanabrava
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
tcanabrava marked 2 inline comments as done.
Closed by commit R871:5c581620b5f7: Store crash report  automatically if 
shutting down (authored by tcanabrava).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22322?vs=61518=61710#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61518=61710

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 61518.
tcanabrava added a comment.


  - Add pid information to the log files
  - Store only the last 10 files in the cache directory

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61371=61518

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22322: Store crash report automatically if shutting down

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 61371.
tcanabrava added a comment.


  - Add pid information to the log files
  - rebase

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22322?vs=61360=61371

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

AFFECTED FILES
  src/drkonqi.cpp
  src/drkonqi.h
  src/main.cpp

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart