D21667: Optionally display threads as if they were processes

2019-07-20 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 62153.
topimiettinen added a comment.


  untabify

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21667?vs=59398=62153

REVISION DETAIL
  https://phabricator.kde.org/D21667

AFFECTED FILES
  processcore/processes.cpp
  processcore/processes.h
  processcore/processes_atop_p.cpp
  processcore/processes_atop_p.h
  processcore/processes_base_p.h
  processcore/processes_dragonfly_p.cpp
  processcore/processes_freebsd_p.cpp
  processcore/processes_gnu_p.cpp
  processcore/processes_linux_p.cpp
  processcore/processes_local_p.h
  processcore/processes_netbsd_p.cpp
  processcore/processes_openbsd_p.cpp
  processcore/processes_remote_p.cpp
  processcore/processes_remote_p.h
  processcore/processes_solaris_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: anthonyfieroni, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

2019-07-19 Thread Topi Miettinen 
topimiettinen added a comment.


  @davidedmundson If you are OK with the idea, could you please review this?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

To: topimiettinen
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

2019-06-10 Thread Topi Miettinen 
topimiettinen added a comment.


  In D21667#477393 , @davidedmundson 
wrote:
  
  > What information would an end user gain from doing this?
  
  
  They get to see how programs uses threads, for example to help develop 
programs. It's probably not very useful for a non-developer, so I think making 
it a less visible menu option is better than for example explicit checkbox 
(like qps does). Here's a screenshot.
  F6881875: screenshot4.png 

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

To: topimiettinen
Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21667: Optionally display threads as if they were processes

2019-06-08 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Display also threads as if they were processes. This is enabled with
  menu entry in PID column header.
  
  Signed-off-by: Topi Miettinen 

TEST PLAN
  None

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D21667

AFFECTED FILES
  processcore/processes.cpp
  processcore/processes.h
  processcore/processes_atop_p.cpp
  processcore/processes_atop_p.h
  processcore/processes_base_p.h
  processcore/processes_dragonfly_p.cpp
  processcore/processes_freebsd_p.cpp
  processcore/processes_gnu_p.cpp
  processcore/processes_linux_p.cpp
  processcore/processes_local_p.h
  processcore/processes_netbsd_p.cpp
  processcore/processes_openbsd_p.cpp
  processcore/processes_remote_p.cpp
  processcore/processes_remote_p.h
  processcore/processes_solaris_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ProcessModel_p.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D20853: ksysguardd: show Mandatory Access Control (SELinux/AppArmor) context

2019-05-20 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:446a3b368813: ksysguardd: show Mandatory Access Control 
(SELinux/AppArmor) context (authored by topimiettinen).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20853?vs=58257=58374

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: libksysguard: show Mandatory Access Control (SELinux/AppArmor) context

2019-05-20 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:e3894f9408cc: libksysguard: show Mandatory Access Control 
(SELinux/AppArmor) context (authored by topimiettinen).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20854?vs=58372=58373

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

2019-05-20 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 58372.
topimiettinen added a comment.


  update to reflect that this also shows AppArmor context

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20854?vs=57197=58372

BRANCH
  process-cgroup-selinux

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-05-18 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 58257.
topimiettinen added a comment.


  Updated to reflect that this is also useful for AppArmor

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20853?vs=57094=58257

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-05-18 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:3eb5e842ae64: process: add support for cgroups (authored 
by topimiettinen).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57196=58245

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20786: ProcessList: add support for cgroups

2019-05-18 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:11af9d11a457: ProcessList: add support for cgroups 
(authored by topimiettinen).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=57093=58244

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein, davidedmundson
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20584: ProcessList: add NoNewPrivileges

2019-05-18 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:892c895bda83: ProcessList: add NoNewPrivileges (authored 
by topimiettinen).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20584?vs=56322=58243

REVISION DETAIL
  https://phabricator.kde.org/D20584

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-05-18 Thread Topi Miettinen 
topimiettinen added a comment.


  Like D20854 , this should be also 
applicable to AppArmor.

REPOSITORY
  R106 KSysguard

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

2019-05-18 Thread Topi Miettinen 
topimiettinen added a comment.


  I noticed that when the system uses AppArmor instead of SELinux, this also 
happens to show AppArmor profile and status. Then at least user facing bits 
should not be so SELinux oriented to avoid confusion. I suppose AppArmor is 
more widely used than SELinux.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20854

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20901: Hide the new NNP column by default

2019-04-29 Thread Topi Miettinen 
topimiettinen added a subscriber: broulik.
topimiettinen added a comment.


  requested by @broulik

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20901

To: topimiettinen
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20901: Hide the new NNP column by default

2019-04-29 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20901

AFFECTED FILES
  processui/ksysguardprocesslist.cpp

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

2019-04-29 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57197.
topimiettinen added a comment.


  hide selinux column view by default

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20854?vs=57072=57197

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-04-29 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57196.
topimiettinen added a comment.


  hide cgroup column by default

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57069=57196

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20853: ProcessList: show SELinux context

2019-04-28 Thread Topi Miettinen 
topimiettinen added a comment.


  In D20853#457577 , @davidedmundson 
wrote:
  
  > Out of curiosity, do you use the remote processlist?
  
  
  No, but at first I thought ksysguardd was always used as a back end. It seems 
simple enough to be updated in sync with Qt version.

REPOSITORY
  R106 KSysguard

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-04-27 Thread Topi Miettinen 
topimiettinen added a comment.


  Example output:
  
ksysguardd> ps?
NamePID PPIDUID GID Status  User Time   System 
Time NiceVmSize  VmRss   VmURss  Login   TracerPID   TTY 
Command IO Priority Class   IO Priority NNP CGroup  SELinux Context
s   d   d   d   d   S   d   d   d   D   
D   D   s   d   s   s   d   d   d   s   
s
ksysguardd> ps
systemd 1   -1  0   0   sleeping34  122 
0   384076  14472   5044root-1  
/usr/lib/systemd/systemd --switched-root --system --deserialize 32  0   
0   0   /init.scope system_u:system_r:init_t:s0
kwin_x111638161810001000running 384 252 0   
3062496 105812  20668   topi-1  /usr/bin/kwin_x11   0   
0   0   /user.slice/user-1000.slice/session-2.scope 
unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20853

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-04-27 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57094.
topimiettinen added a comment.


  avoid memory allocations and reuse existing validation function

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20853?vs=57085=57094

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57093.
topimiettinen added a comment.


  avoid memory allocations and reuse existing validation function

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=57091=57093

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen 
topimiettinen added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in ProcessList.c:420-421
> I made mistake i mean `i--` we start from last.

I also added a check for i not being negative.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20786

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57091.
topimiettinen added a comment.


  more trimming logic fixes

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=57088=57091

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57088.
topimiettinen added a comment.


  improve trimming, thanks to @anthonyfieroni

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=57086=57088

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57086.
topimiettinen added a comment.


  free strdup'ed string

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=57070=57086

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-04-27 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57085.
topimiettinen added a comment.


  free strdup'ed string

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20853?vs=57071=57085

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

2019-04-26 Thread Topi Miettinen 
topimiettinen added a comment.


  F6795665: Screenshot_fedora.png  Fedora 
with SELinux

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20854

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

2019-04-26 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20854

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-04-26 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R106 KSysguard

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-26 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57070.
topimiettinen added a comment.


  trim trailing newlines

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=56890=57070

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-04-26 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57069.
topimiettinen added a comment.


  fix copy-pasta

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57068=57069

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20787: process: add support for cgroups

2019-04-26 Thread Topi Miettinen 
topimiettinen added a comment.


  F6795486: screenshot3.png  Looks much 
better!

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20787: process: add support for cgroups

2019-04-26 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57068.
topimiettinen added a comment.


  phabricate only one git commit, sorry

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57067=57068

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20787: process: add support for cgroups

2019-04-26 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 57067.
topimiettinen added a comment.


  Trim trailing newline for proper vertical alignment

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=56908=57067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20787: process: add support for cgroups

2019-04-25 Thread Topi Miettinen 
topimiettinen added a comment.


  It looks like the CGroup rows are visually not vertically aligned to center 
like other cells, but instead they are aligned to the top. However, I'd expect 
that the default item of switch in ProcessModel.cpp:1693 should implement this, 
like it does for e.g. HeadingName. So I'm a bit puzzled why this happens.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20583: process: add NoNewPrivileges

2019-04-24 Thread Topi Miettinen 
topimiettinen abandoned this revision.
topimiettinen added a comment.


  Abandoned in favour of D20645 .

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20583

To: topimiettinen
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-04-24 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 56908.
topimiettinen added a comment.


  update per comments from @davidedmundson and @apol

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=56891=56908

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen, #plasma, hein
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20645: process: add NoNewPrivileges

2019-04-24 Thread Topi Miettinen 
topimiettinen added a comment.


  In D20645#455416 , @davidedmundson 
wrote:
  
  > Do you have KDE commit access?
  
  
  No, I only started hacking KDE a few days ago...

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20645

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-04-24 Thread Topi Miettinen 
topimiettinen added a comment.


  F6790730: screenshot2.png 

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20787

To: topimiettinen, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-04-24 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-24 Thread Topi Miettinen 
topimiettinen added a comment.


  Sample output:
  
ksysguardd> ps?
NamePID PPIDUID GID Status  User Time   System Time 
NiceVmSize  VmRss   VmURss  Login   TracerPID   TTY Command IO 
Priority Class   IO Priority NNP CGroup
s   d   d   d   d   S   d   d   d   D   
D   D   s   d   s   s   d   d   d   s
ksysguardd> ps
init1   -1  0   0   sleeping127 308 0   
172216  12060   3176root-1  /sbin/init  0   0   
0   /init.scope
systemd-udevd   476 1   0   0   sleeping15  18  
0   22900   56161520root-1  
/lib/systemd/systemd-udevd  0   0   1   
/system.slice/systemd-udevd.service
kwin_x11958 950 10001000sleeping13918   
19025   0   2638008 75776   15984   topi-1  
/usr/bin/kwin_x11 -session 
10cd6f6f7200014837769930009690022_1544638428_145716  0   0   0  
 /user.slice/user-1000.slice/session-1.scope

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20786

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20786: ProcessList: add support for cgroups

2019-04-24 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R106 KSysguard

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20645: process: add NoNewPrivileges

2019-04-24 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 56866.
topimiettinen added a comment.


  update also remote protocol

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20645?vs=56551=56866

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20645

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20645: process: add NoNewPrivileges

2019-04-18 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 56551.
topimiettinen added a comment.


  Updated per comments from @davidedmundson.

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20645?vs=56475=56551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20645

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20583: process: add NoNewPrivileges

2019-04-17 Thread Topi Miettinen 
topimiettinen added a comment.


  It's not static, the thread can enable the mode with 
prctl(PR_SET_NO_NEW_PRIVS). I suppose Process::Status could be used? Maybe I 
made a mistake, now there is D20645 .

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20583

To: topimiettinen
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20645: process: add NoNewPrivileges

2019-04-17 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Signed-off-by: Topi Miettinen 

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20645

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20584: ProcessList: add NoNewPrivileges

2019-04-15 Thread Topi Miettinen 
topimiettinen added a comment.


  This is related to D20583 .
  
  Example output:
  
ksysguardd> ps?
NamePID PPIDUID GID Status  User Time   System Time 
NiceVmSize  VmRss   VmURss  Login   TracerPID   TTY Command IO 
Priority Class   IO Priority NNP
s   d   d   d   d   S   d   d   d   D   
D   D   s   d   s   s   d   d   d
ksysguardd> ps
init1   -1  0   0   sleeping33  283 0   
169996  96442208root-1  /sbin/init  0   0   
0
wpa_supplicant  781 1   64211   111 sleeping8   46  
0   20028   8008752 wpa_supplicant  -1  
/sbin/wpa_supplicant -c/etc/wpa_supplicant.conf -Dnl80211,wext -iwlan0  0   
0   1

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20584

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20584: ProcessList: add NoNewPrivileges

2019-04-15 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Show Linux flag NoNewPrivileges in ksysguardd output.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D20584

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20583: process: add NoNewPrivileges

2019-04-15 Thread Topi Miettinen 
topimiettinen added a comment.


  F6774811: screenshot.bmp 

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20583

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20583: process: add NoNewPrivileges

2019-04-15 Thread Topi Miettinen 
topimiettinen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
topimiettinen requested review of this revision.

REVISION SUMMARY
  Display Linux process flag NoNewPrivileges.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D20583

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h

To: topimiettinen
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart