D25670: Synchronize decorations buttons order in GTK headerbars

[Tranter Madi]

trmdi added a comment.


  Excuse me, could you have a look to see if this bug relates to this patch or 
not? 
https://www.reddit.com/r/kde/comments/imnpny/firefox_global_menu_patch_removes_the_headerbar/

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25670

To: gikari, #vdg, cblack, #plasma, apol
Cc: trmdi, apol, GB_2, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Tranter Madi]

trmdi added a comment.


  Can this be moved to krunner? In that case it can be used even when the user 
doesn't use global menu?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: trmdi, nicolasfella, gikari, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Tranter Madi]

trmdi added a comment.


  Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". 
Does this support it?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28623

To: gikari, #breeze, #plasma, cblack
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Tranter Madi]

trmdi added a comment.


  In D29395#662576 , @ngraham wrote:
  
  > Now the inner image has a greater top margin than bottom margin. Also, 
could the artist and album be allowed to become two-line strings before 
eliding, maybe? F8282138: Screenshot_20200503_202710.png 

  
  
  There seems to be lots of wasted space whereas the text is truncated ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29260: Clean up desktop config window size code and set a better default size

[Tranter Madi]

trmdi added a comment.


  In D29260#659172 , @ngraham wrote:
  
  > `GridUnit * 40` works out to be 720 px high with the default 10pt Noto Sans 
font, which is enough space to not interfere with the default 36px bottom panel.
  >
  > But there's no way around the fact that this window greatly benefits from 
more space. On such a small screen resolution, I would expect people to want to 
just maximize the window.
  
  
  Can the thumbnails be smaller instead? That always looks much better on small 
screens.
  Maximize this window is a weird thing, because it's very difficult to see the 
new wallpaper.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29260

To: ngraham, #vdg, #plasma
Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29260: Clean up desktop config window size code and set a better default size

[Tranter Madi]

trmdi added a comment.


  Please keep in mind that not everyone uses a high res screen. 1366x768 is a 
very popular one, please don't make it too big on those screens. :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29260

To: ngraham, #vdg, #plasma
Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Tranter Madi]

trmdi added a comment.


  In D28985#652097 , @ngraham wrote:
  
  > Excellent!
  >
  > Please land on the `Plasma/5.18` branch and then merge to master. Let me 
know if you need a hand with that.
  
  
  Yes, please. I don't know how to do that.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff

REVISION DETAIL
  https://phabricator.kde.org/D28985

To: trmdi, #plasma, hein, ngraham, davidedmundson
Cc: davidedmundson, ngraham, bugseforuns, dginovker, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28985: [Kickoff] Disable tabBar's mouseArea when searching

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  When the root is in the "Search" state, we can safely disable it.
  
  BUG: 420282

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff

REVISION DETAIL
  https://phabricator.kde.org/D28985

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: trmdi, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi updated this revision to Diff 77644.
trmdi added a comment.


  Nate's comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27998?vs=77643=77644

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:204
> I would make this label non-visible when `dndToMoveEnabler.checked` is false, 
> rather than changing its text.

If there is a new stuff below this, when you make it visible, the below stuff 
will jump up.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi added a comment.


  In D27998#627623 , @ngraham wrote:
  
  > Where? Being wrong in multiple places doesn't make it right. ;)
  
  
  On the left panel.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi updated this revision to Diff 77643.
trmdi added a comment.


  Nate's comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27998?vs=77509=77643

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi added a comment.


  In D27998#627605 , @ngraham wrote:
  
  > Right.
  >
  > @bugseforuns's objection is that you used the word "device" to mean 
"partition" in the UI.
  
  
  Both Dolphin and Qt use this word.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi added a comment.


  In D27998#627603 , @ngraham wrote:
  
  > What does?
  
  
  dnd from /dev/sda1 -> /dev/sda1 : move
  dnd from /dev/sda1 -> /dev/sda2 : show menu

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: [KCMs/Workspace] Add option for dndToMove

[Tranter Madi]

trmdi added a comment.


  Yes, it means "partition".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: bugseforuns, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27998: Add workspace kcm option for dndToMove

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> meven wrote in main.qml:150
> You can nowadays write `!kcm.globalsSettings.isDndToMoveImmutable`
> That was added recently. D26368 

Thanks, but maybe this need another patch. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27998

To: trmdi, #vdg, #plasma, ngraham
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27998: Add workspace kcm option for dndToMove

[Tranter Madi]

trmdi updated this revision to Diff 77509.
trmdi added a comment.


  Move to bottom, add hint

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27998?vs=77478=77509

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: trmdi, #vdg, #plasma, ngraham
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27998: Add workspace kcm option for dndToMove

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: VDG, Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Add gui for the new `dndToMove` option.
  Depend: D27951 

TEST PLAN
  It writes to `~/.config/kglobals` properly.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27998

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: trmdi, #vdg, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27458

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 76629.
trmdi added a comment.


  Rename m_realVisible to m_requestedVisible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=76597=76629

BRANCH
  arcpatch-D27458 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 76597.
trmdi added a comment.


  Small fix.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=76596=76597

BRANCH
  arcpatch-D27458 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 76596.
trmdi added a comment.


  Never show before position is set

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=75883=76596

BRANCH
  arcpatch-D27458 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi added a comment.


  In D27458#618437 , @davidedmundson 
wrote:
  
  >   Idea is nice.
  >   
  >
  > Does this not jitter on first load? Starting off in 0,0 then moving across?
  >  We now have position async() but we're doing that after we've shown the 
window.
  
  
  I don't really understand the problem you're talking about, but it shows up 
in a normal way without any change.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27458

To: trmdi, #plasma, davidedmundson
Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  In D27329#611907 , @mvourlakos 
wrote:
  
  > In D27329#611906 , @trmdi wrote:
  >
  > > How about this?
  > >  F8104781: image.png 
  >
  >
  > You can also try the GoldNumber/Ratio that is found in all real nature 
patterns and also at Ancient Greeks in their architectural buildings. That is 
1.618, there is a big chance that it feels right without being able to explain 
why.
  
  
  But others don't like a wide thumbnail. :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: mvourlakos, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi updated this revision to Diff 75959.
trmdi added a comment.


  - Increase the height a bit more, the last effort.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27329?vs=75486=75959

BRANCH
  adjust-size-of-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27329

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #vdg, #plasma, ngraham
Cc: mvourlakos, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 75883.
trmdi added a comment.


  Improve code style

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=75879=75883

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 75879.
trmdi added a comment.


  Use asyncCall

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=75828=75879

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  In wayland, QScreen::availableGeometry() returns QScreen::geometry(), we 
could get a better value from plasmashell
  
  CCBUG: 386114

TEST PLAN
  Krunner isn't overlapped by a top panel in all cases

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  How about this?
  F8104781: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  Hmm, I think the 1.5 ratio makes a nice shape, the thumbnail is also not too 
small.
  A tooltip has texts and a thumbnail, we needn't too focus in the thumbnail.
  
  F8098753: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi added a comment.


  We can increase the height a bit, but not sure which ratio is the best.
  Another thing is that, even with a bigger thumbnail, we could hardly see its 
content, so making it bigger doesn't make it more clear.
  
  In D27329#609831 , @ngraham wrote:
  
  > Okay, seeing this in action, I don't hate it. However I feel like my 
concern with the album art being squeezed too much is valid:
  >
  > F8098196: Screenshot_20200211_104708.png 

  >
  > Even the windows previews get squeezed a lot:
  >
  > F8098199: Screenshot_20200211_104800.png 

  >
  > If we're going to do this, I think the rectangle should be either larger or 
taller.
  
  
  We should avoid making it larger, otherwise it looks ugly on small screens.
  Does the 1.5 ratio look better to you?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27329

To: trmdi, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi updated this revision to Diff 75486.
trmdi added a comment.


  - Increase the height a bit

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27329?vs=75484=75486

BRANCH
  adjust-size-of-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27329

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

TEST PLAN
  The size of tooltips are not changed between cases
  e.g. a normal window vs a window which is available on all activities,
  e.g. a normal window vs a window which has a player...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  adjust-size-of-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27329

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c8a7a3bd98a8: Scroll the truncated song/artist text when 
long hovering over it (authored by trmdi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75321=75322

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi updated this revision to Diff 75321.
trmdi added a comment.


  - Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75287=75321

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27262: Reduce blank space inside tooltip's header

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5be0b548b6ed: Reduce blank space inside tooltips 
header (authored by trmdi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27262?vs=75288=75320

REVISION DETAIL
  https://phabricator.kde.org/D27262

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27262: Reduce blank space inside tooltip's header

[Tranter Madi]

trmdi added a subscriber: ngraham.
trmdi added a comment.


  Do you have any objection @ngraham ?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reduce-tooltip-blank-space (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27262

To: trmdi, #plasma, #vdg, ndavis
Cc: ngraham, davidedmundson, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27262: Reduce blank space inside header

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Make the tooltip as compact as possible. This is also consistent with texts 
inside playerControlRow

REPOSITORY
  R119 Plasma Desktop

BRANCH
  reduce-tooltip-blank-space (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27262

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi updated this revision to Diff 75287.
trmdi added a comment.


  - Remove the redundant line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75286=75287

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi updated this revision to Diff 75286.
trmdi added a comment.


  - Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=75026=75286

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis
Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27219: Center placeholder texts in system tray popups

[Tranter Madi]

trmdi added a comment.


  Could you post screenshots of a same tab?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27219

To: ngraham, #vdg, #plasma
Cc: trmdi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ngraham wrote in ToolTipInstance.qml:100
> Depends on the font; you can't necessarily count on that.

Heading has `lineHeight: 1.2`, so there are 2 things for padding here right? 
Could we remove one?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

[Tranter Madi]

trmdi added a comment.


  It's super big on my 1366x768 screen:
  
  Before:
  F8090526: image.png 
  After:
  F8090521: image.png 
  
  And the Before and After size are not the same.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi added a comment.


  Any other objection?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

To: trmdi, #plasma, #vdg, ndavis
Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ngraham wrote in ToolTipInstance.qml:79
> If we do that, then the size of the preview/album art area can get very 
> short, which I don't think is desirable.

I think it still looks acceptable, not tool short. This is the worst case:
F8088588: image.png 

The better case without the "Activities..." line, the albumArt will be bigger.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:100
> +ColumnLayout {
> +spacing: units.smallSpacing
> +

Could it be zero here? Because `Text` lines already has its own padding, isn't 
it?

> ngraham wrote in ToolTipInstance.qml:79
> If we do that, then the size of the preview/album art area can get very 
> short, which I don't think is desirable.

Could we have a fixed size rectangle with some ratio?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:79
> +// This number controls the overall size of the window tooltips
> +Layout.maximumWidth: units.gridUnit * 17
> +Layout.minimumWidth: isWin ? Layout.maximumWidth : 0

How do you choose the number 17? On small screens, the tooltip is a bit too big.
Could it be smaller? e.g. 14-15 looks better on my small screen.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27182: [applets/taskmanager] Clean up Tooltip code

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:39
>  
> -spacing: units.smallSpacing
> -

Why do you remove all `spacing`? This increases lots of wasted space which is 
not good at least on small screens like 1366x768.

> ToolTipInstance.qml:79
> +// This number controls the overall size of the window tooltips
> +Layout.maximumWidth: units.gridUnit * 17
> +Layout.minimumWidth: isWin ? Layout.maximumWidth : 0

Should we make the height `const` like this too? e.g. make it a golden 
rectangle?
F8088397: image.png 

Otherwise, the size of the tooltip may be not consistent in all cases, e.g. a 
normal window vs a window which is available on all activities.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi updated this revision to Diff 75026.
trmdi added a comment.


  - Address broulik's comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=74981=75026

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ScrollableTextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis
Cc: broulik, cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi updated this revision to Diff 74981.
trmdi added a comment.


  - Add license

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27149?vs=74972=74981

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/TextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg, ndavis
Cc: cblack, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26514: Delay popup when dropping things into containments

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:36e918b09780: Delay popup when dropping things into 
containments (authored by trmdi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26514?vs=74264=74978

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi, #plasma, davidedmundson, broulik, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27149: Scroll the truncated song/artist text when long hovering over it

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - When the text is truncated, we could hover over it to read the full text

TEST PLAN
  Everything works well

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-tooltip-textWrapper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27149

AFFECTED FILES
  applets/taskmanager/package/contents/ui/TextWrapper.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: trmdi, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#602951 , @ngraham wrote:
  
  > Argh, now I can see it too: F8008546: weird margin.webm 

  >
  > No idea what's causing this. The code seems conceptually right to me. Maybe 
something's getting rounded up instead of down or something.
  
  
  Yep, that is. A possible solution I found is to round up `winTitle.height` 
like this: 
https://phabricator.kde.org/source/latte-dock/browse/master/plasmoid/package/contents/ui/previews/ToolTipInstance.qml$175

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27016: Update from Plasma's ToolTip

[Tranter Madi]

trmdi created this revision.
trmdi added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Add highlight effect when hovering over the tooltip's thumbnail

REPOSITORY
  R878 Latte Dock

BRANCH
  add-highlight

REVISION DETAIL
  https://phabricator.kde.org/D27016

AFFECTED FILES
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#602082 , @filipf wrote:
  
  > ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  >
  > One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.
  
  
  Try changing the General Font size to see if you can reproduce it. On my 
system, I can reproduce it with `Noto 10`, but not with `Noto 11`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#601921 , @ngraham wrote:
  
  > In D26739#601762 , @trmdi wrote:
  >
  > > Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.
  >
  >
  > With the latest iteration of the patch, they should be. Feel free to try it 
out for yourself!
  
  
  Do you see this or just me?
  F7989597: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#601666 , @ndavis wrote:
  
  > Actually, I just noticed a problem. When you hover over the bar, the 
thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring 
the window to the front.
  
  
  Yes, that is what I'm asking. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  What happens when you hover the mouse on the control bar? Did you address it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml 
(authored by trmdi).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26760?vs=74260=74296

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi added a comment.


  Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 
to be committed, then I will add it to this patch. It looks pretty nice. :)

REPOSITORY
  R878 Latte Dock

BRANCH
  update-ToolTipInstance-fromPlasma (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26720: Cache single image wallpapers locally

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> trmdi wrote in image.cpp:503
> `QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath

Sorry, I meant QDir::mkpath is needed for KIO::CopyJob, not here, otherwise 
CopyJob will fail when the destination directory does not exist.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26720

To: ngraham, #plasma, davidedmundson
Cc: trmdi, davidedmundson, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Pretty nice.
  But clicking on `playerControlsRow` (exclude buttons) does not behave the 
same way like clicking on the cover art, while the effect would make users 
think that they can click on the control row to open the window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26514: Delay popup for containments

[Tranter Madi]

trmdi updated this revision to Diff 74264.
trmdi added a dependency: D26484: Add KIO::DropJobFlag to allow manually 
showing the menu.
trmdi added a comment.


  - Show drop menu manually when dropping things into the desktop

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26514?vs=73081=74264

BRANCH
  improve-dropJob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi added a comment.


  In D26760#599227 , @mvourlakos 
wrote:
  
  > @trmdi have you checked the previews still work OK after the patch?
  
  
  Yes, I tested it.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi updated this revision to Diff 74260.
trmdi added a comment.


  - Address comment

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26760?vs=73935=74260

BRANCH
  update-ToolTipInstance-fromPlasma (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  How about this?
  
  F7894214: vokoscreen-2020-01-20_23-10-29.mp4 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Could you clarify before/after screenshots?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26720: Cache single image wallpapers locally

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> image.cpp:503
> +// check the cache
> +} else if (QFile::exists(m_cachedWallpaperPath)) {
> +m_wallpaperPath = m_cachedWallpaperPath;

`QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26720

To: ngraham, #plasma, davidedmundson
Cc: trmdi, davidedmundson, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:175
>  // round necessary, otherwise shadow mask for players has gap!
> -height: Math.round(0.5 * width) + (!winTitle.visible? 
> winTitle.height : 0)
> +height: Math.round(0.5 * width) + (!winTitle.visible? 
> Math.round(winTitle.height) : 0)
>  anchors.horizontalCenter: parent.horizontalCenter

I still don't know why Plasma ToolTip doesn't need this. But it is needed here.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi updated this revision to Diff 73935.
trmdi added a comment.


  - hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom 
margin of the tooltip

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26760?vs=73876=73935

BRANCH
  update-ToolTipInstance-fromPlasma (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi updated this revision to Diff 73876.
trmdi added a comment.


  - Add https://phabricator.kde.org/D11025

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26760?vs=73861=73876

BRANCH
  update-ToolTipInstance-fromPlasma

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi added a comment.


  In D26760#596760 , @mvourlakos 
wrote:
  
  > Is there any improvement, or it is just a code update?
  
  
  Some minor improvements:
  
  - https://phabricator.kde.org/D22230
  - https://phabricator.kde.org/D21629

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma

[Tranter Madi]

trmdi created this revision.
trmdi added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Just pull the update from Plasma

REPOSITORY
  R878 Latte Dock

BRANCH
  update-ToolTipInstance-fromPlasma

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26525: Fix wallpaper destination path

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2212a9af156b: Fix wallpaper destination path (authored by 
trmdi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26525?vs=73217=73640#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26525?vs=73217=73640

REVISION DETAIL
  https://phabricator.kde.org/D26525

AFFECTED FILES
  wallpapers/image/image.cpp

To: trmdi, #plasma, mart, ngraham
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi added a comment.


  Ping. Could I land this now?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma, mart, ngraham
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi added a comment.


  @mart
  Are you ok with this now ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi updated this revision to Diff 73217.
trmdi added a comment.


  - Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26525?vs=73115=73217

BRANCH
  fix-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26525

AFFECTED FILES
  wallpapers/image/image.cpp

To: trmdi, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> mart wrote in image.cpp:555
> I would prefer it to ask before owerwriting

Do I need to modify this or just land it now?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wallpaper

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma, mart
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> mart wrote in image.cpp:554
> this is for first run when ~/.local/share/wallpapers isn't there yet?

This is to check if the directory is available before copying, otherwise 
FileCopyJob would fail.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26525

To: trmdi, #plasma
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi updated this revision to Diff 73115.
trmdi added a comment.


  - Improve code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26525?vs=73070=73115

BRANCH
  fix-wallpaper

REVISION DETAIL
  https://phabricator.kde.org/D26525

AFFECTED FILES
  wallpapers/image/image.cpp

To: trmdi, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26514: Delay popup for containments

[Tranter Madi]

trmdi updated this revision to Diff 73081.
trmdi added a comment.


  - Sync with the dependency

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26514?vs=73080=73081

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi, #plasma, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26514: Delay popup for containments

[Tranter Madi]

trmdi updated this revision to Diff 73080.
trmdi added a comment.


  - Sync with the dependency

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26514?vs=73029=73080

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi, #plasma, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26525: Fix wallpaper destination path

[Tranter Madi]

trmdi created this revision.
trmdi added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  - Correct the destination path when downloading images.
  - Add the `KIO::Overwrite` for the file copy job.
  
  BUG: 379469

TEST PLAN
  Drop files from Firefox to the desktop to set the wallpaper successfully.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-wallpaper

REVISION DETAIL
  https://phabricator.kde.org/D26525

AFFECTED FILES
  wallpapers/image/image.cpp

To: trmdi, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26514: Delay popup for containments

[Tranter Madi]

trmdi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Make use of the new parameter added in D26484 

  
  BUG: 415917

TEST PLAN
  Drop files into desktop folder layout/folder widget, the menu is shown 
correctly in all cases.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D4574: [WIP]: unify file drop menu and containment

[Tranter Madi]

trmdi added a comment.


  This patch seems to cause this bug: 
https://bugs.kde.org/show_bug.cgi?id=415917

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4574

To: mart, #plasma, hein
Cc: trmdi, hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26298: Add license to new files

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:78210e2780cf: Add license to new files (authored by 
trmdi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26298?vs=72407=72408

REVISION DETAIL
  https://phabricator.kde.org/D26298

AFFECTED FILES
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26298: Add license to new files

[Tranter Madi]

trmdi added a comment.


  In D26298#584838 , @ngraham wrote:
  
  > If you wrote this whole file yourself, you only need to add your own 
copyright. :)
  
  
  I wrote it with David's help so I would want to add him here. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26298

To: trmdi, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26298: Add license to new files

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Add license to strutmanager.*

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26298

AFFECTED FILES
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi added a comment.


  Thank you so much @davidedmundson!
  
  @mvourlakos: I think you can improve Latte now. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:e8e360862fb7: Allow to set the available screen 
rect/region from outside through dbus (authored by trmdi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=72387=72388

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi updated this revision to Diff 72387.
trmdi added a comment.


  - Drop the test method

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=72384=72387

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi updated this revision to Diff 72384.
trmdi added a comment.


  - Use const reference for some parameters

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25807?vs=71980=72384

BRANCH
  add-otherShellHelper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25807

AFFECTED FILES
  shell/CMakeLists.txt
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in strutmanager.h:25
> what's this about?

This is just for easily testing using the qdbus command.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25807: Allow to set the available screen rect/region from outside through dbus

[Tranter Madi]

trmdi added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25807

To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi abandoned this revision.
trmdi added a comment.


  In D26266#584135 , @mvourlakos 
wrote:
  
  > What is ConfigOverlay for plasma panels is using at its tooltip?
  
  
  Ah, I was wrong. "delete" should be the right one. Sorry.
  
https://github.com/KDE/plasma-desktop/blob/def96d60241ad7c835532ee09bf95afb7f56fed7/containments/panel/contents/ui/ConfigOverlay.qml#L408

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi added a comment.


  But I've just found that Plasma panels use QIcon::fromTheme which load the 
icon from the icon theme, while PlasmaComponent.ToolButton loads icon from 
Plasma theme, that is not consistent in some cases. What do you think?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Latte Dock, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Follow Plasma codes
  
https://github.com/KDE/plasma-framework/blob/ccceb83b107213ba5d2077fc346d4ab8a027d049/src/plasma/private/applet_p.cpp#L386

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26266

AFFECTED FILES
  containment/package/contents/ui/editmode/ConfigOverlay.qml
  shell/package/contents/configuration/LatteDockConfiguration.qml

To: trmdi, #latte_dock, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:fe5dbf9f2b96: Improve context menu (authored by trmdi).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72253=72255

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/layouts/manager.h
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  app/shortcuts/globalshortcuts.cpp
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  plasmoid/package/contents/ui/ContextMenu.qml

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  In D26238#583556 , @mvourlakos 
wrote:
  
  > In D26238#583555 , @trmdi wrote:
  >
  > > In D26238#583551 , @mvourlakos 
wrote:
  > >
  > > > @trmdi I used Cuttlefish app, it points to **"edit"**
  > >
  > >
  > > Maybe it's `document-edit`.
  > >  (See this: 
https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.html#l00127)
  >
  >
  > Correct
  
  
  Could I land it now?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart