D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:61259acda87b: [plasma-pa] Add command to switch all 
applications to the selected device (authored by vpilo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19014?vs=52146=57304

REVISION DETAIL
  https://phabricator.kde.org/D19014

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/device.h
  src/sink.cpp
  src/sink.h
  src/source.cpp
  src/source.h

To: vpilo, #plasma, broulik, drosca, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added a comment.


  Excellent. Sorry I had no time to follow up for the icon creation yet.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vpilo/switchStreamsToDevice (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added a comment.


  In D19014#417976 , @ngraham wrote:
  
  > In D19014#417906 , @vpilo wrote:
  >
  > > @ngraham If a new icon should be made, who could do it and how does the 
request process go?
  >
  >
  > #VDG  can hook you up. File a bug in 
Breeze | Icons and mention this patch. Then go plug it in the #kde-vdg IRC 
channel/matrix room. :)
  
  
  If it's okay, I'll ask for the icon and add it to the menu as a separate 
patch, so at least we can get the functionality out.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added a comment.


  @ngraham If a new icon should be made, who could do it and how does the 
request process go?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added a comment.




INLINE COMMENTS

> ngraham wrote in ListItemBase.qml:315
> Of those, I'd say `audio-ready` seems least inappropriate, but It almost 
> seems like we need a new icon that uses the speaker symbol with an arrow 
> somewhere in it to connote movement and change.

I hoped I could use a normal "speaker" and "microphone" icon and add an emblem 
on it, like "checked" or "important"; but it's more difficult than I envisioned.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added a reviewer: VDG.
vpilo added inline comments.

INLINE COMMENTS

> ListItemBase.qml:315
> +menuItem.text = i18n("Play all audio via this device");
> +menuItem.icon = "audio-on" // or "audio-ready" // or 
> "audio-speakers-symbolic"
> +menuItem.clicked.connect(function() {

All three options for icons are for me ok, what about #vdg 
 ?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo updated this revision to Diff 52146.
vpilo added a comment.


  - Review comments
  - Add icons

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19014?vs=51895=52146

BRANCH
  vpilo/switchStreamsToDevice (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19014

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/device.h
  src/sink.cpp
  src/sink.h
  src/source.cpp
  src/source.h

To: vpilo, #plasma, broulik, drosca
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:6e53d78136df: [plasma-pa] Increase minimum size of 
expanded plasmoid (authored by vpilo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19013?vs=51862=51896

REVISION DETAIL
  https://phabricator.kde.org/D19013

AFFECTED FILES
  applet/contents/ui/main.qml

To: vpilo, #plasma, broulik, drosca, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo updated this revision to Diff 51895.
vpilo added a comment.


  - Review comments

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19014?vs=51699=51895

BRANCH
  vpilo/switchStreamsToDevice (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19014

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/device.h
  src/sink.cpp
  src/sink.h
  src/source.cpp
  src/source.h

To: vpilo, #plasma, broulik, drosca
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added inline comments.

INLINE COMMENTS

> ngraham wrote in ListItemBase.qml:306
> How about "Play all audio using this device"

Better already; I'm also concerned whether the label should become too long. 
Let's see what happens.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo added a comment.


  I would love some input about:
  
  - The wording of the menu entry.
  - The possibility of having an icon for the menu entry.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19014

To: vpilo, #plasma, broulik, drosca
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

[Valerio Pilo]

vpilo updated this revision to Diff 51862.
vpilo added a comment.


  - Review comments

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19013?vs=51698=51862

BRANCH
  vpilo/minimumSize

REVISION DETAIL
  https://phabricator.kde.org/D19013

AFFECTED FILES
  applet/contents/ui/main.qml

To: vpilo, #plasma, broulik, drosca
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

[Valerio Pilo]

vpilo added a comment.


  In D19013#413022 , @ngraham wrote:
  
  > How about even bigger? In standalone form, there's no reason to skimp on 
size IMO.
  
  
  Thought there was some constraint :) I'll go crazy and say 18.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D19013

To: vpilo, #plasma, broulik, drosca
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19014: [plasma-pa] Add command to switch all applications to the selected device

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  If you have many applications running (e.g. browser tabs) it's very annoying 
to manually switch them all to another device. With this context menu option, 
it's now very easy.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vpilo/switchStreamsToDevice (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19014

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/device.h
  src/sink.cpp
  src/sink.h
  src/source.cpp
  src/source.h

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vpilo/minimumSize

REVISION DETAIL
  https://phabricator.kde.org/D19013

AFFECTED FILES
  applet/contents/ui/main.qml

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1b49255d81f0: [plasma-nm] Refresh wifi networks as fast 
as possible (authored by vpilo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18896?vs=51677=51687

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo updated this revision to Diff 51677.
vpilo added a comment.


  - Review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18896?vs=51525=51677

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo added inline comments.

INLINE COMMENTS

> jgrulich wrote in main.qml:78
> Since this is just one line function, you can use handler.requestScan() 
> directly as before.

I did it for consistency, so in both files there's only one action. It's also 
useful for debugging.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo updated this revision to Diff 51525.
vpilo added a comment.


  - Review comments, rework
  
  - Put the timer back to 15s
  - Removed trigger on start for QML timers: the timer now only runs if the 
current scan was successful
  - Don't use any more Qt 5.12 APIs

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18896?vs=51315=51525

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo added a comment.


  In D18896#409742 , @jgrulich wrote:
  
  > I would keep the 15s interval, everyone does 15s. Also from what I have 
read, every scan drops your connection for a while, which might be a problem 
for bad wifi drivers, where the scan can take 15+ seconds so doing this more 
often is not a good idea. Other thing I would change is to try to repeat the 
scan if it fails only for the first time (when you open the applet), then I 
don't think it's necessary to keep spamming NetworkManager with our requests.
  
  
  Everyone using 15 seconds for a timeout doesn't mean it's good for the 
users... Anyways, why shouldn't we be doing an attempt every 2 seconds? that's 
not a lot. I could do two things instead:
  
  - double the interval between attempts every time they fail
  - Only run the UI timer when the scan request has been successful

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18896: [plasma-nm] Refresh wifi networks as fast as possible

[Valerio Pilo]

vpilo created this revision.
vpilo added reviewers: jgrulich, ngraham, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
vpilo requested review of this revision.

REVISION SUMMARY
  The current 15s timeout is really annoyingly long, but unfortunately, 12s is 
as fast as we can get: NM has a 10s hard timeout, plus 2s is how long many 
devices seem to take to perform a scan.
  
  Added a retry on failure to prevent unnecessarily long waiting times before 
the next scab. This usually happens when closing and reopening the applet, or 
when a scan was started by another component before opening the applet.

TEST PLAN
  - First enable debug logging, there is no UI feedback
  - Tested opening/closing the applet every now and then: wifis are scanned as 
early as NM allows
  - Tested switching to the NM KCM, then switching to the applet, then to the 
KCM again: wifis are always scanned as early as allowed

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/wifiRefresh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18896

AFFECTED FILES
  applet/contents/ui/main.qml
  kcm/kcm.cpp
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/main.qml

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo abandoned this revision.
vpilo added a comment.


  I am abandoning this revision, since a button would be useless 95% of the 
time, thanks to NetworkManager.
  
  I'm submitting an automated retry mechanism. Later, I'd like to try adding 
some status icon showing when a new scan has been started, to let the user know 
//something// is happening.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: broulik, davidedmundson, alexeymin, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo abandoned this revision.
vpilo added a comment.


  In D18814#407090 , @davidedmundson 
wrote:
  
  > What problem are we solving?
  >
  > If someone said "in a shell" I would expect to see a terminal (a shell) 
appear. That's not the case.
  
  
  I thought an inexperienced user could be helped by a more precise outlining 
of the result.
  
  In D18814#407087 , @ngraham wrote:
  
  > By making this label long, the available room for the command itself is 
correspondingly reduced, and this UI already has a limited amount of horizontal 
space. It's probably worse for other languages.
  >
  > I think the current string is fine given that it says "Command line" to the 
left.
  
  
  Fair enough.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo added a comment.


  In D18814#407083 , @davidedmundson 
wrote:
  
  > It already says "Command line" in the group title on the left a console 
icon and unlike apps has the prefix "Run "
  
  
  "Run %1 in a shell" then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  This makes sure the end result of the consequence of clicking this runner's 
results (running a shell command).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  vpilo/clarifyKRunnerShell (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18814

AFFECTED FILES
  runners/shell/shellrunner.cpp

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18745: Fix connections' context menus position and parent

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:5000fc973c6d: Fix connections context menus 
position and parent (authored by vpilo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18745?vs=50971=51018

REVISION DETAIL
  https://phabricator.kde.org/D18745

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

To: vpilo, broulik, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18745: Fix connections' context menus position and parent

[Valerio Pilo]

vpilo updated this revision to Diff 50971.
vpilo added a comment.


  Reworked.
  
  There already were lots of binding loops in this QML, stuff for another change

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18745?vs=50910=50971

BRANCH
  vpilo/fixRightClick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18745

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

To: vpilo, broulik, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo added a comment.


  In D18504#405816 , @ngraham wrote:
  
  > In D18504#405444 , @vpilo wrote:
  >
  > > In D18504#404332 , @Codezela 
wrote:
  > >
  > > > small tweak we can make the connection name in the context menu bold 
header msybe
  > > >  because it look like disabled now
  > > >  it looks strange to me
  > > >  what do u think
  > >
  > >
  > > I tried. Somehow, even if I should be able to, I can't access the `font` 
property. The applet fails to load.
  >
  >
  > The problem is that you're using a disabled menu item for the title, which 
makes the font light automatically. Try setting `supportsMouseEvents: false` 
for it, and then you can style it however you want (+1 for bold, do 
`font.weight: Font.Bold` to get that)
  
  
  Looks like I can't, none of the items in the object tree seem to support that 
property, and it's not in the Qt dox? It's only in a few kirigami items. Can 
you be more specific? Are you suggesting I use another type of Menu?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg, jgrulich
Cc: Codezela, broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18745: Fix connections' context menus position and parent

[Valerio Pilo]

vpilo added a comment.


  In D18745#405458 , @jgrulich wrote:
  
  > This breaks connection details, try to expand details for some available 
connection. There appears to be some issue with heigh of the items.
  
  
  Oh, looks like I didn't test the latest change for available connections, 
only for active ones. I'll check, thank you.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18745

To: vpilo, broulik, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18745: Fix connections' context menus position and parent

[Valerio Pilo]

vpilo created this revision.
vpilo added reviewers: broulik, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
vpilo requested review of this revision.

REVISION SUMMARY
  A connection's context menu now opens only from the main item, not from the 
expanded details;
  this allows again copying the connection information (as per comments in 
D18504 ).
  
  Also fixed a binding loop about heights.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/fixRightClick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18745

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

To: vpilo, broulik, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo added a comment.


  In D18504#404332 , @Codezela wrote:
  
  > small tweak we can make the connection name in the context menu bold header 
msybe
  >  because it look like disabled now
  >  it looks strange to me
  >  what do u think
  
  
  I tried. Somehow, even if I should be able to, I can't access the `font` 
property. The applet fails to load.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg, jgrulich
Cc: Codezela, broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo added a comment.


  Let me be clear here - I don't really care about having this change merged, 
or having to rewrite it into something wholly different. I just want everyone 
to have their list of wifi networks to be up to date //when they need it//, 
that is, //when the nm applet is open//.
  If it means I have to instead go pester NetworkManager people for a 
configurable timeout or such, so be it - I just want to have a discussion to 
have a result that works.
  
  That said, I think @jgrulich 's comment reliability doesn't hold much water, 
as we cannot really make it 'reliable': for now we can just spam NM with scan 
commands until we get a success.
  We have a basic issue (the hard 10s timeout in NM) and there's nothing that 
anyone in KDE can do about it, save patching NM itself. So can we talk about 
its mitigation for now? Maybe not a button, maybe constantly trying to request 
scans until we get a positive answer? Anything will be better than having to 
stare for fifteen plus seconds at the nm applet until my damn tethering network 
finally appears in the applet and I can send my email.
  
  I'll see about asking the NM devs about why is it so incredibly long and if 
it can be made configurable.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: davidedmundson, alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:684ee0c13bfb: Add a popup search bar to the plasma-nm 
applet (authored by vpilo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18607?vs=50582=50628

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo added a comment.


  In D18621#402717 , @jgrulich wrote:
  
  > In D18621#402712 , @vpilo wrote:
  >
  > > But there are legit cases where this timeout is way too long for no 
reason.
  > >
  > > If you close the popup and reopen it before the NM timeout expires, then 
the first request will fail, no attempt will be made at redoing the scan, and 
you're stuck for 30 seconds with the same list.
  >
  >
  > 15 seconds.
  
  
  no, if your device takes 2s for a scan, and if you open the popup, close it 
and reopen it (causing a new scan request) before the 12s mark, the popup will 
wait 15 more seconds, totalling ~27s. It was just an extreme example. 
Regardless, it's still a huge delay, if you consider that any phone will take 
~2s for a scan //but rescan every 3-4s// when you have the wifi settings open.
  
  > Then you can fix this instead. You can check last scan attempt and make it 
to scan a bit later. There is a property in NM::WirelessDevice::LastScan, you 
can see when the last scan was performed and once the applet is opened, do a 
scan as soon as possible when you are sure the attempt will not fail.
  
  I can find LastScan in the fd.o apidox, but not in NMQt... ?!?
  
  If NM didn't have this timeout, we could have chosen ourselves how to do it 
(e.g. waiting for LastScan to be 5s in the past, then scan again). But it's now 
somewhat frustratingly slow, and a button could save a few seconds of annoyance 
that usually instead result in the user losing their patience and turning wifi 
off and on instead.
  I know this whole proposal sounds silly.. for me this also is silly. This is 
however about improving the user experience in a few use cases, so I'm trying 
to mitigate it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo added a comment.
Herald added 1 blocking reviewer(s): jgrulich.


  But there are legit cases where this timeout is way too long for no reason.
  
  If you close the popup and reopen it before the NM timeout expires, then the 
first request will fail, no attempt will be made at redoing the scan, and 
you're stuck for 30 seconds with the same list.
  If your device takes 1 second for a full scan, you still have an useless wait 
of 5 more seconds before you can see the new wifi list.
  
  All this while an user with a phone in their hand can already see updated 
wifi lists every 3-5 seconds, while the pc lags terribly behind. Honestly, if 
there was a way to configure away this 10s NM timeout, I would do it straight 
away. I'd also immediately try to add a configuration checkbox in the applet to 
disable it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo updated this revision to Diff 50583.
vpilo added a comment.


  - Review comments: change button tooltip

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18621?vs=50566=50583

BRANCH
  vpilo/refreshButton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18621

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  libs/handler.cpp
  libs/handler.h

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo marked an inline comment as done.
vpilo added inline comments.

INLINE COMMENTS

> PopupDialog.qml:45
>  
> -Toolbar {
> -id: toolbar
> +ColumnLayout {
> +anchors.fill: parent

This is to solve layouting issues when toggling the search bar.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo updated this revision to Diff 50582.
vpilo added a comment.


  - New implementation with a toolbutton
- Also added search reset on Esc keypress, on applet close, on search close
  
  I made a few tests and with all 3 toolbuttons (wifi/mobile/airplane) in 
place, also adding the search bar to the toolbar itself makes it cramped and 
you can't type a lot in it.
  This version IMHO looks neater and I think still pretty unobtrusive, while 
still making the feature discoverable by having a button.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18607?vs=50567=50582

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo added a comment.


  In D18621#402558 , @ngraham wrote:
  
  > In my opinion, this sort of thing is a "help the user feel in control" 
issue. We had the same sort of conversations in Discover back when it didn't 
have a manual "refresh updates" button. People constantly complained and we had 
to explain over and over again that it automatically fetches when launched and 
periodically after that. Didn't matter; people wanted the button anyway, and 
periodically managed to get themselves into situations where Discover would get 
wedged and a button would actually be nice. Eventually we relented and added 
the button and now people are happy. I think the same thing may be going on 
here and user confidence in the software would benefit. People would feel more 
in control with a button they can click on when it's not doing what they expect 
or not finding their network fast enough.
  
  
  1000% this. Who cares about NM  It really is about making it better for the 
user. I feel that already our 15 seconds timeout is ridiculously long.
  
  I have made some tests with plasma-nm, and then looked in NM's code 
. 
It's an actual hard timeout of 10 whole seconds. 
  I don't really have a clue why would they ever have wanted to introduced this 
long a timeout. Any mobile device, or Windows, can do much faster than this 
crap.
  So, anyways, counting the actual timeout plus whatever time your device takes 
to perform a scan, you can gain up to maybe 4 seconds by refreshing with the 
button.
  
  A plus here: we'd be shifting the blame for updating wifis slowly to the 
actual responsible, networkmanager.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PopupDialog.qml:81
> The connection view changes height depending on the presence of a search bar
> The search bar becomes visible depending on the height of the listview
> 
> I would expect that to be giving binding loops when you're on the edge.

How would I test this?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo updated this revision to Diff 50567.
vpilo added a comment.


  - review
  
  Up, not down
  No label
  Changed search label

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18607?vs=50518=50567

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18621: Add again a button to manually scan for wireless networks

[Valerio Pilo]

vpilo created this revision.
vpilo added reviewers: VDG, Plasma, jgrulich, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  The current 15 seconds timeout is really annoyingly long.
  NetworkManager ignores/refuses most rescan requests when bashing the button,
  that's the reason for the cooldown (preventing flooding NM via dbus).
  
  I also took away the scanning event altogether since it had been removed 
anyways.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/refreshButton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18621

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  libs/handler.cpp
  libs/handler.h

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  Here's my latest change, not submitted yet.
  
  | F6576947: short.png  | F6576946: 
search.png  | F6576945: long.png 
 |
  |
  
  The differences are that I moved the bar to the top, made the label into a 
placeholder text, and added a bit of margin on the textfield sides.
  
  In D18607#402431 , @jgrulich wrote:
  
  > > Putting the search bar in the toolbar on top is an interesting idea. 
There's definitely room on mine. However it does start to feel a bit cramped. 
+1 for the idea of a search field though.
  >
  > My opinion is: I don't want the search bar to take any additional vertical 
space by default, not even when there is many connections, because I don't need 
usually to scroll down to find the connection I need. On the other hand I get 
it might be useful for someone else. What about showing the search bar once 
users start typing?
  
  
  If you usually don't need to scroll down to find a connection you need, then 
you won't see the search bar.
  
  As you can see:
  
  - When the list of connections is short:
- If the user starts typing, then it shows automatically.
- When the field is emptied, then it hides.
  - When the list of connections is long enough to already need a scrollbar:
- The field is always shown, and highlighted.
- You just lose one entry of vertical space that you have to scroll through 
anyway.
  
  In D18607#402444 , @ngraham wrote:
  
  > In D18607#402435 , @jgrulich 
wrote:
  >
  > > Alternatively we can show a small input box just saying "Search ..."  and 
clicking into it to start typing it would hide all the switches in the toolbar 
(wifi, wwan, airplane) and expand across the whole toolbar?
  >
  >
  > That's not a bad idea! And then when the user clicks on the "clear text" on 
the right side of the search field, it would collapse to its prior size.
  
  
  I think my approach is less visually obtrusive, and you can still use 
everything else in the widget while the search field is active.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  In D18607#402261 , @jgrulich wrote:
  
  > Wouldn't be a small search bar placed next to the aiplane mode enough? That 
way it will not need additional vertical space. Hiding it when there is only a 
small amount of connections is a good idea.
  
  
  Isn't there way too little space for it inside of the toolbar? 
  F6576478: searchbar-searching.png 
  It would need at least 150-200 px, and that's exactly how much I have in that 
screenshot. In my panel nm applet, there's just a tiny bit more space (~50px). 
How could I visually separate it from the other buttons around it?
  
  > PS: Please add me as a reviewer next time for plasma-nm changes.
  
  Sure. Is this kind of info written anywhere?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  Better just place it at the top above the the connections list, then?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo created this revision.
vpilo added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  If there are not enough connections to fill the scrollview, the search bar is 
not displayed by default.
  If there are, the search bar is shown.
  Regardless of that, starting typing will filter the connections list and show 
the search bar.
  
  I'm uncertain whether not hiding it by default would be a good idea, 
usability wise.
  
  BUG: 344789
  BUG: 394290

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:32d76665a694: [plasma-nm/applet] Add right-click context 
menu to directly customize a… (authored by vpilo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18504?vs=50248=50435

REVISION DETAIL
  https://phabricator.kde.org/D18504

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp

To: vpilo, #vdg, jgrulich
Cc: broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo added a comment.


  In D18504#399818 , @ngraham wrote:
  
  > In D18504#399653 , @jgrulich 
wrote:
  >
  > > Does it work for you on wayland? When the menu opens, it opens in the 
left top corner of the applet and cannot be closed unless you select any 
option, but that's probably wayland + qt fault
  >
  >
  > This might be https://bugreports.qt.io/browse/QTBUG-51640, though I see 
that got closed...
  
  
  I used the new `PlasmaComponents.Menu` in the second diff and it is now 
working in Wayland too. It's unstable in my VM so I don't usually try too hard 
with it :P

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo updated this revision to Diff 50248.
vpilo marked 4 inline comments as done.
vpilo added a comment.


  - Review comments

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18504?vs=50204=50248

BRANCH
  vpilo/contextMenu

REVISION DETAIL
  https://phabricator.kde.org/D18504

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp

To: vpilo, #vdg
Cc: broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo added a comment.


  In D18504#399653 , @jgrulich wrote:
  
  > Does it work for you on wayland? When the menu opens, it opens in the left 
top corner of the applet and cannot be closed unless you select any option, but 
that's probably wayland + qt fault or perhaps it will change when using 
PlasmaComponents.Menu instead.
  
  
  Works for me with `PlasmaComponents.Menu`.

INLINE COMMENTS

> broulik wrote in ConnectionItem.qml:144
> What't this for?

I didn't want to interfere with other buttons/mouse actions/gestures. I tested 
without this and it looks like there's no issue. I took it out.

> broulik wrote in ConnectionItem.qml:153
> I don't think this header is needed, we hardly do that elsewhere.

I thought it made it easier when the wifi list changes to recognize if you 
clicked on the right item. Should I still take it away?

> broulik wrote in ConnectionItem.qml:165
> Sneaky, I didn't intend `KCMShell.open` to accept arbitrary argument :D

it's not a bug, it's a feature!

Jokes aside, it can be pretty useful to give arguments to KCModules.
 e.g. an app might say "change the file association by going to __//this 
configuration screen//__" with a link opening the right KCM with the right tab

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: broulik, jgrulich, ngraham, abetts, GB_2, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo added a comment.


  In D18504#399356 , @abetts wrote:
  
  > Do you prefer a right click over a settings or 3-dot button?
  
  
  There's already very little space - I personally think it would become 
cluttered.
  An alternative might be a link when the connection is clicked (and gets 
expanded).

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo added a comment.


  In D18504#399351 , @GB_2 wrote:
  
  > Next time please upload images directly to Phabricator.
  
  
  

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  Screenshot: https://imgur.com/MvnFdbW

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/contextMenu

REVISION DETAIL
  https://phabricator.kde.org/D18504

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  kcm/kcm.cpp

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5012: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added a comment.


  In https://phabricator.kde.org/D5012#110815, @lbeltrame wrote:
  
  > Months later, it turns out that notify-osd ships a 
org.freedesktop.Notifications.service already, so it conflicts with the one 
made by this patch.
  
  
  I wouldn't know what course of action would be best to follow in this case. 
@davidedmundson ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, 
dfaure, graesslin
Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, 
plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D4799: Delay notifications until desktop session has loaded

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:2d40672b0c85: Do not remove queued notifications when the 
fd.o service starts. Also start the… (authored by vpilo).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4799?vs=12377=12712

REVISION DETAIL
  https://phabricator.kde.org/D4799

AFFECTED FILES
  src/notifybypopup.cpp

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D4799: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added a comment.


  Ping
  
  [my excuses if it's not good practice to do so]

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D4799: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added a comment.


  I pushed https://phabricator.kde.org/D5012; this rev is now testable.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D5012: Delay notifications until desktop session has loaded

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bf889f7b94b: Add program to wait for D-Bus Notifications 
services to register. (authored by vpilo).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5012?vs=12378=12609#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5012?vs=12378=12609

REVISION DETAIL
  https://phabricator.kde.org/D5012

AFFECTED FILES
  startkde/CMakeLists.txt
  startkde/waitforname/CMakeLists.txt
  startkde/waitforname/main.cpp
  startkde/waitforname/org.freedesktop.Notifications.service.in
  startkde/waitforname/waiter.cpp
  startkde/waitforname/waiter.h

To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, 
broulik, mck182
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4799: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added reviewers: davidedmundson, dfaure, broulik, graesslin, mck182.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, 
graesslin, mck182
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D5012: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added reviewers: graesslin, dfaure, davidedmundson, broulik, mck182.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, 
broulik, mck182
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5012: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added reviewers: Plasma, Plasma: Workspaces.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo, #plasma, #plasma_workspaces
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4799: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo updated this revision to Diff 12377.
vpilo marked an inline comment as done.
vpilo added reviewers: Plasma, Plasma: Workspaces.
vpilo added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  New patchset.
  I moved the waiting program to plasma-workspace, as per the suggestions 
(thanks). I also didn't like it much there, but didn't know where it would have 
fitted better.
  
  The other diff is https://phabricator.kde.org/D5012

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4799?vs=12310=12377

REVISION DETAIL
  https://phabricator.kde.org/D4799

AFFECTED FILES
  src/notifybypopup.cpp

To: vpilo, #plasma, #plasma_workspaces
Cc: plasma-devel, davidedmundson, dfaure, broulik, graesslin, mck182, 
#frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D5012: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo added a dependency: D4799: Delay notifications until desktop session has 
loaded.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

To: vpilo
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5012: Delay notifications until desktop session has loaded

[Valerio Pilo]

vpilo created this revision.
vpilo added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Added program to wait for D-Bus Notifications services to register.
  
  Needed for Plasma to delay showing notifications until the desktop has fully 
loaded.
  
  Related change: https://phabricator.kde.org/D4799

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5012

AFFECTED FILES
  startkde/CMakeLists.txt
  startkde/waitforname/CMakeLists.txt
  startkde/waitforname/main.cpp
  startkde/waitforname/org.freedesktop.Notifications.service.in
  startkde/waitforname/waiter.cpp
  startkde/waitforname/waiter.h

To: vpilo
Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol