Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

[christoph]

On 2023-11-05 18:35, christ...@cullmann.io wrote:

On 2023-11-05 18:01, Nate Graham wrote:

On 11/5/23 07:42, Kevin Ottens wrote:
I was clumsily advocating for this Akademy 2021 or 2022 (can't 
remember

which).

This way it's clearer to application authors when they tie themselves 
to a

given workspace or not.

Also, isn't Elisa able to work without Baloo? It even seems to do the 
right
thing if I trust its CMakeLists.txt. It has Baloo as a recommended 
but

optional dependency, and disable it altogether for Win32 builds.


Yes, Elisa also includes an internal indexer, for use on Windows and 
Android, or on *Nix when Baloo isn't installed or is disabled.


I think the original idea for the app was to delegate all the indexing 
heavy lifting to Baloo to avoid internal complication, but clearly 
this has not worked out in practice, since to be truly cross-platform, 
it can't assume that Baloo is present and active and does need its own 
indexer. So maybe the best course of action is actually to remove 
Baloo support entirely and always use the internal indexer, so that we 
don't have two different code paths.


Hi,

sounds for me a lot easier to test with just one variant.
And one would always use the variant Windows uses.


Hi,

any more feedback about this?

Greetings
Christoph



Greetings
Christoph




Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

[christoph]

On 2023-11-05 18:01, Nate Graham wrote:

On 11/5/23 07:42, Kevin Ottens wrote:
I was clumsily advocating for this Akademy 2021 or 2022 (can't 
remember

which).

This way it's clearer to application authors when they tie themselves 
to a

given workspace or not.

Also, isn't Elisa able to work without Baloo? It even seems to do the 
right

thing if I trust its CMakeLists.txt. It has Baloo as a recommended but
optional dependency, and disable it altogether for Win32 builds.


Yes, Elisa also includes an internal indexer, for use on Windows and 
Android, or on *Nix when Baloo isn't installed or is disabled.


I think the original idea for the app was to delegate all the indexing 
heavy lifting to Baloo to avoid internal complication, but clearly this 
has not worked out in practice, since to be truly cross-platform, it 
can't assume that Baloo is present and active and does need its own 
indexer. So maybe the best course of action is actually to remove Baloo 
support entirely and always use the internal indexer, so that we don't 
have two different code paths.


Hi,

sounds for me a lot easier to test with just one variant.
And one would always use the variant Windows uses.

Greetings
Christoph




Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

[christoph]

On 2023-11-05 15:11, Nate Graham wrote:

On 11/5/23 07:09, christ...@cullmann.io wrote:

On 2023-11-05 12:59, Friedrich W. H. Kossebau wrote:

Hi,

with plasma-framework, kactivities and kactivities entering the 
Plasma product

bundle, I assume they also will adapt to Plasma versioning.


Hi,

if we are atm moving stuff, might it make sense to move Baloo, too, 
given it only

is usable with the daemon inside Plasma more or less, too?

Greetings
Christoph


Baloo is linked by some apps, e.g. Elisa, and I wouldn't like to make 
them haul in Plasma stuff.


Hi,

some applications link to kactivities, too.
I think it just makes it more clear that this will just work with 
Plasma.


But I can live with the status quo, too, just thought it would be 
cleaner.


Greetings
Christoph



Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

[christoph]

On 2023-11-05 12:59, Friedrich W. H. Kossebau wrote:

Hi,

with plasma-framework, kactivities and kactivities entering the Plasma 
product

bundle, I assume they also will adapt to Plasma versioning.


Hi,

if we are atm moving stuff, might it make sense to move Baloo, too, 
given it only

is usable with the daemon inside Plasma more or less, too?

Greetings
Christoph



Without any de-KF-ication though this will break things though for 
building

consumers soonish. Example

--- 8< ---
find_package(KF6 ${KF_MIN_VERSION} REQUIRED COMPONENTS
CoreAddons
Plasma
)
--- 8< ---

* KF6_VERSION will be set by FindKF6.cmake to min component version, so 
that

of KF6Plasma
* when setting KF_MIN_VERSION one will only think about KF versions, 
not

Plasma versions

Asking people to always know about that trap and remember to always 
only do

e.g.
--- 8< ---
find_package(KF6CoreAddons ${KF_MIN_VERSION} REQUIRED)
find_package(KF6Plasma ${PLASMA_MIN_VERSION} REQUIRED)
--- 8< ---
yields rather strange pattern code.

Or think of things like libcolorcorrect/LibColorCorrectConfig.cmake.in:

--- 8< ---
find_dependency(KF6Plasma "@KF6_MIN_VERSION@")
--- 8< ---

Looks fine on first sight, does it? Just, no longer is now.

So not best developer experience here.

Thus, to make it clear to everyone that those 3 libraries are now from 
another
product bundle, with own versioning and other own rules, please do not 
forget

to adapt
* naming: library names, CMake package names, CMake target names
* version variable setting (PLASMA_MIN_VERSION needed now in consumers)
* documentation: metainfo.yaml entries, references to KDE Frameworks

And yes, while at it some other Plasma bundle things might want to be 
unmessy

here as well, e.g. libkscreen :)

Cheers
Friedrich

Re: Frameworks / Plasma/ Gear Release Schedule Plan

[christoph]

On 2023-09-09 13:57, Luigi Toscano wrote:

Hi,

yes, good point.

Just a technical question: if we do this after that period, what is
the process to do it for an application belonging to Gear?

Will it just be sufficient e.g. for Kate to drop the Qt 5 variants 
in


https://invent.kde.org/utilities/kate/-/blob/master/.kde-ci.yml?ref_type=hea
ds

and

https://invent.kde.org/utilities/kate/-/blob/master/.gitlab-ci.yml?ref_type=
heads

and require KF 6 + Qt 6 in the CMake files or is there additional 
stuff

that
needs updates to avoids one breaks stuff?


My guess is what you are describing plus updating things in 
repo-metadata, i

can think of

dependencies/logical-module-structure
  to update the branch info (i.e. kf5-qt5 won't be master anymore, i 
guess

point it to the latest stable branch)

dependencies/dependency-data-kf6-qt6
  to update the dependency info
  But this is autogenerated by Nico scripts nowadays so... maybe not? 
or prod

him to run the script?

projects/*/*/i18n.json
  to update the i18n branch information

Anything else I am missing?


Hi,

Thanks for the additional pointers.

Given no one did seem to oppose so far, I would consider to switch 
Kate to Qt

6 in master next Wednesday and start the bit Qt 6 run :)


When you switch a branch to qt6, please remember to ping the 
translation team
because we need to move the translations. Probably the best way is to 
mention
the translation team in the merge request to sysadmin/repo-metadata.git 
which

updates the content of the i18n.json file.


Thanks for the hint.

Just to be sure, perhaps I missed the docs, what would be needed in

https://invent.kde.org/sysadmin/repo-metadata/-/blob/master/projects-invent/utilities/kate/i18n.json?ref_type=heads

Now we have:

{"trunk": "none", "stable": "none", "stable_kf5": "release/23.08", 
"trunk_kf5": "master"}


Would it be something like:

{"trunk": "master", "stable": "none", "stable_kf5": "release/23.08", 
"trunk_kf5": "none"}


Greetings
Christoph

Re: Frameworks / Plasma/ Gear Release Schedule Plan

[christoph]

On 2023-09-05 23:08, Albert Astals Cid wrote:

El dimarts, 5 de setembre de 2023, a les 22:42:13 (CEST),
christ...@cullmann.io va escriure:

On 2023-09-04 22:59, Albert Astals Cid wrote:
> El dilluns, 4 de setembre de 2023, a les 18:50:45 (CEST), David
> Edmundson va
>
> escriure:
>> Following on from the last Akademy we checked where we were with our
>> development progress in a meeting and settled on the following plan
>>
>> for all 3 major parts:
>>  - In KDE Gear master will be open for Qt6 code to land for those
>>
>> ready to move. Not all apps need to port.
>
> For the trigger happy among us...
>
> This is a plan/proposal, let's give people at least one week to
> comment/
> disagree on it before making master Qt6-only for Gear apps.

Hi,

yes, good point.

Just a technical question: if we do this after that period, what is
the process to do it for an application belonging to Gear?

Will it just be sufficient e.g. for Kate to drop the Qt 5 variants in

https://invent.kde.org/utilities/kate/-/blob/master/.kde-ci.yml?ref_type=hea
ds

and

https://invent.kde.org/utilities/kate/-/blob/master/.gitlab-ci.yml?ref_type=
heads

and require KF 6 + Qt 6 in the CMake files or is there additional 
stuff

that
needs updates to avoids one breaks stuff?


My guess is what you are describing plus updating things in 
repo-metadata, i

can think of

dependencies/logical-module-structure
  to update the branch info (i.e. kf5-qt5 won't be master anymore, i 
guess

point it to the latest stable branch)

dependencies/dependency-data-kf6-qt6
  to update the dependency info
  But this is autogenerated by Nico scripts nowadays so... maybe not? 
or prod

him to run the script?

projects/*/*/i18n.json
  to update the i18n branch information

Anything else I am missing?


Hi,

Thanks for the additional pointers.

Given no one did seem to oppose so far, I would consider to switch Kate 
to Qt 6 in master next Wednesday and start the bit Qt 6 run :)


(If nothing comes up here)

The everybody had a week to chime in.

Let's make our Qt 6 based 'bundled' release next year a good one ;)

Greetings
Christoph



Cheers,
  Albert



Greetings
Christoph

>>  - The KDE Gear release will move by 2 months to allow for the extra
>>
>> time needed for testing initial Qt6 changes
>>
>>  - An Alpha will be made in November  (a soft freeze in Plasma terms)
>>
>>  - Betas/RCs will be made throughout December and January (3 releases,
>>
>> 3 weeks apart)
>>
>>  - Final release of all 3 major parts in sync in February
>>
>> Due to the delay of KDE Gear by an additional patch release of 23.08
>> will be made.
>
> Or maybe even two if there's bugfixes flowing.
>
> Cheers,
>
>   Albert
>>
>> David Edmundson

Re: Frameworks / Plasma/ Gear Release Schedule Plan

[christoph]

On 2023-09-04 22:59, Albert Astals Cid wrote:
El dilluns, 4 de setembre de 2023, a les 18:50:45 (CEST), David 
Edmundson va

escriure:

Following on from the last Akademy we checked where we were with our
development progress in a meeting and settled on the following plan
for all 3 major parts:

 - In KDE Gear master will be open for Qt6 code to land for those
ready to move. Not all apps need to port.


For the trigger happy among us...

This is a plan/proposal, let's give people at least one week to 
comment/

disagree on it before making master Qt6-only for Gear apps.


Hi,

yes, good point.

Just a technical question: if we do this after that period, what is
the process to do it for an application belonging to Gear?

Will it just be sufficient e.g. for Kate to drop the Qt 5 variants in

https://invent.kde.org/utilities/kate/-/blob/master/.kde-ci.yml?ref_type=heads

and

https://invent.kde.org/utilities/kate/-/blob/master/.gitlab-ci.yml?ref_type=heads

and require KF 6 + Qt 6 in the CMake files or is there additional stuff 
that

needs updates to avoids one breaks stuff?

Greetings
Christoph






 - The KDE Gear release will move by 2 months to allow for the extra
time needed for testing initial Qt6 changes

 - An Alpha will be made in November  (a soft freeze in Plasma terms)

 - Betas/RCs will be made throughout December and January (3 releases,
3 weeks apart)

 - Final release of all 3 major parts in sync in February

Due to the delay of KDE Gear by an additional patch release of 23.08
will be made.


Or maybe even two if there's bugfixes flowing.

Cheers,
  Albert



David Edmundson

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=374311

--- Comment #14 from Christoph Feck  ---
Qt developers say it is fixed in Qt 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Alternate calendar in plasma - feature request discussion

[Christoph Feck]

On 12/08/20 16:23, Wang Gary wrote:

An alternate calendar is a feature to allow another calendar system's date
name display together with the main calendar's date names.


Is the calendaring system needed for China supported in Qt? Please see
https://doc.qt.io/qt-5/qcalendar.html#System-enum

This class is new as of Qt 5.14, so we couldn't depend on it yet.
If the Chinese calendar support needs to be added in Qt, I suggest to
contact developers at the Qt development mailing list.

BG,
Christoph

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=374311

Christoph Feck  changed:

   What|Removed |Added

 CC||krzmb...@gmail.com

--- Comment #12 from Christoph Feck  ---
*** Bug 430014 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Plasma and a bachelor thesis

[Christoph Feck]

On 10/16/20 15:26, Ilya Bizyaev wrote:

I've had a wild idea of doing a KDE-related engineering project


Thank you for your interest in helping the KDE community!

If you exclude anything reported to bugs.kde.org (which does not only 
list bugs, but also has ideas for new features), you could also use 
these for inspirations:


- Brainstorm in KDE Forums: https://forum.kde.org/viewforum.php?f=83

- 
https://itvision.altervista.org/why.linux.is.not.ready.for.the.desktop.current.html


On a more personal note, see https://bugs.kde.org/show_bug.cgi?id=252353

BG,
Christoph

[ksysguard] [Bug 424128] libksysguard "make install" fails with ./kdesrc-build

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=424128

Christoph Feck  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #1 from Christoph Feck  ---
Install as root. The kauth helpers need to be found be the kauth framework, and
it expects these at /usr/libexec/kf5/kauth on your system.

If you want them in a different location, you will have to change
KAUTH_HELPER_INSTALL_DIR, but not only for libksysguard, but your complete
system.

See https://techbase.kde.org/Development/Tutorials/KAuth/Helper_HowTo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=374311

Christoph Feck  changed:

   What|Removed |Added

 CC||oceanodefol...@pm.me

--- Comment #8 from Christoph Feck  ---
*** Bug 42 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D29081: [QStyle] Make menu titles look less like menu items

[Christoph Feck]

cfeck added a comment.


  Instead of darker, you could use the text color with very small alpha.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Christoph Feck]

cfeck added a comment.


  What a small difference that makes such a large difference!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28941: startplasma: Sort environment scripts prior to sourcing

[Christoph Feck]

cfeck added a comment.


  It looks like the submitter doesn't have commit rights.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28941

To: auxym, #plasma, davidedmundson, apol
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

[Christoph Feck]

cfeck added a comment.


  Anyone else able to review this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Christoph Feck]

cfeck added a comment.


  See https://bugreports.qt.io/browse/QTBUG-56547

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Christoph Feck]

cfeck added a comment.


  We already lost fractional point sizes when porting from KFontDialog to 
QFontDialog. Best approach is to add the KFontDialog to the platform plugin 
(and also the old KColorDialog while you are at it), or upstream our features 
to Qt.
  
  Btw, I set Toolbar font to a "condensed" version, to have more horizontal 
room for toolbars with text aside icons.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27650: ItemContainer: disconnect signals in destructor

[Christoph Feck]

cfeck added a comment.


  If this is still needed, please commit and clarify the status of the 
referenced bug.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27650

To: alnikiforov, ngraham, davidedmundson, mart
Cc: cfeck, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Re: breeze-gtk now in invent

[Christoph Feck]

On 02/25/20 13:50, Jonathan Riddell wrote:

breeze-gtk seems to have moved to invent for development.

Looking through the list on invent I don't see any other Plasma projects
there.

That's cool but it's useful to know when and why moves like this happens as
it needs changes to my release scrips and others will get a surprise when
they want to make contributions to it.


We have https://phabricator.kde.org/T11994 to track those moves, please 
subscribe there.


--
Christoph Feck
KDE Release Team

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2c832dbdd087: Fix duplicate results for sessions, 
simplify and optimize (authored by alex, committed by cullmann).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27109?vs=74875&id=75775

REVISION DETAIL
  https://phabricator.kde.org/D27109

AFFECTED FILES
  runners/katesessions/CMakeLists.txt
  runners/katesessions/katesessions.cpp
  runners/katesessions/katesessions.h

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Christoph Feck]

cfeck added a comment.


  So... is this all related to bug https://bugs.kde.org/show_bug.cgi?id=378523 ?
  :/

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27383: fix: reset doctor output color before exiting

[Christoph Feck]

cfeck added a comment.


  Since this patch isn't critical, it would make a perfect candidate for your 
first steps with committing :)

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27383

To: z3ntu, davidedmundson
Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27383: fix: reset doctor output color before exiting

[Christoph Feck]

cfeck added a comment.


  Oh, okey. That was just misleading.
  
  I also suggest to ask for commit rights then.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27383

To: z3ntu, davidedmundson
Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27383: fix: reset doctor output color before exiting

[Christoph Feck]

cfeck added a comment.


  According to 
https://phabricator.kde.org/R982:8dffcc64d2aec4041129d67809839f136fec080a you 
have commit rights?

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27383

To: z3ntu, davidedmundson
Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

[Christoph Feck]

cfeck added a comment.


  That looks clever. Since CpuInfoBufSize is a static variable, it will 
remember the last used size and not reallocate again (unless you plug in new 
CPUs).
  
  Is realloc() an option? It should help the case where the library can 
actually grow the buffer without an alloc/copy/free cycle.

REVISION DETAIL
  https://phabricator.kde.org/D27362

To: jakobkummerow, davidedmundson, ahiemstra
Cc: ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

[Christoph Feck]

cfeck added a comment.


  From that bug report:
  
  Newer x86_64 kernels, however, allow up to 4096 CPUs, so either the buffer 
needs to be much bigger, or we should do interleaved /proc/cpuinfo reading and 
parsing.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D27362

To: jakobkummerow, davidedmundson
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Christoph Feck]

On 02/13/20 08:42, Ben Cooksley wrote:

Part of the issue here is that Plasma has been known to add API to
Frameworks and then immediately, without any delay, start using it
(pretty much always breaking CI in the process)

This means that other changes are likely being pushed into Frameworks
by Plasma with very little delay as well.

Consequently this means stuff is landing in Framework repositories up
to the very moment it is released - a release that the next version of
Plasma (LTS) then depends on.

A better way of approaching this would be to freeze the Frameworks
version you are going to require API wise at an earlier point in the
Plasma development cycle. This would allow for a full Frameworks
release cycle to pass where bugs encountered during the lead up to the
Plasma release can be fixed.


You can find bugs in new code best if you are actually using it. I doubt 
that delaying using new API would help much.

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann added a comment.


  Upsa ;) missed that this is in plasma addons, not in the session launcher 
applet we have in our repo, ignore my comment about the invent stuff ;=)

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann added a comment.


  Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, 
but I will just apply this via arc.

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27109: Fix duplicate results for sessions, simplify and optimize

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Improved output seems fine for me, thanks for taking care.

REPOSITORY
  R114 Plasma Addons

BRANCH
  katesession_improvements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27109

To: alex, broulik, davidedmundson, ngraham, #plasma, #kate, cullmann
Cc: cullmann, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

[Christoph Feck]

cfeck added a comment.


  But the timeout isn't used to give apps more time needed to clean up before 
they confirm the session can be closed? If I understand it correctly, there 
should be two timeouts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

[Christoph Feck]

cfeck added a comment.


  Why is there a timeout at all?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> standard_actions_module.cpp:73
> +m_editor->setMinimumWidth(700);
> +m_editor->setMinimumHeight(600);
> +

`setMinimumSize()`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Christoph Feck]

cfeck added a comment.


  Note that a window's minimum size does not include decorations or the panel. 
I suggest to subtract 60 pixels from the minimum height, otherwise on a 800x600 
screen the buttons are likely hidden behind the panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24706: [RFC] Change button style

[Christoph Feck]

cfeck added a comment.


  If application developers need a rotated button, they need to rotate only the 
contents, not the frame.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, 
manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D26271: [Applet]Update layout based on T10470

[Christoph Feck]

cfeck added a comment.


  The radio stream I use (via mpv) shows the interpret and title information 
for all titles it plays. Also, when mpv plays a local file, ttitle information 
about the file is added there. I don't use any other media streams, so I cannot 
comment on the general availability of this additional stream information.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=369158

Christoph Feck  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #8 from Christoph Feck  ---
Thanks for the updates; changing status. If you see this issue again, please
add a comment or reopen the ticket.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=375909

Christoph Feck  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #7 from Christoph Feck  ---
Thanks for the update; changing status.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25280: [Baloo KCM] Purge index when disabling indexing

[Christoph Feck]

cfeck added a comment.


  Shouldn't there be a warning message "delete yes/no?"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25280

To: ngraham, tcanabrava, #plasma, davidedmundson
Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 6.25% on X11

[Christoph Cullmann]

cullmann added a comment.


  On Wayland one seems to always scale up to the next full factor (e.g. 2) and 
then scale down the rendered stuff via gl to the selected factor (e.g 1.5).
  
  That leads to other issues but doesn't let rounding stuff creep into the 
rendering via Qt.
  
  For non IEEE stuff: perhaps that will be available in the future, but at the 
moment all really available RISC-V ISAs provide just IEEE, too.
  And staying in some 1/(2^x) range won't hurt any alternative approach I 
assume.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg, mart
Cc: MayeulC, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24283: Add clang format file

[Christoph Cullmann]

cullmann added a comment.


  There will anyways be one "big" change in the history, but normally git will 
be able to handle that well by ignoring space changes for blame or diff.
  I don't think without the aligning the change will be much smaller.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24283

To: davidedmundson
Cc: zzag, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24283: Add clang format file

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> zzag wrote in .clang-format:83
> s/coding/coding style/

Fixed that in D24568 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24283

To: davidedmundson
Cc: zzag, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24283: Add clang format file

[Christoph Cullmann]

cullmann added a comment.


  This is just a base file for discussion.
  Stuff like the mentioned case indentation can be adjusted to be frameworks 
conform.
  For the alignment of comments, I am not sure, it makes the stuff a lot more 
readable in many cases and after the initial re-format you don't have a lot of 
jitter normally.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24283

To: davidedmundson
Cc: zzag, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24283: Add clang format file

[Christoph Cullmann]

cullmann added a comment.


  See D24568  for the draft of an ECM 
module that applies the Kate/KTextEditor/Artikulate style.
  Is the same file as here, with sorting of includes, but with column limit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24283

To: davidedmundson
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21860: Set a font for gtk applications in the fonts kcm

[Christoph Feck]

cfeck added a comment.


  Please make any GTK stuff optional, not required.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: cfeck, davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, ahiemstra, mart

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

[Christoph Cullmann]

cullmann added a comment.


  I would just reformulate
  
  "Scale factors are limited to multiples of 6.25% on X11 to minimize visual 
glitches in applications."
  
  to
  
  "Scale factors are limited to multiples of 6.25% to minimize visual glitches 
in applications."
  
  I think adding X11 only makes this harder to understand for the users.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24373

To: ngraham, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok ,works for me, too. Sorry for the noise! And thanks for the explanation!
  I think this is already much better than before, the details of the last 
finesse with the minimal step can be discussed elsewhere.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok, that explains why all my tries fail...
  I thought the hint above about looking for kcm_screen in the system was just 
if I have mixed up some stuff, but I always thought if the QT_PLUGIN_PATH is 
properly set like with prefix.sh the local plugins will be prefered.
  Will try at home.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok, but given I have a system wide installed kcm anyways, from the distro, is 
there a way to use the own I have in my user local prefix?
  That explains why I am too dumb to try the fractional scaling on Wayland with 
my installed master version, too.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Or I am maximal confused ;=)
  
  If I compile a master kscreen, have sourced the prefix.sh, shall I see the 
correct stuff in e.g. the kcm_testapp in bin of the kscreen build dir?
  
  If not, I am sorry, could somebody help me out how to test this properly?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Besides, I think you missed half of the code, as for me, I still get a 
different widget here, as for my setup the OutputPanel.qml is used, not 
Panel.qml.
  
  (as I have two displays that can be configured separately)
  
  Could you fix that, independent of the 0.05.. issue?
  I agree that we can do an extra patch for that.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  I don't get why we want to introduce artifacts we can very simple avoid by 
using a different base for the steps.
  Is 0.0625 really that much worse than 0.05?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  To illustrate that, just try, with master of KTextEditor:
  
  export QT_SCALE_FACTOR=1.125
  
  kwrite with some file => select 100 lines, zoom font in and out => I get no 
artifacts
  
  export QT_SCALE_FACTOR=1.0625
  
  > same
  ==
  
  export QT_SCALE_FACTOR=1.1
  
  > artifacts each X lines
  

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  Hmm, could we perhaps adjust the minimal step to 0,0625.
  That is 1/16 and with that, I never get any artifacts with KWrite in current 
master, as it nicely sums up.
  Then you don't need to round at all for output.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

[Christoph Cullmann]

cullmann added a comment.


  I like that UI, too.
  For Wayland: Can somebody tell me how I can try there some fractional scaling?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg, ndavis
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Even with my hacks for https://bugreports.qt.io/browse/QTBUG-66036 in current 
KTextEditor master (see https://bugs.kde.org/show_bug.cgi?id=390451) you will 
still get after every xx lines some stray artifact in some cases during 
selection if you have some 1.1 scaling.
  That still seems to be a remaining issue with selection painting. Not 
happening with proper scaling of 1.25 or 1.5 as nothing adds up multiplication.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: dhaumann, davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok, I wasted one evening on the rendering artifacts stuff.
  
  https://bugreports.qt.io/browse/QTBUG-66036
  
  I have now ugly workarounds in KTextEditor:
  
  1. no anti-aliasing, else fillRect misses to fill 1 pixel at the borders by 
rounding errors
  2. adjust the clip rect by one logical pixel to not miss 1 real device pixel 
sometimes

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  I got some more insight into https://bugreports.qt.io/browse/QTBUG-66036
  If one turns off anti-aliasing, in KTextEditor most of the evil artifacts 
disappear, but not all.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  I will investigate the https://bugreports.qt.io/browse/QTBUG-66036 bug again, 
too :/
  Even with the rounding issues one gets over larger multiplications, it 
shouldn't be that buggy for short ones.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Ok, tried Wayland now on my HiDPI setup.
  In Plasma's KCM I only have Scale 1x or 2x and that works ok, as one would 
think.
  But I see no way to set any more fine-grained scale to check if the scaling 
is nice for other values.
  The slider is for me only there for X11.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540437 , @romangg wrote:
  
  > In D24321#540433 , @cullmann 
wrote:
  >
  > > ;=) I talked only about the Qt HiDPI scaling code paths.
  >
  >
  > In this case I recommend studying the bug report I linked. There is also a 
patch attempt in Qt but it got closed for some reason.
  
  
  You can't patch that issues in Qt if e.g. your application relies on facts 
like you paint 10 lines and you don't get some rounding errors all the time ;)
  
  > 
  > 
  >> For any other scaling I don't care, as that should be application 
transparent, like you say.
  >>  But if Wayland really just scales up the stuff via GL fonts will look 
terrible.
  > 
  > They are scaled down via Gl to match the fractional part of the scaling 
value. Applications provide pre-scaled buffers of integer factors 2, 3, 4 and 
so on.
  
  Hmm, but that means you still set QT_SCALE_ to some non-fractional thing 
like 2, 3, 4 and the only fine adjust, that makes sense.
  Thought for me it did look like the small scale window was up-scaled in my 
try with the 2x combobox field.
  
  > 
  > 
  >> And no, its non-trivial to fix there any artifacts for strange scales and 
it makes there computation wise a very large different if the scale factor is 
1.2 or 1.25, as the later is something you can sanely compute things with ;)
  >>  Therefore I really would like to have only some larger scaling steps set 
for the QT_SCALE_FACTOR... stuff and for the smaller things just some font 
adjustments.
  > 
  > Don't see a reason for that. Never heard about necessity in Gl to only 
calculate with certain floating values for best image quality. But if you can 
provide some source for that I would be interested in studying that. Can't say 
I see problems here in a Wayland session though, currently using a scaling 
factor of 1.8.
  
  The issue is that you transform individual elements.
  
  e.g. if you have some list of X graphical elements with height "virtual" 
pixel 10. If you scale them by 1.1, you get not "real pixel" 11, you get some 
11.00100101010 something. If you later compute things like "10 * element size", 
you not get 110 pixel but again some weired stuff ;=)
  
  
https://www.exploringbinary.com/why-0-point-1-does-not-exist-in-floating-point/
  
  If you apply that as transform on the full texture, I can agree that it 
shouldn't be a real issue.
  But if it is applied as QT_SCALE... you will have the issue of rounding 
artifacts for the individual widgets/layout members that then sum up in weired 
ways. 
  You get already some artifacts with 1/2 or 1/4, but at least you can multiply 
that sanely (as long as your floating point numbers don't get enourmous).

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Hmm, I just tried here a Wayland session, and yes, the KCM has there just 
some 1x/2x combobox and my fonts are maximal ugly compared to some export 
QT_SCALE_FACTOR=2 + starting a Qt application (on Wayland).
  But I must try that at home on real HiDPI screens, perhaps my test is 
suboptimal here.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  ;=) I talked only about the Qt HiDPI scaling code paths.
  
  For any other scaling I don't care, as that should be application 
transparent, like you say.
  But if Wayland really just scales up the stuff via GL fonts will look 
terrible.
  
  And no, its non-trivial to fix there any artifacts for strange scales and it 
makes there computation wise a very large different if the scale factor is 1.2 
or 1.25, as the later is something you can sanely compute things with ;)
  Therefore I really would like to have only some larger scaling steps set for 
the QT_SCALE_FACTOR... stuff and for the smaller things just some font 
adjustments.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540218 , @davidedmundson 
wrote:
  
  > >   For small 0.1 changes: Just change your font size, we did that always 
for the old non-hidpi world were displays did differ a bit in the DPI, that 
works without any glitches
  >
  > I even used to do this in the new high DPI world. Before Qt had fractional 
scaling we had the slider it would adjust the font size until you reached 1.75 
then it would change the Qt scale too. It worked fine.
  
  
  Perhaps such a mixed approach might even make more sense.
  
  As said, any scaling like 1.2 will not work with most of our applications, 
see above Konsole.
  
  With "a lot" of work, stuff like 1.25 or 1.5 will work like in KTextEditor by 
adjusting the fonts internally a bit to avoid sub-pixel jitter per line.
  
  I think we shall really avoid to expose bad scale factors to users.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540056 , @davidedmundson 
wrote:
  
  > > it would go into Plasma 5.17. :)
  >
  > There's still a feature freeze.
  
  
  At least moving away from 0.1 increases is actually a bugfix. Look at my 
konsole screenshot, similar artifacts can be created with most of our 
applications.
  (sadly still with 0.25/0.5, too, but at least not that often and you then can 
try to fix that by choosing some better font...)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Hi, I thought about this a bit more ;)
  
  I really think we shall limit the minimal increase to 0.25, without any 
advanced field. Perhaps the range should be larger, like 1-4, if some people 
get "really" high DPI screens.
  
  Rational:
  
  1. For small 0.1 changes: Just change your font size, we did that always for 
the old non-hidpi world were displays did differ a bit in the DPI, that works 
without any glitches
  
  2. Anything below 0.25 will just break half of our applications. For 
KTextEditor I did some hack in master that might avoid artifacts if you only 
scale with stuff like .25 or .5, it will still break with small stuff and most 
of our applications look horrible with small scalings, look at attached 
screenshot fo 1.1, do we really want to advertise that?
  
  F7481758: screenshot.png 
  
  Qt 5.14 will even have "opt-out" of fractional scaling and perhaps we even 
need to do that for some applications...

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: davidedmundson, ouwerkerk, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  Btw., I think GNOME is more clever than us, too, they allow just sane 
scalings in the UI:
  
  https://www.omgubuntu.co.uk/2019/06/enable-fractional-scaling-ubuntu-19-04

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  And the custom scale factor dialog really should have some warning text like 
on Windows ;=)
  
  see e.g.
  
  
https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html
  
  (custom scale factor not recommended)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: KonqiDragon, GB_2, ndavis, cullmann, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  In D24321#540014 , @ngraham wrote:
  
  > In D24321#540011 , @cullmann 
wrote:
  >
  > > 0.05 is no good idea either ;)
  > >  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  > >  If we really need something finer than 0.25, could we stick with 1/8 or 
1/16?
  >
  >
  > I don't want to lock people out of the finer scale factor numbers. 
Depending on your screen DPI and size, you may want to set and be quite happy 
with a weird scale factor like 1.65x. The idea here is to expose the more 
common and bug-free scale factors in the main UI, while letting experts and 
risk-takers set whatever they want. Maybe I should add a warning in the dialog 
that people who set a weird value there are on their own?
  
  
  That is fine, but please use some step width that is a proper float.
  Just use 1/16, that is 0,0625.
  0.05 will just lead to the same issues as 0.1, it looks nice in the input 
field but is no floating pointer number you can calculate sanely with.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: GB_2, ndavis, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

[Christoph Cullmann]

cullmann added a comment.


  0.05 is no good idea either ;)
  Just like 0.1 that is no 1/2, 1/4, 1/8, ...
  If we really need something finer than 0.25, could we stick with 1/8 or 1/16?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24321

To: ngraham, #vdg, #plasma, romangg
Cc: cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: New Plasma Desktop website

[Christoph Feck]

On 09/14/19 14:38, Carl Schwan wrote:

I finalized the first version of the new plasma-desktop webpage, a preview is 
available at https://kde.carlschwan.eu/plasma-desktop. There are still two 
parts missing (p-b-i and privacy) and some possible improvement that I would 
like to add later. Can I get approval from the Plasma team to land the current 
state?


Nice work! I would remove the first two images, since they don't show 
anything that isn't already shown in the first Laptop screenshot. They 
basically only show the Ice wallpaper.

Re: Plasma 5.12.9 LTS

[Christoph Feck]

On 09/11/19 19:35, Rik Mills wrote:

On 10/09/2019 17:21, Jonathan Riddell wrote:

Plasma 5.12.9 LTS
is now released https://www.kde.org/announcements/plasma-5.12.9.php


Kwin to fails to build with Qt 5.9.

Plasma 5.12 should build with 5.9.

 /effects/screenshot/screenshot.cpp:110:15: error: ‘const class QImage’
has no member named ‘sizeInBytes’

but from qt.io

qsizetype QImage::sizeInBytes() const
Returns the image data size in bytes.
This function was introduced in Qt 5.10.

Commit introducing that is 67444e36592e78d46b757a6c72be1d50bdae19e6
[effects/screenshot] Upload data to xpixmap in chunks


sizeInBytes() can be emulated with bytesPerLine() * height().

Would it be possible to adopt the convention "tars are announced a few 
days before the tag/release" used by Frameworks and Applications also 
for the Plasma packages?


This could help to avoid re-tagging in case of compilation errors.

--
Christoph Feck
KDE Release Team

D23803: [Folder View] Add subtle shadows to icons

[Christoph Feck]

cfeck added a comment.


  Isn't Qt Quick amazing?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

To: ngraham, hein, #plasma, #vdg, filipf, ndavis
Cc: cfeck, ndavis, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23732: [kded] Support fractional output scale

[Christoph Feck]

cfeck added a comment.


  I believe 1.25 is a common scale factor. Is something else in the stack 
limited to one digit?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23732

To: romangg, #plasma
Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

[Christoph Feck]

cfeck added a comment.


  Could someone test this on Wayland? The fix itself looks trivial, but if it 
breaks Wayland session, it obviously needs to be changed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18920: Fix PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:8056039c7947: Fix PCI module (authored by konradr, 
committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18920?vs=61562&id=62955

REVISION DETAIL
  https://phabricator.kde.org/D18920

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22369: Update and add some device names in PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:ed789f56fc69: Update and add some device names in PCI 
module (authored by konradr, committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22369?vs=61498&id=62954

REVISION DETAIL
  https://phabricator.kde.org/D22369

AFFECTED FILES
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=374311

Christoph Feck  changed:

   What|Removed |Added

 CC||marklikesvideogames@gmail.c
   ||om

--- Comment #5 from Christoph Feck  ---
*** Bug 410236 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D22728: Provide a link to KInfoCenter

[Christoph Feck]

cfeck added a comment.


  +1 for putting it in the Help menu.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Christoph Feck]

cfeck added a comment.


  Do we need a matching commit in KWidgetsAddons? See 
https://commits.kde.org/kwidgetsaddons/2631be903f947872f67c9e2063950345dda9033e

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: cfeck, filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22630: Slow down the busy indicator's rotation speed

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Jup, looks less iritating.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  slower-busy-indicator

REVISION DETAIL
  https://phabricator.kde.org/D22630

To: ngraham, #vdg, filipf, cullmann
Cc: filipf, plasma-devel, cullmann, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Christoph Cullmann]

cullmann added a comment.


  Thanks!

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd, #frameworks, dfaure
Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Christoph Feck]

cfeck added a comment.


  Oh, if the latter syntax also works, then you are right.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd
Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

[Christoph Feck]

cfeck added a comment.


  Could we only apply the `:xx` check on the filename part, not on the server 
part? Someone might expect that `http://path.to/file.txt:99` also works for 
remote files.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D22525

To: arrowd
Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22368: Formatting cleanup in PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:196d4aaa9cf6: Formatting cleanup in PCI module (authored 
by konradr, committed by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22368?vs=61497&id=61533

REVISION DETAIL
  https://phabricator.kde.org/D22368

AFFECTED FILES
  Modules/pci/kpci.cpp
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18920: Fix PCI module

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kpci_private.h:48
>  
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are

structure or structures?

> kpci_private.h:49
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are
> +   more widely adopted, and should be ignored if not supported.

seems to

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22367: Update mail address in PCI module

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:96c18ee3cf63: Update Konrad's mail address in PCI 
module (authored by cfeck).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22367?vs=61496&id=61531

REVISION DETAIL
  https://phabricator.kde.org/D22367

AFFECTED FILES
  Modules/pci/kpci.cpp
  Modules/pci/kpci.h
  Modules/pci/kpci_private.h

To: konradr, #plasma, cfeck, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D18245: Create QApplication in a scope to work around possible deadlock

[Christoph Roick]

croick abandoned this revision.
croick added a comment.


  I can no longer reproduce the deadlock, so I'll abandon this.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18245

To: croick, sitter, #kdevelop
Cc: dfaure, thiago, ossi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick added a comment.


  Thanks for your review. It was the last in a series of patches and I'll try 
to advertise the whole "Debug your KDE application with KDevelop"-feature 
somewhere.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:95b6b8b613c2: Show debug button when KDevelop session is 
running (authored by croick).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11234?vs=61377&id=61456

REVISION DETAIL
  https://phabricator.kde.org/D11234

AFFECTED FILES
  src/drkonqidialog.cpp
  src/drkonqidialog.h

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick marked 2 inline comments as done.
croick added a comment.


  In D11234#492200 , @sitter wrote:
  
  > Could you explain your thinking behind the adjustSize call please? The way 
I see it the window should scale up as necessary if the size hints are properly 
set (which they should be on master).
  
  
  That's true, but only since your latest commits. Before, the text of the 
report button was cut off (in german for example) once the debug button got 
activated. I removed the call again.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Christoph Roick]

croick updated this revision to Diff 61377.
croick added a comment.


  - more style fixes
  - do not adjustSize after adding the button, since that is redundant now

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11234?vs=59627&id=61377

BRANCH
  nicebutton

REVISION DETAIL
  https://phabricator.kde.org/D11234

AFFECTED FILES
  src/drkonqidialog.cpp
  src/drkonqidialog.h

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22252: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:d2a1d1ca9e9e: [KDEPlatformSystemTrayIcon] Set 
KStatusNotifierItem to Active (authored by cfeck).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22252?vs=61102&id=61246

REVISION DETAIL
  https://phabricator.kde.org/D22252

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: cfeck, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22252: [KDEPlatformSystemTrayIcon] Set KStatusNotifierItem to Active

[Christoph Feck]

cfeck created this revision.
cfeck added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cfeck requested review of this revision.

REVISION SUMMARY
  Qt applications expect that QSystemTrayIcon's default behavior is to show the 
icon.
  
  BUG: 407963

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D22252

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp

To: cfeck, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Christoph Feck]

cfeck added a comment.


  See also bug 403953 and bug 408863.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: cfeck, GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D18920: Fix and update PCI module

[Christoph Feck]

cfeck added a comment.


  Would it be possible to commit the whitespace changes separately? They hide 
all the actual changes.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19855: Fix bugzilla login page widgets tab order

[Christoph Feck]

cfeck added a comment.


  Is this fixed by https://phabricator.kde.org/D21894 ?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D19855

To: marcelomariano, sitter, cfeck, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: KInit - Current state and benchmarks

[Christoph Cullmann]

Hi,

On 2019-06-17 11:56, David Edmundson wrote:

From API.kde.org:
Using kdeinit to launch KDE applications makes starting a typical KDE 
applications 2.5 times faster (100ms instead of 250ms on a P-III 500)


Certainly sounds like a good thing.

===The current State===

==Plasma==
* Apps launched from the plasma menu skip klauncher and therefore
kinit. This was done due to the API for KRun blocking somewhere
(Though I don't remember details)

This seems like something easily fixable if we tried.

* Processes launched on bootup (with the exception of kcminit,
ksmserver and kded5) skip kinit. This was due to a deadlock in
klauncher and ksmserver at the time when apps autostart moved from
frameworks.

This deadlock is since resolved in my ksmserver splitting branches.

* But Plasma apps launched from the desktop do go through klauncher
(and therefore kinit)! So we're not even consistent.

==Apps==
* The number of applications linking kinit properly under KF5 is in an
equally sorry state.
Dolphin does, but even core applications like Okular and Kate don't.
I stopped using it I guess to be consistent between all platforms 
shipping Kate.
(beside, if you profile the Kate startup, all things are >>>>> the stuff 
kdeinit saves)




See
$ find -name 'CMakeLists.txt' -print0 | xargs -0 grep
'kf5_add_kdeinit_executable'
for a local list.

* It's also incompatible with flatpak/snaps/appimage, which is a rising 
trend


==Other==
Kinit is still also used for spawning KIO slaves.

===Is it still useful?===
We're not using it properly and we need to do something. Either fix it
or start to phase it out officially.

Since the time of writing kinit Qt has changed a lot. linking has
changed a bit. CPUs have changed a lot and Hard Disks have changed a
lot.

So I wrote a benchmark tool to see if the initial speed boost claim is
relevant: kde:scratch/davidedmundson/inittimer

My test does the following:
 - creates a dummy (headless) wayland server
 - spawns an app using either QProcess or sending a DBus message to 
KLauncher

 - times how long it takes for the first window to appear, timing the
more important real world metric and one that includes all the
factors.

Results:
(Showing the median out of 5 runs on a mid range SSD desktop)

Dolphin QProcess: 348
Dolphin Kinit: 332

KCalc   QProcess:  242
KCalc   KInit: 232

Plasmoidviewer (patched) QProces: 622
Plasmoidviewer (patched) KInit: 591

KWrite  QProcess: 391
KWrite  Kinit: 390
(unsurprisingly similar as kwrite does not have a kdeinit exec, I
included it as it shows the others aren't false positives)

===What about memory?===

Good question. It needs a similar investigation by someone who
understands memory...

===Conclusion===

My test implies there /is/ a genuine saving with kinit !
However it's far from the claimed 2.5 times faster, it is less than
1.1 times faster. Saving up to 30ms.


my opinion: it's not worh the hassle.

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org