[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
graesslin added a comment. In https://phabricator.kde.org/D3829#73066, @xuetianweng wrote: > In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > > > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB connection and event handling. > > > At that time the xinput in xcb is incomplete and buggy so XLib is the only choice. Not sure if things change now. no, it never was buggy. There are just no bindings. But all we care about are the events. And events are just a struct. If one wants to use them one can. An example how one can use XInput from an xcb based application without needing the bindings is https://cgit.kde.org/kwin.git/tree/plugins/platforms/x11/standalone/xinputintegration.cpp REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB connection and event handling. At that time the xinput in xcb is incomplete and buggy so XLib is the only choice. Not sure if things change now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
graesslin added a comment. I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB connection and event handling. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#71988, @graesslin wrote: > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote: > > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > > > > > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel > > > > > > I don't really sure about this. So basically XlibNotifications uses XISelectEvent to monitor certain event. And strangely, the event is not received only if it is triggered by global hotkey. > > > Which "event"? search XIPropertyEvent in xlibnotifications.cpp For whatever reason, that part of code is not reached if it is triggered by global hotkey with current code, the display pointer is not shared with anyone.. I really don't understand why adding a new one helps, but it does help. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
graesslin added a comment. In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote: > In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > > > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel > > > I don't really sure about this. So basically XlibNotifications uses XISelectEvent to monitor certain event. And strangely, the event is not received only if it is triggered by global hotkey. Which "event"? > The Display* used in touchpad kded is already a separated one instead of Qt's, so I don't know if there's any interference between them. If someone could highlight me about what is the real cause of this I'd appreciated it. This sounds weird and wrong to me. In none of the applications we use, even in the heavily X relying one like KWin or kglobalaccel, we create another Display, but use the one Qt provides. From my experience there is no need to have a dedicate Display. It can certainly be a source for issues. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#71724, @knambiar wrote: > Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to confirm it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
xuetianweng added a comment. In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel I don't really sure about this. So basically XlibNotifications uses XISelectEvent to monitor certain event. And strangely, the event is not received only if it is triggered by global hotkey. The Display* used in touchpad kded is already a separated one instead of Qt's, so I don't know if there's any interference between them. If someone could highlight me about what is the real cause of this I'd appreciated it. My guess is that it could be caused by mix Xinput call on the same display and there's some interference. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
knambiar added a comment. Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.
graesslin added a comment. Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, davidedmundson Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
