[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread mart (Marco Martin) 
mart added a comment.


  hmm, also wouldn't be loaded if a kde app is loaded from another 
desktopwithout config prior existing i guess

INLINE COMMENTS

> colorscm.cpp:118
>  const QString name = group.readEntry("Name", info.baseName());
> -QListWidgetItem * newItem = new QListWidgetItem(icon, name);
> -// stash the file basename for use later
> -newItem->setData(Qt::UserRole, info.baseName());
> -schemeList->addItem(newItem);
> +if (name == "Default") {
> +defaultItem = new QListWidgetItem(icon, name);

is this name localized?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3048

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, broulik, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread ochurlaud (Olivier Churlaud) 
ochurlaud added reviewers: Plasma, mart, broulik.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3048

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas