D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
broulik added inline comments. INLINE COMMENTS > main.qml:56 > +tasksModel.requestToggleMinimized(idx); > +clients.push(tasksModel.makePersistentModelIndex(i)); > +} This method does not exist, did you forget to commit the plasma-workspace part? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma, anthonyfieroni Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
This revision was automatically updated to reflect the committed changes. Closed by commit R114:c8c734fabe47: Port minimize all applet from its own plugin to org.kde.TaskManager (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10019?vs=27364=27526 REVISION DETAIL https://phabricator.kde.org/D10019 AFFECTED FILES applets/minimizeall/CMakeLists.txt applets/minimizeall/package/contents/ui/main.qml applets/minimizeall/plugin/minimizeall.cpp applets/minimizeall/plugin/minimizeall.h applets/minimizeall/plugin/minimizeallplugin.cpp applets/minimizeall/plugin/minimizeallplugin.h applets/minimizeall/plugin/qmldir To: davidedmundson, #plasma, anthonyfieroni Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. It looks good to me. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma, anthonyfieroni Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
davidedmundson updated this revision to Diff 27364. davidedmundson added a comment. Track window changes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10019?vs=25753=27364 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019 AFFECTED FILES applets/minimizeall/CMakeLists.txt applets/minimizeall/package/contents/ui/main.qml applets/minimizeall/plugin/minimizeall.cpp applets/minimizeall/plugin/minimizeall.h applets/minimizeall/plugin/minimizeallplugin.cpp applets/minimizeall/plugin/minimizeallplugin.h applets/minimizeall/plugin/qmldir To: davidedmundson, #plasma Cc: ngraham, anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
davidedmundson planned changes to this revision. davidedmundson added a comment. Good point. Will revisit. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma Cc: anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
anthonyfieroni added a comment. Thats what doubt me: https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/minimizeall/plugin/minimizeall.cpp;65fc80441388c5f3e70832c40e1d7afea6778e83$63-68 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma Cc: anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
sebas added a comment. I like, getting rid of C++ code is always welcome. Once the patch to libtaskmanager is in and kbroulik's comments addressed, +2 from my side. Thanks! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma Cc: sebas, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
broulik added a comment. Don't you also need to remove the cpp stuff from CMakeLists and what not? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
broulik added a comment. BUG: 377213 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
broulik added a comment. Cool! INLINE COMMENTS > main.qml:57 > +tasksModel.requestToggleMinimized(idx); > +clients.push(tasksModel.makePeristentModelndex(i)); > +} typo REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
davidedmundson updated this revision to Diff 25753. davidedmundson added a comment. Debug-- REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10019?vs=25752=25753 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml applets/minimizeall/plugin/minimizeall.cpp applets/minimizeall/plugin/minimizeall.h applets/minimizeall/plugin/minimizeallplugin.cpp applets/minimizeall/plugin/minimizeallplugin.h applets/minimizeall/plugin/qmldir To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This reduces the code we have and implicitly fixes it under wayland. Tracking of which windows are minimised by us is now done in JS, and through use of model indexes instead of X window IDs, which wouldn't really have worked under wayland. Potentially we may have some minor behavioural differences on X with regards to which windows are managed, as the old code did not skip those with skip_taskmanager. Requires a tiny patch in libtaskmanager to export persistentmodelindexes to QML. TEST PLAN Under wayland: Had 3 windows, one minimised already Clicked button. All minimised. Clicked again, two restored REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019 AFFECTED FILES applets/minimizeall/package/contents/ui/main.qml applets/minimizeall/plugin/minimizeall.cpp applets/minimizeall/plugin/minimizeall.h applets/minimizeall/plugin/minimizeallplugin.cpp applets/minimizeall/plugin/minimizeallplugin.h applets/minimizeall/plugin/qmldir To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
