D10118: Disable keyboard geometry preview code
bshah planned changes to this revision. bshah added a comment. That said I've better idea.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
bshah added a comment. In https://phabricator.kde.org/D10118#196823, @davidedmundson wrote: > > it is not clear if this code is functional at this moment or not > > I'm -1 for disabling if the change is based on a false premise that it doesn't work. No, this change is not proposed because I was not sure if is functional or not, but due to reason that it breaks my development workflow and probably for others as well.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
hein added a comment. In https://phabricator.kde.org/D10118#196820, @sitter wrote: > In https://phabricator.kde.org/D10118#196532, @anthonyfieroni wrote: > > > I believe that port away from boost will fix the problem > > > IIRC the problem isn't with boost at large, it's that the code uses insanely deep recursive templates. Yeah: # # the default maximum template expansion depth (256) is not enough # set_property(SOURCE preview/geometry_parser.cpp APPEND_STRING PROPERTY COMPILE_FLAGS " -ftemplate-depth=512") REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
davidedmundson added a comment. > it is not clear if this code is functional at this moment or not I'm -1 for disabling if the change is based on a false premise that it doesn't work. Is it something you've already lost several hours into trying to fix? If so this proposal has a lot more merit. If it is to be disabled, commenting something out when it's already in an if() block is not a good approach. Also any hacks always always need a code comment. - FWIW: ktouch has it's own layout parser / preview code. It does update between UK and french and move the preview with the letters about, but switching to arabic returns an error, whereas the kcm preview works fine. Probably would need layer support too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
sitter added a comment. In https://phabricator.kde.org/D10118#196532, @anthonyfieroni wrote: > I believe that port away from boost will fix the problem IIRC the problem isn't with boost at large, it's that the code uses insanely deep recursive templates. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: sitter, ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
hein added a comment. This looks up my PC several times a week. I lose work regularly because of it, and often can't finish compiling plasma-desktop successfully. I'm very +1 for killing it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: ngraham, hein, broulik, graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
graesslin added a comment. I never had noticed any problems when compiling the code. Could it be that the CI system changed (e.g. newer compiler?) I would find it sad to lose this very useful feature (which might in fact not be exposed enough) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: graesslin, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
davidedmundson added a comment. > I can't find anything related to preview on my Arch Linux default Arch kcm -> layouts -> add layout -> preview REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
bshah updated this revision to Diff 26004. bshah added a comment. add bug in message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10118?vs=26002=26004 BRANCH bshah/disable-geometry REVISION DETAIL https://phabricator.kde.org/D10118 AFFECTED FILES kcms/keyboard/CMakeLists.txt To: bshah, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY it is not clear if this code is functional at this moment or not, given I can't find anything related to preview on my Arch Linux default Arch Linux, but nevertheless, this code is disabled due to another reason This code makes C++ compiler OOM even with 16GB of RAM, In my opinion this is simply not acceptable, there are multiple build jobs failed on both KDE CI and KDE Neon CI. If someone wants to re-enable this code, it needs to be optimized so that it doesn't bring down full-fledged CI server nodes.. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH bshah/disable-geometry REVISION DETAIL https://phabricator.kde.org/D10118 AFFECTED FILES kcms/keyboard/CMakeLists.txt To: bshah, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10118: Disable keyboard geometry preview code
anthonyfieroni added a comment. I believe that port away from boost will fix the problem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10118 To: bshah, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
