D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi added a dependent revision: D10305: Framework patch: Moving the mouse 
over a different application icon immediately changes the window list.

REVISION DETAIL
  https://phabricator.kde.org/D10304

To: lshoravi, #plasma, #plasma_accessibility
Cc: ngraham, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for doing this! A few notes:
  
  - Put "BUG: 358930" on its own line in the Summary; this will cause that bug 
to get closed once this goes in.
  - Put "Depends on https://phabricator.kde.org/D10305; on its own line in the 
Summary to mark that this patch requires the changes introduced in that other 
one.
  - No need to mention the bug number in the title (which becomes the commit 
message).
  - You'll want to mark Réne as the author; to do this, first do `git commit 
--amend --author=" René Fürst "` and then `arc diff` to update 
the diff.

REVISION DETAIL
  https://phabricator.kde.org/D10304

To: lshoravi, #plasma, #plasma_accessibility
Cc: ngraham, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Anthony Fieroni
anthonyfieroni added a comment.


  You should increase minimal required plasma-framework version to 5.44 but 
when you do this this patch goes to master i.e. 5.13.

REVISION DETAIL
  https://phabricator.kde.org/D10304

To: lshoravi, #plasma, #plasma_accessibility
Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10304

To: lshoravi, #plasma, #plasma_accessibility
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10304

To: lshoravi, #plasma, #plasma_accessibility
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi created this revision.
lshoravi added reviewers: Plasma, Plasma Accessibility.
lshoravi added a project: Plasma Accessibility.
Restricted Application edited projects, added Plasma; removed Plasma 
Accessibility.
Restricted Application added a subscriber: plasma-devel.
lshoravi requested review of this revision.

REVISION SUMMARY
  Submitting Renées patch for bug 358930, as I can't find it here.
  
  https://bugs.kde.org/show_bug.cgi?id=358930

TEST PLAN
  - Review patches

REVISION DETAIL
  https://phabricator.kde.org/D10304

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

To: lshoravi, #plasma, #plasma_accessibility
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart