D10342: From 100% plasma cpu usage to normal when using vivaldi

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D10342#286360 , @jtamate wrote:
  
  > Or perhaps is it better to try to create that cache in KServiceTypeTrader?
  
  
  That will be the right place, reading from disk is always costly, it will be 
better to make service parsing on file changes otherwise to read from cache.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces, hein
Cc: anthonyfieroni, mart, mwolff, broulik, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10342: From 100% plasma cpu usage to normal when using vivaldi

[Jaime Torres Amate]

jtamate added a comment.


  In D10342#286023 , @hein wrote:
  
  > This patch doesn't make any sense. It's setting up a cache for something 
computed from data that's subject to change, and it's never evicting it when 
that data changes.
  
  
  To make it right, should it also be wiped in 
XWindowTasksModel::Private::windowChanged?
  Or perhaps is it better to try to create that cache in KServiceTypeTrader?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces, hein
Cc: mart, mwolff, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10342: From 100% plasma cpu usage to normal when using vivaldi

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  This patch doesn't make any sense. It's setting up a cache for something 
computed from data that's subject to change, and it's never evicting it when 
that data changes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces, hein
Cc: mart, mwolff, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D10342: From 100% plasma cpu usage to normal when using vivaldi

[Jaime Torres Amate]

jtamate updated this revision to Diff 36978.
jtamate retitled this revision from "From 1.03% to 0.08% cpu usage moving 
50.000 files" to "From 100% plasma cpu usage to normal when using vivaldi".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Implement only the windowUrlFromMetadata cache.
  It avoids a 100% plasma cpu usage when using vivaldi in private navigation.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10342?vs=27177=36978

REVISION DETAIL
  https://phabricator.kde.org/D10342

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: jtamate, #plasma_workspaces, hein
Cc: mart, mwolff, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol