D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

2018-03-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:be06f0b74073: Allow users to change the format to BCD 
(decimal) in Binary Clock widget (authored by piotrkakol, committed by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10434?vs=27024=28945#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10434?vs=27024=28945

REVISION DETAIL
  https://phabricator.kde.org/D10434

AFFECTED FILES
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

2018-03-07 Thread Piotr Kąkol
piotrkakol added a comment.


  I was instructed to give my contact details that will be included in the 
commit message.
  Piotr Kąkol piotrka...@pm.me

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

2018-02-19 Thread Piotr Kąkol
piotrkakol added a comment.


  Thank you for reviewing.
  
  No, I don't have commit access.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

2018-02-19 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Do you have commit access?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

2018-02-12 Thread Piotr Kąkol
piotrkakol updated this revision to Diff 27024.
piotrkakol retitled this revision from "Changed hexadecimal system to decimal 
for Binary Clock widget" to "Allow users to change the format to BCD (decimal) 
in Binary Clock widget".
piotrkakol edited the summary of this revision.
piotrkakol added a comment.


  Instead of changing the base to decimal I decided to allow users to choose 
between base 10 (BCD format) and 16 (sexagesimal format) in the config.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10434?vs=26898=27024

REVISION DETAIL
  https://phabricator.kde.org/D10434

AFFECTED FILES
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: piotrkakol
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart